profile
viewpoint
Fernando Serrano fernandojsg @mozilla Spain http://fernandojsg.com full stack, computer graphics, WebGL, WebXR

aframevr/a-painter 514

🎨 Paint in VR in your browser.

aframevr/aframe-inspector 449

:mag: Visual inspector tool for A-Frame. Hit *<ctrl> + <alt> + i* on any A-Frame scene.

fernandojsg/aframe-teleport-controls 121

A-Frame teleport controls component

aframevr/a-blast 98

💥 Save the World From the Cutest Creatures in the Universe!

aframevr/aframe-registry 72

[DISCONTINUED] Curated collection of community A-Frame components.

aframevr/a-saturday-night 54

💃🏼 Record and share your dance moves with motion capture in WebVR.

fernandojsg/aframe-camera-transform-controls-component 46

Camera transform controls component for A-Frame

fernandojsg/aframe-slice9-component 21

A-Frame slice9 component

fernandojsg/aframe-tooltip-component 14

A-Frame tooltip component

pull request commentmrdoob/three.js

Package.json: Removed npm start, dev and dev-test.

I would say dev-test can be removed.

@fernandojsg Are you fine with this?

Yep, I've never used dev-test just dev

mrdoob

comment created time in 12 hours

pull request commentmrdoob/three.js

Package.json: Removed npm start, dev and dev-test.

😢

mrdoob

comment created time in 15 hours

issue commentMozillaReality/webgfx-tests

Mic permission prompt blocks automatic testing

I don't remember exactly how it works without the incognito mode, I guess it will just run your default profile right? If so, we should at least create a new profile, I believe that was the initial approach, as otherwise your profile could affect the benchmark, for example if you have extensions installed or so

takahirox

comment created time in 10 days

issue commentecsyjs/ecsy-devtools

Please link to the Chrome and Firefox extensions in the readme

Thanks for the suggestion. Fixed!

triptych

comment created time in a month

push eventecsyjs/ecsy-devtools

Fernando Serrano

commit sha 0f4086e95d727ce0d568fa05200122617589861c

Fixes #69 Link to the chrome and firefox stores

view details

push time in a month

issue closedecsyjs/ecsy-devtools

Please link to the Chrome and Firefox extensions in the readme

The Chrome and Firefox extensions are mentioned in the blog, but nowhere in the readme. Please add them.

https://blog.mozvr.com/ecsy-developer-tools/ https://chrome.google.com/webstore/detail/ecsy-devtools/cdmidpfffmlibnnbhkfbobpghgfmhdhk

https://addons.mozilla.org/en-US/firefox/addon/ecsy-devtools/

closed time in a month

triptych

issue openedecsyjs/ecsy

Integrate version.js in the build system

So we don't forget to update https://github.com/ecsyjs/ecsy/blob/dev/src/Version.js when building a new release

created time in 2 months

push eventecsyjs/ecsy-devtools

Fernando Serrano

commit sha 9571587bf04762b1dcff2c819afe92f236dd1b58

Fix issue with pool

view details

push time in 2 months

issue commentecsyjs/ecsy-devtools

Registering a component with pooling disabled causes errors

@vegeta897 I just fixed the pool issue, I pushed v0.1.4 to the addons store in firefox and I tried your examples and it works. Can you please verify it too?

vegeta897

comment created time in 2 months

startedspite/nonocache-sw.js

started time in 2 months

issue commentecsyjs/ecsy-devtools

Version 0.1.2 Broken in Chrome and Firefox (missing index.html?)

@vegeta897 @briancw @robertlong could you please give it a try in firefox https://addons.mozilla.org/en-US/firefox/addon/ecsy-devtools/ I just pushed a new release, it will be soon available also on chrome but the review process is a bit longer there. Thanks!

vegeta897

comment created time in 2 months

startedgit-tips/tips

started time in 2 months

issue closedMozilla-Games/emunittest

Can we delete filelock folder?

I was trying to find any reference to filelock within the code but I didn't find anything, in fact if I delete the whole folder and run the server it seems to work as expected. Maybe is from some legacy code?

closed time in 2 months

fernandojsg

delete branch fernandojsg/three.js

delete branch : hapt

delete time in 2 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 498fb643acbd1adb0f3356f34c1e6ca45bec07e9

0.4.1

view details

push time in 2 months

pull request commentMozillaReality/ecsy

Fix Entity type definition

@simonihmig pushed 0.4.1 please check it if it works correctly for you :)

pirelenito

comment created time in 2 months

release MozillaReality/ecsy

v0.4.1

released time in 2 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha f914921124b27efd0295af177bdd9982ac7d3598

Updates

view details

push time in 2 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 498fb643acbd1adb0f3356f34c1e6ca45bec07e9

0.4.1

view details

push time in 2 months

created tagMozillaReality/ecsy

tagv0.4.1

Entity Component System for javascript

created time in 2 months

push eventMozillaReality/ecsy

dependabot[bot]

commit sha 25c9a04219a3b1d013b21a01814ec02286d1d8f2

Bump prismjs from 1.17.1 to 1.21.0 Bumps [prismjs](https://github.com/PrismJS/prism) from 1.17.1 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](https://github.com/PrismJS/prism/compare/v1.17.1...v1.21.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Paulo Ragonha

commit sha d577ea096c862aceda375c3d0f6f25da05a0b004

Fix Entity type definition This seems to have been accidentally introduced recently, but it is my understanding that we want the return of the function to be optional, and not the function itself. It could also been my erroneous interpretation.

view details

Fernando Serrano

commit sha 7795dc02cef72b4b8af80275b06a8ff8e84547da

Merge pull request #243 from MozillaReality/dependabot/npm_and_yarn/prismjs-1.21.0 Bump prismjs from 1.17.1 to 1.21.0

view details

David Peicho

commit sha 7596fa9ec7f49e1cb9c25bf30ccc57292f21d3be

types: system: add as readonly attribute

view details

Fernando Serrano

commit sha 2a8bfeba1260dc91512e27fa8cbc5e84b759beab

Merge pull request #252 from DavidPeicho/fix/ts-system-priority System.d.ts: add `priority` as readonly attribute

view details

Fernando Serrano

commit sha c9c7f8009ea2102533c784c5bc25cff0143e56f0

Merge pull request #244 from pirelenito/fix-entity-type-definition Fix Entity type definition

view details

Fernando Serrano

commit sha 2dbe7c58e4cf7c919f743cd3ca2b5beb91cf2ab1

0.4.0

view details

push time in 2 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 2dbe7c58e4cf7c919f743cd3ca2b5beb91cf2ab1

0.4.0

view details

push time in 2 months

push eventMozillaReality/ecsy

Paulo Ragonha

commit sha d577ea096c862aceda375c3d0f6f25da05a0b004

Fix Entity type definition This seems to have been accidentally introduced recently, but it is my understanding that we want the return of the function to be optional, and not the function itself. It could also been my erroneous interpretation.

view details

Fernando Serrano

commit sha c9c7f8009ea2102533c784c5bc25cff0143e56f0

Merge pull request #244 from pirelenito/fix-entity-type-definition Fix Entity type definition

view details

push time in 2 months

PR merged MozillaReality/ecsy

Fix Entity type definition types

This seems to have been accidentally introduced recently, but it is my understanding that we want the return of the function to be optional, and not the function itself.

It could also been my erroneous interpretation.

+6 -6

1 comment

1 changed file

pirelenito

pr closed time in 2 months

push eventMozillaReality/ecsy

David Peicho

commit sha 7596fa9ec7f49e1cb9c25bf30ccc57292f21d3be

types: system: add as readonly attribute

view details

Fernando Serrano

commit sha 2a8bfeba1260dc91512e27fa8cbc5e84b759beab

Merge pull request #252 from DavidPeicho/fix/ts-system-priority System.d.ts: add `priority` as readonly attribute

view details

push time in 2 months

delete branch fernandojsg/hubs

delete branch : feature/anchor-spawnpoint

delete time in 2 months

push eventfernandojsg/tankball

Fernando Serrano

commit sha 3be9c145423c21b8b14c0c84e661bb714e3456db

Update README.md

view details

push time in 2 months

push eventfernandojsg/guitareditor.js

Fernando Serrano

commit sha 38598710b6b0be75328f12c05f0669affc10361b

Update README.md

view details

push time in 2 months

startedemoon/minifb

started time in 2 months

startedNamek/js13k_2019

started time in 2 months

push eventfernandojsg/hubs

Fernando Serrano

commit sha 7a506e36d25fa2b29d292d9f468a69423490d252

Add preference for animate waypoint transitions

view details

push time in 3 months

pull request commentmozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

@johnshaughnessy thanks for the comments, addressed the issues, ready for another shot :)

fernandojsg

comment created time in 3 months

Pull request review commentmozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

 export class WaypointSystem {       this.waitOneTick = false;       return;     }++    const hashUpdated = window.location.hash !== "" && this.previousWaypointHash !== window.location.hash;++    if (hashUpdated && this.initialSpawnHappened) {+      this.previousWaypointHash = window.location.hash;+      const spawnPointName = window.location.hash.replace("#", "");+      const spawnPoint = this.ready.find(c => c.el.className === spawnPointName);+      if (spawnPoint) {+        this.occupySpawnPoint(spawnPoint);+        this.currentMoveToSpawn = null;+        this.currentMoveToSpawnResolve = null;+        this.nextMoveToSpawn = null;+        this.nextMoveToSpawnResolve = null;+      }+    }+     if (!this.currentMoveToSpawn && this.nextMoveToSpawn) {+      this.initialSpawnHappened = true;

Done! thanks

fernandojsg

comment created time in 3 months

Pull request review commentmozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

 export class WaypointSystem {       this.waitOneTick = false;       return;     }++    const hashUpdated = window.location.hash !== "" && this.previousWaypointHash !== window.location.hash;++    if (hashUpdated && this.initialSpawnHappened) {+      this.previousWaypointHash = window.location.hash;+      const spawnPointName = window.location.hash.replace("#", "");+      const spawnPoint = this.ready.find(c => c.el.className === spawnPointName);+      if (spawnPoint) {+        this.occupySpawnPoint(spawnPoint);+        this.currentMoveToSpawn = null;+        this.currentMoveToSpawnResolve = null;+        this.nextMoveToSpawn = null;+        this.nextMoveToSpawnResolve = null;

With the current flow it won't conflict as the initial spawn will happen and I'll just resolve the hashtag later. I have removed all the nulls anyway as they were not affecting it

fernandojsg

comment created time in 3 months

Pull request review commentmozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

 export class WaypointSystem {       this.waitOneTick = false;       return;     }++    const hashUpdated = window.location.hash !== "" && this.previousWaypointHash !== window.location.hash;++    if (hashUpdated && this.initialSpawnHappened) {+      this.previousWaypointHash = window.location.hash;+      const spawnPointName = window.location.hash.replace("#", "");+      const spawnPoint = this.ready.find(c => c.el.className === spawnPointName);

spawnPoint/spawnPointName -> waypoint/waypointName

Renamed, makes more sense indeed, thanks!

I wonder whether there's any difference between c.el.object3D.name and c.el.className. I think the object3D.name matches what's in spoke and the gltf -- I didn't know/realize that the entity's className matched this as well. Not sure if that's always the case (e.g. if something else modifies an entity's classList)

Yeah I was surprised also that it matches so I thought it was something specific from hubs. In any case I changed it to use object3D.name which makes feels more safe.

fernandojsg

comment created time in 3 months

push eventfernandojsg/hubs

Fernando Serrano

commit sha bc28ba3447ac9959edfd4bb33940a7a4ef9f97a4

Use object3d.name instead of className

view details

push time in 3 months

Pull request review commentmozilla/hubs

Add support to specify a spawn point name on the url with an anchor hash

 export class WaypointSystem {     }     return this.nextMoveToSpawn;   }+  occupySpawnPoint(waypointComponent) {

Addressed that and refactored both functions as they are pretty much the same just changing the instant, that now is a parameter to moveToWaypoint

fernandojsg

comment created time in 3 months

push eventfernandojsg/hubs

Fernando Serrano

commit sha 4749fd84bd229d00f7196dafc17af50930953ba4

Fix naming on SpawnPoint/Waypoint and move initialSpawnHappened inside the promise

view details

Fernando Serrano

commit sha 0854437659ba8581e64d5a7a7e2f1e07ccc1d4c8

Refactor moveToWaypoint to add instant parameter

view details

Fernando Serrano

commit sha 848ad0e6a04322e2dcaf3a8920ddeaa3a5dff4b9

Animated jumping when using hashtag

view details

push time in 3 months

Pull request review commentmozilla/hubs

Fixes #2833 adding support to specify a spawn point name on the url

 export class WaypointSystem {       this.waitOneTick = false;       return;     }++    const hashUpdated = window.location.hash !== "" && this.previousWaypointHash !== window.location.hash;++    if (hashUpdated && this.initialSpawnHappened) {

I introduced initialSpawnHappened as once you enter the scene, async, moveToSpawnPoint will get called and it will override the hash location that will be set otherwise on the first tick after detecting the new hash

fernandojsg

comment created time in 3 months

PR opened mozilla/hubs

Fixes #2833 adding support to specify a spawn point name on the url

It adds support to define the spawn point where you want to start, but it also lets you change it dynamically without refreshing the page. The format is url#[spawn_point_name] for example in the default room you could try:

https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_1
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_2
https://localhost:8080/hub.html?hub_id=XXX#Spawn_Point_3

If the name of the spawn point doesn't exist it will just follow the standard flow and it will spawn you at a random point.

Fixes #2833

+31 -8

0 comment

1 changed file

pr created time in 3 months

create barnchfernandojsg/hubs

branch : feature/anchor-spawnpoint

created branch time in 3 months

issue openedmozilla/hubs

Specify anchor link for spawn points

Is your feature request related to a problem? Please describe. It could be nice to be able to define a preferred spawn point to start for multiple reasons, one of my current use cases is to be able to run benchmarks and testing consistently so the user appears always at the same spot.

Describe the solution you'd like I have a working solution by implementing a occupySpawnPoint(waypoint) to be called before the default tryToOcuppyAnyOf (https://github.com/mozilla/hubs/blob/master/src/systems/waypoint-system.js#L336) if we provide a hash tag and it can be dynamically detected so we can change it at runtime too. If the spawn point name is not found, it will just follow the standard flow and will assign a random point.

Here is a video testing it: https://streamable.com/taxasv

Partially discussed too in https://github.com/mozilla/hubs/issues/2667

created time in 3 months

issue closedMozillaReality/ecsy-three

Double deletion caused by obj.traverse

The following line causes EntityManager.removeEntity to be called twice for an entity that has an Object3D when it is deleted.

https://github.com/MozillaReality/ecsy-three/blob/13127cb0281b4070c5f3ad6b1dd7d4a09e2cf349/src/entity.js#L150

The first invoke of the traverse function will be with the object itself, which calls removeEntity; then the end of the remove function, removeEntity is called again. (Relevant ThreeJS docs: https://threejs.org/docs/index.html#api/en/core/Object3D.traverse)

This was causing

Uncaught Error: Tried to remove entity not in list

in the console.

Adding a self check in the traverse function to prevent the removeEntity call should fix that particular issue.

closed time in 3 months

sam6321

issue commentMozillaReality/ecsy-three

Double deletion caused by obj.traverse

Thanks! merged

sam6321

comment created time in 3 months

push eventMozillaReality/ecsy-three

Samuel

commit sha ba2f1a1299d3288b0c849af20eae60fe3576c4fb

Prevent double removeEntity call caused by obj.traverse https://github.com/MozillaReality/ecsy-three/issues/28 Prevents removeEntity from being called two times when remove is called on an entity.

view details

Samuel

commit sha 1dedec84f76261830c4457c954eb66722b2cf06a

Update entity.js Move check outside of traverse callback

view details

Fernando Serrano

commit sha 933442ddc65ec8c9d3540fc1ecf74c85f9b72e80

Merge pull request #29 from sam6321/patch-1 Prevent double removeEntity call caused by obj.traverse

view details

push time in 3 months

PR merged MozillaReality/ecsy-three

Prevent double removeEntity call caused by obj.traverse

https://github.com/MozillaReality/ecsy-three/issues/28

Prevents removeEntity from being called two times when remove is called on an entity.

+3 -1

0 comment

1 changed file

sam6321

pr closed time in 3 months

startedmaierfelix/webgpu

started time in 3 months

issue commentMozillaReality/ecsy-three

Double deletion caused by obj.traverse

Nice catch @sam6321 Although I believe it's better to just include an else if there is no Object3DComponent so there is not need to check the obj != o on every object we traverse:

   if (this.hasComponent(Object3DComponent)) {
      const obj = this.getObject3D();
      obj.traverse((o) => {
        if (o.entity) {
          this._entityManager.removeEntity(o.entity, forceImmediate);
        }
        o.entity = null;
      });
      obj.parent && obj.parent.remove(obj);
    } else {
      this._entityManager.removeEntity(this, forceImmediate);
   }
sam6321

comment created time in 3 months

push eventMozillaReality/ecsy

dependabot[bot]

commit sha 25c9a04219a3b1d013b21a01814ec02286d1d8f2

Bump prismjs from 1.17.1 to 1.21.0 Bumps [prismjs](https://github.com/PrismJS/prism) from 1.17.1 to 1.21.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](https://github.com/PrismJS/prism/compare/v1.17.1...v1.21.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

Fernando Serrano

commit sha 7795dc02cef72b4b8af80275b06a8ff8e84547da

Merge pull request #243 from MozillaReality/dependabot/npm_and_yarn/prismjs-1.21.0 Bump prismjs from 1.17.1 to 1.21.0

view details

push time in 3 months

PR merged MozillaReality/ecsy

Bump prismjs from 1.17.1 to 1.21.0 dependencies

Bumps prismjs from 1.17.1 to 1.21.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/releases">prismjs's releases</a>.</em></p> <blockquote> <h2>v1.21.0</h2> <p>Release 1.21.0</p> <h2>v1.20.0</h2> <p>Release 1.20.0</p> <h2>v1.19.0</h2> <p>Release 1.19.0</p> <h2>v1.18.0</h2> <p>Release 1.18.0</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/PrismJS/prism/blob/master/CHANGELOG.md">prismjs's changelog</a>.</em></p> <blockquote> <h2>1.21.0 (2020-08-06)</h2> <h3>New components</h3> <ul> <li><strong>.ignore</strong> & <strong>.gitignore</strong> & <strong>.hgignore</strong> & <strong>.npmignore</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2481">#2481</a>) <a href="https://github.com/PrismJS/prism/commit/3fcce6fe"><code>3fcce6fe</code></a></li> <li><strong>Agda</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2430">#2430</a>) <a href="https://github.com/PrismJS/prism/commit/3a127c7d"><code>3a127c7d</code></a></li> <li><strong>AL</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2300">#2300</a>) <a href="https://github.com/PrismJS/prism/commit/de21eb64"><code>de21eb64</code></a></li> <li><strong>Cypher</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2459">#2459</a>) <a href="https://github.com/PrismJS/prism/commit/398e2943"><code>398e2943</code></a></li> <li><strong>Dhall</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2473">#2473</a>) <a href="https://github.com/PrismJS/prism/commit/649e51e5"><code>649e51e5</code></a></li> <li><strong>EditorConfig</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2471">#2471</a>) <a href="https://github.com/PrismJS/prism/commit/ed8fff91"><code>ed8fff91</code></a></li> <li><strong>HLSL</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2318">#2318</a>) <a href="https://github.com/PrismJS/prism/commit/87a5c7ae"><code>87a5c7ae</code></a></li> <li><strong>JS stack trace</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2418">#2418</a>) <a href="https://github.com/PrismJS/prism/commit/ae0327b3"><code>ae0327b3</code></a></li> <li><strong>PeopleCode</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2302">#2302</a>) <a href="https://github.com/PrismJS/prism/commit/bd4d8165"><code>bd4d8165</code></a></li> <li><strong>PureBasic</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2369">#2369</a>) <a href="https://github.com/PrismJS/prism/commit/d0c1c70d"><code>d0c1c70d</code></a></li> <li><strong>Racket</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2315">#2315</a>) <a href="https://github.com/PrismJS/prism/commit/053016ef"><code>053016ef</code></a></li> <li><strong>Smali</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2419">#2419</a>) <a href="https://github.com/PrismJS/prism/commit/22eb5cad"><code>22eb5cad</code></a></li> <li><strong>Structured Text (IEC 61131-3)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2311">#2311</a>) <a href="https://github.com/PrismJS/prism/commit/8704cdfb"><code>8704cdfb</code></a></li> <li><strong>UnrealScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2305">#2305</a>) <a href="https://github.com/PrismJS/prism/commit/1093ceb3"><code>1093ceb3</code></a></li> <li><strong>WarpScript</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2307">#2307</a>) <a href="https://github.com/PrismJS/prism/commit/cde5b0fa"><code>cde5b0fa</code></a></li> <li><strong>XML doc (.net)</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2340">#2340</a>) <a href="https://github.com/PrismJS/prism/commit/caec5e30"><code>caec5e30</code></a></li> <li><strong>YANG</strong> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2467">#2467</a>) <a href="https://github.com/PrismJS/prism/commit/ed1df1e1"><code>ed1df1e1</code></a></li> </ul> <h3>Updated components</h3> <ul> <li>Markup & JSON: Added new aliases (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2390">#2390</a>) <a href="https://github.com/PrismJS/prism/commit/9782cfe6"><code>9782cfe6</code></a></li> <li>Fixed several cases of exponential backtracking (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2268">#2268</a>) <a href="https://github.com/PrismJS/prism/commit/7a554b5f"><code>7a554b5f</code></a></li> <li><strong>APL</strong> <ul> <li>Added <code>⍥</code> (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2409">#2409</a>) <a href="https://github.com/PrismJS/prism/commit/0255cb6a"><code>0255cb6a</code></a></li> </ul> </li> <li><strong>AutoHotkey</strong> <ul> <li>Added missing <code>format</code> built-in (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2450">#2450</a>) <a href="https://github.com/PrismJS/prism/commit/7c66cfc4"><code>7c66cfc4</code></a></li> <li>Improved comments and other improvements (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2412">#2412</a>) <a href="https://github.com/PrismJS/prism/commit/ddf3cc62"><code>ddf3cc62</code></a></li> <li>Added missing definitions (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2400">#2400</a>) <a href="https://github.com/PrismJS/prism/commit/4fe03676"><code>4fe03676</code></a></li> </ul> </li> <li><strong>Bash</strong> <ul> <li>Added <code>composer</code> command (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2298">#2298</a>) <a href="https://github.com/PrismJS/prism/commit/044dd271"><code>044dd271</code></a></li> </ul> </li> <li><strong>Batch</strong> <ul> <li>Fix escaped double quote (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2485">#2485</a>) <a href="https://github.com/PrismJS/prism/commit/f0f8210c"><code>f0f8210c</code></a></li> </ul> </li> <li><strong>C</strong> <ul> <li>Improved macros and expressions (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2440">#2440</a>) <a href="https://github.com/PrismJS/prism/commit/8a72fa6f"><code>8a72fa6f</code></a></li> <li>Improved macros (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2320">#2320</a>) <a href="https://github.com/PrismJS/prism/commit/fdcf7ed2"><code>fdcf7ed2</code></a></li> </ul> </li> <li><strong>C#</strong> <ul> <li>Improved pattern matching (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2411">#2411</a>) <a href="https://github.com/PrismJS/prism/commit/7f341fc1"><code>7f341fc1</code></a></li> <li>Fixed adjacent string interpolations (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2402">#2402</a>) <a href="https://github.com/PrismJS/prism/commit/2a2e79ed"><code>2a2e79ed</code></a></li> </ul> </li> <li><strong>C++</strong> <ul> <li>Added support for default comparison operator (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2426">#2426</a>) <a href="https://github.com/PrismJS/prism/commit/8e9d161c"><code>8e9d161c</code></a></li> <li>Improved class name detection (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2348">#2348</a>) <a href="https://github.com/PrismJS/prism/commit/e3fe9040"><code>e3fe9040</code></a></li> <li>Fixed <code>enum class</code> class names (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2342">#2342</a>) <a href="https://github.com/PrismJS/prism/commit/30b4e254"><code>30b4e254</code></a></li> </ul> </li> <li><strong>Content-Security-Policy</strong> <ul> <li>Fixed directives (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2461">#2461</a>) <a href="https://github.com/PrismJS/prism/commit/537a9e80"><code>537a9e80</code></a></li> </ul> </li> <li><strong>CSS</strong> <ul> <li>Improved url and added keywords (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2432">#2432</a>) <a href="https://github.com/PrismJS/prism/commit/964de5a1"><code>964de5a1</code></a></li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/PrismJS/prism/commit/187c8a607ee70c7914682870156faa31ed01f001"><code>187c8a6</code></a> 1.21.0</li> <li><a href="https://github.com/PrismJS/prism/commit/bf4f323391d546d4b2e1a388f05c512a27491e9c"><code>bf4f323</code></a> Changelog for v1.21.0 (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2507">#2507</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/8bba4880202ef6bd7a1e379fe9aebe69dd75f7be"><code>8bba488</code></a> Previewers: Fixed XSS (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2506">#2506</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/158caf52343e59a66c2351ff1d83648efe871e33"><code>158caf5</code></a> JSON: Greedy comments (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2479">#2479</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/f0f8210c1a9745c064d49bfb985544c654986b24"><code>f0f8210</code></a> Batch: Fix escaped double quote (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2485">#2485</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/649e51e56250a81dc0b0c4f5b3a4ea23e1c21834"><code>649e51e</code></a> Added support for Dhall (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2473">#2473</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/453079bf96746e0c44f90cb7cd90fcae9a5f94cc"><code>453079b</code></a> Line Numbers: Fixed class name on website</li> <li><a href="https://github.com/PrismJS/prism/commit/a0efa40bde420ac3923947be611ebe6b3f077dce"><code>a0efa40</code></a> Fixed Treeview page (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2484">#2484</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/78161d607fe7d493831ff19759aac951330134a1"><code>78161d6</code></a> VB: Added VBA alias (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2469">#2469</a>)</li> <li><a href="https://github.com/PrismJS/prism/commit/ed1df1e1208401a8b84330ecc39689fa37d0e9f6"><code>ed1df1e</code></a> Added support for YANG (<a href="https://github-redirect.dependabot.com/PrismJS/prism/issues/2467">#2467</a>)</li> <li>Additional commits viewable in <a href="https://github.com/PrismJS/prism/compare/v1.17.1...v1.21.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

create barnchfernandojsg/hubs

branch : hackathon

created branch time in 3 months

startedkaliber5/ember-ecsy-babylon

started time in 3 months

startedmacaco-maluco/thermal-runway

started time in 3 months

push eventMozillaReality/ecsy-three

Fernando Serrano

commit sha 35721969e191c57967640e5c81c1d89da211400b

Bump version to 0.1.0

view details

Fernando Serrano

commit sha 86a5b2b7b62672d950be51a963f6d8e7aceef024

0.1.1

view details

Fernando Serrano

commit sha ddc10fdbd42f3fa696c9b986213b92a8f6b46684

Fix gh-pages

view details

Fernando Serrano

commit sha 13127cb0281b4070c5f3ad6b1dd7d4a09e2cf349

Add eslint-import for .js extensions

view details

push time in 3 months

created tagMozillaReality/ecsy-three

tagv0.1.2

ECSY and three.js components, systems and helpers

created time in 3 months

release MozillaReality/ecsy-three

v0.1.2

released time in 3 months

push eventMozillaReality/ecsy-three

Fernando Serrano

commit sha 13127cb0281b4070c5f3ad6b1dd7d4a09e2cf349

Add eslint-import for .js extensions

view details

push time in 3 months

push eventMozillaReality/ecsy-three

Fernando Serrano

commit sha 3b019264b12042678acf59e8507c0738f38269ac

Fix system.d.ts

view details

Fernando Serrano

commit sha ebeea9b115dae906a4093f3e4629316f8765e76c

Merge pull request #26 from MozillaReality/fixsystem Fix system.d.ts

view details

Fernando Serrano

commit sha 35721969e191c57967640e5c81c1d89da211400b

Bump version to 0.1.0

view details

Fernando Serrano

commit sha 86a5b2b7b62672d950be51a963f6d8e7aceef024

0.1.1

view details

Fernando Serrano

commit sha ddc10fdbd42f3fa696c9b986213b92a8f6b46684

Fix gh-pages

view details

push time in 3 months

push eventMozillaReality/ecsy-three

Fernando Serrano

commit sha e8427436d4bb2b0daa030bbba18b5fb46d45dca5

Updates

view details

push time in 3 months

created tagMozillaReality/ecsy-three

tagv0.1.1

ECSY and three.js components, systems and helpers

created time in 3 months

release MozillaReality/ecsy-three

v0.1.1

released time in 3 months

push eventMozillaReality/ecsy-three

Fernando Serrano

commit sha 3b019264b12042678acf59e8507c0738f38269ac

Fix system.d.ts

view details

Fernando Serrano

commit sha ebeea9b115dae906a4093f3e4629316f8765e76c

Merge pull request #26 from MozillaReality/fixsystem Fix system.d.ts

view details

push time in 3 months

PR opened MozillaReality/ecsy-three

Fix system.d.ts
+2 -2

0 comment

1 changed file

pr created time in 3 months

create barnchMozillaReality/ecsy-three

branch : fixsystem

created branch time in 3 months

push eventMozillaReality/ecsy-three

Robert Long

commit sha 022e8b794c75a0055ceb0f68083b3028f0548171

Export ECSYThreeObject3D and ECSYThreeEntity types

view details

Robert Long

commit sha 8acf089fd3c48f00b28e1df6fbdfee628e080bf3

addObject3DComponent, removeObject3DComponent, remove optional arguments

view details

Fernando Serrano

commit sha c09a05c1ac6890b64e5b9aa207dde2ef4950611c

Merge pull request #16 from MozillaReality/fix-typescript-defs-2 Fix some typescript definitions

view details

Robert Long

commit sha 60d57153ceae8766aab96793b6cf7af5fbe986d0

getObject3D should handle returning null

view details

Robert Long

commit sha cae026e0e68840c1e4cf9e7e391076ce7629f509

Avoid exporting Vector3Type value and change to ThreeTypes.Vector3

view details

Robert Long

commit sha 3293606314ba89199b524dc0e2fb93670eef189d

Use undefined instead of null for the default Object3DComponent value

view details

Fernando Serrano

commit sha 6351b65b6fb93bc1d2d6cf5ae3b74bc5d8be39d3

Merge pull request #17 from MozillaReality/nullable-object3d Handle returning undefined from getObject3D and upgrade to new ecsy PropType defs

view details

Fernando Serrano

commit sha 30ff0069e3226d59a8a7c94e67fa0497449871c7

Fix threetypes imports

view details

Fernando Serrano

commit sha 21a11492fa489adce29baf46e0e057f0590f3379

Remove duck due to a bug in snowpack with glb binaries

view details

Fernando Serrano

commit sha 71662af3b7d7fdf958c34411f473e5ab47db9cbc

Add duck again with jsdelivr url

view details

dependabot[bot]

commit sha 9a4e426336f6aec3eeb213cb2ec584ce27e63e18

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Fernando Serrano

commit sha 603d7eeadf810dbb6b30668331a1e6018c3e98f4

Merge pull request #20 from MozillaReality/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

Fernando Serrano

commit sha 7a0a5f50baa3c875d41674c6b5be5795873d3619

Fixes #19 System.d.ts => system.d.ts

view details

Fernando Serrano

commit sha eb9781779d03f543e23ca376b8ef940bd2bb3545

Big refactor to get rid of extras and refactor core

view details

Robert Long

commit sha 8464ef478db311a7ac5ce0c7ec1a12a6d198a62b

Fix exports

view details

Robert Long

commit sha b0da7c744017b13fc1783a954955ad5842f65828

Fix WebGLRendererSystem

view details

Robert Long

commit sha cb07e3894e71eb0d84c825e6b928071df0565a12

Move from defaultObject3D inflator to ThreeTagComponent

view details

Robert Long

commit sha 7cf9f40b2077016af1ed5fc6683258d58be19bf2

Fix typescript definitions

view details

Robert Long

commit sha b43c28c113fd40322ea7e470f14ccc37fd7b1cab

Fix .js imports

view details

Robert Long

commit sha 17628604a410e3ca5cb5c85740fb258b5f932392

Remove troika-3d-text and upgrade ecsy to 0.3.2

view details

push time in 3 months

push eventMozillaReality/ecsy-three

Robert Long

commit sha 022e8b794c75a0055ceb0f68083b3028f0548171

Export ECSYThreeObject3D and ECSYThreeEntity types

view details

Robert Long

commit sha 8acf089fd3c48f00b28e1df6fbdfee628e080bf3

addObject3DComponent, removeObject3DComponent, remove optional arguments

view details

Fernando Serrano

commit sha c09a05c1ac6890b64e5b9aa207dde2ef4950611c

Merge pull request #16 from MozillaReality/fix-typescript-defs-2 Fix some typescript definitions

view details

Robert Long

commit sha 60d57153ceae8766aab96793b6cf7af5fbe986d0

getObject3D should handle returning null

view details

Robert Long

commit sha cae026e0e68840c1e4cf9e7e391076ce7629f509

Avoid exporting Vector3Type value and change to ThreeTypes.Vector3

view details

Robert Long

commit sha 3293606314ba89199b524dc0e2fb93670eef189d

Use undefined instead of null for the default Object3DComponent value

view details

Fernando Serrano

commit sha 6351b65b6fb93bc1d2d6cf5ae3b74bc5d8be39d3

Merge pull request #17 from MozillaReality/nullable-object3d Handle returning undefined from getObject3D and upgrade to new ecsy PropType defs

view details

Fernando Serrano

commit sha 30ff0069e3226d59a8a7c94e67fa0497449871c7

Fix threetypes imports

view details

Fernando Serrano

commit sha 21a11492fa489adce29baf46e0e057f0590f3379

Remove duck due to a bug in snowpack with glb binaries

view details

Fernando Serrano

commit sha 71662af3b7d7fdf958c34411f473e5ab47db9cbc

Add duck again with jsdelivr url

view details

dependabot[bot]

commit sha 9a4e426336f6aec3eeb213cb2ec584ce27e63e18

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Fernando Serrano

commit sha 603d7eeadf810dbb6b30668331a1e6018c3e98f4

Merge pull request #20 from MozillaReality/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

Fernando Serrano

commit sha 7a0a5f50baa3c875d41674c6b5be5795873d3619

Fixes #19 System.d.ts => system.d.ts

view details

Fernando Serrano

commit sha eb9781779d03f543e23ca376b8ef940bd2bb3545

Big refactor to get rid of extras and refactor core

view details

Robert Long

commit sha 8464ef478db311a7ac5ce0c7ec1a12a6d198a62b

Fix exports

view details

Robert Long

commit sha b0da7c744017b13fc1783a954955ad5842f65828

Fix WebGLRendererSystem

view details

Robert Long

commit sha cb07e3894e71eb0d84c825e6b928071df0565a12

Move from defaultObject3D inflator to ThreeTagComponent

view details

Robert Long

commit sha 7cf9f40b2077016af1ed5fc6683258d58be19bf2

Fix typescript definitions

view details

Robert Long

commit sha b43c28c113fd40322ea7e470f14ccc37fd7b1cab

Fix .js imports

view details

Robert Long

commit sha 17628604a410e3ca5cb5c85740fb258b5f932392

Remove troika-3d-text and upgrade ecsy to 0.3.2

view details

push time in 3 months

push eventMozillaReality/ecsy-three

Shaw Walters

commit sha e528363802b3945e39f02c59df89788f68f3c5a4

Make parentEntity optional in Typescript Right now creating an entity requires a parent in typescript, which is clearly a bug since there is a nullcheck on parent in entity.js

view details

Fernando Serrano

commit sha dcb06949c4e60a9f39c78c5c8efa2975a4b10972

Merge pull request #15 from shawticus/patch-1 Make parentEntity optional in Typescript

view details

Robert Long

commit sha 618bafd4fd3783e929f799b66662db603a8edb6e

Export ECSYThreeObject3D and ECSYThreeEntity types

view details

Robert Long

commit sha dd15a9e0441e1b30e737c4c9bd5803aa86d132ea

addObject3DComponent, removeObject3DComponent, remove optional arguments

view details

Robert Long

commit sha af0cf0cef5a1b959158bf5477985ba8460f615eb

getObject3D should handle returning null

view details

Robert Long

commit sha 2a42dcb707f27f257787830840da2cc398152daf

Avoid exporting Vector3Type value and change to ThreeTypes.Vector3

view details

Robert Long

commit sha c87ee092a2de9a2266e72e25a54f2c577370e414

Use undefined instead of null for the default Object3DComponent value

view details

Fernando Serrano

commit sha dfae7629c92f1f9b281eef10dbc23de12ffa19aa

Fix threetypes imports

view details

Fernando Serrano

commit sha 7daca60adf403cf5eb8be89039677218cff906f5

Remove duck due to a bug in snowpack with glb binaries

view details

Fernando Serrano

commit sha 969ed5847735098a33cffea11ba31c9dda438232

Add duck again with jsdelivr url

view details

dependabot[bot]

commit sha ada3b29d4e6463d3f46fc00cf3e7893cd555f158

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Fernando Serrano

commit sha 55d6d74e0b97779d29a22e290115bb5032904fce

Fixes #19 System.d.ts => system.d.ts

view details

Robert Long

commit sha 04ad9bccc20129ff2d80f60a704bb66a2a936a18

Fix system.d.ts

view details

Fernando Serrano

commit sha f0319b7fa31a4a0b693445aed05a790e3db1c8cf

Big refactor to get rid of extras and refactor core

view details

Robert Long

commit sha f6a3c3363146517e07338544a8170613f670ccc6

Fix exports

view details

Robert Long

commit sha a4cb652c0505ede15f31d76199fca32b8d007322

Fix WebGLRendererSystem

view details

Robert Long

commit sha faa08ec40bfea851c7d3c162364883686fb421ac

Move from defaultObject3D inflator to ThreeTagComponent

view details

Robert Long

commit sha 5b598a2a99ecce926ee3c860c455a165fde9ed6b

Fix typescript definitions

view details

Robert Long

commit sha 84d6f7a96d1ca6786aa7badd94aec99e61d8dac3

Fix .js imports

view details

Robert Long

commit sha 2d4a0be9456d1f60bc35984e8c9459224c1f7937

Remove troika-3d-text and upgrade ecsy to 0.3.2

view details

push time in 3 months

release MozillaReality/ecsy

v0.4.0

released time in 3 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 0d2901b3e1751c4a379800fe17c65982ac031425

Updates

view details

push time in 3 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 684662b3f70d7a01b76b00252358fd5c62d17f0d

0.4.0

view details

push time in 3 months

created tagMozillaReality/ecsy

tagv0.4.0

Entity Component System for javascript

created time in 3 months

push eventMozillaReality/ecsy

Endel Dreyer

commit sha a12bf6e99592159281a3cc2248ccdb49bc59f3b0

fixes .set() to use only 2 arguments

view details

push time in 3 months

push eventMozillaReality/ecsy

dependabot[bot]

commit sha 93560130eba540b9f40e2560df740fb6c14847c1

Bump lodash from 3.10.1 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 3.10.1 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/3.10.1...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Fernando Serrano

commit sha c262f945d7b542f4c9d3cbf39d4a55de1d58611f

Merge pull request #212 from MozillaReality/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 3.10.1 to 4.17.19

view details

Chris Shepherd

commit sha 0e4a0fb7e1634caef9517ad7b380edd9dd9cfe5e

Fix and enable Entity tests

view details

Chris Shepherd

commit sha 13d6541f80f2cb258e662153ff3dddd9901f0c9d

Add @rollup/plugin-replace

view details

Chris Shepherd

commit sha 401f5446e057752643d7046600bf5c93e9e73738

Use replace in Rollup

view details

Chris Shepherd

commit sha d00051bbe1a2a8f9ed5f4f6a08b68519fc534dc2

Switch to using NODE_ENV

view details

Chris Shepherd

commit sha b1533e36a0827bec58d46c213e69850d3c3c9cb8

Add docs about development mode

view details

Scott Bailey

commit sha f5715446bcf01ec57f5246875441d720ce0be454

Update World.getSystem() typescript type to return the requested System type instead of System.

view details

Fernando Serrano

commit sha d89aeb457b66a060155f4702372e07c4d6ee9710

Merge pull request #216 from sheepsteak/fix-entity-tests Fix and enable Entity tests

view details

Fernando Serrano

commit sha a57edcc1eed3ed887fe06942ef2bdf825cee171f

Merge pull request #217 from sheepsteak/replace-debug Replace DEBUG with process.env.NODE_ENV

view details

Fernando Serrano

commit sha 94a6da4c2dc69e2345560a96ae39060f0f6b0a91

Merge pull request #218 from zeddic/add-get-system-types Update types for World.getSystem() to return the type of System requested

view details

Fernando Serrano

commit sha 758c668ab7ea9c95d1c5d0cf95f1929a552aeb6e

Check component attributes not defined on schema

view details

Fernando Serrano

commit sha 72451da43380b2042b755ce79f2ad0a2cdbff646

checkUndefinedAttributes on schema

view details

Fernando Serrano

commit sha fe0bef1cb648693e61d6ef73674d157d19026c21

Fix tests

view details

Fernando Serrano

commit sha 883cfb39d83a3f0e34cb3bbe8fea48780dd7266e

Add production check in checkUndefinedAttributes

view details

Fernando Serrano

commit sha 3697ae3302bec4dbaad49b32d7df2561a0e57e79

Merge pull request #195 from MozillaReality/checkattributes Check component attributes not defined on schema

view details

dependabot[bot]

commit sha 2a6521234c22c1b02ed0bc327cc00f6bd7d75796

Bump lodash from 3.10.1 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 3.10.1 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/3.10.1...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Scott Bailey

commit sha fe6dc11d5cb752e7481b82894ecf963c8c323661

Updates queryKey to use the Component typeId. Adds a regression test. Note that this adds an implict dependency that components are registered before systems, so alternatives should still be investigated.

view details

Scott Bailey

commit sha 91d6851ee669d7a28e9a789c378663c5b11a0323

Add a simple test for _typeId

view details

Fernando Serrano

commit sha 9c7af44297e9015cc6a3ba6df05c7ef5ae31b611

Change order on the three example

view details

push time in 3 months

delete branch MozillaReality/ecsy

delete branch : toJSON

delete time in 3 months

delete branch MozillaReality/ecsy

delete branch : system-query-result-types

delete time in 3 months

delete branch MozillaReality/ecsy

delete branch : entity-system-types

delete time in 3 months

push eventMozillaReality/ecsy

shawticus

commit sha 50f850bce3a6f2c62bf6a0587683f2de25e57d11

Added init to System.d.ts

view details

shawticus

commit sha 74a5f34e616a7a3f3f546c6403a749662dd85185

Shouldn't be abstract

view details

Fernando Serrano

commit sha 42ce1a3ca125636cfe433745a767cca746f8dd68

Merge pull request #241 from xr3ngine-archive/init-typescript Added init() to System.d.ts

view details

push time in 3 months

pull request commentMozillaReality/ecsy

Added init() to System.d.ts

@shawticus thanks!

shawticus

comment created time in 3 months

push eventMozillaReality/ecsy

Fernando Serrano

commit sha 695a72044c3671c4a21c3e44cf404faa77e4a283

Update AWESOME_ECSY.md

view details

push time in 3 months

push eventMozillaReality/ecsy-three

Robert Long

commit sha 9f03e2b54725a64aa6937fb4b9ce7be5b822c67b

Fix getSystem, export ECSYThreeEntityType

view details

Fernando Serrano

commit sha d21c96b7823c40b37cd68af8eb28c69640ed8812

Merge pull request #25 from MozillaReality/fix-types Fix getSystem, export ECSYThreeEntity Type

view details

push time in 3 months

PR merged MozillaReality/ecsy-three

Fix getSystem, export ECSYThreeEntity Type

getSystem was broken with the latest version of ECSY and we should export ECSYThreeEntity's type so that you can use it in component property definitions.

+4 -3

0 comment

2 changed files

robertlong

pr closed time in 3 months

push eventMozillaReality/ecsy

Robert Long

commit sha 5c6e7dcf21467c1e47377da57d04c775b5ee2349

Make getComponent etc. use optional return types

view details

Robert Long

commit sha 17677987e094d983244ea32e59ecd0a44aa67cc7

Add queries to system constructor

view details

Robert Long

commit sha d9696ad1df5ac690610f3e0e826f289d2d38b2d2

Merge branch 'dev' into entity-system-types

view details

Fernando Serrano

commit sha c7ccfc822d173b68822f36859cd46124045b1ac6

Merge pull request #240 from MozillaReality/entity-system-types Make getComponent use an optional return type

view details

push time in 3 months

PR merged MozillaReality/ecsy

Make getComponent use an optional return type

getComponent, getRemovedComponent, and getMutableComponent now use optional return types. This lets you use the entity.getComponent!(MyComponent) syntax when using Typescript's strict mode instead of entity.getComponent(MyComponent) as MyComponent.

+16 -13

0 comment

2 changed files

robertlong

pr closed time in 3 months

delete branch MozillaReality/ecsy

delete branch : fix-linting

delete time in 3 months

push eventMozillaReality/ecsy

Robert Long

commit sha f43b121c19ea48a77bf64a9a2875a9aaf71424e1

Upgrade prettier and fix linting

view details

Fernando Serrano

commit sha fe94874b343baa9cfc66ef9f8c45cad83f49d3e4

Merge pull request #238 from MozillaReality/fix-linting Upgrade prettier and fix linting

view details

push time in 3 months

PR merged MozillaReality/ecsy

Upgrade prettier and fix linting

I think vscode is using prettier 2.0 and I've been running into some issues when reformatting code. So I've upgraded us to prettier 2.0 and fixed all the linting errors.

The prettier 2.0 changelog: https://prettier.io/blog/2020/03/21/2.0.0.html

tldr; they like trailing commas and parens around single parameter arrow functions now.

+236 -243

1 comment

29 changed files

robertlong

pr closed time in 3 months

pull request commentMozillaReality/ecsy

Upgrade prettier and fix linting

oh :( it was so cool to be true :D

robertlong

comment created time in 3 months

push eventMozillaReality/ecsy

shawticus

commit sha e469d7ca702774e80f0386c2c7787c159b08755b

Add ;s to pass linting

view details

Fernando Serrano

commit sha 1777e1fb5043e46dee5a74c5865b18de1a3125ca

Merge pull request #239 from xr3ngine-archive/hasRegisteredComponent Fix linting for hasRegisteredComponent PR

view details

push time in 3 months

PR merged MozillaReality/ecsy

Fix linting for hasRegisteredComponent PR

Needed some ";"s after return statements

+2 -2

0 comment

2 changed files

shawticus

pr closed time in 3 months

push eventMozillaReality/ecsy

shawticus

commit sha 9a4f54c3011098eb211f86ad1e6d7f7f655bd85b

Added world.hasRegisteredComponent

view details

Fernando Serrano

commit sha b70c78e0fe16668469800bc842e02f61bc33c12b

Merge pull request #236 from xr3ngine-archive/hasRegisteredComponent Added hasRegisteredComponent to World and ComponentManager

view details

push time in 3 months

PR merged MozillaReality/ecsy

Added hasRegisteredComponent to World and ComponentManager

The goal here is to be able to check whether a component has already been registered to the world before adding it, which can be helpful when different init sequences rely on the same components.

+14 -0

1 comment

3 changed files

shawticus

pr closed time in 3 months

pull request commentMozillaReality/ecsy

Added hasRegisteredComponent to World and ComponentManager

Thanks!

shawticus

comment created time in 3 months

push eventMozillaReality/ecsy-devtools

Fernando Serrano

commit sha 273f647b26e0f5b663a0d7efee81c55786e4f441

Update version 0.1.1

view details

Fernando Serrano

commit sha 2c37fe3ad8472a39019caafc846e2d28c1cbbef3

Bump version

view details

push time in 3 months

delete branch MozillaReality/ecsy

delete branch : remove-undefined-components

delete time in 3 months

push eventMozillaReality/ecsy

Robert Long

commit sha 91de2d95bac003398b906a588ee11b0df516c789

Remove undefined from getComponent type

view details

Fernando Serrano

commit sha 684b2fac46c16d34bbda44c8273f29fdaeddb9f0

Merge pull request #235 from MozillaReality/remove-undefined-components Remove undefined from getComponent type

view details

push time in 3 months

PR merged MozillaReality/ecsy

Remove undefined from getComponent type

The undefined union type is technically correct, but makes it really annoying to use in strict mode and there are many other benefits to be gained in strict mode. I think we should try to use the the system query to determine if the entity has the component and only use the undefined union type when we don't know. There may not be a way to do this in typescript though.

+3 -3

1 comment

1 changed file

robertlong

pr closed time in 3 months

pull request commentMozillaReality/ecsy

Remove undefined from getComponent type

cc @sheepsteak

robertlong

comment created time in 3 months

more