/retest

@randomvariable: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

Yeah, I agree. First of all was trying to fix the test, so added the uncached, but then after doing that, there's no reason to do the cached lookup for leader election where it's not going to be called very often unlike consumers within reconciliation loops. Deleting.

Hmm I'm not sure if this is worth surfacing as an option. It is kinda confusing as well (why cache this namespace in the first place? why do I care?). Is it really that hard to call options.LeaderElectionNamespace = ReadInClusterNamespaceCached() or options.LeaderElectionNamespace = ReadInClusterNamespace() depending on what mode you want when setting up Options, with a default to ReadInClusterNamespace()?

I should probably retire at this stage :)

This still isn't storing ns globally, it's redefining inClusterNamespace in the local scope

	inClusterNamespace = ns

Argh.

@aayushrangwala: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

@aayushrangwala: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

/test pull-controller-runtime-test-master

/test pull-controller-runtime-test-master

Yeah I was pretty sure it did.

It is unrelated to this PR though, isn't it?

PatchStatus doesn't apply patch options it receives in the same way so I wanted to fix it too.. I opened the issue #1514

Metadata client's PatchStatus receives client.Object that must be of *metav1.PartialObjectMetadata type which seems useless because PartialObjectMetadata doesn't have fields that describe status.

Here

https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/metadata_client.go#{L169:L172} - exits with error if type isn't *metav1.PartialObjectMetadata
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/client.go#L259-L260 - calls metadata_client.PatchStatus only if type is *metav1.PartialObjectMetadata

@aayushrangwala: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

@aayushrangwala: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

I think instead of returning nil, we should assign nil to the bool pointer. Which would imply that

• If the user gave the flag but with empty value, it will be considered as flag not passed
• If the user gave the flag but with some invalid value, it will be error
• If the user gave the flag but with some valid value, it will be handled properly

@alvaroaleman this should be all updated.

I've switched around the way this is handled, the first check r.Body == nil now checks if it's a request that doesn't support a body, like a Get and fails out then we go on to reading the body.

So I guess that isn't what happens, the decoder doesn't seem to check what the actual headers are. If you don't have this check and the body is valid the request could be successful or could fail other places.

(I am sorry if this is not the right place for my objection)

In the current discussions about this topic (operator-sdk, kubebuilder and here) there are basically two promoted solutions (at least as a workaround until better support):

1. Downloading the external CRDs
2. Referring to a go module containing the external CRDs

1.) has potential downsides as already mentioned, while 2.) introduces the problem of having a statically defined path floating around, which needs to be updated manually if dependencies in the project change. 2.) can also lead to unexpected errors if multiple versions are available in the go module cache and someone forgets to update the tests to refer to the new version of external CRDs.

As external CRDs should usually be a dependency of the project anyway (as testdata or within the controller), could it be possible to promote using go modules in the regular way and dynamically add the CRDs to envtest using the go.mod file?

E.g. adding OCP CRDs programmatically could look (very) roughly like this:

func getOCPCRDs() []string {
	const ocpModule = "github.com/openshift/api"
	modFilePath := filepath.Join("..", "..", "go.mod")

	goModBytes, err := ioutil.ReadFile(modFilePath)
	Expect(err).NotTo(HaveOccurred())

	file, err := modfile.Parse(modFilePath, goModBytes, nil)
	Expect(err).NotTo(HaveOccurred())

	ocpVersion := ""
	for _, r := range file.Require {
		if r.Mod.Path == ocpModule {
			ocpVersion = r.Mod.Version
		}
	}
	Expect(ocpVersion).ToNot(BeEmpty())

	basePath := filepath.Join(
		build.Default.GOPATH,
		"pkg",
		"mod",
		ocpModule+"@"+ocpVersion,
	)

	netNamespaceCRDPath := filepath.Join(
		basePath,
		"network",
		"v1",
		"003-netnamespace-crd.yaml",
	)

	networkConfigCRDPath := filepath.Join(
		basePath,
		"config",
		"v1",
		"0000_10_config-operator_01_network.crd.yaml",
	)

	return []string{
		netNamespaceCRDPath,
		networkConfigCRDPath,
	}
}
...
By("extracting relevant OpenShift API CRDs")
ocpCRDs := getOCPCRDs()

By("bootstrapping test environment")
testEnv = &envtest.Environment{
    ErrorIfCRDPathMissing: true,
        CRDDirectoryPaths: []string{
	   filepath.Join("..", "..", "config", "crd", "bases"),
	},
}
testEnv.CRDDirectoryPaths = append(testEnv.CRDDirectoryPaths, ocpCRDs...)

This is obviously not at all perfect, but at least removes the need to update the static go module path in the tests with every little dependency update in the overall project.

The path could have spaces, single quotes, etc in in, so this quotes the path and escapes single quotes so we can export properly.

This is very relevant on darwin, where our default store path contains spaces (it includes "Application Support")

So the result is supposed to look something like the following?

$ export FOO='/foo/'"'"'Application Support'"'"''
$ echo $FOO
/foo/'Application Support'

@DirectXMan12: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

@avrahams There is none for Routes. All OCP related CRDs are potentially to be found in the API repo, but a lot of "older" OCP resources are not published that way. Recently had contact with some Red Hat people about that and my information so far is, there is no really immediate plan to change that.

There is a manual way though. One has to create a 'fake' CRD within the correct OCP API repository path and adapt the make targets.

E.g. for Routes, a CRD file route_crd.yaml with the following content has to be created in the path https://github.com/openshift/api/tree/master/route/v1:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  # name must match the spec fields below, and be in the form: <plural>.<group>
  name: routes.route.openshift.io
spec:
  # group name to use for REST API: /apis/<group>/<version>
  group: route.openshift.io
  # list of versions supported by this CustomResourceDefinition
  versions:
    - name: v1
      # Each version can be enabled/disabled by Served flag.
      served: true
      # One and only one version must be marked as the storage version.
      storage: true
  # either Namespaced or Cluster
  scope: Namespaced
  subresources:
    # enable spec/status
    status: {}
  names:
    # plural name to be used in the URL: /apis/<group>/<version>/<plural>
    plural: routes
    # singular name to be used as an alias on the CLI and for display
    singular: route
    # kind is normally the CamelCased singular type. Your resource manifests use this.
    kind: Route

Then the Makefile has to get this line:

$(call add-crd-gen,route,./route/v1,./route/v1,./route/v1)

Updating the CRDs with

make update-codegen-crds

populates the CRD stub with the correct OpenAPI validation content.

Unfortunately it seems to only works this way, as the API repo infrastructure already expects the basic CRD to be there (I am sure one can workaround that somehow).

It works for other resources as well, but it is obviously not a very practical solution. So this is just a documentation comment for people experiencing similar problems with OCP related resources.

Just as a warning: In some of my tests I experienced validation errors populating envtest with these CRDs, but I did not investigate it further.

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

@DirectXMan12: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/controller-runtime/pull/1513#" title="Author self-approved">DirectXMan12</a>, <a href="https://github.com/kubernetes-sigs/controller-runtime/pull/1513#pullrequestreview-652793105" title="Approved">vincepri</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12,vincepri]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/controller-runtime/pull/1513#" title="Author self-approved">DirectXMan12</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

• OWNERS [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->