Hii @richardcase, I am new to open source and will like to contribute to this project so can you assign it to me.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/2542#issuecomment-867833733" title="Approved">randomvariable</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

• OWNERS [randomvariable]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign randomvariable after the PR has been reviewed. You can assign the PR to them by writing /assign @randomvariable in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["randomvariable"]} -->

@dlipovetsky: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

<!-- Thanks for this PR! If this is your first PR please read the contributing guide --> <!-- If this PR is still work-in-progress and is being open for visibility please prefix the title with WIP: -->

What type of PR is this? /kind documentation

<!-- Add one of the following kinds: /kind feature /kind bug /kind api-change /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind flake /kind regression /kind support -->

What this PR does / why we need it: Corrects the version skew in the README.

<!-- Enter a description of the change and why this change is needed -->

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist: <!-- Put an "X" character inside the brackets of each completed task. Some may be optional depending on the PR in which case these can be deleted -->

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests
• [ ] adds or updates e2e tests

Release note: <!-- Write your release note:

1. Enter your extended release note in the below block.
2. If the PR requires additional action from users switching to the new release, include the string "action required".
3. If no release note is required, just write "NONE"....however we encourage contributors to never use this as release notes are incredible useful. -->

Is that thumbprint actually correct? It looks like an ssh publickey and not an SSL cert thumbprint.

/milestone v0.6.x /kind release-blocking

• VSphereCluster fetches Secret (from cluster namespace) or VSphereIdentity that links to a Secret in the controller namespace when verifying connectivity
• VsphereVM utilizes identity when IdentityRef is specified in cluster
• validates secret is stored in the correct namespace for the identity types
• adds namespaces allowed logic
• adds authentication related conditions to VSphereVM
• adds vSphere secret to generated cluster templates
• updates secrets with finalizers and ownerref when secret is meant to be used as the Identity

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1123

Release note:

- Multi-tenancy support. Clusters can either reference a Secret with credentials or a VSphereClusterIdentity

/kind feature

Describe the solution you'd like CAPV manager currently requires credentials to a vcenter through its runtime options to operate. This issue is to track support for multi-tenancy through a single instance of the CAPV manager.

There are currently less than ideal ways to deploy to multiple vcenters:

• Utilize the Server field in vsphere machine clone spec. This allows for machines to be deployed to vcenters other than the one the manager is configured for, but it requires the alternate vcenters to have the same credentials as the primary one.
• Deploy multiple instances of the CAPV manager configured for each vcenter and have them watch a dedicated namespace. Not currently supported and may never be fully supported. CAPI's multi-tenancy contract implicitly calls for a single manager instance.

Anything else you would like to add: Each cluster will need to specify credentials to be used to deploy the cluster, if it's something other than what the CAPV manager is configured for. This could be done through a reference to a secret. If a cluster doesn't specify credentials, CAPV can fall back to using the credentials configured in the manager.

/lgtm

There are numerous errors with the e2e tests:

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/2505/pull-cluster-api-provider-aws-e2e-eks/1408071070308634624/artifacts/clusters/bootstrap/controllers/capa-eks-control-plane-controller-manager/capa-eks-control-plane-controller-manager-79dfc4848d-f7lj6/manager.log

Upgrade kind to v0.11.0 for less flakiness in e2e tests.

Corresponding cluster api issue: https://github.com/kubernetes-sigs/cluster-api/issues/4503

https://github.com/kubernetes-sigs/cluster-api/pull/4469

/milestone v0.7.0

<!-- Thanks for this PR! If this is your first PR please read the contributing guide --> <!-- If this PR is still work-in-progress and is being open for visibility please prefix the title with WIP: -->

What type of PR is this?

<!-- Add one of the following kinds: /kind feature /kind bug /kind api-change /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind flake /kind regression /kind support -->

What this PR does / why we need it:

Upgrade kind to v0.11.0 for less flakiness in e2e tests. the kind is already v0.11.1 in go.sum

<!-- Enter a description of the change and why this change is needed -->

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2413

Special notes for your reviewer:

Checklist: <!-- Put an "X" character inside the brackets of each completed task. Some may be optional depending on the PR in which case these can be deleted -->

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests
• [ ] adds or updates e2e tests

Release note: <!-- Write your release note:

1. Enter your extended release note in the below block.
2. If the PR requires additional action from users switching to the new release, include the string "action required".
3. If no release note is required, just write "NONE"....however we encourage contributors to never use this as release notes are incredible useful. -->

NONE

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/2541#issuecomment-867795076" title="Approved">sedefsavas</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

@srm09: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

/lgtm /approve

/kind bug The default cluster templates create a new Cluster Resource Set (CRS) per cluster but the resources referenced in the CRS don't have unique names. There are things like: Secrets named csi-vsphere-config ConfigMaps named vsphere-csi-node and vsphere-csi-controller

What steps did you take and what happened:

• deploy a cluster to Datacenter 1
• notice the csi-vsphere-config with data that references Datacenter 1
• deploy another cluster to Datastore 2
• csi-vsphere-config is now updated to reference Datastore 2
• If either one of the cluster is deleted, the CRS resources are also deleted.

What did you expect to happen: CRS resources that are unique to a cluster that won't get affected by other clusters' lifecycle.

Environment:

• Cluster-api-provider-vsphere version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

closing since quickstart templates are meant for testing and are expected to be customized by users.

@Ankitasw: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

/ok-to-test

Hi @xinydev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

Welcome @xinydev! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes-sigs/cluster-api-provider-aws'>kubernetes-sigs/cluster-api-provider-aws</a> 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation. <br><br>You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines. <br><br>You may want to refer to our testing guide if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign justinsb after the PR has been reviewed. You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["justinsb"]} -->

@xinydev: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

<!-- Thanks for this PR! If this is your first PR please read the contributing guide --> <!-- If this PR is still work-in-progress and is being open for visibility please prefix the title with WIP: -->

What type of PR is this?

<!-- Add one of the following kinds: /kind feature /kind bug /kind api-change /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind flake /kind regression /kind support -->

What this PR does / why we need it:

Upgrade kind to v0.11.0 for less flakiness in e2e tests. the kind is already v0.11.1 in go.sum

<!-- Enter a description of the change and why this change is needed -->

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2413

Special notes for your reviewer:

Checklist: <!-- Put an "X" character inside the brackets of each completed task. Some may be optional depending on the PR in which case these can be deleted -->

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests
• [ ] adds or updates e2e tests

Release note: <!-- Write your release note:

1. Enter your extended release note in the below block.
2. If the PR requires additional action from users switching to the new release, include the string "action required".
3. If no release note is required, just write "NONE"....however we encourage contributors to never use this as release notes are incredible useful. -->

@richardcase: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

<details>

In response to this:

/area provider/eks /kind api-change /kind refactor /milestone v0.7.0 /help /priority important-soon

Describe the solution you'd like You can optionally enable encryption for EKS by supplying details in AWSManagedControlPlane.Spec.EncryptionConfig. As its optional, it is a pointer and marked as optional and omitempty.

If you want to enable encryption, then you must supply the provider and resources. Currently, these are pointers and not marked as required. We should mark these as required using kubebuilder validation and remove the pointers/omitempty.

This was noticed whilst making a change for #2505

Anything else you would like to add: So perhaps something like this:

// EncryptionConfig specifies the encryption configuration for the EKS clsuter.
type EncryptionConfig struct {
	// Provider specifies the ARN or alias of the CMK (in AWS KMS)
	// +kubebuilder:validation:Required
	Provider string `json:"provider"`
	// Resources specifies the resources to be encrypted
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:MinItems=1
	Resources []string `json:"resources"`
}

This will cause problems with the generated deepcopy and conversion functions which will need to be fixed.

Environment:

• Cluster-api-provider-aws version: 0.6.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

/area provider/eks /kind api-change /kind refactor /milestone v0.7.0 /help /priority important-soon

Describe the solution you'd like You can optionally enable encryption for EKS by supplying details in AWSManagedControlPlane.Spec.EncryptionConfig. As its optional, it is a pointer and marked as optional and omitempty.

If you want to enable encryption, then you must supply the provider and resources. Currently, these are pointers and not marked as required. We should mark these as required using kubebuilder validation and remove the pointers/omitempty.

This was noticed whilst making a change for #2505

Anything else you would like to add: So perhaps something like this:

// EncryptionConfig specifies the encryption configuration for the EKS clsuter.
type EncryptionConfig struct {
	// Provider specifies the ARN or alias of the CMK (in AWS KMS)
	// +kubebuilder:validation:Required
	Provider string `json:"provider"`
	// Resources specifies the resources to be encrypted
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:MinItems=1
	Resources []string `json:"resources"`
}

This will cause problems with the generated deepcopy and conversion functions which will need to be fixed.

Environment:

• Cluster-api-provider-aws version: 0.6.6

/test pull-cluster-api-provider-aws-e2e-eks