profile
viewpoint

cjb129/beaker 0

The Beaker Programming Language

cjb129/beekar 0

beaker with inheritance

New-Innovations/apgdiff 0

Another PostgreSQL Diff Tool

New-Innovations/gocd-s3-artifact-plugin 0

S3 Artifact Plugin for GoCD

New-Innovations/hiplogging 0

Use the standard python logging, and have your logs on Hipchat!

New-Innovations/wait-for 0

./wait-for is a script to wait for another service to become available.

New-Innovations/wait-for-it 0

Pure bash script to test and wait on the availability of a TCP host and port

New-Innovations/zcrm-python-sdk 0

Python SDK is wrapper for Zoho CRM APIs. By using this SDK, user can build the application with ease

toneill818/anchore-container-scanner-plugin 0

Jenkins plugin that adds Anchore container image analysis and policy evaluation to Jenkins as a build step

toneill818/apache-pulsar-grafana-dashboard 0

Apache Pulsar Grafana Dashboard

PR opened terraform-aws-modules/terraform-aws-eks

Added AmazonEKSVPCResourceController To Cluster Policy

PR o'clock

Description

AWS recently added the ability to assign security groups to pods, more info about this can be found here. This new feature requires an additional policy attached to the cluster role.

Checklist

  • [X] CI tests are passing
  • [X] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation
+7 -0

0 comment

1 changed file

pr created time in 5 days

push eventtoneill818/terraform-aws-eks

Thomas O'Neill

commit sha 1ab61806033032f8f3084ce039fb2c1f610eb773

Added AmazonEKSVPCResourceController policy to be able to set secuirty groups per pod.

view details

push time in 5 days

push eventtoneill818/terraform-aws-eks

Daniel Piddock

commit sha 9ace344c57709ac5cd32da2d94ed6b6f7e9c1d28

docs: Better documentation of `cluster_id` output blocking (#955) NOTES: Starting in v12.1.0 the `cluster_id` output depends on the `wait_for_cluster` null resource. This means that initialisation of the kubernetes provider will be blocked until the cluster is really ready, if the module is set to manage the aws_auth ConfigMap and user followed the typical Usage Example. kubernetes resources in the same plan do not need to depend on anything explicitly.

view details

Daniel Piddock

commit sha 415cfca9af3c1f1219e3c294d85fe29a28b255a3

ci: fix CI lint job (#973) Module used by an example does not allow use with 0.13 yet. Lock to latest version of 0.12. No 0.12 floating tag :(

view details

Jürgen W

commit sha f45b5a1d4614a19c0a0e790161ac552fc42f9d6e

fix: random_pet with LT workers under 0.13.0 (#940) Fix for: Error: Provider produced inconsistent final plan When expanding the plan for module.eks.random_pet.workers_launch_template[0] to include new values learned so far during apply, provider "registry.terraform.io/hashicorp/random" changed the planned action from CreateThenDelete to DeleteThenCreate.

view details

Giuseppe Crinò

commit sha 1c8122704413fb3f54bff90b2692100def041caf

docs: Describe key_name is about AWS EC2 key pairs (#970)

view details

Thomas O'Neill

commit sha c508d12b696a24da87f72faa9d3ec073e9ff830b

docs: Mixed spot + on-demand instance documentation (#967) * Add example for lauch config with mixed lifecycles * Set what on-demand instance is * Tweak wording Co-authored-by: Thomas O'Neill <toneill@new-innov.com> Co-authored-by: Daniel Piddock <daniel.piddock@teamcmp.com>

view details

Daniel Piddock

commit sha 1bd5bf5ab9e4f2701c064668a02f012d971a1102

feat: Cluster version is now a required variable. (#972) BREAKING CHANGES: `cluster_version` variable is now required.

view details

Dawid Rogaczewski

commit sha 44d59da57b8298b99986179de6c725af05d85086

docs: Update README about `cluster_version` variable requirement (#988)

view details

Anthony Dahanne

commit sha 1adbe82e1564ecaddee393d329a5b4f99393b7da

fix: Create `cluster_private_access` security group rules when it should (#981) BREAKING CHANGES: Default for `cluster_endpoint_private_access_cidrs` is now `null` instead of `["0.0.0.0/0"]`. It makes the variable required when `cluster_create_endpoint_private_access_sg_rule` is set to `true`. This will force everyone who want to have a private access to set explicitly their allowed subnets for the sake of the principle of least access by default.

view details

Thierno IB. BARRY

commit sha ad5373dc614c3d4d4e70d7177b25f6f084b67197

docs: Add important notes about the retry logic and the `wget` requirement (#999)

view details

Daniel Piddock

commit sha bceb966dfd6f763ad8ea58764e8e84922848eca4

fix: More compatibility fixes for Terraform v0.13 and aws v3 (#976) Additional support for Terraform v0.13 and aws v3! - The update to the vpc module in examples was, strictly speaking, unnecessary but it adds the terraform block with supported versions. - Update for iam module in the example was very necessary to support new versions - Workaround for "Provider produced inconsistent final plan" when creating ASGs at the same time as the cluster. See https://github.com/terraform-providers/terraform-provider-aws/issues/14085 for full details. - Blacklist 0.13.0 as it was too strict when migrating from aws v2 to v3 about dropped attributes.

view details

push time in 5 days

pull request commentapache/pulsar-helm-chart

Ingress optional hostname

@Skaronator That solution still requires a host to be defined as it loops over the hosts list. The goal of this PR was to make the host an optional input. The solution you proposed would not allow for only paths to be defined for an ingress.

toneill818

comment created time in a month

issue openedapache/pulsar-helm-chart

Allow StorageClass to be set for pulsar-manager in the values file

Describe the solution you'd like Have the same options for volumes in pulsar manager as we do in the broker, zookeeper, bookie...

created time in a month

issue openedapache/pulsar-helm-chart

Error Reading Functions Worker ConfigMap

Describe the bug When enabling functions, the broker throws the following error:

Error while trying to fetch configmap pulsar-functions-worker-config at namespace

To Reproduce Steps to reproduce the behavior:

  1. Set Components.functions to True (true by default)
  2. View broker logs
  3. See error

Expected behavior I think the role needs to be bound to the broker service account. It currently creates another service account named pulsar-functions-worker. Not sure if that SA is used by the functions, but the pulsar-broker-acct does not have access to the function worker config map.

What is the pulsar-functions-worker used for? Is it used by the functions? If so we can add read access to the pulsar-broker-acct role that is bound so it can read the ConfigMap.

created time in a month

issue openedapache/pulsar-helm-chart

Add The Ability To Set Log Level

Is your feature request related to a problem? Please describe. Setting PULSAR_LOG_ROOT_LEVEL and PULSAR_ROOT_LOGGER environment variables using configData does not change the log level since it uses the conf/log4j2.yaml .

Describe the solution you'd like Ideally we would be able to only use environment variables, but that will not be possible until pulsar does not depend on the log4j2.yaml file. To get it working in its current state, we could create a ConfigMap with the contents of the logfile, then mount it as a volume and set the PULSAR_LOG_CONF to point to our mounted file instead of conf/log4j2.yaml.

created time in a month

issue openedapache/pulsar

Add The Ability To Set Log Level From Environment Variables In Docker

Currently there are not scripts or set to configure the log YAML file from environment variables. There are for other non YAML configuration files.

Describe the solution you'd like Add a script to the docker container that can read PULSAR_PREFIX_LOG_LEVEL and set it in the yaml file.

Describe alternatives you've considered Being able to set the log level within the configuration files such as the broker.conf.

created time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha 55f61312be7ec6ac307deb59c9f754e9ba9a7a68

version bump

view details

push time in a month

PR opened apache/pulsar-helm-chart

Ingress optional hostname

Fixes #50

Motivation

The host option is not required to setup an ingress, so I made it an optional value

Modifications

Describe the modifications you've done. Made setting the host optional.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.
+15 -11

0 comment

4 changed files

pr created time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha 2eccd3940563043adc736cda502c9b195b39bdb9

Update values

view details

push time in a month

create barnchtoneill818/pulsar-helm-chart

branch : ingress-optional-hostname

created branch time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha bf0053ad6330b3c668cd742e4dc4be26e7781ed1

Update CI to set intialize from the commandline

view details

push time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha 913f793d7c6de460a818c4cf7ed1b8bdf737dee6

Wrap bookkeeper initialize job and update CI

view details

push time in a month

issue commentapache/pulsar-helm-chart

template error in 2.6.0-2

You don't want to change the values.yaml file in the release. Those hold all the default values and is why you are getting the error. You will want to put your values in a different file and reference them with the -f flag. That will override the default values in the values.yaml.

Syphixs

comment created time in a month

PR opened apache/pulsar-helm-chart

Allow initialization to be set

Fixes #47

Motivation

Only create the initialize job on install.

Modifications

  • Added an initialize value that can be set to true on install, matching the documentation in the README.md

Verifying this change

  • [ ] Make sure that the change passes the CI checks.
+6 -1

0 comment

3 changed files

pr created time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha 47902086e5b033b3bf01798a914454a8cd1f48a1

Allow initialization to be set

view details

push time in a month

create barnchtoneill818/pulsar-helm-chart

branch : initialize-once

created branch time in a month

issue commentapache/pulsar-helm-chart

template error in 2.6.0-2

Did you change the default values.yaml file? Looking at your screenshot it looks like you are pointing to the values.yaml file within the chart.

Syphixs

comment created time in a month

PR opened apache/pulsar-helm-chart

Fix zookeeper antiaffinity

Fixes #39

Motivation

The match expression for the "app" label was incorrect breaking the antiaffinity since they would never match. Fixing this makes the podAntiAffinity work, but now requires at least N nodes to be in the cluster where N = largest replica set with affinity. Added the option to set the affinity type to preferredDuringSchedulingIgnoredDuringExecution where it will try to follow the affinity, but will still deploy a pod if it needs to break it.

Modifications

  • Fixed app matchExpression
  • Added option to set the affinity type
  • bumped chart version

Verifying this change

  • [ ] Make sure that the change passes the CI checks.
+141 -12

0 comment

7 changed files

pr created time in a month

create barnchtoneill818/pulsar-helm-chart

branch : fix-zookeeper-antiaffinity

created branch time in a month

issue commentapache/pulsar-helm-chart

Bug in podAntiAffinity labels

@rvashishth The bug is in the labelSelector for podAntiAffinity.

affinity:
  podAntiAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
        matchExpressions:
          - key: "app"
            operator: In
            values:
              - "{{ template "pulsar.name" . }}-{{ .Values.zookeeper.component }}" # This is where the issue is, it will never match

The app is set to pulsar.name-component. So it looks for app: pulsar-zookeeper, but the template for the labels sets the app to pulsar.name. Removing the "-component" should fix this. I can open a PR with this fix if you would like. Also with this change you will need to have as many nodes as the highest replicas for any of the stateful sets. Should we set the affinity to preferredDuringSchedulingIgnoredDuringExecution?

mkozioro

comment created time in a month

issue openedapache/pulsar-helm-chart

Ingress hostname should not be required

Describe the bug When creating ingresses for services such as the proxy or pulsar-manager, the hostname value should optional.

To Reproduce Steps to reproduce the behavior:

  1. Create an ingress without a hostname specified
proxy:
  ingress:
    enabled: true
    path: "/pulsar-manager/"
  1. Try installing or upgrading the chart

Expected behavior An ingress should be created.

Additional context I can submit a PR to make the hostname optional.

created time in a month

PR opened apache/pulsar-helm-chart

Fix deprecated values

Fixes #46

Motivation

There were some templates that relied on extra values that are deprecated.

Modifications

Modified the checks to check for non deprecated values or deprecated values.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.
+12 -12

0 comment

3 changed files

pr created time in a month

create barnchtoneill818/pulsar-helm-chart

branch : fix-deprecated-values

created branch time in a month

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha a41b6c5063f4b5339e4e025ce0c79970e68af872

Allow Grafana to work with a reverse proxy (#48) ### Motivation Allow Grafana to be served from a sub path. ### Modifications - Added a config map to add extra environment variables to the grafana deployment. As the grafana image adds new features that require environment variables, this can be used to set them. - Bumped the grafana image to allow a reverse proxy - removed ingress annotations as they are specific to nginx, and to match all the other ingresses - bumped the chart version as per the README Example values: ``` grafana: configData: GRAFANA_ROOT_URL: /pulsar/grafana GRAFANA_SERVE_FROM_SUB_PATH: "true" ingress: enabled: true port: 3000 path: "/pulsar/grafana/?(.*)" annotations: nginx.ingress.kubernetes.io/rewrite-target: /$1 ```

view details

push time in a month

issue commentapache/pulsar-manager

app assets are not accessible behind nginx proxy on kubernetes

I am running into the same issue. I have an nginx ingress setup to map /pulsar/manager/?(.*) to the pulsar-manager service. The page loads with a 200, but all of the assets are trying to load from /static/.... Does vue have an option that we can pass to the container for it to use a URL prefix?

It appears the assetsPublicPath is set in the build config so I'm guessing we can't change it at runtime within a container?

rvashishth

comment created time in a month

push eventtoneill818/charts

Thomas O'Neill

commit sha f756accf1a2c78f863e15a8e4807c49ff8cba128

Included dashboardProviders in the import example Signed-off-by: Thomas O'Neill <toneill818@gmail.com>

view details

Thomas O'Neill

commit sha 8e4d61f2474da1c1e82115ebeba35b670f71cd8c

Merge branch 'grafana/doc-update' of github.com:toneill818/charts into grafana/doc-update Signed-off-by: Thomas O'Neill <toneill818@gmail.com>

view details

push time in a month

push eventtoneill818/charts

Thomas O'Neill

commit sha a5ba6e07e434c67cc6aac173edc2e5dd052ac895

Included dashboardProviders in the import example Signed-off-by: Thomas O'Neill <toneill818@gmail.com>

view details

push time in a month

PR opened helm/charts

[stable/grafana] Updated documentation for importing dashboards

Signed-off-by: Thomas O'Neill toneill818@gmail.com

Is this a new chart

No

What this PR does / why we need it:

Includes the dashboardProvider in the example to import dashboards. This is needed to access the dashboards that are imported.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])
+13 -0

0 comment

1 changed file

pr created time in a month

create barnchtoneill818/charts

branch : grafana/doc-update

created branch time in a month

fork toneill818/charts

Curated applications for Kubernetes

fork in a month

PR opened terraform-aws-modules/terraform-aws-eks

Spot instance documentation

Description

Added documentation showing how to run mixed lifecycle instances using launch templates, and dynamically set a label on the node for the lifecycle.

+19 -0

0 comment

1 changed file

pr created time in a month

push eventtoneill818/terraform-aws-eks

Thomas O'Neill

commit sha fe373247a69dec306a09e1aae55f88a864e46944

Set what on-demand instance is

view details

push time in a month

create barnchtoneill818/terraform-aws-eks

branch : spot-instance-documentation

created branch time in a month

fork toneill818/terraform-aws-eks

Terraform module to create an Elastic Kubernetes (EKS) cluster and associated worker instances on AWS

https://registry.terraform.io/modules/terraform-aws-modules/eks/aws

fork in a month

issue commentterraform-aws-modules/terraform-aws-eks

Pass different kubelet args based on purchase option

If you want to set the lifecycle label, you can pull it from the instance metadata.

kubelet_extra_args   = "--node-labels=node.kubernetes.io/lifecycle=`curl -s http://169.254.169.254/latest/meta-data/instance-life-cycle`"`

This will set the lifecycle to either "spot" or "on-demand".

kencieszykowski

comment created time in a month

push eventtoneill818/aws-node-termination-handler

Thomas O'Neill

commit sha ad6b68f96bb6d744d48639710668af5b21662ee5

Update README for helm chart, and roll back value change

view details

push time in 2 months

PR opened aws/aws-node-termination-handler

default enableSpotInterruptionDraining to true

Description of changes: According to the README, the default value for enableSpotInterruptionDraining is true, but the value in values.yaml had it set to empty string ("").

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventtoneill818/aws-node-termination-handler

Thomas O'Neill

commit sha 42a7f6a2b6f3f985d82b90e82fd1974c8463a4d4

enableSpotInterruptionDraining default to "true"

view details

push time in 2 months

fork toneill818/aws-node-termination-handler

A Kubernetes Daemonset to gracefully handle EC2 instance shutdown

https://aws.amazon.com/ec2

fork in 2 months

push eventtoneill818/pulsar-helm-chart

Thomas O'Neill

commit sha a65c5cd0da1c2f01c083a5891e7ef69a7f9490b7

Changed chart version to {pulsar-version}-{minor-version}

view details

push time in 2 months

Pull request review commentapache/pulsar-helm-chart

Allow Grafana to work with a reverse proxy

 apiVersion: v1 appVersion: "2.6.0" description: Apache Pulsar Helm chart for Kubernetes name: pulsar-version: 2.6.0+version: 2.6.1

I can do that, the appVersion will match the pulsar version the chart is running. The helm version and pulsar version are different. Do you want them the same so its easy to know what version you are running if you use helm?

toneill818

comment created time in 2 months

Pull request review commentapache/pulsar-helm-chart

Allow Grafana to work with a reverse proxy

 grafana:     targetPort: 3000     annotations: {}   plugins: []+  ## Grafana configMap+  ## templates/grafana-configmap.yaml+  ##+  configData: {}   ## Grafana ingress   ## templates/grafana-ingress.yaml   ##   ingress:     enabled: false-    annotations:

They get merged with other values if a user provides annotations. This also matches the other ingress values. So if I am not using nginx ingress, it still attaches the nginx ingress annotations.

toneill818

comment created time in 2 months

PR opened apache/pulsar-helm-chart

Allow Grafana to work with a reverse proxy

Motivation

Allow Grafana to be served from a sub path.

Modifications

  • Added a config map to add extra environment variables to the grafana deployment. As the grafana image adds new features that require environment variables, this can be used to set them.
  • Bumped the grafana image to allow a reverse proxy
  • removed ingress annotations as they are specific to nginx, and to match all the other ingresses
  • bumped the chart version as per the README

Example values:

grafana:
  configData:
    GRAFANA_ROOT_URL: /pulsar/grafana
    GRAFANA_SERVE_FROM_SUB_PATH: "true"
  ingress:
      enabled: true
      port: 3000
      path: "/pulsar/grafana/?(.*)"
      annotations:
        nginx.ingress.kubernetes.io/rewrite-target: /$1
+41 -7

0 comment

4 changed files

pr created time in 2 months

create barnchtoneill818/pulsar-helm-chart

branch : grafana-ingress

created branch time in 2 months

pull request commentstreamnative/apache-pulsar-grafana-dashboard

Allow grafana to run behind a reverse proxy

@sijie Bumped the version.

toneill818

comment created time in 2 months

push eventtoneill818/apache-pulsar-grafana-dashboard

Thomas O'Neill

commit sha 5a278245fc21e5f4344c5a47738e27d2b4726ad0

Version bump

view details

push time in 2 months

pull request commentstreamnative/apache-pulsar-grafana-dashboard

Allow grafana to run behind a reverse proxy

What determines a version bump? Should this PR set the version to 0.0.10?

toneill818

comment created time in 2 months

PR opened streamnative/apache-pulsar-grafana-dashboard

Allow grafana to run behind a reverse proxy

This adds the option to specify GRAFANA_DOMAIN, GRAFANA_ROOT_URL and GRAFANA_SERVE_FROM_SUB_PATH environment variables, to set the values to run behind a reverse proxy.

+9 -3

0 comment

1 changed file

pr created time in 2 months

create barnchtoneill818/apache-pulsar-grafana-dashboard

branch : reverse-proxy-support

created branch time in 2 months

create barnchtoneill818/pulsar-helm-chart

branch : documentation-fixes

created branch time in 2 months

issue commentaws/containers-roadmap

[ECS] service should let the user specify retry timeout/attempts for deployments

@pavneeta Having the taskLaunchFaultTolerance option will be great. Are you able to provide any update on this?

nhmaha

comment created time in 2 months

issue commentroboll/helmfile

Support Complex Types With Environment Files

Was able to do this by looping over and templating the helmfile

toneill818

comment created time in 3 months

issue closedroboll/helmfile

Support Complex Types With Environment Files

Currently the following does not work: env.yaml

complexType:
  -  object1Item1: object1Value1
     object1Iitem2: object1Value2
  -  object2Item1: object2Value1
     object2Item2: object2Value2

helmfile.yaml

values:
   - complexType: {{ .Environment.Values.complexType }}

It sets the value to [map[object1Item1:object1Value1 object1Item2:object1Value2], [object2Item1: object2Value1, object2Item2: object2Value2]]

It would be nice to be able to specify complex types within the environment files.

closed time in 3 months

toneill818

issue openedroboll/helmfile

Support Complex Types With Environment Files

Currently the following does not work: env.yaml

complexType:
  -  object1Item1: object1Value1
     object1Iitem2: object1Value2
  -  object2Item1: object2Value1
     object2Item2: object2Value2

helmfile.yaml

values:
   - complexType: {{ .Environment.Values.complexType }}

It sets the value to [map[object1Item1:object1Value1 object1Item2:object1Value2], [object2Item1: object2Value1, object2Item2: object2Value2]]

It would be nice to be able to specify complex types within the environment files.

created time in 3 months

fork toneill818/helmfile

Deploy Kubernetes Helm Charts

fork in 3 months

more