profile
viewpoint
Sindre Sorhus sindresorhus https://sindresorhus.com Full-Time Open-Sourcerer ·· Maker ·· Into Swift and Node.js

pull request commentsindresorhus/get-urls

Add requireScheme flag

Maybe also add a note that when it’s off it will match things like unicorn.education.

osdiab

comment created time in 18 hours

pull request commentsindresorhus/get-urls

Add requireScheme flag

Hmm, sorry, I missed that it also affects www, so the option should be requireSchemeOrWww to be explicit. Also use the scheme word instead of protocol.

osdiab

comment created time in 18 hours

pull request commentsindresorhus/get-urls

Add strict url parsing flag

Not sure how this ought to work with the extractFromQueryString param since I never use that - should it just forward the flag there?

I don't think it should apply there as it will be too ambiguous.

osdiab

comment created time in 19 hours

pull request commentsindresorhus/get-urls

Add strict url parsing flag

The option name makes sense for the regex, but not here, as including www and protocol-less URLs is actually looser. I think it should be called requireScheme and default to true.

osdiab

comment created time in 19 hours

push eventsindresorhus/sindresorhus.github.com

Sindre Sorhus

commit sha eb68ddce8b8586596a7351ae818bc120a8436247

Add Dato FAQ

view details

push time in 20 hours

issue openedsindresorhus/Defaults

Add ability to subscribe to multiple keys or any change in a given suite

This can be useful when you need to handle changes to multiple keys the same.

Should support optionally giving an array or keys or if not given subscribe to all changes.

Something like this:

Defaults.observeAll<T: Codable>(
	_ keys: Defaults.Key<T>,
	options: NSKeyValueObservingOptions = [.initial, .old, .new],
	handler: @escaping () -> Void
) -> DefaultsObservation

Defaults.observeAll<T: Codable>(
	suite: UserDefaults = .standard,
	options: NSKeyValueObservingOptions = [.initial, .old, .new],
	handler: @escaping () -> Void
) -> DefaultsObservation

Might be useful with change objects to, but not sure how to handle that.

Feedback wanted.

created time in 21 hours

release sindresorhus/internal-ip

v5.0.0

released time in a day

created tagsindresorhus/internal-ip

tagv5.0.0

Get your internal IP address

created time in a day

push eventsindresorhus/internal-ip

Sindre Sorhus

commit sha 6467da314db91f8f879b0ad355f2e5725507dfb1

Return `undefined` instead of `null` when gateway cannot be determined

view details

Sindre Sorhus

commit sha 85e981f1c60ac73ec1b15f70aa8132be39eacf66

5.0.0

view details

push time in a day

push eventsindresorhus/node-module-boilerplate

Richie Bendall

commit sha 9b8dc81a35acfbd3b75f7f19c9679e4f83b36df3

Use Markdown for line break instead of HTML element (#20)

view details

push time in a day

pull request commentsindresorhus/node-module-boilerplate

Use Markdown for line break instead of HTML element

Ah, I was not aware of that. Great.

Richienb

comment created time in a day

PullRequestEvent

PR merged sindresorhus/eslint-plugin-unicorn

Add `docs` -> `documentation` replacement to `prevent-abbreviations`

https://github.com/sindresorhus/eslint-plugin-unicorn/pull/387#discussion_r332567404

+6 -5

0 comment

2 changed files

fisker

pr closed time in a day

push eventsindresorhus/eslint-plugin-unicorn

fisker Cheung

commit sha dbf4b7996a1aba6deef51916a5435092c130b34e

Add `docs` -> `documentation` replacement to `prevent-abbreviations` (#420)

view details

push time in a day

pull request commentsindresorhus/node-module-boilerplate

chore: Use markdown for line break instead of html element

The backslash is not part of the Markdown spec, so I don't really want to depend on it.

Richienb

comment created time in a day

delete branch sindresorhus/internal-ip

delete branch : node-8

delete time in a day

push eventsindresorhus/internal-ip

silverwind

commit sha 15425f12cf3ea3a58cf0a54f1ccd5f87b7b26f75

Update dependencies and require Node.js 8 (#28)

view details

push time in a day

PR merged sindresorhus/internal-ip

Update dependencies and require Node.js 8
  • default-gateway@5 requires node 8 and brings various minor fixes
  • ava@2 requires node 8.9.4
  • removed module.exports.default as mentioned in the TODO
  • fixed linting issues
+14 -16

4 comments

4 changed files

silverwind

pr closed time in a day

PR closed sindresorhus/dot-prop

Add array access documentation to README

It wasn't obvious to me how to access arrays, so after finding out how to do it, I thought others would benefit from the addition to the README

+3 -0

1 comment

1 changed file

benlieb

pr closed time in a day

pull request commentsindresorhus/dot-prop

Add array access documentation to README

That's just a side-effect of arrays being objects. It's not officially supported and we have no tests for it. Open an issue instead about adding official support.

benlieb

comment created time in a day

issue closedsindresorhus/strip-json-comments

UMD ES5 format for browser use?

Could the library be made to support ES5, you think?

closed time in a day

Spiralis

issue commentsindresorhus/strip-json-comments

UMD ES5 format for browser use?

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser. You can find a more detailed explanation here: https://github.com/sindresorhus/ama/issues/446

If you use Webpack, check out babel-engine-plugin, which transpiles only the dependencies that needs to be transpiled.

If you use Create React App, upgrade to Create React App v2. It supports automatic transpilation of dependencies, which will make this package just work.

Spiralis

comment created time in a day

issue closedsindresorhus/is-plain-obj

Remove arrow syntax for browser compatibility

Hello,

If you want this project to be browser compatible, I'd suggest replacing the arrow syntax in module.exports = value => with module.exports = function (value) as a lot of build tools (Ie. Babel) will not transpile node_modules into ES5 by default. Using arrow syntax here shouldn't be functionally different than function syntax.

Regards.

closed time in a day

okmediagroup

issue commentsindresorhus/is-plain-obj

Remove arrow syntax for browser compatibility

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser. You can find a more detailed explanation here: https://github.com/sindresorhus/ama/issues/446

If you use Webpack, check out babel-engine-plugin, which transpiles only the dependencies that needs to be transpiled.

If you use Create React App, upgrade to Create React App v2. It supports automatic transpilation of dependencies, which will make this package just work.

okmediagroup

comment created time in a day

PR closed sindresorhus/awesome

Scratch 3.0 and micro:bit

YouTube playlist "Scratch 3.0 and micro:bit" with videos from PinkyPepper: https://www.youtube.com/playlist?list=PL01GjNVvxPl-oxB08u_V-FGJk2pX-LK7N.

I've put my videos about the micro:bit and Scratch 3.0 in one playlist for who's interested in this topic.

<!-- Congrats on creating an Awesome list! 🎉 -->

<!-- Please fill in the below placeholders -->

[Insert URL to the list here]

[Explain what this list is about and why it should be included here]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.<br>That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce. If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
    • To verify that you've read all the guidelines, please add comment with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash. <br>Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.<br>You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

+1 -1

1 comment

1 changed file

PinkyPepper

pr closed time in a day

push eventsindresorhus/internal-ip

Sindre Sorhus

commit sha 7928833df4b10bfe26e4d3c51b46ea6cb4640bf1

Update package.json

view details

push time in a day

pull request commentsindresorhus/open

Handle URL and paths escaping in Windows

https://github.com/sindresorhus/open/releases/tag/v7.0.0

herberttn

comment created time in a day

release sindresorhus/open

v7.0.0

released time in a day

created tagsindresorhus/open

tagv7.0.0

Open stuff like URLs, files, executables. Cross-platform.

created time in a day

push eventsindresorhus/open

Sindre Sorhus

commit sha d13bbe3881ba543aeaac800d9cd0001b3858b954

Meta tweaks

view details

Sindre Sorhus

commit sha ed757758dd556ae561b58b80ec7dee5e7c6ffddc

7.0.0

view details

push time in a day

pull request commentsindresorhus/open

Handle URL and paths escaping in Windows

@herberttn Thanks for your awesome work on this 🙌

herberttn

comment created time in a day

push eventsindresorhus/open

Herbert Treis Neto

commit sha 7ef15d29a8776737d2d097f02d117c2ec0439d58

Handle URL and path escaping on Windows (#146)

view details

push time in a day

PR merged sindresorhus/open

Handle URL and paths escaping in Windows

This fixes an old problem that has been widely reported but haven't had a simple and concrete solution yet. This is my attempt on making it happen 🙃

To sum up the problem: on windows, ampersand (&) characters were being escaped with caret (^) characters due to windows's cmd interpreting them as a command would break (as in command not found) or would forward a partial argument only (as in URLs with query arguments that contain spaces).

The solution: JavaScript's standard encodeURI function would solve the problem for URLs, but not for file paths (especially on windows). So we leverage the fact that window's cmd interprets a double-quoted argument as a plain text argument just by quoting it (like Node already does). For that to be consistent we need to disable Node's default quoting and escaping behavior (which is conditional) with its own windowsVerbatimArguments flag, and do it ourselves.

Tested in Windows with both Google Chrome and Internet Explorer, using query strings, spaces, pipes, fragments and multiple combinations of all of them.

  • Fixes #17: URL fragments
  • Fixes #44: URL query strings (ampersand escaping)
  • Fixes #55: URL query strings with local HTML files (ampersand escaping)
  • Fixes #77: File system path (ampersand escaping)
  • Fixes #101: URL query strings with local HTML files (ampersand escaping)
  • Fixes #115: Shell option is not needed since windowsVerbatimArguments is now used explicitly
  • Resolves #74: File system path (ampersand escaping)
  • Resolves #98: URL with pipe characters

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

+93 -2

4 comments

5 changed files

herberttn

pr closed time in a day

PR closed sindresorhus/open

Fix cannot open url contains `|` on windows
  • If contains space, DO NOT escape;
  • otherwise, DO escape.
  • No matter target is URL, or file path.
  • Escape Character: & \ < > ^ |

Detail in #74 (comment).

+3 -1

13 comments

1 changed file

baoti

pr closed time in a day

issue closedsindresorhus/open

Open local HTML file URL with a query string

When I try and open a local HTML file URL, and I add a query string, then it doesn't work.

Please make it possible to add query strings when opening local files, like opn('/file.html?123').

closed time in a day

garyking

issue closedsindresorhus/open

Use the `childProcess.spawn` `shell` option on Windows and fix the quote issue

<!-- Issuehunt Badges --> <img alt="Issuehunt badges" src="https://img.shields.io/badge/IssueHunt-%2440%20Funded-%2300A156.svg" /> <!-- /Issuehunt Badges -->

It might simplify some of the ugly command and escaping logic:

https://github.com/sindresorhus/opn/blob/15caf1c276f1251c9cf8c9cebd40c5ec0681a8c9/index.js#L34-L36

And fix the quote issue: https://github.com/sindresorhus/opn/issues/77

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Backers (Total: $40.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

closed time in a day

sindresorhus

issue closedsindresorhus/open

on windows, can't opn a directory with an ampersand

<!-- Issuehunt Badges --> <img alt="Issuehunt badges" src="https://img.shields.io/badge/IssueHunt-%2430%20Funded-%2300A156.svg" /> <!-- /Issuehunt Badges -->

The following line escapes ampersands on windows. https://github.com/sindresorhus/opn/blob/b9f7e569f5a3d5d520047df3e9f10a42d52fd9d4/index.js#L36

This breaks opening local files and directories where the path contains ampersands.

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Backers (Total: $30.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

closed time in a day

TanninOne

issue closedsindresorhus/open

Bug opening file path html file with query param

System: Linux (Ubuntu 14.04) opn version: 5.1.0 xdg-open version: 1.1.2

File path with query param doesn't work:

$ ~/node_modules/opn/xdg-open /some/path/index.html?hi
xdg-open: file '/usr/local/google/home/chenwilliam/lighthouse/plots/charts/index.html?hi' does not exist

File path without query param works as expected and opens page in Chrome:

$ ~/node_modules/opn/xdg-open /some/path/index.html
Created new window in existing browser session.

Regular URL path with query param works:

https://www.paulirish.com/?hi

Seems related to this issue? https://bugs.freedesktop.org/show_bug.cgi?id=45857

closed time in a day

wwwillchen

issue closedsindresorhus/open

Incorrectly add "^" before "&" in url query strings

I haven't really looked into index.js for this problem, but this doesn't occur on all urls. This only occurs when I have a space in the url I am trying to open. To reproduce this issue on windows 10, do opn('https://www.google.com/#q=12 3&*', {app: 'Chrome'}) and the url in the browser will be https://www.google.com/#q=12 3^&*, however, if I do opn('https://www.google.com/#q=123&*', {app: 'Chrome'}) the url opened in the browser is not modified. I noticed there is a regex replacement target.replace(/&/g, '^&') in index.js, but im not sure why it doesn't replace all the &s with ^&

closed time in a day

JackCai1206

issue closedsindresorhus/open

Strips querystring from URL if it precedes with # in Windows 10 - Chrome

Following code works fine - opens the exact URL in chrome.

var open = require("opn");
open('http://codef0rmer.github.io/eShell/index.html#/1?name=foobar', {app: 'chrome'});

However, if Chrome is a default browser and it's not mentioned then both hash and querystrings are stripped.

var open = require("opn");
open('http://codef0rmer.github.io/eShell/index.html#/1?name=foobar');

Any idea why spawn strips querystring?

closed time in a day

codef0rmer

pull request commentsindresorhus/execa

Add `error.signalDescription`

Why are you even transpiling? Seems like you have a lot of tooling and output bloat/complexity just to be able to use import/export (as the target Node.js version supports most other things). All you really need is https://babeljs.io/docs/en/babel-plugin-transform-modules-commonjs

ehmicky

comment created time in a day

push eventsindresorhus/execa

ehmicky

commit sha ff25ab06cc83da47231f1b9423593a8d43ad646a

Add `execPath` option (#377)

view details

push time in a day

delete branch sindresorhus/execa

delete branch : feature/exec-path-option

delete time in a day

PR merged sindresorhus/execa

Add `execPath` option

Fixes #153 Fixes #196

This adds an execPath option to modify which Node.js executable to use in child processes.

See here for some use cases.

+38 -2

0 comment

6 changed files

ehmicky

pr closed time in a day

issue closedsindresorhus/execa

preferLocal prevents local from working

https://github.com/sindresorhus/execa/issues/191#issuecomment-477650346

Yarn already sets the PATH when running scripts so that the right Yarn binary (and all other binaries that your application should have access to) is always in the PATH. But because execa modifies it as well (and it does it without actually knowing which paths it should use, it only makes assumptions), it ends up overriding the Yarn-generated folder. In the end, the wrong files are called.

I would strongly suggest defaulting it to false, as it's very intrusive and can lead to pretty hard to debug issues (I myself spent an indecent amount of time trying to figure out what happened before I started to consider that maybe execa was doing something strange).

Example:

package.json

{
  "dependencies": {
    "execa": "^1.0.0"
  },
  "scripts": {
    "foo": "yarn --version",
    "bar": "node ./example.js"
  }
}

example.js

const execa = require('execa');

execa('yarn', ['--version']).then(v => {
  console.log(v.stdout);
});

command line

# npm installs the bins in the same folder as Node, so `node` and `yarn` are siblings
$> npm install -g yarn@1.15.1

# This command enforces the Yarn version inside this one project
$> yarn policies set-version 1.15.2

$> yarn foo
1.15.2

$> yarn bar
1.15.1

In this case, you see that Yarn rightfully enforced the use of the 1.15.2 release when calling foo. Unfortunately, since execa overrides the PATH with dirname(node), it also overrode in the process the Yarn binary that we set in the path, which causes the wrong one to be used.

It's even more of a problem with Plug'n'Play, since we inject the path to the binaries within the PATH (rather than always injecting the same node_modules/.bin folder). A similar problem then occurs where if you previously ran npm install -g babel-cli, then your execa scripts will use it instead of the local one.

closed time in a day

arcanis

Pull request review commentsindresorhus/execa

Add `execPath` option

 declare namespace execa { 		*/ 		readonly localDir?: string; +		/**+		Path to the Node.js executable to use in child processes.++		This can be either an absolute path or a path relative to the `cwd` option.++		Requires `preferLocal` to be `true`.

Nah, it's fine.

ehmicky

comment created time in a day

push eventsindresorhus/execa

Sindre Sorhus

commit sha 484036e21b90bce68ec892215fd43179bafb52c1

Update index.d.ts

view details

push time in a day

push eventsindresorhus/execa

Sindre Sorhus

commit sha dd1989f600704f97b2e1326fe5764b013e6fc02d

Update readme.md

view details

push time in a day

pull request commentsindresorhus/weechat-notification-center

Allow whitelisted channels to notify on all messages

Channels specified in the channels option (separated by commas) will create notifications for all new messages.

Is there no way to make a config with a list/array value?

gpanders

comment created time in a day

pull request commentsindresorhus/weechat-notification-center

Allow whitelisted channels to notify on all messages

Can you document the option in the readme?

gpanders

comment created time in a day

pull request commentsindresorhus/internal-ip

Update dependencies and misc tweaks

You also have to update https://github.com/sindresorhus/internal-ip/blob/5491cbc3447b51e0f818fe6086bc530ed35e338e/package.json#L13

silverwind

comment created time in a day

Pull request review commentsindresorhus/internal-ip

Update dependencies and misc tweaks

 internalIp.v6.sync = () => sync('v6'); internalIp.v4.sync = () => sync('v4');  module.exports = internalIp;-// TODO: Remove this for the next major release-module.exports.default = internalIp;

Yes: https://github.com/sindresorhus/internal-ip/blob/5491cbc3447b51e0f818fe6086bc530ed35e338e/index.d.ts#L49-L50

silverwind

comment created time in a day

push eventsindresorhus/internal-ip

Sindre Sorhus

commit sha 718192d80b81fdaf5aec8b86a44a9b11a81a8af9

Update index.js

view details

push time in a day

push eventsindresorhus/alfy

Muhammad Rivki

commit sha bb5c6b887809dc4824a4c57ab6eb3c180393385b

Add alfred-github-trending to Users section (#115)

view details

push time in 2 days

push eventmikqi/alfy

Sindre Sorhus

commit sha 2c557a35478921ef104e1b29b8deb2dbac953ef8

Update readme.md

view details

push time in 2 days

Pull request review commentsindresorhus/alfy

Add alfred-github-trending to Users section

 Non-synced local preferences are stored within `Alfred.alfredpreferences` under - [alfred-trello](https://github.com/mblode/alfred-trello) - Search your boards, quickly add cards, and view list of cards for Trello - [alfred-npm-versions](https://github.com/mrmartineau/alfred-npm-versions) - Lookup the latest 15 versions for an npm package - [alfred-travis-ci](https://github.com/adriantombu/alfred-travis-ci) - Check the status of your Travis CI builds+- [alfred-github-trending](https://github.com/mikqi/alfred-github-trending) - Search trending repository on GitHub
- [alfred-github-trending](https://github.com/mikqi/alfred-github-trending) - Search trending repositories on GitHub
mikqi

comment created time in 2 days

push eventsindresorhus/sindresorhus.github.com

Sindre Sorhus

commit sha 77033afa4ecd97411ade898a1eb941a8d611d016

Use correct App Store badge for Blear Fixes sindresorhus/Blear#14

view details

push time in 2 days

issue closedsindresorhus/Blear

Wrong App Store button image on website

The current download button on website shows "Download on the Mac App Store", which is not appropriate for an iOS app.

closed time in 2 days

xiao99xiao

push eventsindresorhus/sindresorhus.github.com

Sindre Sorhus

commit sha 2d3072dbd8699925da75d762acde2760e642c37c

Improve the Dato page

view details

push time in 2 days

release sindresorhus/pure

v1.11.0

released time in 2 days

push eventsindresorhus/pure

Sindre Sorhus

commit sha 2e354b80deae105ea246699c49e65dcd4fe8b759

1.11.0

view details

push time in 2 days

created tagsindresorhus/pure

tagv1.11.0

Pretty, minimal and fast ZSH prompt

created time in 2 days

pull request commentsindresorhus/pure

Add coloring for git dirty-asterisk

Thanks for this awesome contribution :)

pgoodbread

comment created time in 2 days

push eventsindresorhus/pure

Philip Goodbread

commit sha 4bbb11383f6287270f58dace0b388409b785edcd

Add coloring for git dirty-asterisk (#491)

view details

push time in 2 days

PR merged sindresorhus/pure

Add coloring for git dirty-asterisk

I added an option to define the coloring of only the asterisk on the git branch, because I tend to overlook it, if it is the same color

+8 -4

1 comment

2 changed files

pgoodbread

pr closed time in 2 days

pull request commentsindresorhus/awesome

Add Imba

Removing the description is not what I asked.

shapkarin

comment created time in 2 days

pull request commentsindresorhus/gulp-size

Added 'passthrough' option

What's you use-case for this?

You also need to fix the lint issues. Make sure you run npm test locally and that it passes.

br0wnie

comment created time in 2 days

PR closed sindresorhus/timed-out

Change expected value in 'should clear socket timeout for keep-alive sockets'

In WSL nothing works in a clean manjaro installation, all tests works except the one in the title. fixed reading docs

+4 -4

2 comments

1 changed file

Janluke0

pr closed time in 2 days

pull request commentsindresorhus/timed-out

Change expected value in 'should clear socket timeout for keep-alive sockets'

Closing in favor of https://github.com/sindresorhus/timed-out/pull/24

Janluke0

comment created time in 2 days

PR closed sindresorhus/timed-out

Fix tests, remove unnecessary exit-clause

Fixes #19

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

+3 -5

2 comments

1 changed file

bblommers

pr closed time in 2 days

pull request commentsindresorhus/timed-out

Fix tests, remove unnecessary exit-clause

Closing in favor of https://github.com/sindresorhus/timed-out/pull/24

bblommers

comment created time in 2 days

PR merged sindresorhus/timed-out

Fix skipped tests

Fixes previously skipped tests. Fixes #19.

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

+9 -5

1 comment

1 changed file

danedavid

pr closed time in 2 days

issue closedsindresorhus/timed-out

Fix tests

<!-- Issuehunt Badges --> <img alt="Issuehunt badges" src="https://img.shields.io/badge/IssueHunt-%2440%20Funded-%2300A156.svg" /> <!-- /Issuehunt Badges -->

A couple of tests were failing, so they are skipped. Would be nice to figure out why they are failing now.

  • https://github.com/sindresorhus/timed-out/blob/9cc4ef15197e9017dd84e2639bbb7a6e09f3adf7/test.js#L21-L34
  • https://github.com/sindresorhus/timed-out/blob/9cc4ef15197e9017dd84e2639bbb7a6e09f3adf7/test.js#L194-L231

<!-- Issuehunt content -->


<details> <summary> <b>IssueHunt Summary</b> </summary>

Backers (Total: $40.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor </details> <!-- /Issuehunt content-->

closed time in 2 days

sindresorhus

push eventsindresorhus/timed-out

Dane David

commit sha 4292317a05601e144eb445bafc37ed09e0f602ec

Fix skipped tests (#24)

view details

push time in 2 days

Pull request review commentsindresorhus/timed-out

Fix skipped tests

 describe('when connection is established', () => {  		request.on('socket', socket_ => { 			socket_.once('connect', () => {-				assert.equal(socket_.timeout, 100);+				assert.equal(isNaN(socket.timeout) ? socket._idleTimeout : socket.timeout, 100);

That's a better check, indeed.

danedavid

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `execPath` option

 declare namespace execa { 		*/ 		readonly localDir?: string; +		/**+		Path to the Node.js executable to use in child processes.+

Would be great to include the use-cases for this option.

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `execPath` option

 declare namespace execa { 		*/ 		readonly localDir?: string; +		/**+		Path to the Node.js executable to use in child processes.++		This can be either an absolute path or a path relative to the `cwd` option.++		Requires `preferLocal` to be `true`.

Why does it require preferLocal to be true? Maybe include a short reasoning here.

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `error.signalDescription`

 declare namespace execa { 		killed: boolean;  		/**-		The signal that was used to terminate the process.+		The name of the signal that was used to terminate the process.

Unrelated to this PR, but I just noticed, when something can be undefined, we should try to describe in what scenarios it's defined vs undefined. This can be a big help for the user in knowing when it will be used.

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `error.signalDescription`

 if (process.platform !== 'win32') { 		t.is(signal, 'SIGINT'); 	}); +	test('error.signalDescription is defined', async t => {+		const cp = execa('noop');

Let's try to use subprocess instead of cp everywhere. Maybe we should add it to https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/prevent-abbreviations.md

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `error.signalDescription`

 Whether the process was killed.  Type: `string | undefined` -The signal that was used to terminate the process.+The name of the signal that was used to terminate the process.++#### signalDescription++Type: `string | undefined`

Should be start using

Type: `string?`

?

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `error.signalDescription`

 declare namespace execa { 		killed: boolean;  		/**-		The signal that was used to terminate the process.+		The name of the signal that was used to terminate the process. 		*/ 		signal?: string;++		/**+		A human-friendly description of the signal that was used to terminate the process.

We should also be explicit about that there might be signals with a signalDescription. So users should assume that signalDescription will be defined if signal is.

ehmicky

comment created time in 2 days

Pull request review commentsindresorhus/execa

Add `error.signalDescription`

 declare namespace execa { 		killed: boolean;  		/**-		The signal that was used to terminate the process.+		The name of the signal that was used to terminate the process. 		*/ 		signal?: string;++		/**+		A human-friendly description of the signal that was used to terminate the process.

Can you mention that it's already included in the default Execa error message? So users don't try to be smart and include it themselves and getting it double.

Can you also include a short example of what the description looks like for a signal? (readme too)

ehmicky

comment created time in 2 days

pull request commentsindresorhus/execa

Add `error.signalDescription`

human-signals brings in https://github.com/zloirock/core-js as a dependency, which I don't think is intentional. If it is, that's not great as it's huge.

ehmicky

comment created time in 2 days

pull request commentsindresorhus/execa

Add `error.signalDescription`

human-signals is great, but it kinda feels like something that should be built-in Node.js. Worth opening an issue on the Node.js issue tracker about that?

ehmicky

comment created time in 2 days

startedehmicky/human-signals

started time in 2 days

pull request commentsindresorhus/refined-github

Add `dim-bots` feature

I don't think this feature should be disabled for repo owners. When I look at a commit list or closed PR list in my own repo, I want to focus on the real changes, just like a visitor (or contributor) does.

So don't use spammy bots in the first place?

fregante

comment created time in 2 days

pull request commentsindresorhus/p-event

Include all rejection arguments with `multiArgs`

Because it's such an uncommon case, I think it should be a separate option, as people would want multiArgs for normal events, but not for error. We should also make it clear that multiArgs doesn't apply to errors. This also has the benefit of not requiring a major release. What do you think?

pvdlg

comment created time in 2 days

pull request commentsindresorhus/awesome

Add Imba

You're still not following all the guidelines:

Includes a succinct description of the project/theme at the top of the readme. (Example) ✅ Mobile operating system for Apple phones and tablets. ✅ Prototyping interactive UI designs. ❌ Resources and tools for iOS development. ❌ Awesome Framer packages and tools.

shapkarin

comment created time in 3 days

pull request commentsindresorhus/ora

[WIP] Fix `discardStdin` option

What do you think about just disabling this feature on Windows?

Yes, sounds good. I just want to get out a fix. We can open an issue afterwards in case anyone wants to look into adding Windows support to the option.

stroncium

comment created time in 3 days

pull request commentsindresorhus/type-fest

fix(JsonObject): allow all keys to be optional

@SamVerschueren Is this what you had in mind?

yxliang01

comment created time in 3 days

pull request commentsindresorhus/query-string

Add option to skip null and undefined values in stringify

the option should be called skipNull

This

yaodingyd

comment created time in 3 days

pull request commentsindresorhus/query-string

Only parse '+' to ' ' when decode is true (#119)

Shouldn't encode be changed too then?

Anusien

comment created time in 3 days

issue commentsindresorhus/dark-mode

New release

Done: https://github.com/sindresorhus/dark-mode/releases/tag/v3.0.0

fxcoudert

comment created time in 3 days

release sindresorhus/dark-mode

v3.0.0

released time in 3 days

created tagsindresorhus/dark-mode

tagv3.0.0

Control the macOS dark mode from the command-line

created time in 3 days

push eventsindresorhus/dark-mode

Sindre Sorhus

commit sha d95fcfdc9ee0f38ab201ce2c63c5d36036889e33

3.0.0 Closes #16

view details

push time in 3 days

issue closedsindresorhus/dark-mode

New release

The latest released version does not compile with Xcode 11 (because of the swift version used). Could you release a new version so we can ship it in Homebrew?

closed time in 3 days

fxcoudert
more