profile
viewpoint

containers/docker-lvm-plugin 100

Docker volume plugin for LVM volumes

rapidsai/spark-examples 38

RAPIDS Spark examples

shishir-a412ed/docker-lvm-plugin 4

Docker Volume Driver for lvm volumes.

shishir-a412ed/runc-notify 2

Tool for testing systemd notify (sd_notify) integration with runc containers.

shishir-a412ed/Algorithms 1

Algorithms and data structures in golang.

shishir-a412ed/docker 1

Docker - the open-source application container engine

shishir-a412ed/Docker-Migrate 1

Tool for migrating docker from one backend storage to another

shishir-a412ed/atomic 0

Atomic Run Tool for installing/running/managing container images.

shishir-a412ed/atomic-site 0

Source code for projectatomic.io

shishir-a412ed/awesome-docker 0

:whale: A curated list of Docker resources and projects

issue commenthashicorp/nomad

update gopsutil

@tgross Looking at the existing vendor/vendor.json. It seems I need to vendor github.com/shirou/gopsutil/host and NOT github.com/shirou/gopsutil

I am getting the following error when I try:

  1. govendor fetch github.com/shirou/gopsutil/host@=v2.20.1
  2. govendor fetch github.com/shirou/gopsutil/host@v2.20.1
Error: No label found for specified version "=v2.20.1" from github.com/shirou/gopsutil/host::github.com/hashicorp/gopsutil/host@=v2.20.1
Failed to fetch package "github.com/shirou/gopsutil/host"
github.com/kardianos/govendor/context.(*Context).Alter
	/home/smahajan/go/src/github.com/kardianos/govendor/context/modify.go:712
github.com/kardianos/govendor/run.(*runner).Modify
	/home/smahajan/go/src/github.com/kardianos/govendor/run/modify.go:152
github.com/kardianos/govendor/run.(*runner).run
	/home/smahajan/go/src/github.com/kardianos/govendor/run/run.go:98
github.com/kardianos/govendor/run.Run
	/home/smahajan/go/src/github.com/kardianos/govendor/run/run.go:44
main.main
	/home/smahajan/go/src/github.com/kardianos/govendor/main.go:35
runtime.main
	/usr/local/go/src/runtime/proc.go:203
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1357

Any idea what's going wrong? Also I observed that gopsutil uses dep and HashiCorp is using govendoring. Not sure if these two being different dependency management systems is causing a problem.

tgross

comment created time in 3 days

issue commenthashicorp/nomad

update gopsutil

@tgross I tried to vendor gopsutil into nomad using go vendoring.

$$ govendor fetch github.com/shirou/gopsutil@v2.20.1

It is updating a bunch of files, however it doesn't update the file which has the fix (/host/host_linux.go). Any idea what's going wrong?

smahajan@smahajan-VirtualBox:~/go/src/github.com/hashicorp/nomad$ git status
On branch vendor_update
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   vendor/vendor.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	vendor/github.com/shirou/gopsutil/Gopkg.lock
	vendor/github.com/shirou/gopsutil/Gopkg.toml
	vendor/github.com/shirou/gopsutil/Makefile
	vendor/github.com/shirou/gopsutil/README.rst
	vendor/github.com/shirou/gopsutil/coverall.sh
	vendor/github.com/shirou/gopsutil/doc.go
	vendor/github.com/shirou/gopsutil/mktypes.sh
	vendor/github.com/shirou/gopsutil/v2migration.sh
	vendor/github.com/shirou/gopsutil/windows_memo.rst
tgross

comment created time in 10 days

issue commenthashicorp/nomad

Docker driver security_opts field doesn't match flag behavior

@tgross Thanks! Let me start with (1). Can you point me to the docs in the codebase where (1) needs to be updated? I browsed through the codebase but don't see a folder for documentation.

On a different note, I was also looking to fix #6957 . I see you merged a fix in gopsutil however it has still not been vendor'ed into nomad. It looks like nomad doesn't use go modules or dep (I didn't see a go.mod or Gopkg.toml file). Which vendoring do you guys use?

Any specific reason not to upgrade to go modules (In my experience coming from dep, go mod is a much better dependency management system 🙂 ).

tgross

comment created time in 12 days

issue commentcontainers/docker-lvm-plugin

Docker volume inspect showing incorrect size after increasing volume size

Is there still no solution available for this problem?

@L4rS6 This is not on my immediate priority list, but I will try to investigate when I get a chance. PR's are welcome 🙂 if you wanna propose a PR with the fix.

tanvir-ahmed-m4

comment created time in 13 days

issue commenthashicorp/nomad

Docker driver security_opts field doesn't match flag behavior

@tgross I am looking to contribute to nomad, and this is a good first issue I can take a stab at! Can you point me to where we need to update the documentation for this?

Are you looking for (1) or (2) or Both?

  1. Just update the doc to say, that this error is expected since nomad client is directly using docker HTTP API instead of Docker CLI. It works directly with docker since Docker CLI does the command line parsing of security opts (e.g seccomp profile) before hitting the docker HTTP API.

  2. Change the nomad docker task driver to do the parsing before hitting the docker HTTP API.

Also, Is there a slack/IRC for new contributors who have newbie questions?

tgross

comment created time in 13 days

push eventcontainers/docker-lvm-plugin

TomSweeneyRedHat

commit sha 2e18c3efae232a7fdf53d8c5f979fd9d8cc85616

Add Code of Conduct Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

view details

Shishir

commit sha 4ab20cd06fbd4b192a16886fba632947c3d856ff

Merge pull request #83 from TomSweeneyRedHat/coc Add Code of Conduct

view details

push time in 16 days

PR merged containers/docker-lvm-plugin

Reviewers
Add Code of Conduct

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

As the title says

+3 -0

1 comment

1 changed file

TomSweeneyRedHat

pr closed time in 16 days

pull request commentcontainers/docker-lvm-plugin

Add Code of Conduct

LGTM.

TomSweeneyRedHat

comment created time in 16 days

startedmitchellh/gox

started time in a month

fork shishir-a412ed/nomad

Nomad is an easy-to-use, flexible, and performant workload orchestrator that can deploy a mix of microservice, batch, containerized, and non-containerized applications. Nomad is easy to operate and scale and has native Consul and Vault integrations.

https://www.nomadproject.io/

fork in a month

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 8cb55b322bf1b4869bb4835a73357ba3187cffa7

Add tests. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 1b61e457047e8ea2f4931f3cd47b8e8c3e268cd6

Add tests. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 2060912653cacce612983adb4a05164268be76ca

Add tests. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha d508a7eac7d27a79cc81c2229c8d70b79e5d4ef3

Add tests. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 82e37b6c58f2158d1eb3dcb8dffb602eb2b34d37

Add tests. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

create barnchshishir-a412ed/docker-lvm-plugin-1

branch : tests

created branch time in 3 months

issue closedcontainers/docker-lvm-plugin

lvremove without lvchange

I notice that the code does an lvremove --force $device instead of lvchange -a n $device followed by lvremove $device. I think the latter is usually preferred. This might be deliberate on your part, though, if you want to do the remove as a single atomic action. Heads up, just in case.

closed time in 3 months

mortya

issue commentcontainers/docker-lvm-plugin

lvremove without lvchange

Keeping it as an atomic operation lvremove --force $device for now.

mortya

comment created time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 65dacf316c8b5a97c8832d5733cf8fc8774317bf

Add section for optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Daniel J Walsh

commit sha 5dff817a4ace3d9c11284c25ac31ba345d9ce823

Merge pull request #82 from shishir-a412ed/optional_vg_readme Add section for optional volume group.

view details

push time in 3 months

PR opened containers/docker-lvm-plugin

Reviewers
Add section for optional volume group. documentation

Signed-off-by: Shishir Mahajan shishirm@nvidia.com

+9 -0

0 comment

1 changed file

pr created time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 65dacf316c8b5a97c8832d5733cf8fc8774317bf

Add section for optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha 4bd90f8c23d07338cad31a0ec5dfbd29e108a7a3

Add section for optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha b9e2ca0b16caa6120729a108e7baf735d31383b6

Add section for optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

create barnchshishir-a412ed/docker-lvm-plugin-1

branch : optional_vg_readme

created branch time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Alexander Eichhorn

commit sha 6c1d788e639f227a4df9dfd63944941724499f8a

Add optional argument to select volume group Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 72aa7cf5e04773064cbca266a108ec2b3020d757

Fix review comments. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 77df5cc425a71ad2d4ad0771fdfbb2f86c0c41f0

Fix volume inspect with optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir

commit sha 0c093d971788811582236d83fe71dc24a79ecb8b

Merge pull request #79 from shishir-a412ed/volume_group Add optional argument to select volume group

view details

push time in 3 months

push eventcontainers/docker-lvm-plugin

Alexander Eichhorn

commit sha 6c1d788e639f227a4df9dfd63944941724499f8a

Add optional argument to select volume group Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 72aa7cf5e04773064cbca266a108ec2b3020d757

Fix review comments. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 77df5cc425a71ad2d4ad0771fdfbb2f86c0c41f0

Fix volume inspect with optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir

commit sha 0c093d971788811582236d83fe71dc24a79ecb8b

Merge pull request #79 from shishir-a412ed/volume_group Add optional argument to select volume group

view details

push time in 3 months

PR merged containers/docker-lvm-plugin

Reviewers
Add optional argument to select volume group enhancement

Fixes #7

Signed-off-by: Shishir Mahajan shishirm@nvidia.com

+65 -29

3 comments

3 changed files

shishir-a412ed

pr closed time in 3 months

issue closedcontainers/docker-lvm-plugin

volume group can change

Right now we resolve the VOLUME_GROUP in each call (create, remove, etc, etc). This isn't quite right to me. Because we can create a logical volume in a volume group - then change the volume group in the config file - and fail to remove for instance a logical volume (case the vg name changed at runtime!!!!). I think it would be great if the VOLUME_GROUP is first resolved at plugin init time and saved in memory for that plugin life while allowing ppl via an --opt to choose the volume group to use

@rhvgoyal @rhatdan @shishir-a412ed wdyt (I'm not sure it could work, just thinking out loud)

closed time in 3 months

runcom

pull request commentcontainers/docker-lvm-plugin

Add optional argument to select volume group

@rhatdan Tested the PR. Merging it.

shishir-a412ed

comment created time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha ce6df832bb4dd3332a2c41796ffbda4bbd4a9ead

Throw error if volume size is <16M. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Daniel J Walsh

commit sha c3e038ec92f3a627ea1137b739736596fec1ec64

Merge pull request #80 from shishir-a412ed/min_size Throw error if volume size is <16M.

view details

Alexander Eichhorn

commit sha 6c1d788e639f227a4df9dfd63944941724499f8a

Add optional argument to select volume group Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 72aa7cf5e04773064cbca266a108ec2b3020d757

Fix review comments. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Shishir Mahajan

commit sha 77df5cc425a71ad2d4ad0771fdfbb2f86c0c41f0

Fix volume inspect with optional volume group. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

push time in 3 months

push eventshishir-a412ed/docker-lvm-plugin-1

Shishir Mahajan

commit sha ce6df832bb4dd3332a2c41796ffbda4bbd4a9ead

Throw error if volume size is <16M. Signed-off-by: Shishir Mahajan <shishirm@nvidia.com>

view details

Daniel J Walsh

commit sha c3e038ec92f3a627ea1137b739736596fec1ec64

Merge pull request #80 from shishir-a412ed/min_size Throw error if volume size is <16M.

view details

push time in 3 months

issue closedcontainers/docker-lvm-plugin

RHEL7 `docker ls` does not autostart lvm plugin module

$ docker volume ls
DRIVER      VOLUME NAME
[...]
$ systemctl status docker-lvm-plugin
[...]
Loaded: loaded [...]
Active: inactive (dead)

installed on RHEL 7.4 via yum install. Version docker-lvm-plugin.x86_64 2:1.12.6-71.git3e8e77d.el7.

closed time in 3 months

erikbgithub

issue commentcontainers/docker-lvm-plugin

RHEL7 `docker ls` does not autostart lvm plugin module

@erikbgithub closing it due to inactivity. Please feel free to reopen if you are still facing the issue.

erikbgithub

comment created time in 3 months

issue closedcontainers/docker-lvm-plugin

Plugin "lvm" not found

Hi all, I just installed the plugin and I am testing lvm creation using:

docker volume create -d lvm --opt size=0.2G --name foobar

But I am receiving the following error:

Error response from daemon: create foobar: error looking up volume plugin lvm: plugin "lvm" not found

I have correctly configured the /etc/docker/docker-lvm-plugin and made only one minor configuration to the Makefile (changed GOLANG to my $GOPATH which is GOLANG ?= /usr/local/go/bin/go).

Can anybody guide me where I might have gone wrong? I am guessing this might have to do with the recently released go 1.13 version but I haven't confirmed it yet. Will update this when I am able to do so.

closed time in 5 months

jojaii

issue commentcontainers/docker-lvm-plugin

Plugin "lvm" not found

@jojaii msg="mkfs.xfs is not available, please install xfsprogs to continue" May be install xfsprogs :) ?

jojaii

comment created time in 5 months

issue commentcontainers/docker-lvm-plugin

Plugin "lvm" not found

@jojaii Looks like docker daemon is not able to find the plugin. Is the plugin running?

Can you paste the output of:

  1. cat /etc/os-release
  2. systemctl status docker-lvm-plugin
jojaii

comment created time in 5 months

more