profile
viewpoint
Lokesh Mandvekar lsm5 @RedHatOfficial

containers/podman 4881

libpod is a library used to create container pods. Home of Podman.

containers/buildah 3088

A tool that facilitates building OCI images

cri-o/cri-o 2519

Open Container Initiative-based implementation of Kubernetes Container Runtime Interface

containers/skopeo 2339

Work with remote images registries - retrieving information, images, signing content

containers/conmon 128

An OCI container runtime monitor.

containers/container-selinux 121

SELinux policy files for Container Runtimes

containers/podman.io 121

Repository for podman.io website using GitHub Pages.

cevich/atomic-host-tests 0

A collection of single-host tests for Atomic Host

lsm5/atomic 0

Atomic Run Tool for installing/running/managing container images.

lsm5/autotest-docker 0

Autotest client test containing functional & integration subtests for the Docker project

push eventlsm5/bindings-sample

Lokesh Mandvekar

commit sha 6158d49ef478245c94c149f3e5f2e80722280e9e

remove pause Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 5 hours

push eventlsm5/bindings-sample

Lokesh Mandvekar

commit sha 155418de53763176417cfbab951d703aa491e428

check crun issue Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 7 hours

push eventlsm5/bindings-sample

Lokesh Mandvekar

commit sha bc029ed4ea0f0604a9376821d19f8bd7db91a3f8

pull image and add error checks Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 9 hours

push eventlsm5/bindings-sample

Lokesh Mandvekar

commit sha fcdf800482a339f72de985604124881592b1d754

container pause error Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 18 hours

push eventlsm5/bindings-sample

Lokesh Mandvekar

commit sha c21cb408bb1a638275dac0162fe1bef5e56d83a4

save to local storage Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a day

PublicEvent

pull request commentcontainers/podman

[CI:DOCS] Remove outdated seccomp policy

@lsm5 Poke - does this look like it will break packaging anywhere?

It won't. We're using a separate seccomp.json in containers-common subpackage.

mheon

comment created time in 2 days

delete branch lsm5/slirp4netns

delete branch : debian-stable

delete time in 2 days

issue closedcontainers/podman

Varlink no longer accessible in 2.0.2, requesting stable 2.0.0 package

/kind bug

Varlink is not supported message

I understand that podman is moving away from varlink in favor the the HTTP API, which I think is great. Unfortunately the switch is happening a bit too quickly for us to manage migrating. I think that the deprecation notice in 2.0.0 and then dropping it entirely in 2.0.2 was a little quick and unexpected for a patch release.

Is there anyway we could get a release channel/package that contains varlink (v2.0.0)?

→ podman varlink -t 100000 unix:/run/user/1000/podman/io.podman Command "varlink" is deprecated, Please see 'podman system service' for RESTful APIs Error: varlink is not supported

→ dpkg -s podman
Package: podman
Status: install ok installed
Priority: optional
Section: devel
Installed-Size: 72780
Maintainer: Lokesh Mandvekar <lsm5@fedoraproject.org>
Architecture: amd64
Version: 2.0.2~1
Depends: libseccomp2, libdevmapper1.02.1, libgpgme11, catatonit, conmon (>= 2.0.18~1), containers-common (>= 1.0.0~2), containernetworking-plugins (>= 0.8.6~1), runc | cri-o-runc, iptables, podman-plugins
Recommends: crun, slirp4netns, uidmap
Conflicts: podman-rootless
Conffiles:
 /etc/cni/net.d/87-podman-bridge.conflist a87c090f17c5274af878e7106e969b60
Description: Manage pods, containers and container images.
Homepage: https://github.com/containers/libpod.git

closed time in 4 days

drewbailey

issue commentcontainers/podman

Varlink no longer accessible in 2.0.2, requesting stable 2.0.0 package

@drewbailey v2.0.2 is now on OBS with varlink. Let me know how that works. I'll close this...

drewbailey

comment created time in 4 days

issue commentcontainers/podman

Varlink no longer accessible in 2.0.2, requesting stable 2.0.0 package

Hm. We can probably keep the tag for 2.0.x and 2.1.x, then drop to a subpackage for 2.2.x, and finally remove around 2.3.x, maybe?

I'm fine with that approach, no idea about when exactly those should happen though. @baude @vrothberg @rhatdan @jnovy ??

drewbailey

comment created time in 5 days

issue commentcontainers/podman

Varlink no longer accessible in 2.0.2, requesting stable 2.0.0 package

@drewbailey I can add that back in for debian, no worries.

@mheon maybe we can have different rules for each distro? or conflicting subpackages like podman and podman-varlink, so people can install podman-varlink if podman ain't good enough?

drewbailey

comment created time in 5 days

PR closed containers/buildah

Makefile: use customizable env vars

(cherry picked from commit 8af886b2a4f0fced98eb3532a02a4b2dc95f1197) Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@rhatdan @nalind @TomSweeneyRedHat @vrothberg PTAL @ backport. <!-- Thanks for sending a pull request!

Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with git commit -s. -->

What type of PR is this?

<!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: -->

/kind other

What this PR does / why we need it:

allows me to reuse Makefile targets in packaging

How to verify it

upstream doesn't need to care

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: Fixes #<issue number>, or Fixes (paste link of issue), or None. -->

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

<!-- If no, just write None in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md -->

None
+7 -7

0 comment

1 changed file

lsm5

pr closed time in 6 days

PR closed containers/buildah

Makefile: use customizable env vars

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

I thought this was done before but apparently not.

@rhatdan @nalind @TomSweeneyRedHat @vrothberg PTAL

<!-- Thanks for sending a pull request!

Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with git commit -s. -->

What type of PR is this?

<!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: -->

/kind other

What this PR does / why we need it:

will help me reuse Makefile targets in packaging

How to verify it

upstream doesn't really need to care

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: Fixes #<issue number>, or Fixes (paste link of issue), or None. -->

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

<!-- If no, just write None in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md -->

None
+7 -7

3 comments

1 changed file

lsm5

pr closed time in 6 days

pull request commentcontainers/buildah

Makefile: use customizable env vars

@nalind ah you're right, my bad. Closing ...

lsm5

comment created time in 6 days

pull request commentcontainers/buildah

Makefile: use customizable env vars

backport at https://github.com/containers/buildah/pull/2455

lsm5

comment created time in 6 days

PR opened containers/buildah

Makefile: use customizable env vars

(cherry picked from commit 8af886b2a4f0fced98eb3532a02a4b2dc95f1197) Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@rhatdan @nalind @TomSweeneyRedHat @vrothberg PTAL @ backport. <!-- Thanks for sending a pull request!

Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with git commit -s. -->

What type of PR is this?

<!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: -->

/kind other

What this PR does / why we need it:

allows me to reuse Makefile targets in packaging

How to verify it

upstream doesn't need to care

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: Fixes #<issue number>, or Fixes (paste link of issue), or None. -->

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

<!-- If no, just write None in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md -->

None
+7 -7

0 comment

1 changed file

pr created time in 6 days

push eventlsm5/buildah

Lokesh Mandvekar

commit sha 11f7cea5481130bc43cbbdffe770fd1a644e14db

Makefile: use customizable env vars (cherry picked from commit 8af886b2a4f0fced98eb3532a02a4b2dc95f1197) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 6 days

create barnchlsm5/buildah

branch : release-1.15-makefile-customizable-envvar

created branch time in 6 days

PR opened containers/buildah

Makefile: use customizable env vars

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

I thought this was done before but apparently not.

@rhatdan @nalind @TomSweeneyRedHat @vrothberg PTAL

<!-- Thanks for sending a pull request!

Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with git commit -s. -->

What type of PR is this?

<!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request.

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: -->

/kind other

What this PR does / why we need it:

will help me reuse Makefile targets in packaging

How to verify it

upstream doesn't really need to care

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: Fixes #<issue number>, or Fixes (paste link of issue), or None. -->

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

<!-- If no, just write None in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md -->

None
+7 -7

0 comment

1 changed file

pr created time in 6 days

create barnchlsm5/buildah

branch : makefile-custom-envvars

created branch time in 6 days

issue closedcontainers/podman

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

/kind bug

Description

I wonder if Go can be bumped to 1.13 in packages on the Open Build service for 18.04 <= ubuntu < 20.04 and possible Debian. It seems that recent changes are preventing podman 2.0 from being built with the earlier versions of Go. I was able to build podman 2.0.1 using Go 1.13 from custom ppa on my box, but developers here use and test with your repo.

closed time in 7 days

alitvak69

issue commentcontainers/podman

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

Closing, I guess all distros and arches are happy now except Debian Unstable ppc64le, which is an OBS problem that I nag them often about.

alitvak69

comment created time in 7 days

issue commentcontainers/podman

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

@alitvak69 @afbjorklund dear valued members of the podman community, ask and ye shall receive :) https://build.opensuse.org/package/show/devel:kubic:libcontainers:stable/podman

Enjoy :)

alitvak69

comment created time in 7 days

PR opened opencontainers/runc

allow customizable PREFIX variable

This change would let me specify my own PREFIX so that I can reuse Makefile targets for building rpm packages.

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@mrunalp @cyphar PTAL

+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchlsm5/runc

branch : custom-PREFIX-in-Makefile

created branch time in 7 days

issue commentcontainers/podman

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

would adding custom ppa I used help you at least in short term?

Na, OBS guys aren't gonna agree to it. And, AIUI, there's no way for me to simply add some PPA. I'll look into adding the golang package myself.

alitvak69

comment created time in 8 days

issue commentcontainers/libpod

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

@lsm5: I reused your packaging for podman 1.9.3, in order to fix the podman-remote issues

Good that it works both ways

@afbjorklund sorry, reused where exactly? are you building it separately somewhere?

alitvak69

comment created time in 8 days

issue commentcontainers/libpod

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

@alitvak69 I was able to build for Debian 10 x86_64, but I can't seem to find anything newer than golang 1.10 in Ubuntu versions older than 20.04. So, I can either request ubuntu people to backport it or build it myself on OBS. Might be worth doing both, but may take a few days unless I can reuse current packaging sources without any change.

alitvak69

comment created time in 8 days

issue commentcontainers/libpod

Building of Podman 2.0.x packages fails in Kubic Project due to Go < 1.13 on Ubuntu 18.04

@alitvak69 I just learned from the OBS guys how to add the backports repos to Debian 10. I should be able to fix Debian today, I'll look into the older Ubuntus as well.

alitvak69

comment created time in 8 days

pull request commentcontainers/libpod

move go module to v2

@mheon can we have this in v2 branch as well before we cut a new release please?

vrothberg

comment created time in 9 days

delete branch lsm5/podman

delete branch : v2.0-registry-port-number

delete time in 16 days

create barnchlsm5/podman

branch : v2.0-registry-port-number

created branch time in 18 days

PR opened containers/libpod

Account for non-default port number in image name (backported from master)

Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then podman images would display $PORT/$REPO:$TAG under the "TAG" field.

This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG.

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

Fixes: gh#6665 (cherry picked from commit 71f6dd47ddce82545865739cb3382c0beb3f65a4)

@mheon @baude @rhatdan @jwhonce

+3 -1

0 comment

1 changed file

pr created time in 18 days

delete branch lsm5/podman

delete branch : v2.0-custom-GO_BUILD-backport

delete time in 20 days

delete branch lsm5/podman

delete branch : custom-GO_BUILD

delete time in 20 days

issue closedcontainers/libpod

v2.0.0-rc6: unable to change to root gid in container

<!--

BUG REPORT INFORMATION

Use the commands below to provide key information from your environment: You do NOT have to include this information if this is a FEATURE REQUEST

NOTE A large number of issues reported against Podman are often found to already be fixed in more current versions of the project. Before reporting an issue, please verify the version you are running with podman version and compare it to the latest release documented on the top of Podman's README.md. If they differ, please update your version of Podman to the latest possible and retry your command before creating an issue.

If you are filing a bug against podman build, please instead file a bug against Buildah (https://github.com/containers/buildah/issues). Podman build executes Buildah to perform container builds, and as such the Buildah maintainers are best equipped to handle these bugs. -->

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

<!-- Briefly describe the problem you are having in a few paragraphs. -->

Steps to reproduce the issue:

  1. I enter a container with a non-root user

  2. Try to run sudo inside container

Describe the results you received:

sudo: unable to change to root gid: Operation not permitted
sudo: unable to initialize policy plugin

Describe the results you expected: sudo should work

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version:      2.0.0-rc6
API Version:  1
Go Version:   go1.14.3
Built:        Wed Dec 31 19:00:00 1969
OS/Arch:      linux/amd64

Output of podman info --debug:

  arch: amd64
  buildahVersion: 1.15.0-dev
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.18-1.fc32.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.18, commit: 6e8799f576f11f902cd8a8d8b45b2b2caf636a85'
  cpus: 8
  distribution:
    distribution: fedora
    version: "32"
  eventLogger: file
  hostname: nagato.nanadai.me
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.6.18-300.fc32.x86_64
  linkmode: dynamic
  memFree: 4040089600
  memTotal: 16416161792
  ociRuntime:
    name: crun
    package: crun-0.13-2.fc32.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.13
      commit: e79e4de4ac16da0ce48777afb72c6241de870525
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  remoteSocket:
    path: /run/podman/podman.sock
  rootless: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 8296329216
  swapTotal: 8296329216
  uptime: 24h 53m 54.52s (Approximately 1.00 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - docker.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 47
    paused: 0
    running: 1
    stopped: 46
  graphDriverName: overlay
  graphOptions:
    overlay.mountopt: nodev
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 48
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 1
  Built: 0
  BuiltTime: Wed Dec 31 19:00:00 1969
  GitCommit: ""
  GoVersion: go1.14.3
  OsArch: linux/amd64
  Version: 2.0.0-rc6

Package info (e.g. output of rpm -q podman or apt list podman):

podman-2.0.0-0.2.rc6.fc32.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.): physical

closed time in 21 days

lsm5

issue commentcontainers/libpod

v2.0.0-rc6: unable to change to root gid in container

fixed in v2.0.0. Closing ...

lsm5

comment created time in 21 days

issue commentcontainers/libpod

Unable to install Podman 2.0 on Centos7

Currently, this repo is overwritten by the latest version when a new build is triggered. Would it be difficult to keep the previous version(s) somewhere in order to have a fallback plan when things like this happen?

@guscott OBS gets rid of older builds once a new build is done. The centos packages are built from the fedora sources itself, so you can clone https://src.fedoraproject.org/rpms/podman , checkout the right version of the rpm from the latest release branch (currently f32) and then run rpmbuild on it to generate the rpms.

If stability and being able to fallback on an older version are requirements, I'd recommend using the podman that comes by default with CentOS Extras.

guscott

comment created time in 23 days

issue commentcontainers/libpod

Unable to install Podman 2.0 on Centos7

@guscott could you please check if you're atleast able to install just conmon 2.0.18 after adding that repo via yum install conmon

That 416 error is strange. That might be an issue with OBS and not with the package itself.

guscott

comment created time in 23 days

pull request commentcontainers/libpod

Makefile: allow customizable GO_BUILD

err, i guess someone needs to slash-lgtm it.

lsm5

comment created time in 23 days

PR opened containers/libpod

Makefile: allow customizable GO_BUILD

This will let me use a customizable GO_BUILD so that I can run build targets for deb packages

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@mheon PTAL.

+2 -2

0 comment

1 changed file

pr created time in 23 days

push eventlsm5/podman

Lokesh Mandvekar

commit sha 0ac4061bdbee590a3ff3add09daed92988c04481

Makefile: allow customizable GO_BUILD This will let me use a customizable GO_BUILD so that I can run build targets for deb packages Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> (cherry picked from commit 78bd0e0a635470128a0452a67e242e4761723657)

view details

push time in 23 days

create barnchlsm5/podman

branch : v2.0-custom-GO_BUILD-backport

created branch time in 23 days

issue commentcontainers/libpod

APIv2: missing NetworkSettings and failure to start a container

@max-arnold should be available now.

max-arnold

comment created time in 23 days

create barnchlsm5/podman

branch : custom-GO_BUILD

created branch time in 23 days

PR opened containers/libpod

Makefile: allow customizable GO_BUILD

This will let me use a customizable GO_BUILD so that I can run build targets for deb packages

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@rhatdan @baude @mheon @vrothberg PTAL.

+2 -2

0 comment

1 changed file

pr created time in 23 days

issue commentcontainers/libpod

APIv2: missing NetworkSettings and failure to start a container

@rhatdan Are the 2.0.0 packages for Ubuntu delayed? I only see 1.9.3 here https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_20.04/

We had disabled autobuilds for podman until v2.0.0. I'm in the middle of building them now and I'll enable autobuilds after that. Expect to be done before noon.

max-arnold

comment created time in 23 days

delete branch lsm5/podman

delete branch : fix-Makefile-for-varlink

delete time in 23 days

delete branch lsm5/podman

delete branch : Makefile-custom-REMOTETAGS

delete time in 23 days

delete branch lsm5/podman

delete branch : tag-correction

delete time in 23 days

pull request commentcontainers/libpod

Account for non-default port number in image name

all tests pass. @rhatdan could you PTAL once again for confirmation?

lsm5

comment created time in a month

push eventlsm5/podman

Valentin Rothberg

commit sha 334d3b1ef3a1148147454c4d935ebaf4b741e498

CI: force registry:2.6 For using the `registry:2.6` image. 2.7 and beyond dropped the `htpasswd` binary from the rootfs which parts of our CI depends on. While this is not a sustainable solution (assuming `htpasswd` is gone for ever), it unblocks the CI for now. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha 5ec29f8d4e79500915ec79824d9eb21630205f3f

Merge pull request #6684 from vrothberg/fix-ci CI: force registry:2.6

view details

Valentin Rothberg

commit sha bba433ed926a8ba78e628e1a1d9861ac5ed35e54

podman images --format json: pretty print Pretty print the JSON output when listing images. We regressed on that during v2 development. The indentation is now identical to the one of Podman v1.9.3. Fixes: #6687 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha 33a60276135b7d74f3a10b39d8d69c836a05766e

Merge pull request #6690 from vrothberg/fix-6687 podman images --format json: pretty print

view details

Lokesh Mandvekar

commit sha 71f6dd47ddce82545865739cb3382c0beb3f65a4

Account for non-default port number in image name Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then `podman images` would display $PORT/$REPO:$TAG under the "TAG" field. This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Fixes: gh#6665

view details

push time in a month

pull request commentcontainers/libpod

[DO NOT MERGE] Account for non-default port number in image name

hmm, still a bunch of other failures

lsm5

comment created time in a month

pull request commentcontainers/libpod

[DO NOT MERGE] Account for non-default port number in image name

[+0086s]  * 9a290a95c "Revert to check if tests pass" ... FAIL
[+0086s]   - FAIL - does not have a valid DCO

^^^ this commit isn't signed. I guess we can squash them into one?

Thanks!!

lsm5

comment created time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha a36349649ec581e7e1b78494536aae2357bcb5a3

Revert to check if tests pass This reverts commit 8ca101a73adfdfe5b1851fcecf3fc17ab78ae346. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha 9869533aa64f1476a17aeb42d50f0652d3c58cbf

Revert to check if tests pass This reverts commit 8ca101a73adfdfe5b1851fcecf3fc17ab78ae346.

view details

push time in a month

pull request commentcontainers/libpod

[DO NOT MERGE] Account for non-default port number in image name

master is on a2661b1c25e280282d101f24ce478305622da11f and i'm rebased on that as well.

lsm5

comment created time in a month

pull request commentcontainers/libpod

[DO NOT MERGE] Account for non-default port number in image name

Can you try rebasing? Lint has been acting up recently, but it seems OK on master

seems like my branch is rebased on the latest..

lsm5

comment created time in a month

pull request commentcontainers/libpod

[DO NOT MERGE] Account for non-default port number in image name

alright, so I effectively only have a trivial README change but CI is still failing. Probably not my fault. Could someone PTAL ?

lsm5

comment created time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha c03aa03e2e99177d48934961b3a9b7d343bc3176

test change for CI Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha 2e50356f26166b567bd4ee528537defac1ee465a

test change for CI Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha 9a290a95c6f58eadafe2da3cce35f7ffae6f4ee5

Revert to check if tests pass This reverts commit 8ca101a73adfdfe5b1851fcecf3fc17ab78ae346.

view details

push time in a month

Pull request review commentcontainers/libpod

Account for non-default port number in image name

 func writeTemplate(imageS []*entities.ImageSummary) error { }  func tokenRepoTag(tag string) (string, string) {-	tokens := strings.SplitN(tag, ":", 2)+	tokens := strings.Split(tag, ":") 	switch len(tokens) { 	case 0: 		return tag, "" 	case 1: 		return tokens[0], "" 	case 2: 		return tokens[0], tokens[1]+	case 3:+		return tokens[0] + ":" + tokens[1], tokens[2]

went back to the original change itself as lots of failures otherwise.

lsm5

comment created time in a month

push eventlsm5/podman

Ashley Cui

commit sha 4dc934080b551b305d7e0e214d442f675f0f897c

Fix remote docs Fix renaming bug in remote-docs.sh Remove mentions of 'remote' in windows and mac dos Remove podman-remote.conf.5 Signed-off-by: Ashley Cui <acui@redhat.com>

view details

OpenShift Merge Robot

commit sha a2661b1c25e280282d101f24ce478305622da11f

Merge pull request #6673 from ashley-cui/master [CI:DOCS] Fix remote docs

view details

Lokesh Mandvekar

commit sha 8ca101a73adfdfe5b1851fcecf3fc17ab78ae346

Account for non-default port number in image name Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then `podman images` would display "$PORT/$REPO:$TAG" under the "TAG" field. This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Fixes: gh#6665

view details

push time in a month

Pull request review commentcontainers/libpod

Account for non-default port number in image name

 func writeTemplate(imageS []*entities.ImageSummary) error { }  func tokenRepoTag(tag string) (string, string) {-	tokens := strings.SplitN(tag, ":", 2)+	tokens := strings.Split(tag, ":") 	switch len(tokens) { 	case 0: 		return tag, "" 	case 1: 		return tokens[0], "" 	case 2: 		return tokens[0], tokens[1]+	case 3:+		return tokens[0] + ":" + tokens[1], tokens[2]

err I made some more changes ... made len == 3 the default and <N/A> for len == 0. PTAL ...

lsm5

comment created time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha 8378b46a9be3ee719d5514a0012a2b7ba62cd5f9

Account for non-default port number in image name Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then `podman images` would display "$PORT/$REPO:$TAG" under the "TAG" field. This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org> Fixes: gh#6665

view details

push time in a month

Pull request review commentcontainers/libpod

Account for non-default port number in image name

 func writeTemplate(imageS []*entities.ImageSummary) error { }  func tokenRepoTag(tag string) (string, string) {-	tokens := strings.SplitN(tag, ":", 2)+	tokens := strings.Split(tag, ":") 	switch len(tokens) { 	case 0: 		return tag, "" 	case 1: 		return tokens[0], "" 	case 2: 		return tokens[0], tokens[1]+	case 3:+		return tokens[0] + ":" + tokens[1], tokens[2]

That fails already:

$ ./bin/podman tag docker.io/library/ubuntu foo1:20000/foo2:foo3:foo4
Error: invalid reference format

lsm5 @ nagato : ~/go/src/github.com/containers/libpod(tag-correction) $ ./bin/podman tag docker.io/library/ubuntu foo1:20000/foo2:foo3     
lsm5 @ nagato : ~/go/src/github.com/containers/libpod(tag-correction) $ 
lsm5

comment created time in a month

Pull request review commentcontainers/libpod

Account for non-default port number in image name

 func writeTemplate(imageS []*entities.ImageSummary) error { }  func tokenRepoTag(tag string) (string, string) {-	tokens := strings.SplitN(tag, ":", 2)+	tokens := strings.Split(tag, ":") 	switch len(tokens) { 	case 0: 		return tag, "" 	case 1: 		return tokens[0], "" 	case 2: 		return tokens[0], tokens[1]+	case 3:+		return tokens[0] + ":" + tokens[1], tokens[2]

Is this correct? To be safe this should be

return tokens[0] + ":" + tokens[1], strings.Join(tokens[2:],":")

hmm, is that because the tag can themselves contain ":" in them?

lsm5

comment created time in a month

PR opened containers/libpod

Account for non-default port number in image name

Previously, if an image was tagged with the format $REGISTRY:$PORT/$REPO:$TAG, then podman images would display "$PORT/$REPO:$TAG" under the "TAG" field.

This commit correctly displays $REGISTRY:$PORT/$REPO under the "REPOSITORY" field while the "TAG" field only displays $TAG.

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

Fixes: gh#6665

@baude @mheon @rhatdan @vrothberg @jwhonce PTAL

+3 -1

0 comment

1 changed file

pr created time in a month

create barnchlsm5/podman

branch : tag-correction

created branch time in a month

push eventlsm5/podman

Jhon Honce

commit sha 2e22e18afbaba175a0328b0d70ca4d6bb15c441e

Add deprecated message to varlink command * Remove varlink references from the man pages * Fix signature for extractTarFile() Signed-off-by: Jhon Honce <jhonce@redhat.com>

view details

dependabot-preview[bot]

commit sha 51febc510a50ca02e47e53aef7bac2dd38652b2f

Bump github.com/containers/conmon Bumps [github.com/containers/conmon](https://github.com/containers/conmon) from 2.0.17+incompatible to 2.0.18+incompatible. - [Release notes](https://github.com/containers/conmon/releases) - [Changelog](https://github.com/containers/conmon/blob/master/changelog.txt) - [Commits](https://github.com/containers/conmon/compare/v2.0.17...v2.0.18) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Matthew Heon

commit sha 20345b1ec0dc4fb64ce77400cad822f1fadb86f0

Revert "Change Varlink systemd unit to use `system service`" This reverts commit 1bc992bfc3a983b4d9ab53f778a545d83bcde94d. We originally thought `podman varlink` was entirely removed, but that was not true. We originally thought that `podman system service --varlink` worked the same as `podman varlink` but that was also not true. `system service` is broken when used under systemd units, and `podman varlink` still exists and works. Revert the change to `podman system service` to fix socket-activated Varlink under systemd. Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

OpenShift Merge Robot

commit sha 66b6697d0ebc94d02b71abc0aecd9095de555ec8

Merge pull request #6610 from jwhonce/wip/varlink Add deprecated message to varlink command

view details

OpenShift Merge Robot

commit sha 908bc3fba305666b3cd41b29bd775bb62f1f8f9f

Merge pull request #6619 from mheon/revert_systemd_varlinkchange [CI:DOCS] Revert "Change Varlink systemd unit to use `system service`"

view details

Daniel J Walsh

commit sha fb4148bc41f597f28c1007e5c359f8baa61275a9

Fix podman-remote images Looks like we went too far with the linters. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Joseph Gooch

commit sha eb8bfdad3e6e4f3bbb308c2ae8c8b6dbba7d4f1c

Fix --init and --init-path Init properly passed into specgen Allow --init with --systemd=true but not --systemd=always. Signed-off-by: Joseph Gooch <mrwizard@dok.org>

view details

OpenShift Merge Robot

commit sha d6965da26d194c7edfef65985d4a2c7b564a3fca

Merge pull request #6616 from containers/dependabot/go_modules/github.com/containers/conmon-2.0.18incompatible Bump github.com/containers/conmon from 2.0.17+incompatible to 2.0.18+incompatible

view details

Matthew Heon

commit sha 6589d75565db2c0546787a01e8381cee15edbdf5

Fix podman inspect on overlapping/missing objects This started as a small fix to `podman inspect` where a container and image, with the same name/tag, were present, and `podman inspect` was run on that name. `podman inspect` in 1.9 (and `docker inspect`) will give you the container; in v2.0, we gave the image. This was an easy fix (just reorder how we check for image/container). Unfortunately, in the process of testing this fix, I determined that we regressed in a different area. When you run inspect on a number of containers, some of which do not exist, `podman inspect` should return an array of inspect results for the objects that exist, then print a number of errors, one for each object that could not be found. We were bailing after the first error, and not printing output for the containers that succeeded. (For reference, this applied to images as well). This required a much more substantial set of changes to properly handle - signatures for the inspect functions in ContainerEngine and ImageEngine, plus the implementations of these interfaces, plus the actual inspect frontend code needed to be adjusted to use this. Fixes #6556 Signed-off-by: Matthew Heon <matthew.heon@pm.me>

view details

Ashley Cui

commit sha e867fe5c3e448e6ec9793a653bd2377b75f91dd9

Show Anon, GID, UID in v2 volumes Anon, GID, UID parameters previously hidden if empty in podman volume for API v2. Signed-off-by: Ashley Cui <acui@redhat.com>

view details

Daniel J Walsh

commit sha 713287ce36e3fec57ef3a39788b56f60c8f29287

Vendor containers/common v0.14.0 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha 89630adbc418eac4a7eddf683226ee61f24f93be

Merge pull request #6624 from rhatdan/mount Fix podman-remote images

view details

Daniel J Walsh

commit sha e67dd9ffabff1fda156fe0c2f2e8bef8d3d6dfef

Add <return> to lines returen in podman-remote logs Every line is sent back individually over the APIv2 as logs, but we are not adding the '\n' to give us line breaks. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Matthew Heon

commit sha c51c593ff630719d9d897319a7afabf412580d68

Re-add resource limit warnings to Specgen These were part of Podman v1.9, but were lost in the transition to using Specgen to create containers. Most resource limits are checked via the sysinfo package to ensure they are safe to use (the cgroup is mounted, kernel support is present, etc) and removed if not safe. Further, bounds checks are performed to ensure that values are valid. Ensure these warnings are printed client-side when they occur. This part is a little bit gross, as it happens in pkg/infra and not cmd/podman, which is largely down to how we implemented `podman run` - all the work is done in pkg/infra and it returns only once the container has exited, and we need warnings to print *before* the container runs. The solution here, while inelegant, avoid the need to extensively refactor our handling of run. Should fix blkio-limit warnings that were identified by the FCOS test suite. Signed-off-by: Matthew Heon <matthew.heon@pm.me>

view details

Jhon Honce

commit sha 64d3508a94f9fbb6c31c948d21c5fadae94b5836

[CI:DOCS] Fixes #6548 * Update swagger documentation Signed-off-by: Jhon Honce <jhonce@redhat.com>

view details

OpenShift Merge Robot

commit sha e4e10dfc3e35f0c104f36ccb10aa6f2204446ed8

Merge pull request #6635 from rhatdan/logs Add <return> to lines returned in podman-remote logs

view details

OpenShift Merge Robot

commit sha 4b2da3ed552dcbbe348883abd087f8b06780760b

Merge pull request #6633 from rhatdan/VENDOR Vendor containers/common v0.14.0

view details

OpenShift Merge Robot

commit sha 4fb0f56063de13af53128be9da81027d988516be

Merge pull request #6638 from jwhonce/issues/6548 [CI:DOCS] Fixes #6548

view details

Daniel J Walsh

commit sha a36bc1526652341126a180a304d99777378375ff

Fix handling of old oci hooks Podman is blowing up with oci-umount hook, because it was never rewritten to support the v1.0.0 value. This PR adds support for the older version and cleans up the hook handling. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

Ed Santiago

commit sha 6d5a432c2e6e538308961b9c130c3aeb32138c7b

"streaming output" logs test: fix flake Test has been flaking excessively. A quick look shows that the test itself is broken, making a bad assumption. 'podman logs -f' is guaranteed to exit when a container terminates. This does not (and should not) mean that the container has been cleaned up. It is undefined and unsafe to run 'podman run -n same-name-as-terminated-container' immediately after 'podman logs' exits. Solution: instead of 'podman run', do 'podman inspect'. This, too, is unsafe, but we can expect to see one of two possible conditions: 1) command succeeds, in which case we require that container State.Status be "exited"; or 2) command fails, in which case we expect "no such container" in error output For full coverage we should add a small delay-check test to (1) to ensure that the container is cleaned up after a short amount of time. Leaving that as a TODO because it's more than my Go skills can handle, and I want to get this checked in ASAP to get rid of the flake hassle. Signed-off-by: Ed Santiago <santiago@redhat.com>

view details

push time in a month

issue commentcontainers/libpod

unable to change to root gid in container

This issue occurs only if I start a container as non-root user and then try to sudo inside the container.

It won't occur if the container is first started as root, then inside the container I try to first su to a non-root user and then sudo back.

lsm5

comment created time in a month

issue openedcontainers/libpod

unable to change to root gid in container

<!--

BUG REPORT INFORMATION

Use the commands below to provide key information from your environment: You do NOT have to include this information if this is a FEATURE REQUEST

NOTE A large number of issues reported against Podman are often found to already be fixed in more current versions of the project. Before reporting an issue, please verify the version you are running with podman version and compare it to the latest release documented on the top of Podman's README.md. If they differ, please update your version of Podman to the latest possible and retry your command before creating an issue.

If you are filing a bug against podman build, please instead file a bug against Buildah (https://github.com/containers/buildah/issues). Podman build executes Buildah to perform container builds, and as such the Buildah maintainers are best equipped to handle these bugs. -->

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

<!-- Briefly describe the problem you are having in a few paragraphs. -->

Steps to reproduce the issue:

  1. I enter a container with a non-root user

  2. Try to run sudo inside container

Describe the results you received:

sudo: unable to change to root gid: Operation not permitted
sudo: unable to initialize policy plugin

Describe the results you expected: sudo should work

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version:      2.0.0-rc6
API Version:  1
Go Version:   go1.14.3
Built:        Wed Dec 31 19:00:00 1969
OS/Arch:      linux/amd64

Output of podman info --debug:

  arch: amd64
  buildahVersion: 1.15.0-dev
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.18-1.fc32.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.18, commit: 6e8799f576f11f902cd8a8d8b45b2b2caf636a85'
  cpus: 8
  distribution:
    distribution: fedora
    version: "32"
  eventLogger: file
  hostname: nagato.nanadai.me
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.6.18-300.fc32.x86_64
  linkmode: dynamic
  memFree: 4040089600
  memTotal: 16416161792
  ociRuntime:
    name: crun
    package: crun-0.13-2.fc32.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.13
      commit: e79e4de4ac16da0ce48777afb72c6241de870525
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  remoteSocket:
    path: /run/podman/podman.sock
  rootless: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 8296329216
  swapTotal: 8296329216
  uptime: 24h 53m 54.52s (Approximately 1.00 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - docker.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 47
    paused: 0
    running: 1
    stopped: 46
  graphDriverName: overlay
  graphOptions:
    overlay.mountopt: nodev
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 48
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 1
  Built: 0
  BuiltTime: Wed Dec 31 19:00:00 1969
  GitCommit: ""
  GoVersion: go1.14.3
  OsArch: linux/amd64
  Version: 2.0.0-rc6

Package info (e.g. output of rpm -q podman or apt list podman):

podman-2.0.0-0.2.rc6.fc32.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.): physical

created time in a month

pull request commentcontainers/libpod

Makefile: install.varlink needs to create dirs

anybody know whatsup with the ubuntu failures?

lsm5

comment created time in a month

pull request commentcontainers/libpod

Makefile: install.varlink needs to create dirs

@lsm5 I'd try rebasing and see if #6615 fixed things up for you.

passes gating now. Thanks @TomSweeneyRedHat

lsm5

comment created time in a month

push eventlsm5/podman

Yiqiao Pu

commit sha d072de6efcf366d7453dc32954bb5067265cf73f

APIv2 tests: Add some tests for podman pods Add some tests for podman pods subcommand: restart rm start stas stop top unpause Signed-off-by: Yiqiao Pu <ypu@redhat.com>

view details

Valentin Rothberg

commit sha 2a565f49c2a7cfc4dbb2394d7ded786f20256234

auto-update: use image's arch Use the architecture of the local image when looking for a new image on a registry. It seems to be common practice on ARM to tweak the architecture choice to pull the correct image. Fixes: #6613 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Valentin Rothberg

commit sha af3c4d88b405adb0353f8085298d25e3a5937ee3

handlers/compat: fix lint error Fix a lint error of an used parameter. The error must have sneaked in with a PR that was merged after the recent linter enablement. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha e0dd2279120f9883c0678cce644952007e3ae771

Merge pull request #6605 from ypu/apiv2-pods APIv2 tests: Add some tests for podman pods

view details

OpenShift Merge Robot

commit sha 0968f25988624699f2db559f0a984cf84c8a284f

Merge pull request #6615 from vrothberg/auto-update-variant auto-update: use image's arch

view details

Lokesh Mandvekar

commit sha 8d65408b8dd3ce0a34166d74ba3568156ae589a8

Makefile: install.varlink needs to create dirs Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a month

issue closedcontainers/oci-seccomp-bpf-hook

build fails on CentOS

Trying to build 1.1.0 rpm on OBS for CentOS, and it fails with:

[  168s] _build/src/github.com/containers/oci-seccomp-bpf-hook/vendor/github.com/iovisor/gobpf/bcc/module.go:98:40: too many arguments in call to _Cfunc_bpf_module_create_c_from_string
[  168s] 	have (*_Ctype_char, number, **_Ctype_char, _Ctype_int, _Ctype__Bool, nil)
[  168s] 	want (*_Ctype_char, _Ctype_uint, **_Ctype_char, _Ctype_int, _Ctype__Bool)

closed time in a month

lsm5

issue commentcontainers/oci-seccomp-bpf-hook

build fails on CentOS

[  128s] [218/271] installing bcc-0.10.0-1.el7

the function definition was changed in bcc >= 0.11.0 , you'll need to update bcc

Thanks. I guess I'll just wait until CentOS updates bcc then, unless there's enough demand for me to package it separately on OBS. Closing...

lsm5

comment created time in a month

issue commentcontainers/libpod

Keep older versions in PPA

Then again, maybe that is the way to go in order to make the latest and greatest available faster. I was more requesting something similar to the RHEL packages, that would actually move a bit slower...

IIUC, podman is now available in debian unstable and hopefully will make its way into the other repos as well. That itself might be the right slower moving build to recommend.

matpen

comment created time in a month

issue commentcontainers/libpod

Issue with `podman play kube` on Ubuntu

/usr/bin/runc on Ubuntu is owned by the distro default runc. I have set dependencies to use distro runc by default since that seemed good enough for most cases. Would it be ok to let this be until Ubuntu updates its runc?

mheon

comment created time in a month

issue commentcontainers/oci-seccomp-bpf-hook

build fails on CentOS

https://build.opensuse.org/public/build/devel:kubic:libcontainers:stable/CentOS_7/x86_64/oci-seccomp-bpf-hook/_log

lsm5

comment created time in a month

issue openedcontainers/oci-seccomp-bpf-hook

build fails on CentOS

Trying to build 1.1.0 rpm on OBS for CentOS, and it fails with:

[  168s] _build/src/github.com/containers/oci-seccomp-bpf-hook/vendor/github.com/iovisor/gobpf/bcc/module.go:98:40: too many arguments in call to _Cfunc_bpf_module_create_c_from_string
[  168s] 	have (*_Ctype_char, number, **_Ctype_char, _Ctype_int, _Ctype__Bool, nil)
[  168s] 	want (*_Ctype_char, _Ctype_uint, **_Ctype_char, _Ctype_int, _Ctype__Bool)

created time in a month

pull request commentcontainers/libpod

Makefile: install.varlink needs to create dirs

LGTM. but not happy about the gating tests...

Any idea what those are? And is that taken care of by some other PR already?

lsm5

comment created time in a month

push eventlsm5/podman

Lokesh Mandvekar

commit sha ba1cd48404c714853de89988bed1621ed35b710b

Makefile: install.varlink needs to create dirs Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in a month

PR opened containers/libpod

Makefile: install.varlink needs to create dirs

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

I noticed the install.varlink wasn't self-sufficient. That's why this change.

@mheon @baude @rhatdan

+3 -2

0 comment

1 changed file

pr created time in a month

create barnchlsm5/podman

branch : fix-Makefile-for-varlink

created branch time in a month

issue commentcontainers/crun

/usr/bin/crun: error while loading shared libraries: libyajl.so.2: cannot open shared object file: No such file or directory

should be fixed in the latest 0.13~2 https://build.opensuse.org/package/show/devel:kubic:libcontainers:stable/crun

geverartsdev

comment created time in a month

issue commentcontainers/crun

/usr/bin/crun: error while loading shared libraries: libyajl.so.2: cannot open shared object file: No such file or directory

@saschagrunert PTAL

i guess this one's on me. Please assign this to me. I can't seem to assign myself in this repo.

geverartsdev

comment created time in a month

issue commentcoreos/fedora-coreos-tracker

Need dnsmasq for podman to create CNI networks

@jlebon I don't think we ever had podman-plugins depend on anything prior. If @mheon and others agree, would you mind sending a PR to dist-git. I'm on PTO atm but I can merge :)

Ma124

comment created time in a month

delete branch lsm5/podman

delete branch : build-without-varlink

delete time in a month

push eventlsm5/podman

Valentin Rothberg

commit sha dc80267b594e41cf7e223821dc1446683f0cae36

compat handlers: add X-Registry-Auth header support * Support the `X-Registry-Auth` http-request header. * The content of the header is a base64 encoded JSON payload which can either be a single auth config or a map of auth configs (user+pw or token) with the corresponding registries being the keys. Vanilla Docker, projectatomic Docker and the bindings are transparantly supported. * Add a hidden `--registries-conf` flag. Buildah exposes the same flag, mostly for testing purposes. * Do all credential parsing in the client (i.e., `cmd/podman`) pass the username and password in the backend instead of unparsed credentials. * Add a `pkg/auth` which handles most of the heavy lifting. * Go through the authentication-handling code of most commands, bindings and endpoints. Migrate them to the new code and fix issues as seen. A final evaluation and more tests is still required *after* this change. * The manifest-push endpoint is missing certain parameters and should use the ABI function instead. Adding auth-support isn't really possible without these parts working. * The container commands and endpoints (i.e., create and run) have not been changed yet. The APIs don't yet account for the authfile. * Add authentication tests to `pkg/bindings`. Fixes: #6384 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Matthew Heon

commit sha d4a3c05c0fcd0c53fafda09a682435212b68a68f

Bump to v2.0.0-rc3 Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

Matthew Heon

commit sha cbd4841f3549ef6b50a341e63c7aaed61ce9c4a0

Bump to v2.0.0-dev Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

OpenShift Merge Robot

commit sha 0c750a9672d8078c655fb95f379600609b36dad4

Merge pull request #6207 from vrothberg/auth-header add X-Registry-Auth header support

view details

OpenShift Merge Robot

commit sha 0eea051b92da367469848aac93657653e004a603

Merge pull request #6432 from mheon/bump-2.0.0-rc3 Bump to v2.0.0-RC3

view details

Lokesh Mandvekar

commit sha 8a914e8a0b268121ede5e54032025b4f51dd0b02

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests will be run only if BUILDTAGS contains varlink. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

push eventlsm5/podman

Lokesh Mandvekar

commit sha cde93cd4bc483ce12f8ca3ffca3c565413ed44c9

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests will be run only if BUILDTAGS contains varlink. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

push eventlsm5/podman

Lokesh Mandvekar

commit sha 554652be05d71a09efbf2352997af3a8c2121df9

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests will be run only if BUILDTAGS contains varlink. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

pull request commentcontainers/libpod

enable building without `varlink` tag

I added conditional to skip endpoint tests if no varlink buildtag found.

lsm5

comment created time in 2 months

push eventlsm5/podman

Matthew Heon

commit sha e26f9eda64e4b74e1c56af0b807d37a12a1717a0

Add support for `readonly` option to --mount This is just an alias to the `ro` option, but it's already in the manpages (and Docker) so we might as well add support for it. Fixes #6379 Signed-off-by: Matthew Heon <matthew.heon@pm.me>

view details

Matthew Heon

commit sha e0eb6022b32f4261dbd5b78d958afc15ec2af297

Ensure that signal names can be parsed on Windows To ensure the Windows and OS X remote clients can properly parse container stop signal (when given as a name e.g. SIGTERM) and set it in SpecGen, we need access to a list of Linux signal names and the numbers they map to that is available on non-Linux OSes. Fortunately, these are ABI constants that are extremely unlikely to change, so we can just take the existing constant definitions from the library and use them. The signal numbers used here are sourced from AMD64, but should be the same for every architecture that is not Alpha, SPARC, MIPS, and PA-RISC. So `podman run --stop-signal SIGTTOU` from a Windows client to a Podman service on a SPARC host will set an incorrect stop signal, but I don't think this is a large problem. Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

Daniel J Walsh

commit sha 911b6d8b4808cb6d341fbf7d22f7ebee0227ff4f

Vendor in containers/common v0.12.0 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

dependabot-preview[bot]

commit sha ef807d0ac7ee684fa995592a7b9a1105bd4f173d

Bump github.com/stretchr/testify from 1.5.1 to 1.6.0 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.5.1 to 1.6.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.5.1...v1.6.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha f9217939489ce693db2b358fc8eab68bedac2180

Merge pull request #6423 from rhatdan/VENDOR Vendor in containers/common v0.12.0

view details

OpenShift Merge Robot

commit sha 6e3aec3c6d36e1e344a315e3a5a1600bac154904

Merge pull request #6419 from mheon/signal_parse_windows Ensure that signal names can be parsed on Windows

view details

OpenShift Merge Robot

commit sha 8e048b23fecbcf2140d1f0234d6067379d915953

Merge pull request #6429 from containers/dependabot/go_modules/github.com/stretchr/testify-1.6.0 Bump github.com/stretchr/testify from 1.5.1 to 1.6.0

view details

OpenShift Merge Robot

commit sha 78c38460eb8ba9190d414f2da6a1414990cc6cfd

Merge pull request #6380 from mheon/fix_mount_readonly Add support for `readonly` option to --mount

view details

Lokesh Mandvekar

commit sha e3856355f1ecf838163816bf4d5c5974a0fcc290

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests will be run only if BUILDTAGS contains varlink. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

push eventlsm5/podman

Valentin Rothberg

commit sha d6469c9c9b88cf206b24a99a764ebfbc82d217b7

fix `ps --last=N` Fix `ps --last=N` to also include non-running containers. Also add an e2e test to prevent us from regressing in the future. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha e8818ced806910f8ce44939fef08f89139be4119

Merge pull request #6416 from vrothberg/fix-ps-last fix `ps --last=N`

view details

Jhon Honce

commit sha 5626c2163bff661540e1ae3a5df25f0c7e7573f6

V2 verify JSON output is consistent and doesn't drift $ cd test/apiv2 $ python -m unittest -v test_rest_v1_0_0.TestApi Signed-off-by: Jhon Honce <jhonce@redhat.com>

view details

OpenShift Merge Robot

commit sha cd1e25f5d57059a50e8aeae5b640c2d282e70f96

Merge pull request #6420 from jwhonce/wip/json V2 verify JSON output is consistent and doesn't drift

view details

Lokesh Mandvekar

commit sha 68cfda376615e8a0b87d4fcd8c0dc59e55acf446

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests are guarded by the varlink buildtag as well. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

push eventlsm5/podman

Lokesh Mandvekar

commit sha 263a2542bebc0f64528e6d56407cdcd2631f3aa6

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests are guarded by the varlink buildtag as well. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

push eventlsm5/podman

Lokesh Mandvekar

commit sha b79d1947d1f13c2a74a7f08bded9e03462518e48

default build without `varlink` tag Issue gh#6286 was already fixed in a prior commit but the Makefile still ran some varlink steps by default. This commit makes any varlink build steps dependent on the varlink build tag and also makes the contrib rpm spec file independent of varlink. Endpoint tests are guarded by the varlink buildtag as well. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>

view details

push time in 2 months

pull request commentcontainers/libpod

enable building without `varlink` tag

Hmmm. CI is not happy, and it doesn't look (at first glance) like a flake:

[+0179s] # github.com/containers/libpod/test/endpoint [github.com/containers/libpod/test/endpoint.test]
[+0179s] test/endpoint/config.go:10: undefined: ALPINE
[+0179s] test/endpoint/setup.go:19: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:102: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:120: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:129: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:136: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:144: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:176: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:185: undefined: EndpointTestIntegration
[+0179s] test/endpoint/setup.go:195: undefined: EndpointTestIntegration
[+0179s] test/endpoint/config.go:10: too many errors

err, yes that's a consequence of me wrapping test/endpoint/endpoint.go inside varlink buildtag.

Could someone please let me know if test/endpoint is a varlink-specific thing? Or if I should split out the varlink specific stuff in separate files?

lsm5

comment created time in 2 months

more