profile
viewpoint

seishun/node-steam 962

Interface directly with Steam servers from Node.js

seishun/node-steam-trade 164

Node.js wrapper around Steam trading

seishun/irc-steam-relay 26

UNMAINTAINED. Relays messages between a Steam chat room and an IRC channel

seishun/node-steam-resources 21

Steam resources for Node.js

seishun/node-steam-crypto 15

Node.js implementation of Steam crypto

seishun/node-steam-web-api 12

Steam Web API for Node.js and io.js

seishun/node-tf2 9

UNMAINTAINED. node-steam plugin for Team Fortress 2

seishun/mark 2

A basic Markov chain implementation for text generation for Node.js

seishun/node-dota2 2

node-steam plugin for Dota 2

seishun/aoc2018 1

solutions to advent of code 2018 in haskell

pull request commentnodejs/node-v8

tools: update v8 gypfiles

That looks reasonable, although I think the proper long-term solution is to build V8 using GN.

gengjiawen

comment created time in 7 hours

Pull request review commentdenoland/deno

Removal of the ansi_term dependency

 async fn test_command( }  pub fn main() {-  #[cfg(windows)]-  ansi_term::enable_ansi_support().ok(); // For Windows 10

Now there's something wrong with the colors. image It looks like they're not reset properly. Is the behavior different on Linux?

jsouto18

comment created time in 12 hours

Pull request review commentdenoland/deno

Removal of the ansi_term dependency

 async fn test_command( }  pub fn main() {-  #[cfg(windows)]-  ansi_term::enable_ansi_support().ok(); // For Windows 10

It seems this function isn't even compiled. As far as I can tell, termcolor isn't used to write to stdout/stderr, so it makes sense. I guess deno will have to call set_virtual_terminal_processing directly.

jsouto18

comment created time in a day

pull request commentdenoland/deno

Really fix issue with detecting AMD-like imports

The issue is still there if checkJs is enabled.

tsconfig.json

{
  "compilerOptions": {
    "checkJs": true,
    "allowJs": true
  }
}

foo.ts

import "./test.js";

test.js

function define(foo) {}
define(["long"]);

..\deno\target\debug\deno.exe --config tsconfig.json foo.ts

Compile file:///C:/Users/Nikolai/test-proj-delete/foo.ts
error: Uncaught URIError: relative import path "long" not prefixed with / or ./ or ../ Imported from "file:///C:/Users/Nikolai/test-proj-delete/test.js"
seishun

comment created time in a day

Pull request review commentdenoland/deno

Removal of the ansi_term dependency

 async fn test_command( }  pub fn main() {-  #[cfg(windows)]-  ansi_term::enable_ansi_support().ok(); // For Windows 10

Colors are broken on Windows after this commit:

Compile file:///C:/Users/Nikolai/deno/foo.ts
error TS7006: Parameter 'foo' implicitly has an 'any' type.

► file:///C:/Users/Nikolai/deno/foo.ts:1:17

1 function define(foo) {}
                  ~~~
jsouto18

comment created time in a day

Pull request review commentlibuv/libuv

fs: use WTF-8 on Windows

 void uv_fs_init(void) { }  +static unsigned int fs__decode_wtf8_char(const char** input) {+  unsigned int code_point;+  unsigned char b = **input, b2, b3, b4;+  if (b >= 0x00 && b <= 0x7F) {+    code_point = b;+  } else if (b >= 0xC2 && b <= 0xDF) {+    assert((*input)[1]);+    b2 = *++*input;+    code_point = ((b & 0x1F) << 6) + (b2 & 0x3F);+  } else if (b >= 0xE0 && b <= 0xEF) {+    assert((*input)[1] && (*input)[2]);+    b2 = *++*input;+    b3 = *++*input;+    code_point = ((b & 0x0F) << 12) + ((b2 & 0x3F) << 6) + (b3 & 0x3F);+  } else if (b >= 0xF0 && b <= 0xF0) {+    assert((*input)[1] && (*input)[2] && (*input)[3]);+    b2 = *++*input;+    b3 = *++*input;+    b4 = *++*input;+    code_point = ((b & 0x07) << 18) + ((b2 & 0x3F) << 12) ++      ((b3 & 0x3F) << 6) + (b4 & 0x3F);+  }

An error would make sense if it can be handled. In this case, that assumption failing indicates a problem in the embedder's code, so an assert is more appropriate.

seishun

comment created time in 2 days

issue openedmafintosh/protocol-buffers

Leading '.' not supported

test.proto

enum FOO {
  BAR = 1;
}
message AnotherOne {
  .FOO list = 1;
}
> var messages = protobuf(fs.readFileSync('test.proto'))
Uncaught Error: Could not resolve .FOO

See https://developers.google.com/protocol-buffers/docs/proto#packages-and-name-resolution:

Type name resolution in the protocol buffer language works like C++: first the innermost scope is searched, then the next-innermost, and so on, with each package considered to be "inner" to its parent package. A leading '.' (for example, .foo.bar.Baz) means to start from the outermost scope instead.

created time in 2 days

Pull request review commentlibuv/libuv

fs: use WTF-8 on Windows

 void uv_fs_init(void) { }  +static unsigned int fs__decode_wtf8_char(const char** input) {+  unsigned int code_point;+  unsigned char b = **input, b2, b3, b4;+  if (b >= 0x00 && b <= 0x7F) {+    code_point = b;+  } else if (b >= 0xC2 && b <= 0xDF) {+    assert((*input)[1]);+    b2 = *++*input;+    code_point = ((b & 0x1F) << 6) + (b2 & 0x3F);+  } else if (b >= 0xE0 && b <= 0xEF) {+    assert((*input)[1] && (*input)[2]);+    b2 = *++*input;+    b3 = *++*input;+    code_point = ((b & 0x0F) << 12) + ((b2 & 0x3F) << 6) + (b3 & 0x3F);+  } else if (b >= 0xF0 && b <= 0xF0) {+    assert((*input)[1] && (*input)[2] && (*input)[3]);+    b2 = *++*input;+    b3 = *++*input;+    b4 = *++*input;+    code_point = ((b & 0x07) << 18) + ((b2 & 0x3F) << 12) ++      ((b3 & 0x3F) << 6) + (b4 & 0x3F);+  }

@StefanKarpinski see https://github.com/libuv/libuv/pull/2192#issuecomment-464457965. The string won't come directly from the user (who shouldn't know anything about WTF-8) but from the embedder, so we can expect valid input.

seishun

comment created time in 3 days

issue openedprotocolbuffers/protobuf

BigInt for 64-bit integers

<!--

NOTE: this form is for feature requests (including cleanup requests) only. For questions or troubleshooting, please see the protobuf mailing list: https://groups.google.com/forum/#!forum/protobuf

-->

What language does this apply to? JavaScript

Describe the problem you are trying to solve. Getting and setting 64-bit integers without losing precision.

Describe the solution you'd like Use BigInt to represent 64-bit integers.

Describe alternatives you've considered Using strings, but:

  • This requires modifying .proto files, see https://github.com/protocolbuffers/protobuf/pull/6504.
  • It's inconvenient if you need to do any operations on the value.

Additional context There's a binary protoc option that enables serialization into Uint8Array. I suggest adding a bigint option that makes getters for 64-bit integer fields return BigInt and preferably requires BigInt in setters.

created time in 3 days

pull request commentprotocolbuffers/protobuf

JS: add "int64_type" option to set default type of 64-bit integers

@TeBoring when is this going to happen?

lqs

comment created time in 3 days

issue commentnodejs/node

fs.remove dont remove bad symlinks (Fails with ENOENT code)

Can't reproduce. Symlink deleted successfully. Please post full code.

codermapuche

comment created time in 5 days

pull request commentdenoland/deno

Fix stack traces for required modules

I can't reproduce the test failure locally. Seems unrelated.

seishun

comment created time in 5 days

pull request commentdenoland/deno

Fix stack traces for required modules

Added a test.

seishun

comment created time in 5 days

push eventseishun/deno

Nikolai Vavilov

commit sha 57abc45b653ab28fe36702d43c1f059d1b5ee7c4

add test

view details

push time in 5 days

issue commentnodejs/node-v8

zlib build fail on windows platform

It seems after this change zlib requires the X86_WINDOWS define to be set on Windows.

gengjiawen

comment created time in 5 days

pull request commentdenoland/deno

Fix stack traces for required modules

Is cli/tests/integration_tests.rs the right place for a test for an std module?

seishun

comment created time in 6 days

push eventseishun/deno

Nikolai Vavilov

commit sha 31b2d91464ec292a759c715b3fbff4a8d1047956

fix format

view details

push time in 6 days

PR opened denoland/deno

Fix stack traces for required modules

Before:

error: Uncaught Error: illegal token '105' (../Protobufs/steam/steammessages_clientserver_login.proto, line 1)
► <unknown>:94:16
    at illegal (<unknown>:94:16)
    at parse (<unknown>:734:23)
    at process (<unknown>:108:30)
    at <unknown>:183:17
    at fetchReadFileCallback (<unknown>:51:19)
    at file:///C:/Users/Nikolai/deno/std/node/_utils.ts:33:26

After:

error: Uncaught Error: illegal token '105' (../Protobufs/steam/steammessages_clientserver_login.proto, line 1)
► file:///C:/Users/Nikolai/deno-steam/node_modules/protobufjs/src/parse.js:94:16

94         return Error("illegal " + (name || "token") + " '" + token + "' (" + (filename ? filename + ", " : "") + "line " + tn.line + ")");
                  ^

    at illegal (file:///C:/Users/Nikolai/deno-steam/node_modules/protobufjs/src/parse.js:94:16)
    at parse (file:///C:/Users/Nikolai/deno-steam/node_modules/protobufjs/src/parse.js:734:23)
    at process (file:///C:/Users/Nikolai/deno-steam/node_modules/protobufjs/src/root.js:108:30)
    at file:///C:/Users/Nikolai/deno-steam/node_modules/protobufjs/src/root.js:183:17
    at fetchReadFileCallback (file:///C:/Users/Nikolai/deno-steam/node_modules/@protobufjs/fetch/index.js:51:19)
    at file:///C:/Users/Nikolai/deno/std/node/_utils.ts:33:26

I'm quite new to Rust, so any suggestions on the code will be greatly appreciated.

+9 -4

0 comment

3 changed files

pr created time in 6 days

delete branch seishun/deno

delete branch : fix-ws

delete time in 8 days

issue commentprotocolbuffers/protobuf

JavaScript: es6 module generation

Would you accept ES6 support in a pull request?

tbillington

comment created time in 8 days

issue commentprotobufjs/protobuf.js

protobufjs library itself doesn't provide module support

This would be particularly useful to support deno. I would love to help with this, but since protobuf.js uses CommonJS, a design decision needs to be made on how to approach this.

gertcuykens

comment created time in 8 days

pull request commentdenoland/deno

Really fix issue with detecting AMD-like imports

C:\Users\Nikolai\test-proj-delete>..\deno\target\debug\deno.exe --config tsconfig.json test.js
error: Uncaught ReferenceError: require is not defined
► file:///C:/Users/Nikolai/test-proj-delete/test.js:1:13

1 const foo = require("./foo.ts");
              ^

    at file:///C:/Users/Nikolai/test-proj-delete/test.js:1:13

Do you get a different result?

seishun

comment created time in 9 days

pull request commentdenoland/deno

Really fix issue with detecting AMD-like imports

Could you provide more specific steps? I ran your CommonJS example in a directory with the following tsconfig.json:

{
  "compilerOptions": {
    "checkJs": true,
    "allowJs": true
  }
}

It didn't seem to be converted to ESM:

C:\Users\Nikolai\test-proj-delete>..\deno\target\debug\deno.exe test.js
error: Uncaught ReferenceError: require is not defined
► file:///C:/Users/Nikolai/test-proj-delete/test.js:1:13

1 const foo = require("./foo.ts");
              ^

    at file:///C:/Users/Nikolai/test-proj-delete/test.js:1:13
seishun

comment created time in 9 days

pull request commentdenoland/deno

Really fix issue with detecting AMD-like imports

Please provide an example.

seishun

comment created time in 9 days

pull request commentdenoland/deno

Really fix issue with detecting AMD-like imports

Do such situations currently exist or is it pure theory?

seishun

comment created time in 9 days

PR opened denoland/deno

Update ws client example

<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->

+4 -6

0 comment

2 changed files

pr created time in 9 days

create barnchseishun/deno

branch : fix-ws

created branch time in 9 days

issue commentdenoland/deno

Static non-code resources in modules

Possibly, great for discussion on that issue, as we wouldn't want to introduce one.

That issue is about fetch, I don't think the usage of import I described is relevant there.

Again, great for discussion on that issue.

Left a comment, but that issue is specifically about fetch cache, which is just one of possible solutions to the problem discussed here.

seishun

comment created time in 9 days

issue commentdenoland/deno

fetch cache

As alluded to above, a fetch cache could be used for static non-code resources, such as .proto files. But it won't be ideal if it would still require --alow-net, and especially if the cache would expire. Compare that to npm packages, where any resources required by the module are stored in a local directory and can be read directly from the file system.

brandonkal

comment created time in 9 days

create barnchseishun/deno

branch : fix-define-detect

created branch time in 9 days

PR opened denoland/deno

Really fix issue with detecting AMD-like imports

https://github.com/denoland/deno/pull/4009 fixed it for TypeScript, but the same detection can be performed on JavaScript.

<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->

+5 -4

0 comment

3 changed files

pr created time in 9 days

issue commentdenoland/deno

Compile error when code contains export declaration-like string

And version of Deno?

As I said, master, which is 0.33.0.

keroxp

comment created time in 9 days

issue commentdenoland/deno

Compile error when code contains export declaration-like string

master, same error ouput:

Compile file:///C:/Users/Nikolai/deno/test.ts
error: Uncaught ImportPrefixMissing: relative import path "long" not prefixed with / or ./ or ../ Imported from "file:///C:/Users/Nikolai/deno/test.ts"
keroxp

comment created time in 10 days

issue commentdenoland/deno

Compile error when code contains export declaration-like string

Another test case that doesn't involve string literals:

function define(foo) {}
define(["long"]);
keroxp

comment created time in 10 days

issue commentdenoland/deno

Non-code resources in modules

If we had a "backdoor" to load any network resources that wouldn't be a very secure model.

Would a proxy that wraps arbitrary resources in a JS module default export as described in https://github.com/denoland/deno/issues/3756#issuecomment-581096259 be considered a backdoor?

@seishun see #3756

From deno manual:

Remote code is fetched and cached on first execution, and never updated until the code is run with the --reload flag. (So, this will still work on an airplane.)

It's unclear how the proposed fetch cache will work exactly, but the quoted behavior would be desirable for non-code resources too. Otherwise it's not an ideal solution.

seishun

comment created time in 10 days

issue commentdenoland/deno

Non-code resources in modules

That is very intentional, as allowing privilaged access to non-code resources would break the security model.

Could you elaborate?

Using import.meta.url as a relative base with fetch and --allow-net is the way to go.

See https://github.com/denoland/deno/issues/4001#issue-565332132:

It seems import works only for code and fetch wouldn't be cached.

seishun

comment created time in 11 days

issue commentdenoland/deno

Non-code resources in modules

Only the imported resources are ever retrieved

Correct, and since only code files can be imported, there is seemingly no way to retrieve non-code resources required by the module other than to use fetch. In Node.js, all resources bundled with the module are local, so it's not an issue there.

seishun

comment created time in 11 days

issue commentdenoland/deno

Non-code resources in modules

Deno.cwd() won't contain the module's resources.

seishun

comment created time in 11 days

issue commentdenoland/deno

Non-code resources in modules

For a module imported via a URL, this will be the module's URL, right? It won't be a local directory where you can directly read files from, like in Node.js.

seishun

comment created time in 11 days

issue openeddenoland/deno

Non-code resources in modules

Let's say I want to write a module that communicates with some service using Protobuf.

In Node.js, the npm package would contain .proto files which the module would load using __dirname.

What's the deno equivalent? It seems import works only for code and fetch wouldn't be cached.

created time in 11 days

PR opened rust-lang/book

Clarify the wording

"a type which didn’t implement the type which defines the method" doesn't make a lot of sense.

+6 -6

0 comment

1 changed file

pr created time in 12 days

push eventseishun/book

Nikolai Vavilov

commit sha fe3aa480cd36f6bc1dd35c3d58affb5b33be9baa

Clarify the wording "a type which didn’t implement the type which defines the method" doesn't make a lot of sense.

view details

push time in 12 days

PR opened rust-lang/book

Improve sentence flow

Having the nouns share the same verb when they're being contrasted feels weird.

+10 -10

0 comment

1 changed file

pr created time in 13 days

push eventseishun/book

Nikolai Vavilov

commit sha 5cb3aaee037269ca2dbf5e52ecf4af6f27edf5e9

Improve sentence flow Having the nouns share the same verb when they're being contrasted feels weird.

view details

push time in 13 days

issue openedrust-lang/book

Exercise in chapter 8 requires casting

The exercise here invites the reader to "use a vector and return the mean (the average value)" given a list of integers.

I might be missing something obvious, but it seems the most natural way to accomplish this is to calculate the sum of the integers and then divide it by the vector length. However, dividing a (presumably) signed integer type by usize results in mismatched types.

It seems this is generally solved by casting, which is not covered by the book at this point. This probably makes the exercise difficult for those without experience in strongly-typed languages.

created time in 14 days

delete branch seishun/rusty_v8

delete branch : patch-1

delete time in 15 days

issue commentdenoland/deno

Don't assume paths are always valid UTF8

I think the solution to this problem will depend on the following questions:

  • Should deno allow accessing files with non-Unicode names?
  • Should deno allow creating such files?

I'd say the most reasonable answers are "yes" and "no", respectively. I propose the following approach:

  • Add a "Path" class that opaquely wraps an OsStr. The user can't construct it, but they can attempt to convert it to a string.
  • Methods such as stat take either a Path or a string as input.
  • Methods such as readDir return Paths as output.

What do you think?

piscisaureus

comment created time in 15 days

issue openeddenoland/deno

readDir/readDirSync panics when run on a directory with non-UTF-16 filenames on Windows

Related to https://github.com/denoland/deno/issues/627.

First, create a directory containing a non-UTF-16 filename. You can use the following code to create such a file:

#include <iostream>
#include <windows.h>
#include <string>
using namespace std;

int main()
{
       // Junk surrogate pair
   const wchar_t *filename = L"hi\xD801\x0037";
   HANDLE hfile = CreateFileW(filename, GENERIC_READ, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL);
   return 0;
}

Then run this deno code inside that directory:

const files = Deno.readDirSync('.\\');

Output:

..\target\debug\deno.exe --allow-read test.ts
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8\src\libcore\macros\mod.rs:15:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

created time in 15 days

PR opened denoland/rusty_v8

Add a note about building on Windows

See https://github.com/denoland/rusty_v8/issues/269.

I'm not sure if adding more detail is necessary. If someone wants to build this from source, they should probably know, or be able to figure out, how Rust toolchains work. That said, I'm new to Rust myself, so there might be more precise terminology for this.

+3 -0

0 comment

1 changed file

pr created time in 15 days

push eventseishun/rusty_v8

Nikolai Vavilov

commit sha 020f077b3dc282b7d7afce2dd884e72474c77f80

Add a note about building on Windows

view details

push time in 15 days

fork seishun/rusty_v8

V8 javascript bindings for Rust

https://crates.io/crates/rusty_v8

fork in 16 days

delete branch seishun/deno

delete branch : patch-1

delete time in 16 days

PR opened denoland/deno

Bump required VS version

deno builds successfully with VS2019, so no need to require VS2017.

<!-- Before submitting a PR, please read https://deno.land/std/manual.md#contributing -->

+1 -1

0 comment

1 changed file

pr created time in 16 days

push eventseishun/deno

Nikolai Vavilov

commit sha 5e7544c9549632a0e935b15b6fe5b6d4eec92658

Bump required VS version deno builds successfully with VS2019, so no need to require VS2017.

view details

push time in 16 days

issue commentdenoland/deno

Build with VS2019

I uninstalled VS2017 and ran cargo clean. deno built successfully with only VS2019 installed. I think this can be closed.

ry

comment created time in 16 days

issue openeddenoland/deno

Outdated paths in std/manual.md

For example:

  • tests/http_bench.ts (moved to tools/deno_tcp.ts)
  • third_party/wrk/linux/wrk (moved to third_party/prebuilt/linux64/wrk)
  • tests/002_hello.ts (moved to cli/tests/002_hello.ts)

I'd be happy to update them myself but I don't know what to do with some of them. For example, ./third_party/v8/tools/linux-tick-processor was moved to v8_rusty and is no longer directly accessible.

created time in 16 days

issue commentdenoland/deno

error LNK2019: unresolved external symbol

The solution is to uninstall Rust and install the 64-bit toolchain (https://github.com/denoland/rusty_v8/issues/269#issuecomment-583791122). I suppose this should be documented.

aliabolhassani

comment created time in 16 days

issue commentdenoland/rusty_v8

Broken binary on 64-bit Windows

Should that be mentioned in the docs here (and in deno)? Currently, installing Rust from https://www.rust-lang.org/tools/install will get you a 32-bit toolchain by default (although it seems it's going to change, see https://github.com/rust-lang/rustup/pull/2186 and https://github.com/rust-lang/www.rust-lang.org/pull/1004).

seishun

comment created time in 16 days

issue commentdenoland/rusty_v8

Broken binary on 64-bit Windows

Default host: i686-pc-windows-msvc
rustup home:  C:\Users\Nikolai\.rustup

stable-i686-pc-windows-msvc (default)
rustc 1.41.0 (5e1a79984 2020-01-27)
seishun

comment created time in 17 days

issue closedseishun/node-steam-resources

no such file or directory, open /node_modules/steam-resources/protobuf_gen/protos.csv

index.js contains the following:

var protos = parse(fs.readFileSync(__dirname + '/protobuf_gen/protos.csv', {
  encoding: 'ascii'
}), {
  columns: true
});

But this "protobuf_gen" folder does simply not exist.

closed time in 17 days

simonsk90

issue commentseishun/node-steam-resources

no such file or directory, open /node_modules/steam-resources/protobuf_gen/protos.csv

It seems it didn't work because there shouldn't be a package-lock.json file. Sorry, can't help you further.

simonsk90

comment created time in 17 days

issue commentseishun/node-steam-resources

no such file or directory, open /node_modules/steam-resources/protobuf_gen/protos.csv

There's probably something wrong with your setup. Try clearing the cache or using a different machine.

simonsk90

comment created time in 18 days

issue commentseishun/node-steam-resources

no such file or directory, open /node_modules/steam-resources/protobuf_gen/protos.csv

It does create the directory for me. What's your output of ls node_modules/steam-resources?

simonsk90

comment created time in 18 days

issue commentseishun/node-steam-resources

no such file or directory, open /node_modules/steam-resources/protobuf_gen/protos.csv

What was the output for npm install seishun/node-steam-resources? And what's your npm version?

simonsk90

comment created time in 18 days

issue openeddenoland/rusty_v8

Broken binary on 64-bit Windows

I might be doing something wrong, but it seems binding.cc gets built for x64, while the Rust code gets built for x86. This causes linker errors when this crate is used: https://github.com/denoland/deno/issues/3716

Steps:

  1. Clone the repo and run cargo build -vv.
  2. Open target/debug/librusty_v8.rlib in 7-Zip, extract rusty_v8/binding.obj and one of the Rust .o files, compare their dumpbin /headers outputs.

Expected: same "machine" values.

Actual: Rust object files have 14C machine (x86), binding.obj has 8664 machine (x64).

created time in 18 days

PR opened rust-lang/book

Add missing apostrophe
+1 -1

0 comment

1 changed file

pr created time in 18 days

push eventseishun/book

Nikolai Vavilov

commit sha 449518e34c0e7262b087e18aaeda4760ba5bc4df

Add missing apostrophe

view details

push time in 18 days

fork seishun/book

The Rust Programming Language

https://doc.rust-lang.org/book/

fork in 18 days

issue commentdenoland/deno

error LNK2019: unresolved external symbol

It seems this particular problem was introduced in 5f1df038fb1462607af3555fa7431c05ca484dce. However, the previous commit doesn't build either and fails with other unresolved external symbols, e.g. _deno_delete and _deno_new. @aliabolhassani is it the same for you?

aliabolhassani

comment created time in 21 days

delete branch seishun/deno

delete branch : deno2-win

delete time in 22 days

pull request commentlibuv/libuv

fs: use WTF-8 on Windows

@vtjnash Thank you for the comments. Some of them relate to arbitrary user input, which I addressed in the second half of https://github.com/libuv/libuv/pull/2192#issuecomment-464457965. What do you think?

seishun

comment created time in 24 days

delete branch seishun/build

delete branch : centos6-gcc49

delete time in a month

issue closedseishun/node-steam-resources

Its not a npm bug

You can run: which svn

Then: mv OUTPUT_PAtH_ABOVE OUTPUT_PATH_ABOVE-backup

Then try to run npm install csgo

When you want to restore svn move it back.

closed time in a month

EloB

issue commentseishun/node-steam-resources

Its not a npm bug

You don't need svn if this module is bundled (as it should be). If it's not bundled, complain to the maintainers of the module that uses this module.

It seems you're conflating multiple issues here. One is that the csgo package doesn't include node_modules for some reason. The other is the npm bug where it doesn't properly handle bundled dependencies and package-lock.json. I can't help you with either.

EloB

comment created time in a month

issue commentseishun/node-steam-resources

Its not a npm bug

So, which part confuses you? That svn can't be run if it doesn't exist?

EloB

comment created time in a month

push eventseishun/node-steam

Nikolai Vavilov

commit sha 55227d4d892f975e82e709618bf2b6c97c89bed0

Update protobuf links

view details

push time in a month

push eventseishun/node-steam

Nikolai Vavilov

commit sha 25ca19b0765e3023d937267a1dc362f9a81384d7

Bump steam-resources version

view details

push time in a month

issue closedseishun/node-steam-resources

The prepare script is broken

https://github.com/seishun/node-steam-resources/blob/master/package.json#L6

This command no longer works. svn checkout https://github.com/SteamRE/SteamKit/trunk/Resources/ProtobufGen protobuf_gen

I think this could be the problem why steam module isn't working.

closed time in a month

EloB

issue commentseishun/node-steam-resources

The prepare script is broken

You should do more research before spamming issues. The command works just fine.

EloB

comment created time in a month

issue commentseishun/node-steam-resources

Installation problems (howto?)

I don't see how this is an issue with the module. Looks like an npm bug to me.

zmechu

comment created time in a month

pull request commentlibuv/libuv

win, fs: mkdir really return UV_EINVAL for invalid names

Mapping ERROR_DIRECTORY to UV_EINVAL would be consistent with _mkdir and _rmdir. Unfortunately CreateProcess sets ERROR_DIRECTORY if lpCurrentDirectory is set to a non-existent directory (see 9f07a3673b301da99bd31f2d793983caad6e3428, it seems @bnoordhuis misunderstood the cause of the breakage). I think the proper solution would be to add a case for UV_EINVAL here.

seishun

comment created time in 2 months

push eventseishun/aoc2019

Nikolai Vavilov

commit sha e3101633b93cd232efe98324a2ab167f5fd572ba

Add day6 part1

view details

Nikolai Vavilov

commit sha e836c2bcf18f6d73cdc2d78f95cdba34d780fd69

Add day6 part2

view details

Nikolai Vavilov

commit sha ae4ad57a86519c0c494fc104f7e68f7233461e11

Add day6 in C++

view details

Nikolai Vavilov

commit sha a6a5654cedf2c965a4274daa26bf9b25d183cd28

Add day7 part1

view details

Nikolai Vavilov

commit sha d2c967b7fbf3889381ede1026d25054c467bf60c

Add day7 part2

view details

Nikolai Vavilov

commit sha ee9f58a9152c58b3f09287f4fce68e69a40b6e8a

Add day7 in C++

view details

Nikolai Vavilov

commit sha 1ad82c979c5f820b3e467395d339f0531c1205ac

Add day8 part1

view details

Nikolai Vavilov

commit sha 67dc1daafe2c3840b44da51991fe589dbaff23df

Add day8 part2

view details

Nikolai Vavilov

commit sha ff20ff6c5f1d970d401e4c7565694dabad3cdcdc

Add day8 in C++

view details

Nikolai Vavilov

commit sha e2169a2227ce805078dcbcd1d55bb02ba62a5e3d

Add day9 part1

view details

Nikolai Vavilov

commit sha c25f804a752e65c751f6d09c296920c3c6de6c1a

Add day9 part2

view details

Nikolai Vavilov

commit sha 6b25d6f6874f99839868a778df0430521dd73a9e

Add day9 in C++

view details

Nikolai Vavilov

commit sha b96d2f5cf7c7772649883a72b28d3e931b7b1b07

Add day10 part1

view details

Nikolai Vavilov

commit sha 82c73fa8aa503c62740a0a3f53f9e61a3330bcaa

Add day10 part2

view details

Nikolai Vavilov

commit sha 70cee63598669125cd6a02a134e9e0496a0f0092

Add day10 in C++

view details

Nikolai Vavilov

commit sha f2089c2013923bf2a667639cf44252c5d62f7301

Add day11 part1

view details

Nikolai Vavilov

commit sha e03c690d2dc87b1c164228db8380844ab100b9bc

Add day11 part2

view details

Nikolai Vavilov

commit sha e665e1b434c019979754c42f99b653074d06e54d

Add day11 in C++

view details

Nikolai Vavilov

commit sha 561b7be54ff365a90b6719d483bf99f4590dd460

Add day12 part1

view details

Nikolai Vavilov

commit sha 043db330ee1ffbe16a7ddf6e4a114fd9831f66b1

Add day12 part2

view details

push time in 2 months

pull request commentlibuv/libuv

win, fs: mkdir really return UV_EINVAL for invalid names

That's for ERROR_INVALID_NAME, this is for ERROR_DIRECTORY.

seishun

comment created time in 2 months

pull request commentlibuv/libuv

win, fs: mkdir really return UV_EINVAL for invalid names

@bzoz

seishun

comment created time in 2 months

PR opened libuv/libuv

win, fs: mkdir really return UV_EINVAL for invalid names

Makes uv_fs_mkdir return UV_EINVAL for invalid directory names instead of UV_ENOENT.

Ref: https://github.com/nodejs/node/issues/31177

I'm not happy about locally overriding uv_translate_sys_error but I can't think of a better approach.

+4 -1

0 comment

2 changed files

pr created time in 2 months

create barnchseishun/libuv

branch : mkdir-einval

created branch time in 2 months

startedseishun/node-steam-resources

started time in 2 months

issue commentseishun/node-steam-resources

Can`t install on npm 6.13.4

Full log?

Komar12124

comment created time in 2 months

push eventseishun/aoc2019

Nikolai Vavilov

commit sha 4cf6c8a9c08e7b343ffab6dbe5cc8e880feee70a

Add day5 in C++

view details

push time in 3 months

create barnchseishun/aoc2019

branch : master

created branch time in 3 months

created repositoryseishun/aoc2019

Solutions to Advent of Code 2019 in Haskell and C++

created time in 3 months

issue closedseishun/node-steam-resources

[Dota2] Error: Duplicate name in namespace Namespace : CExtraMsgBlock

Hi there, I'm trying to run node example.js from https://github.com/Arcana/node-dota2, but errors appears:

~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:1530
                    throw Error("Duplicate name in namespace "+this.toString(true)+": "+child.name);
                    ^

Error: Duplicate name in namespace Namespace : CExtraMsgBlock
    at Namespace.ProtoBuf.Reflect.NamespacePrototype.addChild (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:1530:27)
    at Builder.ProtoBuf.Builder.BuilderPrototype.create (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:4470:34)
    at Builder.ProtoBuf.Builder.BuilderPrototype.import (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:4669:22)
    at Object.ProtoBuf.loadJson (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:5135:26)
    at Object.ProtoBuf.loadProto (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:5038:25)
    at Object.ProtoBuf.loadProtoFile (~\node-worker\node_modules\protobufjs\dist\ProtoBuf.js:5084:52)
    at ~\node-worker\node_modules\steam-resources\index.js:41:14
    at Array.forEach (<anonymous>)
    at loadProtoFiles (~\node-worker\node_modules\steam-resources\index.js:40:9)
    at Object.<anonymous> (~\node-worker\node_modules\steam-resources\index.js:33:15)

I have checked code and found that commit: https://github.com/SteamDatabase/GameTracking-Dota2/commit/ea7a913d97ad1ea85ad03d0d7fc57c9094c55c33#diff-e53f0f3df740474482f2fc18a8ae1de2 There was added message CExtraMsgBlock to Protobufs/econ_gcmessages.proto, but message CExtraMsgBlock already exists at extramsgblockutil.proto. And removed line import "extramsgblockutil.proto"; from Protobufs/dota_gcmessages_server.proto If I revert these changes locally, then all works.

closed time in 3 months

worldofsites

issue commentseishun/node-steam-resources

[Dota2] Error: Duplicate name in namespace Namespace : CExtraMsgBlock

Fixed in https://github.com/SteamRE/SteamKit/commit/e243eb845bb68aa8828d827769aa3f26d61569d1.

worldofsites

comment created time in 3 months

delete branch seishun/SteamKit

delete branch : update-protobufs

delete time in 3 months

issue commentseishun/node-steam-resources

[Dota2] Error: Duplicate name in namespace Namespace : CExtraMsgBlock

https://github.com/SteamRE/SteamKit/pull/792

worldofsites

comment created time in 3 months

PR opened SteamRE/SteamKit

Update and regenerate protobufs

extramsgblockutil.proto is no more.

+669 -91

0 comment

19 changed files

pr created time in 3 months

create barnchseishun/SteamKit

branch : update-protobufs

created branch time in 3 months

issue commentseishun/node-steam-resources

[Dota2] Error: Duplicate name in namespace Namespace : CExtraMsgBlock

You can delete the extra message locally as a workaround.

worldofsites

comment created time in 3 months

issue commentseishun/node-steam-resources

[Dota2] Error: Duplicate name in namespace Namespace : CExtraMsgBlock

Simpler way to reproduce: require('steam-resources').

worldofsites

comment created time in 3 months

more