profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/robertpanzer/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

robertpanzer/arquillian-core 2

Arquillian provides a component model for integration tests, which includes dependency injection and container life cycle management. Now, instead of having to manage a runtime in your test, Arquillian brings your test to the runtime. Arquillian Core, Container Extension + Protocols + Enrichers

robertpanzer/asciidoctorj-extensions-lab 2

A collection of extensions for AsciidoctorJ that may be freely reused

robertpanzer/arquillian-container-jruby 0

An embedded Arquillian container adapter that helps in development of JRuby applications

robertpanzer/arquillian-container-was 0

Arquillian WebSphere Containers

robertpanzer/arquillian-cube 0

Arquillian Docker

robertpanzer/arquillian-extension-jacoco 0

Arquillian Jacoco Extension

robertpanzer/arquillian-extension-persistence 0

Arquillian Database / Persistence Extension

robertpanzer/arquillian-extension-warp 0

Warp fills the void between client-side and server-side testing.

robertpanzer/arquillian-wlp-demo 0

Demo project for testing a Java EE application with Arquillian on WebSphere Liberty Profile

issue commentasciidoctor/asciidoctorj

Performance regression in v2.5.0

I ran my test again with concurrent-ruby 1.1.7, 1.1.8 and 1.1.9 but 1.1.7 still seems to be the best (on my senior mac from 2014):

1.1.7
Asciidoctor.create took 5629 msecs
Asciidoctor.convert took 18613 msecs
Asciidoctor.convert took 4038 msecs

1.1.8
Asciidoctor.create took 6093 msecs
Asciidoctor.convert took 28191 msecs
Asciidoctor.convert took 2364 msecs

1.1.9
Asciidoctor.create took 5163 msecs
Asciidoctor.convert took 24633 msecs
Asciidoctor.convert took 2264 msecs

I just took current main, and ran this test:

@RunWith(Arquillian.class)
public class TimeTest {

    @ArquillianResource
    private ClasspathResources classpath;

    @Test
    public void test() {
        String filename = "code-sample";
        File inputFile = this.classpath.getResource(filename + ".adoc");
        File outputFile1 = new File(inputFile.getParentFile(), filename + ".pdf");

        long t1 = System.currentTimeMillis();
        Asciidoctor asciidoctor = Asciidoctor.Factory.create();
        long t2 = System.currentTimeMillis();
        System.out.println("Asciidoctor.create took " + (t2 - t1) + " msecs");
        asciidoctor.convertFile(inputFile, options().backend("pdf").safe(SafeMode.UNSAFE).get());
        long t3 = System.currentTimeMillis();
        System.out.println("Asciidoctor.convert took " + (t3 - t2) + " msecs");


        long t4 = System.currentTimeMillis();
        asciidoctor.convertFile(inputFile, options().backend("pdf").safe(SafeMode.UNSAFE).get());
        long t5 = System.currentTimeMillis();
        System.out.println("Asciidoctor.convert took " + (t5 - t4) + " msecs");

        assertThat(outputFile1.exists(), is(true));

    }
}
kedar-joshi

comment created time in 14 hours

issue commentasciidoctor/asciidoctorj

Performance regression in v2.5.0

Thanks for the pointer @abelsromero! 🎉 I'll also check how it looks here on my machine.

kedar-joshi

comment created time in 2 days

pull request commentasciidoctor/asciidoctorj

Bump SpringBoot version to latest 2.5.2 in it test

Thanks! 🥳

abelsromero

comment created time in 20 days

push eventasciidoctor/asciidoctorj

Abel Salgado Romero

commit sha baf68d7569bea5fdbc169e4bcd54fc5a920ea4e9

Bump SpringBoot version to latest 2.5.2 in it test

view details

Robert Panzer

commit sha 850f7234419b1b43fffe46c803f7a7a255182ab2

Merge pull request #1048 from abelsromero/upgrade-springboot-it-test-to-latest-springboot

view details

push time in 20 days

PR merged asciidoctor/asciidoctorj

Bump SpringBoot version to latest 2.5.2 in it test

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

Upgrade version of Spring Boot version used in the Spring Boot integration test.

How does it achieve that?

Simply upgrade the configuration of the submodule springboot-app. It also removes an unnecessary asciidoctorj version property.

Are there any alternative ways to implement this?

If necessary we could consider parameterizing the version in a way that allowed to run the same test against several version, por example the 2 most recent minnors. But that can be tricky when we fund breaking changes between minors.

Are there any implications of this pull request? Anything a user must know? No.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+1 -5

0 comment

1 changed file

abelsromero

pr closed time in 20 days

issue commentasciidoctor/asciidoctorj

Asciidoctor does not work OOTB in Quarkus Uber JARs

Hi @oleg-nenashev ! That would be awesome if you could contribute some documentation for integrating AsciidoctorJ with Quarkus! I haven't done anything with Quarkus yet myself, so I am not really aware how that would work.

oleg-nenashev

comment created time in 22 days

startedproxy-wasm/proxy-wasm-rust-sdk

started time in a month

issue commentasciidoctor/asciidoctorj-pdf

Can't use reader/writer `convert` with asciidoctorj-pdf

Writer it = new StringWriter()
doctor.convert(reader, writer, Options.builder().backend("pdf").toStream(it).build())

Yes, for pdf writing to a write does not work since PDF is a binary format.

OutputStream it = new ByteArrayOutputStream()
doctor.convert(reader, null, Options.builder().backend("pdf").toStream(it).build())

This function does (unfortunately) not delegate to the stream option, but writes the rendered String (yes) to the Writer, which also won't work here.

OutputStream it = new ByteArrayOutputStream()
doctor.convertFile(file.toFile(), Options.builder().backend("pdf").toStream(it).build())

That is one option, alternatively you can also pass a String, there is a test case for that here: https://github.com/asciidoctor/asciidoctorj/blob/aeb6a04d44542c3827aa6228b8748c4f312a6b46/asciidoctorj-distribution/src/test/groovy/org/asciidoctor/diagram/WhenAPdfDocumentIsRenderedToStream.groovy#L84

I agree that it would be great to pass a Reader as input, even if it internally also results in having to collect it to a string.

veselov

comment created time in a month

startedenvoyproxy/envoy

started time in a month

pull request commentasciidoctor/asciidoctorj

Chocolatey: Upgrade packaging to 2.5.1.

Thank you!

geraldcombs

comment created time in a month

push eventasciidoctor/asciidoctorj

Gerald Combs

commit sha 7d404a80057f32c6b5167597de0ce444ccb995e4

Chocolatey: Upgrade packaging to 2.5.1.

view details

Robert Panzer

commit sha aeb6a04d44542c3827aa6228b8748c4f312a6b46

Merge pull request #1046 from geraldcombs/choco-update-v2.5.1

view details

push time in a month

PR merged asciidoctor/asciidoctorj

Chocolatey: Upgrade packaging to 2.5.1.

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [x] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [ ] Build improvement

Description

What is the goal of this pull request?

Update the Chocolatey package to 2.5.1.

How does it achieve that?

Updates the version numbers in the Chocolatey assets.

+3 -3

0 comment

2 changed files

geraldcombs

pr closed time in a month

issue commentasciidoctor/asciidoctorj

Impossible to highlighting source block with asciidoctorj

Could you please provide a reproducer? There should not be anything required besides configuring the highlighter to use by defining the attribute :source-highlighter: rouge

klod35

comment created time in 2 months

push eventasciidoctor/asciidoctorj

Robert Panzer

commit sha d38456a9d7faba21eadbe70d777f7ca948bc8f3e

Upgrade remaining dependency on junit 4.12 to 4.13.2

view details

Robert Panzer

commit sha d038617b98907dabb520e9a4c079b6b79d81a9e6

Merge pull request #1044 from robertpanzer/upgrade-junit

view details

push time in 2 months

PR merged asciidoctor/asciidoctorj

Upgrade remaining dependency on junit 4.12 to 4.13.2

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

Sonatype sent a warning that we are still relying on unit 4.12 which has an open CVE. Indeed asciidoctorj-test-support still has that dependency even though the build itself should already have used the fixed version 4.13.2. This PR upgrades this last remaining dependency to 4.13.2 too to avoid that CVE.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+2 -1

0 comment

2 changed files

robertpanzer

pr closed time in 2 months

PR opened asciidoctor/asciidoctorj

Upgrade remaining dependency on junit 4.12 to 4.13.2

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

Sonatype sent a warning that we are still relying on unit 4.12 which has an open CVE. Indeed asciidoctorj-test-support still has that dependency even though the build itself should already have used the fixed version 4.13.2. This PR upgrades this last remaining dependency to 4.13.2 too to avoid that CVE.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+2 -1

0 comment

2 changed files

pr created time in 2 months

create barnchrobertpanzer/asciidoctorj

branch : upgrade-junit

created branch time in 2 months

delete branch robertpanzer/asciidoctorj

delete branch : update-nexus-publishing-plugin

delete time in 2 months

push eventasciidoctor/asciidoctorj

Robert Panzer

commit sha ddd9cdf45ecd68e0ccf70b849ea6e13bdffed51d

Upgrade to new gradle-nexus.publish-plugin

view details

Robert Panzer

commit sha a38da86baeb0387f107753274c2dfbc93e083bf9

Merge pull request #1043 from robertpanzer/update-nexus-publishing-plugin Upgrade to new gradle-nexus.publish-plugin

view details

push time in 2 months

PR merged asciidoctor/asciidoctorj

Upgrade to new gradle-nexus.publish-plugin

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

https://github.com/gradle-nexus/publish-plugin is the new replacement for the Gradle Nexus Staging Plugin and Nexus Publish Plugin duo. This PR updates the build to use this new plugin.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+17 -20

0 comment

3 changed files

robertpanzer

pr closed time in 2 months

PR opened asciidoctor/asciidoctorj

Upgrade to new gradle-nexus.publish-plugin

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

https://github.com/gradle-nexus/publish-plugin is the new replacement for the Gradle Nexus Staging Plugin and Nexus Publish Plugin duo. This PR updates the build to use this new plugin.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+17 -20

0 comment

3 changed files

pr created time in 2 months

delete branch robertpanzer/asciidoctorj

delete branch : build-javacompile-release

delete time in 2 months

create barnchrobertpanzer/asciidoctorj

branch : update-nexus-publishing-plugin

created branch time in 2 months

push eventasciidoctor/asciidoctorj

Robert Panzer

commit sha c28c6d446dd2bc94ffa2675f4875539fa4ba4dae

Remove source- and targetCompatiblity options and use javaCompile.options.release instead

view details

Robert Panzer

commit sha 96ed4f06ad11d4ed0c49141a4958ed7edaf85b06

Don't set Java release version when running with Java 8 which does not support this option yet

view details

Robert Panzer

commit sha fe83101574bdad6de744d166ae380db2f9938ef0

Merge pull request #1042 from robertpanzer/build-javacompile-release Remove source- and targetCompatiblity options and use javaCompile.opt…

view details

push time in 2 months

PR merged asciidoctor/asciidoctorj

Remove source- and targetCompatiblity options and use javaCompile.opt…

…ions.release instead

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

Make sure that AsciidoctorJ can always be consumed with Java 8.

How does it achieve that?

Use the new Gradle option JavaCompile.options.release instead of source and targetCompatibility (https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_cross_compilation)

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+14 -15

0 comment

3 changed files

robertpanzer

pr closed time in 2 months

push eventrobertpanzer/asciidoctorj

Robert Panzer

commit sha 96ed4f06ad11d4ed0c49141a4958ed7edaf85b06

Don't set Java release version when running with Java 8 which does not support this option yet

view details

push time in 2 months

PR opened asciidoctor/asciidoctorj

Remove source- and targetCompatiblity options and use javaCompile.opt…

…ions.release instead

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • [ ] Bug fix
  • [ ] New non-breaking feature
  • [ ] New breaking feature
  • [ ] Documentation update
  • [x] Build improvement

Description

What is the goal of this pull request?

Make sure that AsciidoctorJ can always be consumed with Java 8.

How does it achieve that?

Use the new Gradle option JavaCompile.options.release instead of source and targetCompatibility (https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_cross_compilation)

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

+10 -15

0 comment

3 changed files

pr created time in 2 months

push eventrobertpanzer/asciidoctorj

Robert Panzer

commit sha c28c6d446dd2bc94ffa2675f4875539fa4ba4dae

Remove source- and targetCompatiblity options and use javaCompile.options.release instead

view details

push time in 2 months

create barnchrobertpanzer/asciidoctorj

branch : build-javacompile-release

created branch time in 2 months

issue commentasciidoctor/asciidoctorj-pdf

Problems with custom inline macro extension

The conversion works for me after adding the "alt" attribute:

passthrough:screenshots/redeemer-portal-01-login.png[width=80%,align="center", alt="alt"]

The HTML backend doesn't seem to fail on that because it uses '' as a default.

@mojavelinux Since asciidoctor-pdf 1.6.0 relies on asciidoctor >= 2.0.0 I guess it could also use node.alt instead of node.attr 'alt' here? https://github.com/asciidoctor/asciidoctor-pdf/blob/1ab33379a06161f330f8869cd5bef4310d6f43cb/lib/asciidoctor/pdf/converter.rb#L2502 Then it should also fall back to an empty alt attribute for the image.

0xff-lroe

comment created time in 2 months