I ran my test again with concurrent-ruby 1.1.7, 1.1.8 and 1.1.9 but 1.1.7 still seems to be the best (on my senior mac from 2014):

1.1.7
Asciidoctor.create took 5629 msecs
Asciidoctor.convert took 18613 msecs
Asciidoctor.convert took 4038 msecs

1.1.8
Asciidoctor.create took 6093 msecs
Asciidoctor.convert took 28191 msecs
Asciidoctor.convert took 2364 msecs

1.1.9
Asciidoctor.create took 5163 msecs
Asciidoctor.convert took 24633 msecs
Asciidoctor.convert took 2264 msecs

I just took current main, and ran this test:

@RunWith(Arquillian.class)
public class TimeTest {

    @ArquillianResource
    private ClasspathResources classpath;

    @Test
    public void test() {
        String filename = "code-sample";
        File inputFile = this.classpath.getResource(filename + ".adoc");
        File outputFile1 = new File(inputFile.getParentFile(), filename + ".pdf");

        long t1 = System.currentTimeMillis();
        Asciidoctor asciidoctor = Asciidoctor.Factory.create();
        long t2 = System.currentTimeMillis();
        System.out.println("Asciidoctor.create took " + (t2 - t1) + " msecs");
        asciidoctor.convertFile(inputFile, options().backend("pdf").safe(SafeMode.UNSAFE).get());
        long t3 = System.currentTimeMillis();
        System.out.println("Asciidoctor.convert took " + (t3 - t2) + " msecs");


        long t4 = System.currentTimeMillis();
        asciidoctor.convertFile(inputFile, options().backend("pdf").safe(SafeMode.UNSAFE).get());
        long t5 = System.currentTimeMillis();
        System.out.println("Asciidoctor.convert took " + (t5 - t4) + " msecs");

        assertThat(outputFile1.exists(), is(true));

    }
}

Thanks for the pointer @abelsromero! 🎉 I'll also check how it looks here on my machine.

Thanks! 🥳

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

Upgrade version of Spring Boot version used in the Spring Boot integration test.

How does it achieve that?

Simply upgrade the configuration of the submodule springboot-app. It also removes an unnecessary asciidoctorj version property.

Are there any alternative ways to implement this?

If necessary we could consider parameterizing the version in a way that allowed to run the same test against several version, por example the 2 most recent minnors. But that can be tricky when we fund breaking changes between minors.

Are there any implications of this pull request? Anything a user must know? No.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Hi @oleg-nenashev ! That would be awesome if you could contribute some documentation for integrating AsciidoctorJ with Quarkus! I haven't done anything with Quarkus yet myself, so I am not really aware how that would work.

Writer it = new StringWriter()
doctor.convert(reader, writer, Options.builder().backend("pdf").toStream(it).build())

Yes, for pdf writing to a write does not work since PDF is a binary format.

OutputStream it = new ByteArrayOutputStream()
doctor.convert(reader, null, Options.builder().backend("pdf").toStream(it).build())

This function does (unfortunately) not delegate to the stream option, but writes the rendered String (yes) to the Writer, which also won't work here.

OutputStream it = new ByteArrayOutputStream()
doctor.convertFile(file.toFile(), Options.builder().backend("pdf").toStream(it).build())

That is one option, alternatively you can also pass a String, there is a test case for that here: https://github.com/asciidoctor/asciidoctorj/blob/aeb6a04d44542c3827aa6228b8748c4f312a6b46/asciidoctorj-distribution/src/test/groovy/org/asciidoctor/diagram/WhenAPdfDocumentIsRenderedToStream.groovy#L84

I agree that it would be great to pass a Reader as input, even if it internally also results in having to collect it to a string.

Thank you!

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [x] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [ ] Build improvement

Description

What is the goal of this pull request?

Update the Chocolatey package to 2.5.1.

How does it achieve that?

Updates the version numbers in the Chocolatey assets.

Could you please provide a reproducer? There should not be anything required besides configuring the highlighter to use by defining the attribute :source-highlighter: rouge

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

Sonatype sent a warning that we are still relying on unit 4.12 which has an open CVE. Indeed asciidoctorj-test-support still has that dependency even though the build itself should already have used the fixed version 4.13.2. This PR upgrades this last remaining dependency to 4.13.2 too to avoid that CVE.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

Sonatype sent a warning that we are still relying on unit 4.12 which has an open CVE. Indeed asciidoctorj-test-support still has that dependency even though the build itself should already have used the fixed version 4.13.2. This PR upgrades this last remaining dependency to 4.13.2 too to avoid that CVE.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

https://github.com/gradle-nexus/publish-plugin is the new replacement for the Gradle Nexus Staging Plugin and Nexus Publish Plugin duo. This PR updates the build to use this new plugin.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

https://github.com/gradle-nexus/publish-plugin is the new replacement for the Gradle Nexus Staging Plugin and Nexus Publish Plugin duo. This PR updates the build to use this new plugin.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

…ions.release instead

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

Make sure that AsciidoctorJ can always be consumed with Java 8.

How does it achieve that?

Use the new Gradle option JavaCompile.options.release instead of source and targetCompatibility (https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_cross_compilation)

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

…ions.release instead

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

• [ ] Bug fix
• [ ] New non-breaking feature
• [ ] New breaking feature
• [ ] Documentation update
• [x] Build improvement

Description

What is the goal of this pull request?

Make sure that AsciidoctorJ can always be consumed with Java 8.

How does it achieve that?

Use the new Gradle option JavaCompile.options.release instead of source and targetCompatibility (https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_cross_compilation)

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

The conversion works for me after adding the "alt" attribute:

passthrough:screenshots/redeemer-portal-01-login.png[width=80%,align="center", alt="alt"]

The HTML backend doesn't seem to fail on that because it uses '' as a default.

@mojavelinux Since asciidoctor-pdf 1.6.0 relies on asciidoctor >= 2.0.0 I guess it could also use node.alt instead of node.attr 'alt' here? https://github.com/asciidoctor/asciidoctor-pdf/blob/1ab33379a06161f330f8869cd5bef4310d6f43cb/lib/asciidoctor/pdf/converter.rb#L2502 Then it should also fall back to an empty alt attribute for the image.