kedar-joshi ( Kedar Joshi )

commit sha 349833d48d24385dd42c57a0d0b52d8b6a3c3ace

Updated PostgreSQL driver to v42.2.15 Closes gh-174

Update PostgreSQL driver to v42.2.15

push time in a month

issue closedlocationguru-solutions/web-application-reference

closed time in a month

kedar-joshi

issue openedlocationguru-solutions/web-application-reference

Update PostgreSQL to v42.2.15

created time in a month

push eventlocationguru-solutions/web-application-reference

commit sha b928f112c1d88b745dab48e1815a13d751c5cb03

Updated JUnit to v5.7.0-RC1

push time in a month

push eventkedar-joshi/openjdk

commit sha 19f35a39a32a4cae13c932fcbef4b455c49aa94f

Correct typo in README

push time in a month

PR opened apple/openjdk

Corrected typo in README

+1 -1

1 commit in kedar-joshi/openjdk/tree/patch-1 apple/openjdk/tree/xcodejdk14-release

0 comment

1 changed file

pr created time in a month

push eventkedar-joshi/openjdk

commit sha ff7c70f00e6fabd63aed7f99f307c55cdefd1a3e

Corrected typo in README

Consider if we should restore support for spring.profiles.include

push time in a month

fork kedar-joshi/openjdk

apple/openjdk kedar-joshi/openjdk

fork in a month

issue commentspring-projects/spring-boot

Do you have any more details that you can share about how you currently use spring.profiles.include, perhaps a few sample config files that you can share ?

Sure.

We use spring.profiles.include primarily in two different ways -

1. Include + Active Profiles

application.properties

# Profile properties
spring.profiles.include = common
spring.profiles.active = ${PRODUCT_A_PROFILES:dev}

# e.g.
# PRODUCT_A_PROFILES = production,production-node-a

# Common application properties
# ...

application-production.properties

# Production environment specific properties
# ...

application-production-node-a.properties

# Node-A specific properties in production environment
# ...

2. (Only) Include Profiles

application.properties

# Profile properties
spring.profiles.include = ${PRODUCT_A_PROFILES:dev}

# e.g.
# PRODUCT_A_PROFILES = production-node-a

# Common application properties
# ...

application-flavor-a.properties

# Profile properties
spring.profiles.include = common

# Product flavor-a specific properties
# ...

application-production.properties

# Profile properties
spring.profiles.include = flavor-a

# Production environment specific properties
# ...

application-production-node-a.properties

# Profile properties
spring.profiles.include = production

# Node-A specific properties in production environment
# ...

Value for PRODUCT_A_PROFILES is provided by target environment.

Each method has its own denefits and challenges. Using spring.profiles.include and spring.profiles.active together considerably simplifies the configuration but it leaves a lot of room for incorrect configuration, during deployment, if there are too many profiles to be activated.

On the other hand, Using spring.profiles.include alone, simplifies deployment configuration at the cost of added complexity for develoeprs.

We choose the method which best suits the product.

philwebb

comment created time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 0d0e62c8b3e8a7169e48f6d9c1738ff98a33f427

Updated Spring Boot to v2.4.0 M2

push time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 5884e5087d62eb93d4577ff3a457f9feb76b2785

Updated Spring Boot to v2.4.0 M2

2.4.0.M2: server.servlet.encoding.force-response causing content-type to include charset.

push time in a month

issue commentspring-projects/spring-boot

but it produces the same behaviour for me with both 2.4.0-M1 and M2 ...

@wilkinsona Thanks for the reply but can you please check with mvn clean test ? I am able to reproduce this consistently.

v2.4.0-M2.txt v2.4.0-M1.txt

kedar-joshi

comment created time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 73f2a25d1b9d4cda4847516d21abfbea2d542b88

Updated Maven war plugin to v3.3.1 Closes gh-173

commit sha 56bfbe59d071d6a12bd152d8f0554ffab777aed3

Updated Spring Boot to v2.4.0 M2

push time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 73f2a25d1b9d4cda4847516d21abfbea2d542b88

Updated Maven war plugin to v3.3.1 Closes gh-173

Update Maven war plugin to v3.3.1

push time in a month

issue closedlocationguru-solutions/web-application-reference

closed time in a month

kedar-joshi

issue openedlocationguru-solutions/web-application-reference

Update Maven war plugin to v3.3.1

created time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 8168d79f6af0c20f127e3dfd87daa8d795321681

Updated Spring Boot to v2.4.0 M2

push time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 12a180a43c65e04a9528e28796650c0d259eb8d9

Updated Spring Boot to v2.4.0 M2

server.servlet.encoding.force-response causing content-type to include charset.

push time in a month

issue openedspring-projects/spring-boot

In v2.4.0-M2, behavior of server.servlet.encoding.force-response property has changed. Setting following properties results in Content-Type response header to include ;charset=UTF-8. Until v2.4.0-M1, content type used to honor produces configuration of @RequestMapping.

server.servlet.encoding.charset = UTF-8
server.servlet.encoding.force-response = true

Result

Response Header	v2.4.0-M1	v2.4.0-M2
Content-Type	application/json	application/json;charset=UTF-8

I couldn't find any reference of this change in release notes, so assuming it's a bug. See sample MCVE : m2-demo.zip

created time in a month

push eventkedar-joshi/spring-boot

commit sha 33b48c8baca20ca368af563a0f89eaff115e7333

Add @Name support to the annotation processor Update the `ConfigurationMetadataAnnotationProcessor` so that `@Name` annotated parameters generate the correct meta-data. Closes gh-22492

dreis2211

commit sha b01fb63de6468bba9d924d17b1fe5b29da895d04

Polish See gh-22524

Stephane Nicoll

commit sha 5800f1596cce0fc4f8e9aedaad4aa515efb68770

Merge pull request #22524 from dreis2211 * pr/22524: Polish Closes gh-22524

commit sha 36a6ca6e6e63d16c3b5cfc163071d4bdaf14ea1f

Add EnvironmentPostProcessorsFactory Update `EnvironmentPostProcessorApplicationListener` so that it can either use values from `spring.factories` or use a factory interface. Closes gh-22529

commit sha db242794ecfbf00883963ece4217a477830627b4

Upgrade to Micrometer 1.1.16 Closes gh-22536

commit sha 698db27a7566f4946265fafb557ae68c6f748c46

Upgrade to Aspectj 1.9.6 Closes gh-22537

commit sha ce803cc6788e86add190ed3a3e245a0d9687bcf0

Upgrade to Micrometer 1.3.11 Closes gh-22538

commit sha f93bae4bd35406a7625f227f31fd26fe6fd52e22

Upgrade to Aspectj 1.9.6 Closes gh-22539

commit sha 2118c739857d041166a159c32e8e9a4ccb5e4f91

Merge branch '2.1.x' into 2.2.x

commit sha 1cc941f9c3d45b2433ac35c2a88cb67404a938c5

Merge branch '2.2.x' into 2.3.x

commit sha 44e6cf2e55a291f692b7fb98f00defbd886699c2

Upgrade to AspectJ 1.9.6 Closes gh-22540

commit sha 39c8898008dafadd42c2e4c296e2ef1141e97bca

Upgrade to MariaDB 2.6.2 Closes gh-22541

commit sha 8218e5b5489c4f3d34a3515d6da52491e697af50

Merge branch '2.3.x'

commit sha 9c5e59371fe1088b5b346f72a126d7b9ac662530

Upgrade to Jackson 2.10.5 Closes gh-22432

commit sha 3480db72a5ed18ec834dbb3a8e56c142b043a47d

Merge branch '2.2.x' into 2.3.x

commit sha 2ffb41a2de848c5f1122a48e89a96af9a3bf0b7d

Merge branch '2.3.x'

Spring Buildmaster

commit sha 7ac5cc96c2a6969c2131074d0d4ba1770cab23cd

Next development version (v2.1.17.BUILD-SNAPSHOT)

commit sha c043701dc0efc2b027ff35fef748e1af2645e751

Turn on debug logging

commit sha 53296cd16109dc53de867c4cb12b10cecf47bb78

Backport build script updates

commit sha d69c35a1db2faf4bd534b70c19ea017205e28e59

Deal with 404 response when checking for artifacts

push time in a month

push eventkedar-joshi/spring-framework

Brian Clozel

commit sha 92cdf526fbd30f865f6451d36663bf63377013d3

Upgrade CI images to ubuntu:bionic-20200630

Brian Clozel

commit sha d9ccd618ea9cbf339eb5639d24d5a5fabe8157b5

Deprecate remoting technologies support Because of security and broader industry support, support for several remoting technologies is now deprecated and scheduled for removal in Spring Framework 6.0. This commit deprecates the following remoting technologies: * HTTPInvoker * RMI * Hessian * JMS remoting Other remoting technologies like EJB or JAXWS might be deprecated in the future depending on industry support. Closes gh-25379

commit sha b769b73960c904269ea7873cfa5a82c00e28a6a8

Improve JavaDoc for ConfigurableApplicationContext.refresh() Closes gh-25380

commit sha 54d9dfa84f2724f0cfe0af7e1f28b1c0317dfd01

Merge branch '5.2.x'

commit sha abe16eeb6e7ba49e1cf042cf15d7cf3af3301c2b

Use test name as thread name prefix in scheduling TaskExecutor tests This commit also deletes a duplicate copy of the assertThreadNamePrefix() method.

May

commit sha 490bdd11a562b665f1b8695d4b8f61f6bb7949a1

Use Math.min() in ExponentialBackOff Use Math.min() instead of doing it manually in ExponentialBackOff. Closes gh-25381

commit sha 1dec4f3d0f28c19708727d09931bddb90348d41b

DefaultServerRequest parses the path if necessary Closes gh-25353

commit sha 03fa48919e2ec3a3fcff0372081df0ea64fc1a92

Switch to Reactor Dysprosium snapshots See gh-25376

commit sha b54853484e6f77a659aa416bc93e106d6f246790

Merge branch '5.2.x'

commit sha e4a3c1570dafb835d072664895c47a2d63dbbfdc

Upgrade to RSocket 1.1.0 snapshots See gh-25331

commit sha 7c982511426eebea3d34730ab128bb39a55a9de6

Support for making requests via RSocketClient Closes gh-25332

commit sha fcf20bab2ad1ce4c335927c0f99ac7accdc9d7b3

Delete duplicate code block in WebHttpHandlerBuilder.applicationContext() This commit deletes a duplicated code block that was accidentally introduced in a8a1fc6de5be2307eb56844ac1df1a09168f2ad9. Closes gh-25389

commit sha 4578e49213c42ec32c99613e6c616ed90ca456fb

Merge branch '5.2.x'

Yanming Zhou

commit sha d2e1150c7999b347d159ffc8247b123a406bf382

Fix typo in javadoc for @RequestMapping Closes gh-25396

Martin Knopf

commit sha 35c0ae7b0c304599b26769378873856e398d0d38

Allow auto grow for entries w/o default constructor in SpEL Prior to this commit, The "auto grow" feature in SpEL expressions only worked for element types with a default constructor. For example, auto grow did not work for a list of BigDecimal elements. This commit inserts a null value in the list when no default constructor can be found for the element type. Closes gh-25367

commit sha b0570cd3a65d73ccf29558fa994975260a8651d3

Polish contribution See gh-25367

Tomas Drabek

commit sha 524ca1a6767a8912e1a4c58c797e5099794b442b

DefaultSubscriptionRegistry: Reduced thread contention * DestinationCache is now synchronized on multiple 'destination' locks (previously a single shared lock) * DestinationCache keeps destinations without any subscriptions (previously such destinations were recomputed over and over) * SessionSubscriptionRegistry is now a 'sessionId -> subscriptionId -> (destination,selector)' map for faster lookups (previously 'sessionId -> destination -> set of (subscriptionId,selector)') closes gh-24395

commit sha 44f1f94f9785f86dbd40fd49012aab42261739aa

Polishing contribution Renaming, trimming of method parameters, minor refactoring of helper methods, comments, etc. Completely functionally neutral. See gh-25298

commit sha b451379c2f6da834a24d230bc9f1355660da3e7c

Update eviction queue before size See gh-25298

commit sha 111899aa63e3c90c4023b5f98969281282536ac9

Add @Nullable declaration to getDefaultConstructor() See gh-25367

Consider if we should restore support for spring.profiles.include

push time in a month

issue commentspring-projects/spring-boot

Oh yes, please. spring.profiles.include is (was 😢) an important aspect of how we organize common configuration properties for all of our products. As the description goes, Unconditionally activate the specified comma-separated list of profiles is an important feature to have in order to avoid repeating common profile names everywhere.

Personally, I would prefer spring.profiles.include any time over spring.profiles.group.

(For experience sake) I migrated one of our production apps to Spring Boot v2.4.0-M2 and now suddenly I need to maintain configuration groups for all of our environments in application.properties which we used to manage with environmental variables.

Using multiple discrete profiles might make your code easier to reason about, but it’s not ideal for deployment. You don’t want to force users to remember that they must always activate proddb, prodmq, prodmetrics etc. at the same time. Instead, you just want them to be able to activate a single prod profile. Groups allow you to do just that.

I (somewhat) get this rationale but I (humbly) propose to make it an on-demand feature instead of enabling it by default (spring.profiles.include being the default).

P.S. I know I have an option to go back to the old behavior and this is based on my own observations so I may be alone to this way (but since this is brought to teams attention, I hope I am not alone)

philwebb

comment created time in a month

push eventlocationguru-solutions/web-application-reference

commit sha 8a070e5cb080a56dc1437f43367c91842ef3338c

wip

push time in a month

push eventlocationguru-solutions/web-application-reference