profile
viewpoint
Alan Plum pluma Senior Consultant at @foss-haas Rheda-Wiedenbrück, Germany Building ole-scout.app, maintainer at @arangodb & @arangodb-foxx, web dev, ❤️ React & TypeScript. Inquiries to my firstname at foss-haas dot de

DefinitelyTyped/DefinitelyTyped 30575

The repository for high quality TypeScript type definitions.

pluma/fynx 285

UNMAINTAINED. Formerly known as Flox.

arangodb/arangodb-docker 81

Docker container for ArangoDB

arangodb-foxx/demo-graphql 38

Example Foxx Service using GraphQL

arangodb/foxx-cli 35

CLI for managing Foxx services.

pluma/httperr 24

HTTP status codes as JavaScript errors.

arangodb-foxx/fine-grained-permissions 8

Foxx Fine Grained Permissions tutorial

pluma/axn 8

Listenable actions.

pluma/joi-react 8

UNMAINTAINED. React proptype wrapper for joi validation.

arangodb/docs 7

Source code of the ArangoDB online documentation

issue commentfacebook/create-react-app

Apps with `react-scripts` v4.0.0 do not work in IE11

My polyfills look like this and I have no problem with IE11:

import "react-app-polyfill/ie11";
import "react-app-polyfill/stable";

Note that these must come above any other imports that would break without these polyfills in place. Plus the polyfill doesn't provide some more esoteric APIs like TextEncoder so you'll still need to load polyfills for those if you need them for some reason.

yhnavein

comment created time in a day

issue commentsindresorhus/open

Alternative URL opener on WSL - wslview

Wait a second. What do you mean by "preinstalled in new WSL apps" and where did you get that info?

It's definitely not included in my WSL2 Ubuntu, which caused this to break for me. I had to install wslu from a third-party package registry because it was not on the official Ubuntu package registry either.

tiagonapoli

comment created time in 5 days

issue commentfacebook/create-react-app

Cannot compile TypeScript app created with CRA because of parsing errors

Okay, scratch that. After comparing the output of a fresh yarn create react-app with my existing package.json it seems that the file now contains the following section:

  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },

This was missing in the app I upgraded. Presumably this was added to the generator output at some point in the past but inferred if missing and that logic got canned at some point in the 4.0.0 pre-releases, breaking old apps that were missing this bit.

Adding this to my package.json fixed the problem, monorepo or not.

philiparvidsson

comment created time in 5 days

issue commentfacebook/create-react-app

Cannot compile TypeScript app created with CRA because of parsing errors

I'm having the same problem and have been having it since once of the pre-releases. I've gathered that it may be an issue with typescript-eslint but it's making me pull my hair out because CRA doesn't tell me what exactly fails (i.e. no stack trace or even "this is eslint complaining") other than pointing out those nonsense parsing errors on almost every TS and TSX file. I suspect this may have something to do with this being in a monorepo.

philiparvidsson

comment created time in 5 days

startedHopding/pdf-lib

started time in 9 days

PullRequestReviewEvent

delete branch arangodb/resilience-tests

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 9 days

push eventarangodb/resilience-tests

dependabot[bot]

commit sha 6baefe741d90914d7f59b7d54163ab162e659ecf

Bump lodash from 4.17.13 to 4.17.19 (#28) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.13 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.13...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 9 days

PR merged arangodb/resilience-tests

Bump lodash from 4.17.13 to 4.17.19 dependencies

Bumps lodash from 4.17.13 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.13...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+26 -11

0 comment

2 changed files

dependabot[bot]

pr closed time in 9 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 function firstRouting (type, parts, routes, rawParts) {  function routeRequest (req, res, routes) {   if (routes === undefined) {-    var dbname = arangodb.db._name();+    let internalRoute = req.url.match(/^\/_(admin|api)\//);++    const dbname = arangodb.db._name();+    if (internalRoute) {+      // internal route, i.e. /_admin, /_api, etc.+      if (!InternalRoutingList[dbname]) {+        // Do not join these two lines. If so there is a chance+        // the RoutingList will contain undefined afterwards.+        // i have not found out why this is the case.+        const r = buildRouting(dbname, true);+        InternalRoutingList[dbname] = r;+      }+      routes = InternalRoutingList[dbname];+    } else {+      // user-defined, i.e. custom Foxx route+      if (!CustomRoutingList[dbname]) {+        if (global.KEYSPACE_EXISTS('FoxxFirstSelfHeal')) {+          // still waiting for initial selfHeal to execute+          throw new internal.ArangoError({+            errorNum: internal.errors.ERROR_HTTP_SERVICE_UNAVAILABLE.code,+            errorMessage: "waiting for initialization of Foxx services in this database"+          });

I'm not sure if this would work better if it used resultException directly (see line 1937, but followed by a return to bail out). Unhandled exceptions like this are intercepted in js/actions/api-system.js line 53 and wrapped in a generic 500, which is why we're seeing 500 instead of 503.

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 function ensureServiceLoaded (mount) { }  function getServiceInstance (mount) {-  ensureFoxxInitialized();-  const localServiceMap = GLOBAL_SERVICE_MAP.get(db._name());+  let internalOnly = SYSTEM_SERVICE_MOUNTS.indexOf(mount) !== -1;

See above (let/const).

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 exports.manage = function () {         return;       } -      var queues = db._collection('_queues');-      var jobs = db._collection('_jobs');+      let queues = db._collection('_queues');+      let jobs = db._collection('_jobs');

See above (let/const).

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

   const errors = require('@arangodb').errors;    // autoload all modules and reload routing information in all threads-  internal.loadStartup('server/bootstrap/autoload.js').startup();-  internal.loadStartup('server/bootstrap/routing.js').startup();+  // autoload all modules

Duplicate comment?

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 const coordinatorId = (   : undefined ); +let ensureDefaultQueue = function () {+  if (!global.KEY_GET('queue-control', 'default-queue')) {+    try {+      let queues = require('@arangodb/foxx/queues');

We usually prefer const over let when the variable doesn't get reassigned.

jsteemann

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentarangodb/arangodb

now escaping the result of a foxx services setup script

             } else if (result) {               info = (                 '<p>Script results:</p>' +-                '<pre>' + JSON.stringify(result, null, 2) + '</pre>'+                '<pre>' + arangoHelper.escapeHtml(result) + '</pre>'

Note that moving the JSON.stringify into escapeHtml will result in string results being displayed differently than before:

Previously:

# script output
module.export = "success"

# generated html
<pre>"success"</pre>

Now:

# script output
module.export = "success"

# generated html
<pre>success</pre>

This results in some ambiguity if the string output looks like JSON, e.g.

module.exports = "[]"

# now looks the same as

module.exports = []
hkernbach

comment created time in 10 days

PullRequestReviewEvent

startedbunkerity/bunkerized-nginx

started time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

+/*jshint globalstrict:false, strict:false */+/* global getOptions, assertTrue, assertEqual, arango */++////////////////////////////////////////////////////////////////////////////////+/// @brief test for security-related server options+///+/// @file+///+/// DISCLAIMER+///+/// Copyright 2010-2012 triagens GmbH, Cologne, Germany+///+/// Licensed under the Apache License, Version 2.0 (the "License");+/// you may not use this file except in compliance with the License.+/// You may obtain a copy of the License at+///+///     http://www.apache.org/licenses/LICENSE-2.0+///+/// Unless required by applicable law or agreed to in writing, software+/// distributed under the License is distributed on an "AS IS" BASIS,+/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+/// See the License for the specific language governing permissions and+/// limitations under the License.+///+/// Copyright holder is ArangoDB Inc, Cologne, Germany+///+/// @author Jan Steemann+/// @author Copyright 2019, ArangoDB Inc, Cologne, Germany+////////////////////////////////////////////////////////////////////////////////++let jsunity = require('jsunity');+const _ = require('lodash');+const pu = require('@arangodb/process-utils');+const crypto = require('@arangodb/crypto');+const request = require("@arangodb/request");+const suspendExternal = require("internal").suspendExternal;+const continueExternal = require("internal").continueExternal;+const time = require("internal").time;+const path = require('path');+const FoxxManager = require('@arangodb/foxx/manager');+const basePath = path.resolve(require("internal").pathForTesting('common'), 'test-data', 'apps', 'perdb1');++function testSuite() {+  const jwtSecret = 'haxxmann';++  let getServers = function (role) {+    return global.instanceInfo.arangods.filter((instance) => instance.role === role);+  };++  let waitForAlive = function (timeout, baseurl, data) {+    let tries = 0, res;+    let all = Object.assign(data || {}, { method: "get", timeout: 1, url: baseurl + "/_api/version" }); +    const end = time() + timeout;+    while (time() < end) {+      res = request(all);+      if (res.status === 200 || res.status === 401 || res.status === 403) {+        break;+      }+      console.warn("waiting for server response from url " + baseurl);+      require('internal').sleep(0.5);+    }+    return res.status;+  };++  let checkAvailability = function (servers, expectedCode) {+    require("console").warn("checking (un)availability of " + servers.map((s) => s.url).join(", "));+    servers.forEach(function(server) {+      let res = request({ method: "get", url: server.url + "/_api/version", timeout: 3 });+      assertEqual(expectedCode, res.status);+    });+  };++  let suspend = function (servers) {+    require("console").warn("suspending servers with pid " + servers.map((s) => s.pid).join(", "));+    servers.forEach(function(server) {+      assertTrue(suspendExternal(server.pid));+      server.suspended = true;+    });+    require("console").warn("successfully suspended servers with pid " + servers.map((s) => s.pid).join(", "));+  };+  +  let resume = function (servers) {+    require("console").warn("resuming servers with pid " + servers.map((s) => s.pid).join(", "));+    servers.forEach(function(server) {+      assertTrue(continueExternal(server.pid));+      delete server.suspended;+    });+    require("console").warn("successfully resumed servers with pid " + servers.map((s) => s.pid).join(", "));+  };+      +  const mount = '/test';++  return {+    setUp : function() {+      // make sure self heal has run+      arango.POST(`/_admin/execute`, "require('@arangodb/foxx/manager').healAll(); return 1");+    },++    /*+      install A Foxx App.+      Suspend DBServers+      Request Foxx on this Coordinator => Service Unavailable.+      Unsuspend DBServers+      Retry accessing Foxx => Eventually the service will get available.

This doesn't actually get tested

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 function firstRouting (type, parts, routes, rawParts) {  function routeRequest (req, res, routes) {   if (routes === undefined) {-    var dbname = arangodb.db._name();+    let internalRoute = false;+    // systemServiceMounts contains the internal mount points, i.e.+    // /_admin/aardvark and /_api/foxx+    for (let mount of FoxxManager.systemServiceMounts) {

this loop is redundant because all internal apps live in the prefixes we explicitly check below

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 void DatabaseManagerThread::run() {            TRI_ASSERT(!database->isSystem()); -          // remove apps directory for database-          auto appPath = dealer.appPath();--          if (database->isOwnAppsDirectory() && !appPath.empty()) {-            std::string path = arangodb::basics::FileUtils::buildFilename(-                arangodb::basics::FileUtils::buildFilename(appPath, "_db"),-                database->name());--            if (TRI_IsDirectory(path.c_str())) {-              LOG_TOPIC("041b1", TRACE, arangodb::Logger::FIXME)-                  << "removing app directory '" << path << "' of database '"-                  << database->name() << "'";--              TRI_RemoveDirectory(path.c_str());+          {+            // remove apps directory for database

Maybe truncate existing dirs when db is created?

jsteemann

comment created time in 10 days

Pull request review commentarangodb/arangodb

improve JavaScript behavior at coordinator startup

 v3.6.9 (XXXX-XX-XX) ------------------- +* Added startup option `--foxx.force-update-on-startup` to toggle waiting +  for all Foxx services in all databases to be propagated to a coordinator +  before it completes the boot sequence. +  In case the option is set to `false` (i.e. no waiting), the coordinator +  will complete the boot sequence faster, and the Foxx services will be +  propagated lazily. Until the initialization procedure has completed for+  the local Foxx apps, any request to a Foxx app will be responded to with+  an HTTP 500 error and message 

This should probably be 503 (unavailable)?

jsteemann

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

startedyeojz/otplib

started time in 12 days

startedNetflix/pollyjs

started time in 14 days

startedoblador/loki

started time in 15 days

startedgarris/BackstopJS

started time in 15 days

release arangodb/arangojs

v7.1.0

released time in 15 days

created tagarangodb/arangojs

tagv7.1.0

The official ArangoDB JavaScript driver.

created time in 15 days

push eventarangodb/arangojs

Alan Plum

commit sha a4a4c47df05904a0454acdbd3fee2d77894221d2

Drain cursors when killed

view details

Alan Plum

commit sha 41d5f930c1b52092e96831ea124fe0bf5b2d3fcb

7.1.0

view details

push time in 15 days

pull request commentfacebook/create-react-app

Use new JSX transform with React 17

@ho88 language.

iansu

comment created time in 15 days

startedkentcdodds/testing-node-apps

started time in 16 days

pull request commentDefinitelyTyped/DefinitelyTyped

[koa] Fix response.set with object

Ready to merge.

Thanks @harryparkdotio.

pluma

comment created time in 18 days

push eventpluma/DefinitelyTyped

Alan Plum

commit sha 81f2da6a508863706c4405b1b021246a74161537

Add test

view details

push time in 19 days

PR opened DefinitelyTyped/DefinitelyTyped

[koa] Fix response.set with object

When used with an object it just invokes the same method using the key/value pair as arguments so there's no reason not to allow a string array in both cases.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/koajs/koa/blob/master/lib/response.js#L459-L471
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+1 -1

0 comment

1 changed file

pr created time in 19 days

push eventpluma/DefinitelyTyped

Alan Plum

commit sha 8982fc65ad0a6216480c948f5b33cf426e84dfa1

[koa] Fix response.set with object When used with an object it just invokes the same method using the key/value pair as arguments so there's no reason not to allow a string array in both cases.

view details

push time in 19 days

Pull request review commentfastify/fastify

Added custom error formatting for schema errors

 export interface FastifyRouteSchemaDef {   httpStatus?: string; } +export interface FastifyValidationResult {+  errors?: FastifySchemaValidationError[];+}++export interface FastifySchemaValidationError {+  message: string;+  dataPath: string;+}+ /**  * Compiler for FastifySchema Type  */-export type FastifySchemaCompiler = (routeSchema: FastifyRouteSchemaDef) => unknown+export type FastifySchemaCompiler = (routeSchema: FastifyRouteSchemaDef) => FastifyValidationResult

Is this a bug? It looks like this should be like this instead:

export type FastifySchemaCompiler = (routeSchema: FastifyRouteSchemaDef) => (data: unknown) => FastifyValidationResult

As it is now, the signature suggest the validation result is directly derived from the schema by the compiler but actually the compiler returns a function that takes the data as input to generate the validation result instead.

Arnovsky

comment created time in 21 days

PullRequestReviewEvent
IssuesEvent

issue commentarangodb/arangojs

Special characters are not decoding properly

@jsteemann This sounds familiar. I remember an early 3.x issue with fields named _key being handled differently. Is it possible there's a bug when documents have nested fields named _id and this interferes with character encoding?

/cc @joerg84

sudhish-ps

comment created time in 23 days

issue closedarangodb/arangojs

I am getting connection reset error when trying execute two queries at the same time?

Hello All,

I am using arangojs v6.14.1 and arangodb version 3.6.4.

I have nodejs express app which intended to serve client requests.

I am experiencing an issue while executing concurrent requests. The database connection hangup when I concurrently process client requests:

What the app will do when it receives a request?

  • Open a database connection - db = new Database(dbConfig.url); db.useDatabase(dbConfig.name); db.useBasicAuth(dbConfig.username, dbConfig.password);

There are multiple middleware functions that need to access to perform various functions and accessibility checks. And for each middleware I tried to

  • open a new database connection ->
  • perform the action ->
  • close the connection ->
  • return the result to next middleware.

This works fine with single request at a time. But if I tried to call two APIs at same time, I am getting CONNECTIONRESET error. And also throwing socket hangup error.

I tried to commend out the close connection method and it started working fine for a while. But when I increased the number of connections, it again showing the same error as "CONNECTIONRESET".

I have searched the documentation of arangojs regarding the connection manipulation. But I havent found any information regarding the same.

I hope to get some help from the community here.

Any help would be deeply appreciated.

Thanks Syam

closed time in 23 days

syam0000x

issue commentfox1t/fastify-multer

FastifyRequest is missing the fields attribute in TS

One thing I noticed is that types in package.json is normally supposed to point at a file but in this case it points at the lib folder (and the fastify type overrides are outside that folder). I'm guessing it might simply infer the location of the types for the index.js and resolve the types via imports from there but as the fastify overrides are not imported by anything they have no effect.

benediktdertinger

comment created time in 24 days

pull request commentDefinitelyTyped/DefinitelyTyped

update project link of expressjs/cors

No worries. I don't mind having other people share ownership of DT typings I've contributed. I usually create these when I run into missing typings in development, so I have no personal stake in them either way.

You're doing great.

gtpan77

comment created time in 24 days

pull request commentDefinitelyTyped/DefinitelyTyped

update project link of expressjs/cors

Yeah, that's why I've approved it. "lgtm" means "looks good to me" and is generally used to indicate approval.

For what it's worth, adding yourself as a definition author for fixing a URL in he metadata seems a bit excessive but I don't mind, just remember that this means you will likely get tagged by the bot in future pull requests for these typings just like I did.

If this is a hacktober contribution, enjoy your shirt I guess?

gtpan77

comment created time in 24 days

PullRequestReviewEvent

push eventarangodb/arangojs

Alan Plum

commit sha a993de1afb3a39824870990c5f1ee9248a4fb3a6

Fix potential memory leak

view details

push time in 25 days

issue commentarangodb/arangojs

Special characters are not decoding properly

Interesting. Does this only affect fields named _id or does it also affect name in this example?

sudhish-ps

comment created time in 25 days

issue commentarangodb/arangojs

I am getting connection reset error when trying execute two queries at the same time?

You shouldn't generally need to use .close unless you want to discard the arangojs driver instance (e.g. if you're just using arangojs once in a long-running script). Arangojs communicates over HTTP, which means it merely uses keep-alive to keep the HTTP sockets open a little longer after the response has been received in case it needs to perform another request.

Generally speaking, the expected workflow is

  1. Create your db instance (with auth, db, etc)
  2. Eventually perform your request
  3. Handle the response
  4. There is no step 4
syam0000x

comment created time in 25 days

issue commentarangodb/arangojs

Add a favicon to the docs?

The docs are generated via Jekyll using GitHub pages. I haven't found a way to use favicons with those. If you can find something that works, feel free to create a PR to the gh-pages branch.

ArtskydJ

comment created time in 25 days

issue commentarangodb/arangodb

Implement `URL`/`URLSearchParams` in JS

It's a bit more complicated than anticipated. The whatwg-url implementation depends on TextEncoder and TextDecoder being defined in node's util module, which we do not currently implement in ArangoDB.

pluma

comment created time in a month

issue commentjoowani/python-arango

foxx client does not support binary upload formats to foxx REST API

@joowani The docs state that all three values are "fields" (i.e. regular text fields) and then says that "source" can alternatively be a "file field". In the context of multipart these are the only two types that can be represented.

See my comment on the ArangoDB issue https://github.com/arangodb/arangodb/issues/11045#issuecomment-701381388 for an example of how the payload should look. As multipart/form-data was originally created for HTML forms, it helps to imagine how this would look in a form:

<textarea name="configuration">json goes here</textarea>
<textarea name="depenencies">json goes here</textarea>
<input type="file" name="source">

I've looked into the implementation of MultipartEncoder and it seems to delegate the actual field handling to urllib3 but it looks like it allows for two input types:

  1. A plain string (confusingly named file_pointer but urllib3 makes it clear this is actually a string instead).
  2. A tuple of a string (internally called file_name) and 1-3 additional values (internally named file_pointer, file_type and file_headers).

In the former case a simple text field is added to the form. In the latter a file field will be added. I didn't dig deep enough to find out what passing a Dict will do but it's clearly not defined (nor documented) behavior. So there really would only be two ways to represent the JSON config in a multipart form: as a regular field (i.e. converted to a string) or as a file field (i.e. as a binary blob or file pointer with a file name, file type and optionally additional headers).

ex-nerd

comment created time in a month

issue closedarangodb/arangodb

Error: Signature verification failed! should return 403 instead of 500

my environment running ArangoDB

I'm using the latest ArangoDB of the respective release series:

  • [ ] 2.8
  • [ ] 3.0
  • [ ] 3.1
  • [ ] 3.2
  • [X] 3.3
  • [ ] self-compiled devel branch

Mode:

  • [ ] Cluster
  • [X] Single-Server

Storage-Engine:

  • [ ] mmfiles
  • [X] rocksdb

On this operating system:

  • [ ] DCOS on
    • [ ] AWS
    • [ ] Azure
    • [ ] own infrastructure
  • [ ] Linux
    • [ ] Debian .deb
    • [ ] Ubuntu .deb
    • [ ] SUSE .rpm
    • [ ] RedHat .rpm
    • [ ] Fedora .rpm
    • [ ] Gentoo
    • [ ] docker - official docker library
    • [ ] other:
  • [ ] Windows, version:
  • [X] MacOS, version:

this is an AQL-related issue:

[ ] I'm using graph features

I'm issuing AQL via:

  • [ ] web interface with this browser: running on this OS:
  • [ ] arangosh
  • [ ] this Driver:

I've run db._explain("<my aql query>") and it didn't shed more light on this. The AQL query in question is:

The issue can be reproduced using this dataset:

Please provide a way to create the dataset to run the above query on; either by a gist with an arangodump, or `db.collection.save({my: "values"}) statements. If it can be reproduced with one of the ArangoDB example datasets, it's a plus.

Foxx

When loading a Foxx service with wrong JWT token, it raise a 500 error instead of a 403 By example : Service "/auth" encountered error 500 while handling GET http://localhost:8529/_db/cms_bw/auth/whoami via Error: Signature verification failed!

closed time in a month

solisoft

issue commentarangodb/arangodb

Error: Signature verification failed! should return 403 instead of 500

Status 500 generally indicates an uncaught exception. As I understand this issue is about using crypto.decodeJwt in your own Foxx service to handle application level client authentication. In this case you should handle the exception and react accordingly (e.g. by sending your own 403 response).

The API in question doesn't know anything about Foxx or responses and requests. We could use an ArangoError here but we don't for any of the related APIs and even so it wouldn't be clear this should use a 403 HTTP code given there's no way to tell how the API was used or for what purpose.

solisoft

comment created time in a month

push eventarangodb/arangodb

Jan

commit sha 75b4b59777ab552e76d30c253386262151b1369c

take a copy before moving from the same object (#12720)

view details

Jan

commit sha 5bdcaf72dc291189dd00f18ad532f5d494eed13c

fix "hash" property in /_admin/status?overview=true case (#12723)

view details

Wilfried Goesgens

commit sha 37d99de709a96ef241e77c31790a5921542f98c3

Feature/coronabytes timezone (#12669)

view details

Heiko

commit sha c1e6c5fd574a3121c438fd487ce1c5213111545f

disabled range-loop-analysis for clang version 12.0.0 up to 12.1.0 (#12732) * disabled range-loop-analysis for clang version 12.0.0 up to 12.1.0 * Update CMakeLists.txt Co-authored-by: Tobias Gödderz <tobias@arangodb.com> * DARWIN instead of APPLE Co-authored-by: Tobias Gödderz <tobias@arangodb.com>

view details

Simon

commit sha fec244443a585bc162b5fab56de77b0b7617a3ee

fix assertion (#12726)

view details

jsteemann

commit sha 17766a56eb8a677c19db12540c25eb85b443df05

commit auto-generated files that are always marked as locally modified

view details

Jan

commit sha ad769286d4489bd96743fe17865a2da03ab2f35b

forward port of #12741 (#12742)

view details

Andrey Abramov

commit sha 504afb1b0329fa8d8e24a8ebd4901e740c53af6f

ensure arangosearch maintenance thread doesn't sleep infinitely in presence of tasks (#12736)

view details

Vadim

commit sha c804fce31407a1427a2a8d873d34cc12db049901

Update CHANGELOG

view details

Tobias Gödderz

commit sha a8ef4b5db3a32cec756d298a91d732ad7b8e1d5e

Fix LIMIT with COLLECT WITH COUNT INTO (#12719) * Added regression tests * Fixed LIMIT to work as expected with a later COLLECT WITH COUNT INTO * Changed the LIMIT/LIMIT+fullCount behaviour to work as before, instead of throwing an exception * Added another test for LIMIT/LIMIT+fullCount behaviour * Updated CHANGELOG Co-authored-by: Michael Hackstein <michael@arangodb.com>

view details

Alan Plum

commit sha 8e4af46d1d8a8b750dadbcd60f67c969dbd785de

Merge branch 'devel' into bug-fix/issue-12543

view details

push time in a month

Pull request review commentarangodb/arangodb

now escaping the result of a foxx services setup script

             } else if (result) {               info = (                 '<p>Script results:</p>' +-                '<pre>' + JSON.stringify(result, null, 2) + '</pre>'+                '<pre>' + JSON.stringify(arangoHelper.escapeHtml(result), null, 2) + '</pre>'

Looks like arangoHelper.escapeHtml actually doesn't even coerce its argument to a string, it just assumes it's a string and will blow up if it's not something with a replace method as all it does is call str.replace(/&/g, "&#38;").replace(/"/g, "&#34;").replace(/'/g, "&#39;").replace(/</g, "&#60;") on its argument.

hkernbach

comment created time in a month

PullRequestReviewEvent

Pull request review commentarangodb/arangodb

now escaping the result of a foxx services setup script

             } else if (result) {               info = (                 '<p>Script results:</p>' +-                '<pre>' + JSON.stringify(result, null, 2) + '</pre>'+                '<pre>' + JSON.stringify(arangoHelper.escapeHtml(result), null, 2) + '</pre>'

What is the purpose of JSON.stringify here? I assumed it's so we can represent whatever arbitrary data the script returns, which might be a JSON object (i.e. whatever you assigned to module.exports in the script).

In that case running arangoHelper.escapeHtml on it would coerce it to a string, try to escape any HTML in that string and then pass the resulting escaped string to JSON.stringify which would generate a JSON string representation of that string, which is then inserted into the HTML.

The previous behavior would have been to pass the arbitrary data to JSON.stringify, which would generate a JSON string representation, which is then inserted into the HTML.

As I understand it the new could would always output "[object Object]" if the script returns an object instead of a string. Do I misunderstand what the code is doing?

hkernbach

comment created time in a month

PullRequestReviewEvent

Pull request review commentarangodb/arangodb

now escaping the result of a foxx services setup script

             } else if (result) {               info = (                 '<p>Script results:</p>' +-                '<pre>' + JSON.stringify(result, null, 2) + '</pre>'+                '<pre>' + JSON.stringify(arangoHelper.escapeHtml(result), null, 2) + '</pre>'

i.e. it should also escape {"xss": "<script>alert('hi')</script>"} correctly but to me it looks like this would result in that being converted to "[object Object]" (assuming arangoHelper.escapeHtml expects a string).

hkernbach

comment created time in a month

PullRequestReviewEvent

Pull request review commentarangodb/arangodb

now escaping the result of a foxx services setup script

             } else if (result) {               info = (                 '<p>Script results:</p>' +-                '<pre>' + JSON.stringify(result, null, 2) + '</pre>'+                '<pre>' + JSON.stringify(arangoHelper.escapeHtml(result), null, 2) + '</pre>'

Shouldn't this be arangoHelper.escapeHtml(JSON.stringify(result), null, 2)?

hkernbach

comment created time in a month

PullRequestReviewEvent

issue commentarangodb/arangodb

arangod process hangs when running too many unit tests

Can you clarify if this issue is still present in 3.7?

ilearnio

comment created time in a month

issue closedarangodb/arangodb

Optimize parsing of non-zip Foxx bundle files during deploy

my environment running ArangoDB

I'm using the latest ArangoDB of the respective release series:

  • [x] 3.2

Foxx

When deploying a Foxx service from a non-zip file it is treated as JS. If it isn't JS the parse error should be catched and a error with a helpful error code/ message should be thrown.

closed time in a month

mvollmary

issue commentarangodb/arangodb

Optimize parsing of non-zip Foxx bundle files during deploy

This seems to no longer be an issue. If the file is not a zip file nor a well-formed JS file, it will abort installation.

mvollmary

comment created time in a month

issue closedarangodb/arangodb

[3.7] Unable to access FOXX's built-in graphiql Interface

My Environment

  • ArangoDB Version: 3.7.2
  • Storage Engine: RocksDB
  • Deployment Mode: Single Server
  • Deployment Strategy: Manual Start in Docker
  • Configuration: Nothing in particular
  • Infrastructure: Own
  • Operating System: MacOS 10.15.3
  • Total RAM in your machine: 8
  • Disks in use: SSD
  • Used Package: Docker - official Docker library

Component, Query & Data

Affected feature: Foxx - GraphiQL interface

Steps to reproduce

  1. Create an ArangoDB 3.7 instance
  2. Deploy a FOXX service (The demo https://github.com/arangodb-foxx/demo-graphql for example)
  3. Try to access the graphiql interface

Problem:

I was experimenting with the FOXX services on ADB 3.6.6, and decided to try ADB 3.7.2. On the 3.6.6 version, I could access a built-in graphiql interface at localhost:8529/_db/<DATABASE>/<MOUNT_POINT>, or through the FOXX service interface with the "Show Interface" button. Now, on the 3.7.* versions, this endpoint is unaccessible and the button stays grey at all time.

Did something change regarding the build-in graphiql interface with the 3.7 release ?

closed time in a month

Supytalp

issue commentarangodb/arangodb

[3.7] Unable to access FOXX's built-in graphiql Interface

I'm closing this as duplicate since the problem goes away when the accept header is present and the other issue is specifically about the accept header having vanished in 3.7.

Supytalp

comment created time in a month

issue commentarangodb/arangodb

[3.7] Unable to access FOXX's built-in graphiql Interface

Root cause seems to be #12734.

Supytalp

comment created time in a month

issue closedarangodb/arangodb

Is there a way can config editor to support @arangodb module?

my environment running ArangoDB

I'm using the latest ArangoDB of the respective release series:

  • [x] 3.3

Foxx

For now when we write foxx, use the require('@arangodb') but can not get any IntelliSense provided by many nowadays editors like when we use other npm modules. I have to check the manual again & again to see what methods are this module provide. Wished there is a better experience to write foxx services.

closed time in a month

dsonet

issue commentarangodb/arangodb

Is there a way can config editor to support @arangodb module?

I'm closing this as answered for now since it's been over two years since the question was asked but feel free to reopen this issue if you need additional information or would like to expand your question.

dsonet

comment created time in a month

issue commentarangodb/arangodb

Is there a way can config editor to support @arangodb module?

If your editor supports TypeScript, you can add @types/arangodb to your node modules, which defines TypeScript interfaces for the most common ArangoDB modules when working with Foxx.

dsonet

comment created time in a month

issue commentarangodb/arangodb

Is it possible to analyst foxx services as well as AQL with SonarQube?

SonarQube seems to be a code quality tool? https://www.sonarqube.org/

In that case the answer seems to be "yes, if they add support for it or someone in the community creates an integration assuming that is possible".

I'm closing this issue as answered.

aksaha2311

comment created time in a month

issue commentarangodb/arangodb

Cannot upload foxx service

Can you check if this issue is still present in 3.7?

I'd need access to the zip file in order to investigate further.

packetq

comment created time in a month

issue commentjoowani/python-arango

foxx client does not support binary upload formats to foxx REST API

https://github.com/joowani/python-arango/issues/120#issuecomment-579553800

FYI it looks to me like the configuration and dependencies fields here are specified as Dicts rather than strings. If present they must be passed as regular form fields containing JSON strings. I'm not sure what passing a Dict instead does here but I could imagine this resulting in unexpected behavior.

ex-nerd

comment created time in a month

issue commentarangodb/arangodb

Questions on Foxx management HTTP REST API (Multipart/form-data)

This works for me. Arangojs also uses multipart. Here's an example payload:

----MultipartBoundary775575849169
Content-Disposition: form-data; name="configuration"

{"hello":123}
----MultipartBoundary775575849169
Content-Disposition: form-data; name="dependencies"

{}
----MultipartBoundary775575849169
Content-Disposition: form-data; name="source"; filename="2020830-4187-9xp3cm.ji0dd.zip"
Content-Type: application/zip

PK<snip>
----MultipartBoundary775575849169--

Note that the configuration and dependencies fields are transmitted as regular fields, not "files", i.e. they lack a filename disposition and don't have a content-type header. Maybe that's the cause of your problem?

joowani

comment created time in a month

issue commentarangodb/arangodb

[3.7] Unable to access FOXX's built-in graphiql Interface

There seems to be a bug in 3.7 resulting in the accept header being dropped from the request object. This prevents graphqli from working correctly, among other things.

Supytalp

comment created time in a month

issue openedarangodb/arangodb

Implement `URL`/`URLSearchParams` in JS

Component

Affected feature: Foxx

Steps to reproduce

  1. Use a third-party module that expects URL to be defined, e.g. a recent version of joi.

Problem: An error is thrown because the global is not defined.

Expected result: It should just work.

There's a spec compliant implementation on npm: https://github.com/jsdom/whatwg-url

We could just bootstrap the globals by exposing the two exports of that module on the global scope.

created time in a month

issue commentarangodb/arangodb

[3.7] Unable to access FOXX's built-in graphiql Interface

The button stays gray unless there's a GET route on / relative to the service's mount point.

Try accessing the URL directly via the browser address bar.

Supytalp

comment created time in a month

push eventarangodb/arangodb

Alan Plum

commit sha c74995c8ab17d113976b85bcb6f220ed9fcc4228

Work around #12694 more gracefully.

view details

push time in a month

PR opened arangodb/arangodb

Reviewers
Discard unused Foxx config when saving config in production 3 Foxx

Fixes #12543.

Scope & Purpose

This fixes the behavior of Foxx that was supposed to discard unused stored configuration options when options are renamed or removed after a service has been upgraded. These will result in warnings until discarded.

Additionally the warnings now indicate which configuration options they refer to, making them more meaningful to users.

  • [x] :hankey: Bugfix
  • [ ] :pizza: New feature
  • [ ] :hammer: Refactoring
  • [x] :book: CHANGELOG entry made
  • [x] :muscle: The behavior in this PR was manually tested
  • [x] :computer: The behavior change can be verified via automatic tests

Backports:

  • [x] No backports required
  • [ ] Backports required for: (Please specify versions)

Related Information

  • [ ] Docs PR:
  • [ ] Enterprise PR:
  • [x] GitHub issue / Jira ticket number: #12543
  • [ ] Design document:

Testing & Verification

The changes to tests in this PR overlap with #12694 but should merge cleanly.

  • [ ] This change is a trivial rework / code cleanup without any test coverage.
  • [ ] This change is already covered by existing tests, such as (please describe tests).
  • [x] This PR adds tests that were used to verify all changes:
    • [ ] Added Regression Tests
    • [ ] Added new C++ Unit Tests
    • [x] Added new integration tests (i.e. in shell_server / shell_server_aql)
    • [ ] Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

  • [ ] There are tests in an external testing repository:
  • [ ] I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Documentation

All new Features should be accompanied by corresponding documentation. Bugs and features should furthermore be documented in the changelog so that developers and users have a concise overview.

  • [x] Added a Changelog Entry (referencing the corresponding public or internal issue number)
  • [ ] Added entry to Release Notes
  • [ ] Added a new section in the Manual
  • [ ] Added a new section in the HTTP API
  • [ ] Added Swagger examples for the HTTP API
  • [ ] Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries
+88 -6

0 comment

5 changed files

pr created time in a month

create barncharangodb/arangodb

branch : bug-fix/issue-12543

created branch time in a month

push eventarangodb/arangodb

Jan

commit sha 55b7ed98723890a600a4cc1795994137939cc373

turn off upgrade check even for alpha/beta/preview versions (#12676)

view details

Tobias Gödderz

commit sha 7a4a19c17a0f58516973413df39500b9e6fc8a21

Guard against missing edge collection in graph (#12641)

view details

KVS85

commit sha 93e44f9afb5f74a23f3e6a69b03ff79668402cf2

Use own built rclone

view details

Dan Larkin-York

commit sha c2bb40ee087758f51edaf11052e612385e5c73a7

Cleanup abandoned code for collection upgrade (#12695)

view details

Jan

commit sha a77f084bceb68e381daaa7d28e9c9faa0327b4a7

Bug fix/remove js rebalance (#12691)

view details

Jan

commit sha 0a30011ad2e981b43adfefd05f93f2685da5ab17

don't run a full-fledged AQL query to remove an AQL UDF by key (#12699)

view details

Jan

commit sha 69e4b00b054b34988e972dd3a08aaf1e8850a658

introduce `--database.old-system-collections` option. (#12700) * introduce `--database.old-system-collections` option. * Added startup option `--database.old-system-collections` to toggle automatic creation of system collections `_modules` and `_fishbowl`, along with their internal usage. These collections are useful only in very few case, so it is normally not worth to create them in all databases. The `_modules` collection is only used to register custom JavaScript modules, for which there exists no API, and `_fishbowl` is used to store the temporary list of Foxx apps retrieved from the Github Foxx store. If the option value is `false` (which is the default from v3.8 onwards), the two collections will not be created for any new databaase. The `_fishbowl` collection will still be created dynamically when needed. If the option value is `true`, the collections will be created regularly as before. The option will also be introduced to v3.7, where it will have a default value of `true`, meaning the collections will still be created there. Any functionality related to the `_modules` system collection is deprecated and will be removed in ArangoDB v3.9. Two side effects of when this option is turned on are: * there will no be iteration over all databases at server startup just to check the contents of all `_modules` collections. * less collections/shards will be around for deployments that create a large number of databases. Already existing `_modules` and `_fishbowl` system collections will not be modified by this PR, even though they will likely be empty and unused. * Don't iterate over all databases as server startup in order to initialize the routing information. This is not necessary, as the routing information is global and not tied to a specific database.

view details

Jan

commit sha 71a496d10ec1570ba9d08f433bf990598dac9757

Small improvements for the scheduler (#12703) * Make scheduler react and start new threads slightly faster in case a lot of new work arrives. * Make scheduler propertly count down the number of working threads in case an exception happens in a worker thread.

view details

Jan

commit sha 5476984bd02e24a9835860b5eb40bb0c64922b37

Safeguards against using V8 when JavaScript is turned off (#12704) * Safeguards against using V8 when JavaScript is turned off This PR adds safeguards against using V8 internally in environments that have JavaScript turned off via the `--javascript.enabled false` option. The PR also moves a bit of V8 context initialization code from the Scheduler and the DatabaseFeature into the V8DealerFeature, so it is now all in one place. Finally it adds a new metric that tracks the total time it took to create V8 contexts.

view details

Dan Larkin-York

commit sha c6f24740a121aeb46ab0434d728cfe6f21772a55

Lazily allocate revision trees (#12687)

view details

Dan Larkin-York

commit sha 15878422819d54bd455d7d99cf335d401403f44c

Better audit testing (#12677)

view details

Wilfried Goesgens

commit sha 167e1cf3a6614e5739febd4d88ae9fdfed82089d

detect duplicate testcase names in rspec tests and fix them. (#12692)

view details

Kaveh Vahedipour

commit sha 87b67392021dd16433715a17381993a9989ce671

Feature/agency cache database subscription (#12594) Track changes of individual databases, such that we can run `loadPlan` and `loadCurrent` in `ClusterInfo` only on changed databases. Furthermore, track which databases have to be considered in the `Maintenance` loop. This should allow to use many more databases in a cluster than previously possible.

view details

Andrey Abramov

commit sha 3c57c347893d78af1af2228c0f7f73c723db4377

Feature/arangosearch-s2 (#12592) * initial implementation of GEO_INTERSECT function for arangosearch * simplify FieldIterator * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * adjust test * wip * wip * cleanup * wip * avoid unnecessary heap allocation in Geo AQL functions * wip * add GEO_IN_RANGE function * wip * default construction logic for vpack desearilizer * wip * allow to specify input/return types for configurable analyzers * do not use pools for name,value buffers * wip * wip * wip * wip * wip * wip * wip * wip * wip * add some tests * revert some changes * wip * address review comments * wip * address review comments * wip * wiup * fix test * fix test * address review comments * fix test * attempt to fix msvc build * Fix MSVC build Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>

view details

Dan Larkin-York

commit sha 12983d564a6e56628d6f35854d3f14c4561d4b07

Remove unsafe hidden option from arangorestore (#12711)

view details

Simon

commit sha 47ed94f41cc4e82407b57ac964481af1fa6f5e0f

Stream cursor shutdown fix (#12689)

view details

Dan Larkin-York

commit sha eb71062b07c920f912a858501dc03a0455219cd0

Use dynamically-sized revision trees (#12716)

view details

Alan Plum

commit sha ebcef630075112986fd46953df8b5838d166c1ad

Merge branch 'devel' into bug-fix/issue-12363

view details

push time in a month

pull request commentfacebook/create-react-app

Use new JSX transform with React 17

@mrmckeb nope, just a tsconfig.json. I had problems getting custom ESLint configs to work with CRA before, so I don't use one. Also everything works fine in 4.0.0-next.77 and the current 3.x release.

AFAICT it doesn't complain about all TS syntax (e.g. it didn't complain about a type definition earlier in the same file) but it did complain about the as keyword and ! suffix, both of which are perfectly valid parts of TS syntax.

iansu

comment created time in a month

pull request commentDefinitelyTyped/DefinitelyTyped

[cheerio] Refactor using namespace to expose internal types for callers

Yeah, I also had fun with this via json_ml.

paulmelnikow

comment created time in a month

pull request commentfacebook/create-react-app

Use new JSX transform with React 17

@mrmckeb FWIW my problem was different: ESLint would seemingly treat TSX files as JSX rather than TypeScript and complain about TypeScript syntax and keywords existing in my TSX files. I'm not sure if there are any tests for TS compatibility in react-scripts?

iansu

comment created time in a month

startedtailwindlabs/headlessui

started time in a month

push eventarangodb/arangojs

Alan Plum

commit sha b8353d2adc887ca3b126c8ea5c638d21cc36d357

Update CHANGELOG.md

view details

push time in a month

release arangodb/arangojs

v7.0.2

released time in a month

push eventarangodb/arangojs

Alan Plum

commit sha f9d1f4a0be99dc4c340b5c9959a899340e90adae

7.0.2

view details

push time in a month

issue commentarangodb/arangojs

Documentation typo for saveAll

You're right. Thanks for spotting this one.

hikkyu

comment created time in a month

push eventarangodb/arangojs

Alan Plum

commit sha 4d7e5ef00b16d0a7a08eba13cc8f4c1e7c16040c

Fix replaceByExample/updateByExample

view details

Alan Plum

commit sha f6be6f1367895890c481470cc2aafb5d5c96efa2

Fix typo Fixes #689.

view details

Alan Plum

commit sha 7d6350702b3c2ee200174c457d8e5ca50797559d

7.0.2

view details

push time in a month

created tagarangodb/arangojs

tagv7.0.2

The official ArangoDB JavaScript driver.

created time in a month

push eventarangodb/arangojs

Alan Plum

commit sha c4fd716fbf2d268f15df3cc1c285bf6cf9b80e70

7.0.2

view details

push time in a month

push eventarangodb/arangojs

Alan Plum

commit sha ff621c225c54ab0018a3b4dd0c3bc4a0617997b0

Fix replaceByExample/updateByExample

view details

push time in a month

issue commentarangodb/arangodb

Foxx external request only returns one cookie in response

Clarified via Slack: Fuerte will also support http/http2 and replace all use cases of internal.download.

lumic

comment created time in a month

issue commentarangodb/arangodb

Foxx external request only returns one cookie in response

This is for talking to other (third-party) servers, not ArangoDB. Does Fuerte work there too?

lumic

comment created time in a month

issue commentarangodb/arangodb

Foxx external request only returns one cookie in response

@dothebart can you clarify why? Multiple headers with the same name is pretty normal in HTTP. It should be possible to provide a backwards-compatible API by exposing the full headers via a different property name.

lumic

comment created time in a month

more