profile
viewpoint
Jian Zhang dsonet V2 Network Fullerton, California

dsonet/agate 0

灵活易用的nodejs后端框架

dsonet/angular-semantic 0

AngularJS directives for Semantic-UI

dsonet/arangodb 0

ArangoDB is a native multi-model database with flexible data models for documents, graphs, and key-values. Build high performance applications using a convenient SQL-like query language or JavaScript extensions.

dsonet/avalon 0

a lightweight、high-performance and easy-to-follow javascript MVVM framework

dsonet/avalon.oniui 0

基于avalon的组件库

dsonet/bilibili-backup-backup 0

你还要我怎么样嘛 备份的备份(

dsonet/core-js 0

Standard Library

dsonet/egg 0

🥚 Born to build better enterprise frameworks and apps with Node.js & Koa

dsonet/egg-core 0

A core Pluggable framework based on koa.

dsonet/elasticsearch-analysis-hanlp 0

HanLP Analyzer for Elasticsearch

Pull request review commentvuejs/vue-next

feat(renderList): warn with `v-for` has non-integer range number

 export function ssrRenderList(     }   } else if (typeof source === 'number') {     if (__DEV__ && !Number.isInteger(source)) {-      warn('Please give an non-integer value for v-for range.')+      warn('Please give an integer value for v-for range.')

Better to include the source so that easier to find out the cause.

underfin

comment created time in 19 hours

Pull request review commentvuejs/vue-next

feat(renderList): warn with `v-for` has non-integer range number

 export function ssrRenderList(     }   } else if (typeof source === 'number') {     if (__DEV__ && !Number.isInteger(source)) {-      warn('Please give an non-integer value for v-for range.')+      warn('Please give an integer value for v-for range.')

v-for range expect an integer value but got ${source}.

underfin

comment created time in 19 hours

PullRequestReviewEvent
PullRequestReviewEvent

startedvuejs/vue-next

started time in 2 days

pull request commentzenoamaro/react-quill

rename-unsafe-lifecycles

I think code formatting should be in a separate PR.

dodicandra

comment created time in 6 days

pull request commentarangodb/arangojs

doc: Update to correct constructor config prop

Thank you very much. I was wonder what's wrong with my code since I follow the examples. Turns out the example was wrong:(

jschill

comment created time in 7 days

pull request commentvuejs/vue-next

Remove useless else statements

This decreased the code readability A LOT.

sssmi

comment created time in 7 days

issue commentvuejs/vue-next

Array.prototype.push/pop/shift/unshift cause infinite recursion

What about method splice?

unbyte

comment created time in 11 days

pull request commentvuejs/vue-next

fix(reactivity): Array.prototype.push causes infinite recursion

@unbyte If so, unshift should also be included.

unbyte

comment created time in 12 days

pull request commentvuejs/vue-next

fix(computed): add computedRunners

I think it actually doesn't matter. Because in the end the value was correct.

Jackbar

comment created time in 14 days

startedTencent/omi

started time in 19 days

Pull request review commentvuejs/vue-next

fix(runtime-dom): v-model breaks minlength validation

 function baseCreateRenderer(             const prev = oldProps[key]             const next = newProps[key]             if (-              next !== prev ||-              (hostForcePatchProp && hostForcePatchProp(el, key))+              (hostForcePatchProp && hostForcePatchProp(el, key)) ||+              next !== prev

Why do you change this order? Typically a compare operation would be lighter than a method invoke. It's reasonable to have the comparison ahead.

unbyte

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentvuejs/vue-next

fix(runtime-dom): v-model breaks minlength validation

Why not just compare the 2 values? The less involved the better performance.

unbyte

comment created time in a month

pull request commentvuejs/vue-next

fix(runtime-core/scheduler): use undefined instead of null

Talking about the readability, I think the current one is better. It's clearer to have the logic in an if branch, focus on what we should deal with. With an extra return, it does reduce the indent but definitely increase the cost of reading the code, you have to keep reminding yourself it's actually introduced an else branch.

Picknight

comment created time in a month

startedprocessing/p5.js

started time in 2 months

startedalexandersimoes/d3plus

started time in 2 months

startedunconed/mathbox

started time in 2 months

startedmrdoob/three.js

started time in 2 months

PR opened ecomfe/zrender

fix window !== 'undefined' branch ends too early
+3 -3

0 comment

1 changed file

pr created time in 2 months

push eventdsonet/zrender

Jian Zhang

commit sha 1a8dcbbf0043d5a3eb17a71cb985a7b1f0b4f0da

fix window !== 'undefined' branch ends too early

view details

push time in 2 months

fork dsonet/zrender

A lightweight canvas library which providing 2d draw for ECharts

https://ecomfe.github.io/zrender-doc/public/

fork in 2 months

startedjabez128/jabez128.github.io

started time in 2 months

startedraxxarr/note

started time in 2 months

pull request commentvuejs/rfcs

SFC Improvements

I think finally can implement the componet import sugar syntax?

<template>
  <import src="./Foo.vue" />

  <Foo />
</template>
yyx990803

comment created time in 2 months

issue commentvuejs/jsx

Vue 3 JSX Design

I do like this short style, very clean and can be well self explained with hint. <a vOn={[doThat,'click', ['stop','prevent'icsoftfont>} /> It's really unnecessary to introduce extra import just for this syntax hint.

Amour1688

comment created time in 3 months

issue openedOfficeDev/office-js-docs-pr

Comments API doesn't work on Excel version 2006

I tried this API on Excel, but got "This operation is not implemented." I use the latest beta API.

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

created time in 3 months

startedmidwayjs/midway

started time in 3 months

pull request commentvuejs/vue-next

feat(compiler-ssr): support dynamic components that resolve to element(fix: #1508)

It's may not a good idea to expose this logic in generated ssrRender function. I think the better way is to handle this in library layer.

HcySunYang

comment created time in 3 months

pull request commentvuejs/vue-next

fix(reactivity): observe instance from subclass of Collection (close …

It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct. Just like concept vs real world. IMO the best way to deal with it is to put this into limitations section.

tarnishablec

comment created time in 3 months

Pull request review commentvuejs/vue-next

fix(reactivity): observe instance from subclass of Collection (close …

   },   "[json]": {     "editor.defaultFormatter": "esbenp.prettier-vscode"-  }+  },+  "deno.enable": false

It would introduce unnecessary impact of the runtime performance just for very rare user cases., even though it's technically correct. Just like concept vs real world. IMO the best way to deal with it is to put this into limitations section.

tarnishablec

comment created time in 3 months

startedtootsuite/mastodon

started time in 3 months

pull request commentarangodb/arangodb

adds more AQL functions

@jsteemann About the name IP4, I think the better name is IPv4, it's much more standardized & widely used.

jsteemann

comment created time in 3 months

push eventdsonet/vue-next

Jian Zhang

commit sha d584e99b71fffd31ba1bc48d71c2ce5f8b9c5bc7

perf(BaseTransition): avoid unnecessary function call

view details

push time in 3 months

startedrainersu/sumi

started time in 3 months

more