XBMC Main Repository
A better opn. Reuse the same tab on Chrome for 👨💻.
push eventgatsbyjs/gatsby
commit sha 80e1a6d5b3d5f8d5a92bf3faf1d6ff1d251c0df6
fix(structured-logging): keep track of pending status when delaying SET_STATUS dispatch
push time in 9 hours
push eventgatsbyjs/gatsby
commit sha ecedcb6e2a7b6c7f6aaec7bad5bec0b46ed63757
test(structured-logging): add unit and some integration tests around SET_STATUS
push time in 9 hours
Pull request review commentgatsbyjs/gatsby
Create unlinked reference doc for new file system based route APIs
+---+title: Creating Pages from the File System+---++This page roughly documents the APIs and conventions available with the new file-based page creation features.++For now, these features are marked as experimental and require a flag to utilize. Start your Gatsby site locally with the following flag:++```shell+GATSBY_EXPERIMENTAL_ROUTING_APIS=1 gatsby develop+```++## Creating client-only routes++Use client-only routes if you have dynamic data that does not live in Gatsby. This might be something like a user settings page, or some other dynamic content that isn't known to Gatsby at build time. In these situations, you will usually create a route with one or more dynamic segments to query data from a server in order to render your page.++For example, in order to edit a user, you might want a route like `/user/:id` to fetch the data for whatever `id` is passed into the URL. You can now use square brackets (`[ ]`) in the file path to mark any dynamic segments of the URL.++- `/src/pages/users/[id].js => /users/:id`+- `/src/pages/users/[id]/group/[groupId].js => /users/:id/group/:groupId`++Gatsby also supports _splat_ routes, which are routes that will match _anything_ after the splat. These are less common, but still have use cases. As an example, suppose that you are rendering images from [S3](/docs/deploying-to-s3-cloudfront/) and the URL is actually the key to the asset in AWS. Here is how you might create your file:++- `/src/pages/image/[...awsKey].js => /users/*awsKey`+- `/src/pages/image/[...].js => /app/*`
the right side doesn't match left side here - on the left /images/splat - on the right /users/splat or /app/splat
comment created time in 10 hours
push eventgatsbyjs/gatsby
commit sha 0a6c4314958587155362378e9105d90152836ce6
test(structured-logging): add unit and some integration tests around SET_STATUS
push time in 10 hours
PR opened gatsbyjs/gatsby
Description
The setStatus action creator calls are not working correctly right now. This PR aims to add bunch of tests first (some of which will fail), and add code changes showing that hose fixes some problems later.
pr created time in 10 hours
create barnchgatsbyjs/gatsby
branch : fix/structured-logging/fix-delayed-set-status
created branch time in 11 hours
Pull request review commentgatsbyjs/gatsby
"react": "^16.8.0", "redux": "^4.0.5", "resolve-cwd": "^3.0.0",- "semver": "^6.3.0",+ "semver": "^7.3.2",
You probably are right. Older gatsby-cli versions will work fine on older node versions, so upgrade that bumps node version should fine
comment created time in 17 hours
issue commentgatsbyjs/gatsby
ESLint warnings in file that doesn't exist
I'll reopen the issue, as the just published hot-fix handles one specific instance of it, but didn't fix it for all cases (second comment). So this need more involved follow up.
comment created time in 20 hours
Pull request review commentgatsbyjs/gatsby
export const writeAll = async (state: IGatsbyState): Promise<boolean> => { let syncRequires = `${hotImport} // prefer default export if available-const preferDefault = m => m && m.default || m+const preferDefault = m => (m && m.default) || m
In this case I'm not sure which one is more readable :)
But I think we could use your suggestions because this file should be handled by babel so both optional chaining and nullish coalescing operator should work just fine (tho users do have option to use their own custom babel config, so probably keeping old style would result in less potential for problems)
comment created time in 21 hours
issue commentgatsbyjs/gatsby
Cannot find module 'gatsby-cli/lib/reporter'
It looks like https://github.com/gatsbyjs/gatsby/blob/a3f9d2d02bf1bd013eeafb776088da94245c0bf4/packages/gatsby-plugin-page-creator/src/is-valid-collection-path-implementation.ts#L2 imports gatsby-cli, but the package doesn't declare it in its dependencies https://github.com/gatsbyjs/gatsby/blob/a3f9d2d02bf1bd013eeafb776088da94245c0bf4/packages/gatsby-plugin-page-creator/package.json#L26-L34
comment created time in 21 hours
issue commentgatsbyjs/gatsby
ESLint warnings in file that doesn't exist
Opened https://github.com/gatsbyjs/gatsby/pull/26356 to fix this the no-mixed-operators problem. Thank you very much @mrseanbaines for the reproduction showcasing the issue.
I do think that using "ignore" options is better overall (as the more custom eslint rules can still cause more warnings/errors as showcased by logs from @bluenex). Seeing that gatsby-plugin-eslint does set some default exclude ( https://github.com/mongkuen/gatsby-plugin-eslint/blob/master/src/gatsby-node.js ), I might either create pull request in the plugin ... or adjust the "virtual" file path to contain .cache which should restore behaviours before the switch to virtual modules
comment created time in 21 hours
PR opened gatsbyjs/gatsby
Description
Code we generate in (a)sync-requires.js (virtual) modules currently doesn't pass no-mixed-operators eslint rule. This is quick change to make it pass. This is for cases when users might use some custom eslint setups (tho I probably should follow up and see if we have documentation for eslint-loader modifications anywhere and possibly adjust ignore setting there to ignore modules from _this_is_virtual_fs_path_/$virtual (as user might have very speciffic rules that would warn/error on code we autogenerate)
Related Issues
Fixes #26319
pr created time in 21 hours
create barnchgatsbyjs/gatsby
branch : fix/sync-requires/no-mixed-operators
created branch time in 21 hours
created taggatsbyjs/gatsby
Build blazing fast, modern apps and websites with React
created time in a day
push eventgatsbyjs/gatsby
commit sha 6a4b69b31fcf3e78f495b6ee35564a72c1675593
chore(release): Publish - [email protected]
push time in a day
push eventgatsbyjs/gatsby
commit sha da1caa617d343fd656d5ca1151f0f7b36c21a820
fix(gatsby-dev-cli): Increase verdaccio max_body_size (#26339) Co-authored-by: Laurie Barth <[email protected]> Co-authored-by: gatsbybot <[email protected]>
push time in a day
PR merged gatsbyjs/gatsby
We're seeing payload size errors on tests for a few PRs. This should fix that.
pr closed time in a day
Pull request review commentgatsbyjs/gatsby
feat(reporter): log pending activities when killing process externally
import signalExit from "signal-exit" import { getStore } from "./redux" import { createPendingActivity } from "./redux/actions"-import { ActivityStatuses } from "./constants"+import { ActivityStatuses, ActivityTypes } from "./constants" import { reporter } from "./reporter" -const interruptActivities = (): void => {+const interruptActivities = ({+ showCancelledPendingActivities = false,+}: {+ showCancelledPendingActivities?: boolean+} = {}): void => { const { activities } = getStore().getState().logs+ const cancelledPendingActivitiesIds: Array<string> = [] Object.keys(activities).forEach(activityId => { const activity = activities[activityId] if ( activity.status === ActivityStatuses.InProgress || activity.status === ActivityStatuses.NotStarted ) { reporter.completeActivity(activityId, ActivityStatuses.Interrupted)+ if (activity.type === ActivityTypes.Pending) {+ // pending activities are hidden from UI, so we construct+ // list of pending activities to log them to make it easier+ // to debug any timing issues related to reporting+ // global status (SET_STATUS)+ cancelledPendingActivitiesIds.push(`"${activityId}"`)+ } } })++ if (+ showCancelledPendingActivities &&+ cancelledPendingActivitiesIds.length > 0
Yeah, I will re-do this part a little - together with what I mentioned in https://github.com/gatsbyjs/gatsby/pull/26332#issuecomment-671465335 which will also need quite a bit more changes
comment created time in 2 days
pull request commentgatsbyjs/gatsby
feat(reporter): log pending activities when killing process externally
I just marked this PR as draft as I did think of scenarios where logging on SIGINT/SIGTERM event would not help in cases when entire container can be brute force killed and gatsby process just can't react to it.
New approach that I'm thinking of right now is to (re)set 5 or 10 minutes timer on every log action while we are in non-idle state that would log information on what activities prevent gatsby from transitioning to done/idle state. Log action can be progress bar tick, regular log line, starting/ending/marking activities as pending/cancelled, so those traditionally long running activities (query running, html writing) should be fine as we tick progress bar which would reset diagnostic log timer
comment created time in 2 days
Pull request review commentgatsbyjs/gatsby
feat(reporter): log pending activities when killing process externally
import signalExit from "signal-exit" import { getStore } from "./redux" import { createPendingActivity } from "./redux/actions"-import { ActivityStatuses } from "./constants"+import { ActivityStatuses, ActivityTypes } from "./constants" import { reporter } from "./reporter" -const interruptActivities = (): void => {+const interruptActivities = ({+ showCancelledPendingActivities = false,+}: {+ showCancelledPendingActivities?: boolean+} = {}): void => { const { activities } = getStore().getState().logs+ const cancelledPendingActivitiesIds: Array<string> = [] Object.keys(activities).forEach(activityId => { const activity = activities[activityId] if ( activity.status === ActivityStatuses.InProgress || activity.status === ActivityStatuses.NotStarted ) { reporter.completeActivity(activityId, ActivityStatuses.Interrupted)+ if (activity.type === ActivityTypes.Pending) {+ // pending activities are hidden from UI, so we construct+ // list of pending activities to log them to make it easier+ // to debug any timing issues related to reporting+ // global status (SET_STATUS)+ cancelledPendingActivitiesIds.push(`"${activityId}"`)+ } } })++ if (+ showCancelledPendingActivities &&+ cancelledPendingActivitiesIds.length > 0+ ) {+ reporter.warn(+ `There were pending activities:\n${cancelledPendingActivitiesIds.join(+ `, `+ )}.\nPlease, create bug report, if you see this warning when exiting idle process.`+ )
I'm not sure how to word properly this. Users can exit when legitimately in progress and the warning then might be confusing.
For the most part this is most helpful in CIs (where SET_STATUS is most often used), so maybe I should enable this logs there only to not confuse users on their local runs?
comment created time in 2 days
PR opened gatsbyjs/gatsby
Description
This is meant to make it easier to debug timing issues related to SET_STATUS ipc messages not being fired when they should be - switching from "IN_PROGRESS" to idle ("SUCCESS" or "FAILED") would be "blocked" if there are any pending activities. Pending activities are hidden from output (or ipc) and it sometimes can be tricky to reproduce problems like this (as they can be timing related), so logging those should help with debugging of those cases.
pr created time in 2 days
create barnchgatsbyjs/gatsby
branch : log-pending-activities-on-interupt
created branch time in 2 days
Pull request review commentgatsbyjs/gatsby
"react": "^16.8.0", "redux": "^4.0.5", "resolve-cwd": "^3.0.0",- "semver": "^6.3.0",+ "semver": "^7.3.2",
This one is tricky - because global cli is meant to be as backward compatible - this move will break newer cli versions (as semver@7 needs node>=10) for folks trying to use older gatsby versions (that are running fine on node 8 - older v2 versions or even node 6 - gatsby v1)
comment created time in 6 days
issue commentgatsbyjs/gatsby
npm install -g gatsby-cli not working
I also just try installing globally again now and it worked, so for all folks I recommend retrying now
comment created time in 6 days
issue commentgatsbyjs/gatsby
npm install -g gatsby-cli not working
Folks, please track https://status.npmjs.org/incidents/cksjqc1w11v5 - this is npm "incident". 10 minutes ago they reported
We are still looking into error telemetry for installation of scoped packages but are seeing signs of improvement. so it might already been resolved, but they didn't change the overall incident to resolved yet as they monitor errors still
comment created time in 6 days
issue commentgatsbyjs/gatsby
npm install -g gatsby-cli not working
Related with sideway/joi#2411
Unless they remove/delete package completely from registry (and not just deprecate it), it will continue to work (well, if there are no npm issues that is :/)
comment created time in 6 days
issue closedgatsbyjs/gatsby
<!-- Please fill out each section below, otherwise, your issue will be closed. This info allows Gatsby maintainers to diagnose (and fix!) your issue as quickly as possible.
Useful Links:
- Documentation: https://www.gatsbyjs.org/docs/
- How to File an Issue: https://www.gatsbyjs.org/contributing/how-to-file-an-issue/
Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
-->
Description
when i use npm i gatsby-cli -g, it happen error
node v10.21.0 npm v6.14.4
Steps to reproduce
npm i gatsby-cli
Expected result
install success
Actual result
install error
Environment
node v10.21.0 npm v6.14.4 Mac pro 16-inch
closed time in 6 days
3crazyspecial
issue commentgatsbyjs/gatsby
Closing as duplicate - please see https://github.com/gatsbyjs/gatsby/issues/26266#issuecomment-669819344 about likely cause of it
comment created time in 6 days
issue commentgatsbyjs/gatsby
npm install -g gatsby-cli not working
It seems like npm registry have issues with installing "scoped packages" ( https://status.npmjs.org/incidents/cksjqc1w11v5 ) and @hapi/joi is scoped package - so this seems like npm issue
comment created time in 6 days
issue commentgatsbyjs/gatsby
Add messenger plugi in gatsby project
Can you link to one of those guides so we talk about same service (is it facebook messenger?)? I can help with Gatsby-ifying those, but I need bit more info.
comment created time in 6 days
issue closedgatsbyjs/gatsby
Unable to deploy site to gh-pages
<!-- Please fill out each section below, otherwise, your issue will be closed. This info allows Gatsby maintainers to diagnose (and fix!) your issue as quickly as possible.
Useful Links:
- Documentation: https://www.gatsbyjs.org/docs/
- How to File an Issue: https://www.gatsbyjs.org/contributing/how-to-file-an-issue/
Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues -->
Description
The deploy script fails and gives a message about node_modules being ignored
Steps to reproduce
- Clone this repo https://github.com/vicradon/vicradon.github.io
- Install dependencies
- run the deploy script
I can't share my github credentials, so reproduction won't be possible per se
Expected result
No output on the console
Actual result
$ yarn deploy
yarn run v1.22.4
$ gh-pages -d public -b master
The following paths are ignored by one of your .gitignore files:
node_modules
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"
Environment
System: OS: Windows 10 10.0.18362 CPU: (8) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz Binaries: Node: 12.18.2 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD Languages: Python: 3.8.5 - /c/Users/vicradon/AppData/Local/Programs/Python/Python38/python Browsers: Chrome: 84.0.4147.105 Edge: Spartan (44.18362.449.0) npmPackages: gatsby: ^2.20.12 => 2.24.23 gatsby-plugin-manifest: ^2.3.3 => 2.4.21 gatsby-plugin-offline: ^3.1.2 => 3.2.21 gatsby-plugin-react-helmet: ^3.2.1 => 3.3.10 gatsby-plugin-sass: ^2.2.1 => 2.3.12
closed time in 6 days
vicradon
issue commentgatsbyjs/gatsby
Unable to deploy site to gh-pages
I tried forking in effort to reproduce, but I couldn't:
➜ i26263 git:(source) ✗ yarn build && yarn deploy
yarn run v1.16.0
warning ../package.json: No license field
$ gatsby build
success open and validate gatsby-configs - 0.020s
success load plugins - 0.434s
success onPreInit - 0.014s
success delete html and css files from previous builds - 0.011s
success initialize cache - 0.008s
success copy gatsby files - 0.073s
success onPreBootstrap - 0.009s
success createSchemaCustomization - 0.006s
success Checking for changed pages - 0.003s
success source and transform nodes - 0.036s
success building schema - 0.181s
success createPages - 0.014s
success Checking for changed pages - 0.002s
success createPagesStatefully - 0.047s
success update schema - 0.029s
success onPreExtractQueries - 0.002s
success extract queries from components - 0.071s
success write out redirect data - 0.002s
success Build manifest and related icons - 0.338s
success onPostBootstrap - 0.344s
info bootstrap finished - 5.113s
success run static queries - 0.024s - 2/2 84.07/s
success run page queries - 0.014s - 4/4 275.96/s
success write out requires - 0.006s
success Building production JavaScript and CSS bundles - 7.427s
success Rewriting compilation hashes - 0.007s
success Building static HTML for pages - 1.375s - 4/4 2.91/s
info Generated public/sw.js, which will precache 7 files, totaling 270561 bytes.
The following pages will be precached:
/offline-plugin-app-shell-fallback/index.html
success onPostBuild - 0.066s
info Done building in 14.145977722 sec
✨ Done in 14.32s.
yarn run v1.16.0
warning ../package.json: No license field
$ gh-pages -d public -b master
Published
✨ Done in 15.22s.
➜ i26263 git:(source) ✗
And this landed in https://github.com/pieh/vicradon.github.io/tree/master correctly.
I don't really know much about github pages, but this seem like question/issue should be reported in github pages related repositories as you will probably get better support about this issue there (tho I do recognize your setup is following https://www.gatsbyjs.org/docs/how-gatsby-works-with-github-pages/#deploying-to-a-github-pages-subdomain-at-githubio ).
comment created time in 6 days
push eventpieh/vicradon.github.io
commit sha 4fdf6e1f450aeba4a1226b885fe8c4c24736901e
Updates
push time in 6 days
Osinachi Chukwujama Portfolio Website
fork in 6 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): enable ipc messaging on develop
+const { spawn } = require(`child_process`)+const path = require(`path`)++jest.setTimeout(20000) // 20s++const gatsbyBin = path.join(+ `node_modules`,+ `gatsby`,+ `dist`,+ `bin`,+ `gatsby.js`+)++describe(`IPC Send`, () => {+ let gatsbyProcess++ beforeAll(() => {+ gatsbyProcess = spawn("node", [gatsbyBin, `develop`], {+ stdio: [`ignore`, `ignore`, `ignore`, `ipc`],+ env: {+ ...process.env,+ NODE_ENV: `development`,+ },+ })+ })++ afterAll(async () => {+ gatsbyProcess.kill()+ })++ // TODO remove to a more global integration test but for now we want to make sure it gets an external send command+ it(`should kill the develop process when exit command is given`, done => {+ expect.assertions(1)+ gatsbyProcess.on("exit", () => {+ expect(true).toBe(true)
true ...true ... ;)
please ignore this - I get why, just couldn't not comment on this :)
comment created time in 6 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Move static queries to page data dir
export default function ({ types: t }) { ) { const identifier = t.identifier(`staticQueryData`) const filename = state.file.opts.filename- const shortResultPath = `public/static/d/${this.queryHash}.json`+ const shortResultPath = `public/page-data/static/d/${this.queryHash}.json`
I'm fine with major bump, but I wonder if just making location configurable through babel plugin options and defaulting to legacy one would be fine for readability and maintainability.
We don't need core and plugin (or other deps like cli etc) to be on same major version, but having them on same major feels to me like this skips additional mental overhead of which dep version is used in which core version
comment created time in 7 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Move static queries to page data dir
export default function ({ types: t }) { ) { const identifier = t.identifier(`staticQueryData`) const filename = state.file.opts.filename- const shortResultPath = `public/static/d/${this.queryHash}.json`+ const shortResultPath = `public/page-data/static/d/${this.queryHash}.json`
this is a breaking change, we need to do this when gatsby core tells us to do so, otherwise older gatsby version will start breaking (especially after cleaning lock files). Alternatively needs major version bump for babel pluin
comment created time in 7 days
push eventgatsbyjs/gatsby
commit sha f041f8c5cc9451e1b9ca2f4b44f25c5e030d2a49
test(artifacts): add basic case for using query modules in static query
push time in 7 days
push eventgatsbyjs/gatsby
commit sha 9e8d3052d9b01cf28e31694daa8fde25ed5d97cf
fix: handle cases with chained static query -> modules -> static query
commit sha 1e2bccd1d304bd3a1a40442a2cc6f74b2724c068
tmp
commit sha 67466d5403254db6a53c75981f90ebc91a5cbff3
test(artifacts): add basic case for using query modules in static query
push time in 7 days
push eventgatsbyjs/gatsby
commit sha cf8ba275384da7e5757e8edf1d1e83d41ae7d4c0
fix: handle cases with chained static query -> modules -> static query
push time in 7 days
push eventgatsbyjs/gatsby
commit sha 9aecfca4aaf649d1837611beadd4cd2036ec1259
fix(docs): correct ESLint plugin name (#26216) `gatsby-eslint-plugin` -> `gatsby-plugin-eslint` 👍
commit sha a8343def322bd43e742a99751f1f70b75c0f3b33
Adds back peer dependency (#26217)
commit sha 39a457718aae0832c47d2e2daa4570319e6e7355
Create blog post for Recipes Alpha II launch (#26145) * Create index.md * chore: format * Adjust formatting, fix NPM -> npm * chore: format * add code fencing * fix language * chore: format * mdx => MDX * Update and rename docs/blog/2020-07-30-Announcing-Gatsby-Recipes-Alpha-2/index.md to docs/blog/2020-07-31-Announcing-Gatsby-Recipes-Alpha-2/index.md * Rename docs/blog/2020-07-31-Announcing-Gatsby-Recipes-Alpha-2/index.md to docs/blog/2020-08-03-Announcing-Gatsby-Recipes-Alpha-2/index.md * adjust verb tense * Change date, shorten links Change frontmatter and filename to reflect new run date Shorten local links Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Kyle Mathews <[email protected]>
commit sha 3d524dfb9c82ce980cc66218441c007a53491571
Update update-notifier package (#26142)
commit sha 93e1ebdbf10c3fb1f541dfc4c2b6f1af75174d12
fix(gatsby-recipes): Update snapshot to reflect latest recipe text (#26219)
commit sha 3fef89f8ec44b03309ed472d8843cc5380967f78
fix links 404 (#26224)
commit sha 62df4723dff1e6368f507fccd3e97cfd32140c0c
Add blog post for Community Permissions Changes (#26223) * Add blog post for Community Permissions Changes * chore: format * Update index.md * Add Forem to dictionary.txt * Add "pm" to dictionary.txt * update spelling of "résumé" Co-authored-by: gatsbybot <[email protected]>
commit sha a33e1f95be8c4ffe7e6ecd489aee2a78d2ea0a67
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected]
commit sha edefce7f5d71bf9c405c13e778f6a04e09f5f9dc
Remove README link to Spectrum (#26164) Remove repo README support link to Spectrum (support for it has been discontinued and it is going to be sunsetted) and replace with a link to the AskGatsbyJS Twitter account
commit sha 9d334ac5e1bb55c2ac51bf07f4d7de1c718dfabf
feat(generateComponentChunkName): allow receiving optional prefix instead of hardcoded `component`
commit sha 783ccdde7a5cae256c90f3933d877ae50a0761b5
add modules and queryModuleDependencies states to redux, as well as minimal amount of actions to make use of it
commit sha 00658bdf4b3eb5fc3876e48ecbe9ce4b573397db
add context.pageModel.setModule function that will register module and tie it to page query result
commit sha 5871cec82b9055c75df7646b15721b05c5cfefc3
write modules used by page queries to page-data files
commit sha 50111e1010ae1165c757663142a37c4afd4fcccf
add registered modules to webpack bundles
commit sha edfdfbaf94f2f640c94500c1cd79691ca50fc7d7
allow loader.loadComponent to accept optional key to fetch modules
commit sha f74592fc7b6bac4c715697085d5fd6f3e718bdad
implement `getModule`, load needed modules for a page in browser and for SSR
commit sha 6dd224ada63126c0e8cd8376d64bd210434bdf77
feat(dev-loader): update syncRequires on hot updates
commit sha b0ae81d08aa8148ae7c568339052282ad1a20ede
feat(dev-loader): retry mechanism with timeout and hmr trigger
commit sha 85ed892f50d2cc91fb5b2e5ec3167076120bedee
feat(socket-io): run processHotPageDataUpdate if modules changed
commit sha f11fcb3a76c1d7ccc2d72b7d4a7ac0d48ea8038e
feat(query-modules): add support for static queries
push time in 7 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): enable ipc messaging on develop
class ControllableScript { } this.process.on(`exit`, callback) }+ // eslint-disable-next-line @typescript-eslint/no-explicit-any+ send(msg: any): void {+ if (!this.process) {+ throw new Error(`Trying to attach exit handler before process starter`)
And well, this msg doesn't make sense - we don't try to attach exit handlers - is this copied from somewhere? :P
comment created time in 7 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): enable ipc messaging on develop
class ControllableScript { } this.process.on(`exit`, callback) }+ // eslint-disable-next-line @typescript-eslint/no-explicit-any+ send(msg: any): void {+ if (!this.process) {+ throw new Error(`Trying to attach exit handler before process starter`)
NIT :)
throw new Error(`Trying to attach exit handler before process started`)
comment created time in 7 days
pull request commentgatsbyjs/gatsby
fix(gatsby): don't place virtual modules in node_modules directory
Should I have to create an issue ?
@MrGlox Please do, and please @mention me in the issue.
comment created time in 7 days
push eventpieh/query-webpack-modules-demo-site
commit sha 2dce6cf275fa81c5c42d4b2ce6bc022665964fbf
sync
push time in 8 days
push eventpieh/query-webpack-modules-demo-site
push time in 8 days
push eventgatsbyjs/gatsby
commit sha c1110b3fc827238907b2fb0e80d59487a68bb621
feat(gatsby-admin): add modal to manage plugin (#26154) * very rough, includes initial query * very rough, includes initial query * feat(gatsby-admin): add modal to manage plugin * Add loading states * Delete unused file * Show errors in UI Co-authored-by: Laurie Barth <[email protected]>
commit sha 1c5d8e93f0c760d3f36ce1c65a7b0faa4cbb30b9
feat(gatsby-admin): new navbar design (#26159) * feat(gatsby-admin): new navbar design * Update yarn.lock * graphiql
commit sha e9c1f813bc54c835e3804a194327d5d48d5a9583
chore(release): Publish - [email protected] - [email protected] - [email protected]
commit sha 23e6e9bfb4c6f6dde8f380eb15b754411004800c
chore(release): Publish - [email protected] - [email protected]
commit sha 471cb04bacb0bdfc1788263c471129ac54d41de1
chore(release): Publish - [email protected] - [email protected]
commit sha 157bf79ad4afbbdcea0274fc13d9af18a5588c2a
chore(release): Publish - [email protected] - [email protected]
commit sha 2f61ef94c119abc6aa96895043b1a07889efeecf
chore(release): Publish - [email protected] - [email protected]
commit sha feedd1fa4a4c41f1eb097d71ec6707f007771948
chore(release): Publish - [email protected] - [email protected]
commit sha 5791f9ed90b145d3b27d71eea9f4340b1b97aa15
write new blog post about Will It Build (#26113) * write new blog post about Will It Build * Update date * Update date on the post as well * fix images * re-add post o_O * Fix WordPress spelling
commit sha 8ca67a08bbe338b75845669ed0e1d7a04316a964
chore(release): Publish - [email protected] - [email protected]
commit sha 22196a1f04c589f4058875380848d3f9580fef06
feat(gatsby-telemetry): Add API to track feature usage (#26071) * feat(gatsby-telemetry): Add API to track feature usage * fix lint * bring back machineId type
commit sha 5be939b76d7f030f068ea9c9d18d3577880380c7
refactor(www): standardize border styles (#25460) * use border/borderColor properties for styling borders * use border/borderColor properties for styling borders * bump gatsby-design-tokens * update stuff * fix order, it's important — otherwise `borderColor` will render as `initial` Fix views/creators/badge background color along the way. Co-authored-by: Florian Kissling <[email protected]>
commit sha 4e74b97c7e201a7a98763e283c1fac51020eb7c6
remove escaping code fences (#25853)
commit sha 96fdb6b211b08be1f2dc91e9fc5d986d1e5d4d48
fix(readme): gatsby-remark-images -> put code in code fences (#25854) * put code in code fences * more code fences * lint
commit sha 89dcdef9825f4fc13178d6bbb2d672cc885e1c76
fix brand names (#25877)
commit sha 7a7436c55193945574bf87216513c2207c9732e6
add missing prolog of Gatsby Days Reconfigured (#25881)
commit sha f1cb2998f49c996c59422c622be7e7a993a902a3
Change metadata testing tool as its deprecated (#26001)
commit sha dd0ea0a9b552e25037a430a171ab2b52759441a7
fix(docs): Deploy to DigitalOcean -> fix 404 internal link, fix note layout, fix brand names (#25961) * fix 404 internal link, fix note layout, fix brand names * add file name to code block * Apply suggestions from code review Co-authored-by: Aisha Blake <[email protected]>
commit sha ede0e22f1450e2c2edb16c76bb973cfe0e7025fc
add link to swag FAQ's in contributing section (#26049)
commit sha 9dc60744dd57d5890cc1c7718a39481e7876b802
add redux doc to sidebar (#26082)
push time in 8 days
pull request commentgatsbyjs/gatsby
feat(gatsby): data-driven code-splitting
Are there any plans for this feature to get merged into the official version any time soon? I have a setup running using this draft but Gatsby Cloud won't allow using incremental builds for this unofficial version.
I'm working right now on adding incremental build support (it's not just matter of this feature landing in stable release, there are some more code paths to cover when deciding which pages need to be rebuilt, because of how modules can include static queries, which can add more modules (which can have more static queries), the reconciliation is getting much more complex here. The plan is to land this within ~2 weeks right now
comment created time in 8 days
pull request commentgatsbyjs/gatsby
fix(gatsby): don't place virtual modules in node_modules directory
You shouldn't need to do anything more. This is likely interaction with either direct webpack config manipulation (in gatsby-node) or some plugin doing something under the hood.
Here's screenshot from dev tools used on gatsbyjs.org where same path is used (sync-requires is used in gatsby develop and some parts of gatsby build, so here we have async-requires, but both are using same mechanism)
comment created time in 9 days
issue commentgatsbyjs/gatsby
Pass custom encoding to loadNodeContent method
So I think the information about an encoding should be somehow embedded in the node itself. Probably the same way we do with mimeTypes. Then the plugin that is responsible for actually loading the node could properly convert it to
utf-8.
I'm not sure if this would work for filesystem to set encoding on its own, it would need to be hinted by users (or plugins calling loadNodeContent) in some way what encoding to use. Also this would require breaking change as right now we return decoded string and not pre-decoding buffer.
Given above, I would be ok with optional 2nd param (as done in https://github.com/gatsbyjs/gatsby/pull/26174) to force non-utf-8 decoding controlled by transformer plugin (I think most transformers that would use it would be pretty custom, because of how unwieldy it would be to make this user configurable via plugin options and use cases that needs this - most of data is utf-8 these days)
comment created time in 9 days
pull request commentgatsbyjs/gatsby
feat: Added encoding arg to "loadNodeContent" method
This adds 2nd param (encoding), but it isn't actually used anywhere? Now it's up to transformers to make use of it? Do you use custom transformer in the usecase you shared in https://github.com/gatsbyjs/gatsby/issues/26173 where you would make use of it?
comment created time in 9 days
pull request commentgatsbyjs/gatsby
fix(gatsby): don't place virtual modules in node_modules directory
Hi @MrGlox! This should be correctly working path, can you share your project so we could debug it?
comment created time in 9 days
push eventgatsbyjs/gatsby
commit sha 384da2727d68d40ae8402da81f03e0133c42fcf5
feat(generateComponentChunkName): allow receiving optional prefix instead of hardcoded `component`
commit sha 4477109553258eef9340b9a1f0e4f28ae904301d
add modules and queryModuleDependencies states to redux, as well as minimal amount of actions to make use of it
commit sha 0c2f5cf47cafb9531b484ec2834882f6f62ad040
add context.pageModel.setModule function that will register module and tie it to page query result
commit sha dcfbcde00d6c9ff0b9a837071ef158e4c0af5a5b
write modules used by page queries to page-data files
commit sha d388557f0c1f200ece1d017d074978f1dec5d6ca
add registered modules to webpack bundles
commit sha 8b44d09856bfd60782f4cdf2f90c0491e5095ef0
allow loader.loadComponent to accept optional key to fetch modules
commit sha c05ac08878ef83b02139a11d62d0263b1b895171
implement `getModule`, load needed modules for a page in browser and for SSR
commit sha 061c3e6bfd61f40185a73bb95663f9747cd3face
feat(dev-loader): update syncRequires on hot updates
commit sha 14e6571461c4e5cf004a8a6b2734fd4e746d3580
feat(dev-loader): retry mechanism with timeout and hmr trigger
commit sha 9c06fdaf233373277b1651deaa610a351305bf26
feat(socket-io): run processHotPageDataUpdate if modules changed
commit sha 15390d0908823373a2a6925fa15e83210c7c82fb
feat(query-modules): add support for static queries
commit sha 1d4e6ab6e0e393172ee94a62f91f9d5345f1632d
tests(artifacts): add basic cases for query modules
commit sha eb7652d58930b8f3098971ccd63f1acc2d1fb07c
refactor(query-running): move requires writing to after query running
push time in 9 days
PR closed gatsbyjs/gatsby
Description
This PR adds couple of APIs that will allow adding arbitrary "code" modules to pages via graphql data layer. Make sure to check limitations section for current state of this PR
context.pageModel.setModule
Function available in graphql resolvers (can be implemented via createSchemaCustomization / createResolvers hooks).
Signature:
context.pageModel.setModule({
source: string,
type?: "default" | "named" | "namespace",
importName?: string
}): string
Arguments
source: Absolute path to module to be added. If user wants to add some package -require.resolveshould be used to get absolute pathtype: Defines type of import:default-import A from "b"named-import { A } from "b"namespace-import * as A from "b"
importName: only used whentypeis set tonamed- specifies named import to use
Return value
context.pageModel.setModule returns string identifier that later will be used to get instance of a module in frontend code. You will want to return this identifier in resolver where you implement context.pageModel.setModule function.
getModule
This is frontend code function used to get instance of module. Function is imported from gatsby:
import { getModule } from "gatsby"
Signature
getModule(moduleId: string): any
Arguments
moduleId:getModuleexpect module identifier (returned bycontext.pageModule.setModule) as argument. Module identifier is purposely not easily guessable (similar toidin nodes)
Return value
Actual module - this can be React component or any kind of arbitrary code.
Example usage:
Check demo site - https://github.com/pieh/query-webpack-modules-demo-site/tree/0bba2e2158473689850fa9b6112c26dc6f6c8461 . In particular:
createSchemaCustomizationhook that convertscomponentfield in data ( for example https://github.com/pieh/query-webpack-modules-demo-site/blob/0bba2e2158473689850fa9b6112c26dc6f6c8461/content/hello-world/index.json5 ) to module identifiers of actual components implemented in https://github.com/pieh/query-webpack-modules-demo-site/tree/0bba2e2158473689850fa9b6112c26dc6f6c8461/src/components/page-builder.getModuleusage in the frontend
Limitations (currently)
- ~As-is this PR supports using new APIs only in page queries. To support static queries we will need https://github.com/gatsbyjs/gatsby/pull/23837 to be finished and merged.~ Static queries are now supported, not yet very much testing done as there can be surprising chains of things (static query adds a module which has static query and this can repeat over and over again)
- Hot data updates in
gatsby developare not working properly when new modules are added to a page - user does need to manually refresh browser to load new modules ( To handle this we will need https://github.com/gatsbyjs/gatsby/pull/24808 + some additional refactor on top ). EDIT: with state machine in place this is almost done, there are few more timing issues to solve (making long running process rewrite modules at proper time slots, we will need to put bit more things into state machine) - This PR doesn't implement public facing
registerModuleaction that would allow users/plugins to stabilize webpack builds (add module to bundle even if not used currently so we don't have to rewrite whole lot of html files because of webpack hash changes)
Trying it out
I published gatsby@query-webpack-modules that includes those changes - feel free to take it for a spin and let me know what you think
Documentation
❌ This draft PR lacks any documentation related to added new APIs.
Related Issues
Related to https://github.com/gatsbyjs/gatsby/issues/18689
pr closed time in 9 days
push eventgatsbyjs/gatsby
commit sha ce7ba8abcb345174d8f13985b07704bcd8eb71dc
fix(gatsby-image): add required check for one of fluid or fixed (#25371) * Do not crash the page if the image component is invoked without parameters * added a warning if missing fluid and fixed props * had swapped a condition * doing destructuring in function parameter list * now with functioning tree-shaking * updating function doc: returns undefined, not null * switching to proptypes for validation * Update packages/gatsby-image/src/index.js Co-authored-by: Andreas Ehrencrona <[email protected]> Co-authored-by: Ward Peeters <[email protected]>
commit sha f8b7b350fc6e36015b20f82cbfd748e0066c2f78
fix(gatsby): Load resources in ProdPageRenderer (#26092) * Load resources in ProdPageRenderer * Add simple unit tests
commit sha d2de4e5240c0ac777b94ce506fac1b050051769b
chore(release): Publish - [email protected] - [email protected] - [email protected]
commit sha 95ddecbc55322525e327499174b56b835534781b
Update gatsby in www
commit sha c3001522dc5cd0d0a262a60806db49e3030815ad
Add plugincreator to API (#26101) * Add plugincreator to API * fix capitlization Co-authored-by: Laurie Barth <[email protected]>
commit sha f11b9a82a84454354fc5a272fc6497f0357db3fd
chore(showcase): Add Devnet (#25952) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha 0b67a695806f15e8ecc651fe4e227f9a57a6ca9b
Add pluagin source for page (#26104) Co-authored-by: Laurie Barth <[email protected]>
commit sha 5148b3a885eda0984165da8b4b421e6ec7a196db
fix(gatsby-source-contentful): support height parameter for srcset (#25776) * Calculate fixed image width if necessary * Calculate fixed image width if necessary * Revert snapshot test changes * Bring back new test * Update snapshot
commit sha f8fe2b8cef5a691bec9ac024b6107615588784e3
chore(docs): Add author Colby Fayock (#26109) * adding Colby Fayock author avatar and bio * Update author.yaml adding new line at end of file * pretier
commit sha 3f129590f62289bc8c96d1ebd4b55d7c16ffcc9e
chore(gatsby-admin): move sitemap to /pages (#26120)
commit sha b8e1e8d8391b4161ed20873c5ef73f8f83b2dd8c
chore: Add `jest-matchmedia-mock` to replace DIY mock (#26118) Better for maintenance, but also because I need a better API surface of `matchMedia()` for a `gatsby-image` PR that uses it and fails tests otherwise.
commit sha 1030416a47329828d6f07156cd79b53df5f2ce49
Address Uncontrolled Resource Consumption in jpeg-js (#26122) * Address vulnerability in jpeg-js Vulnerability: https://github.com/advisories/GHSA-w7q9-p3jq-fmhm Jimp Pull Request: https://github.com/oliver-moran/jimp/pull/892 Potrace Pull Request: https://github.com/tooolbox/node-potrace/pull/9 * Address vulnerability in jpeg-js Vulnerability: https://github.com/advisories/GHSA-w7q9-p3jq-fmhm Jimp Pull Request: https://github.com/oliver-moran/jimp/pull/892 Potrace Pull Request: https://github.com/tooolbox/node-potrace/pull/9 * Address vulnerability in jpeg-js Vulnerability: https://github.com/advisories/GHSA-w7q9-p3jq-fmhm Jimp Pull Request: https://github.com/oliver-moran/jimp/pull/892 Potrace Pull Request: https://github.com/tooolbox/node-potrace/pull/9 * Update lockfile
commit sha c20e7ef6165e063c99390d25550037a0f9711a53
Updates sites.yml to add Reactive Resume (#25834) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha 0211c053d8894db845838d84cfd268d1940c880a
feat(gatsby-admin): add favicon (#26121)
commit sha 495fd73d6b012cde1a6d44c6ebaf3d8a87e62d8e
feat(gatsby-telemetry): Track if cache was purged (#26096)
commit sha f9e12cc0540eb2fdeb5016fe45f31552dca53f2d
fix(gatsby): Resolve node mutations in waiting state (#26138)
commit sha 12f124b90258763b8ca11aff3746ccdd5c2f42bc
feat(telemetry): Telemetry flush events fixes and covert more of telemetry to TypeScript (#25956) * Flush at end to be safe * Convert more to ts and handle errors better with turit/fetch * More explicit types * Make in-memory-machineids more distinct * Fix up types * Extrace in memory store * Change event storage export * Convert helpers to ts * fix test * Stupid jest * Cheat ts to think match always returns a non null thing
commit sha f57788810b92978bc0d30c0b4b14ae2a14f6a032
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
commit sha f1bfd539878c2183d6acadfc5a07d91e4fbd4e2d
feat(admin): new dashboard design (#26124) * Upgrade strict-ui * Use Inter as the font for everything * Start work on new dashboard design * Fix spacing * Add global layout spacing, update nav a little bit * Fix global backgbround * Various spacing updates * Move global background color to <body> * Add "Coming soon!" for recommended plugins * Add illustration * Fix typescript * Fix badge bg * Cleanup "Coming soon" * Iconssss * Add alt text to img * const Comp => function Comp * Fix contrast issues * fix dirty lock file Co-authored-by: LB <[email protected]> Co-authored-by: Laurie Barth <[email protected]>
commit sha d421cf81c9043e39d328d1677fc81f31315cde42
chore(gatsby-plugin-mdx): Upgrade MDX and snapshots (#26143) Starting in version 1.6.16, the makeShortcode function is only added to compiled MDX when it is needed. This caused the gatsby-plugin-mdx snapshots to fall out of date. MDX is no bumped to 1.6.16 with the snapshots updated. Related: - https://github.com/gatsbyjs/gatsby/pull/24595#discussion_r462906399 - https://github.com/mdx-js/mdx/pull/1088
push time in 9 days
issue commentgatsbyjs/gatsby
[gatsby-remark-prismJs] line highlighting does not work properly with 'triple-quoted-string'
Thanks. Opened https://github.com/gatsbyjs/gatsby/pull/26161 with the fix
comment created time in 12 days
PR opened gatsbyjs/gatsby
Description
This fixes line highlighting with other multiline token spans other than just plain-text (so for example various form of multiline comments, like triple quotes in python or /*, */ in js).
I added test case for it.
Related Issues
Fixes #26079
pr created time in 12 days
create barnchgatsbyjs/gatsby
branch : prismjs-handle-other-multiline-spans
created branch time in 12 days
issue commentgatsbyjs/gatsby
[gatsby-remark-prismJs] line highlighting does not work properly with 'triple-quoted-string'
Hey @Skurrr https://github.com/Skurrr/prismJsBug.git is hello-world starter without markdown/prismjs - could you update repro?
comment created time in 13 days
push eventpieh/gatsby
commit sha d0bf1135eec12d62c9b3f4a2664f124f44bd5b3e
refactor(query-running): move requires writing to after query running
push time in 14 days
pull request commentgatsbyjs/gatsby
chore(gatsby): remove not used code (requires-writer -> startListening)
Ok, apparently this need more changes, marking as draft for now
comment created time in 14 days
PR opened gatsbyjs/gatsby
Description
One of state machine PRs moved triggering requires-writer to state machine flow, and startListener was no longer called but it just wasn't removed. So this is just maintenance removal, nothing should change.
pr created time in 14 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Load resources in ProdPageRenderer
import React from "react" import PropTypes from "prop-types" +import loader from "./loader" import InternalPageRenderer from "./page-renderer" -const ProdPageRenderer = ({ location, pageResources }) => {+const ProdPageRenderer = ({ location }) => {
I wonder if we should keep that prop and fallback to loader.loadPageSync only if it's not passed?
comment created time in 14 days
push eventgatsbyjs/gatsby
commit sha a55f5b6a778063ca4a1ec3aef6d62259b6ae711b
fix: update www (#26043) Co-authored-by: Renovate Bot <[email protected]>
commit sha abc6f874ddd8989cbba03e45f33a22d125077ba6
Added extra markup (#26030) * Added extra markup I found some js code which was not highlighted so I wrapped it in js code block, secondly, I added the link to reach/router as it was confusing if its react/router or reach/router * added the link to reach/router * Update glossary.md
commit sha 462a0608380dc90f5c48eb4b4314557f94cdbe08
chore(showcase): Add leanier.com site (#26016)
commit sha 5c2c68bcf91808633c16d2238712bcb5cb32e433
Add support for cache refresh via GraphiQL (#25960) * Add cache refresh button * Formatting * Explicit return type
commit sha 5d272366beb4ed6cbafefb9e39a275c939a2266c
www: Remove sw (#26054)
commit sha 59de77d7de6e2bc5b36c01dc619cdf8ca5d830b8
Docs: Add a warning about static queries (#25929)
commit sha b84ea14584b6b1f877387f878787fb19578fbdda
feat(gatsby): Add top-level error handling to state machine (#25995)
commit sha 380801165d40c14ee8a80b63ab791fae9f8b1482
chore: Update stale yarn.lock (#26068)
commit sha ec10aab56f379367ba587abb0905ec454fda679b
tests(gatsby): Add unit tests for develop state machine (#26051) * feat(gatsby): Add top-level error handling to state machine * Add initial tests * Add tests for top-level machine * Test error handling * Add post-bootstrap to tests
commit sha c412e4689326228e7a40a5bdd997174a1d186b32
chore(showcase): Add johnkavanagh.co.uk (#25747)
commit sha 96e5ed46d38150c7caaa88239c1ffb1a1a8b86df
chore(showcase): Minor changes Showcase Tatjana Volbeke Portfolio (#25613)
commit sha 5e5b41361ecb96765b6f696090662c5aca9e9495
fix(gatsby): Defer node mutation in more APIs (#26067)
commit sha ae10d6f0910e98bda55910845d0839f76fdb150d
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
commit sha 32f651d9e92c4302523b3371bb82a39b61d12003
chore(showcase): add Julien Karst website (#25682) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha f6c6279447d78e3dc62f911a83864ce69d78fcd8
chore(showcase): BRIKL & TRUE STORY in showcase (#25631) * chore(showcase): BRIKL & TRUE STORY in showcase * chore(showcase): run prettier sites.yml Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha a387bb48e8b2fff3bed54301b2bef9919b5ec4b1
chore(blog): Add i18n theme blog post (#26065) * add blog post * fix linting * put head in code tag lol
commit sha 7619c35a84e5e642b690a0b7d5e51c49135064c2
chore(showcase): add Château de Morey 🏰 (#25683) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha a4f171df1332c4290d86285db295514588f65afb
chore(showcase): meetup.com (#25792) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha 7486b8bfdfb32bbcce67385e922ffd6c9bc98d43
chore(gatsby): fix typegen for publishing (#26078) * chore(gatsby): add typescript as dev dependency * chore(gatsby): run typegen after rimraf
commit sha 9497c97718ad910487f6007b030d057093541ab0
fix(gatsby): Delete babel and terser cache dirs (#26053) * Delete babel and terser cache dirs * Clean up yarn lock * fix yarn.lock (?) * verbose gatsby-dev * chore(gatsby): add typescript as dev dependency * Update e2e-test.sh * chore(gatsby): run typegen after rimraf Co-authored-by: Michal Piechowiak <[email protected]> Co-authored-by: gatsbybot <[email protected]>
push time in 14 days
push eventgatsbyjs/gatsby
commit sha 5cf968754d5664cba22bd1d8c2ee1162e46fd7c6
fix(gatsby): Load static query results from its own Db (#26077) * Load static query results from its own Db * Keep StaticQueryContext because it is public API * Switch to an Object for static query results from a Map * Move getStaticQueryResults to private API
push time in 14 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Load static query results from its own Db
export const publicLoader = { isPageNotFound: rawPath => instance.isPageNotFound(rawPath), hovering: rawPath => instance.hovering(rawPath), loadAppData: () => instance.loadAppData(),+ getStaticQueryDb: () => Object.fromEntries(instance.staticQueryDb),
I don't know if that number scales with the number of pages or just the number of source code files.
This scales with number of source files, not nodes/data
comment created time in 14 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Load static query results from its own Db
export const publicLoader = { isPageNotFound: rawPath => instance.isPageNotFound(rawPath), hovering: rawPath => instance.hovering(rawPath), loadAppData: () => instance.loadAppData(),+ getStaticQueryDb: () => Object.fromEntries(instance.staticQueryDb),
Can we instead just have staticQueryDb as plain object and not Map to save on those conversions on each render? Also Object.fromEntries would need polyfilling possibly? It's quite new API
comment created time in 15 days
push eventgatsbyjs/gatsby
commit sha b075fde69521ba7d6be7e8d6f814e2492c8ec73e
chore(gatsby): run typegen after rimraf
push time in 15 days
PR opened gatsbyjs/gatsby
Description
Adds typescript as dev dependency to gatsby, as tsc is used in build scripts.
Also shuffles build command a little, because it was running rimraf dist after typegen resulting in loss of generated definition files.
pr created time in 15 days
create barnchgatsbyjs/gatsby
branch : chore/core-fix-typegen-for-publishing
created branch time in 15 days
push eventgatsbyjs/gatsby
commit sha 8fbebbdf427937f560dd73c53cbaa5a0a8c85dfb
Update e2e-test.sh
push time in 15 days
push eventgatsbyjs/gatsby
commit sha 92ed31c1555b03d39b33091be82d2abfa43f0d3e
chore(gatsby): add typescript as dev dependency
push time in 15 days
push eventgatsbyjs/gatsby
commit sha c45ae162fc84f099a2bd9aae69f8494afa950cd4
verbose gatsby-dev
push time in 15 days
push eventgatsbyjs/gatsby
commit sha 5d272366beb4ed6cbafefb9e39a275c939a2266c
www: Remove sw (#26054)
commit sha 59de77d7de6e2bc5b36c01dc619cdf8ca5d830b8
Docs: Add a warning about static queries (#25929)
commit sha b84ea14584b6b1f877387f878787fb19578fbdda
feat(gatsby): Add top-level error handling to state machine (#25995)
commit sha 380801165d40c14ee8a80b63ab791fae9f8b1482
chore: Update stale yarn.lock (#26068)
commit sha ec10aab56f379367ba587abb0905ec454fda679b
tests(gatsby): Add unit tests for develop state machine (#26051) * feat(gatsby): Add top-level error handling to state machine * Add initial tests * Add tests for top-level machine * Test error handling * Add post-bootstrap to tests
commit sha c412e4689326228e7a40a5bdd997174a1d186b32
chore(showcase): Add johnkavanagh.co.uk (#25747)
commit sha 96e5ed46d38150c7caaa88239c1ffb1a1a8b86df
chore(showcase): Minor changes Showcase Tatjana Volbeke Portfolio (#25613)
commit sha 5e5b41361ecb96765b6f696090662c5aca9e9495
fix(gatsby): Defer node mutation in more APIs (#26067)
commit sha ae10d6f0910e98bda55910845d0839f76fdb150d
chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected]
commit sha 32f651d9e92c4302523b3371bb82a39b61d12003
chore(showcase): add Julien Karst website (#25682) Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha f6c6279447d78e3dc62f911a83864ce69d78fcd8
chore(showcase): BRIKL & TRUE STORY in showcase (#25631) * chore(showcase): BRIKL & TRUE STORY in showcase * chore(showcase): run prettier sites.yml Co-authored-by: Obinna Ekwuno <[email protected]>
commit sha 432c9e22f4b498ab18d757095ea9e822e7bbc175
Merge remote-tracking branch 'origin/master' into fix/gatsby-clean
push time in 15 days
push eventgatsbyjs/gatsby
commit sha 3712d8c9574a5cb3c70e49e818f9c8a2ae371081
fix yarn.lock (?)
push time in 15 days
PR opened gatsbyjs/gatsby
just testing gatsbybot
pr created time in 15 days
Pull request review commentgatsbyjs/gatsby
fix(gatsby): Delete babel and terser cache dirs
import { IProgram } from "./types" module.exports = async function clean(program: IProgram): Promise<void> { const { directory, report } = program - const directories = [`.cache`, `public`]+ const directories = [+ `.cache`,+ `public`,+ // Ensure we clean babel loader cache+ findCacheDir({
what happens if this can't find anything - will it return undefined, false, null? And we would still call fs.remove on those? Not sure if that's potential problem or not, but maybe we should .filter(Boolean) on directories array to remove those?
comment created time in 15 days
push eventgatsbyjs/gatsby
commit sha 78485185e8beec95d47d41f9df37c6f3f8b0241d
feat(query-modules): add support for static queries
commit sha 9cad1a96d90bf02e310b49c34cf8618145d93276
tests(artifacts): add basic cases for query modules
push time in 15 days
issue commentgatsbyjs/gatsby
Unable to extend MarkdownRemark via schema customisation
Hi @JoshuaWalsh
Does the first code snippet actually works properly? This is a bit surprising, unless you have some testfield field in one of frontmatter objects.
Reason for 2nd approach not working is because you are not providing type of the field. GraphQL is strongly typed and schema needs to know what type field "returns". To fix this you would need to make this adjustment:
export function createResolvers({createResolvers}) {
const resolvers = {
MarkdownRemark: {
testfield: {
+ type: `String`,
resolve(source, args, context, info) {
return "test"
},
},
},
}
createResolvers(resolvers);
}
In this case it was String, but if it's other "built-in" type you can use Float, Int, Boolean, ID, JSON or name of one of types that plugins will create.
The third approach is tricky. Right now createTypes for MarkdownRemark can only really be used inside gatsby-transformer-remark (owner of MarkdownRemark type) and site itself (escape hatch for users to be able to "lock down" things like Frontmatter type). I see that you wanted to do this in a plugin, which is right now not supported, so using createResolvers (2nd approach) is the best approach right now.
comment created time in 15 days
push eventgatsbyjs/gatsby
commit sha 92ecaa5afed623ecff1bd01f60a1d66ed52aae7f
feat(query-modules): add support for static queries
commit sha e6ae38d31577d265c98e863478e2c6ecad906722
tests(artifacts): add basic cases for query modules
push time in 16 days
push eventgatsbyjs/gatsby
commit sha 8c287ab033faac6f5baf2ca04ef2d2284ec79b10
feat(dev-loader): retry mechanism with timeout and hmr trigger
commit sha 9993bf26f595c7e00b486d06919082e39156d413
feat(socket-io): run processHotPageDataUpdate if modules changed
push time in 16 days
Pull request review commentgatsbyjs/gatsby
chore(gatsby): expose full structured logs over the develop status websocket server
export default html` ":" + services.developstatusserver.port )- socket.on("develop:started", () => {- window.location.reload()- })+ socket.on("structured-log", msg => {+ if (msg.type !== "LOG_ACTION") return++ if (+ msg.action.type === "SET_STATUS" &&+ msg.action.payload === "SUCCESS"
What should happen if it's not success? (it can be FAILED for multiple reasons - this could some failure when doing webpack compilation, or during query extraction).
Also - we emit this potentially multiple times after starting gatsby develop, so this could mean that each webpack compilation (hot reloads) actually force hard reload I think
comment created time in 16 days
push eventgatsbyjs/gatsby
commit sha 5d1e23c5f7e1651d0c164d352131561748194562
Add link to infra-as-code glossary item (#25724)
commit sha e8ec13b6cec134e70ed2322c22380d17376d76ea
fix(blog): Gatsby Survey - remove local domain, fix 404 (#25102) * fix local domain * apply suggestion Co-authored-by: Nat Alison <[email protected]> * Fix 404 Co-authored-by: Nat Alison <[email protected]>
commit sha c08fa4a6a6a7e8cc7e06ed4e28a8e325fbf96412
feat(gatsby-source-filesystem): allow adjusting `createRemoteFileNode` retry/timeout settings via env vars (#24535) * (gatsby-source-filesystem) Remote File Node env variables For developers with awful internet connection (like me), when using createRemoteFileNode, default timeouts of 30000ms are too short. Out of 300 files, it'd fail 1-4 images due to timeout and mess up the build process. Thus, it would be useful to overwrite default remote file download settings (retry limits and timeouts) with .env variables. For my specific case, just doubling all the values solved all issues. * Update create-remote-file-node.js removed ";"s * updated readme * update Co-authored-by: Michal Piechowiak <[email protected]>
commit sha e95b876545fccaf3647f80496da107ec5baf1acb
chore(www): fix regex in gatsby-config (#25765)
commit sha c82569f68ac233360e1d8d4db428c69149da565a
Add built in slug for gatsby-plugin-mdx (#25767) * initial slug query * initial commit for slug, behavior not ideal * initial commit, not ideal behavior * undo gatsby-dev in packagejson * should be nullable * use relative path from context node instead * use relative path from context node instead * with relative path we don't need to slugify slashes * add whitespace * better naming * add another test case * use resolvable extensions list * add additional tests * fix typo in test * use path for parsing instead * can be const * fix test typos * add minor comment * make some minor changes to remove try/catch Co-authored-by: Laurie Barth <[email protected]>
commit sha ab5f80a1ff8365a00497f41fdcde9cd327ed616e
fix(gatsby-plugin-mdx): Specify new minimum peerDep version for MDX (#25798) We recently began using a new API in MDX with #25437 which doesn't exist for all versions below 1.5.9. This updates the peer dep for MDX to ensure that the new minimum version is specified. Fixes #25691
commit sha e7a984669e600500d21cfed976759fe02914b7a0
Revert "fix(gatsby-plugin-mdx): Specify new minimum peerDep version for MDX (#25798)" (#25800) This reverts commit ab5f80a1ff8365a00497f41fdcde9cd327ed616e. Co-authored-by: John Otander <[email protected]>
commit sha 87267897a6fd6ecc441bdf73e28b59cd1f364294
Fix little typo in sourcing from sanity (#25748)
commit sha 6516360f9f7eedbb6ec04414fd5e2b1839157be0
docs(tutorial-part-zero): remove word "just" (#25688)
commit sha c99270ae8da8103e73e68dd36b9bd675ec62e3c7
fix typo (#25782)
commit sha a62927522d231e1fa7a726d748a8ef3f7db824d9
docs(tutorial-seo-and-social-sharing-cards-tutorial): remove word "just" and "simply" (#25686)
commit sha 06dd84d0d24251feb601161ef9fd02e0f36958fa
dictionary - fix brandname webpack (#25681)
commit sha caa75413a65377ea753c5fe3528e93a8a45267dd
enhancement(docs): dictionary.txt -> with-layout2 -> Remove file name from image alt text and dictionary (#25358) * Remove with-layout2 from alt text and dictionary * Remove yarn.lock changes Co-authored-by: Hassan Abudu <[email protected]>
commit sha 3519e71ee6f94bfbdd936b5a7fa4cab36c970c4d
enhancement(docs): dictionary.txt -> with-navigation2 -> Remove file name from image alt text and dictionary (#25519) * Change alt text for with-navigation.png image * Fix grammatical error * Update all index.md images without proper alt-texts * Update docs/tutorial/part-three/index.md Co-authored-by: Muescha <[email protected]> * add uncentered to dictionary Co-authored-by: Hassan Abudu <[email protected]> Co-authored-by: Marcy Sutton <[email protected]> Co-authored-by: Muescha <[email protected]> Co-authored-by: gatsbybot <[email protected]>
commit sha 067468ac1043be3815683dd76c269f384b317ead
feat(gatsby-source-contentful): Give "Asset" the same Sys fields as "Entry" (#25030)
commit sha 431c9bbb94a2147961dbf70fa79afd7721ca2610
Fix issue with gatsby-plugin-mdx not picking up gatsbyRemarkPlugins. Fixes #21866. (#24194)
commit sha cb282f508f8add7894739ccd9226a704e2b0b115
Switch node definition language to TS and update some text (#25632)
commit sha 2ef310bd5bf523128db2716ebc601c1b06d34828
chore(gatsby): Migrate type-builders to TypeScript (#23892) * chore(gatsby): Migrate type-builders to TypeScript * chore(gatsby): Migrate type-builders to TypeScript Co-authored-by: Blaine Kasten <[email protected]>
commit sha 6d0c791e73ddb832f74023983fdad4a67de76d98
perf(gatsby-plugin-mdx): drop another babel step during sourcing (#25757) This Babel step was used to get exports and remark header but we can use the mdast for this purpose, just like for imports. See PR for perf numbers but they are big.
commit sha 24621bde0b34d89818be108d9dde43931fe25d9f
chore(gatsby): migrate type of filter to TypeScript (#22493) Co-authored-by: Blaine Kasten <[email protected]>
push time in 16 days
issue commentgatsbyjs/gatsby
Also for reference - we generate API reference page from https://github.com/gatsbyjs/gatsby/blob/067468ac1043be3815683dd76c269f384b317ead/packages/gatsby/src/utils/api-node-docs.ts (and this is why createResolvers have params documented and createPages doesn't (because we don't have any @param jsdoc annotations in most of hooks)
comment created time in a month
issue commentgatsbyjs/gatsby
You are right. We have separate page for arguments that are shared in all gatsby-node hooks ( https://www.gatsbyjs.org/docs/node-api-helpers/ ) but we don't reference it in actual gatsby-node API reference page.
It would be cumbersome to give full list of those for each hook, but we should have a note for each hook to check those shred ones + document any hook specific args (like graphql for createPages)
comment created time in a month
issue commentgatsbyjs/gatsby
Why use internal stylesheets over external CSS files?
It's really not something I care about for now, but, it convinced me to ask this question here. According to my knowledge, using a single (or a few) external CSS files for the entire website would be faster, as the browser will have to download it once and for all other pages, the cached CSS file would work, instead of injecting same styles in all HTML pages
Gatsby will load .html content once (first page you navigate to), it will not read those again on subsequent navigation (that happens purely client side). Because of that splitting it to separate css file just doesn't have those usual benefits as Gatsby use custom navigation, but still would have negative of making another network request for critical resource.
AMP uses similar approach where they even disallow external stylesheets (save from font ones) - https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/style_pages/
All of this is to be able to have hydrated site painted in browser as quickly as possible
comment created time in a month
issue commentgatsbyjs/gatsby
gatsby-source-filesystem: create-remote-file-node does not handle retries
Oh, I didn't notice the PR was linked to the issue, re-opening as functionally nothing changed
comment created time in a month
issue commentgatsbyjs/gatsby
styled-component styles are not being shown inside the style tag in Gatsby site
I'm not very knowledgeable about styled-components, but cloning the site and building it produces what looks like valid css:
And the runtime makes use of that but removes the styles tag from <head> tag and then creates different one (with data-style="active") and uses https://drafts.csswg.org/cssom/ to actually inject them (note that dev tools support for CSSOM API is kinda meh, but chrome for example will be improving that as mentioned in https://developers.google.com/web/updates/2020/06/devtools#css-in-js )
Does this cause you actual issues? or weirdness when trying to debug some styling issues?
comment created time in a month
issue commentgatsbyjs/gatsby
Sometimes some fields are missing when querying data.
This sure looks like a bug, but I can't reproduce it (there likely is specific setup that cause issues like that). Does the chrome dev tools screenshot come from gatsby develop runtime? Do you know what curse of action triggers this? Also - can you share your project if this happen regularly there?
Additionally - there are some known problematic plugins that cause problems for hot data updates (like gatsby-plugin-transition-link in https://github.com/gatsbyjs/gatsby/issues/23622 / https://github.com/TylerBarnes/gatsby-plugin-transition-link/issues/131), so this might be similar case here.
comment created time in a month
issue commentgatsbyjs/gatsby
Upgrade eslint to prevent auto-fix from autofilling deps
Are you sure that it's Gatsby that does it? Eslint that comes with gatsby is used for eslint-loader and it doesn't have autofix enabled. I need more details here, because I can't reproduce auto-fixing in my sample project - can you share your setup?
comment created time in a month