profile
viewpoint
Dan Dascalescu dandv Ex-Google, Blueseed, Yahoo! Digital nomad https://dandascalescu.com/ Ex-@google, Yahoo!, @blueseed. Founded the Quantified Self Forum and 3 web startups.

ampproject/amp-by-example 771

DEPRECATED: AMP by Example has been merged into amp.dev

blueseed/presentation-for-startups 1

Blueseed presentation for startups, using the reveal.js framework

dandv/accounts-foursquare 0

An implementation of the Foursquare OAuth flow for Meteor

dandv/accounts-ui-bootstrap-3-with-themes 0

Display issues when comibining ian:accounts-ui-bootstrap-3 with several Bootswatch themes

dandv/acme.sh 0

A pure Unix shell script implementing ACME client protocol

dandv/activity-tracker 0

Activity Tracking App built with Meteor.

dandv/adapter 0

Shim to insulate apps from spec changes and prefix differences. Latest adapter.js release:

dandv/admin 0

Simple and powerful admin generator for meteor

dandv/agenda 0

Lightweight job scheduling for Node.js

dandv/alloy-editor 0

WYSIWYG editor based on CKEditor — with completely rewritten UI

pull request commentwebix-hub/webix

Correct handling of GraphQL errors per spec

@smendoza88: Sadly, yes. I mean, Webix is a surprisingly easy to use and powerful UI library, compared to the complexity of Material UI, for example, but I really, really don't understand XB Software's approach to open source and marketing.

dandv

comment created time in 13 days

startednordicgiant2/awesome-landing-page

started time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha 05ad5895d325c4973d822a8d58488043a30cd0fe

Setup CI via GitHub Actions

view details

Dan Dascalescu

commit sha 8bb0157f1042ce3c6206168f7cf8adf0885d740f

Make Jest ignore .js files

view details

push time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha 780a3657df2c36df03303565d0629ea373228762

Setup CI via GitHub Actions

view details

push time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha 840490d74bd261ab013c671a6704f71099423a9d

Setup CI via GitHub Actions

view details

push time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha 547669f070a48e03eedba850a0082f387716ff2f

Setup CI via GitHub Actions

view details

push time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha d2ef6bdbfe67f435ef340f42570b76962d043fcb

Setup GitHub Actions CI

view details

push time in 16 days

push eventdandv/typescript-modern-project

Dan Dascalescu

commit sha c295730abdce7b36f2e8d436759d155a2c127c2b

Simplify testing: use ts-jest. Update deps.

view details

push time in 16 days

issue commentreact-hook-form/react-hook-form

Checkbox value is string

@bluebill1049 thanks for the link to the Changelog. This is a breaking change though, maybe it should've happened on a minor version (6.1.0), not on the patch version level?

Re. the codesandbox, https://codesandbox.io/s/react-hook-form-with-ui-library-lg33x doesn't include a checkbox demo, and https://codesandbox.io/s/react-hook-form-controller-079xx?file=/src/index.js uses RHF 5. Updating the latter to RHF 6 produces string instead of boolean.

popuguytheparrot

comment created time in 18 days

issue commentreact-hook-form/react-hook-form

Checkbox value is string

@bluebill1049 thanks for the link to the Changelog. This is a breaking change though, maybe it should've happened on a minor version (6.1.0), not on the patch version level?

popuguytheparrot

comment created time in 18 days

startedaarvanet/longevity-events

started time in 19 days

issue commentreact-hook-form/react-hook-form

Checkbox value is string

I've just run into this critical regression too, and it breaks any GraphQL integration that expects strict types. This worked fine in 6.0.0-rec5.

popuguytheparrot

comment created time in 20 days

issue commentmui-org/material-ui

How do I customize components as part of the theme? (border radius, gradients, font family, etc)

Try: https://material-ui-next.com/customization/themes/ specifically: https://material-ui-next.com/customization/themes/#customizing-all-instances-of-a-component-type

I'm also looking for this. I think the current link for the "all instances" use case is now https://material-ui.com/customization/components/#5-global-theme-variation

jordanranson

comment created time in 20 days

issue commentmui-org/material-ui-pickers

Can't resolve '@material-ui/core/Unstable_TrapFocus'

@Jdban: saw this again when updating to alpha10... just npm update @materia-ui/core every time you update the pickers, I guess.

dandv

comment created time in 20 days

issue commentmui-org/material-ui-pickers

Calendar renders in top-left corner with React Hook Form inputRef

Tip: merge the inputRef prop correctly.

Thanks, not sure if I understood the tip right, but I used renderInput={props => <TextField {...props} ref={inputRef} />} instead of renderInput={props => <TextField {...props} inputRef={inputRef} />} and the calendar is placed correctly.

The reason I filed this as a bug is that the inputRef={inputRef} syntax worked with alpha7 and no longer works with alpha10, so I thought it was a regression.

dandv

comment created time in 20 days

issue openedmui-org/material-ui-pickers

docs: @example appears raw

At https://dev.material-ui-pickers.dev/api/DateTimePicker, search for "@example"

image

created time in 20 days

issue openedmui-org/material-ui-pickers

Calendar renders in top-left corner with React Hook Form inputRef

I think I'm running into a regression or new incompatibility with React Hook Form. This sample worked fine with MUI Pickers 4.0.0-alpha7 and MUI 4.9.14, but with MUI 4.11.0 and Pickers alpha 10, the picker is positioned at (0,0) and clicking the calendar icon triggers this error message:

Warning: Failed prop type: Material-UI: The anchorEl prop provided to the component is invalid. It should be an HTML element instance or a referenceObject

  • [x] The issue is present in the latest release.
  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

image

Expected Behavior 🤔

The calendar should render under the Text input, which does happen if the inputRef prop is not passed to the <Text>.

Steps to Reproduce 🕹

Click the calendar icon in the Code sandbox.

created time in 21 days

issue closedmui-org/material-ui-pickers

Property 'lib' is missing in type 'DateFnsUtils' but required in type 'IUtils<unknown>'

The TypeScript error happens after updating from alpha7 to alpha10. I have date-fns 2.15.0 installed.

  • [x] The issue is present in the latest release.
  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

TS2322: Type 'typeof DateFnsUtils' is not assignable to type 'new (...args: any) => MuiPickersAdapter<unknown>'.   Property 'lib' is missing in type 'DateFnsUtils' but required in type 'IUtils<unknown>'. IUtils.d.ts(70, 3): 'lib' is declared here. LocalizationProvider.d.ts(6, 5): The expected type comes from property 'dateAdapter' which is declared here on type 'IntrinsicAttributes & LocalizationProviderProps & { children?: ReactNode; }'

Expected Behavior 🤔

No TS error.

Steps to Reproduce 🕹

https://codesandbox.io/s/mui-datetimepicker-dateadapter-typescript-error-murff

The code that produces the error is below:

import React, { ReactElement } from 'react';
import { TextField } from '@material-ui/core';
import { DateTimePicker, LocalizationProvider } from '@material-ui/pickers';
import DateFnsUtils from '@material-ui/pickers/adapter/date-fns';

export default function Foo(): ReactElement {
  return (
    <LocalizationProvider dateAdapter={DateFnsUtils}>
      <DateTimePicker
        renderInput={props =>
          <TextField/>
        }
        onChange={() => null}
        value=""
      />
    </LocalizationProvider>
  );
}

Your Environment 🌎

<!-- Include as many relevant details about the environment with which you experienced the bug. If you encounter issues with typescript please include version and tsconfig. -->

Tech Version
@material-ui/core v4.11.0
@material-ui/pickers v4.0.0-alpha10
React 16.13.1
TypeScript 3.9.5

tsconfig:

{
  "compilerOptions": {
    "target": "es2019",
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": false,
    "sourceMap": true
    "resolveJsonModule": true,
    "lib": ["DOM"],
    "jsx": "react",
    "noEmit": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "types": ["cypress"]
  }
}

closed time in 21 days

dandv

issue commentmui-org/material-ui-pickers

Property 'lib' is missing in type 'DateFnsUtils' but required in type 'IUtils<unknown>'

Thanks @dmtrKovalenko, that fixed the issue.

Now I'm running into a different one in my React Hooks Form integration: the calendar popup gets rendered at (0, 0) and the console shows this error message:

index.js:2177 Warning: Failed prop type: Material-UI: The anchorEl prop provided to the component is invalid. It should be an HTML element instance or a referenceObject

It's caused by passing the inputRef to the TextField.

I'll work on creating a minimal CodeSanbox, but hoped maybe you knew of a similar quick fix.

const inputRef = useRef<HTMLInputElement>();
<LocalizationProvider dateAdapter={DateFnsUtils}>
        <Controller {...{ name, control }}
          defaultValue={null}
          as={
            <DateTimePicker
              disablePast
              renderInput={props =>
                <TextField {...props} {...{ label, inputRef }} />
              }
              onChange={() => null}
              value=""  // RHF controls controls it via defaultValue - ^
            />
          }
        />
</LocalizationProvider>
dandv

comment created time in 21 days

issue openedpwa-builder/pwa-features

TypeError: navigator.share is not a function

When clicking the Share button in Firefox 78 at https://components.pwabuilder.com/component/install_pwa, I get that that error.

created time in 21 days

issue openedmui-org/material-ui-pickers

Property 'lib' is missing in type 'DateFnsUtils' but required in type 'IUtils<unknown>'

The TypeScript error happens after updating from alpha7 to alpha10. I have date-fns 2.15.0 installed.

  • [x] The issue is present in the latest release.
  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

TS2322: Type 'typeof DateFnsUtils' is not assignable to type 'new (...args: any) => MuiPickersAdapter<unknown>'.   Property 'lib' is missing in type 'DateFnsUtils' but required in type 'IUtils<unknown>'. IUtils.d.ts(70, 3): 'lib' is declared here. LocalizationProvider.d.ts(6, 5): The expected type comes from property 'dateAdapter' which is declared here on type 'IntrinsicAttributes & LocalizationProviderProps & { children?: ReactNode; }'

Expected Behavior 🤔

No TS error.

Steps to Reproduce 🕹

The code that produces the error is below:

import React, { ReactElement } from 'react';
import { TextField } from '@material-ui/core';
import { DateTimePicker, LocalizationProvider } from '@material-ui/pickers';
import DateFnsUtils from '@material-ui/pickers/adapter/date-fns';

export default function Foo(): ReactElement {
  return (
    <LocalizationProvider dateAdapter={DateFnsUtils}>
      <DateTimePicker
        renderInput={props =>
          <TextField/>
        }
        onChange={() => null}
        value=""
      />
    </LocalizationProvider>
  );
}

Your Environment 🌎

<!-- Include as many relevant details about the environment with which you experienced the bug. If you encounter issues with typescript please include version and tsconfig. -->

Tech Version
@material-ui/core v4.11.0
@material-ui/pickers v4.0.0-alpha10
React 16.13.1
TypeScript 3.9.5

tsconfig:

{
  "compilerOptions": {
    "target": "es2019",
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": false,
    "sourceMap": true
    "resolveJsonModule": true,
    "lib": ["DOM"],
    "jsx": "react",
    "noEmit": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "types": ["cypress"]
  }
}

created time in 21 days

PR opened mui-org/material-ui-pickers

autoOk was removed

Not sure when autoOk was removed, but I've just updated to the latest alpha10 from alpha7, and TypeScript flagged the property as an error.

If it wasn't removed, please disregard the PR. I no longer see autoOk at https://dev.material-ui-pickers.dev/api/DateTimePicker though.

+1 -1

0 comment

1 changed file

pr created time in 21 days

push eventdandv/material-ui-pickers

Dan Dascalescu

commit sha be65afbefcbe1ecb20a43c0bf00e09757857d881

autoOk was removed

view details

push time in 21 days

issue openedmicrosoftgraph/microsoft-graph-toolkit

[BUG] Wrong description for mgt-login on PWA Builder

Describe the bug At https://components.pwabuilder.com/component/graph_login, the description seems to be a copy/paste error from https://components.pwabuilder.com/component/install_pwa

A simple component that gives users a button to install your PWA directly from the browser

created time in 22 days

issue openedGoogleChromeLabs/bubblewrap

Clarify the keystore usage

Is your feature request related to a problem? Please describe. For web developers unfamiliar with android, the keystore may be confusing.

Describe the solution you'd like While running bubblewrap build,

? Password for the Key Store

can be interpreted as both "What is the password for the keystore", and "Set a password for the keystore"

Same for

? Password for the Key:

The previous prompts are ambiguous as well. I ended up creating a directory ("store"):

? Key store location: ./android.keystore ? Key name: ./android.keystore

Then I got this error,

Failed to load signer "signer #1" java.io.FileNotFoundException: ./android.keystore (Is a directory)

Describe alternatives you've considered PWABuilder?

Additional context Ideally, a web dev who's never touched Android development, should be able to build a TWA from their PWA.

created time in 22 days

issue openedshoelace-style/shoelace

Incremental search /autocomplete in Select

Is your feature request related to a problem? Please describe. I'm looking for incremental search for tags input.

Describe the solution you'd like For inspiration, autocomplete in Evergreen and Fluent UI.

Describe alternatives you've considered https://shoelace.style/components/select?id=help-text seems to focus on the option that starts with the typed character, but the search appears to stop there.

created time in 22 days

issue openedshoelace-style/shoelace

Clearable tag example appears to not work

Describe the bug I'm clicking the x icons on the the three tags, but they don't go away.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://shoelace.style/components/tag?id=clearable
  2. Click on the x in Small x.
  3. The tag doesn't disappear/clear.

Desktop (please complete the following information):

  • OS: Ubuntu 20
  • Browser Chrome 84

created time in 22 days

issue openedjitsi/jitsi-meet

Warning sign for insecure meeting name has no tooltip on self-hosted instance

Description:

The warning icon for insecure meeting names has no tooltip. On an intranet server, where there was no concern for bombings, I entered a short meeting name and started the meeting. I didn't realize why I was seeing the warning icon in the upper right corner.

Steps to reproduce:

  1. Navigate to your self-hosted Jitsi Meet instance
  2. Enter a short meeting name
  3. Start the meeting

Expected behavior:

The warning icon in the upper-right corner should have a tooltip explaining what the warning is about.

Actual behavior:

No tooltip.

image

Server information:

  • Jitsi Meet version: 2.0.4627-1
  • Operating System: Ubuntu Linux 20.

Client information:

  • Browser / app version: Chrome 84

Additional information:

Bug is not reproducible at https://meet.jit.si/.

created time in 25 days

push eventdandv/bubblewrap

Dan Dascalescu

commit sha 9bdff06e7964b189b23a763a01171ad40b33ec7b

Typo fix when asking for the key store

view details

push time in 25 days

PR opened GoogleChromeLabs/bubblewrap

OpenJDK contains lib, but not com

This is the contents of the JDK I've just downloaded:

image

+2 -2

0 comment

1 changed file

pr created time in 25 days

push eventdandv/bubblewrap

Dan Dascalescu

commit sha 94a39b538f65082a4edab19116e7f74da34b4157

OpenJDK contains lib, but not com

view details

push time in 25 days

fork dandv/bubblewrap

Bubblewrap is a Command Line Interface (CLI) that helps developers to create a Project for an Android application that launches an existing Progressive Web App (PWAs) using a Trusted Web Activity.

fork in 25 days

issue commentgatsbyjs/gatsby

Output stack traces for Webpack errors during build

Confirming the fix in v2.24.3. Thanks!

dandv

comment created time in a month

pull request commentepilande/gatsby-theme-auth0

Only call checkSession if the token has expired

Any thoughts on this @epilande ?

dandv

comment created time in a month

issue openedgatsbyjs/gatsby

Document createPages formally

Summary

The documentation for createPages does not specify the parameters that createPages receives. Some of those parameters are glossed over in the example (actions), and some are omitted (reporter).

Since this is an API reference page (rather than the corresponding guide), I think the parameters should be comprehensively listed and documented.

Motivation

My particular motivation was to drill into the documentation for the graphql parameter and see if there was any way I could pass a context, in order to make authenticated GraphQL queries from gatsby-node. I couldn't figure out where the documentation for the graphql instance lives.

On the same page, createResolvers has a proper list of parameters.

created time in a month

issue openedHenryNugraha/Window-List-Hotkey

Archive repo?

Now that Cinnamon supports this out of the box, and given the repo hasn't been maintained since 2015, it might make sense to archive it.

created time in a month

issue openedagenda/agendash

Show the exact time in a tooltip

Human-friendly times are fine, but I would like to see exactly what time a give job will run at. "In a day" doesn't tell me much.

image

The absolute time value could be displayed in a tooltip. This would also solve #1.

created time in a month

issue closedagenda/agendash

No UI elements to create a new job

I use agandash as middleware and no UI-elements seen to create a new job.

in package.json stated: "agenda": ">=0.7.0 <1.0.0", could this be an issue? my app uses agenda-1.0.0

closed time in a month

vak

issue commentagenda/agendash

No UI elements to create a new job

This has been implemented:

image

Result:

image

The <kbd>Cancel</kbd> button closes the form and doesn't create any job.

vak

comment created time in a month

issue commenttypegoose/typegoose

Documentation not properly indexed?

Happy to test when it gets deployed.

dandv

comment created time in a month

issue commentdraftbit/twitter-lite

Retry on timeout?

No, but the logic is pretty simple - you want to retry up to MAX_RETRIES times in case of certain types of errors, and sleep in between retries:

for (let i = 0; i < MAX_RETRIES; i++) {
  try {
    const result = await twitter.method(...);
    break;  // success; exit the retry loop
  } catch (error) {
    console.warn(`Twitter API error try ${i} / ${twitter.RETRIES}:`, error);
    // can also look at the error code here, and abort on unrecoverable errors
  }
  await sleep(SLEEP_BETWEEN_RETRIES);
}
GeoffreyPlitt

comment created time in a month

issue commentwhitecolor/ts-node-dev

1.0.0-pre.51 seems to break something

@whitecolor: can you take a look at the PR to fix that, #106?

DMCTowns

comment created time in a month

issue openedwhitecolor/ts-node-dev

Regression: JSON modules no longer loaded between .50 and .51

I have a script that imports a JSON file from outside rootDir (import * as packageJson from '../package.json';) using this pattern of having declare module '*.json'; in../package.json`.

That worked with ts-node-dev@1.0.0-pre.50, but fails with ts-node-dev@1.0.0-pre.51 with the following error:

error TS2732: Cannot find module '../package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension 2 import * as packageJson from '../package.json';

Setting "resolveJsonModule": true in tsconfig.json is not an option, because tsc fails in that case.

created time in a month

issue openedjitsi/handbook

Typo in FAQ

Not sure if this is the right repo, but I couldn't find one for the website.

At https://jitsi.org/user-faq/, under "What are the features...", there's a typo:

Play a YouTube video to all attendees call

Also, under the 2nd FAQ, "What are the major Jitsi projects", is Jitsi Videobridge included in Jitsi Meet? I'm not really new to Jitsi any more, but I still don't understand this :-/

created time in a month

PR opened jitsi/jitsi-meet

Fix typo

fieds -> fields

+1 -1

0 comment

1 changed file

pr created time in a month

push eventdandv/jitsi-meet

Dan Dascalescu

commit sha 32a5879bb5e6da5ac0284c41805fe490a5fac44d

Fix typo

view details

push time in a month

issue commentdraftbit/twitter-lite

Id overflow in 'followers/ids' Endpoint

Have you read the README section about numeric vs string IDs?

If you can still reproduce the problem, please add a test case like this.

amiralitaheri

comment created time in a month

issue commentairbnb/lunar

OT: Airbnb reviews collapse whitespace

Hi @lencioni,

Wanted to report another bug (notifications impossible to dismiss), and thought I'd check on this issue first. The link in my OP is gone, but I still see the issue here.

dandv

comment created time in a month

issue commentdraftbit/twitter-lite

Reconncting stream after 30 secs results in "420 Enhance your calm" error

I suspect this might be a problem with Twitter. Have you checked if users of libraries for other languages have run into this?

karthik947

comment created time in a month

issue openedzachwinter/kaleidosync

Can't get it to sync to beats

I'm playing Queen - We Will Rock You, which has some obvious beats, but the animations don't seem to be in sync. What am I doing wrong? I was expecting more pulsing, I guess.

created time in a month

issue openednjm222/Spotify_Visualizer

Can't get it to sync to beats

I'm playing Queen - We Will Rock You, which has some obvious beats, but the animations aren't in sync. I've granted microphone permission... what am I doing wrong?

created time in a month

issue commentspatie/twitter-streaming-api

Connection keeps failing once a day

https://github.com/draftbit/twitter-lite/issues/59#issuecomment-653723553 - we see this with Node and .NET

JPeterson2015

comment created time in a month

issue commentfennb/phirehose

Connection keeps failing once a day

We're seeing the stream stall with Node and . NET. Might be a Twitter issue.

https://github.com/draftbit/twitter-lite/issues/59#issuecomment-653723553

JPeterson2015

comment created time in a month

issue commentttezel/twit

Does this still work?

No updates in 2+ years. Use at your own risk, or see #528.

AdityaAnand1

comment created time in a month

issue commenttypegoose/typegoose

Support for props in custom validators

Sure, my too, but as a minimal template for people who want to report a bug

On Thu, Jul 2, 2020, 04:08 hasezoey notifications@github.com wrote:

sorry i rather run it locally

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/typegoose/typegoose/issues/314#issuecomment-652942237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGILQC7RHYNGBMWTAFG3RZRTCZANCNFSM4OOVZAIQ .

dandv

comment created time in a month

issue commenttypegoose/typegoose

Support for props in custom validators

Thanks for the quick fix!

BTW what do you think of using that Code sandbox as a template (you may want to tweak it) for the code example in issues? It has the MongoDB connection already setup to a free mLab account. Code sandbox runs Node 10 though, not sure if that's a problem.

dandv

comment created time in a month

issue openedtypegoose/typegoose

Support for props in custom validators

Which feature

  • Custom validators accept props in the message, to display the invalidat value:

    message: props => ${props.value} is not a valid phone number!

Code Examples

https://codesandbox.io/s/typegoose-starter-9yzrk?file=/src/index.ts

Additional Notes

Works, but there's a type error

Types of property 'message' are incompatible. Type '(props: any) => string' is not assignable to type 'string'.

created time in a month

issue commentcodesandbox/codesandbox-client

Ability to hide the preview browser

Sorry, but I don't see any button to hide the browser. Has it been moved?

image

aaronshaf

comment created time in a month

fork dandv/distributions

NodeSource Node.js Binary Distributions

fork in a month

PR opened typegoose/typegoose

Spell check

Thanks for all the work on Typegoose!

PS: maybe setting the browser's spell check language to English would be a good idea?

+1 -1

0 comment

1 changed file

pr created time in a month

push eventdandv/typegoose

Dan Dascalescu

commit sha a7f7804dcedca59dd7f953f1613ee68f84b5617c

Spell check

view details

push time in a month

issue openedtypegoose/typegoose

_id field should not accept 'unique' prop

Versions

  • NodeJS: 13.x
  • Typegoose(NPM): 7.2.0
  • mongoose: 5.9.20

What is the Problem?

Passing unique to the _id field generates this warning message:

mongoose: Cannot specify a custom index on _id for model name "Discussion", MongoDB does not allow overwriting the default _id index. See http://bit.ly/mongodb-id-index

Code Example

@prop({ unique: true, default: nanoid, maxlength: 100, trim: true, validate: validName })

created time in a month

issue openedfirsttris/vscode-jest-runner

Comparison with the other Jest extension for VS Code

Hi, I'm new to Jest in VS Code. How is this extension different from https://github.com/jest-community/vscode-jest ?

I see the README has "The Aim", which looks like tribute to the other extension, so it would be good to explain how this one is different, so devs can make an informed choice between the two.

Maybe that will get it more popularity as well (only 51 repo stars vs. ~1900 for @jest-community's extension.

created time in a month

issue commentreact-hook-form/react-hook-form

Lagging field states in formState demo

I can confirm that dirtyFields is an object in v6. What about the other issues?

dandv

comment created time in a month

issue commentreact-hook-form/react-hook-form

Lagging field states in formState demo

Sorry for talking about two different problems in one issue. I filed a separate Discussion for the isDirty issue, https://github.com/react-hook-form/react-hook-form/discussions/2004. This is only a bug report now.

dirty Set to true after a user interacted with any of the input

I'm talking about v6, so dirty was replaced by isDirty. Also, as noted in my recent PR, isDirty set to true after any input has been modified, not just interacted with - that's what I see by using the component, is that intended?

Anyway, here is a screencast reproducing the bug I've mentioned, by following exactly steps 1 through 5:

dirtyFields stays empty

You can see that dirtyFields stays empty.

Anyway, that demo uses v5, so maybe these bugs have been solved in v6.

dandv

comment created time in a month

issue openedreact-hook-form/react-hook-form

Lagging field states in formState demo

Describe the bug In the formState codesandbox, I've noticed that the field state displayed at the bottom of the form lags one click behind the user's actions.

Is this because that demo uses v5? The code also mentions to check the console for dirtyFields being a set.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/7o2wrp86k6?file=/src/index.js
  2. Click inside 'First name'
  3. "Touched" should include "First name", but is empty.
  4. Type "bill"
  5. dirtyFields is empty, but should include "First name"

Codesandbox link (Required) https://codesandbox.io/s/7o2wrp86k6?file=/src/index.js

created time in a month

issue openedmui-org/material-ui

Example for menu item being a link

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Another one of my simple/stupid questions :) How do I create a menu item that links to another page?

(My particular use case involves a gatsby-theme-material-ui link, but this is a general question).

Motivation 🔦

I'm trying to simply navigate to a route and close the menu on click. Is there a more direct way than defining a handler?

There's been an extensive discussion about this at https://github.com/mui-org/material-ui/issues/204, which suggests it's a very common request. The discussion started in 2015 and refers to v0.x, so I'm not sure what the current solution is. I think it would be great to have a demo of this on the menu page.

created time in a month

issue commentfabiospampinato/html-entities-decode

Comparison with existing packages

Ok, that's interesting, a bunch of people were concerned about the bundle size of he, and entities has a performance comparison.

dandv

comment created time in a month

issue openedfabiospampinato/entities-decode

Comparison with existing package, including your other one

https://github.com/fabiospampinato/html-entities-decode/issues/1

created time in a month

issue openedfabiospampinato/html-entities-decode

Comparison with existing packages

Hi, how is this package different form established (millions of weekly downloads) HTML entity decoding packages on NPM?

If it's just a test package that should not be in NPM, that's fine, but it pollutes the search space. Maybe scope or unpublish it?

created time in a month

issue openedgpawlik/decode-html-entities

Add description?

There are lots of established entity decoding packages. How is this one different?

If it's just a test package, that's fine, but it pollutes the search space for "html entities decode" on NPM/

created time in a month

issue commentmathiasbynens/he

Modular usage

@mdevils' html-entities library is a little smaller, about as popular in terms of NPM weekly downloads, and more recently updated.

shrpne

comment created time in a month

issue openedmdevils/html-entities

Comparison with exiting library

Hi, thanks for publishing this library!

How does it compare with @mathiasbynens's he library, which is more popular on GitHub and NPM?

created time in a month

issue commentmui-org/material-ui-pickers

Lack of AM/PM indicator for 24-hour DateTime picker

@oliviertassinari: for the same reason as in this case. Didn't see an argument against that, so I continued using it.

dandv

comment created time in a month

issue commentmui-org/material-ui-pickers

Lack of AM/PM indicator for 24-hour DateTime picker

@oliviertassinari: it's a desktop app. The audience is exclusively from the US, maybe that's why?

dandv

comment created time in a month

issue commentmui-org/material-ui-pickers

Lack of AM/PM indicator for 24-hour DateTime picker

So far, about 2 thirds of the people I've had use that control, missed seeing the AM/PM, which resulted in it defaulting to whatever half of the day it was when they used it.

dandv

comment created time in a month

issue commentepilande/gatsby-theme-auth0

Question: is the useAuth hook expensive?

@devuxer: I've confirmed the expensive calls from useAuth() by testing this PR. See the two screenshots.

devuxer

comment created time in a month

PR opened epilande/gatsby-theme-auth0

Only call checkSession if the token has expired

This small change addresses #150 by not calling checkSession() unnecessarily.

Before

checkSession() called from every useAuth(). Led to #150. In a typical Gatsby app, this led to many requests to Auth0 from every page:

image

After

checkSession() only called after the token has expired. Same app with the same navigation pattern (3 clicks/pages):

image

Potential drawbacks

The only drawback I can imagine is that if the user's token is revoked, they'll still be able to access client-side information they had access to, until the token expires (2 hours by default with Auth0, I think). However, server-side security would reject the invalidated JWT.

Notes

I've remove the try/catch from that block, as I'm not sure when it the catch would ever occur. setUser() wouldn't trigger is, and auth.getUserProfile(); simply accesses this.userProfile;.

+6 -7

0 comment

1 changed file

pr created time in a month

push eventdandv/gatsby-theme-auth0

Dan Dascalescu

commit sha 471461b776b28bb658d38f87b52da7a10f513e7a

Remove console.log() showing proper (rare) calls

view details

push time in a month

push eventdandv/gatsby-theme-auth0

Dan Dascalescu

commit sha dc7f28ddd32626cf6e6e63904bb04f21d8fad0a6

Don't checkSession() until the token has expired

view details

push time in a month

issue commentepilande/gatsby-theme-auth0

Question: is the useAuth hook expensive?

Turns out that useAuth() is actually pretty expensive: every single time it's called, it will call Auth0's checkSession() method from an effect. This generates network requests, and has another drawback: it makes it impossible to automate testing of authenticated pages in your app with tools like Cypress. Testing those is done by getting a JWT programmatically from Auth0, then storing that in localStorage. But while the code in useAuth() does return the token and isLoggedIn from localStorage first, it then calls checkSession in that useEffect, which will fail, and will delete isLoggedIn, effectively logging the user out.

devuxer

comment created time in a month

issue openedepilande/gatsby-theme-auth0

Impossible to automate testing

I've trying with Cypress to test a Gatsby using this theme. After getting a JWT programmatically from Auth0, I'm storing storing that in localStorage per this Cypress recipe.

Initially, { isLoggedIn } = useAuth() returns true correctly because it looks in localStorage, but after that, the useEffect in useAuth() calls checkSession, which will fail, and will delete isLoggedIn, effectively logging the user out.

created time in a month

issue commentcypress-io/cypress-example-recipes

Auth0 recipe?

Hi @kevinold, I'm using what I think is a pretty common setup, a React SPA that allows Auth0 login with user/pass + social connections, and accesses an API written in Node.js and secured using JWTs.

dandv

comment created time in a month

push eventdandv/date-fns

Dan Dascalescu

commit sha 7566d5ea70fce2d359398e9f16656cecf26bef66

Fix the typo

view details

push time in a month

issue openedtypegoose/typegoose

findByIdAndDelete doesn't return the correct TypeScript type

Versions

  • NodeJS: 13.x
  • Typegoose(NPM): 7.2.0
  • mongoose: 5.9.20

What is the problem?

const doc = await PersonModel.findByIdAndDelete(id) does not return the correct DocumentType, while const doc await PersonModel.findOneAndDelete({ _id: id }) does. In the first case, doc.name will generate a TypeScript error that

TS2339: Property 'name' does not exist on type 'FindAndModifyWriteOpResultObject >'

created time in a month

issue commentreact-hook-form/react-hook-form

Skip validations if a field is not required

image

The tooltip for that label should be "Waiting for more upvotes"?

dandv

comment created time in a month

delete branch dandv/react-hook-form-website

delete branch : patch-3

delete time in a month

delete branch dandv/react-hook-form-website

delete branch : dandv-english

delete time in a month

pull request commentreact-hook-form/documentation

Improve English in formState

Not sure how to do that from the GitHub UI... maybe it's easy for the repo owner as described here ?

dandv

comment created time in a month

PR opened react-hook-form/documentation

Improve English in formState

Notable changes:

  • fixed dirty to isDirty

  • dirtyFields is an object, not a set. This needs to be changed somewhere in the code to match. Right now I see image but tests show image

  • As far as I could tell, isDirty is true if the user modified any of the fields, not just interacted with one

+7 -7

0 comment

1 changed file

pr created time in a month

push eventdandv/react-hook-form-website

Dan Dascalescu

commit sha 89f6ff9c6dec8b8ea94fb3701684ed22044a9e7b

The correct name for formState.dirty is isDirty

view details

push time in a month

issue commentreact-hook-form/documentation

setError needs update?

Thanks! BTW, "MULTIPLE ERROR" should have an S at the end

dandv

comment created time in a month

issue commentreact-hook-form/documentation

Add link to "Edit this page on GitHub"

@pmaier983: that footer links points to the repo, but we can do better: have a much more easily visible link that points to the specific file in the repo that corresponds to the page the user sees. Right now, the user still has to hunt in the repo for the corresponding file.

See how https://mongoosejs.com/docs/schematypes.html implemented my suggestion for example.

dandv

comment created time in a month

issue openedreact-hook-form/documentation

setError needs update?

  1. rc5 removed the multiple error call convention, but the example at https://react-hook-form.com/api#setError calls setError("username", "notMatch", "please choose a different username");

  2. The release notes for rc5 have some typos, setErrror, and missing ' after test.

created time in a month

issue commentreact-hook-form/documentation

🌐 We need your help on translation.

We can help developers by translating (I know Romanian for example), but that's giving someone a fish instead of teaching them to fish.

Learning English is the best investment a developer can make.

bluebill1049

comment created time in a month

push eventdandv/react-hook-form-website

Dan Dascalescu

commit sha c0c6416f50c5a4e9491695070ecaa6006cc526c5

Improve English in formState

view details

push time in a month

issue commentjitsi/jitsi-meet

Clarify which Chrome extension this setting is referring to

I think that's the right place for the full Jitsi docs including the self-hosting instructions?

Agree, but on the other hand, https://github.com/jitsi/jitsi-meet/blob/master/config.js is thoroughly commented inline, probably for good reasons. Do those apply to interface_config.js?

dandv

comment created time in a month

more