profile
viewpoint
Paul Miller paulmillr @hy-dev Europe https://paulmillr.com Markets, cryptography, infosec.

paulmillr/chokidar 6924

An efficient wrapper around node.js fs.watch / fs.watchFile / FSEvents

paulmillr/es6-shim 2996

ECMAScript 6 compatibility shims for legacy JS engines

paulmillr/dotfiles 963

Colourful & robust configuration files and utilities for Mac, Linux and BSD

paulmillr/exoskeleton 893

Faster and leaner Backbone for your HTML5 apps

kimmobrunfeldt/chokidar-cli 548

Fast cross-platform cli utility to watch file system changes

paulmillr/console-polyfill 439

Browser console methods polyfill.

fsevents/fsevents 436

Native access to MacOS FSEvents in Node.js

paulmillr/brunch-with-chaplin 286

Boilerplate application for Brunch with Chaplin framework included.

micromatch/anymatch 265

:bangbang: Matches strings against configurable strings, globs, regular expressions, and/or functions

paulmillr/code-style-guides 164

Idiomatic, widely-used code style guides for various programming languages.

delete branch brunch/deppack

delete branch : ignore-case

delete time in a day

issue commentpaulmillr/chokidar

Files are not watched if we once unwatch it and then again want to watch it

Can you create a test repo that reproduces the case? If this was common, it would have been reported before.

Myasir92

comment created time in a day

issue commentpaulmillr/chokidar

Files are not watched if we once unwatch it and then again want to watch it

chok version? node version? os version?

Myasir92

comment created time in 2 days

created tagpaulmillr/chokidar

tag3.4.2

An efficient wrapper around node.js fs.watch / fs.watchFile / FSEvents

created time in 3 days

push eventpaulmillr/chokidar

Paul Miller

commit sha 95faa2fe42d1736b3c5bfbc0f17a9f0379b001f3

Release 3.4.2.

view details

push time in 3 days

issue closedpaulmillr/chokidar

node 12.3.1 upath

Describe the bug

yarn install v1.17.3 [1/5] 🔍 Validating package.json... [2/5] 🔍 Resolving packages... [3/5] 🚚 Fetching packages... error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9". Got "12.3.1" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

closed time in 4 days

McFlat

push eventpaulmillr/chokidar

whyboris

commit sha 6fb0d1f2a426f8cddc034e8feb0b389e41a2551d

handle SLASH_SLASH at beginning of network path

view details

Paul Miller

commit sha 5452e4f2bc09f58e24f738f1ff74f0bd2b6b12dc

Merge pull request #1025 from whyboris/network-watching-fix handle network path `//server` correctly

view details

push time in 5 days

PR merged paulmillr/chokidar

handle network path `//server` correctly

In current master branch, chokidar fails to recognize paths starting with // or \\ for example:

//StoragePC/DrivePool/movies is a valid network path, but toUnix method would replace // with / making the path invalid.

More details: https://github.com/paulmillr/chokidar/issues/895#issuecomment-660518084

Closes #895

Tested with my app. PR successfully resolves the problem: https://github.com/whyboris/Video-Hub-App/issues/456#issuecomment-664038303

Unit test results unchanged from master:

  192 passing (1m)
  12 pending
  1 failing     <-- should emit `unlinkDir` and `add` when dir is replaced by file:

please let me know if you prefer the constant name to be DOUBLE_SLASH instead of SLASH_SLASH 👍

+11 -1

0 comment

3 changed files

whyboris

pr closed time in 5 days

issue closedpaulmillr/chokidar

Watching network drive '\\server\folder' does not work

Hi I have a problem where chokidar does not report changes to network shared folder, i.e. \\\\file.server.net\\dev\\7500. Using fs.writeFile() on that folder works fine and a file gets created by Node. I'm under Win10. My config is below. I tried both with usePolling true and false, no change. I don't get any errors, just changes to network folder don't get reported. Watching a folder on local drive C:\db works fine. Watching that network drive using drive letter path format actually works too s:\\dev\\7500. I'd prefer to use server path notation in case drive mapping letters get changed in future, or some users in the company have different letters mapped.

Do you see anything amiss in my setup?

fs.writeFile('\\\\file.server.net\\dev\\7500\\test.txt', 'this file gets created OK', (err) => {
  if (err) throw err
})

const chokidarOptions = {
  persistent: true,
  // ignored: "*.txt",
  ignoreInitial: false,
  followSymlinks: true,
  cwd: ".", 
  disableGlobbing: false,
  usePolling: true, // tried with false as well
  interval: 1000,
  binaryInterval: 3000,
  alwaysStat: false,
  depth: 99,
  awaitWriteFinish: {
    stabilityThreshold: 2000,
    pollInterval: 100,
  },
  ignorePermissionErrors: true, // watch files that don't have read permissions
  atomic: true, // or a custom 'atomicity delay', in milliseconds (default 100)
};

const optionsFileMonitor = {
  watchFolders: ["\\\\file.server.net\\dev\\7500", "s:\\dev\\7500", "C:/db"]
};

const fileMonitor = chokidar
  .watch(optionsFileMonitor.watchFolders, chokidarOptions)
  .on("all", (event, epath) => {
    console.log(event, path.resolve(epath));
})

closed time in 5 days

Zireael

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

Ping folks. Let's get this in! 😃

paulmillr

comment created time in 7 days

issue commentpaulmillr/chokidar

Watching network drive '\\server\folder' does not work

@whyboris try doing this and see if tests fail on any platform

Zireael

comment created time in 8 days

issue closedpaulmillr/chokidar

Only build FSEvents when using MacOS

Describe the bug

NPM and Yarn log a warning message saying that the FSEvents build was skipped when running on Linux and Windows machines (this is a duplicate of #460). This is expected.

Ideally, though, chokidar would be smart enough to avoid this warning (when it is expected) by only installing and building FSEvents when the user is on MacOS.

Versions (please complete the following information):

  • Chokidar version: 2.1.8
  • Node version: 14.7.0
  • OS version: Ubuntu 18.04.2

To Reproduce:

  1. Get Linux or Windows machine.
  2. Install chokidar using Yarn v2 (or NPM, the warning should still be there).
  3. See warning message:
$ yarn install
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 0.52s
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0.99s
➤ YN0000: ┌ Link step
➤ YN0062: │ fsevents@patch:fsevents@npm%3A2.1.3#builtin<compat/fsevents>::version=2.1.3&hash=495457 The platform linux is incompatible with this module, building skipped.
➤ YN0062: │ fsevents@patch:fsevents@npm%3A1.2.13#builtin<compat/fsevents>::version=1.2.13&hash=495457 The platform linux is incompatible with this module, building skipped.
➤ YN0000: └ Completed in 1.97s
➤ YN0000: Done with warnings in 3.71s

Expected behavior

FSEvents should only be installed, built, and used when the user is on MacOS (thus avoiding this warning to begin with).

closed time in 8 days

nicholaschiang

issue commentpaulmillr/chokidar

Only build FSEvents when using MacOS

I don't see a way to solve this in chokidar. Report this to NPM or Yarn. We specify supported platforms in fsevents package.json, these bundlers should understand this.

nicholaschiang

comment created time in 8 days

PR closed paulmillr/chokidar

Bump mocha from 7.2.0 to 8.1.0 dependencies

Bumps mocha from 7.2.0 to 8.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/releases">mocha's releases</a>.</em></p> <blockquote> <h2>v8.1.0</h2> <h1>8.1.0 / 2020-07-30</h1> <p>In this release, Mocha now builds its browser bundle with Rollup and Babel, which will provide the project's codebase more flexibility and consistency.</p> <p>While we've been diligent about backwards compatibility, it's <em>possible</em> consumers of the browser bundle will encounter differences (other than an increase in the bundle size). If you <em>do</em> encounter an issue with the build, please <a href="https://github.com/mochajs/mocha/issues/new?labels=unconfirmed-bug&template=bug_report.md&title=">report it here</a>.</p> <p>This release <strong>does not</strong> drop support for IE11.</p> <p>Other community contributions came from <a href="https://github.com/Devjeel"><strong>@Devjeel</strong></a>, <a href="https://github.com/Harsha509"><strong>@Harsha509</strong></a> and <a href="https://github.com/sharath2106"><strong>@sharath2106</strong></a>. <em>Thank you</em> to everyone who contributed to this release!</p> <blockquote> <p>Do you read Korean? See <a href="https://blog.outsider.ne.kr/1489">this guide to running parallel tests in Mocha</a>, translated by our maintainer, <a href="https://github.com/outsideris"><strong>@outsideris</strong></a>.</p> </blockquote> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4287">#4287</a>: Use background colors with inline diffs for better visual distinction (<a href="https://github.com/michael-brade"><strong>@michael-brade</strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4328">#4328</a>: Fix "watch" mode when Mocha run in parallel (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4382">#4382</a>: Fix root hook execution in "watch" mode (<a href="https://github.com/indieisaconcept"><strong>@indieisaconcept</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4383">#4383</a>: Consistent auto-generated hook titles (<a href="https://github.com/cspotcode"><strong>@cspotcode</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4359">#4359</a>: Better errors when running <code>mocha init</code> (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4341">#4341</a>: Fix weirdness when using <code>delay</code> option in browser (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> </ul> <h2>:lock: Security Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4378">#4378</a>, <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4333">#4333</a>: Update <a href="https://npm.im/javascript-serialize">javascript-serialize</a> (<a href="https://github.com/martinoppitz"><strong>@martinoppitz</strong></a>, <a href="https://github.com/wnghdcjfe"><strong>@wnghdcjfe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4354">#4354</a>: Update <a href="https://npm.im/yargs-unparser">yargs-unparser</a> (<a href="https://github.com/martinoppitz"><strong>@martinoppitz</strong></a>)</li> </ul> <h2>:book: Documentation & Website</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4173">#4173</a>: Document how to use <code>--enable-source-maps</code> with Mocha (<a href="https://github.com/bcoe"><strong>@bcoe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4343">#4343</a>: Clean up some API docs (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4318">#4318</a>: Sponsor images are now self-hosted (<a href="https://github.com/Munter"><strong>@Munter</strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4293">#4293</a>: Use Rollup and Babel in build pipeline; add source map to published files (<a href="https://github.com/Munter"><strong>@Munter</strong></a>)</li> </ul> <h2>v8.0.1</h2> <h1>8.0.1 / 2020-06-10</h1> <p>The obligatory patch after a major.</p> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4328">#4328</a>: Fix <code>--parallel</code> when combined with <code>--watch</code> (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mochajs/mocha/blob/master/CHANGELOG.md">mocha's changelog</a>.</em></p> <blockquote> <h1>8.1.0 / 2020-07-30</h1> <p>In this release, Mocha now builds its browser bundle with Rollup and Babel, which will provide the project's codebase more flexibility and consistency.</p> <p>While we've been diligent about backwards compatibility, it's <em>possible</em> consumers of the browser bundle will encounter differences (other than an increase in the bundle size). If you <em>do</em> encounter an issue with the build, please <a href="https://github.com/mochajs/mocha/issues/new?labels=unconfirmed-bug&template=bug_report.md&title=">report it here</a>.</p> <p>This release <strong>does not</strong> drop support for IE11.</p> <p>Other community contributions came from <a href="https://github.com/Devjeel"><strong>@Devjeel</strong></a>, <a href="https://github.com/Harsha509"><strong>@Harsha509</strong></a> and <a href="https://github.com/sharath2106"><strong>@sharath2106</strong></a>. <em>Thank you</em> to everyone who contributed to this release!</p> <blockquote> <p>Do you read Korean? See <a href="https://blog.outsider.ne.kr/1489">this guide to running parallel tests in Mocha</a>, translated by our maintainer, <a href="https://github.com/outsideris"><strong>@outsideris</strong></a>.</p> </blockquote> <h2>:tada: Enhancements</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4287">#4287</a>: Use background colors with inline diffs for better visual distinction (<a href="https://github.com/michael-brade"><strong>@michael-brade</strong></a>)</li> </ul> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4328">#4328</a>: Fix "watch" mode when Mocha run in parallel (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4382">#4382</a>: Fix root hook execution in "watch" mode (<a href="https://github.com/indieisaconcept"><strong>@indieisaconcept</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4383">#4383</a>: Consistent auto-generated hook titles (<a href="https://github.com/cspotcode"><strong>@cspotcode</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4359">#4359</a>: Better errors when running <code>mocha init</code> (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4341">#4341</a>: Fix weirdness when using <code>delay</code> option in browser (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> </ul> <h2>:lock: Security Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4378">#4378</a>, <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4333">#4333</a>: Update <a href="https://npm.im/javascript-serialize">javascript-serialize</a> (<a href="https://github.com/martinoppitz"><strong>@martinoppitz</strong></a>, <a href="https://github.com/wnghdcjfe"><strong>@wnghdcjfe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4354">#4354</a>: Update <a href="https://npm.im/yargs-unparser">yargs-unparser</a> (<a href="https://github.com/martinoppitz"><strong>@martinoppitz</strong></a>)</li> </ul> <h2>:book: Documentation & Website</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4173">#4173</a>: Document how to use <code>--enable-source-maps</code> with Mocha (<a href="https://github.com/bcoe"><strong>@bcoe</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4343">#4343</a>: Clean up some API docs (<a href="https://github.com/craigtaub"><strong>@craigtaub</strong></a>)</li> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4318">#4318</a>: Sponsor images are now self-hosted (<a href="https://github.com/Munter"><strong>@Munter</strong></a>)</li> </ul> <h2>:nut_and_bolt: Other</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4293">#4293</a>: Use Rollup and Babel in build pipeline; add source map to published files (<a href="https://github.com/Munter"><strong>@Munter</strong></a>)</li> </ul> <h1>8.0.1 / 2020-06-10</h1> <p>The obligatory patch after a major.</p> <h2>:bug: Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4328">#4328</a>: Fix <code>--parallel</code> when combined with <code>--watch</code> (<a href="https://github.com/boneskull"><strong>@boneskull</strong></a>)</li> </ul> <h1>8.0.0 / 2020-06-10</h1> <p>In this major release, Mocha adds the ability to <em>run tests in parallel</em>. Better late than never! Please note the <strong>breaking changes</strong> detailed below.</p> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mochajs/mocha/commit/7e250ef1168cf93e9d473321dc93b0b81f9a0d98"><code>7e250ef</code></a> Release v8.1.0</li> <li><a href="https://github.com/mochajs/mocha/commit/a6203c6967d9e73cd6696c82a587213f5e86cee3"><code>a6203c6</code></a> add git tag message to .npmrc</li> <li><a href="https://github.com/mochajs/mocha/commit/60858dc4f32713f67112f837063380639042737e"><code>60858dc</code></a> devDependency updates for v8.1.0</li> <li><a href="https://github.com/mochajs/mocha/commit/cf736fedfb15203824c0d21af7900112354f5804"><code>cf736fe</code></a> handle errors in supporter images during 11ty build</li> <li><a href="https://github.com/mochajs/mocha/commit/f966c943e637eea1e05b90e6904ce3e84271d279"><code>f966c94</code></a> Fixing typos</li> <li><a href="https://github.com/mochajs/mocha/commit/8970429ee06c6f2c52505026af0214471cf67b18"><code>8970429</code></a> update CHANGELOG for v8.1.0</li> <li><a href="https://github.com/mochajs/mocha/commit/edc09bf147bef3a40cd5557fb797808136b7d3da"><code>edc09bf</code></a> Ensure root level hooks are called when running in watch mode</li> <li><a href="https://github.com/mochajs/mocha/commit/29012aa9fa0c4e5f86e72f2e4fa4d72027ccb42d"><code>29012aa</code></a> Update javascript-serialize 3.1.0 to 4.0.0; closes <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4375">#4375</a> (<a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4378">#4378</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/78848932cef7e3feab9184a161b9899b7c024c82"><code>7884893</code></a> ensure hook titles are consistent; closes <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4348">#4348</a> (PR <a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4383">#4383</a>)</li> <li><a href="https://github.com/mochajs/mocha/commit/ad03d2972deba18a7a214324fbd73cb14bbe0d79"><code>ad03d29</code></a> build UMD bundle and polyfill language features (<a href="https://github-redirect.dependabot.com/mochajs/mocha/issues/4366">#4366</a>)</li> <li>Additional commits viewable in <a href="https://github.com/mochajs/mocha/compare/v7.2.0...v8.1.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 9 days

push eventbrunch/brunch

Alexey Shvayka

commit sha 56a18566d73a0fb351a6a0175f8ffc8bb5de495a

Remove note about `terminal-notifier`

view details

Paul Miller

commit sha d101f375aecdf98d9ded4fe28f8f6775cc56b4e4

Merge pull request #1858 from shvaikalesh/patch-1 Remove note about `terminal-notifier`

view details

push time in 9 days

PR merged brunch/brunch

Remove note about `terminal-notifier`

This note dates back 5y ago, long before native-notifier was introduced to handle notifications w/o native dependencies.

+0 -2

0 comment

1 changed file

shvaikalesh

pr closed time in 9 days

issue closedpaulmillr/chokidar

Node Chokidar syntax error in the module's index.js

A clear and concise description of what the bug is. image

"chokidar": "^3.3.1", "electron-packager": "^14.2.1", "electron-rebuild": "^1.11.0", "grpc": "^1.24.2"

  • Node version [ 13.5.0,
  • OS version: [Windows 10]

To Reproduce:

const chokidar = require('chokidar');

var watcher = chokidar.watch("C:\Logs\", {ignored: /[/\]./, persistent: true});

watcher.on('add', function(path) { console.log('File', path, 'has been added');

}) .on('addDir', function(path) {console.log('Directory', path, 'has been added');}) .on('change', function(path) {console.log('File', path, 'has been changed');}) .on('unlink', function(path) {console.log('File', path, 'has been removed');}) .on('unlinkDir', function(path) {console.log('Directory', path, 'has been removed');}) .on('error', function(error) {console.error('Error happened', error);});

While running npm start, its giving below issue - a

What would be the cause?

closed time in 11 days

bharatpatil108

issue commentpaulmillr/chokidar

Node Chokidar syntax error in the module's index.js

Seems like you are using old nodejs version instead of 13.5.

bharatpatil108

comment created time in 11 days

push eventbrunch/skeletons

Nicolas Delauney

commit sha 9ae6376399c062c41748fc84b3b2dee9663de856

add brunch-phaser-desktop

view details

Paul Miller

commit sha aceb30572172593bea568258cbe31a8fa378200e

Merge pull request #65 from Delni/master add brunch-phaser-desktop

view details

push time in 12 days

PR merged brunch/skeletons

add brunch-phaser-desktop
+7 -0

0 comment

1 changed file

Delni

pr closed time in 12 days

issue closedbrunch/brunch

brunch-config.js is missing

Description

Hello,

When I run the "brunch new project_name" command, the brunch-config-js file is missing while building my base project.

Is this normal?

Brunch v.3.0.0 Capture d’écran du 2020-07-24 11-50-33

closed time in 15 days

Dynzels

issue commentbrunch/brunch

brunch-config.js is missing

brunch config is optional since brunch 3.0

Dynzels

comment created time in 15 days

issue commentfsevents/fsevents

Not support error

@3bars we don't fail on arm. We check if the os kernel is darwin. Darwin on arm is still darwin.

pddkhanh

comment created time in 20 days

issue openedkobigurk/phase2-bn254

Security level?

I've heard that security level of bn254 is ~80 bits. Which is bad.

Can you confirm it's true or false? Because the project is important.

created time in 25 days

issue commentfsevents/fsevents

Attention: Errors like "lazy symbol binding failed" / "nan"

@CharlesStover seems like new webpack-dev-server still hasn't been released

paulmillr

comment created time in 25 days

issue commentpaulmillr/readdirp

ESM module

What is index.cjs, how does it look like?

What is the benefit of switching to cjs ?

talentlessguy

comment created time in 25 days

issue openedpaulmillr/noble-bls12-381

Update DST to vectors from hash-to-curve v09

https://www.ietf.org/rfcdiff?url1=draft-irtf-cfrg-hash-to-curve-07&url2=draft-irtf-cfrg-hash-to-curve-09

created time in 25 days

push eventpaulmillr/noble-bls12-381

Paul Miller

commit sha 3df64eace03b28fecf635ef5e9b05cfbba224cdb

Support hash-to-curve 09.

view details

push time in 25 days

created tagpaulmillr/chokidar

tag3.4.1

An efficient wrapper around node.js fs.watch / fs.watchFile / FSEvents

created time in 25 days

push eventpaulmillr/chokidar

Paul Miller

commit sha 06c74cadcb29aeed4f146776c44dc99dc98fd80d

Release 3.4.1.

view details

push time in 25 days

pull request commentpaulmillr/chokidar

Ensure closing watchers does not affect other watchers

New release is coming today

timneutkens

comment created time in a month

push eventpaulmillr/chokidar

Tim Neutkens

commit sha b020f94bb109f8f30f4de5412191a066575ce9c8

Add failing test case for watcher close affecting other watchers If the first watcher that was created gets closed all other watchers will no longer receive events. Ran into this scenario after we upgraded Next.js to use the latest chokidar that came with the latest stable watchpack. With chokidar v2 (which watchpack previously depended on) this test passes fine. Using v3 it stops reporting.

view details

Tim Neutkens

commit sha d071498130a8f1b08d3bff8b33a9b90e3d743311

Check if there are still listeners instead of if the first watcher was closed

view details

Tim Neutkens

commit sha a9c54de75178aaf385f043994555a40c27a9a2fc

Remove unused property fsw

view details

Paul Miller

commit sha bfcde1c82b6508db5203cbbdceeebba8c8de4c2c

Merge pull request #1018 from timneutkens/add/failing-test-for-closed-watcher Ensure closing watchers does not affect other watchers

view details

push time in a month

PR merged paulmillr/chokidar

Ensure closing watchers does not affect other watchers

If the first watcher that was created gets closed all other watchers will no longer receive events.

Ran into this scenario after we upgraded Next.js to use the latest chokidar that came with the latest stable watchpack. With chokidar v2 (which watchpack previously depended on) this test passes fine. Using v3 it stops reporting filesystem events.

So far I've tracked it down to this particular line: https://github.com/paulmillr/chokidar/blob/master/lib/fsevents-handler.js#L149

Because the part that creates the context is only called on the first watcher the fsw variable will always refer to that first watcher.

  • The code in particular loops over the listeners on const.listeners
    • It doesn't need to know if the watcher itself is closed, only if there's listeners left
    • The listeners are correctly removed when a watcher is closed
    • The watcher itself is thrown away correctly when the last listener of that path is deleted
    • Given the above it seems that the best solutions to solve this issue is checking cont.listeners.size instead of fsw.closed
    • Considering the watcher is cleaned up correctly on close the check might not be necessary, though it probably handles an edge case of in-between closing the watcher.

The symptoms (only on macOS) would be that webpack did not recompile after introducing an error or after doing a bunch of quick changes to a certain file. With the change in this PR applied the symptoms are no longer there.

The particular reason this surfaces in webpack is that when an error happens the watchers are closed and recreated when a compilation error happens as files/dependencies could have changed in between.

+28 -4

4 comments

2 changed files

timneutkens

pr closed time in a month

issue commentpaulmillr/chokidar

Watching network drive '\\server\folder' does not work

No status. Feel free to debug this and provide a pull req.

Zireael

comment created time in a month

issue commentpaulmillr/readdirp

ESM module

Hi. It prob won’t work.

talentlessguy

comment created time in a month

issue closedfsevents/fsevents

Upgrading fsevents from 1.2.9 to 1.2.13 causes PhantomJS to fail.

I don't know how better to report or debug this. My team's application is built on React and Webpack and tested in PhantomJS 1.9. Our browserlist is configured to support PhantomJS 1.9. It worked fine for the longest time, then we realized a couple months back that if we delete package-lock.json and pull in the latest dependencies, PhantomJS fails to run with the cryptic and unhelpful "Parse error" with no line number or further information.

I only just yesterday was able to update every dependency one at a time until I realized it was specifically the upgrade of fsevents from 1.2.9 to 1.2.13 causing the problem. If fsevents remains locked at 1.2.9, this error does not occur. PhantomJS can successfully crawl and test the application. But once fsevents is upgraded, PhantomJS fails with that error.

I noticed this upgrade also causes two new dependencies to be included: bindings and file-uri-to-path. The error may occur in those dependencies.

Is this a known issue? Is there a known fix?

closed time in a month

CharlesStover

issue commentfsevents/fsevents

Upgrading fsevents from 1.2.9 to 1.2.13 causes PhantomJS to fail.

1.2 is unsupported. Upgrade to 2.x.

CharlesStover

comment created time in a month

pull request commentethereumjs/rlp

Add browser support, remove dependencies

Great. Thanks for not closing this immediately!

paulmillr

comment created time in a month

pull request commentpaulmillr/chokidar

Ensure closing watchers does not affect other watchers

Thank you!

I’ll be reviewing/merging this in a bit.

timneutkens

comment created time in a month

issue commentwebpack/watchpack

Bring back chokidar v3

re: kane-mason's comment — unrelated to chokidar 3, this is related to graceful-fs module which monkey-patches fs and has a long history of similar issues

paulmillr

comment created time in a month

created tagpaulmillr/micro-should

tag0.1.3

Ultra-simple testing framework without dependencies. Supports async cases.

created time in a month

push eventpaulmillr/micro-should

Paul Miller

commit sha 9045ceb310a86154a004d587d840eb8d4c5e7f67

Release 0.1.3.

view details

push time in a month

issue closedpaulmillr/chokidar

watch not exist file,Become monitor all

Describe the bug code:

chokidar.watch('notExist.js').on('raw', (event, path, details) => {
  console.log('Raw event info:', path);
});

watch a file of not exist, the behavior will like

chokidar.watch('.').on('raw', () => {});

only raw event has problem Versions (please complete the following information):

  • Chokidar version: 3.4.0
  • Node version: 12.16.0
  • OS version: window10

To Reproduce:

chokidar.watch('notExist.js').on('raw', (event, path, details) => {
  console.log('Raw event info:', path);
});

Expected behavior raw event not emit

closed time in a month

WzFFzW

issue commentpaulmillr/chokidar

watch not exist file,Become monitor all

duplicate of #872

WzFFzW

comment created time in a month

issue closedfsevents/fsevents

Having issue while running Newman command

I amgetting error when I am executing Newman command. Could anyone please provide the solution for this. Here is my Newman command.

newman run Digital_API.postman_collection.json -r htmlextra --reporter-htmlextra-title "Digital API Automation report" -d TestData_SIT.json

Here is a error:

<--- Last few GCs --->

[28152:000002D62F1A7200] 4378103 ms: Mark-sweep 2036.9 (2055.4) -> 2032.8 (2055.1) MB, 1328.3 / 0.0 ms (average mu = 0.387, current mu = 0.484) allocation failure scavenge might not succeed [28152:000002D62F1A7200] 4380001 ms: Mark-sweep 2036.6 (2055.1) -> 2032.8 (2054.9) MB, 1684.9 / 0.0 ms (average mu = 0.253, current mu = 0.113) allocation failure scavenge might not succeed

<--- JS stacktrace --->

==== JS stack trace =========================================

0: ExitFrame [pc: 00007FF7202577DD]
1: StubFrame [pc: 00007FF7202C035E]

Security context: 0x01bff81408d1 <JSObject> 2: /* anonymous */ [0000003AC8CB78D9] [evalmachine.<anonymous>:13784] [bytecode=0000031353F12CA1 offset=0](this=0x033a74703c29 <JSGlobal Object>,0x01bff817c1d1 <String[#3]: key>) 3: arguments adaptor frame: 3->1 4: Ht [0000004D77A92F89] [evalmachine.<anonymous>:~13784] [pc=0000031C6ECBD37A](this=0x033a747...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory 1: 00007FF71F64470F napi_wrap+113583 2: 00007FF71F5EF7D6 v8::base::CPU::has_sse+66646 3: 00007FF71F5F05D6 v8::base::CPU::has_sse+70230 4: 00007FF71FE042EE v8::Isolate::ReportExternalAllocationLimitReached+94 5: 00007FF71FDEC3C1 v8::SharedArrayBuffer::Externalize+833 6: 00007FF71FCB890C v8::internal::Heap::EphemeronKeyWriteBarrierFromCode+1436 7: 00007FF71FCC3B40 v8::internal::Heap::ProtectUnprotectedMemoryChunks+1312 8: 00007FF71FCC0664 v8::internal::Heap::PageFlagsAreConsistent+3204 9: 00007FF71FCB5E63 v8::internal::Heap::CollectGarbage+1283 10: 00007FF71FCB44D4 v8::internal::Heap::AddRetainedMap+2452 11: 00007FF71FCD56DD v8::internal::Factory::NewFillerObject+61 12: 00007FF71FA3BF61 v8::internal::interpreter::JumpTableTargetOffsets::iterator::operator=+1665 13: 00007FF7202577DD v8::internal::SetupIsolateDelegate::SetupHeap+546637 14: 00007FF7202C035E v8::internal::SetupIsolateDelegate::SetupHeap+975566 15: 00007FF7201DC78C v8::internal::SetupIsolateDelegate::SetupHeap+42748 16: 00007FF7201D5ABC v8::internal::SetupIsolateDelegate::SetupHeap+14892 17: 0000031C6ECBD37A

closed time in a month

svarshney2311

issue commentfsevents/fsevents

Having issue while running Newman command

Why are you reporting this to fsevents repo if you're not using fsevents?

svarshney2311

comment created time in a month

issue commentfsevents/fsevents

Having issue while running Newman command

which fsevents version?

svarshney2311

comment created time in a month

issue commentfsevents/fsevents

Having issue while running Newman command

which fsevents version?

svarshney2311

comment created time in a month

push eventpaulmillr/micro-should

Roman Koblov

commit sha f14dc1f3205dafc7a179a359560ec246f20891e8

Fix 'Don't re-run tests on next should.run'

view details

Paul Miller

commit sha f028ed80ab69956769c1b90ac1d1bdc65bb8318a

Merge pull request #4 from romankoblov/patch-2 Fix 'Don't re-run tests on next should.run'

view details

push time in a month

created tagpaulmillr/micro-should

tag0.1.2

Ultra-simple testing framework without dependencies. Supports async cases.

created time in a month

push eventpaulmillr/micro-should

Paul Miller

commit sha 9cf09ff2fc98c75cd089f4c2dd36c7334996fc7e

Release 0.1.2.

view details

push time in a month

push eventpaulmillr/micro-should

Roman Koblov

commit sha f30bb37ebd48c590ab8a0692c58dab2d6995d6c1

Don't re-run tests on next should.run

view details

Paul Miller

commit sha a33ff844aee17f4b2561dee481ed462c96da2243

Merge pull request #3 from romankoblov/patch-1 Don't re-run tests on next should.run

view details

push time in a month

issue commentfsevents/fsevents

fsevents [Error]

Read readme.

developer-anand

comment created time in a month

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

I don't care much. I just want this to be merged in some way. It would be shitty if this ain't merged, since i've spent some time.

You can add a simple check if fromWords input is Uint8Array and return Uint8Array in this case.

paulmillr

comment created time in a month

issue closedfsevents/fsevents

fsevents [Error]

fsevents installation error Please help

C:\Users\u>npm install fsevents npm ERR! code EBADPLATFORM npm ERR! notsup Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}) npm ERR! notsup Valid OS: darwin npm ERR! notsup Valid Arch: any npm ERR! notsup Actual OS: win32 npm ERR! notsup Actual Arch: x64

closed time in a month

developer-anand

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

Why would you want to put 5-bit words in a Uint8Array? Uint8Array is the closest thing to Uint5Array.

A number:

  • can be more than 53-bit
  • can be signed
  • can be float
  • can be NaN

In order to make sure that people using TypeScript do not think the 5-bit words are "bytes" it is not a good idea to use Uint8Array. There are way more incorrect things people can do with a number when compared to u8, and it also tells user limits about what to expect from output without looking at code.

Return values should be stricter: u8 is way more strict that number.

there are 3 extra padding bits for each byte which makes no sense There are 48 extra padding bits in each number.

paulmillr

comment created time in a month

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

It's fine if you want users to be able to use number[].

I think it's a big mistake to not allow Uint8Arrays directly. I'm using them, and most people are using them. I'm using them with bech32 code. They are standard across all libraries.

paulmillr

comment created time in a month

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

Using Uint8Array is an industry-standard way of working with binary data in javascript. Most cryptographic libraries work with Uint8Arrays. Browser crypto APIs use Uint8Arrays.

Buffer itself is a legacy node.js-only version of Uint8Array and is in fact a subclass of it. You can check this by doing: Buffer.from([]) instanceof Uint8Array // => true. So, using Uint8Array in type signatures would allow Buffers through. If you want to amend types to add number[], i'd suggest to make it Uint8Array | number[].

Maybe we could bump major version to ensure breaking changes are correctly reflected in semver.

paulmillr

comment created time in 2 months

issue openedmicrosoft/vscode

BigInt literals are not available when targeting lower than ES2020

  • VSCode Version: 1.46
  • OS Version: macos-latest

Steps to Reproduce:

  1. Create js file with bigints like 12345n
  2. Check out "problems" tab. It would highlight the number and throw the error: "BigInt literals are not available when targeting lower than ES2020"

Creating jsconfig.json with target: es2020 doesn't help.

The issue doesn't happen if you use same target with typescript code / tsconfig. Happens only with JS files

created time in 2 months

created tagpaulmillr/lean-rlp

tag2.2.7

Recursive Length Prefix Encoding in JavaScript

created time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha 07e695206ffd290725cc0ae3d95db4e774862e81

Release 2.2.7.

view details

push time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha fb241e32fb0ab2e1a8a6696666046cb94f732ce7

Fix tests

view details

push time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha 141bd2266586e71f3309942d57ff5d551654c1ea

Fix tests

view details

push time in 2 months

issue commentwebpack/webpack-dev-server

Upgrade to chokidar 3 to support the Node v14 release

@evilebottnawi that's not "a lot of changes". You bump to v5 and release with new chokidar. That's it. Takes five minutes.

dandv

comment created time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha a218ffa53503a997a81bddd66cd07a23f8050ed1

Fix tests

view details

push time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha 0823218c2d5db9ee9a9848dba1e1fc550210d352

Fix tests

view details

push time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha 36fb44f2a0005ca323abbd66ea7377b0768e1a7a

Fix errors

view details

push time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

https://travis-ci.org/github/bitcoinjs/bech32/builds/701692127

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 38d64e65285a8e70fe527d645fc43af964d309d0

Prettier travis

view details

push time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 567b99c4287f487e850e6fc6ee806bed138706ea

Remove standard

view details

push time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

All other parts are done. Feel free to merge.

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha d01bf120f369a2a99e56181c61474aa6de659262

Typescript tests

view details

push time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

@junderw coverage is now 100%.

I don't know how to move coverage to typescript. Do you think we could get away without it for now?

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha a7b9360d94b0afb925820c72ce13453e5150d1fb

Travis gitdiff

view details

push time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha b25a7c01f427eba4b53f315b58d6f943640d4294

100% coverage

view details

push time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 1e0cf19948886994fa6de678c658bbd17496ee98

Add gitdiff. Add unsafe tests

view details

push time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 1fd5d5d25498131d00a4aa697b85de072c707c9a

Fix tests.

view details

push time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 5ffd656ced69a9f1a489d7f2b34c30ea34568d70

Target es2015.

view details

push time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

ok i've added them back but that still feels like unnecessary complication. JS folks use try-catch all the time, I don't see a point in doing this inside the lib.

added prettier.

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 95409f3a2872bab0697f58e0313657f59986617f

Add unsafe functions, prettier.

view details

push time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

@junderw

Justification for removing unsafe functions

They were never documented. What is the purpose? They complicate API.

paulmillr

comment created time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

We could move to GitHub actions after that's merged. I can provide a PR.

paulmillr

comment created time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

The linter is obviously failing now because output JS cannot be customized from typescript compiler. I don't think this is a big deal.

Typescript code conforms to prettier linter, we can use it.

paulmillr

comment created time in 2 months

pull request commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

Fixed var issue.

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha d7f0cb81c9c93623c1067920b211be0bc06ad0a2

Add build script. Fix var assigns

view details

push time in 2 months

Pull request review commentbitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

+'use strict';+const BECH32_SEPARATOR = '1';+const BECH32_MAX_LIMIT = 90;+const BECH32_MIN_LIMIT = 8;+const ALPHABET = 'qpzry9x8gf2tvdw0s3jn54khce6mua7l';++const ALPHABET_MAP: { [key: string]: number } = [...ALPHABET].reduce(+  (res, el, i) => ({ ...res, [el]: i }),+  {}+);++const GENERATORS = [0x3b6a57b2, 0x26508e6d, 0x1ea119fa, 0x3d4233dd, 0x2a1462b3];++function polymodStep(pre: number): number {+  var b = pre >> 25;

no

paulmillr

comment created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha fe6a84b930aa76324387f81974f2338748fe8d52

Release 1.1.5.

view details

push time in 2 months

PR opened bitcoinjs/bech32

Clean-up implementation. Rewrite in typescript.

Feels much simpler now.

+304 -278

0 comment

8 changed files

pr created time in 2 months

push eventpaulmillr/bech32.ts

Paul Miller

commit sha 026316189dc7ad544ba3b57624747111140ea7cd

Rewrite in typescript.

view details

push time in 2 months

create barnchpaulmillr/bech32.ts

branch : typescript

created branch time in 2 months

fork paulmillr/bech32

Bech32 encoding / decoding

fork in 2 months

PR opened ethereumjs/rlp

Add browser support, remove dependencies

Hi,

This probably won't get merged -- but I want to get the idea exposed.

Basically Buffer is not supported in browsers. I think a Uint8Array should be used instead, since all Buffers are actually Uint8Arrays. This would allow to support browsers out-of-box.

As for bn.js, all major browsers and node.js versions right now support native bigints. At some point rlp should switch to native bigints -- which would allow to drop dependencies.

I've made a fork - all tests pass. Let me know what you think

+231 -142

0 comment

7 changed files

pr created time in 2 months

created tagpaulmillr/lean-rlp

tag2.2.6

Recursive Length Prefix Encoding in JavaScript

created time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha 42b71aba4d62095d349c262fca3fc620c496b36c

Fork, remove deps, add browser support.

view details

Paul Miller

commit sha a2911699eec628f9a6cca4bfac0b642f7ccc6023

Release 2.2.6.

view details

push time in 2 months

fork paulmillr/rlp-1

Recursive Length Prefix Encoding in JavaScript

fork in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha b1ab2c09efaf62d288338d6b62a899ae899b7c40

Update README.md

view details

push time in 2 months

push eventpaulmillr/lean-rlp

Paul Miller

commit sha d312ad80faa923cd6145d96a7a04fcde6899fd15

Update README.md

view details

push time in 2 months

more