certbot/certbot 27199
Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server. It can also act as a client for any other CA that uses the ACME protocol.
helm/charts 14419
Curated applications for Kubernetes
cloudnativelabs/kube-router 1508
Kube-router, a turnkey solution for Kubernetes networking.
📝 Easily create a beautiful website using Academic, Hugo, and Netlify
Autoscaling components for Kubernetes
Prometheus exporter for BIND
Armbian build tools
Kafka Consumer Lag Checking
This is a NodeJS/Angular 2 frontend UI for Kafka cluster monitoring with Burrow
Certbot, previously the Let's Encrypt Client, is EFF's tool to obtain certs from Let's Encrypt, and (optionally) auto-enable HTTPS on your server. It can also act as a client for any other CA that uses the ACME protocol.
PR opened cloudnativelabs/kube-router
This vendors a later version of prometheus' golang client (0.8.0 ->
0.9.4) to allow go mod tidyto work properly.
It also updates the k8s libraries from 0.18.6 to 0.18.8 to avoid
hitting https://github.com/kubernetes/kubernetes/issues/91073
pr created time in a day
PR opened helm/charts
What this PR does / why we need it:
Version bump to 1.7.1
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [x] DCO signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g.
[stable/mychartname])
pr created time in 3 days
push eventmrueg/charts
commit sha 89eef964732b9ad867a91441b281a9ab8e044d6e
[stable/coredns] Version bump to 1.7.1 Signed-off-by: Manuel Rüger <[email protected]>
push time in 3 days
startedjunegunn/fzf
started time in 3 days
startedadonno/tagreader
started time in 4 days
Pull request review commentkubernetes/kube-state-metrics
e2e.sh: Update kind to 0.9.0 and k8s to 1.19.2
case $(uname -m) in *) ARCH="$(uname -m)";; esac -KUBERNETES_VERSION=v1.19.1+KUBERNETES_VERSION=v1.19.2
Thanks, yes figured it after CI run and dropped the change now.
comment created time in 6 days
push eventmrueg/kube-state-metrics
commit sha 9c487adc16e794c3b3b706ddd5155cecb156da0f
e2e.sh: Update kind to 0.9.0
push time in 6 days
startedaquasecurity/cloudsploit
started time in 6 days
PR opened kubernetes/kube-state-metrics
What this PR does / why we need it: Small updates to the versions used for e2e testing
pr created time in 6 days
startedaquasecurity/starboard
started time in 6 days
startedConfluxDigital/software-delivery-assessment
started time in 6 days
issue commentkubernetes/kube-state-metrics
Provide a new home for the helm chart
/remove-lifecycle stale
comment created time in 7 days
issue commentkubernetes/kubernetes
Kubernetes should warn when referenced imagePullSecret does not exist
/remove-lifecycle stale
comment created time in 8 days
issue commentprometheus-community/helm-charts
[kube-prometheus] update default image to v0.41.0
Here's a PR from @sev3ryn that can be used as a starting point https://github.com/helm/charts/pull/23406
comment created time in 9 days
startedprometheus-community/helm-charts
started time in 9 days
startedatc1441/ATC_MiThermometer
started time in 9 days
startedstelford/home-assistant_inkbird
started time in 9 days
startedloadimpact/k6
started time in 10 days
push eventmrueg/repoman-travis
commit sha ec5d2fded6970ca3c2bee5b8e6ec54f8b473907d
.travis.yml: Update portage to 3.0.7
push time in 10 days
PR opened aquasecurity/trivy
Fixes: https://github.com/aquasecurity/trivy/issues/631
pr created time in 10 days
push eventmrueg/trivy
commit sha 52a78785063adf64f73c75693169146639b9c9fd
goreleaser.yml: Add all templates to archive Fixes: https://github.com/aquasecurity/trivy/issues/631 Signed-off-by: Manuel Rüger <[email protected]>
push time in 10 days
startedIAmStoxe/wirehole
started time in 11 days
issue commentmailcow/mailcow-dockerized
[Feature Proposal] Prometheus Endpoint, etc.
FYI I've filed https://github.com/rspamd/rspamd/issues/3484
Upstream seems to be open to a accept a pr that expands the stats endpoint to expose prometheus metrics.
comment created time in 12 days
startedrebuy-de/aws-nuke
started time in 14 days
startedkbst/terraform-kubestack
started time in 14 days
startedJoshVanL/cni-migration
started time in 15 days
startedkabachook/k8s-security
started time in 17 days
startedjeanbaptisteng/bottlerocket-cloudformation
started time in 17 days
startedinfracost/infracost
started time in 18 days
push eventmrueg/dovecot-core
commit sha 98ed31cb2ec87cae0958ad5a8b68ed51ddc284c1
Revert "Revert content type" This reverts commit 904fd8bb6bbc485430b5178713b26ba4a4c1601d.
push time in 18 days
startedhybridgroup/gobot
started time in 18 days
push eventmrueg/dovecot-core
commit sha 638bc7c60c016e7d1196d03c16b832f4441822ba
Make startup time a timestamp
push time in 18 days
pull request commentdovecot/core
Make metrics compliant with OpenMetrics' standards
Maybe I misunderstood the content type from the client_python implemention
That's the correct content type for OpenMetrics, so you should be using it.
So just to get it right this time, re-reverting https://github.com/dovecot/core/pull/136/commits/904fd8bb6bbc485430b5178713b26ba4a4c1601d is correct?
process_start_time_seconds 836
This should be a timestamp.
Thanks, will fix!
dovecot_imap_command_total{cmd_name="EXAMINE"} 3 dovecot_imap_command_total{cmd_name="EXAMINE",tagged_reply_state="OK"} 3
These still have inconsistent labels.
I see. Unfortunately, this is based on the metrics configuration, there's a group_by option that can generate sub metrics.
If I had failed requests, dovecot_imap_command_total{cmd_name="EXAMINE",tagged_reply_state="FAILED"} 3 would appear.
dovecot_push_notifications and dovecot_push_notifications_duration_seconds_total
These should probably be a summary, as they appear linked. Currently this library only implements histograms and counters. It's a bit out of (my) scope to implement further items.
comment created time in 18 days
issue commentprometheus-community/helm-charts
Happy to help out on the kube-prometheus-stack chart as well to share the load.
comment created time in 18 days
pull request commentdovecot/core
Make metrics compliant with OpenMetrics' standards
Maybe I misunderstood the content type from the client_python implemention https://github.com/prometheus/client_python/blob/3cb4c9247f3f08dfbe650b6bdf1f53aa5f6683c1/prometheus_client/openmetrics/exposition.py#L7 I reverted it back to text/plain and dropped the timestamps:
# HELP process_start_time_seconds Dovecot stats service uptime
# TYPE process_start_time_seconds gauge
process_start_time_seconds 836
# HELP dovecot_build Dovecot build information
# TYPE dovecot_build info
dovecot_build_info{version="2.3.11.3",revision="502c39af9"} 1
# HELP dovecot_storage_http_gets Total number of all events of this kind
# TYPE dovecot_storage_http_gets counter
dovecot_storage_http_gets_total 0
# HELP dovecot_storage_http_gets_duration_seconds Total duration of all events of this kind
# TYPE dovecot_storage_http_gets_duration_seconds counter
dovecot_storage_http_gets_duration_seconds_total 0.000000
# HELP dovecot_imap_command Total number of all events of this kind
# TYPE dovecot_imap_command counter
dovecot_imap_command_total{cmd_name="EXAMINE"} 3
dovecot_imap_command_total{cmd_name="EXAMINE",tagged_reply_state="OK"} 3
dovecot_imap_command_total{cmd_name="UID SEARCH"} 3
dovecot_imap_command_total{cmd_name="UID SEARCH",tagged_reply_state="OK"} 3
dovecot_imap_command_total{cmd_name="UID FETCH"} 13
dovecot_imap_command_total{cmd_name="UID FETCH",tagged_reply_state="OK"} 13
dovecot_imap_command_total{cmd_name="NOOP"} 20
dovecot_imap_command_total{cmd_name="NOOP",tagged_reply_state="OK"} 20
dovecot_imap_command_total{cmd_name="NAMESPACE"} 1
dovecot_imap_command_total{cmd_name="NAMESPACE",tagged_reply_state="OK"} 1
dovecot_imap_command_total{cmd_name="SEARCH"} 1
dovecot_imap_command_total{cmd_name="SEARCH",tagged_reply_state="OK"} 1
dovecot_imap_command_total{cmd_name="SELECT"} 8
dovecot_imap_command_total{cmd_name="SELECT",tagged_reply_state="OK"} 8
dovecot_imap_command_total{cmd_name="UID STORE"} 6
dovecot_imap_command_total{cmd_name="UID STORE",tagged_reply_state="OK"} 6
dovecot_imap_command_total{cmd_name="STATUS"} 3
dovecot_imap_command_total{cmd_name="STATUS",tagged_reply_state="OK"} 3
dovecot_imap_command_total{cmd_name="UID COPY"} 2
dovecot_imap_command_total{cmd_name="UID COPY",tagged_reply_state="OK"} 2
dovecot_imap_command_total{cmd_name="UID EXPUNGE"} 2
dovecot_imap_command_total{cmd_name="UID EXPUNGE",tagged_reply_state="OK"} 2
# HELP dovecot_imap_command_duration_seconds Total duration of all events of this kind
# TYPE dovecot_imap_command_duration_seconds counter
dovecot_imap_command_duration_seconds_total{cmd_name="EXAMINE"} 0.153950
dovecot_imap_command_duration_seconds_total{cmd_name="EXAMINE",tagged_reply_state="OK"} 0.153950
dovecot_imap_command_duration_seconds_total{cmd_name="UID SEARCH"} 0.024290
dovecot_imap_command_duration_seconds_total{cmd_name="UID SEARCH",tagged_reply_state="OK"} 0.024290
dovecot_imap_command_duration_seconds_total{cmd_name="UID FETCH"} 0.973220
dovecot_imap_command_duration_seconds_total{cmd_name="UID FETCH",tagged_reply_state="OK"} 0.973220
dovecot_imap_command_duration_seconds_total{cmd_name="NOOP"} 0.219900
dovecot_imap_command_duration_seconds_total{cmd_name="NOOP",tagged_reply_state="OK"} 0.219900
dovecot_imap_command_duration_seconds_total{cmd_name="NAMESPACE"} 0.001320
dovecot_imap_command_duration_seconds_total{cmd_name="NAMESPACE",tagged_reply_state="OK"} 0.001320
dovecot_imap_command_duration_seconds_total{cmd_name="SEARCH"} 0.032590
dovecot_imap_command_duration_seconds_total{cmd_name="SEARCH",tagged_reply_state="OK"} 0.032590
dovecot_imap_command_duration_seconds_total{cmd_name="SELECT"} 8.019990
dovecot_imap_command_duration_seconds_total{cmd_name="SELECT",tagged_reply_state="OK"} 8.019990
dovecot_imap_command_duration_seconds_total{cmd_name="UID STORE"} 0.188720
dovecot_imap_command_duration_seconds_total{cmd_name="UID STORE",tagged_reply_state="OK"} 0.188720
dovecot_imap_command_duration_seconds_total{cmd_name="STATUS"} 1.703130
dovecot_imap_command_duration_seconds_total{cmd_name="STATUS",tagged_reply_state="OK"} 1.703130
dovecot_imap_command_duration_seconds_total{cmd_name="UID COPY"} 1.537030
dovecot_imap_command_duration_seconds_total{cmd_name="UID COPY",tagged_reply_state="OK"} 1.537030
dovecot_imap_command_duration_seconds_total{cmd_name="UID EXPUNGE"} 0.054430
dovecot_imap_command_duration_seconds_total{cmd_name="UID EXPUNGE",tagged_reply_state="OK"} 0.054430
# HELP dovecot_push_notifications Total number of all events of this kind
# TYPE dovecot_push_notifications counter
dovecot_push_notifications_total 0
# HELP dovecot_push_notifications_duration_seconds Total duration of all events of this kind
# TYPE dovecot_push_notifications_duration_seconds counter
dovecot_push_notifications_duration_seconds_total 0.000000
# HELP dovecot_push_notification_http_finished Total number of all events of this kind
# TYPE dovecot_push_notification_http_finished counter
dovecot_push_notification_http_finished_total 0
# HELP dovecot_push_notification_http_finished_duration_seconds Total duration of all events of this kind
# TYPE dovecot_push_notification_http_finished_duration_seconds counter
dovecot_push_notification_http_finished_duration_seconds_total 0.000000
# EOF
comment created time in 19 days
push eventmrueg/dovecot-core
commit sha 060ece416a446f9e788f71ab4edb571d85481dd7
Drop timestamp for metrics
commit sha 904fd8bb6bbc485430b5178713b26ba4a4c1601d
Revert content type
push time in 19 days
Pull request review commentcloudnativelabs/kube-router
merge gobgp-update into master
endif gobgp: ifeq "$(BUILD_IN_DOCKER)" "true" @echo Building gobgp- $(DOCKER) run -v $(PWD)/vendor:/go/src -w /go/src/github.com/osrg/gobgp/gobgp $(DOCKER_BUILD_IMAGE) \- sh -c 'GOARCH=$(GOARCH) CGO_ENABLED=0 go build -o gobgp'+ $(DOCKER) run -v $(PWD):/go/src/github.com/cloudnativelabs/kube-router -w /go/src/github.com/cloudnativelabs/kube-router $(DOCKER_BUILD_IMAGE) \+ sh -c 'go get -u github.com/osrg/gobgp && GOARCH=$(GOARCH) CGO_ENABLED=0 go build -o gobgp github.com/osrg/gobgp/cmd/gobgp' @echo Finished building gobgp. else- cd vendor/github.com/osrg/gobgp/gobgp && \- CGO_ENABLED=0 GOARCH=$(GOARCH) GOOS=linux go build -o gobgp+ go get -u github.com/osrg/gobgp && \
go get -u github.com/osrg/[email protected] && \
comment created time in 19 days
Pull request review commentcloudnativelabs/kube-router
merge gobgp-update into master
endif gobgp: ifeq "$(BUILD_IN_DOCKER)" "true" @echo Building gobgp- $(DOCKER) run -v $(PWD)/vendor:/go/src -w /go/src/github.com/osrg/gobgp/gobgp $(DOCKER_BUILD_IMAGE) \- sh -c 'GOARCH=$(GOARCH) CGO_ENABLED=0 go build -o gobgp'+ $(DOCKER) run -v $(PWD):/go/src/github.com/cloudnativelabs/kube-router -w /go/src/github.com/cloudnativelabs/kube-router $(DOCKER_BUILD_IMAGE) \+ sh -c 'go get -u github.com/osrg/gobgp && GOARCH=$(GOARCH) CGO_ENABLED=0 go build -o gobgp github.com/osrg/gobgp/cmd/gobgp'
do you want to version lock the go-get call here?
sh -c 'go get -u github.com/osrg/[email protected] && GOARCH=$(GOARCH) CGO_ENABLED=0 go build -o gobgp github.com/osrg/gobgp/cmd/gobgp'
comment created time in 19 days
issue openedrspamd/rspamd
[Feature] Support Prometheus metrics
Summary
Currently rspamd only supports graphite metrics, it would be great if there were support for https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format metrics as well
Motivation
We use prometheus to monitor systems and would like to monitor rspamd as well.
Describe alternatives you've considered
Setting up graphite and pull via prometheus from there is not viable as it requires additional services to maintain.
Additional context
Some implementations how this could look like as a lua-plugin: https://github.com/knyar/nginx-lua-prometheus/blob/master/prometheus.lua https://github.com/tarantool/prometheus
created time in 19 days
issue closedSabayon/genkernel-next
The ebuild in Gentoo depends on lvm2, is there a way to make this optional?
closed time in 19 days
mrueg
push eventmrueg/prometheus-docs
commit sha 03aa18443cbad2e995413b505ae1ea8a122226ca
Dovecot 2.3.11+ can expose metrics natively https://doc.dovecot.org/configuration_manual/stats/openmetrics/ https://dovecot.org/doc/NEWS Signed-off-by: Manuel Rüger <[email protected]>
push time in 19 days
pull request commentdovecot/core
Make metrics compliant with OpenMetrics' standards
This is how metrics currently look like, the suggested test in https://www.robustperception.io/checking-openmetrics-output-is-valid passes. The only item I'm not super sure about here are the timestamps. Do they need to be divided by 10e6 (I think the suggestion is to have them in seconds as well)?
# HELP process_start_time_seconds Dovecot stats service uptime
# TYPE process_start_time_seconds gauge
process_start_time_seconds 778 1599262064097
# HELP dovecot_build Dovecot build information
# TYPE dovecot_build info
dovecot_build_info{version="2.3.11.3",revision="502c39af9"} 1 1599262064097
# HELP dovecot_storage_http_gets Total number of all events of this kind
# TYPE dovecot_storage_http_gets counter
dovecot_storage_http_gets_total{method="get"} 0 1599262064097
# HELP dovecot_storage_http_gets_duration_seconds Total duration of all events of this kind
# TYPE dovecot_storage_http_gets_duration_seconds counter
dovecot_storage_http_gets_duration_seconds_total{method="get"} 0.000000 1599262064097
# HELP dovecot_imap_command Total number of all events of this kind
# TYPE dovecot_imap_command counter
dovecot_imap_command_total 0 1599262064097
# HELP dovecot_imap_command_duration_seconds Total duration of all events of this kind
# TYPE dovecot_imap_command_duration_seconds counter
dovecot_imap_command_duration_seconds_total 0.000000 1599262064097
# HELP dovecot_push_notifications Total number of all events of this kind
# TYPE dovecot_push_notifications counter
dovecot_push_notifications_total 0 1599262064097
# HELP dovecot_push_notifications_duration_seconds Total duration of all events of this kind
# TYPE dovecot_push_notifications_duration_seconds counter
dovecot_push_notifications_duration_seconds_total 0.000000 1599262064097
# HELP dovecot_push_notification_http_finished Total number of all events of this kind
# TYPE dovecot_push_notification_http_finished counter
dovecot_push_notification_http_finished_total 0 1599262064097
# HELP dovecot_push_notification_http_finished_duration_seconds Total duration of all events of this kind
# TYPE dovecot_push_notification_http_finished_duration_seconds counter
dovecot_push_notification_http_finished_duration_seconds_total 0.000000 1599262064097
# EOF
comment created time in 19 days
pull request commentmoby/moby
Add support for zstd compressed layers
@cpuguy83 is there an issue for switching to containerd for image management? If so, could this issue be linked here and added to v21.x?
comment created time in 19 days
pull request commentmoby/moby
dockerd: add --print-default-{seccomp,apparmor} profile
@cpuguy83 this would be nice to have in v21.x
comment created time in 19 days
push eventmrueg/dovecot-core
commit sha d2e50f670fb7a5cdf1f518e2ad798baba95dd2d7
More compatibility fixes * Add missing # EOF * Switch content type to openmetrics-text * Drop illegal newlines
commit sha df7c85f6fc625f51a489ed76e86a046db3b44480
Drop superfluous suffixes from HELP/TYPE
push time in 19 days
issue commentmoby/moby
Adding time namespace to the containers
@cpuguy83 with time namespace being available in recent kernels (https://lwn.net/Articles/779104/) could this be something for moby/docker v21.x?
comment created time in 19 days
push eventmrueg/client_python
commit sha 17a1363afab4dc695023bb6fff53cb39b661965a
openmetrics: Throw error on blank line As per current spec draft blank lines are not allowed Signed-off-by: Manuel Rüger <[email protected]>
push time in 19 days
PR opened prometheus/client_python
As per current spec draft blank lines are not allowed
pr created time in 19 days
push eventmrueg/client_python
commit sha 6e1e16a7ac98d7a37073c7b0ddd50136f0068993
Just check for a url scheme to allow users to provide a handler.
commit sha 87369398bc1ccb7b22970b8ade92465a39850b5c
Allow a handler to be passed in to carry out a custom request. Allow a custom handler to be provided, so that the caller can provide code which carried out basic auth, https client certificate validation or other arbitrary schemes and access methods such as using different types of proxy.
commit sha 7b0677c02e486bc1a23521d3ee425c5540c0a916
Document new handler parameter to pushgateway function Provide pydoc for the new handler function to the various pushgateway functions, provide parameter descriptions in the documentatation for the push_to_gateway function to avoid excessive copy-and-paste.
commit sha 0be1ec5b5ea8d3ee2aed214b122eb9a510603606
Merge branch 'master' of https://github.com/prometheus/client_python
commit sha 8fcc6bb47c6c84b32fb63ae491e0c10baafa7fef
Rename extras_requires to extras_require
commit sha 530411f858f453ba9a3406f0b25a84a146696695
Merge pull request #123 from mrueg/setuppy Rename extras_requires to extras_require
commit sha 67fe14ade77a78e8a8fcc8dff506f5f8e336d6c0
Remove experimental bit on multiproc
commit sha c37a15c21904334aabc260da6efa3c4f7c927048
Separate default handler code for re-use and add test case for custom handler (refs #120)
commit sha 5914671137716052ac740dd55f174575c1a623aa
Fix relative import error.
commit sha 0c1220aae6e95e6ec8d93f0605819aa4a29959ad
Add 'handlers' package to distribution.
commit sha d8a1694f42f8140ecad80b835208218744da9020
Add 'handler_args' to pass extra informatoin to handler.
commit sha a67bf463c64bb672c0b856f7bf46fbc45bca5714
Merge branch 'master' of https://github.com/prometheus/client_python
commit sha 51b1ab02b48a2efa5d73eba1bc7332a8b160f84b
Remove unnecessary imports.
commit sha e3071c4cf859180a47f3f489ab852a81fbb8857e
Just check for a url scheme to allow users to provide a handler.
commit sha c3de82b60c11520a2768b6df9508cd2910814785
Allow a handler to be passed in to carry out a custom request. Allow a custom handler to be provided, so that the caller can provide code which carried out basic auth, https client certificate validation or other arbitrary schemes and access methods such as using different types of proxy.
commit sha 568f6cab05b68033c376dba07c31a4dcb369a0e0
Document new handler parameter to pushgateway function Provide pydoc for the new handler function to the various pushgateway functions, provide parameter descriptions in the documentatation for the push_to_gateway function to avoid excessive copy-and-paste.
commit sha 814e24d562edb301567098c8be058e33bbd5e6c9
Separate default handler code for re-use and add test case for custom handler (refs #120)
commit sha 9139e82b2aae5d6e87f43943a9fd3bdf459c41e0
Fix relative import error.
commit sha ea1e3e77d962f0a0026a3b1741db118a0d4864dd
Add 'handlers' package to distribution.
commit sha 0ac7442868653bb8e629abeb4534d741ab35e93d
Add 'handler_args' to pass extra informatoin to handler.
push time in 19 days
push eventmrueg/dovecot-core
commit sha fa834163aac82457fbfe4c1fbaf05572c6892bab
More compatibility fixes
push time in 19 days
Pull request review commentdovecot/core
Make metrics compliant with OpenMetrics' standards
openmetrics_export_metric_value(struct openmetrics_request *req, string_t *out, timestamp); break; case OPENMETRICS_METRIC_TYPE_DURATION:- str_printfa(out, " %"PRIu64" %"PRId64"\n",- stats_dist_get_sum(metric->duration_stats),+ str_printfa(out, " %f %"PRId64"\n",
Applied a change to .6f
comment created time in 20 days
push eventmrueg/dovecot-core
commit sha 79561dad92b2d4a6de282079aabdd75127fdbf30
Apply changes requested in review
push time in 20 days
Pull request review commentdovecot/core
Make metrics compliant with OpenMetrics' standards
#include "stats-metrics.h" #include "stats-service-private.h" -#define OPENMETRICS_CONTENT_VERSION "0.0.4"+#define OPENMETRICS_CONTENT_VERSION "0.0.5"
Thanks, fixed!
comment created time in 20 days
push eventmrueg/dovecot-core
commit sha d605cfe41a87b24cbcef2623b348629b573dfa7a
Apply changes requested in review
push time in 20 days
Pull request review commentdovecot/core
Make metrics compliant with OpenMetrics' standards
openmetrics_export_histogram(struct openmetrics_request *req, string_t *out, openmetrics_find_histogram_bucket(metric, i); if (sub_metric != NULL) {- sum += stats_dist_get_sum(sub_metric->duration_stats);+ sum += stats_dist_get_sum(sub_metric->duration_stats)/1000.0;
I can add a comment to it, why it's converted.
comment created time in 20 days
Pull request review commentdovecot/core
Make metrics compliant with OpenMetrics' standards
openmetrics_export_metric_value(struct openmetrics_request *req, string_t *out, timestamp); break; case OPENMETRICS_METRIC_TYPE_DURATION:- str_printfa(out, " %"PRIu64" %"PRId64"\n",- stats_dist_get_sum(metric->duration_stats),+ str_printfa(out, " %f %"PRId64"\n",
Thanks, makes sense, since we only have ms precision.
comment created time in 20 days
Pull request review commentdovecot/core
Make metrics compliant with OpenMetrics' standards
openmetrics_export_metric_value(struct openmetrics_request *req, string_t *out, timestamp); break; case OPENMETRICS_METRIC_TYPE_DURATION:- str_printfa(out, " %"PRIu64" %"PRId64"\n",- stats_dist_get_sum(metric->duration_stats),+ str_printfa(out, " %f %"PRId64"\n",+ stats_dist_get_sum(metric->duration_stats)/1000.0,
To convert from milliseconds to seconds, which is the recommended unit for prometheus metrics. https://prometheus.io/docs/practices/naming/#base-units
comment created time in 20 days
pull request commentprometheus/docs
Dovecot 2.3.11+ can expose metrics natively
@brian-brazil Thanks for looking at the metrics, I've incorporated your feedback into a PR to the upstream project.
comment created time in 20 days
PR opened dovecot/core
running promtool check metrics against the current metric output (2.3.11), it mentions:
dovecot_imap_command_count counter metrics should have "_total" suffix
dovecot_imap_command_count non-histogram and non-summary metrics should not have "_count" suffix
dovecot_imap_command_duration_usecs_sum counter metrics should have "_total" suffix
dovecot_imap_command_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix
dovecot_push_notification_http_finished_count counter metrics should have "_total" suffix
dovecot_push_notification_http_finished_count non-histogram and non-summary metrics should not have "_count" suffix
dovecot_push_notification_http_finished_duration_usecs_sum counter metrics should have "_total" suffix
dovecot_push_notification_http_finished_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix
dovecot_push_notifications_count counter metrics should have "_total" suffix
dovecot_push_notifications_count non-histogram and non-summary metrics should not have "_count" suffix
dovecot_push_notifications_duration_usecs_sum counter metrics should have "_total" suffix
dovecot_push_notifications_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix
dovecot_stats_uptime_seconds counter metrics should have "_total" suffix
dovecot_storage_http_gets_count counter metrics should have "_total" suffix
dovecot_storage_http_gets_count non-histogram and non-summary metrics should not have "_count" suffix
dovecot_storage_http_gets_duration_usecs_sum counter metrics should have "_total" suffix
dovecot_storage_http_gets_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix
There was also feedback from a Prometheus' developer in https://github.com/prometheus/docs/pull/1738#issuecomment-683635557
@jeffpc @sirainen
pr created time in 20 days
push eventmrueg/dovecot-core
commit sha fe21413485616d7b515a5cebd0c19566514db879
lib-index: Fix deadlock when expunging mails and adding lots of data to cache This practically happened only when dovecot.index.cache contents were lost and they were being re-filled while mails were also being expunged. Broken by 9efb99924d0b7de27ca83e373f2290f3dd5b22cf
commit sha 43b66273885cf1846bd2742edfadc6da6d85e217
Make metrics compliant with OpenMetrics' standards promtool check metrics mentions: dovecot_imap_command_count counter metrics should have "_total" suffix dovecot_imap_command_count non-histogram and non-summary metrics should not have "_count" suffix dovecot_imap_command_duration_usecs_sum counter metrics should have "_total" suffix dovecot_imap_command_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix dovecot_push_notification_http_finished_count counter metrics should have "_total" suffix dovecot_push_notification_http_finished_count non-histogram and non-summary metrics should not have "_count" suffix dovecot_push_notification_http_finished_duration_usecs_sum counter metrics should have "_total" suffix dovecot_push_notification_http_finished_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix dovecot_push_notifications_count counter metrics should have "_total" suffix dovecot_push_notifications_count non-histogram and non-summary metrics should not have "_count" suffix dovecot_push_notifications_duration_usecs_sum counter metrics should have "_total" suffix dovecot_push_notifications_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix dovecot_stats_uptime_seconds counter metrics should have "_total" suffix dovecot_storage_http_gets_count counter metrics should have "_total" suffix dovecot_storage_http_gets_count non-histogram and non-summary metrics should not have "_count" suffix dovecot_storage_http_gets_duration_usecs_sum counter metrics should have "_total" suffix dovecot_storage_http_gets_duration_usecs_sum non-histogram and non-summary metrics should not have "_sum" suffix Feedback from a Prometheus' developer: https://github.com/prometheus/docs/pull/1738#issuecomment-683635557
push time in 20 days
pull request commenthelm/charts
[stable/coredns] Let externalIPs be configurable
/approve
comment created time in 21 days
starteddoncabreraphone/victorhugo
started time in 21 days
pull request commentscottrigby/prometheus-helm-charts
Rename prometheus-operator chart to kube-prometheus
I guess since it's a chart, we might be able to "omit" kube- completely. How about prometheus-stack?
comment created time in 21 days
issue commentkubernetes/website
Document the SupportPodPidsLimit feature
I would like to help out documenting this. Not sure where's the best place to put it though. Do you feel this is closer to a node feature or resource limits?
comment created time in 22 days
startedFairwindsOps/goldilocks
started time in 22 days
startedgrafana/helm2-grafana
started time in 22 days
pull request commenthelm/charts
[stable/grafana] deprecate chart
@zanhsieh out of curiosity, why is the repo called helm2? Is there one for helm3?
comment created time in 22 days
startedplunder-app/kube-vip
started time in 22 days
issue openedaquasecurity/linux-bench
No binaries are uploaded to github
It seems like the deployment process does not upload binaries to github.
created time in 22 days
PR opened aquasecurity/linux-bench
This would allow to get arm/arm64 binaries on the next github release as well.
pr created time in 22 days
startedjasonumiker/k8s-plus-aws-gitops
started time in 23 days
pull request commenthelm/charts
[stable/coredns] Let externalIPs be configurable
/ok-to-test
comment created time in 23 days
PR opened prometheus/docs
https://doc.dovecot.org/configuration_manual/stats/openmetrics/ https://dovecot.org/doc/NEWS
pr created time in 24 days
startedzalando-incubator/kube-metrics-adapter
started time in 24 days
push eventmrueg/kube-state-metrics
commit sha de87bd89375ff97fd1d043e1ffa0cd44deb4622b
Generate version from git tag This drop the need to maintain a separate version file. See also: https://github.com/kubernetes/kube-state-metrics/issues/1198
push time in 25 days
push eventmrueg/kube-state-metrics
commit sha 3c265b95f04116ce3b2e9f26f2011a669520cde3
Generate version from git tag This drop the need to maintain a separate version file. See also: https://github.com/kubernetes/kube-state-metrics/issues/1198
push time in 25 days
push eventmrueg/kube-state-metrics
commit sha 00158f66837a4dc3848f7bb9e159a30207a19c8e
Generate version from git tag This drop the need to maintain a separate version file. See also: https://github.com/kubernetes/kube-state-metrics/issues/1198
push time in 25 days
PR opened kubernetes/kube-state-metrics
What this PR does / why we need it: This drop the need to maintain a separate version file.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially resolves: https://github.com/kubernetes/kube-state-metrics/issues/1198
pr created time in 25 days