profile
viewpoint

DefinitelyTyped/DefinitelyTyped 28303

The repository for high quality TypeScript type definitions.

mjbvz/awesome-nodejs 1

:zap: Delightful Node.js packages and resources

mjbvz/learnopencv 1

Learn OpenCV : C++ and Python Examples

mjbvz/markdown-it 1

Markdown parser, done right. 100% CommonMark support, extensions, syntax plugins & high speed

mjbvz/after-dark-css 0

Recreating After Dark screensavers with CSS3.

mjbvz/angular2-inline 0

VSCode extension that adds syntax highlighting for inline Angular2 templates.

mjbvz/Bracket-Pair-Colorizer-2 0

Bracket Colorizer Extension for VSCode

push eventmicrosoft/vscode-typescript-next

Azure Pipelines

commit sha 71a9e5ecc828b919636a67f7a3a99ff2de6d229b

Publishing version bump ***NO_CI***

view details

push time in an hour

issue openedmicrosoft/vscode

Test: add missing imports and remove unused source actions

Refs: #95831

  • [ ] anyOS
  • [ ] anyOS

Complexity: 3


Summary This iteration, we added two new source actions: add missing imports and Remove all unused code. This actions let you trigger add missing imports or remove unused from anywhere in a file

You can also use them with editor.codeActionsOnSave or configure a keybinding for them

    {
        "key": "ctrl+shift+i",
        "command": "editor.action.sourceAction",
        "args": {
            "kind": "source.addMissingImports",
            "apply": "first"
        }
    },

Test these new source actions and their behavior. Add missing imports should pretty much always work (although it may not select the ideal import in all cases).

Remove all unused code has more limitations due to current TypeScript APIs

created time in an hour

push eventmicrosoft/vscode

Matt Bierner

commit sha aa803039784c1ca4ec2ac3c87bd381fc0d2acec7

Fix scheme for webview test

view details

Matt Bierner

commit sha 2aa26b1a1f775772a956b7bca0063800313d6c01

Reuse reviveUri

view details

push time in 2 hours

issue commentmicrosoft/TypeScript

Enable node typings if file starts with node shebang

Similar to https://github.com/microsoft/TypeScript/issues/30902

The issue seems to be that we aren't picking up any signals that these JS files should have node apis enable

As a workaround, you can either npm install @types/node into your workspace or create a jsconfig that explicitly includes the node typings:

{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es2016",
        "jsx": "preserve",
    },
    "exclude": [
        "node_modules",
        "**/node_modules/*"
    ],
    "typeAcquisition": {
        "include": [
            "node"
        ]
    }
}
NightMachinary

comment created time in 2 hours

issue commentmicrosoft/vscode

Error opening images on remotes

@alexdima We actually need to call it from the main processes. This is where the protocol for registering local resources in webviews is registered: https://github.com/microsoft/vscode/blob/75fb631e423ea478a726bd5e8cf12dba8e10487b/src/vs/platform/webview/electron-main/webviewProtocolProvider.ts#L26

mjbvz

comment created time in 2 hours

issue commentmicrosoft/vscode

Markdown Preview not loading in Codespaces (Brave Browser)

So it works when you disable Brave Shield? If so, this sounds like a bug with Brave Shield to me

joshspicer

comment created time in 2 hours

issue closedmicrosoft/vscode-extension-samples

Fix typo in commit message

Change Recomend to Recommend in mjbvz@9819038.

closed time in 2 hours

issammani

issue commentmicrosoft/vscode-extension-samples

Fix typo in commit message

Commit message support best effort spelling :)

issammani

comment created time in 2 hours

issue commentmicrosoft/vscode

refactoring of imports on filename change

Please fill out the issue template and share a code example

/needsMoreInfo

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

bkilinc

comment created time in 2 hours

issue commentmicrosoft/typescript-lit-html-plugin

html is not defined

You need to import some library that defines html, for example: https://github.com/Polymer/lit-html

jenstornell

comment created time in 2 hours

issue closedmicrosoft/typescript-lit-html-plugin

html is not defined

I use Electron with NodeJS

module.exports = {
  snippet: () => {
    return html`<div>
      </div>`;
  },
};

html is not defined

closed time in 2 hours

jenstornell

issue commentmicrosoft/vscode

Error opening images on remotes

@deepak1556 I've reopened #89038 to track switching back over to use a protocol from the main process. I want someone to verify that this issue has been fixed for May however

mjbvz

comment created time in 2 hours

issue commentmicrosoft/vscode

Webview is unable to load resources while reconstructing after a reload

Had to revert this fix due to #98768

Will revisit for June

akonwi

comment created time in 2 hours

issue commentmicrosoft/TypeScript

TS Server fatal error: Cannot read property 'get' of undefined

Does this reproduce in the latest VS Code insiders build which includes TypeScript 3.9?

shandysiswandi

comment created time in 2 hours

push eventmicrosoft/vscode

Matt Bierner

commit sha af5002501a901839dc610d976e4b92c5cc27fdcf

Move back to use renderer-side protocol for loading resources in webviews Fixes #98768 The protocol in the main process cannot correctly load remote resources from the workspace at the moment. Reverting to use the renderer side protocol which can handle this correctly

view details

push time in 2 hours

issue closedmicrosoft/vscode

Error opening images on remotes

@mjbvz this happens for me 100% of the time when using Remote - WSL. If I open a folder locally I can view the images. Trying to open any images when remote give this error.

There are no errors in the console.

Using latest Insiders

Version: 1.46.0-insider (user setup)
Commit: 9e439b13d5784538333bee044ca1d1a992bc1c90
Date: 2020-05-28T18:44:47.151Z
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Originally posted by @chrisdias in https://github.com/microsoft/vscode/issues/95736#issuecomment-635629621

closed time in 2 hours

mjbvz

issue commentmicrosoft/vscode

Error opening images on remotes

Thanks @alexdima! I tried this but it looks like RemoteAuthoritiesImpl._hosts and _ports are empty in this case, so the resolved uri ends up being:

vscode-remote-resource://undefined:undefined/vscode-remote-resource?path%3D%252Fworkspaces%252Fvscode-docs%252Fdocs%252Fcontainers%252Fimages%252Fregistries%252Fazure-repository-context-menu.png

I'm checking in the change that moves us back to using the render side vscode-resource scheme now. Will continue looking into this for June

mjbvz

comment created time in 2 hours

push eventmicrosoft/vscode

Matt Bierner

commit sha eb099962389a28a5f32490a530adae05b8d25851

Move custom editor provider out of proposed to main api For #77131

view details

push time in 3 hours

issue commentmicrosoft/vscode

Auto-update Javascript paths fails

Please share your project or a small example project that demonstrates the issue

mjstelly

comment created time in 3 hours

push eventmicrosoft/vscode

Matt Bierner

commit sha f4a8d2e0b1f12b75ef27aaf37641920b06a6117a

Update markdown grammar

view details

Matt Bierner

commit sha 05d6fb66344eb5611969bc24ae6e53581eb294d4

Support new TS proposed API for refactorings For https://github.com/microsoft/TypeScript/pull/38378/files#diff-121b46a8c0f71b73817f429b57e27e61R553

view details

push time in 4 hours

issue commentmicrosoft/vscode-pull-request-github

[Remote] Blank Pull Request view

I believe this is the same issue as https://github.com/microsoft/vscode/issues/98768

tfenster

comment created time in 4 hours

push eventmicrosoft/vscode-markdown-tm-grammar

Matt Bierner

commit sha a7e4475626a505472c76d18e0a1b3cfcf46f9cf9

Rebuild

view details

push time in 6 hours

pull request commentmicrosoft/vscode-markdown-tm-grammar

Support Erlang and Elixir fenced code blocks

Thanks!

jayjun

comment created time in 6 hours

push eventmicrosoft/vscode-markdown-tm-grammar

Tan Jay Jun

commit sha b7bd5df45abf8b0e774598801f266e29b476b1d3

Support Erlang and Elixir fenced code blocks

view details

Matt Bierner

commit sha 1235ba474b4def0ccd6d65ebab0dcef2e1c03e70

Merge pull request #75 from jayjun/beam Support Erlang and Elixir fenced code blocks

view details

push time in 6 hours

PR merged microsoft/vscode-markdown-tm-grammar

Support Erlang and Elixir fenced code blocks

Mirrors GitHub Markdown fenced code support for Erlang and Elixir.

io:format("Hello from Erlang~n")
IO.puts("Hello from Elixir")
+3 -1

0 comment

1 changed file

jayjun

pr closed time in 6 hours

pull request commentmicrosoft/vscode-markdown-tm-grammar

fix to use "end" instead of "while"

Closing this as out of date. As I mentioned in the comment, I think we need a different fix for the issue

shskwmt

comment created time in 6 hours

push eventmicrosoft/vscode-markdown-tm-grammar

Tan Jay Jun

commit sha 84c2745afff764b52ca68d75474b6c01c6c926e3

Fix test

view details

Matt Bierner

commit sha e37232649f5cabecea14028a185e9dc223d2b593

Merge pull request #76 from jayjun/test Fix test

view details

push time in 6 hours

PR merged microsoft/vscode-markdown-tm-grammar

Fix test

Travis is failing because var in

const var = 3;

is now scoped to variable.other.constant instead of just variable.

+2 -2

1 comment

1 changed file

jayjun

pr closed time in 6 hours

pull request commentmicrosoft/vscode-markdown-tm-grammar

Fix test

Thanks!

jayjun

comment created time in 6 hours

issue commentmicrosoft/vscode

TS Server fatal error: Debug Failure. False expression.

Does this reproduce in the latest VS Code insiders build?

OYaipen

comment created time in 6 hours

issue closedmicrosoft/vscode

duplicate definitions with "go to definition" when using CommonJS require

Issue Type: <b>Bug</b>

When using the "go to definition" command on a javascript function imported with require, multiple identical definitions are shown which results in a 'peek' instead of jumping to the definition in the other file.
I disabled all extensions and created two minimal javascript files which demonstrate this. See image below:

Annotation 2020-05-31 223931 When I select the second definition, nothing changes. The filename and function that are displayed are identical. Here's a screenshot anyway: Annotation 2020-05-31 224352

Code from screencap:

index.js

const importedFoo = require('./fooFile');

importedFoo.foo(4);

fooFile.js

exports.foo = function (x) {
    return x + 5;
}

VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:27:35.169Z) OS version: Windows_NT x64 10.0.18362

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (12 x 3498)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 15.90GB (8.07GB free)
Process Argv
Screen Reader no
VM 0%

</details>Extensions: none <!-- generated by issue reporter -->

closed time in 6 hours

bbukaty

issue commentmicrosoft/vscode

duplicate definitions with "go to definition" when using CommonJS require

Should already be fixed in VS Code insiders (which includes TypeScript 3.9)

bbukaty

comment created time in 6 hours

push eventmicrosoft/vscode-typescript-next

Azure Pipelines

commit sha 35df016146d3a29100b62ed4b195d930fac26aa6

Publishing version bump ***NO_CI***

view details

push time in a day

issue commentmicrosoft/vscode

Error opening images on remotes

In remote scenarios, files in the workspace have urls such as:

vscode-remote://vscode-ssh+localhost/path/to/file.png

We can read uris that have the vscode-remote scheme in our renderer processes (there is a file system provider registered for them). However it looks like we currently cannot read this sort of url in the main process

mjbvz

comment created time in 2 days

push eventmicrosoft/vscode-typescript-next

Azure Pipelines

commit sha 009ccb5cdfd653410666a49731860fbfb46da677

Publishing version bump ***NO_CI***

view details

push time in 2 days

push eventmicrosoft/vscode

Matt Bierner

commit sha 50f907f0ba9b0c799a7c1d2f28a625bf30041636

Add more strict typing for webview options We can only send URI components over from the extension host to the renderer process. Make sure the typings reflect that Follow up on #98746

view details

push time in 2 days

issue commentmicrosoft/vscode

Webview blank after a reload

Thanks @tamuratak for the detailed investigation!

I believe I fixed that specific bug with a42fc9031da1c3ffa8a3ed06b45b8ddbe2deb74d. Are you still seeing this when using the latest change from VS Code master?

bcanzanella

comment created time in 3 days

issue closedmicrosoft/vscode

Space before code block in bullet point renders extra whitespace in preview mode

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.45.1
  • OS Version: Ubuntu 18.04

Markdownlint has a rule that says:

MD031/blanks-around-fences: Fenced code blocks should be surrounded by blank

Follow this rule however makes extra vertical white space between bullet points (or padding rather), which looks bad. The same thing happens here in GitHub, which the below example shows.

Could this be fixed in the VS Code markdown preview window to not render this extra padding?

Example: No space before code block (breaks MD031, but looks good in preview)

- Bullet point 1
- Bullet point 2
  ```javascript
  const test = 'test';
  ```
- Bullet point 3

Example: Space before code block (follows MD031, but looks bad in preview)

- Bullet point 1
- Bullet point 2

  ```javascript
  const test = 'test';
  ```

- Bullet point 3

(The easiest way to view this markdown code is via "view source" in your browser)

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

closed time in 3 days

thernstig

issue commentmicrosoft/vscode

Space before code block in bullet point renders extra whitespace in preview mode

Thanks.

VS Code's built-in markdown preview targets commonmark. The current render does match how commonmark renders the file

Specifically see the section of the spec on loose vs tight lists

I'm going to close this as by-design. I suspect that markdown lint rule may need to be reevaluated

thernstig

comment created time in 3 days

push eventmicrosoft/vscode

Matt Bierner

commit sha 2b9c5271a1c1502f54daf742ed07d7b5467b0154

Fix rewriting of vscode-webview-resource schemes when using iframe based webviews

view details

Matt Bierner

commit sha b2cb8682f9c589e8e05e21621d98745c5314bd55

Remove rewriting logic added for #98768 This only appears to work in very specific case

view details

push time in 3 days

issue commentmicrosoft/vscode

Error opening images on remotes

Still happening for me on wsl.

@alexdima When you have a chance, can you please look at my comment https://github.com/microsoft/vscode/commit/b84597ef934cfb97c8846b98e2fd4a91b872d582#commitcomment-39521095.

@deepak1556 @bpasero Unless there is a simple fix, I think we need to revert the work to move the webview resource protocol to the main process. The change has been much more complicated than I anticipated and it is late in the release cycle. Since we are still on electron 7, I don't anticipate this revert to cause any issues problems. We will still have to solve this problem for June

@deepak1556 I just want to check again if there is any way we can get service workers supported in our webviews? The service worker based approach we use to implement webviews on the web is quite elegant

mjbvz

comment created time in 3 days

IssuesEvent

issue commentmicrosoft/vscode

node.js support doesn't work in project-less, global scripts

What does project mean here? Are you using a jsconfig.json project? Just opening a folder?

Can you please share example code (as text) or an example project along with more detailed steps to reproduce the issue

NightMachinary

comment created time in 3 days

issue commentmicrosoft/vscode

Space before code block in bullet point renders extra whitespace in preview mode

Also, the original two examples seem to renderer identically for me in the current VS Code insiders build

Screen Shot 2020-05-29 at 10 04 08 PM

Can you please share a screenshot pointing out what is wrong?

thernstig

comment created time in 3 days

issue commentmicrosoft/vscode

Space before code block in bullet point renders extra whitespace in preview mode

Do you have markdown.preview.breaks enabled? Because by default, the built-in markdown preview should render the markdown:

- Some text
  More text
- Some more text
  Some more text
- Text text
  text text

As

Screen Shot 2020-05-29 at 10 02 20 PM

thernstig

comment created time in 3 days

issue commentmicrosoft/vscode

Webview blank after a reload

@tamuratak Are there any error logs when this happens? Any thing special about your environment or the folder you have open?

I can't repo. The only difference in setup is that I'm on Darwin x64 19.4.0

May-29-2020 21-29-13

bcanzanella

comment created time in 3 days

push eventmicrosoft/vscode-typescript-next

Azure Pipelines

commit sha 46f33ab463eb7b69a9c2c002c3c96e96366066b3

Publishing version bump ***NO_CI***

view details

push time in 3 days

push eventmicrosoft/vscode-extension-samples

Matt Bierner

commit sha 1c9a14f3e481d8fbfeec4a645e476bbaf8333d7a

Fix npm warnings

view details

push time in 3 days

push eventmicrosoft/vscode-extension-samples

Matt Bierner

commit sha d13ffc162830438c27ebbae28aa607a211314bdd

Remove proposed api from semantic-tokens This api has now been finalized

view details

push time in 3 days

push eventmicrosoft/vscode-extension-samples

Matt Bierner

commit sha 2c377b78284fb81263120c4834de8a70d4d58d10

Update extensions to build with typescript 3.9.4 Also fixing some compile errors in configuration-sample

view details

Matt Bierner

commit sha 4efd4272581e5e56b7693b3ea482b86dd203c823

Enable semicolon rule for eslint

view details

Matt Bierner

commit sha 9819038c9e2385bb6ca75c120ef957ae44f8e027

Recomend eslint for all samples

view details

push time in 3 days

push eventmicrosoft/vscode-extension-samples

Matt Bierner

commit sha e3389a5c60a0a1bd2f45f68d79ebe29ba74634af

Add missing eslintrc files

view details

Matt Bierner

commit sha e70997d6c20645774da47549a7da650f3ca74dfd

Update readme

view details

push time in 3 days

push eventmicrosoft/vscode-extension-samples

Matt Bierner

commit sha 5b3fc0a2ff53b53d0ca67396abd51fe9a6af10f1

Remove any

view details

Matt Bierner

commit sha d1168422a0a6409b814e1a89ea852b6923d1eb16

Update custom editor example to use eslint

view details

Matt Bierner

commit sha 7b9a0a8c4c631e393862c3e767c7be26bb2233b2

Use eslint instead of tslint Fixes #266

view details

push time in 3 days

issue closedmicrosoft/vscode-extension-samples

Migrate TSLint to ESLint

TSLint has been deprecated. The migration for vscode already happened with microsoft/vscode#87644. Extension authors are also encouraged to migrate according to the docs, so the samples should be migrated accordingly.

closed time in 3 days

KamasamaK

PR closed microsoft/vscode

add typescript command for missing imports and unused identifiers

I was pretty disappointed by the lack of commands for "Add all missing imports" and "Delete all unused declarations" in typescript, and the consequent lack of the possibility to assign keyboard shortcuts to them. I added those commands, as well as a simple API to add similar commands in the future. You can test those changes by doing CTRL+SHIFT+P -> TypeScript: Add all missing imports / Delete all unused declarations

+134 -0

4 comments

6 changed files

mzdunek93

pr closed time in 3 days

pull request commentmicrosoft/vscode

add typescript command for missing imports and unused identifiers

Should be fixed by #95831

mzdunek93

comment created time in 3 days

pull request commentmicrosoft/vscode

Let core command such as undo/redo be overridden by webviews and notebooks

It's pretty late in the iteration so let's take a look at this for June instead

mjbvz

comment created time in 3 days

issue commentmicrosoft/vscode

Custom webview editor API

@rchiodo yes #93441 tracks a better solution. Until then, you should be able to create untitled files by using an untitled uri that points to a specific file path:

untitled:/absolute/path/to/file/in/workspace.png
mjbvz

comment created time in 3 days

issue commentmicrosoft/vscode

TS Server fatal error: Debug Failure. False expression.

Thank you for investigating this!

Oddly you are not the first person to hit this issue: https://github.com/microsoft/TypeScript/issues/21136

I'll close this as upstream. Please upvote the upstream issue too

thedomi

comment created time in 3 days

issue closedmicrosoft/vscode

I cannot refactor my code with VsCode it gives TypeScript server error(3.8.3) debug failiure

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<semantic> TypeScript Server Error (3.8.3)
Debug Failure. False expression.
Error: Debug Failure. False expression.
    at getPos (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:123278:22)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124064:27)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73104:117)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73104:63)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73104:63)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73104:63)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73142:46)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73172:42)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at Object.visitNodes (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72938:48)
    at assignPositionsToNodeArray (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124069:30)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73166:45)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at visitNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72887:23)
    at visitFunctionBody (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:72991:23)
    at Object.visitEachChild (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:73204:464)
    at assignPositionsToNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124061:30)
    at getNonformattedText (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124045:56)
    at getFormattedTextOfNode (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124026:26)
    at format (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124009:52)
    at computeNewText (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124012:23)
    at c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:123982:89
    at Array.map (<anonymous>)
    at c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:123981:50
    at Array.map (<anonymous>)
    at Object.getTextChangesFromChanges (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:123967:86)
    at ChangeTracker.getChanges (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:123935:45)
    at extractFunctionInScope (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:131617:43)
    at getFunctionExtractionAtIndex (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:131306:24)
    at Object.getEditsForAction (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:130902:28)
    at Object.getEditsForRefactor (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:124598:41)
    at Proxy.getEditsForRefactor (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:135907:32)
    at IOSession.Session.getEditsForRefactor (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:145708:59)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:144531:61)
    at c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:146003:88
    at IOSession.Session.executeWithRequestId (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:145994:28)
    at IOSession.Session.executeCommand (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:146003:33)
    at IOSession.Session.onMessage (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:146027:35)
    at Interface.<anonymous> (c:\Users\Sidra Riaz\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js:147342:27)
    at Interface.emit (events.js:203:13)
    at Interface._onLine (readline.js:316:10)
    at Interface._normalWrite (readline.js:461:12)
    at Socket.ondata (readline.js:172:10)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.45.1 (user setup)
  • OS Version: Windows_NT x64 10.0.18.362

Steps to Reproduce:

  1. Select code which i want to extract/refactor
  2. Press Cntl+Shift+R || right click and select refactor action

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes It fails after disabling extentions

closed time in 3 days

hanzlahabib

issue commentmicrosoft/vscode

I cannot refactor my code with VsCode it gives TypeScript server error(3.8.3) debug failiure

Thanks for testing. The insiders build includes a new TypeScript version which I suspect fixed this issue then. This TypeScript version should also ship with VS Code 1.46

hanzlahabib

comment created time in 3 days

issue closedmicrosoft/vscode

Support TS server returning custom schemes

We have a TS server that can return zip paths (zip:///path/to/module.zip/package.json). We also have a VSCode extension that can handle such paths using a zip: protocol handler.

Using "Go to definition" unfortunately doesn't work because VSCode hardcodes the list of valid protocols, so the zip: protocol is lost as soon as the service client reworks the path.

Looking at the blame history, it looks like the hardcode occurred organically, with the first one being a one-of check, later followed by another one-of workaround. I believe at this time VSCode didn't support custom schemes (at least not visible for extensions), so this made sense. Now, I think it should simply forward all schemes it recognizes. Would you accept a PR to this effect?

Related: https://github.com/microsoft/vscode/issues/59650 Cc: @mjbvz @cspotcode

closed time in 3 days

arcanis

issue commentmicrosoft/vscode

Support TS server returning custom schemes

Should be fixed by #94986 I believe. I only verified the change did not break the normal VS Code JS/TS support.

@elmpp or @cspotcode Can you please verify that the fix also addresses the original problem you were running into?

arcanis

comment created time in 3 days

PR merged microsoft/vscode

Create VsCodeResource for schemed filepaths

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

Continuing from downstream issue 36943, we'd like to see support for custom schemes from TS Server.

Testing: set of steps

+1 -1

1 comment

1 changed file

elmpp

pr closed time in 3 days

push eventmicrosoft/vscode

matt penrice

commit sha 3cb12a21b5711022d304d8ea1252bbf620d6eb15

Create VsCodeResource for schemed filepaths (#94986)

view details

push time in 3 days

issue commentmicrosoft/TypeScript

Intellisense not excluding definitions from `node_modules`

I believe this is the expected behavior if you have the node typings installed, but someone on TS would have to confirm that. Note that if run the script in node, require('constants') also always resolves to the node constants module and not the local constant.js file.

I do see the expected local constants.js file being resolved if I use a relative import: './constants"

mrlubos

comment created time in 3 days

issue commentmicrosoft/vscode

TypeScript refactoring: moving files around messed up with imports

@rebornix Have you seen this again recently? I'm having trouble reproducing this issue?

Also, did you try moving both folders at once or did you move them individually?

rebornix

comment created time in 3 days

issue commentmicrosoft/vscode

Add missing imports quick fix should come after all import actions

Thanks @pfongkye but after I looked into how to better explain the problem, I realized it would require a pretty particular fix so I just went ahead and made it

mjbvz

comment created time in 3 days

push eventmicrosoft/vscode

Matt Bierner

commit sha 5f8e6d0b196b90e7d9b1590284db54c05b4f29b1

Make sure add all missing imports quick fix comes after individual add missing import quick fixes Fixes #98613

view details

Matt Bierner

commit sha dfde221caad8b5cccce0dc76d388704c7337d109

Fix the remove unused source action not removing single unused interfaces

view details

push time in 3 days

issue closedmicrosoft/vscode

Add missing imports quick fix should come after all import actions

Issue Type: <b>Bug</b>

Repo

  1. git clone https://github.com/mjbvz/vscode-98613.git
  2. Open index.ts and trigger a quick fix on abc

Bug

Screen Shot 2020-05-26 at 3 38 59 PM VS Code version: Code - Insiders 1.46.0-insider (b26e0bcf39c1b8faaf770265391b5a387d1d9172, 2020-05-26T17:07:53.549Z)

The 'add all missing import' action is in the middle of the other actions

OS version: Darwin x64 19.4.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>webgl: enabled<br>webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.50GB free)
Process Argv -psn_0_10402283
Screen Reader no
VM 17%

</details> <!-- generated by issue reporter -->

closed time in 3 days

mjbvz

push eventmjbvz/vscode-98613

Matt Bierner

commit sha 15d04fa2ebb40a8881d1b27aa57f20b4099d6b87

Add tsconfig

view details

push time in 4 days

issue commentmicrosoft/vscode

Webview resource: support baseUrl and relative path

I just tested this in the markdown preview and it does seem to work:

Screen Shot 2020-05-29 at 12 36 43 AM

Can you please share an example where it is not working?

rebornix

comment created time in 4 days

issue closedmicrosoft/vscode

JS autocomplete recommends and inserts out-of-context symbols

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.43.2
  • OS Version: Win 10 Enterprise v1909; build 18363.836

Steps to Reproduce:

  1. Create a brand new JS file with the following contents:
const o = {
  f: function() {},
};

  1. Attempt to type in ...args within the f function's parentheses.

Notice how .apply (this is just because apply is the first recommendation) is automatically inserted for each dot that is typed. This can also be reproduced in TS files. The odd part is that .apply doesn't even belong in the argument list. Also, I've noticed that this does not happen with free functions, only ones that are defined within an object.

Reproduction GIF:

776EC0C3-052B-4010-9416-9FAF3D5710EC

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

closed time in 4 days

abbondanza

issue commentmicrosoft/vscode

JS autocomplete recommends and inserts out-of-context symbols

Thanks. Opened https://github.com/microsoft/TypeScript/issues/38840 to track upstream

abbondanza

comment created time in 4 days

issue openedmicrosoft/TypeScript

Unexpected completions returned for function inside object literal

TypeScript Version: 4.0.0-dev.20200529

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms:

  • completion
  • suggest / suggestions
  • completionInfo

Code For the JS:

const z = {
  z: function() {}
}

Inside the function parens, type .

Bug Completions are returned. Also isNewIdentifierLocation is set to false.

No completions are returned when you type . in a top level function

Here are the completions:

[Trace  - 07:24:46.568] <semantic> Sending request: completionInfo (284). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/index.jsx",
    "line": 2,
    "offset": 16,
    "includeExternalModuleExports": true,
    "includeInsertTextCompletions": true,
    "triggerCharacter": "."
}
[Trace  - 07:24:46.597] <semantic> Response received: completionInfo (284). Request took 29 ms. Success: true 
Result: {
    "isGlobalCompletion": false,
    "isMemberCompletion": true,
    "isNewIdentifierLocation": false,
    "entries": [
        {
            "name": "apply",
            "kind": "method",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "arguments",
            "kind": "property",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "bind",
            "kind": "method",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "call",
            "kind": "method",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "caller",
            "kind": "property",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "length",
            "kind": "property",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "name",
            "kind": "property",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "prototype",
            "kind": "property",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "toString",
            "kind": "method",
            "kindModifiers": "declare",
            "sortText": "0"
        },
        {
            "name": "z",
            "kind": "warning",
            "kindModifiers": "",
            "sortText": "6"
        }
    ]
}

created time in 4 days

issue commentmicrosoft/vscode

presence of node_modules folder rises cpu usage to over 100 %

Thanks. Can you share the project that causes this?

humahn

comment created time in 4 days

issue commentmicrosoft/vscode

Webview blank after a reload

I cannot reproduce this and without a repro, I can't really investigate it either

What does this look like from your extension's point of view? Are you still creating a webview? Does it appear in the normal state?

bcanzanella

comment created time in 4 days

issue closedmicrosoft/vscode

Incorrectly marking a declaration as unused

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

Apologies if this is the wrong repo for this.

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.45.1
  • OS Version: Windows 10 & macOS

Steps to Reproduce:

The issue can be observed on CodeSandbox which I guess uses the same underlying code. https://codesandbox.io/s/lucid-http-qscl0?file=/src/App.js

CancelToken is being marked as an unused declaration when it clearly isn't and applying the quick fix breaks the code.

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

closed time in 4 days

andokai

issue commentmicrosoft/vscode

Incorrectly marking a declaration as unused

This is a bug with the typings that axios is shipping

If you enable type checking in the JS file, you'll see the error on new CancellationToken:

'CancelToken' only refers to a type, but is being used as a value here.ts(2693)

If your code is correct, please file a bug against axios to have them fix their typings

andokai

comment created time in 4 days

issue commentmicrosoft/vscode

Slow Compiling/Building for Typescript

Please share steps to reproduce and describe what exactly "slow" means

Madaditya

comment created time in 4 days

issue commentmicrosoft/vscode

Smoketest fails with a webview exception

I don't see that error locally but this could also be the notebooks tests. I don't think we have any smoke tests that use the webview api itself

bpasero

comment created time in 4 days

issue commentmicrosoft/vscode

Smoketest fails with a webview exception

I think this is a css test that is failing. Where are you seeing the webview error? Also in the smoketests?

bpasero

comment created time in 4 days

issue commentmicrosoft/vscode

Custom editor save issues

@caponetto All of these should be fixed now except for the save menu items being disabled on first open. I'm having trouble tracking down why that is still happening

mjbvz

comment created time in 4 days

push eventmicrosoft/vscode

Matt Bierner

commit sha 9721b4ab5cefcd74d85c10f786ea5c682f9c79d6

Make sure custom editor working copy is initially considered dirty For #96503

view details

push time in 4 days

CommitCommentEvent

issue commentmicrosoft/TypeScript

TS Server fatal error: Cannot read property 'get' of undefined

Please just test on VS Code insiders. It includes TypeScript 3.9

gungunfebrianza

comment created time in 4 days

push eventmicrosoft/vscode

Matt Bierner

commit sha 6cc7c452036528620fe9874363ed37770553c230

Make sure we keep around custom editor models while autosave is going on For #96503

view details

Matt Bierner

commit sha 03cbe60992a1d9e362d6bb4b8f67661bb7b2d44e

Fix isReadonly being inverted for custom editors For #96503 This should enable the revert command on windows

view details

push time in 4 days

issue commentmicrosoft/vscode

Incorrectly marking a declaration as unused

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

andokai

comment created time in 4 days

issue commentmicrosoft/TypeScript

TS Server fatal error: Cannot read property 'get' of undefined

Do you see this in VS Code insiders using TypeScript 3.9+?

gungunfebrianza

comment created time in 4 days

issue openedmicrosoft/vscode

web-playground error about activation events

Issue Type: <b>Bug</b>

Repro

  1. On OSS build
  2. Open a workspace

Bug See this error:

Screen Shot 2020-05-28 at 8 04 05 PM

VS Code version: Code - Insiders 1.46.0-insider (9e439b13d5784538333bee044ca1d1a992bc1c90, 2020-05-28T18:46:41.056Z) OS version: Darwin x64 19.4.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.15GB free)
Process Argv -psn_0_16535492 --max-memory=4096
Screen Reader no
VM 14%

</details> <!-- generated by issue reporter -->

created time in 4 days

issue commentmicrosoft/vscode

web-playground error about activation events

Seems to have been triggered by d1a3e6ede65a3d0559b5146b6d7fdaf5a0ad4ac3

mjbvz

comment created time in 4 days

issue closedmicrosoft/vscode

Fix 'The operand of a 'delete' operator must be optional' errors in VS Code codebase

The latest TS 3.9 nightly catches a potential strict null check violation where you delete a property that is not marked optional:

interface Foo {
   x: number;
}

const a: Foo = { x: 3 };

delete a.x // new error here since `x` is not marked as being potentially undefined 

This revealed a few potential errors in our code:

  • [x] vs/workbench/contrib/tasks/browser/taskQuickPick.ts(56,11) @alexr00
  • [x] vs/workbench/contrib/tasks/browser/taskQuickPick.ts(57,11) @alexr00
  • [x] vs/workbench/contrib/tasks/common/taskConfiguration.ts(1204,13) @alexr00
  • [x] vs/workbench/contrib/search/test/browser/queryBuilder.test.ts(954,10) @roblourens
  • [x] vs/workbench/contrib/search/test/browser/queryBuilder.test.ts(955,10) @roblourens
  • [x] vs/workbench/contrib/search/common/searchModel.ts(1103,10) @roblourens
  • [x] vs/workbench/contrib/debug/browser/debugToolBar.ts(274,11) @isidorn
  • [x] vs/workbench/browser/parts/statusbar/statusbarPart.ts(706,12) @bpasero
  • [x] vs/platform/environment/node/argv.ts(253,9) @aeschli
  • [ ] vs/workbench/api/node/extHostDebugService.ts(100,12) @weinand
  • [x] vs/code/electron-main/window.ts(762,11) @bpasero
  • [X] vs/code/electron-main/app.ts(196,12) @mjbvz
  • [x] vs/server/remoteCli.ts(128,9) @aeschli

I've made some initial assignments but please reassign if you are not the correct owner

closed time in 4 days

mjbvz

issue commentmicrosoft/vscode

Fix 'The operand of a 'delete' operator must be optional' errors in VS Code codebase

Closing this since most bugs have been fixed. I believe that TS 4.0 should add this check back

mjbvz

comment created time in 4 days

push eventmicrosoft/vscode

Matt Bierner

commit sha cd41dd1f6065db76c77c6e2f659bb50e6f558dec

Pick up new TS version

view details

push time in 4 days

CommitCommentEvent

push eventmicrosoft/vscode

Matt Bierner

commit sha b84597ef934cfb97c8846b98e2fd4a91b872d582

Make sure we normalize remote uris Fixes #98768 On remote file systems, webviews can recieve requests for resources with scheme such as: `vscode-remote://vscode-ssh+localhost/path/to/file` When the webview resource loading was handled in the renderer, we were able to handle these uris correclty. Now that resource loading happens in the main proccess, we have to normalize them ourselves

view details

push time in 4 days

issue closedmicrosoft/vscode

Error opening images on remotes

@mjbvz this happens for me 100% of the time when using Remote - WSL. If I open a folder locally I can view the images. Trying to open any images when remote give this error.

There are no errors in the console.

Using latest Insiders

Version: 1.46.0-insider (user setup)
Commit: 9e439b13d5784538333bee044ca1d1a992bc1c90
Date: 2020-05-28T18:44:47.151Z
Electron: 7.3.0
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Originally posted by @chrisdias in https://github.com/microsoft/vscode/issues/95736#issuecomment-635629621

closed time in 4 days

mjbvz

push eventmicrosoft/vscode-typescript-next

Azure Pipelines

commit sha 370242eda35eb4311eb3dadfa9a203d9c6900508

Publishing version bump ***NO_CI***

view details

push time in 4 days

issue closedmicrosoft/vscode

TypeScript Intellisense not working for class properties

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version: 1.45.1
  • OS Version: macOS 10.15.4 (Darwin x64 19.4.0)

Steps to Reproduce:

  1. create a typescript class
  2. try to assign existing variable to a class property: not autocomplete will show. Autocomplete works fine outside class definition or inside methods

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

Screenshots (Angular project): Screenshot 2020-05-28 om 17 46 20 Screenshot 2020-05-28 om 17 46 52

closed time in 4 days

ties-s

issue commentmicrosoft/vscode

Error opening images on remotes

@chrisdias I extracted this to a new issue. I can reproduce this with containers as well

mjbvz

comment created time in 4 days

more