profile
viewpoint
Miroslav Stastny miroslavstastny

microsoft/fluentui 9008

We've moved! UI Fabric is now Fluent UI - A set of React components for building Microsoft web experiences.

WICG/open-ui 790

Maintain an open standard for UI and promote its adherence and adoption.

microsoft/fluent-ui-react 373

An ecosystem for building highly customizable enterprise class user interfaces.

stardust-ui/react-old 28

MOVED TO: http://github.com/stardust-ui/react

kolaps33/office-ui-fabric-react 0

React components for building Microsoft web experiences.

miroslavstastny/Architecture-For-Leak-Testing 0

Test for Leaks in Fabric or ODSP using this repository

miroslavstastny/e2dvr 0

E2/OpenWebif DVR Frontend

miroslavstastny/fluentui 0

React components for building Microsoft web experiences.

issue openedmicrosoft/fluentui

Debug panel does not show any styles if cache is used

Environment Information

  • Package version(s): 0.51.0

Please provide a reproduction of the bug in a codepen:

https://codesandbox.io/s/debug-styles-cache-r5fbs

<!-- Providing an isolated reproduction of the bug in a codepen makes it much easier for us to help you. Here are some ways to get started:

  • Go to https://aka.ms/fluentpen for a starter codepen
  • You can also use the "Export to Codepen" feature for the various components in our documentation site.
  • See http://codepen.io/dzearing/pens/public/?grid_type=list for a variety of examples

Alternatively, you can also use https://aka.ms/fluentdemo to get permanent repro links if the repro occurs with an example. (A permanent link is preferable to "use the website" as the website can change.) -->

Actual behavior:

Have two identical Buttons rendered side by side. Use FUI's CSSInJS debug tool to inspect styles of the two components. One of them does not show any styles: image

Expected behavior:

Both components show used styles

created time in 9 hours

Pull request review commentmicrosoft/fluentui

feat(Skeleton): add base skeleton components

 export * from './MenuButton/menuButtonBehavior';  export * from './SplitButton/splitButtonBehavior'; +export * from './Skeleton/skeletonBehavior';+export { skeletonBehavior } from './Skeleton/skeletonBehavior';
assuncaocharles

comment created time in 11 hours

Pull request review commentmicrosoft/fluentui

Added undo and redo features to UI builder

 export const Designer: React.FunctionComponent = () => {     dispatch({ type: 'SELECT_PARENT' });   }, [dispatch]); +  const handleUndo = () => {+    const action = history.pop();+    if (!action) {+      return;+    }++    dispatch({+      type: 'UNDO',+      jsonTree: action,

With history in state, this will have just type.

vyhnalekl

comment created time in 11 hours

Pull request review commentmicrosoft/fluentui

Added undo and redo features to UI builder

 type DesignerState = {   codeError: string | null; }; +const history = [];

What is the motivation for having history and redo as global variables? I would rather have them as part of the state. Whenever those are changed, the component is rerendered anyway.

vyhnalekl

comment created time in 11 hours

Pull request review commentmicrosoft/fluentui

Replace compose with a simpler set of helpers (not export impacted, included under /next folder)

+import * as React from 'react';+import { GenericDictionary } from './types';++/**+ * Ensures that the given slots are represented using object syntax. This ensures that+ * the object can be merged along with other objects.+ * @param props - The incoming props+ * @param shorthandPropNames - An array of prop names to apply simplification to+ */+export const simplifyShorthand = (props: GenericDictionary, shorthandPropNames?: string[]) => {+  let newProps = props;++  if (shorthandPropNames && shorthandPropNames.length) {+    newProps = {+      ...props,+    };+    for (const propName of shorthandPropNames) {+      const propValue = props[propName];++      if (propValue !== undefined && (typeof propValue !== 'object' || React.isValidElement(propValue))) {+        newProps[propName] = { children: propValue };

v0 shorthands can map to a different prop based on config: https://github.com/microsoft/fluentui/blob/10a4c280bd1feb94a149e35555d0539d55ff24a8/packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx#L579-L581 and also supports an array collections: https://github.com/microsoft/fluentui/blob/10a4c280bd1feb94a149e35555d0539d55ff24a8/packages/fluentui/react-northstar/src/components/Menu/Menu.tsx#L389-L391

Do you plan to support these as well?

dzearing

comment created time in 2 days

Pull request review commentmicrosoft/fluentui

Replace compose with a simpler set of helpers (not export impacted, included under /next folder)

+# @fluentui/react-compose++`@fluentui/react-compose` is a library of utilities for composing Fluent UI components.++## A basic component walkthrough++Building a recomposable component requires that we build legos; we put them together, but we let others put them together how they may need. Here's what's needed:++- **State hooks** - all processing of the component should be done within one or more reusable hooks. The hooks should be allowed to manipulate the state in some reusable way, so that recomposing the component can be easily done.+- **Render function** - a function which takes in final state and returns JSX. (e.g. `renderButton`)+- **Component factory function** - a create function which returns `{ state, render }` parts for creating the component. This is used to scaffold a new version of the component as needed.+- **Style hooks** - hooks which can take in styles and provide appropriate classnames to the anatomy of the component.++With these building blocks, you can compose or recompose the component in numerous ways.++### Simple example++A render function:++```jsx+const renderButton = state => {+  return <button {...state} />;+};+```++A hook which can manipulate the state (defining accessibility and behaviors):++```jsx+const useButton = state => {+  // If the button is rendered as something besides a button or anchor, make it focusable.+  if (state.as !== 'button' && state.as !== 'a') {+    state.tabIndex = 0;+  }+};+```++A factory function sets up the state and render function:++```jsx+const createButton = (userProps, ref, defaultProps) => {+  const state = _.merge({}, defaultProps, userProps);++  // Apply button behaviors.+  useButton(state);++  return { state, render };
  return { state, render: renderButton };
dzearing

comment created time in 3 days

push eventkolaps33/office-ui-fabric-react

Miroslav Stastny

commit sha fc08437bd78c7c591223979fd2528ff59814ef26

merge aa and axe errors

view details

push time in 6 days

MemberEvent

Pull request review commentmicrosoft/fluentui

Feat/Detect when focus goes to body

 export const Designer: React.FunctionComponent = () => {     }   }, []); +  const handleCanvasMessage = (canvasMessage: string) => setCanvasMessage(canvasMessage);

You should use useCallback with empty dependencies array to have referentially stable callback between rerenders.

c33k

comment created time in 7 days

PR merged microsoft/fluentui

A

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

+6600 -1351

0 comment

117 changed files

assuncaocharles

pr closed time in 7 days

push eventmicrosoft/fluentui

Luis Marroquin

commit sha 6d97a6dd63602425eff28123a9d58c5717422902

Documentation fixes ResponsiveMode `Large` and `Small` to `large` and `small` (#14219) * Renamed ResponsiveMode.Large to ResponsiveMode.large * Renamed ResponsiveMode.Small to ResponsiveMode.small

view details

Caleb Zearing

commit sha 6b6f285bfcd8c6f5df8077605d8ea6b82d45bd85

Copying TeachingBubble to react-next, in preparation for converting to a function component (#14220) * Moving teachingBubble into react-next. * Change files

view details

John Lorenz

commit sha ccb3e8e569d2af1e4bcfa18789ea426927d32e50

adding Roman to codeowners for date time (#14226)

view details

Caleb Zearing

commit sha 0dfa86ddfc41052efb58c5de5eb760f0020c18f8

Updating existing react-next examples to use the newest ones found inside of office-ui-fabric-react (#14217) * Updating existing react-next examples to use newest examples inside of OUFR. * Change files * Removing unused useKeytipsRef import from Ketips.Basic.Example * Changing comment on Change file. * Reverting changes in Keytips.Basic.Example

view details

Michael Loughry

commit sha a35dce221bb1e179dbc068cff67d02f6b75e67f3

Add general comment about refs in function components (#14148) * Add general comment about refs in function components * Change files

view details

Fluent UI Build

commit sha 32119206e8d42aa3690d63a3b4bf4000fcbf09ed

applying package updates

view details

Jacqueline Gaherity

commit sha 91fff79253d0aa6b9b6572abbf7691a04371253c

High contrast light + dark themes (#14193) * High contrast light + dark themes * Change files * High contrast clean up * DetailsList border fix * Merge branch 'master' of https://github.com/microsoft/fluentui into jackieg/high-contrast-themes * Pivots bug fix + high contrast values * Typo fix Co-authored-by: Jackie <jagaheri@microsoft.com>

view details

Micah Godbolt

commit sha 56673c9157fa64c2ac2d8684b0c9f119ee668990

Syntax highlighting a11y (#14139) Updating syntax highlighting to resolve some a11y contrast issues. Bit of a stopgap until we can do a full pass. ![image](https://user-images.githubusercontent.com/1434956/88081730-a9299000-cb35-11ea-8cc8-9ee1533685e5.png)

view details

Micah Godbolt

commit sha 7fb345ceb101cf5b5ad6d046cf95a58195155d17

GroupedList: Added built in keyboard support (#11494) * updated grouped list to be a11y compliant * fixed snaps * Change files

view details

Jon Schectman

commit sha 65b946bd6bc9381f190816307a18d866fa585e37

Result: Add either to help with creation of codemods (#14154) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes Either makes it easy to handle things like failure states since you can return the error and handle it later after preforming several computations. #### Focus areas to test (optional)

view details

Miles Starkenburg

commit sha b42ae30fb2bf82da9dac0acec4e7c61431c59652

Suggestion list clipping fix (#13875) #### Pull request checklist - [x] Addresses an existing issue: Fixes #13590 - [x] Include a change request file using `$ yarn change` #### Description of changes This adds a noop transform that forces hardware acceleration. ##### Before ![Original](https://user-images.githubusercontent.com/3166322/86189360-3f016a80-baf6-11ea-89b5-b8234d2dcd13.gif) ##### After ![with fix](https://user-images.githubusercontent.com/3166322/86189389-4f194a00-baf6-11ea-98dc-d92e79aac54f.gif) #### Focus areas to test

view details

jameelakowsar

commit sha 5679d177d5febc6541806b31592d35a44fb9f139

Charting: Common charting helper base class added (#14177) * common charthelper added to charting package * Change files * change log files Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Rajesh Goriga

commit sha e0cd2a86ed6c914206bbf72766c2bba10473dc92

Charting: Add Accessibility support for Sankey chart (#14196) * Charting: Add Accessibility support for Sankey chart * Change files * Add opacity for selected link Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

Miroslav Stastny

commit sha 076fe4b17268c713ed6db171ba5f11375557220e

Merge remote-tracking branch 'origin/master' into hackathon/ui-builder-a11y

view details

push time in 7 days

delete branch miroslavstastny/fluentui

delete branch : hackathon/builder-ability-attributes

delete time in 7 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha db73f118757e120be217f3cf6874d6447fd1c18b

Hackathon(Builder): ability attributes (#14247) * Copied ability-attributes * ability-attributes: fix build, disable lint * ability-attributes integrated into UI Builder's iframe * AbilityAttributesValidator * Make build happy

view details

push time in 7 days

PR merged microsoft/fluentui

Reviewers
Hackathon(Builder): ability attributes Fluent UI react-northstar

Description of changes

Add ability attributes check to UI builder: image

Focus areas to test

Examples of errors you can test:

  • drop ButtonGroup into a canvas
  • drop Button inside another Button
  • in code editor, delete content prop on a Button
+1994 -4

1 comment

17 changed files

miroslavstastny

pr closed time in 7 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha 0ac0a2f05172e870a12f61d4a40a825fff9d5c67

Make build happy

view details

push time in 7 days

Pull request review commentmicrosoft/fluentui

[Hackathon] simplified narration for ui builder elements

 export const ReaderText: React.FunctionComponent<ReaderTextProps> = ({ selector    React.useEffect(() => {     if (ref.current) {-      const t = ref.current.ownerDocument.querySelector(selector)?.textContent;-      setText(t);+      const element = ref.current.ownerDocument.querySelector(selector);

The ref handling is messy. You don't want to use createRef in a functional component, that created a new ref on each render. You want useRef. With that you cannot have ref.current as a dependency. When do you want the effect to be called? Also run yarn lint in packages/fluentui/react-builder.

jurokapsiar

comment created time in 7 days

PR opened microsoft/fluentui

Reviewers
Hackathon(Builder): ability attributes

Description of changes

Add ability attributes check to UI builder: image

Focus areas to test

Examples of errors you can test:

  • drop ButtonGroup into a canvas
  • drop Button inside another Button
  • in code editor, delete content prop on a Button
+1992 -2

0 comment

16 changed files

pr created time in 7 days

push eventmiroslavstastny/fluentui

Charles Assunção

commit sha 38c49bc5c4b94ada56047144b17edfa5474045e4

feat(builder): add a11y props for all components in the builder (#14210) * feat(builder): add a11y props for all components in the builder * feat(builder): prop name

view details

Charles Assunção

commit sha 02c937c4241bffc0879026d9d4688d1693a87b13

feat(builder): download/upload (#14223) * Documentation fixes ResponsiveMode `Large` and `Small` to `large` and `small` (#14219) * Renamed ResponsiveMode.Large to ResponsiveMode.large * Renamed ResponsiveMode.Small to ResponsiveMode.small * feat(builder): allow save and upload json tree * Update packages/fluentui/react-builder/src/components/Designer.tsx Co-authored-by: Miroslav Stastny <mistastn@microsoft.com> Co-authored-by: Luis Marroquin <mluis651@gmail.com> Co-authored-by: Miroslav Stastny <mistastn@microsoft.com>

view details

Juraj Kapsiar

commit sha 9af4d1bd926953316c4049e90f643c8ac7e926ee

Hackathon: Make UI Builder a bit more accessible (#14222) * remove unused potentialDropTarget * Designer state refactored to immer. showCode commented out * code editing * remove codeError after code change * cleanup types * make ui builder a bit more accessible * much better * Update packages/fluentui/react-builder/src/components/Designer.tsx Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com> * Update packages/fluentui/react-builder/src/components/ReaderText.tsx Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com> Co-authored-by: Miroslav Stastny <mistastn@microsoft.com> Co-authored-by: Juraj Kapsiar <jukapsia@microsoft.com> Co-authored-by: Charles Assunção <junioassuncaocharles@gmail.com>

view details

vyhnalekl

commit sha b944a55a31a8730a9c1655413dd02b888a1d050b

Grouped components in left-side menu into a Tree (#14213) * Grouped components in left-side menu into a Tree * Changed config representation, added expanding to component tree * Removed some changes * Added child components into the groups * Removed unused code * Addressed comments * Code refactoring

view details

vyhnalekl

commit sha c8e35b5d60352aec377ab2f1f3ae992f621b644a

Fixed search (#14245)

view details

Miroslav Stastny

commit sha 0596e9afcc8c7d7adaec9725e88895efa9e963c4

Merge remote-tracking branch 'upstream/hackathon/ui-builder-a11y' into hackathon/builder-ability-attributes

view details

push time in 7 days

push eventmicrosoft/fluentui

vyhnalekl

commit sha c8e35b5d60352aec377ab2f1f3ae992f621b644a

Fixed search (#14245)

view details

push time in 7 days

PR merged microsoft/fluentui

Reviewers
Fixed search after adding Tree Fluent UI react-northstar

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

+4 -3

1 comment

1 changed file

vyhnalekl

pr closed time in 7 days

create barnchmiroslavstastny/fluentui

branch : hackathon/builder-ability-attributes

created branch time in 7 days

PR opened microsoft/fluentui

Hackathon(Builder): a11y

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

+599 -151

0 comment

13 changed files

pr created time in 7 days

push eventmicrosoft/fluentui

vyhnalekl

commit sha b944a55a31a8730a9c1655413dd02b888a1d050b

Grouped components in left-side menu into a Tree (#14213) * Grouped components in left-side menu into a Tree * Changed config representation, added expanding to component tree * Removed some changes * Added child components into the groups * Removed unused code * Addressed comments * Code refactoring

view details

push time in 7 days

PR merged microsoft/fluentui

Reviewers
Grouped components in left-side menu into a Tree Fluent UI react-northstar

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • [ ] Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

+95 -37

2 comments

2 changed files

vyhnalekl

pr closed time in 7 days

push eventkolaps33/office-ui-fabric-react

Miroslav Stastny

commit sha 14670996861c68ca1c47714b9890720710cb57b4

use axe-core directly, add script to iframe

view details

push time in 7 days

pull request commentmicrosoft/fluentui

fix(UIBuilder) maximize view

It fails to load from time to time, investigating...

miroslavstastny

comment created time in 8 days

Pull request review commentmicrosoft/fluentui

feat(builder): download/upload

 export const Designer: React.FunctionComponent = () => {     }   }, [dispatch]); +  const handleUpload = React.useCallback(+    jsonTree => {+      console.log('jsonTree: ', jsonTree);

dispatch logs the action

assuncaocharles

comment created time in 8 days

Pull request review commentmicrosoft/fluentui

feat(builder): download/upload

 const stateReducer: Reducer<DesignerState, DesignerAction> = (draftState, action       treeChanged = true;       break; +    case 'UPLOAD_TREE':+      draftState.jsonTree = action.jsonTree;

always mutate the draft state and return nothing. that's the purpose of immer.

assuncaocharles

comment created time in 8 days

PR opened microsoft/fluentui

Reviewers
fix(UIBuilder) maximize view

Description of changes

UIBuilder Maximize view failed to load because of missing babel. Babel is not required for the maximize view but was a hard dependency in Designer - it is now lazily loaded only when code editor is opened.

Focus areas to test

  • Code editor in UI Builder
  • Maximize view
+9 -2

0 comment

1 changed file

pr created time in 8 days

create barnchmiroslavstastny/fluentui

branch : fix/builder-maximize

created branch time in 8 days

push eventmiroslavstastny/fluentui

Rajesh Goriga

commit sha 7485a3728d69f54dfdc2e1778811065938ddbd20

Charting: Fix sankey chart dark mode text not visble properly (#14082) * Charting: Fix sankey chart dark mode text not visble properly * Add font styles Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

Trip Master

commit sha dd5f32f6b039d1426a73ad686bf87750cfbc4aaa

Codemod utilities - support for arrow functions when changing values in props (#14095) * WIP add transform * add support for arrow functions * Change files Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

Sarah Higley

commit sha 4a6bdec34f0858cec60de3701005ea0706f79d48

Dialog: VoiceOver / aria-modal fix (#14096) * add role document to dialog child * update modal snapshots * Change files

view details

Xu Gao

commit sha 3a9feb3725b79ed39a5c080906da8957e6f1aec0

DetailsList: fix exception in DetailsRow when selection is undefined. (#14088) * fix exception with selection is undefined * Change files

view details

hki-237

commit sha 1c3012b212603f34a8bd7b72f43c66176ab27c23

Conditional for valueInsideDonut (#14093) * Updating valueInsideDonut to be set to yAxisCalloutData if the value is defined * Change files

view details

Micah Godbolt

commit sha f7a19cab16e3d974f5eabd5a74a563dfc6c6e62d

Add aria label to website search box (#14118) * add aria label to searchbox * Change files

view details

Jon Schectman

commit sha 817557b56584d665e7a697d5d81d3b581815241d

CodeMods: Add filtering and improve maybe (#14072) * Codemods: Add in filtering based on cmd line strings * Change files * update maybes null checks * address comments and improve commands structure * fix mod filtering * fix comments

view details

nebhatna

commit sha fda47de92fc2f2dcb825c07e6452aafc87dc9d52

[UnifiedPicker] Fixing the paste logic and updating the example (#14121) * fixing paste logic

view details

Miroslav Stastny

commit sha 4b8d8bc6315978b021f098378231248eae39b156

fix(UI Builder): load babel before loading the UI Builder (#14120)

view details

Elizabeth Craig

commit sha 63b41e907049f38dd65f5cbb027b1be4ade7615c

Start enabling "rules of hooks" lint rules (#14097)

view details

Fluent UI Build

commit sha f584014cfdb4375cc8ee125fe1c8f8daaff430c4

applying package updates

view details

Roman Sudarikov

commit sha 1e1838959a48481860b0d3acfefd71546b7036ec

feat(Datepicker): Add Calendar navigation (#14061) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes Adding arrow buttons for navigation in `DatepickerCalendar`. Adding child components and exposing them in Datepicker props for consumer overrides **UI before** ![image](https://user-images.githubusercontent.com/2802155/87939360-42a26480-ca98-11ea-93b2-4b536277de75.png) **UI after** ![image](https://user-images.githubusercontent.com/2802155/87939289-243c6900-ca98-11ea-9439-99b4441a5bbd.png)

view details

Oleksandr Fediashov

commit sha 2ce05ffc6f2988adfceea3f99c8fee101326f4e6

feat: add imperative handle for Popper, remove warnings (#14131) * feat: add imperative handle for Popper, remove warnings * fix issue, fix UT * fix UTs * add propTypes * update async example

view details

Oleksandr Fediashov

commit sha 9c9ef94404e37645e271d920eb3c715b6adc0f3e

feat: add @fluentui/react-image (#14083) * feat: add @fluentui/react-image * Change files * add API file * fix deps * Update packages/react-image/src/components/Image/useImage.ts Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> * Update packages/react-image/src/components/Image/ImageBase.tsx Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> * Update packages/react-image/tsconfig.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-image/package.json * update types * fix versions Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

view details

Micah Godbolt

commit sha fe2f59ab230033eeaca58bc7c16d5096d922faf7

Best Practices Docs Update Branch (#13887) Major overhaul of component documentation markdown content

view details

Elizabeth Craig

commit sha 41bc48a4656ff7ebff0e4643b26a4fa17215f7ce

Rename release.md to RELEASE_NOTES.md

view details

Elizabeth Craig

commit sha 50b712e1326f93f4d22f81ebdf83fcce48b7f070

Update RELEASE_NOTES.md

view details

Elizabeth Craig

commit sha 7236cfa7f9784c7a8a42d87ca51db9dd16484d06

Update RELEASE_NOTES.md

view details

Trip Master

commit sha f7feb25732b3c959b6da4abd5a6c1dcb020c16a3

Add simple transform functions to change prop values (#14140) * WIP add transform * add general transforms that work with spread * Change files * clean up propHelper * fix unused import Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

Elizabeth Craig

commit sha 7bea3a43f5f01a3aef8a36813b8d88484aa021bc

Enable "rules of hooks" lint rules in react-hooks and utilities; hook fixes (#14099)

view details

push time in 9 days

Pull request review commentmicrosoft/fluentui

Grouped components in left-side menu into a Tree

 type FiberNavigator = FUI.FiberNavigator;  export const EXCLUDED_COMPONENTS = ['Animation', 'Debug', 'Design', 'FocusZone', 'Portal', 'Provider', 'Ref']; +export const COMPONENT_GROUPS = [+  'Surfaces',+  'Content',+  'Layout',+  'Forms',+  'Actionable',+  'Containers',+  'Utilities',+  'Other',+];++export const GET_COMPONENT_GROUP_INDEX = {

This is fragile and hard to maintain, I would prefer single object:

{
  Surfaces: [Popup, Dialog, ...],
  ...
}
vyhnalekl

comment created time in 9 days

create barnchmicrosoft/fluentui

branch : hackathon/ui-builder-a11y

created branch time in 9 days

delete branch miroslavstastny/fluentui

delete branch : chore/builder-immutable-tree

delete time in 9 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 5f80b4d72d88d16bb33af1a33817e199fb61fadf

chore(Builder): immutable tree (#14209) * remove unused potentialDropTarget * Designer state refactored to immer. showCode commented out * code editing * remove codeError after code change * cleanup types

view details

push time in 9 days

PR merged microsoft/fluentui

Reviewers
chore(Builder): immutable tree Fluent UI react-northstar

Description of changes

Refactor Designer in UI Builder to use immutable state.

+512 -551

4 comments

7 changed files

miroslavstastny

pr closed time in 9 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha 107eb1b7dbd10347615704a64ee5f751fb0c91f0

chore: prepare release react-northstar 0.51.0

view details

Fluent UI Build

commit sha 8fae3a54723db0600aa6cf0d3b713f66e4455739

applying package updates

view details

Miroslav Stastny

commit sha 215aed1574db0b0db7d5fe130d19072178855423

@fluentui/react-northstar_v0.51.0

view details

Miroslav Stastny

commit sha bdb1d3a96db34d4fb854457ed2e9e6491753092f

Fix dependencies after react-northstar release

view details

Miroslav Stastny

commit sha 1b333516ecea02b2ed4b7e4e2d03f7286deba6a9

Merge remote-tracking branch 'upstream/master' into chore/builder-immutable-tree

view details

push time in 9 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha bdb1d3a96db34d4fb854457ed2e9e6491753092f

Fix dependencies after react-northstar release

view details

push time in 9 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 215aed1574db0b0db7d5fe130d19072178855423

@fluentui/react-northstar_v0.51.0

view details

push time in 9 days

created tagmicrosoft/fluentui

tag@fluentui/react-northstar_v0.51.0

We've moved! UI Fabric is now Fluent UI - A set of React components for building Microsoft web experiences.

created time in 9 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 107eb1b7dbd10347615704a64ee5f751fb0c91f0

chore: prepare release react-northstar 0.51.0

view details

push time in 9 days

PR opened microsoft/fluentui

Reviewers
chore(Builder): immutable tree Fluent UI react-northstar

Description of changes

Refactor Designer in UI Builder to use immutable state.

+512 -551

0 comment

7 changed files

pr created time in 10 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha da65ee01ea5368cb658875d50804aa15034592af

cleanup types

view details

push time in 10 days

push eventmiroslavstastny/fluentui

Rajesh Goriga

commit sha 7485a3728d69f54dfdc2e1778811065938ddbd20

Charting: Fix sankey chart dark mode text not visble properly (#14082) * Charting: Fix sankey chart dark mode text not visble properly * Add font styles Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

Trip Master

commit sha dd5f32f6b039d1426a73ad686bf87750cfbc4aaa

Codemod utilities - support for arrow functions when changing values in props (#14095) * WIP add transform * add support for arrow functions * Change files Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

Sarah Higley

commit sha 4a6bdec34f0858cec60de3701005ea0706f79d48

Dialog: VoiceOver / aria-modal fix (#14096) * add role document to dialog child * update modal snapshots * Change files

view details

Xu Gao

commit sha 3a9feb3725b79ed39a5c080906da8957e6f1aec0

DetailsList: fix exception in DetailsRow when selection is undefined. (#14088) * fix exception with selection is undefined * Change files

view details

hki-237

commit sha 1c3012b212603f34a8bd7b72f43c66176ab27c23

Conditional for valueInsideDonut (#14093) * Updating valueInsideDonut to be set to yAxisCalloutData if the value is defined * Change files

view details

Micah Godbolt

commit sha f7a19cab16e3d974f5eabd5a74a563dfc6c6e62d

Add aria label to website search box (#14118) * add aria label to searchbox * Change files

view details

Jon Schectman

commit sha 817557b56584d665e7a697d5d81d3b581815241d

CodeMods: Add filtering and improve maybe (#14072) * Codemods: Add in filtering based on cmd line strings * Change files * update maybes null checks * address comments and improve commands structure * fix mod filtering * fix comments

view details

nebhatna

commit sha fda47de92fc2f2dcb825c07e6452aafc87dc9d52

[UnifiedPicker] Fixing the paste logic and updating the example (#14121) * fixing paste logic

view details

Miroslav Stastny

commit sha 4b8d8bc6315978b021f098378231248eae39b156

fix(UI Builder): load babel before loading the UI Builder (#14120)

view details

Elizabeth Craig

commit sha 63b41e907049f38dd65f5cbb027b1be4ade7615c

Start enabling "rules of hooks" lint rules (#14097)

view details

Fluent UI Build

commit sha f584014cfdb4375cc8ee125fe1c8f8daaff430c4

applying package updates

view details

Roman Sudarikov

commit sha 1e1838959a48481860b0d3acfefd71546b7036ec

feat(Datepicker): Add Calendar navigation (#14061) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes Adding arrow buttons for navigation in `DatepickerCalendar`. Adding child components and exposing them in Datepicker props for consumer overrides **UI before** ![image](https://user-images.githubusercontent.com/2802155/87939360-42a26480-ca98-11ea-93b2-4b536277de75.png) **UI after** ![image](https://user-images.githubusercontent.com/2802155/87939289-243c6900-ca98-11ea-9439-99b4441a5bbd.png)

view details

Oleksandr Fediashov

commit sha 2ce05ffc6f2988adfceea3f99c8fee101326f4e6

feat: add imperative handle for Popper, remove warnings (#14131) * feat: add imperative handle for Popper, remove warnings * fix issue, fix UT * fix UTs * add propTypes * update async example

view details

Oleksandr Fediashov

commit sha 9c9ef94404e37645e271d920eb3c715b6adc0f3e

feat: add @fluentui/react-image (#14083) * feat: add @fluentui/react-image * Change files * add API file * fix deps * Update packages/react-image/src/components/Image/useImage.ts Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> * Update packages/react-image/src/components/Image/ImageBase.tsx Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> * Update packages/react-image/tsconfig.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-image/package.json * update types * fix versions Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

view details

Micah Godbolt

commit sha fe2f59ab230033eeaca58bc7c16d5096d922faf7

Best Practices Docs Update Branch (#13887) Major overhaul of component documentation markdown content

view details

Elizabeth Craig

commit sha 41bc48a4656ff7ebff0e4643b26a4fa17215f7ce

Rename release.md to RELEASE_NOTES.md

view details

Elizabeth Craig

commit sha 50b712e1326f93f4d22f81ebdf83fcce48b7f070

Update RELEASE_NOTES.md

view details

Elizabeth Craig

commit sha 7236cfa7f9784c7a8a42d87ca51db9dd16484d06

Update RELEASE_NOTES.md

view details

Trip Master

commit sha f7feb25732b3c959b6da4abd5a6c1dcb020c16a3

Add simple transform functions to change prop values (#14140) * WIP add transform * add general transforms that work with spread * Change files * clean up propHelper * fix unused import Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

Elizabeth Craig

commit sha 7bea3a43f5f01a3aef8a36813b8d88484aa021bc

Enable "rules of hooks" lint rules in react-hooks and utilities; hook fixes (#14099)

view details

push time in 10 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha e0629c29829049a706937732464fb7bdc79ae1fc

code editing

view details

push time in 10 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha 7bc48148aab8d648dbaf403390db7756ea8c38ff

Designer state refactored to immer. showCode commented out

view details

push time in 10 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 4b8d8bc6315978b021f098378231248eae39b156

fix(UI Builder): load babel before loading the UI Builder (#14120)

view details

push time in 16 days

delete branch miroslavstastny/fluentui

delete branch : fix/builder-lazy-babel

delete time in 16 days

PR merged microsoft/fluentui

Reviewers
fix(UI Builder): load babel before loading the UI Builder Fluent UI react-northstar

Description of changes

UI Builder depends on babel being loaded on window. Fetch and load babel before loading the builder.

Focus areas to test

  • UI Builder loads, babel is fetched before loading the builder.
+25 -15

4 comments

3 changed files

miroslavstastny

pr closed time in 16 days

create barnchmiroslavstastny/fluentui

branch : chore/builder-immutable-tree

created branch time in 16 days

PR opened microsoft/fluentui

Reviewers
fix(UI Builder): load babel before loading the UI Builder

Description of changes

UI Builder depends on babel being loaded on window. Fetch and load babel before loading the builder.

Focus areas to test

  • UI Builder loads, babel is fetched before loading the builder.
+25 -15

0 comment

3 changed files

pr created time in 16 days

create barnchmiroslavstastny/fluentui

branch : fix/builder-lazy-babel

created branch time in 16 days

push eventmiroslavstastny/fluentui

shivasai09

commit sha 2d5932ce602ab7c38bf8a6aead53cbd42e296c55

chart hover card content component wrapped in styled component (#14038) * wrapping chartHoverCard in styled component and deleting static Theme * Change files Co-authored-by: v-sivsar <v-sivsar@microsoft.com>

view details

Miroslav Stastny

commit sha 042d257c2ebd8a9353a3c8fc9dfdf39084c498dc

fix(FocusZone): fix EventListener leak (#14031) * fix(FocusZone): fix EventListener leak * changelog * address PR comments * address PR comments

view details

tomi-msft

commit sha 682f1db2c515d0d2f9db036e108fbe316ec09007

Calendar: Fix onBlur event firing on every date click (#13992) * fix calendar props * Change files * Use event.relatedTarget to stop bubbling of onFocus and onBlur event * Use as prop to cast EventTarget type as Node type * update snapshot * Update packages/office-ui-fabric-react/src/components/Calendar/Calendar.tsx Co-authored-by: Xu Gao <xugao0131@hotmail.com> * use elementContains for target comparisons Co-authored-by: Xu Gao <xugao0131@hotmail.com>

view details

John Lorenz

commit sha 30fc4c9ad3b2b9236027b477e27eb742f8419cca

Calendar accessibility fixes (#14032) * adding accessibility fixes for alt+tab to datepicker, turn button -> div if not clickable, and high contrast color selectors * Change files * removing unnecessary !important, fixing two linting errors, fixing high contrast bug in oufr calendar * Change files * addressing comments

view details

Jon Schectman

commit sha a1f0ef7f1f03a6c0a5f66ae093bb2da22726c186

Maybe: Improve then return and remove thenMaybe (#14045) * fix maybe to correctly wrap return value from then * Change files

view details

Caleb Zearing

commit sha bca273168c554d5a4fee1f7a809316b7dabe7007

Updating SpinButton to a function component within React-Next (#13689) * moving files and updating imports * Change files * api update * updates * quick changes * update * update * api update * update * update * update * updating styles * updates * updates * update * update * bug fix * bug fixes * import correction * updates * import change * quick fix * Removing commented code * Change files * change * Update packages/react-next/src/components/SpinButton/SpinButton.base.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/react-next/src/components/SpinButton/SpinButton.styles.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update change/@fluentui-react-next-2020-04-30-15-57-11-feat-spin-button.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * pr feedback * update * Delete @uifabric-file-type-icons-2020-06-22-11-41-59-caperez-filetype_cortex_and_shortcut.json * quick fix * pr feedback * pr feedback * quick fix * Change files * Delete DateMath.test.ts * Delete DateValues.ts * Delete DateMath.ts * fix * Rename TimeConstants.ts to timeConstants.ts * Updates to styles prop. Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>

view details

David Zearing

commit sha 8247d915e42b98aceeeaaf0061c1ce3773bd17fb

useMergedRefs: mergedRefs should mutate the function if any of the merged refs mutate (#14053) * Addressing constantly mutating refs to merge. * refs * Addressing constantly mutating refs to merge. (cherry picked from commit f3ac4ce02ce4ea3f4f475bd4c956f18cd20bafe3) * Change files * oops

view details

Xu Gao

commit sha 06b783216e8652f356324d10fb5bf8c50a7f44c3

Fix publish by syncing with published versions (#14066) * sync * Change files

view details

Rajesh Goriga

commit sha a92d7dc1636d67b1bfe4de640d7d59566d05b4b4

Charting:Add New Sankey chart to charting package (#13982) * Add Sankey chart to charting package * Expose pathColor prop * Change files * Add d3-sankey dependency * Fix tslint * Update yarn.lock file * Fix eslint errors * Fix eslint errors * Update JSX.Element to React.Reactnode Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

jameelakowsar

commit sha 4fc60e6201e26e6b1d318628de1559b20be8f00e

Line chart & Vertical bar chart - high contrast of y axis line styles updated (#14037) * line and vertical charts y axis line high contrast styles updated * Change files * change log * test case of vertical bar chart updated Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Trip Master

commit sha 1601f2c50737814a91a036df964b481f00b23efb

Add transform function for prop renaming utility for codemods (#14067) * WIP add transform * WIP merge * add new prop transform file * Change files * moved general enum case into a transform Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

Fluent UI Build

commit sha 6072a109ca821510a98245709fc722bed102e246

applying package updates

view details

Esteban Munoz

commit sha 34da57c2cd02c1c68bc8ae0aad4b5ee4f6cfea51

(react-flex) Creating new react-flex package (#14051) * creating new react-flex package * updating dependency * adding requested changes * adding requested changes

view details

Elizabeth Craig

commit sha 19d531374c491eb479ddc057312d1771768fe027

Use new service connection in release pipelines (#14070)

view details

hki-237

commit sha bd32dc4495932971f783b6451a723c25d4dfb2b7

Legend hover updates value inside donut chart circle (#14055) * When legend is hovered, center of donut chart updates to the value cooresponding to the legend. * Change files * Modified operator * Add return statement

view details

Elizabeth Craig

commit sha 4e31634d7914e595032111ba15d6fb87750b5f4b

Update release service connection name (#14077)

view details

Oleksandr Fediashov

commit sha 346cd61df2ce2268f4126eab1b31a173904ff4c2

fix: useFocusRects should resolve window inside useEffect (#14063) * fix: useFocusRects should resolve window inside useEffect * Change files * fix API file

view details

Fluent UI Build

commit sha af064fecc6b264f18fefcfc2b181a510b2bfecaf

applying package updates

view details

Xu Gao

commit sha 5874c5755ea454adb9bbea9a5273f1cae5203eda

Panel: pass missing event to onDismiss (#14075) * add missing event * Change files

view details

Jacqueline Gaherity

commit sha 23029b1fa37aac673e664121001c6e15d46bca50

Azure theme style updates across several components (#14014) * 13px across various components, detailslist, datepicker, commandbar, label style updates * Change files * Hiyo's feedback for comments/naming Co-authored-by: Jackie <jagaheri@microsoft.com>

view details

push time in 16 days

Pull request review commentmicrosoft/fluentui

Roster Prototype

+import * as React from 'react';

Rename the file to start with a capital 'R' -> Roster.perf.tsx

vyhnalekl

comment created time in 21 days

Pull request review commentmicrosoft/fluentui

Roster Prototype

+import * as React from 'react';+import Participant from './participant';+import { AcceptIcon } from '@fluentui/react-icons-northstar';++const participants = [+  {+    id: 1,+    title: (+      <Participant+        name="Irving Kuhic"+        role="Software Engineer"+        isMuted+        image="https://s3.amazonaws.com/uifaces/faces/twitter/ariffsetiawan/128.jpg"

For the perf test to be relevant there should be no additional network requests. Use base64 encoded images, similar to this: https://github.com/microsoft/fluentui/blob/8247d915e42b98aceeeaaf0061c1ce3773bd17fb/packages/fluentui/docs/src/examples/components/List/Performance/ListCommon.perf.tsx#L4-L34

vyhnalekl

comment created time in 21 days

push eventmiroslavstastny/fluentui

Fluent UI Build

commit sha ef2d6e26da981f93a3df66c9a2b1cad449cd99ab

applying package updates

view details

Miroslav Stastny

commit sha 15ee28cda5ee81da62a00bde74ece8bbfa3abbc6

fix(FocusZone): fix EventListener leak (v0) (#14044)

view details

push time in 21 days

delete branch miroslavstastny/fluentui

delete branch : fix/focus-zone-leak

delete time in 21 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 042d257c2ebd8a9353a3c8fc9dfdf39084c498dc

fix(FocusZone): fix EventListener leak (#14031) * fix(FocusZone): fix EventListener leak * changelog * address PR comments * address PR comments

view details

push time in 21 days

PR merged microsoft/fluentui

Reviewers
fix(FocusZone): fix EventListener leak

Pull request checklist

  • [x] Addresses an existing issue: Fixes #14025
  • [x] Include a change request file using $ yarn change

Description of changes

Converted key down event handler in FocusZone class from member arrow function to a regular member function to make it equal among class instances to avoid the leak. Fixed in react-focus (v7, v8). react-bindings (v0) was fixed in a separate PR #14044

Focus areas to test

(optional)

+114 -12

8 comments

3 changed files

miroslavstastny

pr closed time in 21 days

issue closedmicrosoft/fluentui

Resource leak in FocusZone

<!-- Thanks for contacting us! We're here to help.

Before you report an issue, check if it's been reported before:

  • Search: https://github.com/microsoft/fluentui/search?type=Issues
  • Search by area or component: https://github.com/microsoft/fluentui/issues/labels

Note that if you do not provide enough information to reproduce the issue, we may not be able to take action on your report. -->

Environment Information

  • Package version(s): @fluentui/react-northstar@0.50.0

Please provide a reproduction of the bug in a codepen:

https://codesandbox.io/s/v050-focus-zone-resource-leak-31gpt

Repro steps

  1. Have a component with two sibling FocusZone components:
<FocusZone>first</FocusZone>
<FocusZone>second</FocusZone>
  1. Mount and unmount the component 5 times.
  2. Check keydown event listeners on html node.

Actual behavior:

After the last unmount, there are 5 keydown event listeners in FocusZone: image

Expected behavior:

After the last unmount, there should be NO event listeners in FocusZone.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low) High

Products/sites affected: (if applicable)

closed time in 21 days

miroslavstastny

push eventmiroslavstastny/fluentui

Luan Nguyen

commit sha e94ddb76a22232c4f574f32d7f8972cfb48e3808

Allow overriding ContextualMenu's internal List's role (#13908) #### Pull request checklist - [X] Addresses an existing issue: Fixes #13971 - [X] Include a change request file using `$ yarn change` #### Description of changes Currently, the `ContextualMenu` control hard-code the `role` attribute of the internal List as `menu`. In my usage, I want to set a different role, specifically `grid`. There's currently no way to achieve this. In this PR, I'm adding a `role` property to the `IContextualMenuListProps` struct. The idea is that the consumer of `ContextualMenu` would provide a custom implementation of `onRenderMenuList` callback. Inside the callback, it can set the `role` attribute to `grid`, before invoking the default renderer. The default renderer inside `ContextualMenu` is modified to honor the `role` property. If `role` is not set, it falls back to `menu`, hence preserving the existing behavior. #### Focus areas to test Added unit tests.

view details

Elizabeth Craig

commit sha 6ddf7d61096e644b7ee3a63abf02629a786a99ac

ESLint: add faster max-len rule (#13994)

view details

Sarah Higley

commit sha 5d63c38662cc26c0518dbe5b7299b1039e0c02ad

Fix Picker action button screen reader issue by updating activedescendant (#13627) * Point picker activedescendant to suggestions action buttons, update render when leaving action buttons * change file * add test for activedescendant on BasePicker * return undefined activedescendant when loading

view details

tomi-msft

commit sha 41c1643be865c1969acacf4d3d896fd80ca29037

Adding CodeSandbox next/northstar templates (#13893) * Add codesandbox template for react-next package * fix version error in package.json * add react-next template to ci.json * add <ThemeProvider> and <Stack> components to fix template rendering * add theme-samples dependency to package.json * fix lint errors in package.json * Add initializeIcons so <SpinButton> can render correctly * Add codesandbox template for react-northstar package components * Update ci.json file with new package * remove unused package and fix index.tsx * Add oufr to package.json * Fix dependency tree to run codesandbox for react-northstar package * Update some package.json dependencies * Update dependencies in react-next template to fix lint errors * Add oufr package to dependencies in package.json * Add react-bindings package to ci.json * fix package order * update package dependencies to fix lint errors * Add explicit typing to index.tsx and clean up json files in both templates * fix lint error * add prettier dependency to react-northstar template * Update just.config.ts file and tsconfig.json file for both templates * update next and northstar templates to use eslint * update package.json

view details

Rajesh Goriga

commit sha a0b451a274e96ecedfb55c13276ee6e5777f75c2

Legends: Remove tab stop on legends for data viz (#14019) * Legends:Skip all legends in data viz as it is confusing to non sighted users as they have just gone through the data viz. * Change files * Update snapshots Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

Fluent UI Build

commit sha ef2d6e26da981f93a3df66c9a2b1cad449cd99ab

applying package updates

view details

Miroslav Stastny

commit sha 15ee28cda5ee81da62a00bde74ece8bbfa3abbc6

fix(FocusZone): fix EventListener leak (v0) (#14044)

view details

Miroslav Stastny

commit sha a837aca7b53dab497f853118c9f04b2b63ca61d8

Merge remote-tracking branch 'upstream/master' into fix/focus-zone-leak

view details

Miroslav Stastny

commit sha 713fb68e8a8cedd8a078aeb944523effa07d8c6b

address PR comments

view details

push time in 21 days

created tagmicrosoft/fluentui

tagfluentuizero_v0.47.7

We've moved! UI Fabric is now Fluent UI - A set of React components for building Microsoft web experiences.

created time in 21 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 4ff7591ea54d733d7199ab2f25beb24615b27f97

fluentuizero_v0.47.7

view details

push time in 21 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha afc8ce702d65032592047cb845bc49ea348aa590

fix(FocusZone): fix EventListener leak (v0) (#14044) (cherry picked from commit 15ee28cda5ee81da62a00bde74ece8bbfa3abbc6)

view details

push time in 21 days

delete branch miroslavstastny/fluentui

delete branch : fix/focus-zone-leak-v0

delete time in 21 days

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 15ee28cda5ee81da62a00bde74ece8bbfa3abbc6

fix(FocusZone): fix EventListener leak (v0) (#14044)

view details

push time in 21 days

PR merged microsoft/fluentui

Reviewers
fix(FocusZone): fix EventListener leak (v0) Fluent UI v0

Pull request checklist

  • [x] Addresses an existing issue: v0 fix for #14025.

Description of changes

Converted key down event handler in FocusZone class from member arrow function to a pure function to make it equal among class instances to avoid the leak. Fixed in react-bindings (v0).

+94 -11

3 comments

3 changed files

miroslavstastny

pr closed time in 21 days

PR opened microsoft/fluentui

Reviewers
fix(FocusZone): fix EventListener leak (v0)

Pull request checklist

  • [x] Addresses an existing issue: v0 fix for #14025.

Description of changes

Converted key down event handler in FocusZone class from member arrow function to a pure function to make it equal among class instances to avoid the leak. Fixed in react-bindings (v0).

+94 -11

0 comment

3 changed files

pr created time in 21 days

create barnchmiroslavstastny/fluentui

branch : fix/focus-zone-leak-v0

created branch time in 21 days

push eventmiroslavstastny/fluentui

Luan Nguyen

commit sha e94ddb76a22232c4f574f32d7f8972cfb48e3808

Allow overriding ContextualMenu's internal List's role (#13908) #### Pull request checklist - [X] Addresses an existing issue: Fixes #13971 - [X] Include a change request file using `$ yarn change` #### Description of changes Currently, the `ContextualMenu` control hard-code the `role` attribute of the internal List as `menu`. In my usage, I want to set a different role, specifically `grid`. There's currently no way to achieve this. In this PR, I'm adding a `role` property to the `IContextualMenuListProps` struct. The idea is that the consumer of `ContextualMenu` would provide a custom implementation of `onRenderMenuList` callback. Inside the callback, it can set the `role` attribute to `grid`, before invoking the default renderer. The default renderer inside `ContextualMenu` is modified to honor the `role` property. If `role` is not set, it falls back to `menu`, hence preserving the existing behavior. #### Focus areas to test Added unit tests.

view details

Elizabeth Craig

commit sha 6ddf7d61096e644b7ee3a63abf02629a786a99ac

ESLint: add faster max-len rule (#13994)

view details

Sarah Higley

commit sha 5d63c38662cc26c0518dbe5b7299b1039e0c02ad

Fix Picker action button screen reader issue by updating activedescendant (#13627) * Point picker activedescendant to suggestions action buttons, update render when leaving action buttons * change file * add test for activedescendant on BasePicker * return undefined activedescendant when loading

view details

tomi-msft

commit sha 41c1643be865c1969acacf4d3d896fd80ca29037

Adding CodeSandbox next/northstar templates (#13893) * Add codesandbox template for react-next package * fix version error in package.json * add react-next template to ci.json * add <ThemeProvider> and <Stack> components to fix template rendering * add theme-samples dependency to package.json * fix lint errors in package.json * Add initializeIcons so <SpinButton> can render correctly * Add codesandbox template for react-northstar package components * Update ci.json file with new package * remove unused package and fix index.tsx * Add oufr to package.json * Fix dependency tree to run codesandbox for react-northstar package * Update some package.json dependencies * Update dependencies in react-next template to fix lint errors * Add oufr package to dependencies in package.json * Add react-bindings package to ci.json * fix package order * update package dependencies to fix lint errors * Add explicit typing to index.tsx and clean up json files in both templates * fix lint error * add prettier dependency to react-northstar template * Update just.config.ts file and tsconfig.json file for both templates * update next and northstar templates to use eslint * update package.json

view details

Rajesh Goriga

commit sha a0b451a274e96ecedfb55c13276ee6e5777f75c2

Legends: Remove tab stop on legends for data viz (#14019) * Legends:Skip all legends in data viz as it is confusing to non sighted users as they have just gone through the data viz. * Change files * Update snapshots Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

push time in 21 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha 7f5adc2d3e19d582e56b913bb9bf4a642ad098fb

address PR comments

view details

push time in 21 days

pull request commentmicrosoft/fluentui

fix(FocusZone): fix EventListener leak

Was a bit unclear why referential equality helped the memory leak.

Please check #14025 for details.

miroslavstastny

comment created time in 22 days

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha fbf0d1792ddcfe85a2ed90ac3158dfe64d69408a

changelog

view details

push time in 22 days

PR opened microsoft/fluentui

Reviewers
fix(FocusZone): fix EventListener leak

Pull request checklist

  • [x] Addresses an existing issue: Fixes #14025
  • [x] Include a change request file using $ yarn change

Description of changes

Converted key down event handler in FocusZone class from member arrow function to a regular member function to make it equal among class instances to avoid the leak. Fixed in both react-bindings (v0) and react-focus (v7, v8).

Focus areas to test

(optional)

+199 -4

0 comment

5 changed files

pr created time in 22 days

create barnchmiroslavstastny/fluentui

branch : fix/focus-zone-leak

created branch time in 22 days

push eventmiroslavstastny/fluentui

Jason Wu

commit sha 3cc14fd0025a40c5ac6845439b0ab4b65b735cba

Adding Headset Icon (#12956) * Add HeadsetIcon * Updateing changelog * fix imports * Change files * fix imports Co-authored-by: Jason Wu <jaswu@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>

view details

Oleksandr Fediashov

commit sha b53685fe5f503626f3be8d0f1b81b476a7cd442e

chore: improve lazy loading in v0 docs (#13777) * chore: improve lazy loading in v0 docs * fix chunk comment * fix merge issues, remove default exports * restore change

view details

Roman Sudarikov

commit sha 15630baeae575e1dce90871da1c880277cb3582e

Chore(Splitbutton): Fix docsite example (#14023) * Fix docsite example * Update Changelog

view details

TanelVari

commit sha 114da0ae0adecff5d084ee139216bf51c51a4d9e

Use Teams logo as TeamsIcon (#13966) * Renamed TeamsIcon to ContactGroupIcon. Brought in coloured Teams logo as TeamsIcon instead * Update to changelog

view details

Trip Master

commit sha f58148f1c36c6801903bd78a31dcd1e05cd103a3

Support for enums in props (#13993) * migrate files between branches * migrate spinner * add spinner * add propsutilities test file * add props tests * fix failing tests * fix commenting * add support for enums in spread attributes * add value-changing * Change files * WIP add maybe to proprename * Add Maybe to props utility * fix undefined and linting errors * linting errors Co-authored-by: Trip Master <t-dama@microsoft.com>

view details

push time in 22 days

push eventmiroslavstastny/fluentui

TanelVari

commit sha cf0060666fb2ec44f7602ee0ccca79a3ed504c18

Adding 4 icons (#13888) * Adding 'AppsIcon', 'GeofenceArrivesIcon', 'GeofenceLeavesIcon', 'GeofenceArrivesOrLeavesIcon' * Changelog update * Adjusting with the changes made in the meantime

view details

Rajesh Goriga

commit sha b6bd4bf7bd32cecad30625e4a95010aea34a20dc

Line chart: Expose chart margins prop for line chart (#13896) * Line chart:Expose chart margins prop for line chart * Change files * Merge branch 'master' of https://github.com/RajeshGoriga/office-ui-fabric-react into user/v-gorraj/Task_4265281 Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

David Zearing

commit sha ffbc577bc04d0118804237c644b65456d3259537

fix jest. (#13940)

view details

Oliver Wheeler

commit sha d737e5aeaba213c57e92dd026de3052466c58290

Add props and state typings type for Sidebar component (#13851) * Add SidebarState type for Sidebar component * Add typings for Sidebar component props

view details

Caleb Zearing

commit sha 1d1f3f05a17a40f1af458c2569bcc0b11fc02823

Removing console.log from MarqueeSelection Example (#13941) * Removing console.log from MarqueeSelection.Basic.Example.tsx * Change files

view details

Miroslav Stastny

commit sha 3687dc5506c001dbc5dbcf657d1d895597fac0f2

fix(build): match only main react-northstar package tag when saving stats (#13930)

view details

Fluent UI Build

commit sha 71d16917c9956ffdd2f6bc5d5741f488661c763d

applying package updates

view details

Oleksandr Fediashov

commit sha 220c08b4b89f06a30d76e487356c446ceeed49e9

chore: remove React from @fluentui/styles dependencies (#13950)

view details

hemantha-ponnuru

commit sha d44b274e00c19a9514579586f37050079762dc2e

Linked folder icon (#13946) * Add special folder icon support for LinkedFolder * Change files Co-authored-by: Hemantha Ponnuru <hemanp@microsoft.com>

view details

Roman Sudarikov

commit sha b4adf81c515bd8fcee8264da0dd93d23f881f3cd

Fix: Normalize date in tests without setting timezone (#13948) * Set timezone for tests via env variable * Change files * Normalize dates in test * Add comments * Fix changes comment

view details

Michael Loughry

commit sha 31047ace0c9dd27fc6f3d3fa4cf2acd4639e0ad9

Calendar: Migrate components to function components (#13904) * Add stub function component * Hoist date state * Hoist default props * Hoist remaining state * Hoist focus logic * Finish migration of Calendar * Add stub functional component, and fix animation * Hoist dayGrid ref * Remove extraneous methods * Finish migration of CalendarDay * Use forwarded ref * Migrate CalendarYearGridCell * Migrate CalendarYearGridCell * Migrate CalendarYearGrid * Migrate CalendarYearNavArrow * Migrate CalendarYearNav * Migrate CalendarYearTitle * Migrate CalendarYearHeader * Add stub function CalendarYearBase * Clean up state * Finish migrating CalendarYearBase * WIP * Fix safe-create to fix test issues * Change files * Fix typing * Reactor forceUpdate hook * Fix OUFR tests that make assumptions about styled components * Change files * Remove redundant code * Minor cleanup of code * Add stub CalendarMonth function component * Hoist default props * Hoist animateBackwards state * Hoist focus logic * Remove all component state * Refactor out year string logic * Refactor isCurrentMonth function * Refactor out onButtonKeyDown * Remove extraneous typing from styled calls * Finish CalendarMonth function component migration * Change files * Change react-next to export Calendar/DatePicker from date-time package * Change files * Fix API * Add dependency * Fix issue with month/year navigation after date is selected * Make inline example a controlled component * Change files

view details

tomi-msft

commit sha 5622cd353f0dc368f8ffe4d59af2ee40c60f5053

Slider: Fix High Contrast bug in Slider #13869 (#13952) * fix slider styles * Change files * Update change/office-ui-fabric-react-2020-07-08-09-49-12-a11y-slider.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>

view details

Charles Assunção

commit sha 4ef919011a2ca6fad974a9796a0728920032744b

fix(components): Fix input and menu styles for IE11 (#13901) * fix(components): set position top for icon in input * fix(components): set position top and bottom for input * fix(components): menu item display flex * fix(components): Menu Item Indicator * fix(components): Menu Examples * fix(components): Menu * fix(components): Menu Compose * fix(components): Menu Compose * fix(components): Menu Overflow * fix(components): Clearable input * Update packages/fluentui/react-northstar/src/themes/teams/components/Input/inputStyles.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * fix(components): fix compose regression * fix(components): fix compose regression * fix(components): revert alert styles * fix(Menu): change menuIndicator height Co-authored-by: Marija Najdova <mnajdova@gmail.com>

view details

Jon Schectman

commit sha 4099ffe49cb131ba7aab65e2a6950b443501c466

Add new codemods package (#13884) * initial codemods * some compats working * final major changes to compat * repath somethings * repath a bunch of test stuff * move test stuff for real this time * remove unneeded export * remove unneeded utilitiy * streamline utilities * add another minor utlity * streamline some other utils * add rest of the compat things * minor move * remove comment * made a bunch of comments, improved readme * minor changes to build steps * update yarn lock * use create-package * add missing files * revert change to toggle * fix linting * fix lint mismatch * Fix all comments * add missing test * Change files * make sure lock file is correct * properly rename file paths because git is bad at cases * fix lint for real * use correct version of fabric * Apply suggestions from code review Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: Xu Gao <xugao0131@hotmail.com> * remove ignore lint * remove ignore lint Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: Xu Gao <xugao0131@hotmail.com>

view details

jameelakowsar

commit sha 1f2048c1503558d5648bd0e72faf3ea62b00d2a0

Vertical stacked bar chart: fit container updated to chart (#13860) * fitcontainer changed done in VS bar chart * Change files * change log Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

jameelakowsar

commit sha 957978aa93b4192805a87c0c81f7f380e4cca6a5

Charting: LineChart - callout not visible when graph more dense issue resovled. (#13933) * linechart-callout not visible in dense graph issue resolved * Change files * change files Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Makoto Morimoto

commit sha 209102879028aa62a445ac6c041b79b9d203c8e1

MenuButton: Creating component using compose (#13812) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This is a first stab at a `MenuButton` component using `compose`. At the moment I'm making using of `ContextualMenu` to build this but only on the opinionated version and we can swap it for whatever once we have a more refined new `Menu` component. ![MenuButton](https://user-images.githubusercontent.com/7798177/85902478-f9bd0000-b7b8-11ea-9a77-b086fc4bb05b.gif) #### Focus areas to test (optional)

view details

Philip Kuo

commit sha 0bae11fc8b91cdbf1cf9d0d78dfe5c0e77766367

Theming: new semantic card slots (#13906) * new slots * fix * Change files * fix

view details

hemantha-ponnuru

commit sha e89e47f56fe69600efd52e0f9398a8e2679e7a19

Linked folder tile (#13960) * Update the base url for new assets * Introduce FolderCover for linked folders Fixed the example to render the folder covers example * Change files Co-authored-by: Hemantha Ponnuru <hemanp@microsoft.com>

view details

Roman Sudarikov

commit sha 65e1f3d9412b481b26a28887a14405129e750cea

fix: Respect hidden HTML attribute on components (#13964) * Respect hidden attrinbute on Button * Update Changelog

view details

push time in 22 days

issue commentmicrosoft/fluentui

Resource leak in FocusZone

@dzearing There is the same problem in @fluentui/react-focus@7.12.19 -> Fabric is also affected.

miroslavstastny

comment created time in 22 days

issue commentmicrosoft/fluentui

Resource leak in FocusZone

FocusZone uses ref counting for the keydown event listener to be added only once in componentDidMount: https://github.com/microsoft/fluentui/blob/ac395c5e30b21081b49166ccfc02177f777df7c6/packages/fluentui/react-bindings/src/FocusZone/FocusZone.tsx#L165-L167

And the same logic for removing the event listener in componentWillUnmount: https://github.com/microsoft/fluentui/blob/ac395c5e30b21081b49166ccfc02177f777df7c6/packages/fluentui/react-bindings/src/FocusZone/FocusZone.tsx#L218-L220

If you have two siblings in a React tree, they are unmounted in the same order they were added (not in a reverse order): image

That means that in the FocusZone case, having two sibling FocusZones, the componentWillUnmount of a different class instance tries to remove the event listener.

As the _onKeyDownCapture is an arrow function, it is not referentially equal across the class instances, the function passed in removeEventListener does not equal the one passed in addEventListener and removeEventListener does not remove anything: image

miroslavstastny

comment created time in 22 days

issue openedmicrosoft/fluentui

Resource leak in FocusZone

<!-- Thanks for contacting us! We're here to help.

Before you report an issue, check if it's been reported before:

  • Search: https://github.com/microsoft/fluentui/search?type=Issues
  • Search by area or component: https://github.com/microsoft/fluentui/issues/labels

Note that if you do not provide enough information to reproduce the issue, we may not be able to take action on your report. -->

Environment Information

  • Package version(s): @fluentui/react-northstar@0.50.0

Please provide a reproduction of the bug in a codepen:

https://codesandbox.io/s/v050-focus-zone-resource-leak-31gpt

Repro steps

  1. Have a component with two sibling FocusZone components:
<FocusZone>first</FocusZone>
<FocusZone>second</FocusZone>
  1. Mount and unmount the component 5 times.
  2. Check keydown event listeners on html node.

Actual behavior:

After the last unmount, there are 5 keydown event listeners in FocusZone: image

Expected behavior:

After the last unmount, there should be NO event listeners in FocusZone.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low) High

Products/sites affected: (if applicable)

created time in 22 days

delete branch miroslavstastny/fluentui

delete branch : fix/stats-tag

delete time in a month

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha 3687dc5506c001dbc5dbcf657d1d895597fac0f2

fix(build): match only main react-northstar package tag when saving stats (#13930)

view details

push time in a month

PR merged microsoft/fluentui

fix(build): match only main react-northstar package tag when saving stats Fluent UI v0

Description of changes

When v0 perf stats are saved for a git commit which contains tag for the v0 main package (@fluentui/react-northstar), a version from the tag should be saved to the stats db.

This fix saves the version only for the main package and ignores tag for other packages (like @fluentui/react-icons-northstar_v0.50.0).

+1 -1

2 comments

1 changed file

miroslavstastny

pr closed time in a month

PullRequestEvent

PR closed microsoft/fluentui

fix(build): match only main react-northstar package tag when saving stats Fluent UI v0

Description of changes

When v0 perf stats are saved for a git commit which contains tag for the v0 main package (@fluentui/react-northstar), a version from the tag should be saved to the stats db.

This fix saves the version only for the main package and ignores tag for other packages (like @fluentui/react-icons-northstar_v0.50.0).

+1 -1

1 comment

1 changed file

miroslavstastny

pr closed time in a month

push eventmiroslavstastny/fluentui

Fluent UI Build

commit sha f2315bf2695d36e40eaf49e0d7fdf1274b4ba7af

applying package updates

view details

Oleksandr Fediashov

commit sha 9cf1be406abd6b5160a3a4169ede9e6d491e64eb

chore: remove default exports [P4] (#13917) * chore: remove default exports [P4] * Update itemLayoutStyles.ts

view details

push time in a month

push eventmiroslavstastny/fluentui

Oliver Wheeler

commit sha 2ae92b52ef4c8d53dcb1d2193bbe3b9c58510c25

Update react-router-dom in @fluentui/docs and @fluentui/e2e packages (#13857) * Update react-router-dom in @fluentui/docs * Bump react-router dom in @fluentui/e2e

view details

Charles Assunção

commit sha 70fde20da35fdb66574ec0f9f981737f113df7e3

fix(FormPrototype): fix IE11 (#13880)

view details

Connor Smith

commit sha 6a33fd5c4919b378ce306c1877aa52d384a91019

Resolve side effects in keyboard-key/codes.ts (#13729) * Resolve side effects in keyboard-key/codes.ts * Change files

view details

Oleksandr Fediashov

commit sha d8115b1bcee06dc0db694be124154b8d421bae84

chore: remove withSafeTypeForAs (#13845) * chore: remove withSafeTypeAs * Update packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx Co-authored-by: Miroslav Stastny <mistastn@microsoft.com> Co-authored-by: Miroslav Stastny <mistastn@microsoft.com>

view details

Fluent UI Build

commit sha 40bd7178700b73bf22ca41beea77fbf5d76bf8f8

applying package updates

view details

Charles Assunção

commit sha 061498cbd3f31d83afa7ff6c3515a59ba1071113

fix(components): small fix for ie11 (#13898) * fix(FormPrototype): fix IE11 * fix(Prototypes): IE11 * fix(Prototypes): fix toolbar overflow * fix(Prototypes): fix actions menu positioning * Update packages/fluentui/docs/src/prototypes/customToolbar/index.tsx * Update packages/fluentui/docs/src/prototypes/customToolbar/index.tsx * Update packages/fluentui/docs/src/prototypes/customToolbar/index.tsx * Update packages/fluentui/docs/src/prototypes/customToolbar/index.tsx * Update packages/fluentui/docs/src/prototypes/customToolbar/index.tsx * fix(Prototypes): revert deleted lines * fix(Prototypes): revert deleted lines * fix(Prototypes): alternative for chat * fix(Prototypes): alternative for chat

view details

Milan Turon

commit sha 872a717898af5c2e16833d429bdfc3a285b8f124

fix(Toolbar,Popup) accessibility fixed based on user feedback (#13859) * fixing navigation into cell which has multiple focusable elements * updating changelog * adding table keyboard navigation tests * deleting from master * adding table keyboard navigation tests * deleting files from master, pushed by mistaked * first patch of fixes based on user feedback after testing * changing as well menuButtonBehavior * returning change in menuButtonBehavior Co-authored-by: Milan Turon <mituron@microsoft.com>

view details

Michael Loughry

commit sha 017dc3372393a5e4b327e1c90134c1858ed9abfd

Migrate styled utility function to use functional component (#13891) * WIP * Fix safe-create to fix test issues * Change files * Fix typing * Reactor forceUpdate hook * Fix OUFR tests that make assumptions about styled components * Change files * Remove redundant code * Minor cleanup of code

view details

Oleksandr Fediashov

commit sha 60f2ac912bb9ff12eb507b222e90e4743365fb77

chore: remove outdated packages (#13902) * chore: remove outdated packages * clean up yarn.lock

view details

Rajesh Goriga

commit sha d55eecf434dfe269ecbf6f412dcde73a13dace3e

Line chart: Remove Duplicate ID's for lines and circles (#13897) * Line chart: Remove Duplicate ID's for lines and circles * Change files Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

TanelVari

commit sha 49e799793f7ce1c4d8b1edc5ffc51b88f9000e58

SplitButton - Padding 12px on the sides. Added a variable for minWidth. (#13874)

view details

Oleksandr Fediashov

commit sha 523f1ed72368da18cb33a6d620a730bd271e8905

chore: remove default exports [P1] (#13903) * chore: remove default exports * fix import, restore FZ * restore ref components * remove export defaults

view details

Fluent UI Build

commit sha 8117a775d5095759a2b0ac10b244b3c6d4792228

applying package updates

view details

Oleksandr Fediashov

commit sha 472f361b5533b4eb723e78dfb1ed0b24721a64e5

chore: remove default exports [P3] (#13916)

view details

Oleksandr Fediashov

commit sha a4898636dfef66f59f63740ab2646c7497410137

chore: remove default exports [P2] (#13915) * chore: remove default exports [P2] * fix build issues

view details

jameelakowsar

commit sha 953592c7bdc750c2f1dbd9e2ca3863774a82c516

Line chart - callout and circle ID's updated. (#13920) * Line Chart-callout and circle Id's udpated * Change files * change log file updated Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Fluent UI Build

commit sha ecd63a32282ff1b1215690510d3a7d605a76d6c8

applying package updates

view details

Trip Master

commit sha 0154774e650c0a53b1a7e9fe056b6473bfc64948

Toggle: remove double label for (#13886) * Combine labelId and StateTextId in labelledById and update tests * Combine labelId and StateTextId in labelledById and update tests * Change files * minor style fix in toggle base * Update packages/office-ui-fabric-react/src/components/Toggle/Toggle.base.tsx Co-authored-by: Xu Gao <xugao0131@hotmail.com> * repeat fix in useToggle.ts * Change files * fix tests Co-authored-by: Trip Master <t-dama@microsoft.com> Co-authored-by: Xu Gao <xugao0131@hotmail.com>

view details

push time in a month

PR opened microsoft/fluentui

Reviewers
fix(build): match only main react-northstar package tag when saving stats Fluent UI v0

Description of changes

When v0 perf stats are saved for a git commit which contains tag for the v0 main package (@fluentui/react-northstar), a version from the tag should be saved to the stats db.

This fix saves the version only for the main package and ignores tag for other packages (like @fluentui/react-icons-northstar_v0.50.0).

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchmiroslavstastny/fluentui

branch : fix/stats-tag

created branch time in a month

Pull request review commentmicrosoft/fluentui

chore: remove default exports [P1]

-export { default as Unstable_NestingAuto } from './NestingAuto';

default exports in react-component-nesting-registry: image

layershifter

comment created time in a month

Pull request review commentmicrosoft/fluentui

chore: remove default exports [P1]

 export { default as FocusZone } from './FocusZone/FocusZone'; export * from './FocusZone/FocusZone.types';

There are still default exports in react-bindings: image

layershifter

comment created time in a month

push eventmiroslavstastny/fluentui

Fluent UI Build

commit sha 4252ec8288267f4330a6344eadbf9093fd423704

applying package updates

view details

Esteban Munoz

commit sha 29ea83a5b421019b4c6c71301bfcbda849a650ad

React conformance - Adding as prop tests and adding isConformant to MenuItem (#13770) * adding as prop tests * Change files * fixing lint error * Update change/office-ui-fabric-react-2020-06-23-18-39-23-react-conformance.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * fixing lint error * replacing repeated test and adding requested changes * Update packages/react-conformance/src/isConformant.ts Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * fixing paths * Adding requested changes * removing react-component-ref dependency * adding requested changes and fixing bugs * Change files * Updating dependencies * updating dependencies * changing dep to devdep * Adding environment settings for jest * disabling as test for react-button * Change files Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>

view details

Xu Gao

commit sha 385fd7ef91de3a7dde19520cb8a52ac9880f5993

Fix build: yarn.lock is out of sync (#13885) * fix yarn.lock * add caret

view details

Xu Gao

commit sha 70ddd498cbc27f269cef66a5688c2ffc52c32b93

Revert "resolveSlotProps: when slot/shorthand prop has JSX element as children, slot should be completely replaced by it" (#13882) * Revert "resolveSlotProps: when slot/shorthand prop has JSX element as children, slot should be completely replaced by it (#13827)" This reverts commit c04c43b2107ef83473ab505bde653bc6bd3b6cb2. * Change files

view details

Makoto Morimoto

commit sha faf194d9af24a2f08010ba022913816bc43b1b88

Button: Adding story of Button using styled icon from react-icons via tokens. (#13890)

view details

Saad Najmi

commit sha 206da19b0bb45a8edca305b4d40aac8c1c4d9f38

New macos link control (#13892) * Initial Link Documentation without images * Change section title * Add links to images for link control * Rewrote sentence * Change files

view details

Makoto Morimoto

commit sha 4d02c9112111b40532411757c37878124c581b38

PR deployed sites: Adding react-button and react-next to list of deployed sites (#13873) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes This PR adds the `react-button` and `react-next` packages to the list of deployed sites that appears in the PR checks for other people to be able to test the changes that have been done. #### Focus areas to test (optional)

view details

shivasai09

commit sha ec20514fdd2721e62194c6f1d4c3878fa9df2e39

remove bench mark and target (#13816) * resolving pr comments * changing type Co-authored-by: v-sivsar <v-sivsar@microsoft.com>

view details

Charles Assunção

commit sha 7927b7c04a8e30c41d1de6c9edc52f4bc0bb8eb0

feat(Schema): Add validation for forms and form components (#13861) * feat(Schema): Add validation for forms and form components * feat(Schema): Radiogroup message * feat(Schema): error message * Update packages/fluentui/ability-attributes/schema.json

view details

push time in a month

Pull request review commentmicrosoft/fluentui

chore: remove withSafeTypeForAs

 class Dropdown extends AutoControlledComponent<WithAsProp<DropdownProps>, Dropdo  * @accessibilityIssues  * [Issue 991203: VoiceOver doesn't narrate properly elements in the input/combobox](https://bugs.chromium.org/p/chromium/issues/detail?id=991203)  */-export default withSafeTypeForAs<typeof Dropdown, DropdownProps>(Dropdown);+export default (Dropdown as unknown) as ComponentWithAs<'div', DropdownProps> & {+  Item: typeof DropdownItem;+  SelectedItem: typeof DropdownSelectedItem;++  a11yStatusCleanupTime: number;+  charKeyPressedCleanupTime: number;+};+/* ^ A temporary typing until Dropdown will not be converted to functional component. */
/* ^ A temporary typing until Dropdown is converted to functional component. */
layershifter

comment created time in a month

Pull request review commentmicrosoft/fluentui

chore: remove withSafeTypeForAs

 const iterateItems = (items: TreeProps['items'] | TreeItemProps['items'], acc =     acc,   ); -const Tree: React.FC<WithAsProp<TreeProps>> &+/**+ * A Tree displays data organised in tree hierarchy.+ *+ * @accessibility+ * Implements [ARIA TreeView](https://www.w3.org/TR/wai-aria-practices-1.1/#TreeView) design pattern.+ * @accessibilityIssues+ * [Treeview - JAWS doesn't narrate position for each tree item](https://github.com/FreedomScientific/VFO-standards-support/issues/338)+ * [Aria compliant trees are read as empty tables](https://bugs.chromium.org/p/chromium/issues/detail?id=1048770)+ */+const Tree: ComponentWithAs<'div', TreeProps> &

The change from ul to div is intentional bugfix, correct?

layershifter

comment created time in a month

push eventmiroslavstastny/fluentui

Charles Assunção

commit sha 4acd7f720a50247230c2a46200911fe642ab973c

feat(FormPrototype): add form validation prototype (#13615) * feat(FormField): Add error message, error indicator and satisfactory indicator * feat(FormField): Add satisfactoryIndicator to proptypes * feat(FormField): contidion to satisfactory Indicator * feat(FormField): add desc to prop * feat(FormField):fix proptype * feat(FormField): fix message ID * feat(FormField): add aria required * feat(FormField): add error examples * feat(FormField): add tests * feat(FormField): add children api * feat(FormField): add children api * feat(FormField): reduce example * feat(FormField): remove comment * feat(FormField): rename satisfactoryIndicator * feat(FormField): update ids * feat(FormField): replace labelledby * feat(FormField): use controlId * feat(FormField): use id for label * feat(FormField): add best practice * feat(FormField): aria-labelledby in the input * feat(FormField):error to hasIcon * feat(FormField): simplify * feat(FormField): Fix text * feat(FormComponents): add components * feat(FormField): rename * feat(FormField): rename * feat(FormField): rename * feat(FormComponents): add components * feat(FormComponents): add button * feat(FormComponents): remove coments * feat(FormComponents): slot props * feat(FormComponents): fix label * feat(FormComponents): Fix tests * feat(FormComponents): Fix tests * feat(FormComponents): Fix checkbox Label * feat(FormComponents): Fix import * feat(FormComponents): Add FormFieldCustom * feat(FormComponents): remove unused prop from checkbox form * feat(FormComponents): add form slider and form radio group * feat(FormComponents): form slider class * feat(FormComponents): fix handled props * feat(FormComponents): remove checkboxLabel * feat(FormPrototype): add form prototype validation * feat(FormPrototype): remove mode * feat(FormPrototype): inputRef type * feat(FormPrototype): inputRer type * feat(FormPrototype): small fixes * feat(FormComponents): remove control * feat(FormComponents): review * feat(FormComponents): Update example * feat(FormComponents): revert formFieldStyles * feat(FormComponents): fix props input * feat(FormComponents): remove type from styles * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * feat(FormComponents): update class name * feat(FormComponents): revert formfield test * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * feat(FormComponents): Variants Section * feat(FormComponents): revert removing control * feat(FormComponents): remove default prop * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Form/FormCheckbox.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(FormComponents): review * feat(FormPrototype): handle dropdown onBlur * feat(FormPrototype): Validation on blur dropdown * feat(FormPrototype): Refact FormFieldBase * feat(FormPrototype): add FormFieldCustom * feat(FormPrototype): change file name * feat(FormPrototype): remove children * feat(FormComponents): review * feat(FormComponents): review * feat(FormComponents): review * feat(FormPrototype): required * feat(FormPrototype): error to message in dropdown * feat(FormPrototype): Fix formik * feat(FormPrototype): Fix onBlur * feat(FormPrototype): Fix onBlur * feat(FormPrototype): Fix lock * feat(FormPrototype): Fix validation * feat(FormPrototype): hotfix * feat(FormPrototype): remove import * feat(FormPrototype): remove flat from packagejson * feat(FormPrototype): remove condition using watch * feat(FormPrototype): update * feat(FormPrototype): change ref Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Fluent UI Build

commit sha 17a103f2d7fce4edc885ab87a0086c52e0d91f1c

applying package updates

view details

Charles Assunção

commit sha 30ab262bd881de335a24538bd332aed0361ba0f4

fix(FormPrototype): remove required (#13840)

view details

Charles Assunção

commit sha 038a8f24ee86010c9665f5a7875f72a4a0e7b181

fix(FormInput): Forwards ref properly (#13839) * feat(FormField): Add error message, error indicator and satisfactory indicator * feat(FormField): Add satisfactoryIndicator to proptypes * feat(FormField): contidion to satisfactory Indicator * feat(FormField): add desc to prop * feat(FormField):fix proptype * feat(FormField): fix message ID * feat(FormField): add aria required * feat(FormField): add error examples * feat(FormField): add tests * feat(FormField): add children api * feat(FormField): add children api * feat(FormField): reduce example * feat(FormField): remove comment * feat(FormField): rename satisfactoryIndicator * feat(FormField): update ids * feat(FormField): replace labelledby * feat(FormField): use controlId * feat(FormField): use id for label * feat(FormField): add best practice * feat(FormField): aria-labelledby in the input * feat(FormField):error to hasIcon * feat(FormField): simplify * feat(FormField): Fix text * feat(FormComponents): add components * feat(FormField): rename * feat(FormField): rename * feat(FormField): rename * feat(FormComponents): add components * feat(FormComponents): add button * feat(FormComponents): remove coments * feat(FormComponents): slot props * feat(FormComponents): fix label * feat(FormComponents): Fix tests * feat(FormComponents): Fix tests * feat(FormComponents): Fix checkbox Label * feat(FormComponents): Fix import * feat(FormComponents): Add FormFieldCustom * feat(FormComponents): remove unused prop from checkbox form * feat(FormComponents): add form slider and form radio group * feat(FormComponents): form slider class * feat(FormComponents): fix handled props * feat(FormComponents): remove checkboxLabel * feat(FormPrototype): add form prototype validation * feat(FormPrototype): remove mode * feat(FormPrototype): inputRef type * feat(FormPrototype): inputRer type * feat(FormPrototype): small fixes * feat(FormComponents): remove control * feat(FormComponents): review * feat(FormComponents): Update example * feat(FormComponents): revert formFieldStyles * feat(FormComponents): fix props input * feat(FormComponents): remove type from styles * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * feat(FormComponents): update class name * feat(FormComponents): revert formfield test * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * feat(FormComponents): Variants Section * feat(FormComponents): revert removing control * feat(FormComponents): remove default prop * Update packages/fluentui/react-northstar/src/components/Form/FormFieldCustom.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Form/FormCheckbox.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(FormComponents): review * feat(FormPrototype): handle dropdown onBlur * feat(FormPrototype): Validation on blur dropdown * feat(FormPrototype): Refact FormFieldBase * feat(FormPrototype): add FormFieldCustom * feat(FormPrototype): change file name * feat(FormPrototype): remove children * feat(FormComponents): review * feat(FormComponents): review * feat(FormComponents): review * feat(FormPrototype): required * feat(FormPrototype): error to message in dropdown * feat(FormPrototype): Fix formik * feat(FormPrototype): Fix onBlur * feat(FormPrototype): Fix onBlur * feat(FormPrototype): Fix lock * feat(FormPrototype): Fix validation * feat(FormPrototype): hotfix * feat(FormPrototype): remove import * feat(FormPrototype): remove flat from packagejson * feat(FormPrototype): remove condition using watch * feat(FormPrototype): update * feat(FormPrototype): change ref * fix(FormInput): foward ref properly * Update packages/fluentui/react-northstar/src/components/Input/Input.tsx * fix(FormPrototype): fix tests * fix(FormPrototype): fix tests Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Rajesh Goriga

commit sha 50a3aaef8b7b967078b850656354594fee30bbbd

Legends: Fix Incorrect role is defined for lagend overflow items (#13837) * FIx Incorrect role is defined for lagend overflow items * Change files Co-authored-by: Rajesh Goriga <v-gorraj@microsoft.com>

view details

Oleksandr Fediashov

commit sha 97c2a145ae6c5478d17f1577bd2a21a31de860f0

fix(compose): update types to provide better infers (#13841) * fix(compose): update types to provide better infers * Change files * update prop name * use update API * fix types * fix lint

view details

David Zearing

commit sha 7932ae5eef247af9b914e8f05efdaac0b64914f8

getNativeProps perf: adjusting indexOf lookup to object lookups. (#13842) * Update native props. * Change files * fix * Change files

view details

Makoto Morimoto

commit sha a41ab1f5338190531ba50b0e87193a54f7e3b6c7

Button: Adding visual regression tests for focused scenarios (#13832) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR adds visual regression tests for scenarios where the `Button` has been focused. #### Focus areas to test (optional)

view details

David Zearing

commit sha 0992ce1a42dcd1105ec055d655111288b54d3bcd

mergestyles: IStyle: loosening typings for objects embedded within the style. (#13847) * Loosening typings in IStyle. * Change files * api. * :(

view details

David Zearing

commit sha 4746eb1c2dd4846510353f839bc4079511a75e22

Button: Adding various tests and updating component to include componentRef (#13718) * Updates. * useMergedRefs update to be immutable. * adding comment. * Change files * more updates. * updates * better. * Fixing unneeded style prop in button. * undo * Change files * update. * cleanup. * Removing oufr dependency from button, updating api * Update change/@fluentui-react-button-2020-06-19-15-32-16-fix-button-fixes.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/react-button/src/components/Button/Button.types.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * updates. * This is wrong - styles should not be injected without being necessary. * undo! * no message Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>

view details

Miroslav Stastny

commit sha f4abe1f5efe35acf7743275a44e59a099c46f39b

doc: Document Debug Panel and Telemetry Popover (#13818) * doc: Document Debug Panel and Telemetry Popover * remove cruft * update doc * changelog * Apply suggestions from code review Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>

view details

Oleksandr Fediashov

commit sha 6525619bf5e6c844406ed3cb9ad3103237eff89f

chore: move shorthandConfig to compose() (#13856) * chore: move shorthandConfig to compose() * remove duplicate import * remove unused import

view details

Fluent UI Build

commit sha 9703000e9e94fdbb82d11200a715108fcb480a00

applying package updates

view details

Oleksandr Fediashov

commit sha 992853c1a9c37e4ab9ba390b5a1760173bdfd702

chore: update Webpack config for bundle size task in v0 (#13862)

view details

Oleksandr Fediashov

commit sha 7720f47bdff20903044a47c9073ea170b4c83515

chore(Grid): convert to be function component (#13863) * chore(Grid): convert to be function component * add changelog entry * fix types in Teams theme * use FZ * fix UT

view details

Thomas Michon

commit sha 6870e7068a2cb7fbd36828c5c0e7bab198fa3efa

Use correct target window for ResizeGroup animation frame callback (#13864) * Ensure ResizeGroup uses correct window for animation frame * Change files

view details

jameelakowsar

commit sha ea1cb2f66589e09d46ad49843114fec282c1ed6c

Grouped vertical bar chart: Prop check added to update chart when props changed (#13853) * prop check added * Change files * change lig * on legend click code updated Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

tomi-msft

commit sha acc9cc976871838be5967d6d303ebee44f557f24

Adding a template in the repo for codesandbox examples (#13745) * Create codesandbox template for react package * Move files up to maintain file structure * Fix variable declaration so options for ChoiceGroup and DropDown can render * Change package dependency to @fluentui/react * Update apps/codesandbox-react-template/package.json Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * Update ci.json * Update ci.json * Update require.context() function to the right file * Fix file path to index.tsx in storybook * remove unneccesary files * Update ci.json * update ci.json * Add missing infor to package.json and tsconfig.json files * Fix dependency issue in package.json * update yarn.lock Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: David Zearing <dzearing@microsoft.com>

view details

Xu Gao

commit sha 967a2d4d1879c1683f3c8bd9ea9cd4884944d396

High Contrast in Edge Chromium: Fix Label and TextField (#13844) * update high contrast selector * fix label * fix textfiled * update snapshots * Change files * update api * update snapshots * update snapshots in date-time * Change files * update snaps for exp package * Change files * update snaps for react-next * update label styles * update snapshots

view details

Xu Gao

commit sha 1606d80c8d9964ca6f1cac4219ab9249b93b4428

High Contrast in Edge Chromium: fix Nav (#13850) * fix nav in high contrast * Change files * update snapshots * fixes

view details

push time in a month

PR opened microsoft/fluentui

Reviewers
chore(design): design prop using caching by hash from emotion [47.x] Fluent UI v0 Status: Do Not Merge 🚫

Backport of #13641 to @fluentui/react-northstar@0.47.x

+80 -63

0 comment

6 changed files

pr created time in a month

create barnchmiroslavstastny/fluentui

branch : feat/design-prop-revisit-hash-47

created branch time in a month

push eventmicrosoft/fluentui

Miroslav Stastny

commit sha f4abe1f5efe35acf7743275a44e59a099c46f39b

doc: Document Debug Panel and Telemetry Popover (#13818) * doc: Document Debug Panel and Telemetry Popover * remove cruft * update doc * changelog * Apply suggestions from code review Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>

view details

push time in a month

PR merged microsoft/fluentui

Reviewers
doc: Document Debug Panel and Telemetry Popover Fluent UI v0

Description of changes

Add documentation for debug tools in v0.

+138 -1

3 comments

9 changed files

miroslavstastny

pr closed time in a month

push eventmiroslavstastny/fluentui

Miroslav Stastny

commit sha d7e85a9514cfd8ae65f2bb2180950fc9c057387c

Apply suggestions from code review Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>

view details

push time in a month

more