profile
viewpoint
Levi Thomason levithomason Microsoft Post Falls, Idaho http://levithomason.com I love life, learning, and the web.

asafdav/ng-clip 268

Copy to clipboard using AngularJS

ckcollab/chin-up 87

Track your metrics (motivation, happiness, relationships) and find correlations in your behaviors

levithomason/cmatrix 47

The original Matrix effect for your Mac terminal

layershifter/babel-plugin-transform-react-handled-props 17

Generates handledProps from defaultProps and propTypes during the build :sparkles:

levithomason/angular-annyang 15

Annyang speech recognition in AngularJS

levithomason/anny 14

Anny is an artificial neural network, yo!

layershifter/event-stack 5

[DEPRECATED] A React component for binding events on the global scope

levithomason/canibrowse 2

Browser detection and check API

dzearing/office-ui-fabric-react 1

React components for building experiences for Office and Office 365.

levithomason/CI-BuildStats 1

Little SVG widget to display AppVeyor, TravisCI or CircleCI build history charts and other SVG badges.

pull request commentmicrosoft/fluentui

chore: add typescript as explicit dev dependency to react-northstar

This looks good by me. @layershifter ?

chrisdholt

comment created time in 4 hours

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 01c7e00d46e7e7aa358fe1184e0f31666a4e7f10

deploy docs [ci skip]

view details

push time in 2 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 9115a935bf83f6dd539e54b8dcb76baa19a829c2

1.1.1

view details

push time in 2 days

created tagSemantic-Org/Semantic-UI-React

tagv1.1.1

The official Semantic-UI-React integration

created time in 2 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 1c464a9d0cd967d89dbd32ca9029ee0e04ca5b1b

deploy docs [ci skip]

view details

push time in 6 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 63c7edec66b1b4e944ad2477e3cdec28dcf75ecf

1.1.0

view details

push time in 6 days

created tagSemantic-Org/Semantic-UI-React

tagv1.1.0

The official Semantic-UI-React integration

created time in 6 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 2700521b250e2cee49d54b84b18a4c7c6f4fd5c5

fix: remove missing tsd:lint from prerelease [ci skip]

view details

push time in 6 days

issue commentSemantic-Org/Semantic-UI-React

Add sponsor button

GitHub's new sponsor features look pretty interesting. I joined the waitlist and was accepted immediately. It looks like we'll need to do some thinking and planning on setting up tiers and writing descriptions and what not. I'll talk to @layershifter and @jlukic about this as well and see what they think as well.

While this is really great and I expect it to transform the open source community over time, I still think it will need to enable open source developers to nearly full time on projects in order to make them successful. One half of this equation is funding but the other half is time. Currently, day jobs consume nearly all the available time open source developers have to work on their projects.

In either case, thanks much for this post and looking forward to seeing what we can do with these new tools.

sholladay

comment created time in 6 days

issue commentSemantic-Org/Semantic-UI-React

Add sponsor button

This is something I've considered for a while. I've talked to Jack about it extensively as well, sustainable open source development.

In terms of my continued contributions and maintenance, sponsorship would certainly help. I think in an ideal utopia, open source developers could just develop all day every day for the benefit of the world wide community and not be bound by the interests of a specific entity (like a day job 😅).

In the absence of 100% full time open source focus powered by full-time salaries for those devs, I think a good compromise is part-time focus with part-time funding.

I'll take a look at the sponsors and see what it entails.

sholladay

comment created time in 6 days

push eventlevithomason/fluentui

Levi Thomason

commit sha 34a5120a8605d5b064b1e892e618629c3c95117b

BROKEN useDesign cache tests

view details

push time in 6 days

push eventlevithomason/fluentui

Levi Thomason

commit sha 28613d1e27048af79651065e225cf49bde3eba8e

stub use design function and tests

view details

push time in 12 days

push eventlevithomason/fluentui

John Lorenz

commit sha 385517ff6b14786e1ea744f3de61d06a34be7822

[Date-Time] refactor date time examples (#13956) * refactoring the date time examples into separate files to fix storybook. Also fixing bug in Calendar where externally controlled date does not navigate the calendar when the date changes * Change files * fixing auto-import of DateRangeType that broke linter * undoing accidental typo change in the OUFR file

view details

Micah Godbolt

commit sha 559e91a35ec2bde8ae3a7431a8679b5637192ecb

Website icon fix - give icons unique IDs (#13967) SVG icons had hard coded ids. made them unique.

view details

Saad Najmi

commit sha 20be95a095c9296db1fa735b76ae58191f015171

New macos button and separator (#13910) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes We have 2 more new controls coming in for macOS. Let's update the documentation.

view details

Oleksandr Fediashov

commit sha 7fc0a7d046869c5f245661bd606831d9e390a32a

chore(Dropdown): convert to be functional component (#13962) * wip * remove cruft * fix const usage * fix regressions * fix visual regressions * fix lint errors * fix visual regressions * add changelog entries

view details

Oleksandr Fediashov

commit sha f62f03845b9ad5dbfacc094676f0819181c53c13

fix: make getShorthandInfo compatible with `compose()` (#13961)

view details

Fluent UI Build

commit sha 77a67dc27a4a3f546fcfc88732e42da0fa1c9d9e

applying package updates

view details

Oleksandr Fediashov

commit sha 90ac82119ec951273a8bac7b6d3e75cabd3b49a6

chore: use minification for stats task and proper env (#13986)

view details

Charles Assunção

commit sha d43db14983c012854c144263821109e09ed15310

fix(ChatMessage): remove auto (#13988)

view details

Jacqueline Gaherity

commit sha 8df4df38a9af3fe5dccf54c5db844af4805cfc83

Fix bug: azure-theme CommandBar styles (#13959) * Azure-theme command bar and command bar button style updates * Change files Co-authored-by: Jackie <jagaheri@microsoft.com>

view details

Xu Gao

commit sha d07846f717c51a003c496c9fcac49e52fc55c8f1

Remove KeytipData usage from Link, Checkbox, Toggle (react-next) (#13742) * export useKeytipData * remove KeytipData usage from Checkbox, add withKeytipData HOC * remove KeytipData for toggle * Remove keytipData for link * update example * cleanups * Change files * resolve comments * avoid adding keytipData prop * fixes * fix keytip set to invisible if addKeytipQueue is called multiple time * resolve comment

view details

shrallap

commit sha ec36a5c214cfc9a9262f8100013734f61952e95a

DatePicker: showDatePickerPopup should be public (#13981) * showDatePickerPopup as public api * Change files * make method public * api file update * add showdatepicker to interface * build fix

view details

Justin Slone

commit sha 47f3eafa6b60d3e12ea5f87c839c4e332364d38a

Update CODEOWNERS for packages/foundation (#13990)

view details

Oleksandr Fediashov

commit sha b369d4a7a47b622366771c39a1520f635d41adf2

chore: bump Babel to latest (#13985) * chore: bump Babel to latest * fix deps * fix UTs * Revert "fix UTs" This reverts commit 2e52b747 * fix yarn.lock

view details

c0r32

commit sha 7370c100a267785a14c69ee18d8f1e128eaa64b6

Add multi select delimiter to combobox (#13979) * Add multiSelectDelimiter property to ComboBox * Add test for ComboBox.mutliSelectDelimiter property * Change files Co-authored-by: Corey Cahill <cocahill@microsoft.com>

view details

erichdev

commit sha be5ada5f95814f7daa5485024050bc674865fcab

ContextualMenu accessibility: Fix high contrast style for submenu icon (#13843) * Fix high contrast color for submenu icon * Change files * Add comma * Revert "Add comma" This reverts commit e73d7955f5e5c0e0d20b5563e202a4f81be619a7. * Revert "Fix high contrast color for submenu icon" This reverts commit 36f286f324208742ef2975e38fa6958f8eed146f. * Fix high contrast color for submenu icon * Update snapshot Co-authored-by: Erich Abellera <erabelle@microsoft.com>

view details

Micah Godbolt

commit sha c7b7480e6c59f4ccff7033364e0138bf5e8418de

Website hook fix (#13989) * revert to getId as svg is not a react component * Change files * remove unnecessary color styling on b/w icons and fixed homepage icons

view details

Caleb Zearing

commit sha e105904735ba78f93b9a99862ff3e833248228a8

Adding useSetInterval and useSetTimeout within react-hooks package (#13973)

view details

Elizabeth Craig

commit sha e7b119a05ef8a4aa254df00320f3672298617ade

Use ESLint everywhere (#13944) * Delete tslint.json * Remove tslint-rules dep, add eslint-rules dep * Update config files * Delete tslint-rules package * Add no-tslint-comments * Go back to naming convention helper function since override wasn't working * fix lint-staged eslint * Ignore unused disables in lint-staged * All the fixes and renames * Scripts to prevent tslint reintroduction Co-authored-by: KHMakoto <humbertomakotomorimoto@gmail.com>

view details

Oleksandr Fediashov

commit sha ae46225e1b94e6b348daa23fe90d983a285ce4ad

chore: remove default exports [P5] (#13934) * chore: remove default exports * wip * Change files * Update index.ts * fix merge * fix import * fix UTs * fix eslint setting * Update packages/fluentui/react-northstar/src/index.ts Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>

view details

Charles Assunção

commit sha ed882164f5adc2fc3577cfc959517ae1d8c4943d

feat(Input): add input label (#13949) * feat(Input): add input label * feat(Input): revert display change from input * feat(Input): adding internal label * feat(Input): flex display * feat(Input): add example * feat(Input): add steps * feat(Input): add steps * feat(Input): steps id * feat(Input): export InputLabel * feat(Input): remove container class * feat(InputLabel): add test * feat(InputLabel): fix chidlren error * fix: make getShorthandInfo compatible with `compose()` * feat(InputLabel): add best practices * feat(InputLabel): add changelog * feat(InputLabel): revert componentGenerators file change * feat(InputLabel): fix input container for icon * feat(InputLabel): vertical align * feat(InputLabel): labelId * feat(InputLabel): try usage of context * feat(InputLabel): add comment * feat(InputLabel): use variables * feat(InputLabel): fix id * Update packages/fluentui/react-northstar/src/themes/teams/components/Input/inputVariables.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/react-northstar/src/themes/teams/components/Input/inputVariables.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/react-northstar/src/themes/teams/components/Input/inputStyles.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(InputLabel): update proptypes from InputLabel * Update packages/fluentui/docs/src/examples/components/Input/Variations/InputExampleWithLabels.shorthand.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/docs/src/examples/components/Input/Variations/InputExampleWithLabels.shorthand.steps.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/docs/src/examples/components/Input/Variations/InputExampleWithLabels.shorthand.steps.ts Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/docs/src/examples/components/Input/BestPractices/InputBestPractices.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/CHANGELOG.md Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(InputLabel): remove docgen change * feat(InputLabel): move example to slots * feat(InputLabel): Stable child props * feat(InputLabel): id for label * feat(InputLabel): fix for autocomplete * feat(InputLabel): Fix merge * feat(InputLabel): Fix test * feat(InputLabel): Fix styles * feat(InputLabel): small review Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com>

view details

push time in 14 days

push eventlevithomason/fluentui

Levi Thomason

commit sha c074aec62c1e65b87c5c5dad8a5390f85ed9acea

stub useDesign function and tests

view details

push time in 15 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 7863b2973b5c9e23bd1b0bcb32cf44c246e8321f

deploy docs [ci skip]

view details

push time in 15 days

created tagSemantic-Org/Semantic-UI-React

tagv1.0.0

The official Semantic-UI-React integration

created time in 15 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha ef532ffe1e05ae1cf45a543241afd2b68826678d

1.0.0

view details

push time in 15 days

push eventSemantic-Org/Semantic-UI-React

Levi Thomason

commit sha 799d4e927a595a95eab842eb068efc31d3252b4b

docs: remove development warning from readme [ci skip]

view details

push time in 15 days

push eventlevithomason/fluentui

Roman Sudarikov

commit sha 15dc5e8e782565c75bc5d637813cee8be2b8a384

feat(Datepicker): Extract utility functions from date-time/Calendar* (#13640)

view details

Esteban Munoz

commit sha 8800f1cab6daba604e97652c87c3a134994f8887

@fluentui/react-conformance - adding isConformant() example to slider and fixing bugs (#13656)

view details

Xu Gao

commit sha d4a876865dc29f979daf58d099cc90f4244137dd

fix storybook hardsource errors (#13691)

view details

Esteban Munoz

commit sha 7e490986f3c1b27a2702acbed5ee15a8531e7537

@fluentui/react-button - Adding conformance tests to components (#13690) * adding isConformant to react-button * modifying jest setup * Change files

view details

jameelakowsar

commit sha 58b2b5638d52a34fa16f0bd5ddf4d615a0311ad9

Doughnut chart - circular accessibility updated. (#13662) * doughnut chart circualr accessibility issue resolved * Change files * change log Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Xu Gao

commit sha ffb1099f3e09f1524d499b397a01377a7763066a

Keytips: storybook example fixes (#13687) * Keytip storybook example fixes * Change files * update snapshot * remove file

view details

Andrew Martin

commit sha 1118c621662b0b0bd95a6a83aff3b845109b1a86

fix(Form): update layouts in Teams theme (#13292) * updating form layouts

view details

Makoto Morimoto

commit sha 2437057f63caf20ffd76bfa5b16c234520b156d2

Creating compat layers for Button, Checkbox, Link, Pivot, Slider and Toggle components (#13575) * Re-exporting react-button in react-next. * Change files * Fixing validation issues. * Adding compat layers for other enhanced components in react-next. * Updating API. * Fixing merge conflict. * Adding missing package to jest mapping. * Moving compat layer to compat folder. * Updating API. * Enabling api-extractor on compat layer. * Fixing lint error. * Updating change file. * Allowing apiExtractorVerify check all api-extractor.json files. * Fixing check for folder existence. * Allowing for compat imports in lint rules. * Update API Extractor tasks * Fixing mismatched versions lint error. Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

view details

Karel Rymeš

commit sha 0866ae174dad3f7ebee6e232598f4025ecf9ab71

fix(Avatar): Fixing name initials bug in Avatar component. (#13682) #### Pull request checklist - [x] Addresses an existing issue: Fixes #13619 - [x] Include a change request file using `$ yarn change` #### Description of changes The changes focus on allowing an input of whitespace characters to construct proper initials. This is achieved through passing an initial value to the accumulator function. #### Focus areas to test The Avatar tests were extended to include broader ranges of inputs; specifically focusing on corner cases. Some of the test cases were taken from the FabricUI [initials utilities tests](https://github.com/microsoft/fluentui/blob/78a6692613ae3b445e785a4062ae3a704fb3ae4c/packages/utilities/src/initials.test.ts).

view details

Oleksandr Fediashov

commit sha 5d8ac767d84df0031201834f4ac061bcc74e7b36

fix(Dropdown): change order of callbacks (#13707) * fix(Dropdown): change order of callbacks * add changelog entry

view details

Fluent UI Build

commit sha 67cc1ff1c7460c5d5bba59d94c69513dfd48465f

applying package updates

view details

Oleksandr Fediashov

commit sha f001525576b94658cbd16f433c80fea93badc56d

fix(Dropdown): fix handling of `inputRef` on `searchInput` (#13711) * fix(Dropdown): fix handling of `inputRef` on `searchInput` * add changelog entry

view details

jameelakowsar

commit sha 38ecac09b70b1aa96df20c9974af4adbf95d06eb

Vertical bar chart customization (#13660) * vertical bar chart code changes * high contract code updated * Change files * change log * snapshot test case updated Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

jameelakowsar

commit sha 4768dd6fc3c44bbb9c8bf7442a2c8b1aacad867c

Doughnut chart target alignment updated. (#13703) * doughnut chart targer alignment updated * Change files * change log file Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Andrew Martin

commit sha 0e7b691edfcaa70a1e32e7f854ccb54c7b6e298a

fix(List): updating the list colors to match Teams redlines (#13233) * updating list item

view details

Makoto Morimoto

commit sha 35f5aa25db089b737a8612740de3c378a2ed3f8e

Button: Adding pointer-events: none to :after focus rectangle (#13696) * Button: Adding pointer-events: none to :after focus rectangle. * Change files * Deleting unused story.

view details

Thomas Michon

commit sha ea8341faf77fe72fc91d8d6c66e6e0d3fbb6e8ad

Fix width of header cells in TilesList (#13697) * Fix width of header rows in TilesList * Change files

view details

Xu Gao

commit sha b0b4d703ec1178f2f3d80ead4d78a72e5fc64554

Jest test: add and use act wrapped create (#13713) * add act wrapped create * update componentexamples test * use wrapped create in react-next * Change files * fix * resolve comment

view details

David Zearing

commit sha 2ad257284fddfc2c0115a787ce1aab593e764979

useMergedRefs should return an immutable function (#13712) * useMergedRefs update to be immutable. * adding comment. * Change files * Updated to use refs. * removing unused import. * Updating api. * updating comments

view details

Xu Gao

commit sha 0ea5b852e9aa0a465d15924dcb1607e76db7d431

KeytipData: convert to function component (#13688) * convert KeytipData to function component * update snapshots * Change files * fix lint * add usePrevious hook * fix useKeytipData hook * Change files * fixes * add act to unit tests * fixes * add more tests * improve perf * Change files * merge * merge conflict * avoid keytipdata rendering for toggle

view details

push time in a month

create barnchlevithomason/fluentui

branch : patch/react-northstar_v0.47.x-design

created branch time in a month

pull request commentmicrosoft/fluentui

Button: Adding various tests and updating component to include componentRef

Let's have a sync on this one. I think we moved a little too fast both in merging this and in objecting to it. Let's take a look at the use cases we have, refresh ourselves on the latest React docs dealing with refs and the DOM (especially exposing DOM refs to parents and forwardRef), and hop on a call to discuss. Who's in?

Reminders

👉 We discussed this to a decent degree in our last off site as well, notes aren't too telling but here they are:

componentRef currently supports 2 cases unpredictably - will continue to support both cases but with 2 difft APIs: have a way to always return imperative API but it shouldn’t be abused, separately have something that always gets DOM node.

  • return native DOM element in Stardust vs rn in Fabric, it’s returning the React instance or be line with hooks - imperative api?
  • current Ref in Fluent = findDOMNode

-- https://hackmd.io/8WievoYRQpiAXbP_rBAecA?both

👉 We also have slots, so you can already get a ref to any part of the component, including the root:

const MyComponent = () => {
  const rootRef = React.useRef();
  const iconRef = React.useRef();
  const headerRef = React.useRef();
  const descriptionRef = React.useRef();
  const actionRef = React.useRef();
  const progressRef = React.useRef();

  return (
    <Attachment
      ref={{ ref: rootRef }}
      icon={<MyIcon ref={iconRef} />}
      header={{ ref: headerRef }}
      description={{ ref: descriptionRef }}
      action={{ ref: actionRef }}
      progress={{ ref: progressRef }}
    />
  );
};
dzearing

comment created time in a month

pull request commentmicrosoft/fluentui

feat(Carousel): add CarouselPaddle component

@mnajdova This change is listed as a breaking change. Please update the PR description with adequate info and a before/after snippet so folks can upgrade. Thanks much.

mnajdova

comment created time in a month

push eventlevithomason/fluentui

Charles Assunção

commit sha 841a10671ccbb61d7803e2931f257c0c6393623b

fix(UseKnob): Prevent infinity update (#13356)

view details

Makoto Morimoto

commit sha cc582893be5600df0d710241ca8f8ad4f59f1d39

SplitButton: Making imperative focus call on touch events (#13361) #### Pull request checklist - [x] Addresses an existing issue: Fixes #12486 - [x] Include a change request file using `$ yarn change` #### Description of changes `SplitButtons` in touch scenarios would return to their last focused input when tapped twice. This made interactions with them more difficult. This PR adds an imperative focus call as part of handling the touch events to resolve this issue, which makes the touch handling match closer to the click handling (which does this behavior as part of the browser handling of click events) #### Focus areas to test (optional)

view details

Giuseppe Campanelli

commit sha 13bd77d6062dfbf0209043275a581536aa5cad56

Add autoCapitalize property (#13335) #### Pull request checklist - [x] Addresses an existing issue: Fixes #13231 - [x] Include a change request file using `$ yarn change` #### Description of changes Added autoCapitalize property to inputProperties and textAreaProperties

view details

Andrew Martin

commit sha 72cd52efc041e343538f46beb20e7ef0371d1667

optimizing Teams theme font stack (#13273) * optimizing the font stack to use what TMP/Teamspace Web use

view details

Kenneth Chau

commit sha 4eb6f33eeb419a3189b8c7d2c5e5675fd86a77fd

Make ts composite builds use separate buildinfo files for variants (#13363)

view details

Charles Assunção

commit sha 2bc351b11ce81110a29b0a28f2a25fd8d9076863

chore(HierarchicalTreeTitle): Convert to RFC (#13371) * chore(HierarchicalTreeTitle): Convert to RFC * chore(HierarchicalTreeTitle): Add changelog

view details

Charles Assunção

commit sha e5adec2a91f1b920d1b0a2ab5e29828f2a7f4c30

chore(Dialog): Convert to RFC (#13359) * chore(Dialog): Convert to RFC * fix(Dialog): Add changelog * Update packages/fluentui/react-northstar/src/components/Dialog/Dialog.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Dialog/Dialog.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Dialog/Dialog.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * fix(Dialog): useEffect * chore(Dialog): move functions * chore(Dialog): remove flag * chore(Dialog): remove flag Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Oleksandr Fediashov

commit sha e2ae7d50d4d934743d8e4a45610285471096fe6c

docs(Table): add perf example, make visible existing (#13373) * docs(Table): add perf example, make visible existing * reduce iterations

view details

Oleksandr Fediashov

commit sha 4e3fefb7dd55487762db270e554d280b16fa6580

perf: use mergeVariablesOverrides() to avoid cache breaks when variables are not passed (#13374) * perf: use mergeVariablesOverrides() to avoid cache breaks when variables are not passed * add changelog entry * fix ts issue

view details

Fluent UI Build

commit sha 8b68232e0891b16d3006eb0557c3b64da7ae4bbf

applying package updates

view details

Oleksandr Fediashov

commit sha 03e03eb0fa6c278a00199fcf4bdda19f90627b36

feat(ToolbarMenu): use compose() (#13320) * feat(ToolbarMenu): use compose() * fix import * -added slots and slotsProps to ToolbarMenu * -updated changelog * -fixed popup issue Co-authored-by: Marija Najdova <mnajdova@gmail.com>

view details

Oleksandr Fediashov

commit sha d41b690529ee3c2821c391c4d322ef77acf186d2

feat(telemetry): add cache hits ratio (#13346) * feat(telemetry): add cache hits ratio * fix todo * fix usage * add changelog entry * Update CHANGELOG.md * fix imports * Update packages/fluentui/docs/src/app.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * Update packages/fluentui/CHANGELOG.md * wip * fix UTs * remove debug statements * remove debug statements * fix issue in renderComponent.tsx * fix naming Co-authored-by: Marija Najdova <mnajdova@gmail.com>

view details

Jon Schectman

commit sha c72d3162dfd200b94dc40a8a723c67d47f944046

SliderNext: Completely pull state out to be slot-like (#13365) * update slider to entirely be housed in the useSlider hook * minor spacing * Change files

view details

Elizabeth Craig

commit sha e75129662aa1077eae00831e6f5587e7f3c14a70

SpinButton: reintroduce incorrect semi-controlled behavior (#13367) #### Pull request checklist - [x] Include a change request file using `$ yarn change` #### Description of changes Prior to #13174, the SpinButton incorrectly had "semi-controlled" behavior: even when the `value` prop was provided, it would respect user updates until a new `value` was passed in. (Providing `value` is supposed to mean that the component is controlled and *will not* respect updates, unless the consumer passes in a new `value` in response to change events.) While the SpinButton will definitely have strict controlled behavior in version 8, unintentionally introducing it in version 7 was a breaking change for some consumers. So this PR reverts to the semi-controlled behavior.

view details

taenri

commit sha cfcf5178fb8304109274a68121c7762a91f55d5b

Special Folder Icons (#13347) #### Pull request checklist - [X] Addresses an existing issue: internal bug - [X] Include a change request file using `$ yarn change` #### Description of changes Add special folder icon support for file-type-icons and signals. i.e. Desktop, Documents, and Pictures #### Focus areas to test N/A

view details

Sebastian Öttl

commit sha 557a96005568e03981f184a7d663e6dc490ceffc

Add dedicated touch invoke functionality to SelectionZone (#13241) Add dedicated touch invoke functionality to SelectionZone Co-authored-by: Sebastian Ottl <sebastian.oettl@microsoft.com>

view details

Caleb Zearing

commit sha ecdf482aa6df378ab152850c7bce5d9ab9a53545

Updating Pivot to a function component inside React-Next and tweaks to React-Next and Fabric storybook (#12906) * Updates to create-package. * fixing ts issue. * Adding type safety for scss modules and storybook integration. * Start of project. * Temp changes. * - Pivot update * updating pivot to use components * update * pivot update * removing extra DOM element, adding tests, and updating snapshots * Moving Pivot into react-next, updating storybook addons. * reverting v7 changes. * cleaning up code * Change files * updating the api * snapshot update * updating api * adding resetIds to checkbox.test.tsx * pr feedback * Update packages/react-next/src/components/Checkbox/Checkbox.test.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update change/@fluentui-react-next-2020-04-28-14-01-59-feat-pivot.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update change/office-ui-fabric-react-2020-04-28-14-01-59-feat-pivot.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * pr feedback * update Co-authored-by: David Zearing <dzearing@microsoft.com> Co-authored-by: caleb <czearing@outlook.co> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>

view details

Elizabeth Craig

commit sha eaac0b213003dbb92ef2565dc5c99c7bea8fc3ca

Fix second builds of just-based projects in packages/fluentui (#13392)

view details

Esteban Munoz

commit sha 841d4e5b92526b8713947eebc1e4fd643a550e49

creating react-conformance package (#13355)

view details

Elizabeth Craig

commit sha 6a11d65ce8a09e6eeb2363feb7f804e95a8e5749

Fix update release notes author name (#13387)

view details

push time in 2 months

push eventlevithomason/fluentui

Hector Rincon

commit sha 3312f0b6ae8a09865f9a29d0d2ad7778e1199c5f

Add `renderActiveOnly?` prop to Pivot component to control rendering of PivotItems (#12779) #### Pull request checklist - [x] Addresses an existing issue: Fixes #11965 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR: - Adds a `renderActiveOnly` optional prop to the Pivot component to enable controlling of rendering of the PivotItems. - Adds a story (example) to test the behaviour. Expensive components (components that are costly to mount / render) have to be unmounted/ remounted with the current implementation every time a new PivotItem is shown. This PR adds a toggle (`false` by default, to maintain current behaviour) that instead renders everything on the first Pivot render and only hides the inactive PivotItems, thereby removing the extra mounts/unmounts. Example of expensive components: `<iframes>` have to load/reload everything every time a pivot changes. #### Focus areas to test (optional)

view details

Jon Schectman

commit sha 0237a69b9a723f3bf25353b4960cf1d07fce37d3

Slider hook part 1. (#13260) * root props working * adding in hook file * labelprops working * sliderbox props working * container props working * minor switch to make origin from zero easier * cleanup * update api * Change files * fix aria-label and minor refactor * update api * Update change/@fluentui-react-next-2020-05-20-19-12-25-slider-hook.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * fix aria-label decomp Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>

view details

Xu Gao

commit sha f99b9ac8a9c4be2178964ebcfec717b07b6e7315

Add storybook addon to switch between different theme (#13329) * add theme switching knob * Change files * cleanup * nit

view details

Elizabeth Craig

commit sha 08fa1c9b45c9c9938241740e71b9091a97067d0f

Selection: respect 0 as selected key (#13331)

view details

David Zearing

commit sha 3d91f5bff251e25e9806e9da29def9811a997c43

Adding createClassResolver helper to react-compose (#13330) * Adding createClassResolver * Updating api. * Change files * Updates based on PR feedback.

view details

Makoto Morimoto

commit sha bd9e5d19525801208270d2f74b2cc28732032f7a

Button: Adding bundle, perf and VR tests for Button in @fluentui/react-button (#13328) * Button: Adding bundle and perf test for Button in @fluentui/react-button. * Adding perf test. * Fixing bundle test. * Fixing bundle test. * Adding 'Next' suffix to Button vr stories. * Fixing vr test. * Adding react-button as a dependency of test-bundles.

view details

Xu Gao

commit sha ab57740670cffd44b084be840b9359377b60fb28

add Xu as perf-test co-owner (#13334)

view details

Oleksandr Fediashov

commit sha 9498d7737f66ebaa3a520b1055f85e678c49a8d9

feat(ToolbarMenuRadioGroup|ToolbarRadioGroup): use compose() (#13322) * chore(ToolbarMenuRadioGroup|ToolbarRadioGroup): use compose() * add changelog entries * add and fix UTs * fix exports * fix export name * fix changelog * add export * fix overrideStyles * use slots * fix broken UTs * other fixes

view details

Charles Assunção

commit sha 3ba379e433aab8982aaf1712ad6f5fe7aecea605

chore(RadioGroup): Convert to RFC (#13338) * chore(RadioGroup): Convert to RFC * chore(RadioGroup): Add changelog * Update packages/fluentui/react-northstar/src/components/RadioGroup/RadioGroup.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/RadioGroup/RadioGroup.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Charles Assunção

commit sha f027562d6fbb284cf2dc48af605705b0b16c6179

chore(Layout): Convert to RFC (#13324) * chore(Layout): Convert to RFC * chore(Layout): Add changelog * chore(Layout): Fix circular * chore(Layout): Fix circular

view details

Marija Najdova

commit sha b1455c4f0b83cd1cbe71e989377ef21d0c80f5f0

feat(Toolbar): use compose() (#13341) * -converted Toolbar to use compose * -updated changelog entry * -fix typings

view details

Fluent UI Build

commit sha 1dc036b4710ae47094ba6c8bd5d3f4e3a09e9ea7

applying package updates

view details

Oleksandr Fediashov

commit sha 4721a990b7686d30647f45cd23def03739658efd

fix(useStyles): fix broken caching when "enableBooleanVariablesCaching" and there is no variables (#13345) * fix(useStyles): fix broken caching when "enableBooleanVariablesCaching" and there is no variables * add changelog entry

view details

Oleksandr Fediashov

commit sha b4f0766b97750552d4bb73683c75287341bfde7a

perf: omit "_.findKey" usage in focusVisibleEnhancer() (#13343) * perf: fix focusVisibleEnhancer * fix rebase issue * fix unused import * add changelog entry

view details

Abdul Sal

commit sha b5db12bf09c83da92fc4691df26bc7ebc04a6dfe

Fix the order of Concepts menu items and previous/next buttons of the affected pages (#13305) * docs(Sidebar): Fix the menu items order * docs(pages): Fix the previous and next buttons of Composition page * docs(pages): Fix the previous and next buttons of Shorhand Props page * docs(pages): Fix the previous and next buttons of Icons page

view details

Marija Najdova

commit sha 4e0806c221ce73c1b85b4d2f20bdc6390e51f7c8

feat(ToolbarItem): use compose() (#13321) * wip * added icon and fixed menu * -updated changelog * push changes related to refs * -merge conflicts fixes * -expanded example -added missing variables * -fixed e2e * -resolved merge conflicts * -fixed toolbar radio group -expanded example Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>

view details

Abdul Sal

commit sha a562eba88ce9e1029d0aaeda9cc0e5d59a7a91df

docs(pages): Fix the navigational next button of Component Architecture (#13304)

view details

Charles Assunção

commit sha ff77a1a68d7c4bd1359ece05f300adc6071f65f3

chore(ItemLayout): Convert to RFC (#13327) * chore(ItemLayout): Convert to RFC * chore(ItemLayout): Add changelog * Update CHANGELOG.md * Update CHANGELOG.md * Update packages/fluentui/react-northstar/src/components/ItemLayout/ItemLayout.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * chore(ItemLayout): remove debug styles Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Marija Najdova

commit sha 4e3ddd80bbfc278128aec9c285f22ab6f71a26b3

feat(ToolbarMenuItem): use compose() (#13350) * -added compose in toolbar menu item * -expanded compose example * -added todos * updated changelog * -removed todo * -import fixes

view details

Oleksandr Fediashov

commit sha 67eb2500f077da1c6136bb49e2fc22debd5913ac

feat(ToolbarCustomItem): use compose() (#13319) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes (give an overview) #### Focus areas to test (optional)

view details

push time in 2 months

push eventlevithomason/fluentui

Xu Gao

commit sha 16818508bc150b4cc6f6824d0ef9ef34247241ff

do not clean on start (#13274)

view details

Krystal Siler

commit sha 200b1a0960dbc059918d92385b1a4bb9a5f44406

Update cross platform text documentation for fontSize prop (#13276) * Update documentation for fontSize prop * Change files

view details

David Zearing

commit sha bb3a1059eabff7a81c6666ec7319e66af5d74351

Adding getNativeElementProps (#13272) * Exporting a getNativeElementProps function. * Change files * update api. * pr feedback. * fixing lint

view details

Xu Gao

commit sha 77ade9a313abc59753fb7550cd050ffc38678d44

add react-compose to size auditor (#13279) * add react-compose to size auditor * add dep

view details

Oleksandr Fediashov

commit sha e3e33eb834f2288e3d4a7786800480604bbb476f

chore: reexport themes separately (#13268) * chore: reexport themes separately * add changelog entry

view details

Charles Assunção

commit sha e0ac865b42fc850a5473453eba7abc50602f97a2

fix(dropdown): scroll loading into view (#13175) * fix(dropdown): scroll loading into view * fix(dropdown): fix header condition * fix(dropdown): format comment * fix(dropdown): downgrade to approved version * fix(dropdown): Screenshot * fix(dropdown): Screenshot * fix(dropdown): Screenshot * fix(Dropdown): change stops * fix(Dropdown): snapshot * fix(Dropdown): screenshot * fix(Dropdown): screenshot * fix(Dropdown): changelog

view details

Fluent UI Build

commit sha 387865b75c5a33a576800a15cd663f767964165a

applying package updates

view details

Charles Assunção

commit sha 9088a68478af2071729c9dd4b909b2f25779a68c

feat(Menu): Add children api support (#13227) * feat(Menu): Add children api support * feat(Menu): Pointing example * feat(Menu): Pointing example remove items array * feat(Menu): Underlined example * feat(Menu): IconOnly example * feat(Menu): Icon&Content Example * feat(Menu): Divider Example * feat(Menu): Disabled Example * feat(Menu): Vertical submenu * feat(Menu): Vertical submenu fix * feat(Menu): partially fix submenu * feat(Menu): Fix submenu * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): with submenu * feat(Menu): with submenu controlled * feat(Menu): With Tooltips * feat(Menu): Evaluate accessibility * feat(menu): fix divider * chore(Menu): fix build * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu with controlled * chore(Menu): fix Menu toolbar * feat(Menu): parentComponent Slot * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleSlot.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/menuContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Menu): Review * feat(Menu): fix prop * feat(Menu): fix build errors * feat(Menu): rename example * feat(Menu): delete examples with submenu * feat(Menu): typo * feat(Menu): remove return statement * feat(Menu): Revert parentComponent slot * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): Acessibility for item and divider * feat(Menu): Acessibility for item and divider * feat(Menu): MenuExampleTabList RFC * feat(Menu): onItemClick using actualProps * feat(Menu): onItemClick instead actualProps * fix types * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): pass parentProps to slotProps * feat(Menu): onItemClick stable * feat(Menu): remove unnused * feat(Menu): add changelog * feat(Menu): fix screen * feat(Menu): fix tests * feat(Menu): change divider content condition * feat(Menu): fix item click * feat(Menu): fix item click * feat(Menu): itemClick as null * feat(Menu): itemClick as fixed * feat(Menu): remove onclick from props * feat(Menu): improve onlclick invoke Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>

view details

Elizabeth Craig

commit sha ea77eb18bd42bdca8bb63df675abe01cf7bbd6b4

Add separate node template to create-package (#13275)

view details

erichdev

commit sha eb1750d8c3f1f0e5a6c1506b5b16261454f7b451

FileTypeIcon: Add empty alt text to img (#13194) Co-authored-by: Erich Abellera <erabelle@microsoft.com>

view details

Caleb Zearing

commit sha 80b07ce917c42061ece97c72a4e256101289fc4a

Copying FocusTrapZone to react-next, in preparation for converting to function component. (#13280) * update * Change files * updating api

view details

Tony Xia

commit sha 1edf380e1d06a24c5f7f4dfb4f5d52e512d54315

Fixed more typos (#13247)

view details

Tony Xia

commit sha 8722f6c224ff811107129b41e8e62845e3106e78

Fixed minor typos (#13246)

view details

Charles Assunção

commit sha 12530399bcff7c8849a175f8e0bd67fc0870366b

chore(HeaderDescription): Convert to RFC (#13296) * chore(HeaderDescription): Convert to RFC * chore(HeaderDescription): AccessibilityType

view details

Charles Assunção

commit sha ff0425db96ad245137d1786df05f5958043255e9

chore(Loader): Convert to RFC (#13297) * chore(Loader): Convert to RFC * chore(Loader): Fix loader id usage * Update packages/fluentui/react-northstar/src/components/Loader/Loader.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * chore(Loader): Fix delay * chore(Loader): add changelog Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Charles Assunção

commit sha 7a2822b05a9a816056784a7b27acc3806315d9b9

chore(PortalInner): Convert to RFC (#13298) * ga * chore(PortalInner): Add chagelog * chore(PortalInner): Add chagelog * Update packages/fluentui/react-northstar/src/components/Portal/PortalInner.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Portal/PortalInner.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Portal/PortalInner.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Portal/PortalInner.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Portal/PortalInner.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/CHANGELOG.md Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * chore(PortalInner): Fix imports Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Elizabeth Craig

commit sha 56db85a8a435bfafe0354bf5b74eb56be92e3a35

Remove implicit dep on lodash in charting package (#13295) * Remove lodash references and fix imports * Change files * findIndex: add fromIndex argument * fix naming and API file

view details

Fluent UI Build

commit sha 0b2d08c4a31cf9df97199f7e2d7945c0280efbb5

applying package updates

view details

Charles Assunção

commit sha 2cc65e33e8ec772aff95d433056a2abc8ed640a0

chore(RadioGroupItem): Convert to RFC (#13301) * chore(RadioGroupItem): Convert to RFC * chore(RadioGroupItem): Add Changelog * chore(RadioGroupItem): add deo to the hook * chore(RadioGroupItem): change condition * chore(RadioGroupItem): Move on change trigger

view details

Marija Najdova

commit sha 072549124566c7512870a5d769c40fd2f509aca0

feat(Menu): support compose for submenus (#13300) * feat(Menu): Add children api support * feat(Menu): Pointing example * feat(Menu): Pointing example remove items array * feat(Menu): Underlined example * feat(Menu): IconOnly example * feat(Menu): Icon&Content Example * feat(Menu): Divider Example * feat(Menu): Disabled Example * feat(Menu): Vertical submenu * feat(Menu): Vertical submenu fix * feat(Menu): partially fix submenu * feat(Menu): Fix submenu * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): with submenu * feat(Menu): with submenu controlled * feat(Menu): With Tooltips * feat(Menu): Evaluate accessibility * feat(menu): fix divider * chore(Menu): fix build * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu with controlled * chore(Menu): fix Menu toolbar * feat(Menu): parentComponent Slot * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleSlot.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/menuContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Menu): Review * feat(Menu): fix prop * feat(Menu): fix build errors * feat(Menu): rename example * feat(Menu): delete examples with submenu * feat(Menu): typo * feat(Menu): remove return statement * feat(Menu): Revert parentComponent slot * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): Acessibility for item and divider * feat(Menu): Acessibility for item and divider * feat(Menu): MenuExampleTabList RFC * feat(Menu): onItemClick using actualProps * feat(Menu): onItemClick instead actualProps * fix types * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): pass parentProps to slotProps * feat(Menu): onItemClick stable * feat(Menu): remove unnused * feat(Menu): add changelog * wip * merge conflicts * feat(Menu): fix screen * feat(Menu): fix tests * feat(Menu): change divider content condition * feat(Menu): fix item click * feat(Menu): fix item click * chore * tests * Update packages/fluentui/react-northstar/src/components/Menu/menuContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/menuContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * -fixes * -props rename * -updated changelog * -moved menu props to slot props Co-authored-by: Charles Assuncao <junioassuncaocharles@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>

view details

push time in 2 months

create barnchlevithomason/fluentui

branch : feat/faster

created branch time in 2 months

push eventlevithomason/fluentui

Michael Loughry

commit sha 8caa94d30aaec06bc511b61344265de066815667

Migrate Fabric component to function component (#12923) * Migrate Fabric component to funtional component * Forward ref * Fix line endings * Add tests * Merge from master * Migrate to react-next * Change files * Fix display name convention * Update api

view details

Xu Gao

commit sha 044fc026e5121c54427d8b9fb489dcb174d109cb

fix updateReleaseNotes script path (#12950) * fix updateReleaseNotes script path * Update azure-pipelines.release.yml Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>

view details

Philip Kuo

commit sha 2408412993a71f675b82905a3012135202470306

Theming: fix and run SASS autogenerator for theme slots (#12949)

view details

Fluent UI Build

commit sha 081078fb222b5e999a9486a6d224ae01fcf219a8

applying package updates

view details

Jacqueline Gaherity

commit sha fbcfa2856add63c1d241db6cb56e43ecf85ce229

Azure-theme component style updates per Azure portal design team (#12537) * Azure-theme component style updates per Azure portal design team * Change files * FIxing build errors * Reformatting per feedback * Calling import to remove error * lint error fixes * Lint error fixes * Removed pointer * todo comment per Hiyos' recommendation Co-authored-by: Jackie <jagaheri@microsoft.com>

view details

Fluent UI Build

commit sha 86582f4d5200e1ac0a1d782fd77e93f133f143f5

applying package updates

view details

Micah Godbolt

commit sha 07b02c8ee75dd5ca4e47f06f724fe51f21769cac

Website: Update Icon Product Page (#12958) * Updated ofice brand icons * Change files * point to new cdn

view details

David Zearing

commit sha 4fa20a22f1cfe0700690cc971973e0cc8b12534b

@fluentui/react-stylesheet fixes (#12954) * Adding react-avatar. * Adding Avatar. * Updating Avatar to use raw sass. * blah. * more updates. * Changes. * Shorthand props now work * more updates. * Adding PersonaCoin example. * Cleanup. * Updating url. * changes * more changes. * Adding button. Renaming handledProp to mappedProp. * Addressing missing font definitions. Adding stylesheet support to themeprovider. * Addressing review feedback. * Merge branch 'master' of https://github.com/microsoft/fluentui into feat/avatar # Conflicts: # apps/test-bundles/package.json # packages/fluentui/react-northstar/src/components/Provider/Provider.tsx # yarn.lock * Undoing changes. * undoing a few more changes. * Updating react-compose dependency * Fixing broken things. * Integrating useStylesheet. * Updates. * undo * more undo * yarn lock * Change files * updating api.

view details

Micah Godbolt

commit sha d40f4629b7bde5795090e84eed6896190dab3f4e

Website: Update 'forms' text on icon page (#12962) * Website: Updated Forms icon text * Change files

view details

Michael Loughry

commit sha 9e53b82fcc814a0ec53e34a77ed25bcebb256d19

Image: Migrate Image to function component (#12908) * Add new hooks used in migrating Fabric components to functional components * Change files * Cherry pick revision from MLoughry:functional/checkbox * Fix lint error * Address comments from dzearing * Fix launch.json for debugging tests * Use common onChange call signature * Fix useControllableValue types in case with no onChange handler * Export ChangeCallback type * Persist the controlled vs uncontrolled state * Update packages/react-hooks/src/useMergedRefs.ts Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com> * Update README * Allow for undefined events in the onChange callback * Fix error in isControlled value * Delete test for deprecated behavior * Update packages/react-hooks/README.md Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com> * Update packages/react-hooks/README.md Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com> * Migrate Image to function component * Fix naming * Move changes to react-next package * Clean up a bad merge * Clean up prettier changes * Change files * Copy OUFR lint config * Address comments Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>

view details

Marija Najdova

commit sha d2965c140976180661acb4271ee74ddc820f71d7

feat(react-icons): add fill currentColor (#12948) * -added fill current color on the svgs * Change files * Updating snapshot. * Change files Co-authored-by: David Zearing <dzearing@microsoft.com>

view details

Caleb Zearing

commit sha c369780b48c8f1479d91a35f5dbea69ea84dd830

Copying SpinButton to react-next, in preparation for converting to function component (#12955) * moving files and updating imports * Change files * api update

view details

William Saulnier

commit sha 20f14bb438b950570662eab97ee5e021828e4f4b

Add an imperitive focus call to handleTouch (#12946) #### Pull request checklist - [x] Addresses an existing issue: Fixes #12486 - [x] Include a change request file using `$ yarn change` #### Description of changes Split buttons in touch scenarios would return to their last focused input when tapped twice. This made interactions with them more difficult. Adding an imperative `focus` call as part of handling the touch events, as suggested by @khmakoto, worked well to resolve this issue, and made the touch handling match closer to the click handling (which does this behavior as part of the browser handling of click events) #### Focus areas to test Button interactions in touch scenarios.

view details

Caleb Zearing

commit sha 538a70e01f666b269dc75a3d0edbc7cd86c1d095

Copying Toggle to react-next, in preparation for converting to function component (#12969) * Adding Toggle component to React.Next * Change files

view details

Elizabeth Craig

commit sha d93ac86ba129ec4809c0ca4f6b8d128c85c39666

Revert "Add an imperitive focus call to handleTouch (#12946)" This reverts commit 20f14bb438b950570662eab97ee5e021828e4f4b.

view details

Elizabeth Craig

commit sha 4039ef722c1c3ee5bf14eed0a49477eaf773cd08

Switch create-package to plop (#12915) Switch the `create-package` script to use [`plop`](https://plopjs.com/) (thanks @kenotron for the idea!). This makes the template structure much more readable and provides other more powerful features. Note that I **did not** yet update the template to the agreed converged structure; that will be done separately. The only change was removing the `typescript-plugin-css-modules` dep (and places it was used) because @dzearing said we want to do a different approach. Delete the `create-component` and `create-page` (website) scripts because they're out of date. We can add a new `plop`-based `create-component` script once we decide how a converged component template should look.

view details

Makoto Morimoto

commit sha ce067e65e8fee3fb56fcea401b920237e7879ff0

FocusZone: Changing restoreFocusFromRoot to preventFocusRestoration in v0 and bringing functionality to v7 (#12615) * FocusZone: Bringing restoreFocusFromRoot functionality to v7. * Change files * Updating tests. * Change files

view details

Charles Assunção

commit sha 9ed642bd21c18de98cb3f3c7e1bb0555fba429a3

chore(CarouselNavigation): Convert to RFC (#12937) * chore(CarouselNavigation): Convert to RFC * chore(CarouselNavigation): Add changelog * Update packages/fluentui/react-northstar/src/components/Carousel/CarouselNavigation.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Charles Assuncao <charles.assuncao@microsoft.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

view details

Charles Assunção

commit sha a61340a32d51068c084f766875d0133dede1b9a1

fix(Accordion): Control itemsRef (#12944) * chore(Accordion): Control itemsRef * chore(Accordion): Remove expanded from memo dep * chore(Accordion): Control ref by state * chore(Accordion): Remove refs from state * chore(Accordion): Add refs from state * chore(Accordion): remove log * chore(Accordion): useMemo * chore(Accordion): Type UseMemo * chore(Accordion): Prevent length on undefined * chore(Accordion): Remove length as dep * chore(Accordion): Add length as dep Co-authored-by: Charles Assuncao <charles.assuncao@microsoft.com>

view details

Charles Assunção

commit sha 43124264d32cf177390500b4d8f71657b0850a68

docs(Changelog): add changelog (#12983) * fix(Accordion): Add changelog Co-authored-by: Charles Assuncao <charles.assuncao@microsoft.com>

view details

push time in 2 months

push eventlevithomason/fluentui

Levi Thomason

commit sha 5e0b3845ba33c042edce14e7abeec263e1de5050

fix component tokens

view details

push time in 3 months

push eventlevithomason/fluentui

Levi Thomason

commit sha 616e9ccaad54b4f9caac574f45826a6659481780

split into full page view

view details

push time in 3 months

push eventlevithomason/fluentui

Levi Thomason

commit sha 2cc6b643901773e374cf81240d716b777883537d

move route to /themes

view details

push time in 3 months

push eventlevithomason/fluentui

David Zearing

commit sha fdb9ddd00c2da0efa3e24c150695c8e2ef884cfd

@fluentui/react package minor script cleanup. (#12377) * Cleanup. * Change files

view details

David Zearing

commit sha d83f78f7a8f3a09addb64f6c2f3955152698173f

Update README.md

view details

David Zearing

commit sha db22bc38b09244d3951eee2e79b6b11c5cafd395

Update README.md

view details

David Zearing

commit sha c0a3b2b60082bd83654f69c90a669b61146a2e65

Update README.md

view details

Elizabeth Craig

commit sha 6c7858ac94f492a9620a108c184c028f782bc9b3

Replace OfficeDev/office-ui-fabric-react with microsoft/fluentui (#12378) * Replace OfficeDev/office-ui-fabric-react with microsoft/fluentui * Change files * Update azure-pipelines.release.yml Co-Authored-By: David Zearing <dzearing@microsoft.com> * Update azure-pipelines.release-fluentui.yml Co-Authored-By: David Zearing <dzearing@microsoft.com> * update devops urls Co-authored-by: David Zearing <dzearing@microsoft.com>

view details

Xu Gao

commit sha 492fff101f5943affeae637bebe761fdd163b0a0

Group publishing for @fluentui/react and office-ui-fabric-react packages (#12383) * bump beachball * bump script * add version group * fix change file * bump beachball * remove bump script

view details

UI Fabric Build

commit sha 983b6a77a0faf4faed6641f2bc3235a1d9c0376a

applying package updates

view details

David Zearing

commit sha 779ac4a9a91ee8c6e05d702223c0c2b331510e20

Updating account display name.

view details

Rajesh Goriga

commit sha ee8a04b544f9941094a57e21db2a53fd00a2f587

expose prop for overflow items text in legends (#12388) * expose prop for overflow items text in legends * Change files * Add overflow text for legends overflow label * Replace callout id with getID Co-authored-by: Satish kumar Garaga <v-satgar@microsoft.com>

view details

Charles Assunção

commit sha fe11adfece5ee4cafec44b826c2eada9addd085b

feat(ResponsiveTable): Adding responsive table prototype (#12360) Co-authored-by: Charles Assuncao <chassunc@microsoft.com>

view details

Fluent UI Build

commit sha 76326a9ca3061f631b3893292e2cf6c930d6d12e

applying package updates

view details

Oleksandr Fediashov

commit sha 3ad8d6c377023a7eb5c6c0ab5e01940d62a1f9f6

fix(Toolbar): fix positioning for overflow ToolbarMenu (#12390) * fix(Toolbar): fix positioning for overflow ToolbarItem * add border * add RTL sample * add changelog entry * update entry * update steps * update steps * update steps * update steps * add duplicate for RTL * one more update

view details

Miroslav Stastny

commit sha ceced99b2224262ce24926e395d477a9c5d793e3

Measure bundle size of individual react-northstar components (#12374) * Add bundle size examples to docsite * Show per-example bundle size charts in docsite * Bundle size examples * address PR comments * changelog * fix external bsize examples

view details

Vitalie Braga

commit sha edd11deae5d3efa05d183aa4eefe2dbb672bcb59

Vibraga/fix mdl2 focus button (#12399) * Fix focus styles for buttons in MDL2 package * Change files

view details

David Zearing

commit sha cb7797a92208cb641d6f31e759c7445db0f492d8

Styling: adding bold font weight definition (#12398) * Define the bold font... * Change files * Adding visual regression test for weights. * Adding snapshot.

view details

Elizabeth Craig

commit sha 7d04235e8690200da43cad4516992a7450e02c4c

Minor script fixes (#12370)

view details

Aleksandr Shevchenko

commit sha 49290e1ba3da2035073790a52caacf3a12b853d3

Hide Safari default input outline (#12279) * Fix default Safari outline * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Juraj Kapsiar <jurokapsiar@gmail.com>

view details

jameelakowsar

commit sha 40c445f41399230fd1fa24c8a3aab40128aad741

Vertical stacked bar chart added to @uifabric/charting (#12308) * verticalStackedBar axis and graph * callout and focus added to verticalStackedChart * legends added and code restructured * Y-axis issues fixed and code optimized * Axis issues * render code optimized * optimized code * removed test file * Change files * imports order changed * imports format changed * styles changed and unwanted styles removed * Styles changed as per review * change file info changed and linter rules applies * height adjustments of graph done * added 10px for better graph alignments Co-authored-by: Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) <v-jasha@microsoft.com>

view details

Micah Godbolt

commit sha 0b0df50c68ee6996f39470c308af8a0eb9b24f81

Update Fabric website to "Fluent" (#12366)

view details

Fluent UI Build

commit sha 823bfe5371b9449e9099cd85f7bb243527ad3b42

applying package updates

view details

push time in 3 months

PullRequestEvent

pull request commentWICG/open-ui

Add design token page

@gregwhitworth Whoops, yea this is still ongoing. It will be long running.

@nicholasrice Per our sync today, we've agreed to not prefix token names by default. In order to handle inevitable collisions, we'll ensure systems have the option to prefix token names. This will also allow interop and embed scenarios to play nicely together.

nicholasrice

comment created time in 3 months

push eventWICG/open-ui

Levi Thomason

commit sha 1e0eb4977ff2e56c46e6777ed37f816a734f07ae

Clean up buttons and improve concepts (#60) * clean up images * add many missing specimens, improve openUIName * add more button images, improve organization * add fast button images * cleanup logs

view details

push time in 3 months

delete branch WICG/open-ui

delete branch : research/cleanup-button

delete time in 3 months

PR merged WICG/open-ui

Clean up buttons and improve concepts

This PR adds many missing button images. It also fixes many of the images to be more appropriate.

I also updated the openUIName which is used to link similar specimens. Here's an example of how we display grouped images now:

image

  • The openUIName is used for the heading
  • There is a coverage meter for each other name it is known by
  • The specimens that are known by a different name in their design system show their other name in bold
+503 -134

3 comments

91 changed files

levithomason

pr closed time in 3 months

pull request commentWICG/open-ui

Clean up buttons and improve concepts

Thanks for the ping. Will get this released.

Note, there's a billing issue with Netlify that is failing PRs that I've been working on in the background. We should be able to release without that.

levithomason

comment created time in 3 months

push eventWICG/open-ui

Levi Thomason

commit sha 726ae98d264f1d720954773111a0f6c7e2072c4f

cleanup logs

view details

push time in 3 months

push eventWICG/open-ui

Greg Whitworth

commit sha 775a09fad05bc4f5d229bdd1354031afea3dd5f2

Charter initial draft (#67) * Initial draft of charter * Added roles of the chairs * A few minor changes * Fixed issue that was causing stateful page creation loop * Update research/src/pages/charter.research.mdx Co-Authored-By: Nicholas Rice <nicholas.rice119@gmail.com> * Addressed suggestions based on today's telecon Co-authored-by: Nicholas Rice <nicholas.rice119@gmail.com>

view details

Greg Whitworth

commit sha f4ad316a9b9374153e73db9860ff25225e9c63cc

Updating the select specification to the template (#70) * Updated anatomy * initial updates to select and investigations into behaviors * Added open questions * Updated select spec to match template and other items * Update research/src/pages/select.proposal.mdx Co-Authored-By: Nicholas Rice <nicholas.rice119@gmail.com> Co-authored-by: Nicholas Rice <nicholas.rice119@gmail.com>

view details

Greg Whitworth

commit sha 86bcab88ff43ab41384f7e25e0dce8aa78d66e84

Updating the select (#71) * Updated anatomy * initial updates to select and investigations into behaviors * Added open questions * Updated select spec to match template and other items * Added attributes and properties for select, optgroup and option * Updated title

view details

Greg Whitworth

commit sha fee9356f90170818244d04a4e5daa13d5003e4e0

Updated name and fixed some merge issues

view details

Greg Whitworth

commit sha d62246f0f5ac3c66e9204aad9b09f9df3eb392f2

Removed dupe content from merge

view details

Greg Whitworth

commit sha 2ed621547d172ce838f4f36b509b2cb797f44084

Improved styling a bit for general specs by adding a root stylesheet

view details

Greg Whitworth

commit sha 2b5ff787d5abbba34a5a5f97ce156a7968ff89a6

Added styles file

view details

Greg Whitworth

commit sha 53abd043a2e9d25c0b6d6154dd40b3c6480d4b2a

Adding initial editors for select & template (#72)

view details

Greg Whitworth

commit sha 5ec99d17182016b6b8e355e4d1950c238583076b

Updated anatomy.css and the naming of the anatomy per our discussion regarding the issue

view details

Greg Whitworth

commit sha 3e0ccfbd1e4786879a5ee5ef41878a305652c370

Merge branch 'master' of github.com:WICG/open-ui

view details

Greg Whitworth

commit sha 12d8d36e5682a6dc77e7f33524ba5020a3592308

Fixed color issue in anatomy of optgroup

view details

Greg Whitworth

commit sha 8874216576d8328d1bd40708a39727e621c286ea

Removed element brackets to keep it consistent

view details

Greg Whitworth

commit sha e5f73d7751afaf7640af417b86c0fc585636de5c

Added in links to WIA-ARIA and about listbox positioning

view details

Greg Whitworth

commit sha 7e95e60c63b83ecce43c73677dbed9e84d61dc30

Updated look of anatomy and added capability to toggle slots, fixes issue #75

view details

Greg Whitworth

commit sha 7bf3ef5bb677e4f4c2f4ede030ddd2dcd78d331f

Added meeting minutes and information on how to join meetings

view details

Greg Whitworth

commit sha 32265ab96e60661f6fbb5640815759d4531eeb01

Added link to minutes page

view details

Greg Whitworth

commit sha c9d2fda8965f9205f7197cd67da4b00d19720612

Sharp was consistently crashing and I found that upgrading all dependanices (in particular gatsby sharp) fixes this issue. Submitting an update in hopes of others seeing the same benefit (#76)

view details

Greg Whitworth

commit sha 2a43a7e6cb2dc8546d1b3bf6dd6ac88b1b6683aa

Added 2 additional slots that are required

view details

Greg Whitworth

commit sha 289c96eff1bc1cd45db797419c15adde9bd7f696

Adding contribution information (#84) * Added more information to the contribute page on how to write up a research and proposal page * added anchors * Added clarification that not all sections are required

view details

Levi Thomason

commit sha a8a6605c87aae32305018738a065b0b959f71324

Merge branch 'master' into research/cleanup-button

view details

push time in 3 months

issue closedSemantic-Org/Semantic-UI-React

Long text flows outside of label attached to image

Bug Report

Steps

Create an Image with a label attached to it. This is the component that is giving me the text sitting outside the label.

    <Image
      size="tiny"
      circular
      src={imageSource}
      label={{
        attached: "bottom",
        basic: true,
        circular: true,
        content: "Luke Groundwalker"
      }}
    />

Expected Result

I expected the text to sit completely within the label

Actual Result

The actual result that happened 💣 image

Version

0.88.1

Testcase

https://codesandbox.io/s/semantic-ui-react-4950g?fontsize=14

closed time in 3 months

kwayebopp

issue commentSemantic-Org/Semantic-UI-React

Long text flows outside of label attached to image

Thanks for using SUIR! This is a CSS bug and would be fixed in https://github.com/Semantic-Org/Semantic-UI which is the main repo where styles are stored.

In the meantime, I would likely add a custom style that targeted .ui-label and extended the styles with the look you after.

A more appropriate fix would be to use a custom theme that implemented the styles you preferred. You can see more on that here: https://react.semantic-ui.com/theming.

kwayebopp

comment created time in 3 months

more