profile
viewpoint
Marten Deinum mdeinum Conspect Consulting & ICT Meppel, The Netherlands http://mdeinum.github.io Husband, Father, Lifeguard, Scuba Instructor, Consultant, Author, Pragmatist, Open Source Enthusiast.

mdeinum/legacy-app 5

Code for the Improve your legacy app with Spring talks.

mdeinum/blog-database-up 4

Sample code for the Database Startup Validator blog post.

mdeinum/dddsample-core 1

This is the new home of the original DDD Sample app (previously hosted at sf.net)..

mdeinum/microservice 1

Sample of a Microservice setup for my book. Based on Spring Cloud / Netflix / Java / Docker / Docker Compose / Docker Machine / Vagrant

mdeinum/adventurebuilder 0

Code of the old Adventure Builder reference application for using in the architecture conformance tutorial

mdeinum/awesome-annotation-processing 0

A curated list of resources related to the Java annotation processoring API (JSR 269)

mdeinum/blog-spring-contexts 0

Project code belonging to my ApplicationContexts and Bean configuration blog post.

push eventmdeinum/securing-devops

Marten Deinum

commit sha 385780526a04e88162e0e0abd084a9ab960b7630

Add Spring Security Adding Spring Security will add most of the headers and protect cookies.

view details

push time in 9 hours

push eventmdeinum/securing-devops

Marten Deinum

commit sha 61fc85b91be65af0d547b7f6d270403ae6a51160

Add ZAP Baseline Scan

view details

push time in 9 hours

push eventmdeinum/securing-devops

Marten Deinum

commit sha 02431904dc7abb006cc4e88f18419ec727d0aedf

Add ZAP Baseline Scan

view details

push time in 10 hours

push eventmdeinum/securing-devops

Marten Deinum

commit sha aafafbb45843e9c19290c7f7b0bc5cf1ec5b21e3

Add ZAP Baseline Scan

view details

push time in 10 hours

issue commentspring-projects/spring-framework

RequestDispatcher forward not working with OncePerRequestFilter with Spring boot 2.3.* version but working fine till 2.2.10

Since Spring Boot 2.3 all OncePerRequestFilters are attached to all dispatch types https://github.com/spring-projects/spring-boot/issues/18953.

nitinit

comment created time in 16 hours

push eventmdeinum/securing-devops

Marten Deinum

commit sha ac321f2fa821a87f1d0ac06a6918b239ae4d21f5

Fix CI build

view details

Marten Deinum

commit sha 7a165be012afa904cb4acba21edfe0ee8ebbc039

Remove JUnit4

view details

push time in 4 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 5bd8e9a42bab44986011fa4651df538a2247e70b

Fix CI build

view details

push time in 4 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha f11eff4e75c6307a76093b01fa82b0066f90f996

Remove usage of jQuery Modify the JavaScript of the application to not need jQuery to prevent security issues.

view details

push time in 4 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha a2e8ce2e078bb2fcf7d9d8c75e973476a4aeec91

Upgrade to Spring Boot 2.3.4 Upgrade to newer Spring Boot version to fix several security issues.

view details

Marten Deinum

commit sha 589e04f1b9a1dbea3e0dcbf56bf1db6457d19ebb

Remove usage of jQuery Modify the JavaScript of the application to not need jQuery to prevent security issues.

view details

push time in 4 days

push eventmdeinum/spring-framework

Arjen Poutsma

commit sha e9d9de5f998b0112d472cadf9bed0d6c0bba87a4

RouterFunction honors PathPatternParser in config This commit introduces a way to change the PathPatternParser used in PathPredicates, by way of a ChangePathPatternParserVisitor. This visitor is used by both WebFluxConfigurationSupport and WebMvcConfigurationSupport to make sure the configured parser is used. Closes gh-23236

view details

Arjen Poutsma

commit sha 20254f02d2ed962753bbd00e0c6d9455dd246713

Polishing

view details

Arjen Poutsma

commit sha 79c339b03e4fca4d58598207cf8e6d8c2c54652d

Support for ASCII in Jackson codec & converter This commit introduces support for writing JSON with an US-ASCII character encoding in the Jackson encoder and message converter, treating it like UTF-8. See gh-25322

view details

Arjen Poutsma

commit sha e251075d6c8487ac8dfea7b9b261e70f83432a8c

Merge branch '5.2.x'

view details

Sébastien Deleuze

commit sha 9d37794ebcc403e33f343e41ec121ddb83e30328

Avoid using LiveBeansView in GraalVM native images Closes gh-25344

view details

Rossen Stoyanchev

commit sha b2a4d1c5b175844345d027d72eec321e6c1bd0d3

Avoid re-creating connect Mono<RSocket> Closes gh-25330

view details

Rossen Stoyanchev

commit sha 3aaff40e2ea3719eaaa98689e058c3edcc0a6e8a

Replace explicit use of PooledDataBuffer.release()

view details

Rossen Stoyanchev

commit sha 5e1b6e3386cf6b62d77840294bd726681bc2d6bd

Merge branch '5.2.x'

view details

Arjen Poutsma

commit sha 5b94d9b00b88b12fc0eb0eadd95de079826a110b

Use UTF-8 for application/*+json This commit makes sure that the StringHttpMessageConverter reads input with "application/*+json" as Content-Type with the UTF-8 character set. Closes gh-25328

view details

Arjen Poutsma

commit sha f13ab6d18c78e593d5c41cd6355b2e6710b27b01

Merge branch '5.2.x'

view details

Maksim

commit sha 008a0a1bdd3a0a5c394cb688108f767ec101e859

Fix interface and class names in examples in core-aop doc Closes gh-25351

view details

Sam Brannen

commit sha 85a46882ce7a0dce7179b68f9e724b465da639ef

Merge branch '5.2.x'

view details

Johnny Lim

commit sha 72e92211ce3db15d87551737bb41aba987c47c39

Polish mutateContextPathWithoutUpdatingPathShouldFail() Closes gh-25352

view details

Sam Brannen

commit sha 35582ded0e6619fa0d86fe1eb0182274456767b7

Use System.nanoTime() for Random seed in SocketUtils Prior to this commit, SocketUtils used System.currentTimeMillis() for the seed for the java.util.Random instance used internally. The use of the milliseconds value returned by currentTimeMillis() can lead to collisions for randomly selected free ports for tests executing in parallel on the same computer. This commit therefore switches to System.nanoTime() for the Random seed used in SocketUtils in an attempt to avoid such collisions for tests executing in parallel in different JVMs on the same computer. Closes gh-25321

view details

Sam Brannen

commit sha 362e228142287f3f1042fa8a71c2ef4773f84e55

Merge branch '5.2.x'

view details

Sam Brannen

commit sha 4ae98958142f8cce21d54f5a21a536766900f608

Upgrade to Gradle 6.5.1

view details

Brian Clozel

commit sha 32ab596e94ef15b15174218229c8ba216aece138

Upgrade CI to JDK15ea30

view details

Rossen Stoyanchev

commit sha 34607d96f1f40efae1dc83274c8b4d8eb632b790

PathPattern caching with HandlerMappingIntrospector This commit evolves the solution from M1 by parsing and caching patterns with the target HandlerMapping's PathPatternParser. This makes it unnecessary for callers to be aware of pattern parsing. Closes gh-25312

view details

Sam Brannen

commit sha 52c2ca610b6f583f5ab2a068240e4f10cc279a9a

Polish AOP reference documentation - fix formatting - fix syntax - use consistent example package name

view details

Sam Brannen

commit sha 33643593e2fb121b486e5e20d515a2b1c8a2bff9

Merge branch '5.2.x'

view details

push time in 4 days

issue commentspring-projects/spring-boot

dbcp2 auto config is missing ability to set connectionProperties

@mdeinum Thanks for trying to help but "as this isn't detected spring isn't capable of setting this value" isn't accurate. As @snicoll described above, the binder can set the property despite it appearing to be write-only from a JavaBeans perspective due to the unconventional getter.

Totally read over that comment, so sorry for the pollution and the setter will be invoked even if it isn't documented (did the same in the past with other DataSource related properties which weren't documented at the time).

jbotuck

comment created time in 5 days

issue commentspring-projects/spring-boot

dbcp2 auto config is missing ability to set connectionProperties

Spring (nor Spring Boot) uses any logic, it is all deferred to plain Java using introspection and the JDK introspection won't detect properties for non matching set/get types. As this isn't detected spring isn't capable of setting this value. This is just how introspection, based on the java beans specification, works. There is nothing Spring nor Spring Boot could do about that.

Adding a property to that json wouldn't be helpful either as that is for documentation purpose and IDE support (AFAIK) and even adding it wouldn't help (nor are all the Hikari or Tomcat JDBC properties in there).

To work around your issue you could register a BeanPostProcessor for a BasicDataSource and use the addConnectionProperty method to set the desired additional properties. Important is to use the postProcessBeforeInitialization else setting the property might be too late.

jbotuck

comment created time in 5 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 4617ba438672a5accb134aa9d8e434863a3a2787

Add OWASP Dependency Check With this commit we introduce the OWASP Dependency Checker as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha ff51d5ab58ab77bd501bf5d1648c4806862aa8af

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 57af064f017b3b8c353f94688c151e9216a4012c

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha a2321f8ad16c826ac4d69d99346f7304197a71b4

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 66481de785226e5cf561ffb56ed3f6dd06bcca72

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha a6d5374f0a635a238ce4fa96aa440c4ca02c640d

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 6 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha b3b9eb518780032f974726e614a5c2c56c11f68a

Add SpotBugs With this commit we introduce SpotBugs as a maven plugin and execute this in a separate parallel step in our CI pipeline.

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 21f73bac5cb044287a945f7deee5cfe200a0e78c

Initial Code Commit

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 5a6b6bc703db5a3e583c34b323ee66d454ba1b12

Initial Code Commit

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 6f55d50618d198a9dbaff0291e8b101649b49ffd

Java14 on cloudfoundry

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha b8ffb9382ab33767210f4d49d41ddc66b61d12aa

Java14 on cloudfoundry

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha c74ca30ac1a9d2c94f33601b800781c2d2dbe52c

Java14 on cloudfoundry

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 9fca3eaa447d0361dfa1e8eea058ecdff97e5c0e

Polish

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha e66ee3ecfebdc0d81eebea7208959d680e1168fb

Polish

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha e547e42a97e3fcf735692fdfef13e1b9ebf3e0c9

Polish

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 0f45512f6f0c5d2c83e4898af9112ba1b2823ce8

Polish

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 1d1d2c2adbabf8834dbc6c1cc31b776fb24728f5

Polish to Java14

view details

push time in 7 days

push eventmdeinum/securing-devops

Marten Deinum

commit sha 5c06dc9e48ce5f458c1ab9b832c0ee97084a2aa3

Update Script

view details

Marten Deinum

commit sha 4b1495477d455e09ad5f14260a7f294e449d276c

.gitignore

view details

Marten Deinum

commit sha 44d6b1ebc535ac9274bd44e24eee36a44bbd99a4

Upgrade to maven 3.6.3

view details

Marten Deinum

commit sha 6aee3d1b620c481705ab68ccf30af6c5a32382d7

Polish to Java14

view details

push time in 7 days

issue commentspring-projects/spring-framework

"getBean(Class<T> requiredType)" api has bug

Chancing the @Order won't help. There is the real object and a class-based proxy of that object. Both are annotated with the same @Ordered (as both are the class). So chancing the @Order value won't help.

Although I would suspect this being a corner-case, it will only happen in the case of one creating your own class based proxies for a bean that has an @Order without one being the @Primary. The solution would be to annotate the proxy with @Primary or don't use the ProxyFactoryBean but use @Aspect to define aspects (as this will replace the bean with a proxy instead of adding a second bean).

AvengerEug

comment created time in 7 days

issue commentspring-projects/spring-boot

Refactor BootstrapRegistry

Should this really rely on the undertow API? I suspect the javadoc should use the InstanceSupplier (which probably got renamed from InstanceFactory somewhere).

philwebb

comment created time in 12 days

CommitCommentEvent

issue commentspring-projects/spring-framework

Provide a GSON JMS/Messaging MessageConverter [SPR-16958]

I assume the question is for @gaxpay and not me. But the initial contribution was to align the supported JSON implementation from the web to messaging (and JMS) as well. Isn't it a bit strange to support something for the web but not for messaging in regards to first-class citizens? Wouldn't that also be a source of problems, especially in regards to auto-configuration as which JSON implementation would be used (GSON for the web and Jackson for messaging?).

Currently, it might make more sense to place them in spring-messaging instead of spring-jms for a broader application. The messaging ones can be adapted to JMS quite easily, the other way around not so much.

spring-issuemaster

comment created time in 12 days

PR opened bootiful-asciidoctor/bootiful-asciidoctor.github.io

Update README.adoc

Fixed indentation of code block for CredentialsProvider`.

+5 -5

0 comment

1 changed file

pr created time in 15 days

push eventmdeinum/bootiful-asciidoctor.github.io

Marten Deinum

commit sha f303ed45370eed8e839498ef891d79b7635362fb

Update README.adoc Fixed indentation of code block for CredentialsProvider`.

view details

push time in 15 days

issue commentspring-projects/spring-framework

Optimize ConfigurationClassPostProcessor#enhanceConfigurationClasses method to shorten startup time

I know what you meant, but adding an else isn't going to solve it. When warn` is enabled and the bean is already in the bean factory it now still would be added. The whole point should be that the bean shouldn't be enhanced regardless of info being enabled or not.

yourbatman

comment created time in 19 days

issue commentspring-projects/spring-framework

Optimize ConfigurationClassPostProcessor#enhanceConfigurationClasses method to shorten startup time

Which would still fail if info logging would be disabled because it is part of the expression.

yourbatman

comment created time in 19 days

push eventmdeinum/spring-boot

Phillip Webb

commit sha c1be5cb5e02870cb0c4c12f2f33e4e4742a843f8

Add limited support for spring.profiles.include Restore support for the `spring.profiles.include` property but only for non-profile specific documents. Closes gh-22944

view details

Phillip Webb

commit sha aa0f20473291e92630e39805f822364b189217a3

Add global optional config data opt-out Support a `spring.config.all-locations-optional` property which can be set to `true` if all config data locations should be considered optional. Closes gh-23097

view details

Phillip Webb

commit sha a2530ad5f173f1825b9c5cb4a8ea1173ecdfba9e

Fix global optional config data opt-out test See gh-23097

view details

push time in a month

push eventmdeinum/spring-boot

Andy Wilkinson

commit sha 28128a9577c9352479c9c970654e3f6bc09ed866

Add support for ChronoUnit.WEEKS when using PeriodUnit Fixes gh-22225

view details

Andy Wilkinson

commit sha 523dd937cdc37516b149ea84797566502ea559c3

Merge branch '2.3.x' Closes gh-22238

view details

Julio Gomez Diaz

commit sha 13d1d2393d4d12f33532a48a3f30864b402c452a

Optionally ignore routing data sources when creating DB health indicators See gh-22222

view details

Andy Wilkinson

commit sha b627918011bc7a7de0122cd911630f664d5a8040

Polish "Optionally ignore routing data sources when creating DB health indicators" See gh-22222

view details

Andy Wilkinson

commit sha fe1919063f56c5041fd5066beb5bcf199617dd07

Merge pull request #22222 from juliojgd * gh-22222: Polish "Optionally ignore routing data sources when creating DB health indicators" Optionally ignore routing data sources when creating DB health indicators Closes gh-22222

view details

XenoAmess

commit sha 75a64bd9017b0c5822bdbf05a364fcdc89e6b09c

Fix unwrapping of captured PrintStream in test support's OutputCapture See gh-22214

view details

Andy Wilkinson

commit sha a0f1424393419a652f92d2f582fc61a5c412eb1c

Polish "Fix unwrapping of captured PrintStream in test support's OutputCapture" See gh-22214

view details

Andy Wilkinson

commit sha ae043285d840665dad1d9fac881d5159c73c7fb6

Merge pull request #22214 from XenoAmess * gh-22214: Polish "Fix unwrapping of captured PrintStream in test support's OutputCapture" Fix unwrapping of captured PrintStream in test support's OutputCapture Closes gh-22214

view details

Andy Wilkinson

commit sha 96e6b748946c24149e351828af64c71d9815beb9

Merge branch '2.2.x' into 2.3.x Closes gh-22243

view details

Andy Wilkinson

commit sha 2a9193f6d9da4a932f5c9ea4c71c76fca8222d6f

Merge branch '2.3.x' Closes gh-22244

view details

XenoAmess

commit sha 66dc24062ff12968abed39a8275f15e00bde63ea

Fix typos in test code See gh-22218

view details

Andy Wilkinson

commit sha 597d6acabc644d48813215331e1977acca7d9e9e

Merge pull request #22218 from XenoAmess * gh-22218: Fix typos in test code Closes gh-22218

view details

XenoAmess

commit sha 90d8480ffe8fe7672a575bba49f8f8c423f25d4d

Use new ArrayList(Collection) rather than new, iterate, and add See gh-22210

view details

Andy Wilkinson

commit sha 54ce2905afe1102283e0368caa0264e6f6fa1088

Merge pull request #22210 from XenoAmess * gh-22210: Use new ArrayList(Collection) rather than new, iterate, and add Closes gh-22210

view details

XenoAmess

commit sha fb70c529d46efc50375f5516f9d007f36b28467c

Use new ArrayList(Collection) rather than new and addAll See gh-22211

view details

Andy Wilkinson

commit sha cd8081f9522b57700e9fe448150f593dbea411b0

Polish "Use new ArrayList(Collection) rather than new and addAll" See gh-22211

view details

Andy Wilkinson

commit sha eb56bb57972ecea2984f85a854b7173123bf3c74

Merge pull request #22211 from XenoAmess * gh-22211: Polish "Use new ArrayList(Collection) rather than new and addAll" Use new ArrayList(Collection) rather than new and addAll Closes gh-22211

view details

XenoAmess

commit sha 623b3ab96ec9480d70bd58f726d401807b974603

Remove redundant close() call from JarResourceManagerTests See gh-22213

view details

Andy Wilkinson

commit sha 3c7f54b97f90c56fb63353cbb7ccf1fbc9887f0e

Polish "Remove redundant close() call from JarResourceManagerTests" See gh-22213

view details

Andy Wilkinson

commit sha e5b5622b1fba46e57364c27e7e22b8ca459953c7

Merge pull request #22213 from XenoAmess * gh-22213: Polish "Remove redundant close() call from JarResourceManagerTests" Remove redundant close() call from JarResourceManagerTests Closes gh-22213

view details

push time in a month

PullRequestReviewEvent

issue commentspring-projects/spring-framework

Webclient OffHeap Memory Leak

@SentryMan does it make a difference if you move the RouterFunction @Bean method to a different class which is annotated with @Configuration or make this class an @Configuration?

@Bean methods in @Component classes are handled differently than from @Configuration classes.

SentryMan

comment created time in a month

issue commentspring-projects/spring-framework

Why PropertyValue needs to extends AttributeAccessor

StackOverflow is the place to ask questions that way GitHub issues can remain for issues and enhancements.

So please open a question there.

yilianhuaixiao

comment created time in a month

issue commentspring-projects/spring-boot

integrate spring actuator in a non spring boot application

StackOverflow is a better place for asking questions.

That being said the Release Notes contain valuable information about the changes in each version including what changed in the actuator part.

mazenaissa

comment created time in a month

issue commentmockito/mockito

RedundantListenerException when updating to mockito 3.2.4 with parallel test execution

Had the same issue when upgrading to 3.5.0 from 2.25.1. Changing the surefire <parallel> to methods fixed it. Leaving the default still makes it fail.

julius-d

comment created time in a month

pull request commentspring-projects/spring-boot

Use no-op lambda as default action for step action

Just noticed 4 test failures on Concourse-ci, however, it is 4 times the same test, appears that tests are either counted or run multiple times?

The test is failing due to the linked Spring Framework issue.

mdeinum

comment created time in 2 months

push eventmdeinum/spring-boot

Marten Deinum

commit sha 2e9934c47c1e4dbbe6fc1be5ed1607419385b338

Use no-op lambda as default action for step action Prior to this commit the StartupStep.end method was being called from the default step action. However when overriding the default step action this might lead to the StartupStep.end method not being called. As in the case of a failure, as that enriches the information being written. This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution. See: gh-22776

view details

push time in 2 months

push eventmdeinum/spring-boot

Marten Deinum

commit sha d9e0c14fa0b32e26d9ab7af90422fff24efe3c88

Use no-op lambda as default action for step action Prior to this commit the StartupStep.end method was being called from the default step action. However when overriding the default step action this might lead to the StartupStep.end method not being called. As in the case of a failure, as that enriches the information being written. This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution. See: gh-22776

view details

push time in 2 months

push eventmdeinum/spring-boot

ksmilek

commit sha 5cb1b4135543d365b32b4b8b5ae8d01df015cc1a

Fix wrong reference in `ReadinessStateHealthIndicator` javadoc See gh-22760

view details

Stephane Nicoll

commit sha 32ed34481a52bf1f4b882cf9123dc7e69cdb5ff4

Merge pull request #22760 from ksmilek-wr * pr/22760: Fix wrong reference in `ReadinessStateHealthIndicator` javadoc Closes gh-22760

view details

Stephane Nicoll

commit sha 13260eab4668feea52ad3d771d6cc01b8ca22e1d

Merge branch '2.3.x' Closes gh-22846

view details

Stephane Nicoll

commit sha b2e581947fd677e68aa14618e9789ea206187124

Upgrade to Reactor Dysprosium-SR11 Closes gh-22841

view details

Stephane Nicoll

commit sha 3535c03695796d6fc52b87c1c20ccd76c2120845

Merge branch '2.3.x'

view details

davidbilge

commit sha 12c419054a43c316beaf012ab6570b632f9ddb09

Propagate the cause that led Reactor"s debug agent to fail Prior to this commit, DebugAgentEnvironmentPostProcessor throws a RuntimeException with a generic error message if its initialization fails. The causing exception is discarded, which makes error analysis unnecessarily difficult. This commit attaches the cause to the newly thrown RuntimeException. See gh-22777

view details

Stephane Nicoll

commit sha 333af3d4e7705314154ba7da48197fc3d8eeb78b

Polish "Propagate the cause that led Reactor"s debug agent to fail" See gh-22777

view details

Stephane Nicoll

commit sha 8836dc96ac9fc4f6e0a206f033d90101a92cc48a

Merge pull request #22777 from davidbilge * pr/22777: Polish "Propagate the cause that led Reactor"s debug agent to fail" Propagate the cause that led Reactor"s debug agent to fail Closes gh-22777

view details

Stephane Nicoll

commit sha f466734801d9954b4264438bb8d8c2c2b6c148ca

Merge branch '2.2.x' into 2.3.x Closes gh-22847

view details

Stephane Nicoll

commit sha dedf09d20feae0e45f3e8159224e770d2ca4cca7

Merge branch '2.3.x' Closes gh-22848

view details

Stephane Nicoll

commit sha 8962d6ca21b39b5274b86ee3e832c3574eefdbfe

Polish

view details

Stephane Nicoll

commit sha 2b578296f990c32af0a0886ef0af03aa76d96b8b

Merge branch '2.2.x' into 2.3.x

view details

Stephane Nicoll

commit sha fcab5d6ce1a4fe16a422bb0e38cdf6e1eecc8876

Merge branch '2.3.x'

view details

dreis2211

commit sha 11df8216add287f066a455c260e1996393b3dd32

Fix some doc anchors See gh-22839

view details

Stephane Nicoll

commit sha 342a98afc66df3322dab73c78714f2e1011a5547

Merge pull request #22839 from dreis2211 * pr/22839: Fix some doc anchors Closes gh-22839

view details

Gabriele Bianchet-David

commit sha 0f9f10f97ec2d439a1f4edcab533f40c17586cdf

Migrate legacy endpoint that have a dash in their id See gh-21615

view details

Stephane Nicoll

commit sha dd9c9fd171faf89c9ca3e19a93bbe0ac72f4dec5

Polish "Migrate legacy endpoint that have a dash in their id" See gh-21615

view details

Stephane Nicoll

commit sha afe99ad64c74514e5983b5b5200b52cc380c2f62

Merge pull request #21615 from Larisho * pr/21615: Polish "Migrate legacy endpoint that have a dash in their id" Migrate legacy endpoint that have a dash in their id Closes gh-21615

view details

Stephane Nicoll

commit sha 980ddcffd0dd6ed8b9fd1df70f7a363bcb80165b

Merge branch '2.2.x' into 2.3.x Closes gh-22849

view details

Stephane Nicoll

commit sha f2a52a87ecd76c54936448983dc11ca5d6fdcdf1

Merge branch '2.3.x' Closes gh-22850

view details

push time in 2 months

pull request commentspring-projects/spring-framework

Call StartupStep.end in finally block

Maybe more events need to be in a try/finally approach due to possible errors being generated? I didn't investigate all other events (as this was the one that was missing).

mdeinum

comment created time in 2 months

pull request commentspring-projects/spring-framework

Call StartupStep.end in finally block

@bclozel this fixes the missing end event detected in #22845.

mdeinum

comment created time in 2 months

pull request commentspring-projects/spring-boot

Use no-op lambda as default action for step action

#25572 fixes the missing call to end. It was the spring.beans.instantiate that wasn't ended when an error occurred.

mdeinum

comment created time in 2 months

PR opened spring-projects/spring-framework

Call StartupStep.end in finally block

Prior to this commit it was possible that a StartupStep was started but never ended. This was the case when an exception occured during bean initializing. To always call the method regardless of the outcome, the call to StartupStep.end has been moved to a finally block.

When an exception occurs the StartupStep is also enriched with the exception class and message for diagnostic purposes.

Related: gh-22776

+7 -3

0 comment

1 changed file

pr created time in 2 months

create barnchmdeinum/spring-framework

branch : prevent-event-from-not-being-registered

created branch time in 2 months

push eventmdeinum/spring-boot

Marten Deinum

commit sha b4ad4758262dcac6d90e15b5bfb836b3f8dabd04

Use no-op lambda as default action for step action Prior to this commit the StartupStep.end method was being called from the default step action. However when overriding the default step action this might lead to the StartupStep.end method not being called. As in the case of a failure, as that enriches the information being written. This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution. See: gh-22776

view details

push time in 2 months

pull request commentspring-projects/spring-boot

Use no-op lambda as default action for step action

@bclozel There appears to be still a missing call to a StartupStep.end() in case of failure during startup, which that is I couldn't determine (might be one in Spring itself.

Another note I couldn't run the tests locally it was hanging on the BuildImageTests (or at least it appeared that way as it didn't progress).

mdeinum

comment created time in 2 months

create barnchmdeinum/spring-boot

branch : gh-22776

created branch time in 2 months

PR opened spring-projects/spring-boot

Use no-op lambda as default action for step action

Prior to this commit the StartupStep.end method was being called from the default step action. However when overriding the default step action this might lead to the StartupStep.end method not being called. As in the case of a failure, as that enriches the information being written.

This commit also introduces a test for the failure case showing that there is a missed call to end with the initial solution.

See: gh-22776

+24 -1

0 comment

2 changed files

pr created time in 2 months

issue commentspring-projects/spring-boot

StartupStep are closed twice in SpringApplicationRunListeners

Although this works, doesn't this break the call from failed which uses a lambda to enrich the tags being written? Wouldn't the better solution be to, by default, pass a no-op lambda, then call end, else it might lead to situation where the end method might not be called.

mdeinum

comment created time in 2 months

issue openedspring-projects/spring-boot

Collecting metrics with Flight Recorder breaks application startup

With the introduction of #22600 I was eager to test this with Flight Recorder based events. For this purpose, I cloned the Petclinic, updated it to Spring Boot 2.4.0-SNAPSHOT and confined it to run using the FlightRecorderApplicationStartup. However, when doing so it results in an exception during startup.

xception in thread "restartedMain" java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49)
Caused by: java.util.NoSuchElementException
	at java.base/java.util.ArrayDeque.getFirst(ArrayDeque.java:403)
	at org.springframework.core.metrics.jfr.FlightRecorderApplicationStartup.start(FlightRecorderApplicationStartup.java:52)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:111)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:106)
	at org.springframework.boot.SpringApplicationRunListeners.environmentPrepared(SpringApplicationRunListeners.java:57)
	at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:356)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:318)
	at org.springframework.samples.petclinic.PetClinicApplication.main(PetClinicApplication.java:39)
	... 5 more

The events that are logged are

  1. spring.boot.application.starting, sequenceId = 0
  2. spring.boot.application.starting (?), sequenceId = 0
  3. spring.boot.application.environment-prepared, sequenceId = 1
  4. spring.boot.application.failed , sequenceId = 2 -> which leads to the error due to the currentSteps Deque is empty.

To reproduce checkout petclinic, upgrade Spring Boot and use the following PetClinicApplication class

@SpringBootApplication(proxyBeanMethods = false)
public class PetClinicApplication {

	public static void main(String[] args) {
		SpringApplication springApplication = new SpringApplicationBuilder()
			.applicationStartup(new FlightRecorderApplicationStartup())
			.sources(PetClinicApplication.class)
			.build();
		springApplication.run(args);
	}
}

The application starts successfully when commenting the .applicationStartup(new FlightRecorderApplicationStartup()) line.

Relates to: #22600

created time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 53d59cb0ee59f72d10e9888e2752af85e541c34c

Fix links in post

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 4b64ccaa94cb9ce98d7220fca2d86ac24447af5a

Fix links in post

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 7cb78ea73cf4aeb63943d41c8fb13cd9bc3ca81d

Fix typos and links

view details

Marten Deinum

commit sha ae652e63bceb96a848457bcd4a7bc53afd4477f9

WIP: Aop with proxies

view details

push time in 2 months

issue commentspring-projects/spring-boot

Spring boot controller class is not taking data more than 2MB from HTML template

The property to use is server.tomcat.max-http-form-post-size so looks like the wrong property being used.

HimanshuChugh2

comment created time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 23d53fb2a9f9427402cb3f49894480e99f0af1e4

Added Github Repo

view details

push time in 2 months

push eventmdeinum/dependency-injection

Marten Deinum

commit sha e4c45201ed854e3f00ed6807c81c7910242bab3a

Initial Commit

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha c16a7cea32fda14a820a6e4b5ae9c8c0c9a735bc

Polish - Dependency Injection Post

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 3f992af0dd933b6cf06e0bbb5b2afa3889742864

Added Dependency Injection Post

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 1311f56ed3b079a89a5bc688d31081e4d818c45d

Polish header.html

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 74abdf795ee4af63216638ad8d3b8a39fd864bf8

Fix image at index

view details

push time in 2 months

issue commentspring-projects/spring-framework

When spring.jackson.date-format and WebMvcConfigurationSupport are used at the same time, it will not take effect

Which is as expected. The usage of WebMvcConfigurationSupport indicates to Spring Boot that you have configured the web part and it will stop applying the auto-configuration. With that it also stops configuring Jackson and thus the use of the spring.jackson.date-format.

Instead of extending the WebMvcConfigurationSupport your class should implement WebMvcConfigurer and override the methods you need.

brucelwl

comment created time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 7b6b82309aafbc90e5adb848569f1519e5aec657

Polish header

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha ccdb80cef22db9c95ae5caf4d57fc8ff92589362

Added last_modified_at to post

view details

push time in 2 months

push eventmdeinum/blog-autowiring-null

Marten Deinum

commit sha 5b26c63b564513ce2a089eb1535ac936d04ba049

Added sample for omitted @Autowired on field

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha ab62d06d7de7759871ad2c8498c4bdfba978ed40

Add support for update date

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 0b4db95f58a173295143647d15882a3fae0b0bc7

Add support for update date

view details

Marten Deinum

commit sha 5f4406881fdf474035c353df909aef7c2595b4c0

Updated post

view details

push time in 2 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha fd4f49022086c2d6e7bb4b5ac3caac1f119a25ac

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 46363f051027efe2018e9051f1bb336a7be133f2

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 3f6d454fdd58d839084c4d8bf1e167b40fb940c1

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha a26c32bc09650204e228ba0324988e371e783a8d

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 6fa4dd0fe9e5821eb520abd5ba91339cbb616278

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 672ef87cd9f7a428fa910803f71fbf8814582c39

Polish index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 6d718b668eaa05c721bad7de2f2a739ff907e827

Align txt and image

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha d408ba49a50dab6f78ed0a1b526aef76a61aff03

Add cover image

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 5be799e01dbde9417b96c76704423fb0986eb19b

Polish

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 5a7088f6511ae0293e6376128a04ce549ae09f2d

Update tags

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha cf568134582f7d84b695b650f8efc208882dec4d

Fix author tag

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 3c4cd99060fe1d979b783103d91d17a8ddf813b0

Add recent posts to index page

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 5b9dbd52980f5656faf2d0c186fa6fbeabe7cbfd

Polish

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha a1e084d2a3ba7923079e439d17abfb35390ae86e

Update index

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha bd4ef8c97be968010dde53bb60a2993fadc3d0d1

Polish

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 0afb08fe22cf518f0354a0c86280b7a1ca7ae318

Update avatar

view details

Marten Deinum

commit sha a5c4560ba5768eba078711a12819fd1d6e5061fa

Added Google Analytics

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 53258631a71ec86f34a7a0e4f55663e65c85c1ee

Create CNAME

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 1b88f0b93bf62a388948de60bdc68bcd330a56dc

Added blog

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha c8bdaaa49297560ec23944059ec0fcc63fe0376a

Update talks page

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 8ac79966fccf854b4833d7a35700f60a8f8464ba

Added pages

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

Marten Deinum

commit sha 7f8b1a6cf723583f78bf097d13a28ea6d04f8685

Update menu

view details

push time in 3 months

push eventmdeinum/mdeinum.github.io

npes87184

commit sha c3ba5629c420720d1db3d3427dc7b17d2b99913c

Fix wrong default layout in README.md (#348)

view details

Chris Kennedy

commit sha f035e4391aca26b14ad8753bff83ba4ad621a56c

Readme.md: fix instructions for dirs with spaces (#351) $PWD needs to be surrounded in quotes so that the commands work when any folder in the path has a space in it.

view details

Marco Blessing

commit sha 3c2e2e5401c7ae554c707230a018a5c0e79be4e0

update nokogiri deps (#352)

view details

Dean Attali

commit sha dcbf2abef37c740eb30834f2a0051720802dbe1d

add guitarlessons to featured users

view details

Marco Blessing

commit sha 284e2fb3f78c91c289d6a01293eaedecbc3103de

update link to personal website (#360)

view details

Dean Attali

commit sha 786849a7c2bf82a0a5c7e413a61dac3a7782cbdb

Update README.md

view details

npes87184

commit sha b9a562da4f2aa6a5107bade7985bd3dc092b832c

add fb comment (#350) * add fb comment * Update README.md for facebook comments * Update _config.yml * Update README.md

view details

Dean Attali

commit sha 0b66bbe5df54f635448969cf0f009cdfb113ed00

Update CHANGELOG.md

view details

Harry Khanna

commit sha 66dcbfda2bc563da727f5a41d0cd9e8ad0691101

Fix code fence css bug when published on gh pages (#366) fixes #365

view details

Dean Attali

commit sha 364604551d151cad89b3fbc662325db2e763ffb1

Update README.md

view details

키위

commit sha 362462948f9b3f2b9484651911d800c848cb4d2b

Notch display (#355) * Notch display * Notch display * Update main.css mistake

view details

Harry Khanna

commit sha dfa273c1a4d9e82e5b6961e7782e43c06b6657f8

Add gtag support for Google Analytics (#374)

view details

Dean Attali

commit sha b52344bde547ff41ecfc84fba8fd2a8888a3f2f0

Update README.md

view details

Dean Attali

commit sha 67a3895758992888bc8e30a5c6740265d0f428aa

update http to https in readme

view details

Dean Attali

commit sha 7412727730fc87bc64e210bb3c48fd0743e3f290

update http to https in footer

view details

mashed-potatoes

commit sha 88aead4504586066c21ba3e4c42dba3b4343d9b8

Use HTTPS as default protocol of site (#414)

view details

Dean Attali

commit sha b6ac9e46ff419b488422fc3a970a77745394acc5

add pull request template to try to discourage wrong PRs

view details

Dean Attali

commit sha a3d736ed19fad94903c7854d5d9490adafad16df

Update pull_request_template.md

view details

Dean Attali

commit sha 3bab586828894ab225eb2b19e84be093eae4ce2e

Create issue_template.md

view details

jpvicari

commit sha b535468618343a8af15c288ef676b5a32991c0f7

Moved Google Analytics to the Head (#419) * Moved Google Analytics to the Head * Update CHANGELOG

view details

push time in 3 months

push eventmdeinum/spring-batch-excel

Marten Deinum

commit sha 18ac288605f312e34e1aa961a46d0164c74cf580

Upgrade to Spring Batch 4.2.4 Fixes: #21

view details

push time in 3 months

more