@Trott The only one is that I didn't test this explicitly on i.e. node-auto-test as I didn't yet have to to do so, but this should 'just work' :smile: so we can probably land it and fix issues later, it shouldn't cause any major issues if it fails (same goes for https://github.com/nodejs/node/pull/35206)

@ronag no it doesn't, it will only autosquash if used with --fixup git command see https://github.com/nodejs/node/pull/34969#issuecomment-683340555 for more information.

I've implemented https://github.com/nodejs/node-core-utils/pull/490 but it is not yet integrated into this repo. (also - https://github.com/nodejs/node/issues/34770)

No problem, thanks for opening a PR =).

  [`--unhandled-rejections`][] flag set to `strict` or `throw` and
  an unhandled rejection.

New speed output:

$ metatests speed benchmarks/cases/setVsArray.js --target size5.match
...
Speed test
searchSet      792317500ns   min          12621202.98 ops/s ±1.64%
searchArray    824139121ns +4.02%         12133873.69 ops/s ±1.19%

Old speed output

$ metatests speed benchmarks/cases/setVsArray.js --target size5.match
...
Speed test
searchSet......................726039154.......min
searchArray...................1351735530...+86.18%

New measure output (the old output is still available with --verbose)

$ metatests measure benchmarks/example/create.js
defineObject   32972630.18 ops/s ±3.85%
mixinObject    34238572.84 ops/s ±1.72%

Old measure output

$ metatests measure benchmarks/example/create.js
defineObject    n=1000000:              27190838ns, 36777093.81ops/s
defineObject    n=1000000:              30433772ns, 32858233.94ops/s
defineObject    n=1000000:              30466257ns, 32823198.47ops/s
defineObject    n=1000000:              30604932ns, 32674472.21ops/s
defineObject    n=1000000:              31591362ns, 31654222.44ops/s
defineObject    n=1000000:              30758265ns, 32511586.72ops/s
defineObject    n=1000000:              30378491ns, 32918027.43ops/s
defineObject    n=1000000:              29996100ns, 33337667.23ops/s
defineObject    n=1000000:              30555639ns, 32727183.35ops/s
defineObject    n=1000000:              31740639ns, 31505351.86ops/s
defineObject    n=1000000:              31576109ns, 31669513.18ops/s
defineObject    n=1000000:              30549053ns, 32734238.93ops/s
defineObject    n=1000000:              29693945ns, 33676899.45ops/s
defineObject    n=1000000:              30464988ns, 32824565.69ops/s
defineObject    n=1000000:              30087619ns, 33236262.4ops/s
defineObject    n=1000000:              31392956ns, 31854279.67ops/s
defineObject    n=1000000:              29608957ns, 33773563.86ops/s
defineObject    n=1000000:              40608643ns, 24625299.59ops/s
defineObject    n=1000000:              40201016ns, 24874993.21ops/s
defineObject    n=1000000:              33822013ns, 29566542.95ops/s
mixinObject     n=1000000:              29733543ns, 33632049.84ops/s
mixinObject     n=1000000:              33056377ns, 30251349.08ops/s
mixinObject     n=1000000:              35438258ns, 28218091.31ops/s
mixinObject     n=1000000:              32281742ns, 30977262.63ops/s
mixinObject     n=1000000:              33958784ns, 29447461.96ops/s
mixinObject     n=1000000:              32509604ns, 30760140.91ops/s
mixinObject     n=1000000:              31235763ns, 32014585.33ops/s
mixinObject     n=1000000:              31415716ns, 31831201.94ops/s
mixinObject     n=1000000:              31566123ns, 31679531.88ops/s
mixinObject     n=1000000:              31124214ns, 32129325.42ops/s
mixinObject     n=1000000:              29919812ns, 33422669.9ops/s
mixinObject     n=1000000:              30891851ns, 32370996.48ops/s
mixinObject     n=1000000:              35654862ns, 28046665.84ops/s
mixinObject     n=1000000:              32572663ns, 30700590.86ops/s
mixinObject     n=1000000:              34478141ns, 29003883.94ops/s
mixinObject     n=1000000:              33451602ns, 29893934.53ops/s
mixinObject     n=1000000:              32389873ns, 30873847.51ops/s
mixinObject     n=1000000:              32102164ns, 31150547.98ops/s
mixinObject     n=1000000:              31317254ns, 31931279.8ops/s
mixinObject     n=1000000:              31230215ns, 32020272.68ops/s

ping @fox1t @mcollina @Ethan-Arrowood I think this can be landed. =)

ping @fox1t @mcollina @Ethan-Arrowood I think this can be landed. =)

@ruyadorno these changes were applied on top of other changes related to AbortController (https://github.com/nodejs/node/pull/34911). I think it shouldn't be backported since AbortController is semver-major.

Oh, that's right, it should be done before the push :+1:

I agree, but since this is bash and everything is kind of 'messy' (imo) I'd prefer to have it right beside the place of usage if you don't mind.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x] tests and/or benchmarks are included
• [x] documentation is changed or added
• [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

Anyone knows of a better way than git merge-base?

Refs: https://github.com/nodejs/node/issues/34770#issuecomment-693201987

/cc @mmarchini @targos

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [ ] tests and/or benchmarks are included
• [ ] documentation is changed or added
• [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. --> Refs: https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables Refs: https://github.com/nodejs/node/issues/34770#issuecomment-691290938

Not tested yet. I guess I should land this to node-auto-test to verify that it works? /cc @mmarchini

Oh, good catch. Do we have a make command to run all tests?

I think this can be closed with https://github.com/fastify/fastify/pull/2554 being landed.

ping @addaleax @nodejs/documentation, wdyt https://github.com/nodejs/node/pull/35000#issuecomment-684518217?

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

• Version: v14.2.0 (npm v6.14.4) and node v13.14.0 (npm v6.14.4)
• Platform: macOS
• Subsystem:

What steps will reproduce the bug?

• npm install firebase
• create a file index.mjs to import it using import * as firebase from 'firebase/app'
• node index.mjs

How often does it reproduce? Is there a required condition?

Consistently

What is the expected behavior?

Load firebase/app correctly instead of throwing ERR_MODULE_NOT_FOUND

<!-- If possible please provide textual output instead of screenshots. -->

What do you see instead?

feiyangc-macbookpro:node feiyangc$ node index.mjs 
internal/modules/run_main.js:54
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/feiyangc/Projects/test/node/node_modules/firebase/app' imported from /Users/feiyangc/Projects/test/node/index.mjs
Did you mean to import firebase/app/dist/index.cjs.js?
    at finalizeResolution (internal/modules/esm/resolve.js:277:11)
    at packageResolve (internal/modules/esm/resolve.js:608:14)
    at moduleResolve (internal/modules/esm/resolve.js:655:14)
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:748:11)
    at Loader.resolve (internal/modules/esm/loader.js:97:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:243:28)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:42:40)
    at link (internal/modules/esm/module_job.js:41:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

<!-- If possible please provide textual output instead of screenshots. -->

Additional information

• import * as firebase from 'firebase/app' works fine in Node 10 with --experimental-modules.

• require('firebase/app') works correctly in all versions of Node.

About the firebase package structure

firebase/app is a subfolder in the firebase package. It has its own package.json (firebase/app/package.json) which defines a main field that points to firebase/app/dist/index.cjs.js. The structure looks like:

node_modules
-- firebase
  -- app
     -- dist
       -- index.cjs.js
       -- package.json // the main field points to ./dist/index.cjs.js
  -- package.json

<!-- Tell us anything else you think we should know. -->

I think this test is okay, the issue is that it (the fact that these properties are exported from fastify itself and not just from plugin.ts) was not tested at all before.

Fixes: https://github.com/metarhia/metadoc/issues/104

/cc @SemenchenkoVitaliy

Having a class name in prioritizedEntries will result in class declaration being properly prioritized but the class methods, properties etc will not be handled resulting in 'torn' declarations in the output file.

Done https://github.com/fastify/fastify/pull/2555.

These were accidentally removed in https://github.com/fastify/fastify/pull/2554

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md

By making a contribution to this project, I certify that:

• (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

• (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

• (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

• (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

Checklist

• [x] run npm run test and npm run benchmark
• [x] tests and/or benchmarks are included
• [x] documentation is changed or added
• [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Also adds tests to make sure these Types are exported.

Oh, now I see the issue. I don't know how these got removed. I'll put a PR to get them back

I'm not sure I understand the message (it suggests to import the same thing), but could you verify that you are using most recent fastify-plugin version? (it should be fixed in 2.0.1 ->https://github.com/fastify/fastify-plugin/commit/d81e6a6b32effc6607e2e7b58c4365d1ec60dc61)

Depends on https://github.com/metarhia/metadoc/pull/105

Fixes: https://github.com/metarhia/metadoc/issues/104

/cc @SemenchenkoVitaliy

Having a class name in prioritizedEntries will result in class declaration being properly prioritized but the class methods, properties etc will not be handled resulting in 'torn' declarations in the output file.

Refs: https://github.com/fastify/help/issues/251

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md

By making a contribution to this project, I certify that:

• (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

• (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

• (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

• (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

Checklist

• [x] run npm run test and npm run benchmark
• [x] tests and/or benchmarks are included
• [x] documentation is changed or added
• [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

IIUC why not use clear loop condition instead?

  while (pos < argv.length) {
    const arg = argv[pos];
    ...
  }
  return result;

Nit:

* `argv` {string[]} (Optional) Array of argument strings; defaults

since this argument cannot be an object itself, it is only an object if it is options. I don't think that we include 'replacement/nested/optional' types in our docs in such cases. IMO it will only confuse the reader as it removes clear type-boundary between optional arguments.

 * @param {string[]|string} [options.multiOptions] - This argument (or arguments)

And also above to better refer to the other argument?

Nit: perhaps:

### Additional considerations

:thinking: Anyone knows why but these PRs failed to apply patches: https://github.com/nodejs/node/pull/34997#issuecomment-687832961 https://github.com/nodejs/node/pull/34682#issuecomment-691138681

even though locally it applied successfully with manual git node land. Is three-way-merge somehow disabled for commit-queue?

Refs: https://github.com/nodejs/node/pull/34682/#discussion_r475241035

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x] tests and/or benchmarks are included
• [ ] documentation is changed or added ?
• [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. --> /cc @BridgeAR @jasnell @Trott

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x] tests and/or benchmarks are included
• [x] documentation is changed or added
• [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

This simplifies logic related to EventTarget handling and shortens the code.

/cc @nodejs/events @jasnell

Landed in b1831fed3a28

This will be a start to generalize all argument validation errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more specific errors. The OPT errors didn't bring much to the errors as it's just another variant of ARG error which is sometimes more confusing (some of our code used OPT errors to denote just argument validation errors presumably because of similarity of OPT to 'option' and not 'options-object') and they don't specify the name of the options object where the invalid value is located. Much better approach would be to just specify path to the invalid value in the name of the value as it is done in this PR (i.e. 'options.format', 'options.publicKey.type' etc)

Also since this decreases a variety of errors we have it'd be easier to reuse validation code across the codebase.

Refs: https://github.com/nodejs/node/pull/31251 Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009 Signed-off-by: Denys Otrishko [email protected]

Since this is a semver-major anyway I'm also considering integrating ERR_OUT_OF_RANGE into ERR_INVALID_ARG_VALUE.RangeError as I don't see much benefit of it having a separate error code since everything will be stated in the message anyways, wdyt?

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

• [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
• [x] tests and/or benchmarks are included
• [x] documentation is changed or added
• [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. --> /cc @nodejs/crypto @nodejs/buffer @nodejs/http2 as most affected systems /cc @jasnell @tniessen

Landed in c66e6471e780

ping @Trott @jasnell @BridgeAR @mcollina this needs another review before it lands since there were changes to errors.md file to include version history in yaml (latest fixup!) as noted by @Trott.

  of the provided `buffer` must be less or equal to `2**31 - 1`.

  must be less or equal to `2**31 - 1`.

  must be less or equal to `2**31 - 1`.

Ditto

  size of the provided `buffer` must be less or equal to `2**31 - 1`.