Thank you for this PR.

Also updates puppeteer to fix builds with node v16.

The last build passed in Node 16 using Puppeteer 9. Could you elaborate on what exactly is breaking here? Updating puppeteer in Mochify can introduce very subtle breakages from time to time...

watchify v3 has indirect security vulnerabilities. watchify v4 resolves those vulnerabilities and has minimal incompatibilities.

Watchify changelog

There is playwright of Microsoft. They also offer their own test runner for Node. Folio, "a highly customizable test framework", available in preview. This is going to be a very competitive player in test frameworks.

Quite often before hook contains business-critical setup that is needed for all the tests (it blocks). From the retry logic, it is understood that retry works for only it blocks and corresponding beforeEach and afterEach hooks. Looking for a workaround or guidance for retrying the full suite/spec if before hook fails.

@giltayar do you have any suggestions how to start with this one? We also have some funds available we could invest.

In the case of an illegal format format, null is now returned which is handled well by the rest of the implementation. However, using the raw value or returning a 4.15 are also still on the table as options.

Any news on this? This is closed, but it is still a very valuable feature.

After thinking about this, returning the numeric value in this very case actually makes a lot of sense to ensure that all messages can be handled. However, maybe returning null when the content-format is too big could be an option?

I now realized that the new error message is coming from the assert in line 346 that is (obviously) undefined. I am wondering if requests like this should rather be handled normally or if a 4.15 ("unsupported content-format") should be returned.

After investigating the problem a bit more, I now think it would be better to add a try-catch-block to agent.js as this is the place where the error causes the crash or the packetToMessage function. The change originally proposed in this PR has too many unintended side-effects imho.

I am wondering if it makes sense to return the value here or if it would be better to return null since a value that is longer than two bytes is prohibited by the RFC. Using null would probably make the handling of errors easier as well I assume?

This line prevented the tests from succeeding. However, the transmitted payload (assert is not defined) is very weird and indicates that there is something wrong with the new solution.

Pull Request Test Coverage Report for Build 931451290

• 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
• 66 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-2.2%) to 89.545%

Totals
Change from base Build 676119756:	-2.2%
Covered Lines:	1111
Relevant Lines:	1205

💛 - Coveralls

Pull Request Test Coverage Report for Build 931195688

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.1%) to 89.551%

Totals
Change from base Build 928044144:	-0.1%
Covered Lines:	1112
Relevant Lines:	1206

💛 - Coveralls

This PR updates the README in accordance to the newly added feature for type 1 block-wise transfer. I created a PR for this change as I wanted to be sure that this actually going to be a new minor release.

The very last commit actually changes the default token length to 8 bytes by adding random bytes to the end of the 4-byte token, so first 4 bytes are sequential as before, but the last 4 are pseudorandom. That pretty much tests the whole suite against this new behaviour.

Great, I think that is a very good addition in terms of security! As all of the tests are passing and coverage stayed roughly the same I think this should be ready to be merged :)

@Apollon77 Do you want to hit the button? Or do you see more points that should be addressed?

Pull Request Test Coverage Report for Build 930180255

• 48 of 52 (92.31%) changed or added relevant lines in 3 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.2%) to 89.485%

Totals
Change from base Build 928044144:	-0.2%
Covered Lines:	1133
Relevant Lines:	1230

💛 - Coveralls

Bumps glob-parent from 5.1.1 to 5.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/releases">glob-parent's releases</a>.</em></p> <blockquote> <h2>v5.1.2</h2> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md">glob-parent's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">5.1.2</a> (2021-03-06)</h3> <h3>Bug Fixes</h3> <ul> <li>eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>) (<a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366">f923116</a>)</li> </ul> <h2><a href="https://www.github.com/gulpjs/glob-parent/compare/v5.1.2...v6.0.0">6.0.0</a> (2021-05-03)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">#34</a>)</li> <li>upgrade scaffold, dropping node <10 support</li> </ul> <h3>Bug Fixes</h3> <ul> <li>Correct mishandled escaped path separators (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/34">#34</a>) (<a href="https://www.github.com/gulpjs/glob-parent/commit/32f6d52663b7addac38d0dff570d8127edf03f47">32f6d52</a>), closes <a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/32">#32</a></li> </ul> <h3>Miscellaneous Chores</h3> <ul> <li>upgrade scaffold, dropping node <10 support (<a href="https://www.github.com/gulpjs/glob-parent/commit/e83d0c5a411947cf69eb58f36349db80439c606f">e83d0c5</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/gulpjs/glob-parent/commit/eb2c439de448c779b450472e591a2bc9e37e9668"><code>eb2c439</code></a> chore: update changelog</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/12bcb6c45c942e2d05fc1e6ff5402e72555b54b6"><code>12bcb6c</code></a> chore: release 5.1.2</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/f9231168b0041fea3f8f954b3cceb56269fc6366"><code>f923116</code></a> fix: eliminate ReDoS (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/36">#36</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/0b014a7962789b2d8f2cf0b6311f40667aecd62c"><code>0b014a7</code></a> chore: add JSDoc returns information (<a href="https://github-redirect.dependabot.com/gulpjs/glob-parent/issues/33">#33</a>)</li> <li><a href="https://github.com/gulpjs/glob-parent/commit/2b24ebd64b2a045aa167c825376335555da139fd"><code>2b24ebd</code></a> chore: generate initial changelog</li> <li>See full diff in <a href="https://github.com/gulpjs/glob-parent/compare/v5.1.1...v5.1.2">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>