profile
viewpoint
Dave Lee kastiglione Apple Menlo Park, CA

jspahrsummers/libextobjc 4462

A Cocoa library to extend the Objective-C programming language.

ashfurrow/FunctionalReactivePixels 710

A demonstration of how to use FRP with ReactiveCocoa in an iOS context using the 500px API.

jspahrsummers/enemy-of-the-state 209

My talk explaining what state is and why it's so harmful

dduan/tre 132

Tree command, improved.

jspahrsummers/adt 104

Algebraic data types for Python

jspahrsummers/the-future-of-reactivecocoa 75

Presentation for RACDC 2014

dduan/DrString 74

DrString finds issues in your Swift docstrings and fixes them for you.

jspahrsummers/Clairvoyant 61

Append-only key-value database

jspahrsummers/library-oriented-programming 58

Talk about the how/why of separating concerns into libraries

kastiglione/bazel-xcode-demo-swift-driver 41

Bazel+Xcode Demo of apple/swift-driver: Swift compiler driver reimplementation in Swift

pull request commentapple/llvm-project

Add override to fix -Winconsistent-missing-override warning.

thanks

jimingham

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/llvm-project

TypeSystem: Avoid the ISO646 spelling of the logical operators

 template <> struct less<swift::ClusteredBitVector> {     for (; iL >= 0 && iR >= 0; --iL, --iR) {       bool bL = lhs[iL];       bool bR = rhs[iR];-      if (bL and not bR)

if it were my choice, we should switch everything to use not instead of !

compnerd

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):+def _get_bool_config(key):     config = lldb.SBDebugger.GetBuildConfiguration()     value_node = config.GetValueForKey(key)     fail_value = True # More likely to notice if something goes wrong-    have = value_node.GetValueForKey("value").GetBooleanValue(fail_value)+    return value_node.GetValueForKey("value").GetBooleanValue(fail_value)++def _get_bool_connfig_skip_if_decorator(key):

it didn't work for me, I only noticed this because of python exceptions

Teemperor

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):+def _get_bool_config(key):     config = lldb.SBDebugger.GetBuildConfiguration()     value_node = config.GetValueForKey(key)     fail_value = True # More likely to notice if something goes wrong-    have = value_node.GetValueForKey("value").GetBooleanValue(fail_value)+    return value_node.GetValueForKey("value").GetBooleanValue(fail_value)++def _get_bool_connfig_skip_if_decorator(key):
def _get_bool_config_skip_if_decorator(key):
Teemperor

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch apple/llvm-project

delete branch : lldb-Fix-few-easily-correctable-warnings

delete time in 4 days

Pull request review commentapple/llvm-project

TypeSystem: silence some errors identified by MSVC

 class SwiftDWARFImporterDelegate : public swift::DWARFImporterDelegate {       // described in DWARF.       return true;     }+    return false;

so msvc doesn't consider the switch exhaustive? should this be an llvm_unreachable?

compnerd

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch apple/llvm-project

delete branch : cmake-Centralize-LLVM_ENABLE_WARNINGS-option

delete time in 6 days

push eventapple/llvm-project

Dave Lee

commit sha e184b47a679ecccedc4bad7acc42db1c28621765

[cmake] Centralize LLVM_ENABLE_WARNINGS option Configure default value of `LLVM_ENABLE_WARNINGS` in `HandleLLVMOptions.cmake`. `LLVM_ENABLE_WARNINGS` is documented as ON by default, but `HandleLLVMOptions` assumes the default has been set somewhere else. If it has not been explicitly set, then `HandleLLVMOptions` implicitly uses OFF as a default. This removes the various `option()` declarations in favor of a single declaration in `HandleLLVMOptions`. This will prevent the unwanted use of `-w` that is mentioned in a couple of the comments. Reviewed By: DavidTruby, #libunwind, JDevlieghere, compnerd Differential Revision: https://reviews.llvm.org/D87243 (cherry picked from commit b36bdfe5ca0c2b863248f327b03d41516b38dc11)

view details

Dave Lee

commit sha e509ca5ee572b29ac773b3524cca30e8ba6762b3

Merge pull request #1991 from apple/cmake-Centralize-LLVM_ENABLE_WARNINGS-option [cmake] Centralize LLVM_ENABLE_WARNINGS option

view details

push time in 6 days

PR merged apple/llvm-project

Reviewers
[cmake] Centralize LLVM_ENABLE_WARNINGS option

Configure default value of LLVM_ENABLE_WARNINGS in HandleLLVMOptions.cmake.

LLVM_ENABLE_WARNINGS is documented as ON by default, but HandleLLVMOptions assumes the default has been set somewhere else. If it has not been explicitly set, then HandleLLVMOptions implicitly uses OFF as a default.

This removes the various option() declarations in favor of a single declaration in HandleLLVMOptions. This will prevent the unwanted use of -w that is mentioned in a couple of the comments.

Reviewed By: DavidTruby, #libunwind, JDevlieghere, compnerd

Differential Revision: https://reviews.llvm.org/D87243

(cherry picked from commit b36bdfe5ca0c2b863248f327b03d41516b38dc11)

+4 -9

2 comments

7 changed files

kastiglione

pr closed time in 6 days

delete branch apple/llvm-project

delete branch : cmake-Limit-missing-external-lit-warning-to-be-shown-once

delete time in 6 days

push eventapple/llvm-project

Dave Lee

commit sha 0e87f350daf6b07d30c10db9b83ab22e4182bc64

[cmake] Limit missing external lit warning to be shown once When using a custom `LLVM_EXTERNAL_LIT`, it's possible the file may not exist at the CMake is generating the build. One example is LLDB standalone builds. When the external lit doesn't exist, a warning message is emitted, but the warning is printed once for every single lit target. This produces many redundant warnings. This changes the warning to only be emitted once, controlled by a CACHE variable. Other options are: 1. remove the warning 2. have callers pass an option to silence the warning if desired See https://reviews.llvm.org/D76945 for some context. Differential Revision: https://reviews.llvm.org/D89356 (cherry picked from commit 41f946a6d2a4c1b36ee0a63f615a1aa6edf37cab)

view details

Dave Lee

commit sha 9298450d846d2d674489732ac02985b1555380fb

Merge pull request #1984 from apple/cmake-Limit-missing-external-lit-warning-to-be-shown-once [cmake] Limit missing external lit warning to be shown once

view details

push time in 6 days

PR merged apple/llvm-project

[cmake] Limit missing external lit warning to be shown once

When using a custom LLVM_EXTERNAL_LIT, it's possible the file may not exist at the CMake is generating the build. One example is LLDB standalone builds. When the external lit doesn't exist, a warning message is emitted, but the warning is printed once for every single lit target. This produces many redundant warnings.

This changes the warning to only be emitted once, controlled by a CACHE variable.

Other options are:

  1. remove the warning
  2. have callers pass an option to silence the warning if desired

See https://reviews.llvm.org/D76945 for some context.

Differential Revision: https://reviews.llvm.org/D89356

(cherry picked from commit 41f946a6d2a4c1b36ee0a63f615a1aa6edf37cab)

+2 -1

1 comment

1 changed file

kastiglione

pr closed time in 6 days

delete branch apple/llvm-project

delete branch : lldb-Fix-few-easily-correctable-warnings-next

delete time in 6 days

push eventapple/llvm-project

Dave Lee

commit sha 4ded62352746dfc681b6799fce33b949a11ef7d4

[lldb] Fix few easily correctable warnings (cherry picked from commit 590ecce905fc15136c3d458793224a1ce44ecc0f)

view details

Dave Lee

commit sha 54125617448099682950ae21fe8b9d57f9b4b895

Merge pull request #1992 from apple/lldb-Fix-few-easily-correctable-warnings-next [lldb] Fix few easily correctable warnings

view details

push time in 6 days

PR opened apple/llvm-project

[lldb] Fix few easily correctable warnings

(cherry picked from #1990)

+3 -11

0 comment

2 changed files

pr created time in 6 days

push eventapple/llvm-project

Dave Lee

commit sha 590ecce905fc15136c3d458793224a1ce44ecc0f

[lldb] Fix few easily correctable warnings

view details

Dave Lee

commit sha 9c80a3d89d40a7cb2afdf023781f805a1538fcea

Merge pull request #1990 from apple/lldb-Fix-few-easily-correctable-warnings [lldb] Fix few easily correctable warnings

view details

push time in 6 days

push eventllvm/llvm-project

Dave Lee

commit sha ae4fe1984f0e47259b5e476a73749185cc24e1ac

[lldb] Enable cmake policy CMP0077 for option() In lldb, explicitly set the "option() honors normal variables" CMake policy. This applies for standalone lldb builds and matches what llvm, clang, etc do. This prevents potentially unwanted clearing of variables like `LLVM_ENABLE_WARNINGS`, and also prevents unnecessary build warnings. See: https://cmake.org/cmake/help/latest/policy/CMP0077.html Differential Revision: https://reviews.llvm.org/D89614

view details

push time in 7 days

push eventllvm/llvm-project

Dave Lee

commit sha 5564ee495bddeb12d3a9a617631cfa478cf67959

Revert "Register TargetCXXABI.def as a textual header" Unbreak module builds. TargetCXXABI.def has been removed in a revert: 79829a47040512fe54001db839ac59146ca55aec. This reverts commit 0ff9116b36781d6fa61c25841edd53dc8f366bec.

view details

push time in 7 days

pull request commentapple/swift

Add check for Xcode version compatibility

@swift-ci smoke test

keith

comment created time in 7 days

pull request commentapple/llvm-project

[lldb] Fix few easily correctable warnings

@swift-ci test macOS Platform

kastiglione

comment created time in 7 days

pull request commentapple/llvm-project

[lldb] Fix few easily correctable warnings

@swift-ci test

kastiglione

comment created time in 7 days

pull request commentapple/llvm-project

[cmake] Centralize LLVM_ENABLE_WARNINGS option

@swift-ci test macOS Platform

kastiglione

comment created time in 7 days

pull request commentapple/llvm-project

[lldb] Fix few easily correctable warnings

This PR is in prep for https://github.com/apple/llvm-project/pull/1991

kastiglione

comment created time in 7 days

pull request commentapple/llvm-project

[cmake] Centralize LLVM_ENABLE_WARNINGS option

This will re-enable warnings when building swift-lldb.

kastiglione

comment created time in 7 days

PR opened apple/llvm-project

Reviewers
[cmake] Centralize LLVM_ENABLE_WARNINGS option

Configure default value of LLVM_ENABLE_WARNINGS in HandleLLVMOptions.cmake.

LLVM_ENABLE_WARNINGS is documented as ON by default, but HandleLLVMOptions assumes the default has been set somewhere else. If it has not been explicitly set, then HandleLLVMOptions implicitly uses OFF as a default.

This removes the various option() declarations in favor of a single declaration in HandleLLVMOptions. This will prevent the unwanted use of -w that is mentioned in a couple of the comments.

Reviewed By: DavidTruby, #libunwind, JDevlieghere, compnerd

Differential Revision: https://reviews.llvm.org/D87243

(cherry picked from commit b36bdfe5ca0c2b863248f327b03d41516b38dc11)

+4 -9

0 comment

7 changed files

pr created time in 7 days

Pull request review commentapple/llvm-project

[lldb] Fix few easily correctable warnings

 bool SwiftASTContext::CacheUserImports(SwiftASTContext &swift_ast_context,                                        Status &error) {   llvm::SmallString<1> m_description; -  swift::ModuleDecl::ImportFilter import_filter {

@medismailben I believe this is left over from your recent PR.

kastiglione

comment created time in 7 days

PullRequestReviewEvent

create barnchapple/llvm-project

branch : lldb-Fix-few-easily-correctable-warnings

created branch time in 7 days

pull request commentapple/swift

Add check for Xcode version compatibility

Whether we include other versions can be decided in future PRs, probably.

keith

comment created time in 7 days

pull request commentapple/swift

Add check for Xcode version compatibility

With that, @Keith the list can be reduced to the one version.

keith

comment created time in 7 days

PullRequestReviewEvent

pull request commentapple/llvm-project

[cmake] Limit missing external lit warning to be shown once

@swift-ci test

kastiglione

comment created time in 7 days

PR opened apple/llvm-project

Reviewers
[cmake] Limit missing external lit warning to be shown once

When using a custom LLVM_EXTERNAL_LIT, it's possible the file may not exist at the CMake is generating the build. One example is LLDB standalone builds. When the external lit doesn't exist, a warning message is emitted, but the warning is printed once for every single lit target. This produces many redundant warnings.

This changes the warning to only be emitted once, controlled by a CACHE variable.

Other options are:

  1. remove the warning
  2. have callers pass an option to silence the warning if desired

See https://reviews.llvm.org/D76945 for some context.

Differential Revision: https://reviews.llvm.org/D89356

(cherry picked from commit 41f946a6d2a4c1b36ee0a63f615a1aa6edf37cab)

+2 -1

0 comment

1 changed file

pr created time in 7 days

pull request commentapple/swift

Add check for Xcode version compatibility

Note that CI has been updated to Xcode 12.2 Beta 3.

@shahmishal @varungandhi-apple do either of you know in the past when the documentation was updated to new minimum versions? Does the documentated minimum Xcode version update in lock step with CI updates?

keith

comment created time in 7 days

push eventllvm/llvm-project

Dave Lee

commit sha f16cecf3752a7c168293934d2ba6472a6b405694

[lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() Implement `GetName` for `ObjCExceptionThrowFrameRecognizer`. Otherwise, `frame recognizer list` shows "(internal)" for the name. Differential Revision: https://reviews.llvm.org/D89589

view details

push time in 7 days

Pull request review commentapple/llvm-project

[lldb/Swift] Fix import attributes handing in following expression evaluation

+public struct Bar {+    public init(Baz: Int) { self.Baz = Baz }

not worth changing, but fwiw Swift uses camelCase for parameter/property/variable names.

medismailben

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/swift

Add check for Xcode version compatibility

+1 for me, @shahmishal and @varungandhi-apple what do you say?

keith

comment created time in 8 days

push eventapple/swift

Keith Smiley

commit sha ae0c380f1b0f37e11b111a06634dd4c64e67b96c

Improve -*prefix-map help text Before: ``` -coverage-prefix-map <value> -debug-prefix-map <value> ``` After: ``` -coverage-prefix-map <prefix=replacement> -debug-prefix-map <prefix=replacement> ```

view details

Dave Lee

commit sha d35cb3cc4865221aebbc8f5abda3b54159798b7f

Merge pull request #34228 from keith/ks/improve--prefix-map-help-text Improve `-*prefix-map` help text

view details

push time in 8 days

PR merged apple/swift

Improve `-*prefix-map` help text

Before:

-coverage-prefix-map <value>
-debug-prefix-map <value>

After:

-coverage-prefix-map <prefix=replacement>
-debug-prefix-map <prefix=replacement>
+2 -2

4 comments

1 changed file

keith

pr closed time in 8 days

push eventapple/swift

Dave Lee

commit sha 52bbe11161f908d4c58cbdd2a423c68b9688b191

[build] Remove dash-dash from build-presets.ini (NFC)

view details

Dave Lee

commit sha b8e726a386993851d5fc952910c8b73e31dd31f1

Merge pull request #34300 from apple/build-Remove-dash-dash-from-build-presets.ini-NFC [build] Remove dash-dash from build-presets.ini (NFC)

view details

push time in 8 days

delete branch apple/swift

delete branch : build-Remove-dash-dash-from-build-presets.ini-NFC

delete time in 8 days

PR merged apple/swift

[build] Remove dash-dash from build-presets.ini (NFC)

Remove the many dash-dash lines in build-presets.ini, their handling is a no-op:

https://github.com/apple/swift/blob/2c3a6e06f4edc2ed64a638e30379bbcc83479768/utils/build_swift/build_swift/presets.py#L256-L258

+0 -128

1 comment

1 changed file

kastiglione

pr closed time in 8 days

PullRequestReviewEvent

pull request commentapple/swift

Improve `-*prefix-map` help text

@swift-ci smoke test Linux Platform

keith

comment created time in 8 days

push eventllvm/llvm-project

Dave Lee

commit sha 4cb4db11ee1323c5d4bf66d21deb046970f4e516

Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex" This broke the GreenDragon build, due to the following error while running TestImportBuiltinFileID: ``` Ignored/unknown shouldn't get here UNREACHABLE executed at tools/clang/include/clang/Sema/AttrSpellingListIndex.inc:13! ``` See http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24213/ This reverts commit 73c6beb2f7053fe8b5150072c2b5cd930de38a22. This reverts https://reviews.llvm.org/D89318

view details

push time in 9 days

delete branch apple/llvm-project

delete branch : lldb-Remove-unused-version-defines-next

delete time in 9 days

delete branch apple/llvm-project

delete branch : lldb-Remove-unused-version-defines

delete time in 9 days

push eventapple/llvm-project

Dave Lee

commit sha 83253b29d64b6b5a95da0c0eea2403d9d53a448a

[lldb] Remove unused version defines

view details

Dave Lee

commit sha 0387ef915497ac552c45aa21f557a5ac27c4ad8f

oops, restore upstream block of code

view details

Dave Lee

commit sha 8a33482be9af7561aed05d566f4f28e3f1fbb2d5

fix indentation

view details

Dave Lee

commit sha dee9c924420f00acb08fd2c47acef2fe6d156346

Merge pull request #1912 from apple/lldb-Remove-unused-version-defines [lldb] Remove unused version defines

view details

push time in 9 days

push eventapple/llvm-project

Dave Lee

commit sha e3e51ab979df1ec103041b8d2105c6b63a75839f

[lldb] Remove unused version defines (cherry picked from commit 83253b29d64b6b5a95da0c0eea2403d9d53a448a)

view details

Dave Lee

commit sha 602c37563ed333af651ade264fae74b5c2aef31b

oops, restore upstream block of code (cherry picked from commit 0387ef915497ac552c45aa21f557a5ac27c4ad8f)

view details

Dave Lee

commit sha 7148791bdd3ff148ea531dbe6a92bd426e805acc

fix indentation (cherry picked from commit 8a33482be9af7561aed05d566f4f28e3f1fbb2d5)

view details

Dave Lee

commit sha 1715c0e39797b201189b55f1201282db8dce6476

Merge pull request #1961 from apple/lldb-Remove-unused-version-defines-next [lldb] Remove unused version defines

view details

push time in 9 days

PR merged apple/llvm-project

Reviewers
[lldb] Remove unused version defines

Removes unused compiler defines, and related code.

  • LLDB_IS_BUILDBOT_BUILD
  • LLDB_BUILD_DATE

This eliminates some downstream diff from llvm.org. See also https://github.com/apple/swift/pull/34212

This also removes the "fake" LLDB_UPSTREAM definition, which is the inverse of LLDB_ENABLE_SWIFT. Instead, that block of code is an #else branch.

+2 -21

5 comments

1 changed file

kastiglione

pr closed time in 9 days

push eventapple/llvm-project

Jonas Devlieghere

commit sha e465ddac880228b879b5a6549adbb9c8a7f335bf

[lldb] Alphabetically sort test categories (NFC)

view details

git apple-llvm automerger

commit sha 80d64a04c6eda6ded9b82c76f06f3aa08bbd1dc9

Merge commit 'e465ddac8802' from llvm.org/master into apple/main

view details

Jonas Devlieghere

commit sha 360ab009e2b95629388cef132ebe639c120ed35e

[lldb] Add instrumentation runtime category

view details

git apple-llvm automerger

commit sha c983d61707cc83e58ccb3c9083b27807cb76abd4

Merge commit '360ab009e2b9' from llvm.org/master into apple/main

view details

Jonas Devlieghere

commit sha 794cf135c15eb38a2fa74792c9552d8b374d5fd0

Merge commit '80d64a04c6ed' from apple/main into swift/next Conflicts: lldb/packages/Python/lldbsuite/test/test_categories.py

view details

git apple-llvm automerger

commit sha d48ddf38d4a2e28177ecbea7742e6e11df1559e3

Merge commit 'c983d61707cc' from apple/main into swift/next

view details

Nathan Ridge

commit sha b764edc59ff7768e052bc2b9e76e3bb69dd5147b

[clangd] Try harder to get accurate ranges for documentSymbols in macros Fixes https://github.com/clangd/clangd/issues/500 Differential Revision: https://reviews.llvm.org/D88463

view details

git apple-llvm automerger

commit sha 7bc213e62350e10f100af680a08507cf56dc8749

Merge commit 'b764edc59ff7' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha c2a20d0cc6be456839d5bd8b6d302b5588025690

Merge commit '7bc213e62350' from apple/main into swift/next

view details

Dave Lee

commit sha a52cc9b4be362b12ca261000b723374d4b772a45

[lldb] Handle alternative output in TestAbortExitCode This test On macOS, this test can instead return `status = 0 (0x00000000) Terminated due to signal 6`. This updates the `CHECK` accordingly. Differential Revision: https://reviews.llvm.org/D89273

view details

git apple-llvm automerger

commit sha e7eb43e7aa51e24d5720b84c826333950a0a680d

Merge commit 'a52cc9b4be36' from llvm.org/master into apple/main

view details

git apple-llvm automerger

commit sha c167c4d5918ac9d189b344fef56f171fae660cd1

Merge commit 'e7eb43e7aa51' from apple/main into swift/next

view details

Dave Lee

commit sha 08924b54debcfd47bcf22a8213308cec7d22b975

[lldb] Remove unused code in GetVersion (NFC) Small cleanup to `lldb_private::GetVersion()`. Differential Revision: https://reviews.llvm.org/D88939

view details

git apple-llvm automerger

commit sha bcc0aca98dd30ba6b1f5b4a3ccd69a379a62dc74

Merge commit '08924b54debc' from llvm.org/master into apple/main

view details

Vedant Kumar

commit sha 7990ee99979c2b29c77343cc665f773eb6ac36b8

[repl_swift] Delete codesigning override This might be causing codesigning to occur multiple times during a fat package build. rdar://70237254 (cherry picked from commit 86d12608bee69c58f2268dbe810f924e0352ef7f)

view details

Vedant Kumar

commit sha 9008352dc19dbf743ef0ddab2b844b3cda3c1151

Revert "[repl_swift] Delete codesigning override" This reverts commit 7990ee99979c2b29c77343cc665f773eb6ac36b8.

view details

Adrian Prantl

commit sha 1fd46b11688c21c87a65d393d427b7bf6b64029e

Remove legacy Swift language constant support (cherry picked from commit 31031e6866c85a95d3506fdf58cde72cb83fb84e) Conflicts: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

view details

Vedant Kumar

commit sha 9f26a1f6b10497f599467044913fdec25519aaad

[repl_swift] Delete unused Xcode project (cherry picked from commit ec01dd968514785735e3de48e5e320eab2853071)

view details

adrian-prantl

commit sha 7b1b5de6996f619e90922f76056b151ddf1b73b9

Merge pull request #1952 from adrian-prantl/D86615-next Remove legacy Swift language constant support

view details

Adrian Prantl

commit sha 29ac346972e88a5f354960eb85cf70df67f3b6aa

Remove legacy Swift language constant support (cherry picked from commit 31031e6866c85a95d3506fdf58cde72cb83fb84e) Conflicts: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

view details

push time in 9 days

PR opened apple/llvm-project

[lldb] Remove unused version defines

(cherry pick of #1912)

+2 -21

0 comment

1 changed file

pr created time in 9 days

create barnchapple/llvm-project

branch : lldb-Remove-unused-version-defines-next

created branch time in 9 days

push eventapple/swift

Dave Lee

commit sha 27330f169df5d2dcb018ab2c6615d66be91d04e2

[build] Remove unused lldb cmake

view details

Dave Lee

commit sha b02dc2b25bc2c9c258370265c54d744c178a101c

LLDB_PATH_TO_SWIFT_SOURCE too

view details

Dave Lee

commit sha 804459df815793cc3781addd3f14b0ee1a983abf

Merge pull request #34212 from apple/build-Remove-unused-lldb-cmake [build] Remove unused lldb cmake

view details

push time in 9 days

delete branch apple/swift

delete branch : build-Remove-unused-lldb-cmake

delete time in 9 days

PR merged apple/swift

Reviewers
[build] Remove unused lldb cmake

This removes the CMake definitions for:

  • LLDB_IS_BUILDBOT_BUILD
  • LLDB_BUILD_DATE
  • LLDB_PATH_TO_SWIFT_SOURCE

Despite being defined here, their values have not been passed through to the compiler. See also https://github.com/apple/llvm-project/pull/1912

+0 -14

2 comments

1 changed file

kastiglione

pr closed time in 9 days

pull request commentapple/swift

[build] Remove unused lldb cmake

@swift-ci smoke test

kastiglione

comment created time in 9 days

pull request commentapple/swift

[build] Remove dash-dash from build-presets.ini (NFC)

@swift-ci test

kastiglione

comment created time in 10 days

PR opened apple/swift

Reviewers
[build] Remove dash-dash from build-presets.ini (NFC)

Remove the many dash-dash lines in build-presets.ini, which are not handled:

https://github.com/apple/swift/blob/2c3a6e06f4edc2ed64a638e30379bbcc83479768/utils/build_swift/build_swift/presets.py#L256-L258

+0 -128

0 comment

1 changed file

pr created time in 10 days

create barnchapple/swift

branch : build-Remove-dash-dash-from-build-presets.ini-NFC

created branch time in 10 days

push eventapple/swift

Dave Lee

commit sha b02dc2b25bc2c9c258370265c54d744c178a101c

LLDB_PATH_TO_SWIFT_SOURCE too

view details

push time in 10 days

pull request commentapple/llvm-project

[lldb] Remove unused version defines

@Teemperor do you know if anything supplies or consumes these values?

kastiglione

comment created time in 10 days

push eventllvm/llvm-project

Dave Lee

commit sha 41f946a6d2a4c1b36ee0a63f615a1aa6edf37cab

[cmake] Limit missing external lit warning to be shown once When using a custom `LLVM_EXTERNAL_LIT`, it's possible the file may not exist at the CMake is generating the build. One example is LLDB standalone builds. When the external lit doesn't exist, a warning message is emitted, but the warning is printed once for every single lit target. This produces many redundant warnings. This changes the warning to only be emitted once, controlled by a CACHE variable. Other options are: 1. remove the warning 2. have callers pass an option to silence the warning if desired See https://reviews.llvm.org/D76945 for some context. Differential Revision: https://reviews.llvm.org/D89356

view details

push time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/llvm-project

[repl_swift] Delete codesigning override

The signing was introduced in https://github.com/apple/llvm-project/commit/400559d80721bc8b5a33344cbf0b8b2fe947f474 "[CMake] install-distribution support for swift-lldb on Darwin". Are we sure that it can be removed?

vedantk

comment created time in 10 days

delete branch apple/llvm-project

delete branch : lldb-Handle-alternative-output-in-TestAbortExitCode

delete time in 11 days

Pull request review commentapple/swift

Add check for Xcode version compatibility

 from swift_build_support.swift_build_support.toolchain import host_toolchain # TODO: Remove this constant, it's really not helpful. HOME = os.environ.get("HOME", "/") +_SUPPORTED_XCODE_BUILDS = [+    ("12.0 beta 3", "12A8169g"),+    ("12.0 beta 4", "12A8179i"),+    ("12.0 beta 5", "12A8189h"),+    ("12.0 beta 6", "12A8189n"),+    ("12.0 GM 1", "12A7208"),+    ("12.0 GM 2", "12A7209"),+    ("12.0.1", "12A7300"),

I figured the second constant would have to be defined here. The question is: Is it good to introduce that constant here, or not?

keith

comment created time in 11 days

PullRequestReviewEvent

PR opened apple/llvm-project

Reviewers
[lldb] Handle alternative output in TestAbortExitCode

On macOS, this test can instead return status = 0 (0x00000000) Terminated due to signal 6. This updates the CHECK accordingly.

Differential Revision: https://reviews.llvm.org/D89273

(cherry picked from commit a52cc9b4be362b12ca261000b723374d4b772a45)

+1 -1

0 comment

1 changed file

pr created time in 11 days

push eventllvm/llvm-project

Dave Lee

commit sha 08924b54debcfd47bcf22a8213308cec7d22b975

[lldb] Remove unused code in GetVersion (NFC) Small cleanup to `lldb_private::GetVersion()`. Differential Revision: https://reviews.llvm.org/D88939

view details

push time in 11 days

push eventllvm/llvm-project

Dave Lee

commit sha a52cc9b4be362b12ca261000b723374d4b772a45

[lldb] Handle alternative output in TestAbortExitCode This test On macOS, this test can instead return `status = 0 (0x00000000) Terminated due to signal 6`. This updates the `CHECK` accordingly. Differential Revision: https://reviews.llvm.org/D89273

view details

push time in 11 days

Pull request review commentapple/swift

Add check for Xcode version compatibility

 from swift_build_support.swift_build_support.toolchain import host_toolchain # TODO: Remove this constant, it's really not helpful. HOME = os.environ.get("HOME", "/") +_SUPPORTED_XCODE_BUILDS = [+    ("12.0 beta 3", "12A8169g"),+    ("12.0 beta 4", "12A8179i"),+    ("12.0 beta 5", "12A8189h"),+    ("12.0 beta 6", "12A8189n"),+    ("12.0 GM 1", "12A7208"),+    ("12.0 GM 2", "12A7209"),+    ("12.0.1", "12A7300"),

I'm thinking we can put a comment on _SUPPORTED_XCODE_BUILDS and say something like:

These versions are community sourced. At any given time only the Xcode version used by Swift CI is officially supported. See https://ci.swift.org.

Maybe we could even separate out the current CI version of Xcode into its own constant, and if the current version doesn't match that, a warning/info notice can be shown, to highlight the potential issue in case anything goes wrong.

keith

comment created time in 11 days

PullRequestReviewEvent

delete branch apple/llvm-project

delete branch : lldb-Remove-decl-of-unimplemented-DoesTypeEntailIndirectBuffer

delete time in 11 days

pull request commentapple/llvm-project

[lldb] Remove decl of unimplemented DoesTypeEntailIndirectBuffer

preset= doesn't work here, only for swift

kastiglione

comment created time in 11 days

pull request commentapple/llvm-project

[lldb] Remove decl of unimplemented DoesTypeEntailIndirectBuffer

preset=lldb-smoketest,tools=RA @swift-ci test with preset macOS Platform

kastiglione

comment created time in 11 days

pull request commentapple/llvm-project

[lldb] Remove decl of unimplemented DoesTypeEntailIndirectBuffer

preset=lldb-smoketest,tools=RA @swift-ci test with preset macOS

kastiglione

comment created time in 11 days

delete branch apple/llvm-project

delete branch : lldb-Remove-unused-overload-of-FindAllSymbolsWithNameAndType

delete time in 11 days

more