kastiglione ( Dave Lee )

pull request commentapple/llvm-project

Add override to fix -Winconsistent-missing-override warning.

thanks

jimingham

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

TypeSystem: Avoid the ISO646 spelling of the logical operators

 template <> struct less<swift::ClusteredBitVector> {     for (; iL >= 0 && iR >= 0; --iL, --iR) {       bool bL = lhs[iL];       bool bR = rhs[iR];-      if (bL and not bR)

if it were my choice, we should switch everything to use not instead of !

compnerd

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):+def _get_bool_config(key):     config = lldb.SBDebugger.GetBuildConfiguration()     value_node = config.GetValueForKey(key)     fail_value = True # More likely to notice if something goes wrong-    have = value_node.GetValueForKey("value").GetBooleanValue(fail_value)+    return value_node.GetValueForKey("value").GetBooleanValue(fail_value)++def _get_bool_connfig_skip_if_decorator(key):

it didn't work for me, I only noticed this because of python exceptions

Teemperor

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentapple/llvm-project

[lldb][swift] Make swiftTest decorator not always skip

 def skipIfAsan(func):     """Skip this test if the environment is set up to run LLDB *itself* under ASAN."""     return skipTestIfFn(is_running_under_asan)(func) -def _get_bool_config_skip_if_decorator(key):+def _get_bool_config(key):     config = lldb.SBDebugger.GetBuildConfiguration()     value_node = config.GetValueForKey(key)     fail_value = True # More likely to notice if something goes wrong-    have = value_node.GetValueForKey("value").GetBooleanValue(fail_value)+    return value_node.GetValueForKey("value").GetBooleanValue(fail_value)++def _get_bool_connfig_skip_if_decorator(key):

def _get_bool_config_skip_if_decorator(key):

Teemperor

comment created time in 4 days

PullRequestReviewEvent

delete branch apple/llvm-project

delete branch : lldb-Fix-few-easily-correctable-warnings

delete time in 4 days

Pull request review commentapple/llvm-project

TypeSystem: silence some errors identified by MSVC

 class SwiftDWARFImporterDelegate : public swift::DWARFImporterDelegate {       // described in DWARF.       return true;     }+    return false;

so msvc doesn't consider the switch exhaustive? should this be an llvm_unreachable?

compnerd

comment created time in 6 days

PullRequestReviewEvent

delete branch apple/llvm-project

delete branch : cmake-Centralize-LLVM_ENABLE_WARNINGS-option

delete time in 6 days

push eventapple/llvm-project

Dave Lee

commit sha e184b47a679ecccedc4bad7acc42db1c28621765

[cmake] Centralize LLVM_ENABLE_WARNINGS option Configure default value of `LLVM_ENABLE_WARNINGS` in `HandleLLVMOptions.cmake`. `LLVM_ENABLE_WARNINGS` is documented as ON by default, but `HandleLLVMOptions` assumes the default has been set somewhere else. If it has not been explicitly set, then `HandleLLVMOptions` implicitly uses OFF as a default. This removes the various `option()` declarations in favor of a single declaration in `HandleLLVMOptions`. This will prevent the unwanted use of `-w` that is mentioned in a couple of the comments. Reviewed By: DavidTruby, #libunwind, JDevlieghere, compnerd Differential Revision: https://reviews.llvm.org/D87243 (cherry picked from commit b36bdfe5ca0c2b863248f327b03d41516b38dc11)