profile
viewpoint
Keith Smiley keith Lyft San Francisco, CA https://smileykeith.com iOS @Lyft

christoomey/vim-tmux-navigator 3272

Seamless navigation between tmux panes and vim splits

CocoaPods/Rome 644

Makes it easy to build a list of frameworks.

bazelbuild/tulsi 346

An Xcode Project Generator For Bazel

bazelbuild/rules_apple 207

Bazel rules to build apps for Apple platforms.

bazelbuild/rules_swift 139

Bazel rules to build Swift on Apple and Linux platforms

bazel-ios/rules_ios 89

Bazel rules for building iOS applications and frameworks

keith/contacts-cli 40

Query macOS contacts from the command line

kattrali/webkitten 33

A command-driven web browser toolkit inspired by luakit and Vim.

bazelbuild/apple_support 19

Apple support for Bazel rules

keith/conductor 19

A lightweight OS X window manager for hackers

PR opened apple/swift

[Concurrency] Add a debug variable pointing to the metadata for AsyncTask.

Debugging tools can use _swift_concurrency_debug_asyncTaskMetadata to identify memory blocks as async task allocations by looking at their isa/metadata pointer.

rdar://72906895

+34 -0

0 comment

2 changed files

pr created time in 14 minutes

pull request commentapple/swift

IRGen: Emit async function pointers for resilient class and protocol dispatch thunks

@swift-ci Please smoke test

slavapestov

comment created time in 16 minutes

PR opened bazelbuild/bazel

Reviewers
Update the internal version of bazelbuild/platforms to 0.0.3
+4 -4

0 comment

1 changed file

pr created time in 18 minutes

PR opened bazelbuild/platforms

Reviewers
Update distribution docs for new Bazel dist scheme.
+21 -131

0 comment

1 changed file

pr created time in 18 minutes

push eventbazelbuild/bazel

Googler

commit sha bff197a1c4c6673a6b4aff14d2f56a0d36657634

Make J2ObjcAspect#getProtoOutputRoot compatible with --experimental_sibling_repository_layout. It currently adds the repository's exec path. Since it starts with ".." when the flag is in effect, what it actually does is removing the "genfiles" path element from the returned path. Given genfiles paths already include repository names in the new path architecture, this suffix is no longer required. PiperOrigin-RevId: 354122464

view details

push time in 19 minutes

pull request commentapple/swift

SimplifyCFG: fix an infinite jump-threading loop.

@swift-ci test macOS

eeckstein

comment created time in 22 minutes

release bazelbuild/platforms

0.0.3

released time in 25 minutes

push eventapple/swift-tools-support-core

Boris Buegling

commit sha 6fa6017164ab1f6723149eeb42533410dad5d1c3

Improve `removeFileTree` There is a potential race of the given directory being deleted between the `exists` call and the actual deletion. If this happens, we can ignore the error.

view details

Boris Bügling

commit sha 238a305a5c265d8e531f1df2c220cc9277dd7285

Merge pull request #186 from neonichu/improve-removeFileTree Improve `removeFileTree`

view details

push time in 26 minutes

PR merged apple/swift-tools-support-core

Reviewers
Improve `removeFileTree`

There is a potential race of the given directory being deleted between the exists call and the actual deletion. If this happens, we can ignore the error.

+10 -1

7 comments

2 changed files

neonichu

pr closed time in 26 minutes

created tagbazelbuild/platforms

tag0.0.3

Constraint values for specifying platforms and toolchains

created time in 27 minutes

push eventapple/swift

Dave Lee

commit sha 4a349f93973deb95d69b8a7f9344a66eedf4f16d

SIL: Gate checkForLeaksAfterDestruction to asserts builds

view details

Michael Gottesman

commit sha 1de2d3f7c07914e640f480aa85e31cf89ade2935

[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds. This follows the design of how we handled this with sil-verify-all. Specifically, the default behavior is to run only in asserts builds, but one can use the two flags: enable-ast-verifier and disable-ast-verifier to override the default behavior. The reason why this is interesting is that this means that when compiling normally, we will not run the verifier, so we won't have a perf hit. But we can now ask the user to run with this flag (or in a future maybe a re-run in the driver would do this for them), saving us time when screening bugs by avoiding the need to build an asserts compiler to triage if the ASTVerifier would catch the bug.

view details

Dave Lee

commit sha 9760533fe2f28e1d2afc4d47bba3a76d5ea737c1

add explanatory comment

view details

Michael Gottesman

commit sha 6e61279dece48c11960b8228eaa46cd2ae91c5e4

Merge pull request #35587 from gottesmm/pr-5db2d0b093c814bacaaf559563926c5dec16acc3 [ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds.

view details

Dave Lee

commit sha c36c32027e6bad5fd52010ed2c539936b667d8a7

Merge pull request #35568 from apple/SIL-Gate-checkForLeaksAfterDestruction-to-asserts-builds SIL: Gate checkForLeaksAfterDestruction to asserts builds

view details

swift-ci

commit sha 9aad33b08f0c883200b1b53d017edeb347471f0c

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 28 minutes

push eventapple/swift

Dave Lee

commit sha 4a349f93973deb95d69b8a7f9344a66eedf4f16d

SIL: Gate checkForLeaksAfterDestruction to asserts builds

view details

Dave Lee

commit sha 9760533fe2f28e1d2afc4d47bba3a76d5ea737c1

add explanatory comment

view details

Dave Lee

commit sha c36c32027e6bad5fd52010ed2c539936b667d8a7

Merge pull request #35568 from apple/SIL-Gate-checkForLeaksAfterDestruction-to-asserts-builds SIL: Gate checkForLeaksAfterDestruction to asserts builds

view details

push time in 29 minutes

delete branch apple/swift

delete branch : SIL-Gate-checkForLeaksAfterDestruction-to-asserts-builds

delete time in 29 minutes

PR merged apple/swift

SIL: Gate checkForLeaksAfterDestruction to asserts builds

A few lldb bug reports have shown that SILModule::checkForLeaksAfterDestruction() can fail. The root cause is TBD, possibly by calling IRGenRequest::evaluate concurrently (the leaks check uses counters that are not thread safe).

This leaks check should reasonably be performed only in asserts builds. That way end users won't face a crash if there's a race in how the check is performed, or if there is a leak. Note that SILModule::checkForLeaks() is called only in asserts builds.

rdar://70826934

+4 -0

5 comments

1 changed file

kastiglione

pr closed time in 30 minutes

issue openednicklockwood/SwiftFormat

convenience seems to disable --rules wrapAttributes --funcattributes prev-line

Hi,

similarly to https://github.com/nicklockwood/SwiftFormat/issues/856, having convenience present prevents @objc beign wrapped.

My example:

@objc public convenience init(arg1: Type1,
                              arg2: Type2,
                              arg3: Type3)
{
     // ...
}

Removing convenience and reformatting will put @objc on the previous line.

Manually formatted code in that manner will not be reverted to same line.

created time in 33 minutes

pull request commentapple/swift

[test] Allow setting extra environment for running tests.

@swift-ci please smoke test

drodriguez

comment created time in an hour

PR opened apple/swift

Reviewers
[test] Allow setting extra environment for running tests.

In some situations, in order to set the correct environment during some tests, extra environment has to be provided to the LLVM Lit invocations. It seems that the preferred way is using cmake -E env to be cross-platform.

The environment can be set using a cached variable so it can be set from CMake cache files, or passing parameters to the CMake configuration step.

/cc @rmaz

+4 -0

0 comment

1 changed file

pr created time in an hour

push eventapple/swift

Michael Gottesman

commit sha 1de2d3f7c07914e640f480aa85e31cf89ade2935

[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds. This follows the design of how we handled this with sil-verify-all. Specifically, the default behavior is to run only in asserts builds, but one can use the two flags: enable-ast-verifier and disable-ast-verifier to override the default behavior. The reason why this is interesting is that this means that when compiling normally, we will not run the verifier, so we won't have a perf hit. But we can now ask the user to run with this flag (or in a future maybe a re-run in the driver would do this for them), saving us time when screening bugs by avoiding the need to build an asserts compiler to triage if the ASTVerifier would catch the bug.

view details

Michael Gottesman

commit sha 6e61279dece48c11960b8228eaa46cd2ae91c5e4

Merge pull request #35587 from gottesmm/pr-5db2d0b093c814bacaaf559563926c5dec16acc3 [ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds.

view details

push time in an hour

PR merged apple/swift

Reviewers
[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds.

This follows the design of how we handled this with sil-verify-all. Specifically, the default behavior is to run only in asserts builds, but one can use the two flags: enable-ast-verifier and disable-ast-verifier to override the default behavior.

The reason why this is interesting is that this means that when compiling normally, we will not run the verifier, so we won't have a perf hit. But we can now ask the user to run with this flag (or in a future maybe a re-run in the driver would do this for them), saving us time when screening bugs by avoiding the need to build an asserts compiler to triage if the ASTVerifier would catch the bug.

+106 -33

8 comments

10 changed files

gottesmm

pr closed time in an hour

pull request commentapple/swift

ABI: convert some `unsigned long` to `unsigned long long`

or uint64_t or uintptr_t?

compnerd

comment created time in an hour

pull request commentapple/swift

[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds.

I talked with @varungandhi-apple. They are fine with us doing post-commit review on this since there wasn't a perf change at all.

gottesmm

comment created time in an hour

created repositorysergeylukin/rapidmovie

created time in an hour

pull request commentbazelbuild/bazel

Support multiple --bazelrc on command line

Thanks! have adjusted accordingly.

wisechengyi

comment created time in an hour

pull request commentapple/swift

Minor bug fixes in SILCombine, Canonicalization and LoadBorrowImmutabilityChecker

@swift-ci test Windows Platform

meg-gupta

comment created time in an hour

pull request commentapple/swift

Minor bug fixes in SILCombine, Canonicalization and LoadBorrowImmutabilityChecker

@swift-ci test macOS Platform

meg-gupta

comment created time in an hour

pull request commentapple/swift

Platform: add dxgidebug.h to _DXGI module

@swift-ci please smoke test

compnerd

comment created time in an hour

pull request commentapple/swift

Platform: add dxgidebug.h to _DXGI module

CC: @egorzhdan

compnerd

comment created time in an hour

PR opened apple/swift

Platform: add dxgidebug.h to _DXGI module

The debug header is used for enumeration of certain DXGI interfaces related to debugging of the pipeline. Add this to gain access to the interfaces and some of the global GUIDs associated with it.

<!-- What's in this pull request? --> Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Resolves SR-NNNN.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+1 -0

0 comment

1 changed file

pr created time in an hour

push eventapple/swift

Evan Wilde

commit sha 0445f4f2b24376bfa92932679bc216abf5a80403

Suggest replacing 'async' with 'await' at call site It's pretty easy to typo-replace 'await' with 'async' and get a confusing error about 'async' not being in scope. This patch updates the diagnostic to suggest replacing 'async' with 'await' at the call-sites so that users aren't left scratching their heads.

view details

Pavel Yaskevich

commit sha b03dc636341d48ec9c5d5dda2fc436af8f1e9b5d

[AST] Adjust `TypeBase::getTypeVariables` to accept a set Currently the pattern is to collect the type variables and then unique them. Instead of asking clients to do uniquing, let's just accept a set as an argument.

view details

Evan Wilde

commit sha 49bfcd223e06f5b487d3933e68e0aea678996298

Replace improper 'async' in parser By replacing the 'async' with 'await' in the parser, we avoid the issue of cascading errors as the compiler gets more and more confused by what it's reading. Instead, everything mostly passes and we just emit the one error message. One caveat that I hadn't taken into account before was that we could have a function called "async", in which case we don't want to replace the "async" keyword with "await".

view details

Evan Wilde

commit sha c2be0bd66320ea5c957c07fbad01f54fcd323392

Add test case for `async try foo()` Ensure that we emit the proper diagnostics for when the await and try are flipped, but also await is incorrectly spelled `async`. We're expecting two diagnostics, both of which have fix-its that do the right thing. One will just replace the `async` with an `await`. The other will move the text so that try comes first. Because `await` and `async` are both have the same number of characters, both fix-its will fix the issue correctly.

view details

Evan

commit sha 2c4f7b90964f76991bb09a2c2f97cb601a5543a8

Merge pull request #35518 from etcwilde/ewilde/did-you-mean-await [Concurrency] Suggest replacing 'async' with 'await' at call site

view details

Pavel Yaskevich

commit sha fda3dc51273173fb108c8d2efd8ee4499cf31ed9

Merge pull request #35607 from xedin/type-vars-accepts-set [AST] Adjust `TypeBase::getTypeVariables` to accept a set

view details

swift-ci

commit sha 0955d729a432076fa62c19a906912be567a6d9b6

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in an hour

pull request commentapple/swift

ABI: convert some `unsigned long` to `unsigned long long`

@swift-ci please test

compnerd

comment created time in an hour

more