profile
viewpoint

altayaydemir/react-dual-list-box 8

A dual listbox component for React.

codeforbirmingham/smarterbham 6

Repository for the SmarterBham project (UNMAINTAINED)

jflayhart/ar-workshop 0

AR store app workshop

jflayhart/battleshipt 0

hit and sunk!

jflayhart/bookmarklets 0

bookmarklet scripts for task automation

jflayhart/create-react-app 0

Set up a modern web app by running one command.

jflayhart/DIM 0

Destiny Item Manager

jflayhart/ducks-modular-redux 0

A proposal for bundling reducers, action types and actions when using Redux

jflayhart/hacktoberfest 0

Participate in Hacktoberfest by contributing to any Open Source project on GitHub! Here is a starter project for first time contributors. #hacktoberfest

jflayhart/Hello-Hacktober 0

This repository is for people who are starting to program, and want to participate in hacktoberfest or just want to contribute

issue commentcypress-io/cypress

Add ability to configure ‘upload’ and ‘storage’ of videos separately when test suite passes/fails.

The main motivator of that issue seemed to be what would be achieved in this issue - that people want non-passing tests' videos to be deleted.

Thanks for replying @jennifer-shehane I still think there's a misunderstanding here. It's not that "people want non-passing tests' videos to be deleted", that is in fact the inverse of precisely what we're asking 😄 We don't want failed tests to be removed, we want failed tests to be the only things processed and saved, in other words, passing tests should not be saved, only failed ones.

GrayedFox

comment created time in a month

PullRequestReviewEvent

startedvercel/next.js

started time in a month

Pull request review commentshipt/specter

Updating Readme

 class App extends React.PureComponent {       .then(res => {         self.appVersion = res.headers.get('Version')       });-+         this.setupWebSocket();-  }+}    setupWebSocket() {     try {       let uri = window.location.protocol === 'https:' ? 'wss:' : 'ws:';       uri += '//' + window.location.host;-      uri += window.location.pathname + 'ws';+      uri += window.location.pathname + 'ws'+      let host_proxy_list = []       this.ws = new WebSocket(uri);-       this.ws.onmessage = (evt) => {         // exit early if we get bad JSON data         if (evt.data === '') return         const wsData = JSON.parse(evt.data)++        if (host_proxy_list.includes(wsData['HostProxy']) === false) {+          host_proxy_list.push(wsData['HostProxy'])+        }++        var result = host_proxy_list.map(e => ({id: e, name: e}))++        this.setState({host_list: result});++        if (wsData['HostProxy'])  {+          if (this.state.dropdown != "all" && wsData['HostProxy'] != this.state.dropdown) return+        }    

personally, i'd leave comments to help others understand the conclusion that lead us to this logic.

kartsree

comment created time in 2 months

Pull request review commentshipt/specter

Updating Readme

 class App extends React.PureComponent {       .then(res => {         self.appVersion = res.headers.get('Version')       });-+         this.setupWebSocket();-  }+}    setupWebSocket() {     try {       let uri = window.location.protocol === 'https:' ? 'wss:' : 'ws:';       uri += '//' + window.location.host;-      uri += window.location.pathname + 'ws';+      uri += window.location.pathname + 'ws'+      let host_proxy_list = []       this.ws = new WebSocket(uri);-       this.ws.onmessage = (evt) => {         // exit early if we get bad JSON data         if (evt.data === '') return         const wsData = JSON.parse(evt.data)++        if (host_proxy_list.includes(wsData['HostProxy']) === false) {+          host_proxy_list.push(wsData['HostProxy'])+        }++        var result = host_proxy_list.map(e => ({id: e, name: e}))++        this.setState({host_list: result});

this may be ok... but this is going to fire ALOT, so if you run into performance issues (react working too hard) then you may need to throttle this method to only happen every 200ms or something like that.

kartsree

comment created time in 2 months

issue commentcypress-io/cypress

Add ability to configure 'upload' and 'compression' of videos (outside of actual recording)

Hacks and other solutions like "just remove all the non-failed ones" is silly. This is not what we want! A simple toggle to NOT process SUCCESSFUL videos AT ALL. PERIOD. Regardless of using recording, cypress dashboards, etc.

The problem with said hacks is that it completely doesn't fix the problem that TIME and SPACE is required to store process, store, and generate these videos and that time is spent wasted for videos some users of the community don't need. We use Cypress liberally and the tests take minutes just to process videos we don't need.

For example, 99 tests pass, 1 test fails, but 100 videos are processed. In this example, we only want ONE VIDEO RECORDING GENERATED AND SAVED. I think there's still confusion around this ask.

GrayedFox

comment created time in 2 months

issue commentvercel/next.js

React server mismatches: Prop `className` did not match.

Same problem here, trying to use styled(ExternalComponent) mismatches classes.

Similar issue and @KyorCode's comment was my problem. I just had to convert all const StyledComponent = styled(Component) to be const StyledComponent = styled.[html-element-goes-here]...

voronianski

comment created time in 2 months

issue commentrt2zz/redux-persist

PersistGate stuck on loading when query parameter present in URL

Yes I am using NextJS and I just went ahead and made my own implementation of persisted state in localStorage (hint uses store.subscribe) and it's working. Does this library support SSR?

mdolon

comment created time in 2 months

issue commentrt2zz/redux-persist

PersistGate stuck on loading when query parameter present in URL

I think this may be an issue with this library because it is what throws this error in this case:

react_devtools_backend.js:2273 Warning: Cannot update a component (`ConnectFunction`) while rendering a different component (`StyledApp`). To locate the bad setState() call inside `StyledApp`, follow the stack trace as described in https://fb.me/setstate-in-render
    in StyledApp (created by App)
    in Provider (created by App)
    in App
    in ErrorBoundary (created by ReactDevOverlay)
    in ReactDevOverlay (created by Container)
    in Container (created by AppContainer)
    in AppContainer
    in Root
mdolon

comment created time in 2 months

issue commentrt2zz/redux-persist

PersistGate stuck on loading when query parameter present in URL

I am getting this error as well and been trying to get to the root cause... if I find anything I'll update here.

mdolon

comment created time in 2 months

Pull request review commentGoogleChrome/lighthouse-ci

feat(cli): allow status app url to be configured

 function buildCommand(yargs) {       description: '[filesystem only] The pattern to use for naming Lighthouse reports.',       default: '%%HOSTNAME%%-%%PATHNAME%%-%%DATETIME%%.report.%%EXTENSION%%',     },+    githubAppUrl: {+      type: 'string',+      default: GITHUB_APP_STATUS_CHECK_URL,+      description:+        "The URL of the GitHub app where PR status checks are POST'd. Defaults to the publicly hosted app. Most users will not need to change this.",+    },

🎉

KnisterPeter

comment created time in 2 months

push eventjflayhart/website

Josh Flayhart

commit sha 0d0c75c53b808892c2953d8d86d4b93c812d28b5

Add webp logo

view details

push time in 2 months

delete branch jflayhart/website

delete branch : jflayhart-patch-1

delete time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha a986e25f498d0ee5e85eb3afe9c21e40d57c1a61

Improve a11y (#9) * Add valid lang attribute * Add main landmark region

view details

push time in 3 months

PR merged jflayhart/website

Improve a11y
+7 -5

1 comment

2 changed files

jflayhart

pr closed time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha ff3362861b3e7b4d21774b5b96c7b9f945c1a305

Update Main.js

view details

push time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha ba1ed783f0e5b73f329f6478f49d37e57d95ddbf

Update index.js

view details

push time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha acdfca75d4d738625205f420949281ae8264bd68

Add main landmark region

view details

push time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha 4db0b075834166001adb305ae03cc18507ec58da

Update _document.js

view details

push time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha 4a72cd3c9ab3004eceae2f19c2facee0a7ec7959

Add main landmark region

view details

push time in 3 months

PR opened jflayhart/website

Add valid lang attribute
+1 -1

0 comment

1 changed file

pr created time in 3 months

create barnchjflayhart/website

branch : jflayhart-patch-1

created branch time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha 88f6dcf8b07a35d8196d353a8845093142389c8c

Delete .gitpod.yml (#8)

view details

push time in 3 months

delete branch jflayhart/website

delete branch : jflayhart-patch-1

delete time in 3 months

PR merged jflayhart/website

Delete .gitpod.yml
+0 -4

1 comment

1 changed file

jflayhart

pr closed time in 3 months

PR opened jflayhart/website

Delete .gitpod.yml
+0 -4

0 comment

1 changed file

pr created time in 3 months

create barnchjflayhart/website

branch : jflayhart-patch-1

created branch time in 3 months

push eventjflayhart/website

Josh Flayhart

commit sha f3cd56182e413791fb365ef9cf5fe13f53a77b5f

Migrate to NextJS (#7) * Move to NextJS and Vercel hosting * migrate to NextJS framework * move off github pages * Fix _document

view details

push time in 3 months

delete branch jflayhart/website

delete branch : nextjs

delete time in 3 months

PR merged jflayhart/website

Migrate to NextJS
+4697 -7754

0 comment

33 changed files

jflayhart

pr closed time in 3 months

PR opened jflayhart/website

Migrate to NextJS
+4697 -7754

0 comment

33 changed files

pr created time in 3 months

create barnchjflayhart/website

branch : nextjs

created branch time in 3 months

issue commentGoogleChrome/lighthouse-ci

Feature request: allow parallel uploads for the same build hash

Ah i see the docs on this. thanks for the tip, that's what I'll do!

jflayhart

comment created time in 3 months

Pull request review commentGoogleChrome/lighthouse-ci

Clarify puppeteer docs

 When running Lighthouse CI on a page with behind authentication, you'll need to  * @param {{url: string, options: LHCI.CollectCommand.Options}} context  */ module.exports = async (browser, context) => {+  // launch browser for LHCI   const page = await browser.newPage();   await page.goto('http://localhost:8080/login');   await page.type('#username', 'admin');   await page.type('#password', 'password');   await page.click('[type="submit"]');   await page.waitForNavigation();+  // we're logged in, so test the page behind auth+  // runs the url set in lighthouserc+  await page.goto(context.url);

yeh, I could be very wrong though. Somehow I got to a point where this was necessary because the page was empty and the LHCI run would simply time out. I threw this in there and it worked.

Regardless, I agree this probably isn't necessary as a generic example!

jflayhart

comment created time in 3 months

push eventjflayhart/lighthouse-ci

Josh Flayhart

commit sha 9c94230b266543e5ee23eb77cd2c7ef0bcb1c539

Update docs/configuration.md Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>

view details

push time in 3 months

PR opened GoogleChrome/lighthouse-ci

Clarify puppeteer docs

Fixes #361

I still think there's more nuance to this script stuff, but hopefully this covers in more detail?

+22 -2

0 comment

1 changed file

pr created time in 3 months

push eventjflayhart/lighthouse-ci

Josh Flayhart

commit sha d5a4812042a47670d878f4f17958765bd9fe0630

Clarify puppeteer docs

view details

push time in 3 months

push eventjflayhart/lighthouse-ci

Josh Flayhart

commit sha 805c417b9c26bb9eea35d65884b4b93f00cb0699

feat(server): add "click to pin" prompt in dashboard (#360)

view details

push time in 3 months

delete tag jflayhart/lighthouse-ci

delete tag : v0.4.2-beta.0

delete time in 3 months

issue openedGoogleChrome/lighthouse-ci

Failing to upload using CircleCI parallel builds

The following error is occurring I think because it's trying to upload to the same 123abc hash on different parallel machines.

I NEED to have parallel machines to speed up the lighthouse ci and the first url to finish the test is the only one to be uploaded 😞

Error: Unexpected status code 422
 
  {"message":"Build already exists for hash \"123abc\""}
 
    at ApiClient._convertFetchResponseToReturnValue (/home/circleci/project/node_modules/@****/utils/src/api-client.js:91:21)
 
    at process._tickCallback (internal/process/next_tick.js:68:7)
 
WARNING: upload command failed.

created time in 3 months

issue commentGoogleChrome/lighthouse-ci

Document how an array of urls interacts with the puppeteerScript flag

Ah yes great point, I def use disableStorageReset: true

jimbyo

comment created time in 3 months

issue commentGoogleChrome/lighthouse-ci

Document how an array of urls interacts with the puppeteerScript flag

For example one of my solutions was to get around this fact that the browser session seems to persist cookies and thus once you're logged in once, you're logged in the rest of the runs:

// lighthouserc.js
urls: [
  'localhost/login', // have to test this first before cookie auth or else it never gets hit
  'localhost/',
  'localhost/contact',
  'localhost/about',
  ...
]
// puppeteer script
module.exports = async (browser, context) => {
  const page = await browser.newPage()
  try {
    if (!context.url.includes('/login')) {
       // do login stuff through UI once
    }
  await page.close()
  catch (e) {
    // handle error gracefully
  }
}
jimbyo

comment created time in 3 months

issue commentGoogleChrome/lighthouse-ci

Document how an array of urls interacts with the puppeteerScript flag

I agree docs would be good because when this CI tool first came out I spent a good bit of time figuring this out in particular.

@patrickhulce Should we make this a recipe or just a snippet in the docs?

jimbyo

comment created time in 3 months

pull request commentfacebook/create-react-app

Update workbox plugin to 5.1.2

love it! thanks @jeffposnick

jflayhart

comment created time in 3 months

PR closed jflayhart/website

Bump websocket-extensions from 0.1.3 to 0.1.4 dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

PR closed jflayhart/website

Bump acorn from 5.7.3 to 5.7.4 dependencies

Bumps acorn from 5.7.3 to 5.7.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/6370e90067552022710190319cbbbd8c43001957"><code>6370e90</code></a> Mark version 5.7.4</li> <li><a href="https://github.com/acornjs/acorn/commit/fbc15b1344f6dfb992f67b4bbf1357436247c8a0"><code>fbc15b1</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/5.7.3...5.7.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

PR closed jflayhart/website

Bump handlebars from 4.1.2 to 4.5.3 dependencies

Bumps handlebars from 4.1.2 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

more