Why is this only for tests?

nit: indentation.

@bors-servo r+

@bors-servo r+

@bors-servo retry

• #23290

@bors-servo r+

https://github.com/mrDIMAS/hrtf https://crates.io/crates/hrtf

From DEATHROAD in https://www.digitalmzx.com/show.php?id=1277. I suspect the "move player south" command might be misbehaving.

This is probably fixed by a758066c69f0879d80a68ce060af99d611bbf0fe.

Used by https://www.digitalmzx.com/show.php?id=1711

https://www.digitalmzx.com/show.php?id=511

Original:

libmzx:

Fixed by d604ddedb791c18815f4e422072f89b983c1f167.

This also means that the "blocked" label is only used when the player tries to move beyond the boundaries of the board.

Fixed by a758066c69f0879d80a68ce060af99d611bbf0fe.

This also means that the "blocked" label is only used when the player tries to move beyond the boundaries of the board.

https://www.digitalmzx.com/show.php?id=497

thread 'main' panicked at 'range end index 672024 out of range for slice of length 672000', capture/src/main.rs:23:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::slice::slice_end_index_len_fail
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/slice/mod.rs:3152
   3: <core::ops::range::Range<usize> as core::slice::SliceIndex<[T]>>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3352
   4: core::slice::<impl core::ops::index::IndexMut<I> for [T]>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3137
   5: <capture::Framebuffer as libmzx::render::Renderer>::put_pixel
             at ./capture/src/main.rs:23
   6: libmzx::render::draw_char
             at /Users/jdm/src/libmzx/src/render.rs:606
   7: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:203
   8: capture::render_game
             at ./capture/src/main.rs:198
   9: capture::run
             at ./capture/src/main.rs:153
  10: capture::main
             at ./capture/src/main.rs:220
  11: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Fixed by https://github.com/jdm/libmzx/commit/56ade15ed026fd6931a5e0e43cf7bc20c542a0ba

https://www.digitalmzx.com/show.php?id=497

thread 'main' panicked at 'range end index 672024 out of range for slice of length 672000', capture/src/main.rs:23:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::slice::slice_end_index_len_fail
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/slice/mod.rs:3152
   3: <core::ops::range::Range<usize> as core::slice::SliceIndex<[T]>>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3352
   4: core::slice::<impl core::ops::index::IndexMut<I> for [T]>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3137
   5: <capture::Framebuffer as libmzx::render::Renderer>::put_pixel
             at ./capture/src/main.rs:23
   6: libmzx::render::draw_char
             at /Users/jdm/src/libmzx/src/render.rs:606
   7: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:203
   8: capture::render_game
             at ./capture/src/main.rs:198
   9: capture::run
             at ./capture/src/main.rs:153
  10: capture::main
             at ./capture/src/main.rs:220
  11: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@bors-servo r+

The lack of a pinned revision in this manifest makes it harder for people to experiment with using libsimpleservo from other projects.

@jrmuizel Ping?

@bors-servo retry

@bors-servo r+

Replacing #4560.

@bors-servo retry

@bors-servo r+

https://www.digitalmzx.com/show.php?id=2154

godot:mzxscreen jdm$ RUST_BACKTRACE=1 ./random.sh a
    Finished dev [unoptimized + debuginfo] target(s) in 0.26s
     Running `target/debug/capture image.png output.json unzipped/KKbday3/KKBDAY3.mzx`
Capturing board 1: gameplay
thread 'main' panicked at 'index out of bounds: the len is 4160 but the index is 4160', /Users/jdm/src/libmzx/src/lib.rs:445:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic_bounds_check
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:62
   3: <usize as core::slice::SliceIndex<[T]>>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3285
   4: core::slice::<impl core::ops::index::Index<I> for [T]>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3126
   5: <alloc::vec::Vec<T> as core::ops::index::Index<I>>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/vec.rs:2012
   6: libmzx::Board::put_at
             at /Users/jdm/src/libmzx/src/lib.rs:445
   7: libmzx::board::put_at
             at /Users/jdm/src/libmzx/src/board.rs:112
   8: libmzx::board::put_thing
             at /Users/jdm/src/libmzx/src/board.rs:101
   9: libmzx::robot::run_one_command
             at /Users/jdm/src/libmzx/src/robot.rs:1480
  10: libmzx::robot::update_robot
             at /Users/jdm/src/libmzx/src/robot.rs:413
  11: libmzx::board::update_board
             at /Users/jdm/src/libmzx/src/board.rs:186
  12: capture::run
             at ./capture/src/main.rs:141
  13: capture::main
             at ./capture/src/main.rs:220
  14: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@bors-servo r+

@bors-servo retry

https://www.digitalmzx.com/show.php?id=342

thread 'main' panicked at 'attempt to subtract with overflow', /Users/jdm/src/libmzx/src/lib.rs:2347:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:50
   3: libmzx::decrypt_and_fix_offset
             at /Users/jdm/src/libmzx/src/lib.rs:2347
   4: libmzx::load_world
             at /Users/jdm/src/libmzx/src/lib.rs:2468
   5: capture::run
             at ./capture/src/main.rs:63
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Fixed by a1a53cdb09261db7e4cba506e631dec7a0d92f1e.

Also https://www.digitalmzx.com/show.php?id=965

Is there a plan to create a foundation to support Servo development? I plan to use some crates (pathfinder, etc.), but I'm worried about the future of the Servo project. Maybe I could donate or contribute if the project needs help. Do you plan to organize an independent browser development?

https://www.digitalmzx.com/show.php?id=2496

     Running `target/debug/populate download.zip output.json`
Fetching https://www.digitalmzx.com/search.php?browse=ALL&page=27
Fetching https://www.digitalmzx.com/show.php?id=2496
Fetching https://www.digitalmzx.com/download/2496/2cb1088a453e9a49b73d8ec43274b4aba3f7c81a7f4abc2b5431be23900033ec/
error: open zip entry PUN1.MZX failed
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `7`,
 right: `0`', populate/src/main.rs:104:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixed by b1ff894c085108313c7b6114f4be172e053dec62.

https://www.digitalmzx.com/show.php?id=698

Capturing board 1: Freaktown
thread 'main' panicked at 'internal error: entered unreachable code', /Users/jdm/src/libmzx/src/lib.rs:1396:14
stack backtrace:
   0: std::panicking::begin_panic
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:497
   1: libmzx::door_from_param
             at /Users/jdm/src/libmzx/src/lib.rs:1396
   2: libmzx::render::char_from_id
             at /Users/jdm/src/libmzx/src/render.rs:730
   3: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:130
   4: capture::render_game
             at ./capture/src/main.rs:198
   5: capture::run
             at ./capture/src/main.rs:153
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233

This is #15.

https://www.digitalmzx.com/show.php?id=698

Capturing board 1: Freaktown
thread 'main' panicked at 'internal error: entered unreachable code', /Users/jdm/src/libmzx/src/lib.rs:1396:14
stack backtrace:
   0: std::panicking::begin_panic
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:497
   1: libmzx::door_from_param
             at /Users/jdm/src/libmzx/src/lib.rs:1396
   2: libmzx::render::char_from_id
             at /Users/jdm/src/libmzx/src/render.rs:730
   3: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:130
   4: capture::render_game
             at ./capture/src/main.rs:198
   5: capture::run
             at ./capture/src/main.rs:153
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233

All the known information about this is in this issue.

The world files no longer fail to load.

Correct. It is expected they will become public at some point in the future.

@bors-servo retry

@bors-servo r+

Servo crashes on start when I try to open yahoo.com:

D/RustAndroidGlueStdouterr(14544): WARN:servo: Panic hook called.
D/RustAndroidGlueStdouterr(14544): ERROR:servo: Failed to get window position.
D/RustAndroidGlueStdouterr(14544): Failed to get window position. (thread <unnamed>, at /buildslave/rust-buildbot/slave/nightly-dist-rustc-arm-android/build/src/libcore/option.rs:715)
E/Gecko   (14544): mozalloc_abort: Redirecting call to abort() to mozalloc_abort
F/libc    (14544): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 14560 (m.mozilla.servo)
D/RustAndroidGlueStdouterr(14544): fatal runtime error: failed to initiate panic, error 9

Commit 143dfc879e609603839502d61bc064fba96cc80f, tested on an Odroid XU3 running Android 4.4.4.

Our android builds don't rely on winit any more, so this can be closed.

@bors-servo r+

These test results for layout-2020 need to be updated:

6 unexpected results that are NOT known-intermittents:
  â–¶ Unexpected subtest result in /css/cssom/cssimportrule.html:
  â”” PASS [expected FAIL] StyleSheet : MediaList mediaText attribute should be updated due to [PutForwards]


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-001.html:
  â”” PASS [expected FAIL] mediatest_medialist_serialize_empty


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-004.html:
  â”” PASS [expected FAIL] appendMedium_correctly_appends_medium_to_empty_MediaList

  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-004.html:
  â”” PASS [expected FAIL] appendMedium_correctly_appends_medium_to_nonempty_MediaList


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-002.html:
  â”” PASS [expected FAIL] deleteMedium_removes_correct_medium


  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList must be primary interface of sheet.media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] Stringification of sheet.media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "mediaText" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "length" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "item(unsigned long)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling item(unsigned long) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "appendMedium(CSSOMString)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling appendMedium(CSSOMString) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "deleteMedium(CSSOMString)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling deleteMedium(CSSOMString) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] StyleSheet interface: attribute media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] StyleSheet interface: sheet must inherit property "media" with the proper type


  â–¶ PASS [expected FAIL] /css/cssom/medialist-dynamic-001.html

@bors-servo retry

@bors-servo try=wpt-2020

@bors-servo retry

@bors-servo r+

@bors-servo retry

That still sounds like a good improvement.

@bors-servo r+

@bors-servo r+

I agree this would be a good improvement. It will require some way of indicating the desired backend (D3D or GL) when creating the OpenXrDiscovery struct, and restructuring some of the code like this to support non-windows platforms.

@bors-servo r+

@bors-servo r+

thread 'main' panicked at 'attempt to subtract with overflow', /Users/jdm/src/libmzx/src/lib.rs:2347:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:50
   3: libmzx::decrypt_and_fix_offset
             at /Users/jdm/src/libmzx/src/lib.rs:2347
   4: libmzx::load_world
             at /Users/jdm/src/libmzx/src/lib.rs:2468
   5: capture::run
             at ./capture/src/main.rs:63
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

What are examples of ways electron apps need to interact with the content being rendered?

Can we rename this engine to zinc?

zinc stands for zinc is not chrome

@bors-servo r+

Hello, Please has anyone tried to run servo on redox os?

By default it would require redox support in https://github.com/rust-windowing/winit/ and https://github.com/servo/surfman. I'm not sure if Redox has any support for GL or EGL yet, which is a prerequirement.

Try cargo +nightly-2020-07-27 build instead.

More concretely, those are test results found under tests/wpt/metadata-layout-2020/.

@bors-servo r+ Thanks!

That sounds like you're using a different nightly version of rustc than https://github.com/servo/servo/blob/master/rust-toolchain.

@bors-servo retry

Might as well use and_then instead of unwrapping here.

Same as previous comment: let's use if let instead.

Let's do this instead:

if let Some(owner) = rule.parent_stylesheet().get_owner() {
    stylesheets_owner_from_node(owner.upcast::<Node>())
        .invalidate_stylesheets();
}

@bors-servo r+

Diff in /repo/components/script/dom/cssrulelist.rs at line 109:
             .get_owner()
             .map(DomRoot::downcast::<HTMLElement>)
             .flatten();
-        let loader = owner.as_ref().map(|element| StylesheetLoader::for_element(&**element));
(B+        let loader = owner
(B+            .as_ref()
(B+            .map(|element| StylesheetLoader::for_element(&**element));
(B         let new_rule = css_rules.with_raw_offset_arc(|arc| {
             arc.insert_rule(
                 &parent_stylesheet.shared_lock,
Run `./mach fmt` to fix the formatting

@bors-servo try=wpt

I believe that owner.as_ref().map(|element| StylesheetLoader::for_element(&**element)); might work.