profile
viewpoint
Josh Matthews jdm Rural Ontario http://www.joshmatthews.net/blog/ Cette danse n'est pas pour tout le monde.

jdm/asknot 220

Ask not what Mozilla can do for you but what you can do for Mozilla.

glennw/servo-shell 181

Proof of concept HTML/CSS/JS browser UI for Servo

brson/rust-sdl 171

SDL bindings for Rust

jdm/bugsahoy 69

A landing page to make finding relevant bugs easier for new Mozilla contributors.

jdm/accountable-refcell 13

std::cell::RefCell with more useful error messages.

jdm/bindings-workshop 8

Exercises and slides for "Fluent Rust Bindings for C APIs" workshop from Rust Belt Rust

brson/llvm 7

Temporary fork of LLVM for Rust

jdm/accessible 3

Abstraction layer over platform accessibility APIs for Rust programs.

jdm/blackhole-dashboard 2

*distracting flailing motions*

Pull request review commentservo/core-foundation-rs

Test that copying system fonts doesn't change the url

 extern {     fn CTFontCreateWithFontDescriptor(descriptor: CTFontDescriptorRef, size: CGFloat,                                       matrix: *const CGAffineTransform) -> CTFontRef;     //fn CTFontCreateWithFontDescriptorAndOptions-    //fn CTFontCreateUIFontForLanguage+    #[cfg(test)]

Why is this only for tests?

jrmuizel

comment created time in an hour

Pull request review commentservo/core-foundation-rs

Test that copying system fonts doesn't change the url

 fn copy_font() {     assert_eq!(font.family_name(), "Zapf Dingbats"); } +#[test]+fn copy_system_font() {+    let small = unsafe {+        CTFont::wrap_under_create_rule(+        CTFontCreateUIFontForLanguage(kCTFontSystemDetailFontType, 19., std::ptr::null())

nit: indentation.

jrmuizel

comment created time in an hour

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentservo/core-foundation-rs

Make sure we can round trip data fonts through descriptors.

@bors-servo r+

jrmuizel

comment created time in 3 hours

PullRequestReviewEvent

pull request commentservo/core-foundation-rs

Expand and correct osx versions.

@bors-servo r+

jrmuizel

comment created time in 4 hours

pull request commentservo/servo

Sync WPT with upstream (26-10-2020)

@bors-servo retry

  • #23290
servo-wpt-sync

comment created time in 8 hours

pull request commentservo/servo

Sync WPT with upstream (26-10-2020)

@bors-servo r+

servo-wpt-sync

comment created time in 9 hours

push eventservo-wpt-sync/servo

Josh Matthews

commit sha 0907b3deedeb2ced4c4899efb8b8ee5d98b9d07c

Add 2020 failure.

view details

push time in 9 hours

issue commentservo/media

Implement HRTF support

https://github.com/mrDIMAS/hrtf https://crates.io/crates/hrtf

jdm

comment created time in 9 hours

issue closedjdm/libmzx

Player falls through customblocks

From DEATHROAD in https://www.digitalmzx.com/show.php?id=1277. I suspect the "move player south" command might be misbehaving.

closed time in a day

jdm

issue commentjdm/libmzx

Player falls through customblocks

This is probably fixed by a758066c69f0879d80a68ce060af99d611bbf0fe.

jdm

comment created time in a day

issue commentjdm/libmzx

Implement substring operations

Used by https://www.digitalmzx.com/show.php?id=1711

jdm

comment created time in a day

issue closedjdm/libmzx

best3d4 doesn't render correctly

https://www.digitalmzx.com/show.php?id=511

Original: Screen Shot 2020-08-15 at 12 41 37 PM

libmzx: Screen Shot 2020-08-15 at 12 41 46 PM

closed time in a day

jdm

issue commentjdm/libmzx

best3d4 doesn't render correctly

Fixed by d604ddedb791c18815f4e422072f89b983c1f167.

jdm

comment created time in a day

issue closedjdm/libmzx

MOVE PLAYER command doesn't do any collision detection

This also means that the "blocked" label is only used when the player tries to move beyond the boundaries of the board.

closed time in a day

jdm

issue commentjdm/libmzx

MOVE PLAYER command doesn't do any collision detection

Fixed by a758066c69f0879d80a68ce060af99d611bbf0fe.

jdm

comment created time in a day

push eventjdm/libmzx

Josh Matthews

commit sha e5c4b3b677c241277c8ed2ddf77d11a10606ec76

Fix loading boards/robots for zip worlds with uppercase hex representations.

view details

Josh Matthews

commit sha a758066c69f0879d80a68ce060af99d611bbf0fe

Make move player command do simple collision detection.

view details

Josh Matthews

commit sha d604ddedb791c18815f4e422072f89b983c1f167

Add reverse board scan.

view details

push time in a day

push eventjdm/mzxplay

Josh Matthews

commit sha b46dc02a5deef4df3983c2edcb04494a8c998573

Update view after updating board.

view details

push time in a day

issue openedjdm/libmzx

MOVE PLAYER command doesn't do any collision detection

This also means that the "blocked" label is only used when the player tries to move beyond the boundaries of the board.

created time in a day

issue closedjdm/mzxscreen

Panic when rendering

https://www.digitalmzx.com/show.php?id=497

thread 'main' panicked at 'range end index 672024 out of range for slice of length 672000', capture/src/main.rs:23:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::slice::slice_end_index_len_fail
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/slice/mod.rs:3152
   3: <core::ops::range::Range<usize> as core::slice::SliceIndex<[T]>>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3352
   4: core::slice::<impl core::ops::index::IndexMut<I> for [T]>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3137
   5: <capture::Framebuffer as libmzx::render::Renderer>::put_pixel
             at ./capture/src/main.rs:23
   6: libmzx::render::draw_char
             at /Users/jdm/src/libmzx/src/render.rs:606
   7: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:203
   8: capture::render_game
             at ./capture/src/main.rs:198
   9: capture::run
             at ./capture/src/main.rs:153
  10: capture::main
             at ./capture/src/main.rs:220
  11: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

closed time in 2 days

jdm

issue commentjdm/mzxscreen

Panic when rendering

Fixed by https://github.com/jdm/libmzx/commit/56ade15ed026fd6931a5e0e43cf7bc20c542a0ba

jdm

comment created time in 2 days

push eventjdm/libmzx

Josh Matthews

commit sha 56ade15ed026fd6931a5e0e43cf7bc20c542a0ba

Don't draw message line outside of window bounds.

view details

push time in 2 days

push eventjdm/libmzx

Josh Matthews

commit sha bc7ce6782b915909a4dd9f6ec9728833c58f6713

Don't draw message line outside of window bounds.

view details

push time in 2 days

issue openedjdm/mzxscreen

Panic when rendering

https://www.digitalmzx.com/show.php?id=497

thread 'main' panicked at 'range end index 672024 out of range for slice of length 672000', capture/src/main.rs:23:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::slice::slice_end_index_len_fail
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/slice/mod.rs:3152
   3: <core::ops::range::Range<usize> as core::slice::SliceIndex<[T]>>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3352
   4: core::slice::<impl core::ops::index::IndexMut<I> for [T]>::index_mut
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3137
   5: <capture::Framebuffer as libmzx::render::Renderer>::put_pixel
             at ./capture/src/main.rs:23
   6: libmzx::render::draw_char
             at /Users/jdm/src/libmzx/src/render.rs:606
   7: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:203
   8: capture::render_game
             at ./capture/src/main.rs:198
   9: capture::run
             at ./capture/src/main.rs:153
  10: capture::main
             at ./capture/src/main.rs:220
  11: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

created time in 2 days

pull request commentservo/servo

Sync WPT with upstream (24-10-2020)

@bors-servo r+

servo-wpt-sync

comment created time in 2 days

push eventservo-wpt-sync/servo

Josh Matthews

commit sha 978921e5625dcc15d92c30db9dded013ccae72d3

Add 2020 failures.

view details

push time in 2 days

push eventservo/servo

Josh Matthews

commit sha b7ccbab1d09412c1250dbad21e317f00f8099fa7

Pin git revisions of dependencies that aren't compatible in newer revisions.

view details

Josh Matthews

commit sha 280e2b1ca4d1616c3da1d65abcef02a7fc60bf66

Fix deprecation warnings.

view details

push time in 3 days

PR opened servo/servo

Pin bluetooth devices.

The lack of a pinned revision in this manifest makes it harder for people to experiment with using libsimpleservo from other projects.

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchservo/servo

branch : jdm-patch-46

created branch time in 3 days

pull request commentjrmuizel/raqote

Update font-kit.

@jrmuizel Ping?

jdm

comment created time in 3 days

pull request commentservo/servo

Sync WPT with upstream (23-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 3 days

pull request commentservo/servo

Sync WPT with upstream (23-10-2020)

@bors-servo r+

servo-wpt-sync

comment created time in 3 days

push eventservo-wpt-sync/servo

Josh Matthews

commit sha cfd69f70154c2bc81e367ef69bf30477eeb97275

Add 2020 failures.

view details

push time in 3 days

PR opened google/oss-fuzz

Update primary contact for Servo

Replacing #4560.

+1 -1

0 comment

1 changed file

pr created time in 4 days

push eventjdm/oss-fuzz

Josh Matthews

commit sha 119e8c736402c59eebabdf507d1c1fc158aa2b50

Update primary contact for Servo

view details

push time in 4 days

pull request commentservo/servo

Sync WPT with upstream (22-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 4 days

pull request commentservo/rust-smallvec

Add SmallVec::append method

@bors-servo r+

mbrubeck

comment created time in 4 days

issue openedjdm/libmzx

Panic placing object on board

https://www.digitalmzx.com/show.php?id=2154

godot:mzxscreen jdm$ RUST_BACKTRACE=1 ./random.sh a
    Finished dev [unoptimized + debuginfo] target(s) in 0.26s
     Running `target/debug/capture image.png output.json unzipped/KKbday3/KKBDAY3.mzx`
Capturing board 1: gameplay
thread 'main' panicked at 'index out of bounds: the len is 4160 but the index is 4160', /Users/jdm/src/libmzx/src/lib.rs:445:27
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic_bounds_check
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:62
   3: <usize as core::slice::SliceIndex<[T]>>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3285
   4: core::slice::<impl core::ops::index::Index<I> for [T]>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/mod.rs:3126
   5: <alloc::vec::Vec<T> as core::ops::index::Index<I>>::index
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/alloc/src/vec.rs:2012
   6: libmzx::Board::put_at
             at /Users/jdm/src/libmzx/src/lib.rs:445
   7: libmzx::board::put_at
             at /Users/jdm/src/libmzx/src/board.rs:112
   8: libmzx::board::put_thing
             at /Users/jdm/src/libmzx/src/board.rs:101
   9: libmzx::robot::run_one_command
             at /Users/jdm/src/libmzx/src/robot.rs:1480
  10: libmzx::robot::update_robot
             at /Users/jdm/src/libmzx/src/robot.rs:413
  11: libmzx::board::update_board
             at /Users/jdm/src/libmzx/src/board.rs:186
  12: capture::run
             at ./capture/src/main.rs:141
  13: capture::main
             at ./capture/src/main.rs:220
  14: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

created time in 5 days

pull request commentservo/core-foundation-rs

Expose CTFontDescriptorCreateCopyWithAttributes

@bors-servo r+

jrmuizel

comment created time in 5 days

pull request commentservo/servo

Sync WPT with upstream (20-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 6 days

issue closedjdm/libmzx

Panic decrypting FRED2.MZX

https://www.digitalmzx.com/show.php?id=342

thread 'main' panicked at 'attempt to subtract with overflow', /Users/jdm/src/libmzx/src/lib.rs:2347:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:50
   3: libmzx::decrypt_and_fix_offset
             at /Users/jdm/src/libmzx/src/lib.rs:2347
   4: libmzx::load_world
             at /Users/jdm/src/libmzx/src/lib.rs:2468
   5: capture::run
             at ./capture/src/main.rs:63
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

closed time in 6 days

jdm

issue commentjdm/libmzx

Panic decrypting FRED2.MZX

Fixed by a1a53cdb09261db7e4cba506e631dec7a0d92f1e.

jdm

comment created time in 6 days

push eventjdm/libmzx

Josh Matthews

commit sha a1a53cdb09261db7e4cba506e631dec7a0d92f1e

Fix underflow when decrypting some worlds.

view details

push time in 6 days

issue commentjdm/libmzx

Panic decrypting FRED2.MZX

Also https://www.digitalmzx.com/show.php?id=965

jdm

comment created time in 6 days

issue closedservo/servo

What about the Servo Foundation?

Is there a plan to create a foundation to support Servo development? I plan to use some crates (pathfinder, etc.), but I'm worried about the future of the Servo project. Maybe I could donate or contribute if the project needs help. Do you plan to organize an independent browser development?

closed time in 7 days

XX

issue closedjdm/mzxscreen

Issues with zip files

https://www.digitalmzx.com/show.php?id=2496

     Running `target/debug/populate download.zip output.json`
Fetching https://www.digitalmzx.com/search.php?browse=ALL&page=27
Fetching https://www.digitalmzx.com/show.php?id=2496
Fetching https://www.digitalmzx.com/download/2496/2cb1088a453e9a49b73d8ec43274b4aba3f7c81a7f4abc2b5431be23900033ec/
error: open zip entry PUN1.MZX failed
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `7`,
 right: `0`', populate/src/main.rs:104:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

closed time in 8 days

jdm

issue commentjdm/mzxscreen

Issues with zip files

Fixed by b1ff894c085108313c7b6114f4be172e053dec62.

jdm

comment created time in 8 days

push eventjdm/mzxscreen

Josh Matthews

commit sha b1ff894c085108313c7b6114f4be172e053dec62

Use unzipper that avoids panics.

view details

push time in 8 days

issue openedjdm/libmzx

Support smzx mode

created time in 8 days

issue closedjdm/libmzx

Panic rendering doors

https://www.digitalmzx.com/show.php?id=698

Capturing board 1: Freaktown
thread 'main' panicked at 'internal error: entered unreachable code', /Users/jdm/src/libmzx/src/lib.rs:1396:14
stack backtrace:
   0: std::panicking::begin_panic
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:497
   1: libmzx::door_from_param
             at /Users/jdm/src/libmzx/src/lib.rs:1396
   2: libmzx::render::char_from_id
             at /Users/jdm/src/libmzx/src/render.rs:730
   3: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:130
   4: capture::render_game
             at ./capture/src/main.rs:198
   5: capture::run
             at ./capture/src/main.rs:153
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233

closed time in 8 days

jdm

issue commentjdm/libmzx

Panic rendering doors

This is #15.

jdm

comment created time in 8 days

issue openedjdm/libmzx

Panic rendering doors

https://www.digitalmzx.com/show.php?id=698

Capturing board 1: Freaktown
thread 'main' panicked at 'internal error: entered unreachable code', /Users/jdm/src/libmzx/src/lib.rs:1396:14
stack backtrace:
   0: std::panicking::begin_panic
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/std/src/panicking.rs:497
   1: libmzx::door_from_param
             at /Users/jdm/src/libmzx/src/lib.rs:1396
   2: libmzx::render::char_from_id
             at /Users/jdm/src/libmzx/src/render.rs:730
   3: libmzx::render::render
             at /Users/jdm/src/libmzx/src/render.rs:130
   4: capture::render_game
             at ./capture/src/main.rs:198
   5: capture::run
             at ./capture/src/main.rs:153
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233

created time in 8 days

push eventjdm/mzxplay

Josh Matthews

commit sha 567b656db27310ace835d4e33bb9470a394d7df8

Ignore invalid board exits.

view details

push time in 8 days

push eventjdm/libmzx

Josh Matthews

commit sha a65bc7770d9f048d6171d4de2dc58b41c2b438af

Incomplete support for loading zip archive worlds.

view details

Josh Matthews

commit sha e1915379465d7e0186d1945c99a258a88314a434

Support overlay in zip archive worlds.

view details

Josh Matthews

commit sha 4447f2abc2a9c89b2acb4602679b9a7b84a91ba8

Set board exits in zip worlds.

view details

Josh Matthews

commit sha b75eced2e1978e10406a421aca85a8e66dec7145

Set starting board for zip worlds.

view details

Josh Matthews

commit sha c79a187c88e8ce79c5a4c27d5e2d1a981442e269

More board properties for zip files.

view details

Josh Matthews

commit sha b3ae1e4ef09acefd058bf6cf6dcb10e4db12dcee

Support running Lochronotran 2.

view details

push time in 8 days

issue commentservo/servo

Black Screen: Servo fails to render anything on Xorg drivers

All the known information about this is in this issue.

r1walz

comment created time in 8 days

issue closedjdm/libmzx

Support loading modern mzx worlds

closed time in 8 days

jdm

issue commentjdm/libmzx

Support loading modern mzx worlds

The world files no longer fail to load.

jdm

comment created time in 8 days

issue commentservo/servo

Audit Servo for dependencies on mozilla services

Correct. It is expected they will become public at some point in the future.

asajeffrey

comment created time in 8 days

pull request commentservo/servo

Sync WPT with upstream (17-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 9 days

pull request commentservo/servo

Sync WPT with upstream (17-10-2020)

@bors-servo r+

servo-wpt-sync

comment created time in 9 days

push eventservo-wpt-sync/servo

Josh Matthews

commit sha 94264ad900240e3acbb75bc2f6611409bd91df6c

Add 2020 failures.

view details

push time in 9 days

issue closedservo/servo

`yahoo.com` crashes on Android

Servo crashes on start when I try to open yahoo.com:

D/RustAndroidGlueStdouterr(14544): WARN:servo: Panic hook called.
D/RustAndroidGlueStdouterr(14544): ERROR:servo: Failed to get window position.
D/RustAndroidGlueStdouterr(14544): Failed to get window position. (thread <unnamed>, at /buildslave/rust-buildbot/slave/nightly-dist-rustc-arm-android/build/src/libcore/option.rs:715)
E/Gecko   (14544): mozalloc_abort: Redirecting call to abort() to mozalloc_abort
F/libc    (14544): Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 14560 (m.mozilla.servo)
D/RustAndroidGlueStdouterr(14544): fatal runtime error: failed to initiate panic, error 9

Commit 143dfc879e609603839502d61bc064fba96cc80f, tested on an Odroid XU3 running Android 4.4.4.

closed time in 9 days

mmatyas

issue commentservo/servo

`yahoo.com` crashes on Android

Our android builds don't rely on winit any more, so this can be closed.

mmatyas

comment created time in 9 days

pull request commentservo/servo

Implements StyleSheet.media

@bors-servo r+

ghostd

comment created time in 10 days

pull request commentservo/servo

Implements StyleSheet.media

These test results for layout-2020 need to be updated:

6 unexpected results that are NOT known-intermittents:
  â–¶ Unexpected subtest result in /css/cssom/cssimportrule.html:
  â”” PASS [expected FAIL] StyleSheet : MediaList mediaText attribute should be updated due to [PutForwards]


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-001.html:
  â”” PASS [expected FAIL] mediatest_medialist_serialize_empty


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-004.html:
  â”” PASS [expected FAIL] appendMedium_correctly_appends_medium_to_empty_MediaList

  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-004.html:
  â”” PASS [expected FAIL] appendMedium_correctly_appends_medium_to_nonempty_MediaList


  â–¶ Unexpected subtest result in /css/cssom/medialist-interfaces-002.html:
  â”” PASS [expected FAIL] deleteMedium_removes_correct_medium


  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList must be primary interface of sheet.media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] Stringification of sheet.media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "mediaText" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "length" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "item(unsigned long)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling item(unsigned long) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "appendMedium(CSSOMString)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling appendMedium(CSSOMString) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: sheet.media must inherit property "deleteMedium(CSSOMString)" with the proper type

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] MediaList interface: calling deleteMedium(CSSOMString) on sheet.media with too few arguments must throw TypeError

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] StyleSheet interface: attribute media

  â–¶ Unexpected subtest result in /css/cssom/idlharness.html:
  â”” PASS [expected FAIL] StyleSheet interface: sheet must inherit property "media" with the proper type


  â–¶ PASS [expected FAIL] /css/cssom/medialist-dynamic-001.html
ghostd

comment created time in 11 days

pull request commentservo/servo

Implements StyleSheet.media

@bors-servo retry

ghostd

comment created time in 11 days

pull request commentservo/servo

Implements StyleSheet.media

@bors-servo try=wpt-2020

ghostd

comment created time in 11 days

PR closed servo/servo

Run CSP tests S-needs-rebase S-tests-failed
+2414 -18

43 comments

329 changed files

jdm

pr closed time in 11 days

pull request commentservo/servo

Sync WPT with upstream (15-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 11 days

pull request commentservo/servo

Set CORS preflight requests' `mode` to `cors`

@bors-servo r+

ghostd

comment created time in 12 days

pull request commentservo/servo

Sync WPT with upstream (14-10-2020)

@bors-servo retry

servo-wpt-sync

comment created time in 12 days

issue commentservo/servo

Set CORS preflight requests' `mode` to `cors`.

That still sounds like a good improvement.

CYBAI

comment created time in 12 days

pull request commentservo/servo

Sync WPT with upstream (14-10-2020)

@bors-servo r+

servo-wpt-sync

comment created time in 12 days

push eventservo-wpt-sync/servo

Josh Matthews

commit sha 78764864e68e68a85f864bb33560f72f2a2ee69d

Add 2020 failure.

view details

push time in 12 days

pull request commentservo/core-foundation-rs

Add CFBundleCopyResourcesDirectoryURL

@bors-servo r+

yuhr

comment created time in 12 days

issue commentservo/webxr

Servo should support using OpenXR on Linux via Monado

I agree this would be a good improvement. It will require some way of indicating the desired backend (D3D or GL) when creating the OpenXrDiscovery struct, and restructuring some of the code like this to support non-windows platforms.

RangerMauve

comment created time in 12 days

pull request commentservo/core-foundation-rs

Fix the type of Arc::from_raw().

@bors-servo r+

jrmuizel

comment created time in 12 days

pull request commentservo/core-foundation-rs

Fix the definition of CFAllocatorContext

@bors-servo r+

jrmuizel

comment created time in 13 days

issue openedjdm/libmzx

Panic decrypting FRED2.MZX

thread 'main' panicked at 'attempt to subtract with overflow', /Users/jdm/src/libmzx/src/lib.rs:2347:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/std/src/panicking.rs:475
   1: core::panicking::panic_fmt
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:85
   2: core::panicking::panic
             at /rustc/81dc88f88f92ba8ad7465f9cba10c12d3a7b70f1/library/core/src/panicking.rs:50
   3: libmzx::decrypt_and_fix_offset
             at /Users/jdm/src/libmzx/src/lib.rs:2347
   4: libmzx::load_world
             at /Users/jdm/src/libmzx/src/lib.rs:2468
   5: capture::run
             at ./capture/src/main.rs:63
   6: capture::main
             at ./capture/src/main.rs:220
   7: core::ops::function::FnOnce::call_once
             at /Users/jdm/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:233
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

created time in 13 days

issue commentservo/servo

[meta] Embedding notes 2020

What are examples of ways electron apps need to interact with the content being rendered?

paulrouget

comment created time in 14 days

issue closedservo/servo

Rename this to zinc

Can we rename this engine to zinc?

zinc stands for zinc is not chrome

closed time in 14 days

larsenv

pull request commentservo/servo

Implements Stylesheet.ownerNode

@bors-servo r+

ghostd

comment created time in 16 days

issue closedservo/servo

Servo on Redox

Hello, Please has anyone tried to run servo on redox os?

closed time in 16 days

eshikafe

issue commentservo/servo

Servo on Redox

By default it would require redox support in https://github.com/rust-windowing/winit/ and https://github.com/servo/surfman. I'm not sure if Redox has any support for GL or EGL yet, which is a prerequirement.

eshikafe

comment created time in 16 days

issue commentservo/servo

Compiling libservo as a dependency fails

Try cargo +nightly-2020-07-27 build instead.

hellux

comment created time in 16 days

pull request commentservo/servo

Implements Stylesheet.ownerNode

More concretely, those are test results found under tests/wpt/metadata-layout-2020/.

ghostd

comment created time in 16 days

pull request commentservo/servo

Implements Stylesheet.ownerNode

@bors-servo r+ Thanks!

ghostd

comment created time in 16 days

issue commentservo/servo

Compiling libservo as a dependency fails

That sounds like you're using a different nightly version of rustc than https://github.com/servo/servo/blob/master/rust-toolchain.

hellux

comment created time in 16 days

pull request commentservo/servo

Make hidden input _charset_ check case insensitive

@bors-servo retry

ghostd

comment created time in 17 days

Pull request review commentservo/servo

Implements Stylesheet.ownerNode

 impl StyleSheetMethods for StyleSheet {         self.href.clone()     } +    // https://drafts.csswg.org/cssom/#dom-stylesheet-ownernode+    fn GetOwnerNode(&self) -> Option<DomRoot<Element>> {+        self.downcast::<CSSStyleSheet>().unwrap().get_owner()

Might as well use and_then instead of unwrapping here.

ghostd

comment created time in 17 days

Pull request review commentservo/servo

Implements Stylesheet.ownerNode

 impl CSSStyleRuleMethods for CSSStyleRule {             let mut guard = self.cssrule.shared_lock().write();             let stylerule = self.stylerule.write_with(&mut guard);             mem::swap(&mut stylerule.selectors, &mut s);-            stylesheets_owner_from_node(self.cssrule.parent_stylesheet().owner().upcast::<Node>())+            if self.cssrule.parent_stylesheet().get_owner().is_some() {+                stylesheets_owner_from_node(

Same as previous comment: let's use if let instead.

ghostd

comment created time in 17 days

Pull request review commentservo/servo

Implements Stylesheet.ownerNode

 impl CSSStyleOwner {                 if changed {                     // If this is changed, see also                     // CSSStyleRule::SetSelectorText, which does the same thing.-                    stylesheets_owner_from_node(rule.parent_stylesheet().owner().upcast::<Node>())+                    if rule.parent_stylesheet().get_owner().is_some() {+                        stylesheets_owner_from_node(+                            rule.parent_stylesheet()+                                .get_owner()+                                .unwrap()+                                .upcast::<Node>(),+                        )                         .invalidate_stylesheets();

Let's do this instead:

if let Some(owner) = rule.parent_stylesheet().get_owner() {
    stylesheets_owner_from_node(owner.upcast::<Node>())
        .invalidate_stylesheets();
}
ghostd

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentservo/servo

Make hidden input _charset_ check case insensitive

@bors-servo r+

ghostd

comment created time in 17 days

pull request commentservo/servo

Implements Stylesheet.ownerNode

Diff in /repo/components/script/dom/cssrulelist.rs at line 109:
             .get_owner()
             .map(DomRoot::downcast::<HTMLElement>)
             .flatten();
-        let loader = owner.as_ref().map(|element| StylesheetLoader::for_element(&**element));
(B+        let loader = owner
(B+            .as_ref()
(B+            .map(|element| StylesheetLoader::for_element(&**element));
(B         let new_rule = css_rules.with_raw_offset_arc(|arc| {
             arc.insert_rule(
                 &parent_stylesheet.shared_lock,
Run `./mach fmt` to fix the formatting
ghostd

comment created time in 17 days

pull request commentservo/servo

Implements Stylesheet.ownerNode

@bors-servo try=wpt

ghostd

comment created time in 17 days

pull request commentservo/servo

Implements Stylesheet.ownerNode

I believe that owner.as_ref().map(|element| StylesheetLoader::for_element(&**element)); might work.

ghostd

comment created time in 17 days

more