profile
viewpoint
Katsuya Miyachi int-tt @recruit-tech Japan Tokyo http://integer.xyz/

startedaws-samples/aws-saas-factory-serverless-workshop

started time in 6 days

startedawslabs/aws-config-rules

started time in 7 days

startedawslabs/aws-config-rdk

started time in 7 days

startedaws/containers-roadmap

started time in 22 days

startedquay/quay

started time in a month

startedRiotGames/LoRDeckCodes

started time in a month

push eventint-tt/landing-page

Miyachi Katsuya

commit sha 9997398388eea61d15e80dd40e61a7d1b5689ebd

fix: typo

view details

push time in 2 months

MemberEvent

push eventint-tt/landing-page

Miyachi Katsuya

commit sha 82835b638221a00e2390456a18c34f5fd45c8969

feat: add button message

view details

push time in 2 months

push eventint-tt/landing-page

Miyachi Katsuya

commit sha 0dd08ab46304c8e0ab557196c37d282dd8a12264

feat: add button message

view details

push time in 2 months

push eventint-tt/landing-page

Miyachi Katsuya

commit sha 87da9db180a3d84cdfb482d1c74fcf9b22c2fc98

fix: Bring preventDefault first

view details

push time in 2 months

push eventint-tt/landing-page

Miyachi Katsuya

commit sha 8b7cd496ec6ec4d7304592f839a6e347d5d316ba

feat: add priventDefault

view details

push time in 2 months

create barnchint-tt/landing-page

branch : master

created branch time in 2 months

created repositoryint-tt/landing-page

created time in 2 months

startedlocalstack/localstack

started time in 2 months

startedNetflix/NfWebCrypto

started time in 2 months

startedclient9/misspell

started time in 2 months

startedisucon/isucon9-final

started time in 2 months

startedaws/aws-xray-daemon

started time in 2 months

startedlyft/cartography

started time in 2 months

startedduo-labs/cloudmapper

started time in 2 months

startedawslabs/smithy

started time in 2 months

startedboto/botocore

started time in 2 months

startedterraform-providers/terraform-provider-google

started time in 2 months

startedGoogleCloudPlatform/k8s-config-connector

started time in 2 months

Pull request review commentconcourse/concourse

feat: enable dns message compression

 func (config DNSConfig) Server() (*dns.Server, error) { 		for _, server := range resolvConf.Servers { 			response, _, err := client.Exchange(r, fmt.Sprintf("%s:%s", server, resolvConf.Port)) 			if err == nil {-				w.WriteMsg(response)+				response.Compress = true

私は2つの理由で大丈夫だと認識しています。

  • Dockerの内部DNSも常に圧縮をしているため。 https://github.com/docker/libnetwork/blob/master/resolver.go#L537
  • ライブラリの内部で圧縮可能かどうか検査しているため https://github.com/miekg/dns/blob/master/msg.go#L767
int-tt

comment created time in 2 months

startedtenntenn/isucontools

started time in 3 months

starteddylanaraps/pure-sh-bible

started time in 3 months

pull request commentconcourse/concourse

feat: enable dns message compression

Thanks!!!

int-tt

comment created time in 3 months

PR opened concourse/concourse

feat: enable dns message compression

fixed: #4478

+2 -1

0 comment

1 changed file

pr created time in 3 months

issue openedconcourse/concourse

DNS response returns uncompressed when using Concourse Worker DNS

Bug Report

Worker DNS does not do Message compression when returning a response, so it returns with a large response

Steps to Reproduce

execute task https://gist.github.com/int-tt/e814b3886fc362ce2d03c11f2a86956d#file-use-worker-dns-yaml

Expected Results

execute task or use inttt/concourse:dev-set-compress image https://gist.github.com/int-tt/e814b3886fc362ce2d03c11f2a86956d#file-external-dns-yaml

DNS reponse with message compression returned

; <<>> DiG 9.14.3 <<>> ecr-emulate.lnteger.dev @8.8.8.8
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 15180
;; flags: qr rd ra; QUERY: 1, ANSWER: 7, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;ecr-emulate.lnteger.dev.       IN      A

;; ANSWER SECTION:
ecr-emulate.lnteger.dev. 3      IN      CNAME   proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev.
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.1
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.2
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.3
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.4
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.5
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 3 IN A 192.168.0.6

;; Query time: 8 msec
;; SERVER: 8.8.8.8#53(8.8.8.8)
;; WHEN: Sat Sep 21 11:05:47 UTC 2019
;; MSG SIZE  rcvd: 205

Actual Results

DNS reponse with no message compression returned

; <<>> DiG 9.14.3 <<>> ecr-emulate.lnteger.dev
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 28183
;; flags: qr rd ra; QUERY: 1, ANSWER: 7, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;ecr-emulate.lnteger.dev.       IN      A

;; ANSWER SECTION:
ecr-emulate.lnteger.dev. 2      IN      CNAME   proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev.
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.1
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.2
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.3
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.4
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.5
proxy-ap-n-proxylb-1r9iukj5vmg6a-733833415.lnteger.dev. 2 IN A 192.168.0.6

;; Query time: 9 msec
;; SERVER: 172.19.0.4#53(172.19.0.4)
;; WHEN: Sat Sep 21 10:58:30 UTC 2019
;; MSG SIZE  rcvd: 563

Additional Context

When running on docker-compose, it is confirmed that the packet flows as follows

DNS Query flow

Version Info

  • Concourse version: 5.5.1
  • Deployment type (BOSH/Docker/binary): Dokcer (use https://github.com/concourse/concourse-docker/blob/master/docker-compose.yml)
  • Infrastructure/IaaS: anywhere

created time in 3 months

push eventint-tt/concourse

int

commit sha 560023d8c7f347e8b8b2503f6c730d1dd41f540f

feat: enable dns message compression Signed-off-by: int <kattu0426@gmail.com>

view details

push time in 3 months

create barnchint-tt/concourse

branch : dns-response-compress

created branch time in 3 months

fork int-tt/concourse

Concourse is a container-based continuous thing-doer written in Go and Elm.

https://concourse-ci.org

fork in 3 months

startedmiekg/dns

started time in 3 months

startedcloudfoundry/guardian

started time in 3 months

push eventint-tt/dicon

Miyachi Katsuya

commit sha 9bcc87c5cd911828f37d86ef153fcd9e85747728

feat: update vendor

view details

push time in 3 months

fork int-tt/dicon

DICONtainer Generator for go.

fork in 3 months

startedterraform-providers/terraform-provider-helm

started time in 3 months

fork int-tt/helm

The Kubernetes Package Manager

https://helm.sh

fork in 3 months

startedisucon/isucon9-qualify

started time in 3 months

more