A Filecoin Network Monitoring and Analysis System
filecoin-project/sentinel-visor 12
capturing on-chain state for the filecoin network
Go package providing a column-centric data structure for aggregating data.
A version of reflect.DeepEqual that includes reasons for failing inequality checks
filecoin-project/sentinel-drone 5
An analytics capture agent for lotus daemon which is forked from Telegraf (https://github.com/influxdata/telegraf) to support custom input/output plugins.
Embedded RDF (historical)
RDF for chess positions
A Go package implementing relations between crisp time intervals
A client-side linked data explorer for use with the Talis Platform
push eventfilecoin-project/FIPs
commit sha 3ced054beae378840ac3d3c35bd064ab976d27ce
Move fip 0008 to last call
commit sha d6cab188dab7c6763eaf7018747ca1a6e99f078b
move fip 13 to last call
commit sha e082284c9fbbfc54b61650445823804a0efb4adf
Merge pull request #97 from filecoin-project/jen/fip0008 Move fip 0008 to& 0013 to last call
push time in 36 minutes
push eventfilecoin-project/FIPs
commit sha d6cab188dab7c6763eaf7018747ca1a6e99f078b
move fip 13 to last call
push time in an hour
push eventfilecoin-project/FIPs
commit sha fe536b795ca6879f32cdefd59cb7d5129c552df2
adding serialization and format
commit sha 9f0167860fd700e92dbfffd04d9cf143ec1df3a5
adding proofs input
commit sha 68944661cf38276f65b75b57c44adc49f509c2b4
correction
commit sha 7291b1d4d270693b0c091a6345a5bb74976d9114
links to implem
commit sha f7bcce4139bbcb0b9bbe35a02be5b15bbf1dd937
incentives
commit sha b057745e3ff5f66fd702e956a0da7e88fa666d76
authors
commit sha 6db88a7d5cdf26462f130b78d6e05b56e39442ad
Merge pull request #87 from filecoin-project/jen/fip0012 Move fip-0012 to Accepted
commit sha 0de5cb56f38b21c1cc0fcb285be6a376e7a18ec9
feat: add rust public API notes
commit sha 928611152b8876b11a57f2b2bea7e26b2331d736
feat: add notes on naive padding as implemented
commit sha 92461a31a361f744447a5413a1d9ae9f340081a0
fix: replace typo and make a clarification
commit sha cb89e9affe338a86e3932e39fc548250a36e3b3c
Update FIP-0014 to Accepted
commit sha 5ab54f271a87b3c759c21dc36948c033f105ac4d
Merge pull request #88 from filecoin-project/arajasek-patch-1 Update FIP-0014 to Accepted
commit sha d6fd69863905481f8e15a350d915e79b01982ebd
Merge pull request #2 from cryptonemo/fip13 feat: add rust public API notes
commit sha 457df202718ac115e3a3412ed24dda75ca5c0993
Merge pull request #82 from nikkolasg/fip13 IPP spec supplement
commit sha 8dc4db6f63e87b6203903d37236f786a83abc844
Editing
commit sha 846f415f279e9b404d05605dfe131f0afd141d64
Move to last call
commit sha d7bfbf38a899a24351bb92d14de2c14362c3a6a8
Update max PoReps
commit sha 1f29098cb3fa8fbda83ce4f1a6baf11a2ec48919
Review Response
commit sha 33b437a551d7bee806f4aceb2bb683371423ef42
Add some test cases
commit sha 80a23e927085d4fbfb739855f186e39c9714a2d1
Merge pull request #94 from filecoin-project/complete-fip-00013 FIP 00013 Proposing Last Call
push time in an hour
push eventfilecoin-project/FIPs
commit sha 35bc04820b2675c788bc794171a3303d53ee09fe
move fip 13 to last call
push time in an hour
push eventfilecoin-project/FIPs
commit sha 8dc4db6f63e87b6203903d37236f786a83abc844
Editing
commit sha 846f415f279e9b404d05605dfe131f0afd141d64
Move to last call
commit sha d7bfbf38a899a24351bb92d14de2c14362c3a6a8
Update max PoReps
commit sha 1f29098cb3fa8fbda83ce4f1a6baf11a2ec48919
Review Response
commit sha 33b437a551d7bee806f4aceb2bb683371423ef42
Add some test cases
commit sha 80a23e927085d4fbfb739855f186e39c9714a2d1
Merge pull request #94 from filecoin-project/complete-fip-00013 FIP 00013 Proposing Last Call
push time in an hour
PR merged filecoin-project/FIPs
Editing FIP 0013, adding some last mile details, proposing last call
pr closed time in an hour
push eventfilecoin-project/FIPs
commit sha 33b437a551d7bee806f4aceb2bb683371423ef42
Add some test cases
push time in an hour
Pull request review commentfilecoin-project/FIPs
FIP-0008: draft potential test cases.
Thus, such changes must be delivered through a major version upgrade to the acto This proposal retains the existing non-batch `PreCommitSector` method, so mining operations need not change workflows due to this proposal (but _should_ in order to enjoy the reduced gas costs). ## Test Cases-Test cases will accompany implementation.++Test cases will accompany implementation. Suggested scenarios include:++1. PreCommitSectorBatch with # of sectors 10, with all preconditions succeeding => OK.+2. PreCommitSectorBatch with # of sectors 1, with all preconditions succeeding => OK and gas cost similar to PreCommitSector.+3. PreCommitSectorBatch with # of sectors 33, with all preconditions succeeding => failure due to violation of maximum sector count (32).+4. PreCommitSectorBatch with empty sector array, with all preconditions succeeding => failure?+5. PreCommitSectorBatch with # of sectors 10, with insufficient (starting) balance to carry out pledge 1 => failure and state untouched.+6. PreCommitSectorBatch with # of sectors 10, with insufficient balance to carry out pledge 10 => failure and state untouched.+7. PreCommitSectorBatch with # of sectors 32, all sectors with deals => OK and deals activated.
Deals aren't activated until ProveCommit so for this to make sense this test should include subsequent prove commit.
comment created time in 2 hours
push eventfilecoin-project/FIPs
commit sha 1f29098cb3fa8fbda83ce4f1a6baf11a2ec48919
Review Response
push time in 2 hours
push eventfilecoin-project/FIPs
commit sha 83a0ddad83174041988849c4f275d5e5ec0a4558
Update FIPS/fip-0008.md
push time in 2 hours
Pull request review commentfilecoin-project/FIPs
FIP-0008: draft potential test cases.
Thus, such changes must be delivered through a major version upgrade to the acto This proposal retains the existing non-batch `PreCommitSector` method, so mining operations need not change workflows due to this proposal (but _should_ in order to enjoy the reduced gas costs). ## Test Cases-Test cases will accompany implementation.++Test cases will accompany implementation. Suggested scenarios include:++1. PreCommitSectorBatch with # of sectors 10, with all preconditions succeeding => OK.+2. PreCommitSectorBatch with # of sectors 1, with all preconditions succeeding => OK and gas cost similar to PreCommitSector.+3. PreCommitSectorBatch with # of sectors 33, with all preconditions succeeding => failure due to violation of maximum sector count (32).+4. PreCommitSectorBatch with empty sector array, with all preconditions succeeding => failure?+5. PreCommitSectorBatch with # of sectors 10, with insufficient (starting) balance to carry out pledge 1 => failure and state untouched.+6. PreCommitSectorBatch with # of sectors 10, with insufficient balance to carry out pledge 10 => failure and state untouched.+7. PreCommitSectorBatch with # of sectors 32, all sectors with deals => OK and deals activated.+8. PreCommitSectorBatch with # of sectors 32, one deal in sector 20 => OK and deal activated.+9. ...
comment created time in 2 hours
Pull request review commentfilecoin-project/FIPs
Semantics will be similar to those of `ProveCommitSector` with the following pro #### Scale and limits -The number of sectors that may be pre-committed in a single aggregation starts-from 50 (TODO) and a maximum of 203 (TODO)+The number of sectors that may be proven in a single aggregation+is a minimum of 12 and a maximum of 204++MaxProveCommitDuration, the enforced delay between pre-commit and prove-commit is also increased from 1 day + PreCommitChallengeDelay to 6 days + PreCommitChallengeDelay. This does not impact security of the system it only increases the possible time pre-commits remain on chain before expiry. See the section about incentives for motivation.++#### Gas calculations++Similar to existing PoRep gas charges, gas values will be determined from empirical measurements of aggregate proof validation on representative hardware. Each PoRep count corresponding to a power of two snark count will be assigned to a gas table. See the "Proof scheme changes" section for discussion on padding to the next power of two for motivation. The number of sectors proven in a call to `ProveCommitSectorAggregated` will be rounded up to the nearest number in the table to calculate the gas value. Currently the table looks like this (subject to change)++- 12 PoReps (128 snarks): 300M+- 13-25 PoReps (256 snarks): 300M+- 26-51 PoReps (512 snarks): 350M+- 52-102 PoReps (1024 snarks): 350M+- 103-204 PoReps (2048 snarks): 350M
These gas values will be finalized after lotus integration using the existing lotus-bench methodology for gas estimation.
comment created time in 3 hours
startedpixie-labs/pixie
started time in 7 hours
pull request commentfilecoin-project/FIPs
FIP-0008: draft potential test cases.
Great, I will plan to include these as actors generated test vectors once the framework is finished.
@anorth you can help by writing any of these as vm tests during implementation.
comment created time in 2 days
PR opened filecoin-project/FIPs
These would likely translate to test vectors.
pr created time in 2 days
Pull request review commentfilecoin-project/FIPs
Semantics will be similar to those of `ProveCommitSector` with the following pro #### Scale and limits -The number of sectors that may be pre-committed in a single aggregation starts-from 50 (TODO) and a maximum of 203 (TODO)+The number of sectors that may be proven in a single aggregation+is a minimum of 12 and a maximum of 203++MaxProveCommitDuration, the enforced delay between pre-commit and prove-commit is also increased from 1 day + PreCommitChallengeDelay to 6 days + PreCommitChallengeDelay. This does not impact security of the system it only increases the possible time pre-commits remain on chain before expiry. See the section about incentives for motivation.++#### Gas calculations++Similar to existing PoRep gas charges, gas values will be determined from empirical measurements of aggregate proof validation on representative hardware. Each PoRep count corresponding to a power of two snark count will be assigned to a gas table. See the "Proof scheme changes" section for discussion on padding to the next power of two for motivation. The number of sectors proven in a call to `ProveCommitSectorAggregated` will be rounded up to the nearest number in the table to calculate the gas value. Currently the table looks like this (subject to change)++- 12 PoReps (128 snarks): 300M
Yes, agreed, sorry was thinking about it incorrectly at the time. Thanks!
comment created time in 3 days
issue commentfilecoin-project/FIPs
i also perfect filecoin 2.0, the "PLUS" titile make more confusion.
comment created time in 4 days
startedblushft/go-diagrams
started time in 6 days
startedmingrammer/diagrams
started time in 6 days
issue commentmvdan/gofumpt
break long lines when it's appropriate to do so
Another example, this time in rustfmt (Rust is like Go in that if conditions do not require parens):
if isThisAReallyReallyReallyReallyReallyLongVariableName == 123 && doReallyReallyReallyLongNamedCheck() == true {
return true;
}
becomes:
if isThisAReallyReallyReallyReallyReallyLongVariableName == 123
&& doReallyReallyReallyLongNamedCheck() == true
{
return true;
}
comment created time in 7 days
issue commentmvdan/gofumpt
break long lines when it's appropriate to do so
That's also a good point. Splitting one line into two, when two lines adds ambiguity, is not good. The example I shared would need another extra newline to become non-ambiguous again. I worry that it might be tricky to determine "will the new format look ambiguous", though.
Though I still think the line on its own should be left alone, even if the ambiguity wasn't an issue.
comment created time in 7 days
issue commentmvdan/gofumpt
break long lines when it's appropriate to do so
Agreed, something about putting the second condition on the next line and indented to the same level as the if body irks me a bit
prettier turns this:
if (isThisAReallyLongVariableName === 123 && doReallyLongNamedCheck() === true) {
return true
}
into this:
if (
isThisAReallyLongVariableName === 123 &&
doReallyLongNamedCheck() === true
) {
return true;
}
which works for me, but only because of the way the parens are used here, which is optional and completely uncommon in Go code
comment created time in 7 days
issue commentmvdan/gofumpt
break long lines when it's appropriate to do so
I've been trying to keep the env var on at all times, and I've been finding it's a tiny bit too aggressive - especially on indented code. For example, it did this change:
typeInfo := info.TypeOf(x)
- if typeInfo != types.Typ[types.String] && typeInfo != types.Typ[types.UntypedString] {
+ if typeInfo != types.Typ[types.String] &&
+ typeInfo != types.Typ[types.UntypedString] {
return true
}
This definitely feels wrong. The indented line does reach to column 110 if we count tabs as 8 columns, but the non-indented line is just 86 characters, and we end up with two tiny lines of 41 and 44 non-indented characters.
The new format is not wrong per se, but I lean towards the old format, and I don't think there's anything wrong with it. I think it falls under "goes over the limit, but splitting the line isn't better".
I'll probably tweak the heuristic to be a bit less aggressive on indented lines.
comment created time in 7 days
issue commentmvdan/gofumpt
add newlines in nested expressions to fix confusing indentation
In cases where the inner closing token is on a separate line, and its indentation is messed up in a way that could confuse the reader
Here are some examples of two indentation levels joined into a single line, which don't result in confusing indentation. I don't think gofumpt should modify these programs.
var _ = foo(x, y, bar(
"baz",
), z)
var _ = foo{x: y, bar: bar{
z: "baz",
}}
The difference here is that both indentation levels begin on the same line, but also end on the same line.
comment created time in 7 days