facebook/draft-js 19112
A React framework for building text editors.
draft-js-plugins/draft-js-plugins 3618
React Plugin Architecture for Draft.js including Slack-Like Emojis, FB-Like Mentions and Stickers
Draft-JS experiments with drag&drop, resizing, tooltips, WIP
A React framework for building text editors.
Immutable persistent data collections for Javascript which increase efficiency and simplicity.
Adds static typing to JavaScript to improve developer productivity and code quality.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
The hackable text editor
Status bar for Atom
Next generation vim support for atom
push eventdagster-io/dagster
commit sha 0cbb8dece60140ca5f409abdd3bd9fa0b2aace82
[dagit] Quick search component (experiment) Summary: An initial stab at a "quick search" feature for Dagit, which could be used to quickly navigate to objects. - Aims to ingest a GraphQL query payload for the repositories, though if we want to be able to search data outside of repos, I'd need to add that too. It may make sense for such a feature to live on the back end if we want it to do lots of heavy lifting. - Uses fuse.js for fuzzy searching, I haven't investigated how much this adds to the built JS but I didn't want to try rolling something like this myself. - Currently searches on pipelines, plus the schedules, runs, and assets that apply to those pipelines. Feedback very welcome. If this is something that doesn't seem like it would be useful in Dagit, by all means say so! Video inline. Test Plan: Run storybook, use SearchDialog story to perform searches and stuff. Reviewers: bengotow, alangenfeld, catherinewu, prha, dgibson Reviewed By: bengotow Differential Revision: https://dagster.phacility.com/D4876
push time in 6 hours
push eventdagster-io/dagster
commit sha 4396161679ee0b8024e0f9eac63ba3da9fd11b07
[dagit] Replace Legend tables with Table Summary: Replace uses of Legend/LegendColumn/RowContainer/Row with regular HTML tables, in this case striped Blueprint tables. The idea here is to have consistent table views throughout Dagit, and remove some of the excess chrome of the card-style rows, by using the standard from the Blueprint library. I'll need to do some tidying to elimiante some of the repeated styles. I also assume that in some cases we'll want to tweak some of the cell widths. Also: - For pagination controls, show them if needed, but show disabled buttons instead of hiding them - Tweak some of the rendering for schedule row cells, especially in the execution params flyout Test Plan: View table views throughout Dagit (Runs, Assets, Schedules, pipeline Overview, etc.) and verify proper table rendering. Reviewers: bengotow, alangenfeld, prha, sashank Reviewed By: bengotow Differential Revision: https://dagster.phacility.com/D4871
push time in 7 hours
push eventdagster-io/dagster
commit sha 2baa707c9b4361f2433b21bfeccbffbf429c8045
[dagit] Move fonts to src Summary: Move fonts to `src/fonts` so that they can be imported directly in the dagit CRA and in storybook. Test Plan: Run dagit and storybook. Verify that fonts render as expected in both. Reviewers: bengotow Reviewed By: bengotow Differential Revision: https://dagster.phacility.com/D4885
push time in 8 hours
push eventdagster-io/dagster
commit sha 4ff17fdc635f19a7d8f1f7d4770e3d284294be73
[dagit] Tag truncation on Playground Summary: Repair long tags on the Playground view by setting a max-width. Overflow should render an ellipsis. I also did some tidying around how the tags are rendered, including using blueprint colors and fixing some flex issues. Test Plan: View Playground, add some tags including very long tags. Verify correct rendering. Shrink window horizontally, verify proper wrapping behavior. View Runs page, verify same. Reviewers: bengotow, catherinewu, prha, sashank Reviewed By: prha Differential Revision: https://dagster.phacility.com/D4864
push time in 4 days
push eventdagster-io/dagster
commit sha 17c5334963d4fc283f7f013722f05b989fa0bdd1
[dagit] Create workspace routes Summary: This is a first step in the plan to add more specificity to Dagit URLs. Create workspace-level pages to serve as index pages for repositories, namespaced to `/workspace` paths. - `/workspace`, an overview of all loaded repositories - `/workspace/[repo@location]/pipelines`, all pipelines in a repo - `/workspace/[repo@location]/solids`, all solids in a repo - `/workspace/[repo@location]/schedules`, all schedules in a repo - `/workspace/pipelines/[pipeline_name]`, either a redirect page (if only one matching pipeline name found across repos) or a disambiguation page with all matches displayed These pages aren't currently linked anywhere in Dagit. There are several more disambiguation pages to create (solids, schedules) and I expect that it would probably be good to have a page with all partition sets for a given repo. Screenshots and overall plan below. Test Plan: View all pages above, verify proper rendering and behavior. Reviewers: bengotow, alangenfeld, dgibson, prha Reviewed By: bengotow Differential Revision: https://dagster.phacility.com/D4821
push time in 6 days
push eventdagster-io/dagster
commit sha 00202b96f1c4792e188e0ecba3ebd7bee6038a00
[dagit] Create instance routes Summary: Move instance-level sections of Dagit to `/instance` paths. - `/assets/...` -> `/instance/assets/...` - `/scheduler` -> `/instance/scheduler` - `/runs?...` -> `/instance/runs?...` I also created a `FallthroughRoot` to perform redirects for the existing routes, in case of any paths that I missed converting, or in case users have bookmarks. In the future, these should probably be cleaned up. There are a couple other paths to move to the `/instance` path space as well, but this gets things moving. Test Plan: View all affected routes in Dagit, verify correct loading, rendering, redirects. Reviewers: bengotow, alangenfeld, dgibson, prha Reviewed By: bengotow Differential Revision: https://dagster.phacility.com/D4828
push time in 6 days
issue commentdagster-io/dagster
Partition backfill UI: should be able to easily select range of partitions to backfil
I believe this is part of @bengotow's ongoing work.
comment created time in 7 days
issue closeddagster-io/dagster
dagit - format pyspark stack traces
Pyspark stack traces aren't indented so it makes it difficult to locate the exception cause, eg:
Ideally, the stack trace would be formatted with indents/tabs, the same as the raw stderr output eg:
at org.apache.spark.sql.DataFrameWriter.runCommand(DataFrameWriter.scala:676)
at org.apache.spark.sql.DataFrameWriter.saveToV1Source(DataFrameWriter.scala:285)
at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:271)
at org.apache.spark.sql.DataFrameWriter.jdbc(DataFrameWriter.scala:515)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
at py4j.Gateway.invoke(Gateway.java:282)
at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
at py4j.commands.CallCommand.execute(CallCommand.java:79)
at py4j.GatewayConnection.run(GatewayConnection.java:238)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 55
at org.apache.xbean.asm6.ClassReader.<init>(ClassReader.java:166)
at org.apache.xbean.asm6.ClassReader.<init>(ClassReader.java:148)
at org.apache.xbean.asm6.ClassReader.<init>(ClassReader.java:136)
at org.apache.xbean.asm6.ClassReader.<init>(ClassReader.java:237)
at org.apache.spark.util.ClosureCleaner$.getClassReader(ClosureCleaner.scala:49)
at org.apache.spark.util.FieldAccessFinder$$anon$3$$anonfun$visitMethodInsn$2.apply(ClosureCleaner.scala:517)
at org.apache.spark.util.FieldAccessFinder$$anon$3$$anonfun$visitMethodInsn$2.apply(ClosureCleaner.scala:500)
at scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:733)
at scala.collection.mutable.HashMap$$anon$1$$anonfun$foreach$2.apply(HashMap.scala:134)
at scala.collection.mutable.HashMap$$anon$1$$anonfun$foreach$2.apply(HashMap.scala:134)
at scala.collection.mutable.HashTable$class.foreachEntry(HashTable.scala:236)
at scala.collection.mutable.HashMap.foreachEntry(HashMap.scala:40)
at scala.collection.mutable.HashMap$$anon$1.foreach(HashMap.scala:134)
at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:732)
at org.apache.spark.util.FieldAccessFinder$$anon$3.visitMethodInsn(ClosureCleaner.scala:500)
at org.apache.xbean.asm6.ClassReader.readCode(ClassReader.java:2175)
at org.apache.xbean.asm6.ClassReader.readMethod(ClassReader.java:1238)
at org.apache.xbean.asm6.ClassReader.accept(ClassReader.java:631)
at org.apache.xbean.asm6.ClassReader.accept(ClassReader.java:355)
at org.apache.spark.util.ClosureCleaner$$anonfun$org$apache$spark$util$ClosureCleaner$$clean$14.apply(ClosureCleaner.scala:307)
at org.apache.spark.util.ClosureCleaner$$anonfun$org$apache$spark$util$ClosureCleaner$$clean$14.apply(ClosureCleaner.scala:306)
at scala.collection.immutable.List.foreach(List.scala:392)
closed time in 7 days
tekumara
issue commentdagster-io/dagster
dagit - format pyspark stack traces
This looks like it should be fixed.
comment created time in 7 days
issue commentdagster-io/dagster
Enable dagit to connect to a remote gql server
Do you have some more details about what you have in mind?
comment created time in 10 days
issue closeddagster-io/dagster
Enable filtering on "step failed" event types
As I'm debugging a job in dagit, I want to be able to focus on the steps that failed. Maybe the solution is generic filtering on event types, but didn't want to be to prescriptive.
closed time in 10 days
sryza
issue commentdagster-io/dagster
Enable filtering on "step failed" event types
Possible to do this with text filter.
comment created time in 10 days
issue closeddagster-io/dagster
Config Editor: Color in config sections/bubbles that are missing *required* configuration
e.g. in this state it would be very cool to have the "read_csv" solid be a different color to indicate the it requires configuration. eventually we could do "click to scaffold" or something.
closed time in 10 days
schrockn
issue commentdagster-io/dagster
Execution plan errors hidden on small screens
Do you have a screenshot of this?
comment created time in 10 days
issue closeddagster-io/dagster
Dagit playground solid sub-selection solid explorer view doesn't expand composite solids
When I am using the dagit playground. I am trying to figure out what solids to sub-select, however, when I use the provided solid explorer I cannot expand composite solids.
closed time in 10 days
asingh16
issue commentdagster-io/dagster
Dagit playground solid sub-selection solid explorer view doesn't expand composite solids
Can use the solid selection DSL to accomplish this.
comment created time in 10 days
issue closeddagster-io/dagster
Config editor sidebar hides text for long strings
Maybe we can add a disclosure triangle to hide this or something?
closed time in 10 days
natekupp
issue commentdagster-io/dagster
Sort order is ambiguous in the absence of a created_at timestamp for PipelineRun
@mgasner Do you have more context on this?
comment created time in 10 days
issue commentdagster-io/dagster
Preset loading has surprising behavior
Could potentially pop the merged config into a new tab.
comment created time in 10 days
issue closeddagster-io/dagster
Figure out a good strategy for generating test data for jest
https://dagster.phacility.com/D127#3362
closed time in 10 days
mgasner
issue commentdagster-io/dagster
Figure out a good strategy for generating test data for jest
I've got ideas here based on what I've done in the past. Closing this in favor of a larger discussion.
comment created time in 10 days
issue closeddagster-io/dagster
Need a sensible subset selection story for composites
Composites aren't expandable here, so we should find another way to visually indicate that the solid is a composite:
closed time in 10 days
natekupp
issue commentdagster-io/dagster
Need a sensible subset selection story for composites
Workaround is now to use the DSL in solid selection view.
comment created time in 10 days
issue closeddagster-io/dagster
Handling broken pipelines in dagit
Right now when something is wrong w/ a pipeline definition, dagit will spew the error to the console and refuse to load.
Instead, it would be great to show the dagit UI and highlight which pipeline in the repository is broken
closed time in 10 days
natekupp
issue commentdagster-io/dagster
Handling broken pipelines in dagit
Closing in favor of #2718.
comment created time in 10 days
push eventdagster-io/dagster
commit sha f24d430fcbd0ff88fde91436c75d3b1bf282782f
[dagit] Standardize font-family usage Summary: Resolves #3093 Standardize our fonts throughout Dagit. Makes things look a lot nicer. - Use the default font-family supplied by Blueprint, with `-apple-system` as the primary choice. For recent MacOS versions, this should be San Francisco. - Define a standard monospace font-family for usage everywhere, Source Code Pro. We use this in some places, but there is a fairly loose mixture of this override and the regular `monospace` default, which in most cases is sadly Courier New. Test Plan: View Dagit on latest Chrome, Firefox, Safari on MacOS 10.15.7. Verify that fonts are consistent throughout Dagit. Reviewers: bengotow, alangenfeld, prha, sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D4803
push time in 10 days
issue closeddagster-io/dagster
Monospace consistency in dagit
We have a mismash of system monospace and Source Code Pro, sometimes right next to each other. Let's make everything Source Code Pro, with a fallback to system fonts.
closed time in 10 days
hellendag
push eventdagster-io/dagster
commit sha 2fd4374e38897783db73c91e8b7a81a4e145f931
[dagit] Allow copying filter state to URL on Run page Summary: Resolves #3029 A handful of changes to the behavior of query parameters on the Run page in dagit: - Allow setting filter values via URL params: - `steps` to set the step selection on the Gantt chart - `logs` to set log filter tokens - `levels` to set the levels filter on the logs view - Add a "Copy URL" button to the logs toolbar to allow deep linking to the current filter state - Add the ability to use a `query:` token in the logs filter, since it's used implicitly by step selection I also made the jest config not insist on tests being in `__tests__` directories, since I think this is the kind of thing that adds friction to creating new tests (which we need more of). Test Plan: View a Run page. Modify filters, and click "Copy URL" in each case, then open that copied URL to a new tab and verify correct filter initialization. - Change step selection, using wildcard characters and multiple steps. Verify proper filtering behavior. - Change log filter tokens, verify same. - Change levels, verify same. - Change a combination of these, verify same. Reviewers: bengotow, yuhan, catherinewu, sashank Reviewed By: sashank Differential Revision: https://dagster.phacility.com/D4765
push time in 10 days
issue closeddagster-io/dagster
Add ability to link to a specific pipeline run including current filters
User requested ability to create links that contain the currently selected filters to make it easier to share specific views. As an extension, it could be nice to also be able to link specific events or sets of events.
closed time in 10 days
catherinewu
push eventdagster-io/dagster
commit sha 9b9c78e332f976f196d17a38c9840f53679d94cd
[Docs] 0.9.15
push time in 11 days
created tagdagster-io/dagster
A data orchestrator for machine learning, analytics, and ETL.
created time in 11 days
push eventdagster-io/dagster
commit sha ffc2566c127ce585e3cb0e5fcc18a1c8e4319a76
0.9.15
push time in 11 days
created tagdagster-io/dagster
A data orchestrator for machine learning, analytics, and ETL.
created time in 11 days
push eventdagster-io/dagster
commit sha da8a0069f1c949afb2fbd246d6693800be5951b2
0.9.15pre0
push time in 11 days
push eventdagster-io/dagster
commit sha 9ac36b9274f1796ce4ecf3560cce518f8d905b8b
Changes for 0.9.15 Test Plan: None Reviewers: alangenfeld Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D4795
push time in 11 days
push eventdagster-io/dagster
commit sha 84a37997d50899deda766a5f53abae58542a36b0
[dagit] Use parent snapshot ID to determine current-ness of snapshot Summary: In cases where a snapshot is a child of a parent snapshot, use that information to determine whether to tag the snapshot as "current". That is, if a parent snapshot is the current state of the pipeline, it should be labeled as "current". - Add nullable `parentSnapshotId` to `PipelineSnapshot` in GraphQL - Break apart PipelineNav - Query for parent snapshot in snapshot pipeline nav, with a brief loading state and a set width to avoid making the tabs jump Test Plan: View snapshot pages for different pipelines, verify that the "current"/"snapshot" tag shows up correctly. Reviewers: alangenfeld, max, sandyryza Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D4789
push time in 11 days
push eventdagster-io/dagster
commit sha fd3a0fcd54790b121bc2375377c4ae6c3b8ef528
[dagit] Restore nav height fix for Safari Summary: Resolves #3106 Looks like I accidentally dropped the fix from https://github.com/dagster-io/dagster/commit/585b2130ee033fcbc666dac6dbd3b283c6f09f95 when creating `TopNav`. Restore it. Test Plan: View Runs page in Safari, verify that the nav height stays correct. Shrink the window horizontally, verify that tabs wrap to the second line. Reviewers: bengotow, alangenfeld, prha, sashank Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D4790
push time in 11 days
issue closeddagster-io/dagster
Dagit 0.9.14 top nav collapses in Safari
Summary
The updated top nav in Dagit 0.9.14 collapses on the Runs and Partitions tabs in Safari. This was previously reported in #2891 and fixed in https://github.com/dagster-io/dagster/commit/585b2130ee033fcbc666dac6dbd3b283c6f09f95.
Steps to reproduce
- Using Dagit 0.9.14, select a pipeline and click on Runs or Partitions in the top nav.
What is the current bug behaviour?
The top nav bar collapses vertically (height-wise) after the Runs or Partitions tabs are loaded.
What is the expected correct behaviour?
The top nav bar should remain a constant height when the Runs or Partitions tabs are active, matching their inactive state.
Relevant logs and/or screenshots
Playground tab in Safari (correct height):
Runs tab in Safari (incorrect height):
Runs tab in Chrome (correct height):
Versions
- Safari 14.0 (14610.1.28.1.9) on macOS 10.14.6
- Chrome 86.0.4240.80
- Dagster 0.9.14
- Dagit 0.9.14
closed time in 11 days
kinghuang
push eventdagster-io/dagster
commit sha 703aa09985bf3e0adff0789284813c424089f008
[dagit] Allow snapshots to re-run even if the snapshot ID is mismatched Summary: When viewing a run, we currently disable the re-execution button if the snapshot ID doesn't match the current snapshot ID for that pipeline in the active repo. An issue here is that a run on a solid subselection will produce a different snapshot ID from the parent pipeline, which means this button will always end up being disabled when trying to re-run that subselection. Instead, show a tooltip warning but allow the re-execution to occur. Test Plan: View a historical run, verify that the warning appears and that I am able to re-execute the run. Reviewers: bengotow, alangenfeld, sandyryza, max Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D4784
push time in 12 days
push eventdagster-io/dagster
commit sha 67e4e6b1a7a2823cecc1028c8b24b88ba483d039
[dagit] Remove "historical" tag on Run table Summary: On the Run table, the "historical" tag is inaccurate for pipelines that aren't on the active repository, since we're currently just checking whether the snapshot ID matches the current snapshot ID for the pipeline name in the current repo. Let's just remove it for now. Also "Pipeline snapshot" -> "Pipeline definition" on the Run table header. Test Plan: View /runs, verify changes. Reviewers: bengotow, alangenfeld, sandyryza, max Reviewed By: sandyryza Differential Revision: https://dagster.phacility.com/D4782
push time in 12 days
issue closeddagster-io/dagster
Empty pipelines in dagit bring up the "This is a large dag" box
closed time in 13 days
mgasner
issue commentdagster-io/dagster
Empty pipelines in dagit bring up the "This is a large dag" box
#3094 has a bit more detail and some repro steps, so I'll close this in favor of that one.
comment created time in 13 days
issue openeddagster-io/dagster
Monospace consistency in dagit
We have a mismash of system monospace and Source Code Pro, sometimes right next to each other. Let's make everything Source Code Pro, with a fallback to system fonts.
created time in 13 days
push eventdagster-io/dagster
commit sha 078f1b92bfc8b7ea43a0ac0c646eb4ccf549c034
Delete unnecessary file, fix run row link Summary: Forgot to remove `/snapshot` root, ended up with a broken path on the run link. Test Plan: View Runs, verify proper link on row component. Reviewers: bengotow, alangenfeld, sashank Reviewed By: alangenfeld Differential Revision: https://dagster.phacility.com/D4766
push time in 13 days
push eventdagster-io/dagster
commit sha f7dd62ecd9e2c8b9360801142ada59b516ab08f9
[dagit] Separate snapshot and current pipeline permalinks Summary: Separate a specific snapshot view from the main view of a pipeline. The snapshot permalink will have two tabs: - Definition, for the state of the snapshot - Runs, for runs specific to that snapshot ID It will also display "Historical snapshot" or "Current snapshot" tags, depending on whether the viewed snapshot ID is the current one for the pipeline. Breadcrumbing allows navigation back to the main pipeline page, where one can use the Playground and view all runs for the pipeline. Stacked on top of the change that modifies how the Runs table rows are rendered. Screenshots below. Test Plan: View all existing `pipeline@snapshot` paths, verify that they display the correct breadcrumbs, tag, and tabs. View `pipeline`-only paths, verify same. Reviewers: bengotow, alangenfeld, sashank, catherinewu, prha Reviewed By: bengotow Subscribers: alangenfeld Differential Revision: https://dagster.phacility.com/D4709
push time in 13 days