profile
viewpoint
Alexander Kotliarskyi frantic Facebook Seattle, WA https://frantic.im Software engineer and UX zealot at @facebook, chief color officer.

airbnb/native-navigation 3122

Native navigation library for React Native applications

corporateshark/WCMCommander 332

:computer: WCM Commander

frantic/copy-with-syntax 20

Copy buffer content with syntax highlighting

frantic/delphi-tdd-example 16

Test Driven Development example with Delphi and DUnit

frantic/app-host 8

Windows App Host makes it easy to run any script or program as a Windows service

frantic/anyconnect-dark 4

Dark OSX menu bar assets for Cisco AnyConnect VPN.

frantic/clippy 4

Clippy for Google Docs and Chrome

frantic/domash 2

Legendary Domash!

frantic/dotfiles 1

My own dotfiles

frantic/alfred-workflows 0

Alfred 2 Workflows

push eventfrantic/expo

Alexander Kotliarskyi

commit sha 26765ef3458bd99f1a5459986694273b3701fd6b

Fix regex

view details

push time in 5 days

PR opened expo/expo

Reviewers
Allow property names to contain numbers

This should bring the check more inline with the comment in Analytics.ts

Why

Fixes #8390 and adds the property name to the error message for easier debugging.

How

Fixed the regex.

Test Plan

'test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);    // OK
'_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);   // Fail
'1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);  // Fail
'a1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/); // OK
+2 -2

0 comment

1 changed file

pr created time in 5 days

push eventfrantic/expo

Alexander Kotliarskyi

commit sha 0c672b91452926f8012d4421d1dc9d54ba95338a

Allow property names to contain numbers This should bring the check more inline with [the comment](https://github.com/expo/expo/blob/6f0c3a53651063627b88ee322b9ef8a5344995d8/packages/expo-firebase-analytics/src/Analytics.ts#L130) in `Analytics.ts`

view details

push time in 5 days

issue openedexpo/expo

expo-firebase-analytics doesn't allow number in property names

🐛 Bug Report

Environment

<!-- In your terminal run expo diagnostics and paste the output here. -->

<!-- Please also let us know about your app's target (iOS, Android, Client, Standalone, ExpoKit) -->

Steps to Reproduce

Analytics.setUserProperties({hello_11: 'test'});

Expected Behavior

User property is set

Actual Behavior

Promise returned from setUserProperties is rejected with:

"Error: Invalid user-property name specified. Should contain 1 to 24 alphanumeric characters or underscores. The name must start with an alphabetic character"

Looking into the code

This comment claims the property name should be alphanumeric and not start with number. However the actual code rejects all properties with numbers.

created time in 5 days

startedromejs/rome

started time in 8 days

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha 7bb76e5d82c96a0b428be376355fbf4720e87f2a

HTTPS

view details

push time in 14 days

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha b0ef37921dc955a4d6af993eb7820b596d24e7e5

Add Joking Hazard

view details

push time in a month

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha 7765bdf0b438f9e91bacffa3cb3346514fb32a43

Use stats subdomain

view details

push time in a month

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha bdfca176195999041efbd21982e34e47e7795e9e

Add Plausible

view details

push time in a month

fork frantic/expo

An open-source platform for making universal native apps with React. Expo runs on Android, iOS, and the web.

https://docs.expo.io/

fork in a month

PR opened sarat-ravi/elixir-formatter

Improve the way mix invoked in concurrent VSCode environment

Looks like there was a change in how VSCode works.

In the past this extension used to call document.save() before invoking mix format. The format function simply operated on saved file.

Now VSCode invokes the extension before it saves the file, and document.save() waits for this extension to finish, but the extension is waiting for document.save(). VSCode shows infinite spinner dialog.

This PR fixes the behavior. I switched exec with spawn and use stdio to send the unformatted and receive the formatted file. I've also improved the error message so it should be easier to figure out what's not working.

Because I had to make some substantial changes, I also backported #6 by @maennchen (which fixes #5). #4 should be fixed too because spawn accepts arguments as array of strings and does the escaping for us.

I've tried my best to do some reasonable testing. mixFormatArgs and formatterCwd options are still working and I documented the new mixCommandPath.

+80 -29

0 comment

2 changed files

pr created time in 2 months

push eventfrantic/elixir-formatter

Alex Kotliarskyi

commit sha ca09648a24033abab73f769c8d555c3a2c5151a7

Use stdin for mix format to avoid race condition while saving

view details

Jonatan Männchen

commit sha b4e0f8f081db04aecd581e185f4cc771edcdc936

Support mix not in $PATH (#5)

view details

Alex Kotliarskyi

commit sha a45687639e6b106a5ed6e7f80dd0069b208c9cbd

Add documentation for mixCommandPath option

view details

push time in 2 months

startedcaddyserver/caddy

started time in 2 months

startedredwoodjs/redwood

started time in 2 months

push eventfrantic/tinacms.org

Alexander Kotliarskyi

commit sha 216b105aab74521dd20e61e62184c4a981766ff3

Update from TinaCMS

view details

push time in 2 months

push eventfrantic/tinacms.org

Alexander Kotliarskyi

commit sha c044013ddef3358a2b20f1d04dab9fcd35089f86

Update from TinaCMS

view details

push time in 2 months

push eventfrantic/tinacms.org

Alexander Kotliarskyi

commit sha a47332fc9060491549ad7e68a5b8a301d5f4705d

Update from TinaCMS

view details

push time in 2 months

push eventfrantic/tinacms.org

Alexander Kotliarskyi

commit sha 0a4cf32f3be044f3abfed3019fd1c1447f150db0

Update from TinaCMS

view details

push time in 2 months

fork frantic/tinacms.org

Organization site for general info, documentation, blogs & contribution guidelines.

https://tinacms.org/

fork in 2 months

startedmprokopov/docker-egeya

started time in 3 months

more