profile
viewpoint
Alexander Kotliarskyi frantic Facebook Seattle, WA https://frantic.im Software engineer and UX zealot at @facebook, chief color officer. Maker of https://cantunsee.space and https://hacker.gifts

airbnb/native-navigation 3125

Native navigation library for React Native applications

corporateshark/WCMCommander 339

:computer: WCM Commander

frantic/copy-with-syntax 20

Copy buffer content with syntax highlighting

frantic/delphi-tdd-example 14

Test Driven Development example with Delphi and DUnit

frantic/app-host 8

Windows App Host makes it easy to run any script or program as a Windows service

frantic/anyconnect-dark 4

Dark OSX menu bar assets for Cisco AnyConnect VPN.

frantic/clippy 4

Clippy for Google Docs and Chrome

frantic/domash 2

Legendary Domash!

frantic/dotfiles 1

My own dotfiles

frantic/alfred-workflows 0

Alfred 2 Workflows

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha ead1d5d13ab59cf21110e3b8e1e571cf4fc15d96

Move drafts to posts

view details

Alex Kotliarskyi

commit sha 43a7e07345c73401e993528edfb8cf36a01b17f0

Highlight drafts

view details

Alex Kotliarskyi

commit sha 9f28c18b753a01118ceee04839f560d733db3021

Add related posts

view details

push time in 2 months

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha 6e19223ecf9c36156d023dfe116830f244893bb8

[typing]

view details

push time in 2 months

startediaincollins/next-auth

started time in 2 months

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha 54bf6ce4cf2b735790d8097e2624eea59de911b0

[typing]

view details

push time in 2 months

push eventfrantic/frantic.github.io

Alex Kotliarskyi

commit sha dafdfb9ca41fae52a5fb84c90497befa954a7a8e

Draft for "Back to Rails"

view details

Alex Kotliarskyi

commit sha 7ff8a719c19911b75f37d1fb060fce5b64138082

Add scripts to create post and serve content

view details

Alex Kotliarskyi

commit sha dc7675c1682e9b5223da9d6af36f0d185eefe434

[typing]

view details

push time in 2 months

startedbrentvatne/hour-power

started time in 2 months

Pull request review commentexpo/expo

[expo-firebase-analytics] Updates Regex To Allow Numeric Chars

 class FirebaseAnalyticsJS {       !eventName.length ||       eventName.length > 40 ||       eventName[0] === '_' ||-      !eventName.match(/^[A-Za-z_]+$/) ||+      eventName[0].match(/^\d$/) ||+      !eventName.match(/^[A-Za-z_0-9]+$/) ||

Feel free to reuse the regex! I think your PR is more complete, so I've closed mine

thorbenprimke

comment created time in 3 months

PR closed expo/expo

[firebase-analytics] Allow property names to contain numbers Launch-blocking

This should bring the check more inline with the comment in Analytics.ts

Why

Fixes #8390 and adds the property name to the error message for easier debugging.

How

Fixed the regex.

Test Plan

'test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);    // OK
'_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);   // Fail
'1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);  // Fail
'a1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/); // OK
+2 -2

1 comment

1 changed file

frantic

pr closed time in 3 months

pull request commentexpo/expo

[firebase-analytics] Allow property names to contain numbers

#8516 is a more complete solution.

frantic

comment created time in 3 months

push eventfrantic/expo

Alexander Kotliarskyi

commit sha 26765ef3458bd99f1a5459986694273b3701fd6b

Fix regex

view details

push time in 3 months

PR opened expo/expo

Reviewers
Allow property names to contain numbers

This should bring the check more inline with the comment in Analytics.ts

Why

Fixes #8390 and adds the property name to the error message for easier debugging.

How

Fixed the regex.

Test Plan

'test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);    // OK
'_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);   // Fail
'1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/);  // Fail
'a1_test'.match(/^[A-Za-z][[A-Za-z_\d]*$/); // OK
+2 -2

0 comment

1 changed file

pr created time in 3 months

push eventfrantic/expo

Alexander Kotliarskyi

commit sha 0c672b91452926f8012d4421d1dc9d54ba95338a

Allow property names to contain numbers This should bring the check more inline with [the comment](https://github.com/expo/expo/blob/6f0c3a53651063627b88ee322b9ef8a5344995d8/packages/expo-firebase-analytics/src/Analytics.ts#L130) in `Analytics.ts`

view details

push time in 3 months

issue openedexpo/expo

expo-firebase-analytics doesn't allow number in property names

🐛 Bug Report

Environment

<!-- In your terminal run expo diagnostics and paste the output here. -->

<!-- Please also let us know about your app's target (iOS, Android, Client, Standalone, ExpoKit) -->

Steps to Reproduce

Analytics.setUserProperties({hello_11: 'test'});

Expected Behavior

User property is set

Actual Behavior

Promise returned from setUserProperties is rejected with:

"Error: Invalid user-property name specified. Should contain 1 to 24 alphanumeric characters or underscores. The name must start with an alphabetic character"

Looking into the code

This comment claims the property name should be alphanumeric and not start with number. However the actual code rejects all properties with numbers.

created time in 3 months

startedromejs/rome

started time in 3 months

more