profile
viewpoint
Evan Bacon EvanBacon @expo East Palo Alto, California https://twitter.com/baconbrix Bad at programming. Working on Expo and React Native (for web) PWAs. Follow me on Twitter for updates 💙🥓

EvanBacon/AWESOME-REACT-NATIVE-WEB 184

💙 React Native Web patterns, techniques, tips, and tricks ✨

EvanBacon/apple-notes 43

A clone of the Apple Notes app but made universally with Expo

EvanBacon/Cel-Shader 16

SceneKit Cel Shader Example

EvanBacon/app.js-conf 6

Resources from my App.js conf talk

EvanBacon/anime-lorem 5

Anime placeholder photos

EvanBacon/0 2

Empty repo = empty tar = good shim for ignoring packages

EvanBacon/Alien-Vs.-Predator 2

SceneKit AVP Game... Pardon my rage induced naming convention.

EvanBacon/can-it-be-done-in-react-native 2

Examples used in the "Can it be done in React Native?" YouTube series

EvanBacon/Batcave-Virtual-Reality 1

Walk through the batcave in virtual reality. Using SceneKit, Google Maps, Cocoa Pods, Swift 2 and Core Motion.

push eventexpo/expo

Evan Bacon

commit sha 3bdab31c20e80cdd62d100ffa7a1b2fdf94956aa

Comment tips

view details

push time in a day

issue commentexpo/expo

App show "Expo pasted from CoreSimulator" continuously

We don't support iOS 14 yet as it's not released.

huy-lv

comment created time in a day

issue closedexpo/expo

[expo-auth-session] Unable to get Google+Firebase authentication working in standalone app

🐛 Bug Report

Summary of Issue (just a few sentences)

When attempting to follow either of the Google AuthSession demos with Firebase (the one using Token or with IdToken in the Authentication guides.

While this works in development (using the Expo client), I consistently get the following error in my standalone iOS app:

Error 400: invalid request
Invalid parameter value for redirect_uri: Custom schemes cannot have authority: come.googleusercontent.apps.MY_GUID://redirect

I've also tried to set up the Google-services configuration files for the expo-google-signin documentation here: https://docs.expo.io/versions/latest/sdk/google-sign-in/#usage-with-firebase. But this still does not work.

Environment - output of expo diagnostics & the platform(s) you're targeting

Currently only testing on iOS.

Expo CLI 3.21.13 environment info:
    System:
      OS: macOS 10.15.5
      Shell: 5.7.1 - /bin/zsh
    Binaries:
      Node: 12.18.1 - /usr/local/bin/node
      Yarn: 1.22.4 - /usr/local/bin/yarn
      npm: 6.14.5 - /usr/local/bin/npm
    IDEs:
      Xcode: 11.4/11N111s - /usr/bin/xcodebuild
    npmPackages:
      expo: ^38.0.8 => 38.0.8 
      react: ~16.11.0 => 16.11.0 
      react-dom: ~16.11.0 => 16.11.0 
      react-native: https://github.com/expo/react-native/archive/sdk-38.0.0.tar.gz => 0.62.2 
      react-native-web: ~0.11.7 => 0.11.7 
    npmGlobalPackages:
      expo-cli: 3.21.13

Reproducible Demo

Here is how I am setting up Google authentication with AuthSession:

const [request, response, promptAsync] = useAuthRequest(
    {
      responseType: ResponseType.Token,
      clientId: web,
      redirectUri: makeRedirectUri({
        // For usage in bare and standalone
        native: `com.googleusercontent.apps.${
          MY_IOS_GUID
        }://redirect`,
        useProxy,
      }),
      usePKCE: false,
      scopes: [
        "openid",
        "profile",
        "email",
      ],
    },
    discovery
  );

closed time in a day

davitykale

issue commentexpo/expo

[expo-auth-session] Unable to get Google+Firebase authentication working in standalone app

This is a general Google OAuth error, I think it's unrelated to expo-auth-session. See this SO https://stackoverflow.com/questions/16342191/google-oauth-redirect-to-ios-custom-url

I cannot tell from the issue cuz it seems like the error isn't correct:

- Invalid parameter value for redirect_uri: Custom schemes cannot have authority: come.googleusercontent.apps.MY_GUID://redirect
+ Invalid parameter value for redirect_uri: Custom schemes cannot have authority: com.googleusercontent.apps.MY_GUID://redirect
  1. come should be com
  2. Perhaps your auth doesn't allow ://redirect
davitykale

comment created time in a day

pull request commentreact-native-directory/website

update Expo version to 38 and few other packages

Published the latest in @expo/html-elements@0.0.0

Simek

comment created time in 3 days

push eventexpo/expo

Evan Bacon

commit sha a246801b0d9ca7f803261fa533c14e6369927258

Publish @expo/html-elements @expo/html-elements@0.0.0

view details

push time in 3 days

push eventEvanBacon/pillar-valley

Evan Bacon

commit sha 86b574ff5c49a095ea7b433646c4ab8f5ce8dd1a

Removed .shared

view details

Evan Bacon

commit sha 7f720c525d310a273eed74e16b4d20dce4cfad8c

cleanup

view details

Evan Bacon

commit sha dcb0fb3feeb84ac510f9a99c826163cd7989eec0

Move GameObject

view details

Evan Bacon

commit sha 26e0aebf439d85951c2ca8db75006bc53014fae2

Delete FlatMaterial

view details

Evan Bacon

commit sha 26297fb19ebaa80924d07ca172df074fa5eee1b1

Refactor folders out

view details

Evan Bacon

commit sha 64e349f0861318a5028838c2c1067a9257133c3d

Remove Lighting abstraction

view details

Evan Bacon

commit sha a210d2c8477ee7f0a891a43ced63e3ea7225112a

Remove position binding

view details

Evan Bacon

commit sha 79bc5e6085f532ada446c9867331a2c734366b92

Update Game.ts

view details

push time in 3 days

create barnchEvanBacon/pillar-valley

branch : @evanbacon/migrate-to-typescript

created branch time in 3 days

delete branch expo/expo-cli

delete branch : @evanbacon/webpack-config/upgrade-loaders

delete time in 3 days

push eventexpo/expo-cli

Evan Bacon

commit sha 80b9197ef77845984fa589cd53587186fbaff61a

Updated webpack version (#2336) * Updated webpack version * Fixed noop sw * Update index.ts * updated tests

view details

push time in 3 days

PR merged expo/expo-cli

Reviewers
Updated webpack version Platform: web 🧹 chore

How

  • bump expo-cli, xdl, and webpack-config webpack deps
  • bump other deps in webpack-config
  • add react-refresh plugin
  • fix SW register by passing force to copy webpack plugin

Test Plan

  • Built and published a website
    • Lighthouse scores are still at 100
  • Ensure homepage works
  • Ensure SW is registered properly
  • Ensure PWA assets can be generated
  • Test fast refresh with EXPO_WEBPACK_FAST_REFRESH=1 in a blank project and in native-component-list.
  • Test HTTPS works
  • [x] Test Next.js projects continue to work
+776 -1121

0 comment

15 changed files

EvanBacon

pr closed time in 3 days

push eventEvanBacon/icon-builder

Evan Bacon

commit sha 4197324df3d90dfe94511b3af7df0cf870017669

TypeScript

view details

push time in 3 days

push eventEvanBacon/icon-builder

Evan Bacon

commit sha 08f302939929c424b53951e7d3e5ac7cf0297d70

Fixed more emojis

view details

push time in 3 days

push eventEvanBacon/icon-builder

Evan Bacon

commit sha f23e52053a6f0c6bede1177b711e065ed208663a

Fixed flags

view details

push time in 3 days

push eventexpo/expo-cli

Evan Bacon

commit sha 285977ae5ee78f63f00e811db757a9a803241c3a

[webpack-config] Remove yup validation (#2335) * Remove yup - deprecate polyfill option * Updated tests

view details

Evan Bacon

commit sha 79174520f46d53ec64fc28a2a70dbace87b74a15

Merge branch 'master' into @evanbacon/webpack-config/upgrade-loaders

view details

push time in 3 days

push eventexpo/expo-cli

Evan Bacon

commit sha 285977ae5ee78f63f00e811db757a9a803241c3a

[webpack-config] Remove yup validation (#2335) * Remove yup - deprecate polyfill option * Updated tests

view details

push time in 3 days

delete branch expo/expo-cli

delete branch : @evanbacon/webpack-config/update-validation

delete time in 3 days

PR merged expo/expo-cli

[webpack-config] Remove yup validation 🧹 chore
  • yup is not needed.
  • deleted the deprecated polyfill property.
+36 -52

0 comment

7 changed files

EvanBacon

pr closed time in 3 days

issue closedexpo/expo

Chromecast functionality!

Would love an update on how/if you guys are working on Chromecast functionality :) https://expo.canny.io/feature-requests/p/support-for-chromecast

Thanks!

closed time in 4 days

cjcmattsson

issue commentexpo/expo

Chromecast functionality!

We will update the canny if we plan on adding support for this package. You can use Chromecast native SDK by ejecting to the bare-workflow. We are a small team so we're prioritizing improving the bare-workflow rather than making new modules.

Further, have you tried using the JS API for Chromecast? Here is a package that works using the built-in Networking API https://github.com/alxhotel/chromecast-api

cjcmattsson

comment created time in 4 days

push eventexpo/expo

Evan Bacon

commit sha ea08dda831694b5678871ce1a40ebb9e7731334e

Added drawer navigator for larger screens (#9057)

view details

push time in 4 days

delete branch expo/expo

delete branch : @evanbacon/ncl/add-drawer-navigator

delete time in 4 days

PR merged expo/expo

Reviewers
[ncl][chore] Added drawer navigator for larger screens

Why

Wanted to add drawer navigator to NCL so we can test it more often. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. -->

How

Use drawer navigator for desktop and landscape. <!-- How did you build this feature or fix this bug and why? -->

Test Plan

See the web link. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. -->

+147 -52

1 comment

9 changed files

EvanBacon

pr closed time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha f2f693442281e94ad380a7e3ec8e69b21120bef6

updated tests

view details

push time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha a6cfc572ad015147f16a0c859b942cd160d96ee2

Update index.ts

view details

push time in 4 days

PR opened expo/expo-cli

Reviewers
Updated webpack version Platform: web 🧹 chore

How

  • bump expo-cli, xdl, and webpack-config webpack deps
  • bump other deps in webpack-config
  • add react-refresh plugin
  • fix SW register by passing force to copy webpack plugin

Test Plan

  • Built and published a website
    • Lighthouse scores are still at 100
  • Ensure homepage works
  • Ensure SW is registered properly
  • Ensure PWA assets can be generated
  • Test fast refresh with EXPO_WEBPACK_FAST_REFRESH=1 in a blank project and in native-component-list.
  • Test HTTPS works
  • [ ] Test Next.js projects continue to work
+733 -1084

0 comment

12 changed files

pr created time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha 026b3799688eac349d1b800433363972b473b329

Fixed noop sw

view details

push time in 4 days

create barnchexpo/expo-cli

branch : @evanbacon/webpack-config/upgrade-loaders

created branch time in 4 days

PR opened expo/expo-cli

[webpack-config] Remove yup validation 🧹 chore
  • yup is not needed.
  • deleted the deprecated polyfill property.
+36 -52

0 comment

7 changed files

pr created time in 4 days

PR closed expo/expo-cli

Reviewers
Upgrade copy-webpack-plugin to 6.0.1

Regarding to this issue:

https://github.com/expo/expo-cli/issues/2210 related issue

I upgraded the package version. If there are any questions let me know.

+1 -1

4 comments

1 changed file

spoilerdo

pr closed time in 4 days

pull request commentexpo/expo-cli

Upgrade copy-webpack-plugin to 6.0.1

completed in https://github.com/expo/expo-cli/pull/2334 -- in the future please ensure the tests pass and the package can be used locally.

spoilerdo

comment created time in 4 days

issue closedexpo/expo-cli

Upgrade copy-webpack-plugin for the webpack-config npm package

When I ran npm i on an empty expo typescript template I got one moderate vulnerability: image

Currently I use version: 0.12.11 of the @expo/webpack-config npm package. Maybe better to update this in the package itself. copy-webpack-plugin current version is 6.0.1 (which uses version 3.0.0 of serialize-javascript) and the webpack-config package uses 5.0.0.

closed time in 4 days

spoilerdo

issue commentexpo/expo-cli

Upgrade copy-webpack-plugin for the webpack-config npm package

fixed https://github.com/expo/expo-cli/pull/2334

spoilerdo

comment created time in 4 days

delete branch expo/expo-cli

delete branch : @evanbacon/webpack-config/upgrade-copy-webpack-plugin

delete time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha 985702ccbf6604cc19ebeb87a48d55a13fb41e76

Upgraded copy-webpack-plugin (#2334)

view details

push time in 4 days

PR merged expo/expo-cli

Upgraded copy-webpack-plugin Platform: web 🧹 chore

Test Plan

  • Tests will continue to pass
  • Built and deployed a project
  • Added files to web/ and ensured they were copied to web-build
+203 -87

0 comment

4 changed files

EvanBacon

pr closed time in 4 days

create barnchexpo/expo-cli

branch : @evanbacon/webpack-config/update-validation

created branch time in 4 days

PR opened expo/expo-cli

Upgraded copy-webpack-plugin Platform: web 🧹 chore
+203 -87

0 comment

4 changed files

pr created time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha 7f0d1020dee9d5f9b4a342d019ad0e99c1b5ed19

[expo-cli] Combined ID prompts for build and eject (#2313) * Combined ID prompts for build and eject * Move prompt to after validation * Update Eject.ts

view details

push time in 4 days

delete branch expo/expo-cli

delete branch : @evanbacon/expo-cli/prompt-ids

delete time in 4 days

PR merged expo/expo-cli

Reviewers
[expo-cli] Combined ID prompts for build and eject
  • The build:ios bundle ID prompt is awesome, this PR adds the same functionality for Android and shares the methods across expo eject, expo build:android, and expo build:ios
+216 -150

0 comment

5 changed files

EvanBacon

pr closed time in 4 days

PR opened expo/expo

Reviewers
[ncl][chore] Added drawer navigator for larger screens

Why

Wanted to add drawer navigator to NCL so we can test it more often. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. -->

How

Use drawer navigator for desktop and landscape. <!-- How did you build this feature or fix this bug and why? -->

Test Plan

See the web link. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. -->

+147 -52

0 comment

9 changed files

pr created time in 4 days

create barnchexpo/expo

branch : @evanbacon/ncl/add-drawer-navigator

created branch time in 4 days

push eventexpo/expo-cli

Wojciech Kozyra

commit sha 88151801ccef11e05baeafbd3ac7e8633c85e063

fix(expo-cli): use user provided, teamId don't access appleCtx (#2315)

view details

Brent Vatne

commit sha 12e2b05cf7a8823bff587262b2ae7d0d045f76a8

Add CHANGELOG entry for fix

view details

Brent Vatne

commit sha e32aeb5f93c8e4517b36c4356e18b840ca748cf6

[config] Simplify findProjectRootAsync so it just uses package.json and does not swallow config errors

view details

Brent Vatne

commit sha b385a388de6a486be3269352016118338cd9b04c

[expo-cli] Wrap entitlements config eject step in try/catch and warn if it throws

view details

Brent Vatne

commit sha 8a9d17f699c07747c8198d5670eb779006e9b961

Publish - expo-cli@3.21.13

view details

Brent Vatne

commit sha 10907e083a4ce74dac48ec7a90d5df4374f72ea8

[CHANGELOG] Update for new release

view details

Brent Vatne

commit sha c4fed00624298b034e313db62863b23cbd50093e

[expo-cli] Fix ProjectUtils-test

view details

Evan Bacon

commit sha ea085644a624f140e945b2d7cda2ea37487b7d75

Merge branch 'master' into @evanbacon/expo-cli/prompt-ids

view details

push time in 4 days

push eventexpo/expo

Evan Bacon

commit sha f5bead5978c804c8c1526cf35676ecc1cd8db89a

Upgrade to react-native-web@~0.12 (#9023) * react-native-web@~0.12 * Update CHANGELOG.md * Update yarn.lock * Updated jest-expo-enzyme * add patch version * Update package.json

view details

push time in 4 days

delete branch expo/expo

delete branch : @evanbacon/react-native-web/bump-0.12

delete time in 4 days

PR merged expo/expo

Reviewers
Upgrade to react-native-web@~0.12 Platform: web

Why

resolve https://github.com/expo/expo/issues/8064

+61 -107

1 comment

17 changed files

EvanBacon

pr closed time in 4 days

issue closedexpo/expo

Support react-native-web@0.12

  • react-native-web@0.12 maps roughly to react-native@0.62 which we will support in Expo SDK 38.
  • RNW v12 is slightly ahead of RN by way of deprecation, so somethings that have been removed in react-native-web haven't been removed in react-native yet. We can jump ahead of react-native and start removing things immediately.
  • RNW v12 Release Notes

TODO

  • [x] Delete prop types https://github.com/necolas/react-native-web/commit/1ad16930391303da511c98879fa7b2002b28c822 - prop-types are deprecated in react-native - #8675 #8676 #8677 #8678 #8679 #8680 #8681
    • Will leave expo-payments-stripe alone for now since it doesn't have web support.
  • Remove the following modules:
    • AsyncStorage
      • [x] Remove from expo-notifications
      • [x] Remove from NCL https://github.com/expo/expo/pull/9018
    • [x] AlertIOS
    • ActionSheetIOS
      • [x] Remove from NCL
      • [ ] Remove from react-navigation-header-buttons
    • [x] CameraRoll
    • [x] DatePickerAndroid
    • [x] DatePickerIOS
    • [x] ImageEditor
    • [x] ImagePickerIOS
    • [x] ImageStore
    • [x] ListView
    • MaskedViewIOS
    • [x] NavigatorIOS
    • NetInfo
      • [ ] Add legacy web support
      • [x] Integrate module
      • [x] Swap in NCL
    • PickerIOS
    • [x] ProgressBarAndroid
    • [x] ProgressViewIOS
    • [x] PushNotificationsIOS
    • SegmentedControlIOS
      • [x] Add legacy web support
      • [x] Integrate module
      • [x] Swap in NCL
    • Slider
      • [x] Add legacy web support
      • [x] Integrate module
      • [x] Swap in NCL
    • [x] SnapshotViewIOS
    • [x] StatusBarIOS
    • [x] SwipeableListView
    • [x] ToolbarAndroid
    • [x] VibrationIOS
    • ViewPagerAndroid
      • [ ] Add web shim / warning
      • [ ] Integrate module
      • [ ] Swap in NCL
    • WebView
      • [ ] Add legacy web support
      • [ ] Integrate module
      • [ ] Swap in NCL
  • More TBD

closed time in 4 days

EvanBacon

push eventexpo/expo

Evan Bacon

commit sha b1bc6cfff681f118821866c103ebdd0728e52773

Update package.json

view details

push time in 4 days

push eventexpo/expo

Evan Bacon

commit sha 12675d07306e6cfa4be928eb6dea51a69c7e1ac5

add patch version

view details

push time in 5 days

push eventexpo/match-media

Evan Bacon

commit sha b4f0c02a6c2334e345eb8be428f25e20954a276e

Clean up

view details

push time in 5 days

push eventexpo/match-media

Evan Bacon

commit sha e118060baa8ef3f1e23d57543f3b095c33aeb186

Disable native test - broken in RN 62

view details

push time in 5 days

issue closedexpo/match-media

How to work with react-native-unimodules?

I got error

Unable to resolve module `expo/build/ScreenOrientation/ScreenOrientation` from `modules/node_modules/@expo/match-media/build/polyfill.native.js`: expo/build/ScreenOrientation/ScreenOrientation could not be found within the project.

If you are sure the module exists, try these steps:
 1. Clear watchman watches: watchman watch-del-all
 2. Delete node_modules: rm -rf node_modules and run yarn install
 3. Reset Metro's cache: yarn start --reset-cache
 4. Remove the cache: rm -rf /tmp/metro-*

RCTFatal
__28-[RCTCxxBridge handleError:]_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
-[NSRunLoop(NSRunLoop) runMode:beforeDate:]
-[NSRunLoop(NSRunLoop) runUntilDate:]
+[RNSplashScreen show]
-[AppDelegate application:didFinishLaunchingWithOptions:]
-[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:]
-[UIApplication _callInitializationDelegatesForMainScene:transitionContext:]
-[UIApplication _runWithMainScene:transitionContext:completion:]
__111-[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:]_block_invoke
+[_UICanvas _enqueuePostSettingUpdateTransactionBlock:]
-[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:]
-[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:]
__82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke
-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]
__125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke
_performActionsWithDelayForTransitionContext
-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]
-[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:]
-[UIApplication workspace:didCreateScene:withTransitionContext:completion:]
-[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:]
-[FBSSceneImpl _didCreateWithTransitionContext:completion:]
__56-[FBSWorkspace client:handleCreateScene:withCompletion:]_block_invoke_2
__40-[FBSWorkspace _performDelegateCallOut:]_block_invoke
_dispatch_client_callout
_dispatch_block_invoke_direct
__FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__
-[FBSSerialQueue _performNext]
-[FBSSerialQueue _performNextFromRunLoopSource]
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
__CFRunLoopDoSources0
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start
Unable to resolve module `expo/build/ScreenOrientation/ScreenOrientation` from `modules/node_modules/@expo/match-media/build/polyfill.native.js`: expo/build/ScreenOrientation/ScreenOrientation could not be found within the project.

If you are sure the module exists, try these steps:
 1. Clear watchman watches: watchman watch-del-all
 2. Delete node_modules: rm -rf node_modules and run yarn install
 3. Reset Metro's cache: yarn start --reset-cache
 4. Remove the cache: rm -rf /tmp/metro-*

RCTFatal
__28-[RCTCxxBridge handleError:]_block_invoke
_dispatch_call_block_and_release
_dispatch_client_callout
_dispatch_main_queue_callback_4CF
__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
__CFRunLoopRun
CFRunLoopRunSpecific
-[NSRunLoop(NSRunLoop) runMode:beforeDate:]
-[NSRunLoop(NSRunLoop) runUntilDate:]
+[RNSplashScreen show]
-[AppDelegate application:didFinishLaunchingWithOptions:]
-[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:]
-[UIApplication _callInitializationDelegatesForMainScene:transitionContext:]
-[UIApplication _runWithMainScene:transitionContext:completion:]
__111-[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:]_block_invoke
+[_UICanvas _enqueuePostSettingUpdateTransactionBlock:]
-[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:]
-[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:]
__82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke
-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]
__125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke
_performActionsWithDelayForTransitionContext
-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]
-[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:]
-[UIApplication workspace:didCreateScene:withTransitionContext:completion:]
-[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:]
-[FBSSceneImpl _didCreateWithTransitionContext:completion:]
__56-[FBSWorkspace client:handleCreateScene:withCompletion:]_block_invoke_2
__40-[FBSWorkspace _performDelegateCallOut:]_block_invoke
_dispatch_client_callout
_dispatch_block_invoke_direct
__FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__
-[FBSSerialQueue _performNext]
-[FBSSerialQueue _performNextFromRunLoopSource]
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
__CFRunLoopDoSources0
__CFRunLoopRun
CFRunLoopRunSpecific
GSEventRunModal
UIApplicationMain
main
start

CMIIW, I think ScreenOrientation still in expo library and not supported in unimodule?

closed time in 5 days

Jekiwijaya

issue commentexpo/match-media

How to work with react-native-unimodules?

Fixed in 0.0.0-beta.2

Jekiwijaya

comment created time in 5 days

issue closedexpo/match-media

Error on bare app

I get the following error when using it on iOS:

ExceptionsManager.js:44 Error: The Expo SDK requires Expo to run. It appears the native Expo modules are unavailable and this code is not running on Expo. Visit https://docs.expo.io to learn more about developing an Expo project.

Installing expo-screen-orientation and the amending the following import in node_modules/@expo/match-media/build/polyfill.native.js apparently solves the issue:

import { ScreenOrientation } from "expo"; import * as ScreenOrientation from 'expo-screen-orientation';

expo diagnostics:

  Expo CLI 3.20.1 environment info:
    System:
      OS: macOS Mojave 10.14.6
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 12.16.3 - ~/.nvm/versions/node/v12.16.3/bin/node
      Yarn: 1.22.4 - /usr/local/bin/yarn
      npm: 6.14.4 - ~/.nvm/versions/node/v12.16.3/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    IDEs:
      Android Studio: 3.6 AI-192.7142.36.36.6392135
      Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
    npmPackages:
      expo: ~37.0.3 => 37.0.7
      react-native: ~0.61.5 => 0.61.5

closed time in 5 days

emac3

issue commentexpo/match-media

Error on bare app

Fixed in 0.0.0-beta.2

emac3

comment created time in 5 days

issue closedexpo/match-media

Broken after sdk 37 upgrade

Hello,

import '@expo/match-media'; doesnt seem to be working ufter an upgrade from sdk 36 to 37

Screenshot from 2020-04-16 09-21-39

closed time in 5 days

dincozdemir

issue commentexpo/match-media

Broken after sdk 37 upgrade

Fixed in 0.0.0-beta.2

dincozdemir

comment created time in 5 days

push eventexpo/match-media

Evan Bacon

commit sha cdeef524943e0845fdabb4211e97a54bf8a5b340

Publish 0.0.0-beta.2

view details

push time in 5 days

push eventexpo/match-media

Evan Bacon

commit sha 36a1414fe525043e0a1492b07bf1567ffc70197f

Publish 0.0.0-beta.1

view details

push time in 5 days

push eventexpo/match-media

dependabot[bot]

commit sha 30ff9e54e879196019f8a9109b70970e8ef5f732

Bump handlebars from 4.1.2 to 4.7.6 Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.7.6. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.7.6) Signed-off-by: dependabot[bot] <support@github.com>

view details

Evan Bacon

commit sha deb247cfd2eadd93c034da4dd17877a06214df6c

Merge pull request #16 from expo/dependabot/npm_and_yarn/handlebars-4.7.6 Bump handlebars from 4.1.2 to 4.7.6

view details

push time in 5 days

PR merged expo/match-media

Bump handlebars from 4.1.2 to 4.7.6 dependencies

Bumps handlebars from 4.1.2 to 4.7.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md">handlebars's changelog</a>.</em></p> <blockquote> <h2>v4.7.6 - April 3rd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1672">#1672</a> - Switch cmd parser to latest minimist (<a href="https://api.github.com/users/dougwilson">@dougwilson</a></li> </ul> <p>Compatibility notes:</p> <ul> <li>Restored Node.js compatibility</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.5...v4.7.6">Commits</a></p> <h2>v4.7.5 - April 2nd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><del>Node.js version support has been changed to v6+</del> Reverted in 4.7.6</li> </ul> <p>Compatibility notes:</p> <ul> <li><del>Node.js < v6 is no longer supported</del> Reverted in 4.7.6</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.5">Commits</a></p> <h2>v4.7.4 - April 1st, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1666">#1666</a> - Replaced minimist with yargs for handlebars CLI (<a href="https://api.github.com/users/aorinevo">@aorinevo</a>, <a href="https://api.github.com/users/AviVahl">@AviVahl</a> & <a href="https://api.github.com/users/fabb">@fabb</a>)</li> </ul> <p>Compatibility notes:</p> <ul> <li>No incompatibilities are to be expected</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.4">Commits</a></p> <h2>v4.7.3 - February 5th, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1644">#1644</a> - Download links to aws broken on handlebarsjs.com - access denied (<a href="https://api.github.com/users/Tea56">@Tea56</a>)</li> <li>Fix spelling and punctuation in changelog - d78cc73</li> </ul> <p>Bugfixes:</p> <ul> <li>Add Type Definition for Handlebars.VERSION, Fixes <a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1647">#1647</a> - 4de51fe</li> <li>Include Type Definition for runtime.js in Package - a32d05f</li> </ul> <p>Compatibility notes:</p> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/e6ad93ea01bcde1f8ddaa4b4ebe572dd616abfaa"><code>e6ad93e</code></a> v4.7.6</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/2bf4fc6fd3ae3d8f076d628653f284d85faebeb4"><code>2bf4fc6</code></a> Update release notes</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/b64202bc9197307bd785a58693e3820eb9bb41a8"><code>b64202b</code></a> Update release-notes.md</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/c2f1e6203178918569f085e12afdb762cae17fb0"><code>c2f1e62</code></a> Switch cmd parser to latest minimist</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/08e9a11a34c3ad8387a0b85b1334f97cab85191a"><code>08e9a11</code></a> Revert "chore: set Node.js compatibility to v6+"</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/1fd2edee2a12fb228061fcde807905c6b14339c4"><code>1fd2ede</code></a> v4.7.5</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/3c9c2f5cf29cf10f54d5fe4daca6b24b65f0adcf"><code>3c9c2f5</code></a> Update release notes</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/16487a088e13f4d52c6fd6610b9ec71c4a51be8a"><code>16487a0</code></a> chore: downgrade yargs to v14</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/309d2b49a11628d2a8f052c5587e7459968cd705"><code>309d2b4</code></a> chore: set Node.js compatibility to v6+</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/645ac73844918668f9a2f41e49b7cb18ce5abf36"><code>645ac73</code></a> test: fix integration tests</li> <li>Additional commits viewable in <a href="https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.7.6">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~erisds">erisds</a>, a new releaser for handlebars since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+13 -33

0 comment

1 changed file

dependabot[bot]

pr closed time in 5 days

push eventexpo/match-media

dependabot[bot]

commit sha 784e48be0ba80885c26f2ff55a72912e944a174a

Bump acorn from 5.7.3 to 5.7.4 Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Evan Bacon

commit sha bf89695c3319f14e8987f242c3fa58a223baaf6d

Merge pull request #12 from expo/dependabot/npm_and_yarn/acorn-5.7.4 Bump acorn from 5.7.3 to 5.7.4

view details

push time in 5 days

PR merged expo/match-media

Bump acorn from 5.7.3 to 5.7.4 dependencies

Bumps acorn from 5.7.3 to 5.7.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/6370e90067552022710190319cbbbd8c43001957"><code>6370e90</code></a> Mark version 5.7.4</li> <li><a href="https://github.com/acornjs/acorn/commit/fbc15b1344f6dfb992f67b4bbf1357436247c8a0"><code>fbc15b1</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/5.7.3...5.7.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 5 days

Pull request review commentexpo/match-media

➕ Add await catcher

 class MediaQuery {   private unsubscribe: Subscription;    constructor(private query: string) {-    // @ts-ignore-    (async () => {-      const { orientation } = await ScreenOrientation.getOrientationAsync();-      this.updateListeners({ orientation });-    })();+    // notice we don't need an async function+    // Also if an error occurs, await-catcher will handle it.+    awaitCatcherAsync(

Probably just want to wrap in a try/catch

canaanites

comment created time in 5 days

push eventexpo/match-media

Ian Martorell

commit sha 7d67db05cf16f8caae4d7708a77227d34abd7316

Use expo-screen-orientation

view details

Evan Bacon

commit sha 75a00e646d3f50f7b6b3de6be1f30295ca492ec7

Fix orientation

view details

Evan Bacon

commit sha b4153130ecf75d5d44afd352b7b67be984931423

Update polyfill.native.ts

view details

Evan Bacon

commit sha b8d0c309bc180d27629405753e5295642bb78e25

Merge pull request #15 from ianmartorell/fix-screen-orientation Use expo-screen-orientation

view details

push time in 5 days

PR merged expo/match-media

Use expo-screen-orientation

Fixes #7.

Not sure if the changes to package.json are quite right, let me know if anything needs to be adjusted!

+2316 -977

2 comments

5 changed files

ianmartorell

pr closed time in 5 days

push eventianmartorell/match-media

Evan Bacon

commit sha b4153130ecf75d5d44afd352b7b67be984931423

Update polyfill.native.ts

view details

push time in 5 days

pull request commentexpo/match-media

Use expo-screen-orientation

Thanks for bringing this to my attention, GitHub notifications are not great. I fixed a few bugs and ran the tests, seems like everything is in order.

ianmartorell

comment created time in 5 days

push eventianmartorell/match-media

Evan Bacon

commit sha 75a00e646d3f50f7b6b3de6be1f30295ca492ec7

Fix orientation

view details

push time in 5 days

push eventexpo/react-native

Brent Vatne

commit sha 4b85dd3b671a59b6c25f8e2909f2dc9091248395

[appearance] Use listener whenever possible in order to respect userInterfaceStyle of RCTRootView - getColorScheme does not do this by default

view details

push time in 5 days

push eventexpo/expo

Evan Bacon

commit sha 1628e6f5f902212148b350cd2940cc4d44463981

Update CHANGELOG.md

view details

Evan Bacon

commit sha 6904e24f1895baa739e814aa6b6ff1ac892bc1f4

Update yarn.lock

view details

Evan Bacon

commit sha 6dac847374633f8472c8c9abdd38a3163c1f261f

Updated jest-expo-enzyme

view details

push time in 6 days

PR opened expo/expo

Upgrade to react-native-web@~0.12 Platform: web

Why

resolve https://github.com/expo/expo/issues/8064

+25 -25

0 comment

15 changed files

pr created time in 6 days

create barnchexpo/expo

branch : @evanbacon/react-native-web/bump-0.12

created branch time in 6 days

push eventexpo/expo

Evan Bacon

commit sha f86796af9b5e3f709ace7e3a84a42cb0e7c34db8

[firebase-recaptcha] Remove webview on web (#9021) * Remove webview on web * Remove WebView from NCL screen * Update CHANGELOG.md

view details

push time in 6 days

delete branch expo/expo

delete branch : @evanbacon/firebase-recaptcha/remove-webview-on-web

delete time in 6 days

PR merged expo/expo

Reviewers
[firebase-recaptcha] Remove webview on web Platform: web

Why

  • Required for #8064
  • Web isn't supported by expo-firebase-recaptcha or react-native-webview

<!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. -->

How

  • Render an empty view on web <!-- How did you build this feature or fix this bug and why? -->

Test Plan

  • RNW 12 doesn't crash in NCL <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. -->
+19 -29

1 comment

14 changed files

EvanBacon

pr closed time in 6 days

push eventexpo/expo-cli

Evan Bacon

commit sha 83c39cf9c2be5f500d869d011e8e43e8dfbeec26

Update Eject.ts

view details

push time in 6 days

push eventexpo/expo

Evan Bacon

commit sha 2bac9b66682bad47d56ec28db970e2c04c16888a

Update CHANGELOG.md

view details

push time in 6 days

push eventexpo/expo

Evan Bacon

commit sha bfcd8650c00098728a54fde02c7b781c194e603c

Remove WebView from NCL screen

view details

push time in 6 days

PR opened expo/expo

Reviewers
[firebase-recaptcha] Remove webview on web Platform: web

Why

  • Required for #8064
  • Web isn't supported by expo-firebase-recaptcha or react-native-webview

<!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. -->

How

  • Render an empty view on web <!-- How did you build this feature or fix this bug and why? -->

Test Plan

  • RNW 12 doesn't crash in NCL <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. -->
+15 -4

0 comment

12 changed files

pr created time in 6 days

create barnchexpo/expo

branch : @evanbacon/firebase-recaptcha/remove-webview-on-web

created branch time in 6 days

push eventexpo/expo

Evan Bacon

commit sha acefa979bae16eae9b72322145cbe7bbb87b5906

[ncl][chore] use community async storage (#9018) * Install community async-storage * Install pods in bare-expo * Migrate NCL to community async storage

view details

push time in 6 days

delete branch expo/expo

delete branch : @evanbacon/ncl/use-community-async-storage

delete time in 6 days

PR merged expo/expo

Reviewers
[ncl][chore] use community async storage AsyncStorage Platform: web

Why

  • Required for #8064

<!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. -->

+1916 -1331

1 comment

28 changed files

EvanBacon

pr closed time in 6 days

push eventexpo/examples

Evan Bacon

commit sha ba7427ae92ca53edd2c0d03b801765b8ebb638b4

Update README.md

view details

push time in 6 days

Pull request review commentexpo/examples

with-camera

+import React, { useState, useEffect } from 'react';+import { Text, View, TouchableOpacity, ImageBackground, Platform } from 'react-native';+import { Camera } from 'expo-camera';++export default function App() {+  const [hasPermission, setHasPermission] = useState(null);+  const [type, setType] = useState(Camera.Constants.Type.back);+  const [lastPhotoURI, setLastPhotoURI] = useState(null);++  useEffect(() => {+    (async () => {+      if (Platform.OS == "web") { +        setHasPermission(true);+        return; +      }+      const { status } = await Camera.requestPermissionsAsync();+      setHasPermission(status === 'granted');+    })();+  }, []);++  if (lastPhotoURI !== null) {+    return (+      <ImageBackground +        source={{uri: lastPhotoURI}}+        style={{+          flex: 1,+          backgroundColor: 'transparent',+          flexDirection: 'row',+          justifyContent: "center"+        }}>+        <TouchableOpacity+            style={{+              flex: 0.2,+              alignSelf: 'flex-end',+              alignItems: 'center',+              justifyContent: "center",+              backgroundColor: "#666",+              marginBottom: 40, +              marginLeft: 20,+            }}+            onPress={() => {+              setLastPhotoURI(null);+            }}>+            <Text style={{ fontSize: 30, padding: 10, color: 'white' }}>❌</Text>+          </TouchableOpacity>+      </ImageBackground>+    );+  }++  if (hasPermission === null) {+    return <View />;+  }+  if (hasPermission === false) {+    return <Text>No access to camera</Text>;+  }++  let cameraRef;+  return (+    <View style={{ flex: 1 }}>+      <Camera +        style={{ flex: 1 }}+        type={type}+        ref={ref => {+          cameraRef = ref;+        }}
        ref={cameraRef}

Use the hook React.useRef(null) instead

YassineElbouchaibi

comment created time in 6 days

Pull request review commentexpo/examples

with-camera

+import React, { useState, useEffect } from 'react';+import { Text, View, TouchableOpacity, ImageBackground, Platform } from 'react-native';+import { Camera } from 'expo-camera';++export default function App() {+  const [hasPermission, setHasPermission] = useState(null);+  const [type, setType] = useState(Camera.Constants.Type.back);+  const [lastPhotoURI, setLastPhotoURI] = useState(null);++  useEffect(() => {+    (async () => {+      if (Platform.OS == "web") { +        setHasPermission(true);+        return; +      }+      const { status } = await Camera.requestPermissionsAsync();+      setHasPermission(status === 'granted');+    })();+  }, []);++  if (lastPhotoURI !== null) {+    return (+      <ImageBackground +        source={{uri: lastPhotoURI}}+        style={{+          flex: 1,+          backgroundColor: 'transparent',+          flexDirection: 'row',+          justifyContent: "center"+        }}>+        <TouchableOpacity+            style={{+              flex: 0.2,+              alignSelf: 'flex-end',+              alignItems: 'center',+              justifyContent: "center",+              backgroundColor: "#666",+              marginBottom: 40, +              marginLeft: 20,+            }}+            onPress={() => {+              setLastPhotoURI(null);+            }}>+            <Text style={{ fontSize: 30, padding: 10, color: 'white' }}>❌</Text>+          </TouchableOpacity>+      </ImageBackground>+    );+  }++  if (hasPermission === null) {+    return <View />;+  }+  if (hasPermission === false) {+    return <Text>No access to camera</Text>;+  }

Move these into other component

YassineElbouchaibi

comment created time in 6 days

Pull request review commentexpo/examples

with-camera

+import React, { useState, useEffect } from 'react';+import { Text, View, TouchableOpacity, ImageBackground, Platform } from 'react-native';+import { Camera } from 'expo-camera';++export default function App() {+  const [hasPermission, setHasPermission] = useState(null);+  const [type, setType] = useState(Camera.Constants.Type.back);+  const [lastPhotoURI, setLastPhotoURI] = useState(null);++  useEffect(() => {+    (async () => {+      if (Platform.OS == "web") { +        setHasPermission(true);+        return; +      }

Camera permission is required on web.

YassineElbouchaibi

comment created time in 6 days

Pull request review commentexpo/examples

with-camera

+import React, { useState, useEffect } from 'react';+import { Text, View, TouchableOpacity, ImageBackground, Platform } from 'react-native';+import { Camera } from 'expo-camera';++export default function App() {+  const [hasPermission, setHasPermission] = useState(null);

Split the permission into a new component that guards the custom camera component.

YassineElbouchaibi

comment created time in 6 days

Pull request review commentexpo/examples

Remove yarn.lock from with-storybook #181

 export function font() { }  // On-Device Register-storiesOf('Font', module).add('Font', font);+storiesOf('Font', module).add('Font', () => (<CustomFontComponent/>));

Nevermind, I found your comment. https://github.com/expo/examples/issues/181#issuecomment-650463810 Good work again.

YassineElbouchaibi

comment created time in 6 days

issue closedexpo/examples

Remove yarn.lock from with-storybook

  • Lock package.json version to the latest versions that work as expected - requires manually testing
  • Delete yarn.lock file to prevent dependabot issues

closed time in 6 days

EvanBacon

issue closedexpo/examples

Map

Describe the example you'd like

<!-- A clear and concise description of what you want to happen. -->

Basic example for setting up and using a map component (ios and android only atm)

Any existing examples?

<!-- Does an example like this already exist? --> https://docs.expo.io/versions/v37.0.0/sdk/map-view/#usage

closed time in 6 days

EvanBacon

push eventexpo/examples

Yassine El Bouchaibi

commit sha e199336d7800706ab90bd8bbd72ca07052820645

with-maps

view details

Evan Bacon

commit sha 08a715bad379ba1b4f36bcd978367d9acadfa225

Merge pull request #189 from YassineElbouchaibi/NewExample/#170 with-maps

view details

push time in 6 days

PR merged expo/examples

with-maps New Example

Hey, here's a small PR for to add a template with a MapView. Let me know if my readme is not detailed enough.

Relates to #170

+76 -0

0 comment

4 changed files

YassineElbouchaibi

pr closed time in 6 days

push eventexpo/examples

allcontributors[bot]

commit sha 535c33ad1cf75f38a6cc4ff518bbd623014cd52d

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha 02471d6ea14ad09af80ca5c0223d2aedd4258d33

docs: update .all-contributorsrc [skip ci]

view details

Evan Bacon

commit sha e35967a3b0a9fb1a784285d31edeef3844e95285

Merge pull request #193 from expo/all-contributors/add-YassineElbouchaibi docs: add YassineElbouchaibi as a contributor

view details

push time in 6 days

delete branch expo/examples

delete branch : all-contributors/add-YassineElbouchaibi

delete time in 6 days

PR merged expo/examples

docs: add YassineElbouchaibi as a contributor

Adds @YassineElbouchaibi as a contributor for code.

This was requested by EvanBacon in this comment

+11 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 6 days

push eventexpo/examples

Yassine El Bouchaibi

commit sha 18601f54daf47c4d78fb101be2066726566eb77d

* Removed yarn.lock * Tweaked version numbers in package.json * Tweaked Font story to be able to use hooks

view details

Evan Bacon

commit sha e08b1c87b79dab9dd444393c7ec56858d4d882a4

Merge pull request #190 from YassineElbouchaibi/update/#181 Remove yarn.lock from with-storybook #181

view details

push time in 6 days

more