emplums ( Emily )

commit sha 08e74c4d1819281402efc2f48c204d7203bd30cd

update version number

Table of Contents doesn't appear in .mdx files

push time in 6 days

PR opened primer/doctocat-template

Use the latest version of Doctocat & upgrade React

This PR updates the template repo to the latest version of Doctcat & bumps the React version.

I've changed the package manager from npm to yarn, for some reason npm wasn't deduping the react version correctly (possibly because doctcat is using yarn and this repo was using npm??), plus all our other repos are using yarn so it's nice to keep it consistent ✨

+15164 -15459

5 commit in primer/doctocat-template/tree/update-doctocat primer/doctocat-template/tree/master

0 comment

5 changed files

pr created time in 6 days

issue openedprimer/doctocat

I was working with @ashygee on the new mobile docs and noticed that the new table of contents only appears in .md files and not .mdx files

created time in 6 days

push eventprimer/doctocat-template

commit sha b8cff53f760a9795e28a6d129e8e9cc4920aec2d

switch to yarn

commit sha 36f409e46105aaff95b92a8d1c1b8d7d6dfa23bb

Update README.md

push time in 6 days

push eventprimer/doctocat-template

commit sha d709300bf50522b5cf37ef7a715ea14bac1d0cb8

update react versions

Keeping Everything Fresh 🌱

push time in 6 days

create barnchprimer/doctocat-template

branch : update-doctocat

created branch time in 6 days

issue commentprimer/doctocat

cc @BinaryMuse since you are 💯 at thinking of cool ways to automate things, do you have any ideas??

emplums

comment created time in 6 days

issue openedprimer/doctocat

Keeping Everything Fresh 🌱

Doctocat is starting to get a fair amount of traction! 🎉 This is wonderful news, and leads me to think we need to start defining some processes for keeping everything up to date and if possible, automating this process.

Goals

primer/doctocat should always have the latest version of Primer React Components and Primer Octicons
primer/dotocat-template should always be using the latest version of the doctocat theme
All of our documentation sites should be using the latest version of the doctocat theme

Roadblocks

Keeping all of these up to date is time consuming. Take for example shipping a new version of Primer Components. Afterwards, we'd need to update the version in primer/doctocat, which would mean we'd need to ship a new release. Then we'd need to update each of our doc sites (I believe we're up to 10+ doc sites at the moment), and the primer/doctocat-template repository. My hunch is that because this is so tedious, we don't often do it 😬 Many of the docs sites are currently using old versions of doctocat, and the doctocat template is using a version of the doctocat theme that is 12 versions old 😬

Potential solutions

Could we use a GitHub Action that automatically creates a new PR for all our docs sites when primer/doctocat ships a new version?
Could dependabot do this for us?
If there isn't an easy way to automate this, would it make sense to schedule a recurring time to do this manually once a month?

created time in 6 days

issue commentprimer/css

Add issue progress bars to Primer

This would be easy to implement in the current ProgressBar::Component, we'd just want to add a custom CSS color variable for this grey to make sure it's standardized!

emplums

comment created time in 6 days

pull request commentprimer/css

Update Octicons

Ash and I upgraded the Primer Components version to the latest and did all the breaking change refactors, but we're still seeing that weird syntax error for the jsx in the colors.mdx file 🤔 It's super weird because that syntax has been there for a year and there were never any issues, so I wonder if there's been some sort of gatsby version upgrade in Doctocat that is somehow messing with how babel compiles jsx in the mdx files? I should work out of the box since that's the whole point of Gatsby, so I think we've fudged something up somehow! I will keep looking into this today 😄

simurai

comment created time in 12 days

issue openedprimer/components

Rename "master" -> "main"

[ ] Change the base for any release branches
[ ] Transfer branch protection policies
[ ] Update any necessary GitHub Actions

created time in 15 days

push eventprimer/doctocat

Jp

commit sha b9529afa583058a6a109a038c70e80209809b5fc

fix: error react jsx when developing

commit sha 4cc32f96e9656f1f28a91c87eb88c430438c1d8a

Merge pull request #151 from jpvalery/patch-1 fix: ERROR #98123 when `gatsby develop` with shadowed hero.js

push time in 16 days

PR merged primer/doctocat

fix: ERROR #98123 when `gatsby develop` with shadowed hero.js

When running gatsby develop, the CLI was returning an error.

 ERROR #98123  WEBPACK

Generating development JavaScript bundle failed


~/docs/src/@primer/gatsby-theme-doctocat/components/hero.js
  6:5  error  'React' must be in scope when using JSX  react/react-in-jsx-scope

✖ 1 problem (1 error, 0 warnings)


File: src/@primer/gatsby-theme-doctocat/components/hero.js

failed Re-building development bundle - 1.190s

Adding this line fixes the error.

+1 -0

1 commit in jpvalery/doctocat/tree/patch-1 primer/doctocat/tree/master

1 comment

1 changed file

jpvalery

pr closed time in 16 days

delete branch primer/doctocat

delete branch : upgrade-comps

delete time in 16 days

push eventprimer/doctocat

commit sha bb69bfa1aff4dacdf19d73f2fc47d71a9e17cbe9

octicon refactor

commit sha 06ba2304b6224274b98a25f3f2a6d1215e413f68

BorderBox refactor

commit sha 792311afbc60fc6331e34b47b76e6307c1dfc64f

v 19.0.0 updates

commit sha 3eea6e32302c3c6b8e85ab4004a645cde105110c

v18.0.0 changes

commit sha 0eaacfc90b6c81c60e13434e752c695aa5788051

upgrade Primer Components

commit sha d22fb45a28305775ca708cbf12f991944f6234ec

use 20.0.0

commit sha 0a7138a6c642dfeea8d064809a875805f430809d

upgrade components in docs

commit sha 247cce098938aa516ed7b5775d6eb35ff13057f9

update version of theme

commit sha 86dd794e0661cfbc0d492cc9814b21f5ce32e939

Merge pull request #154 from primer/upgrade-comps Upgrade Primer Components

push time in 16 days

PR merged primer/doctocat

Upgrade Primer Components

This PR switches back to using @primer/[email protected] and uses the rc version of the Primer Components v20.0.0 release. I've made all necessary refactors for versions 17.0.0, 18.0.0, 19.0.0 and 20.0.0 in this PR. As soon Primer React Components makes the v20.0.0 release, I will change the version in this branch and merge + release this 😄

+266 -123

8 commit in primer/doctocat/tree/upgrade-comps primer/doctocat/tree/master

1 comment

18 changed files

emplums

pr closed time in 16 days

push eventprimer/doctocat

commit sha 247cce098938aa516ed7b5775d6eb35ff13057f9

update version of theme

push time in 16 days

push eventprimer/doctocat

commit sha 0a7138a6c642dfeea8d064809a875805f430809d

upgrade components in docs

push time in 16 days

push eventprimer/doctocat

commit sha d22fb45a28305775ca708cbf12f991944f6234ec

use 20.0.0

push time in 16 days

release primer/components

v20.0.0

released time in 16 days

delete branch primer/components

delete branch : major

delete time in 16 days

push eventprimer/components

commit sha 90ee5939080fd089d3cc9d800368b5ff47adc0d9

Add prop to Avatar

commit sha 09a2e33d5fbc765dcaf6bfe48233c0ec82aeba21

Update types, documentation, and snapshot

commit sha 3ebfd8c78cf6e2a541bd19aca52796d8a30aa1ce

Add test

commit sha 903454f86b0791a886f46f5e1b848c9a5bbee2e6

Rename prop: form -> shape

commit sha e71ecac626e567c204fd080abc89573aae2a7f1a

Slight refactoring

commit sha d47989691f4af729fd897e9f4c0c9c51c3d88899

Merge pull request #765 from albingroen/albingroen/avatar-form-prop Add `shape` prop to `Avatar` component

commit sha e5743147b9dbd46b592c88f96027c9fb12c16834

AvatarPair refactor

commit sha d4321de4cf5783f67698ade109f73974341a06d8

refactor AvatarStack

commit sha 415ab0e256fba325b77945f95953d61d2f506728

use `square` boolean instead of `shape`

commit sha fd9f6acb01ff3a8bd4d3d18e650eedc98e6db412

small refactors

commit sha 8312595f34ea8907aa9164c9cbf46defc3582a31

give Avatar COMMON props

commit sha dee746bcb476b89e7ff755c8d84fc0ae3375f8fa

remove native attributes from Avatar prop types

commit sha 40e870c56d916684f456dd912817163cb61a603c

fix Avatar type

commit sha 38ea35479847e2c7da1950cf9d32e7cdf410b81c

AvatarPair shouldn't get Avatar props, it should get Relative props since that's the rendered component

commit sha 7278da845c5d307f83a17c9aaef41dec380add0d

docs tweaks

commit sha 96c906d3f34e3d0b34b5959f6467bc536b8846ff

update to 1px instead of 2 for AvatarStack

commit sha 36e90db38dac6eb85b10c3b77aadeb45e3e82fc4

remove AvatarItem-more

commit sha bd37c53fb53a62b47e0574ddf2a2d8391c59879c

Merge branch 'master' into avatar-tweaks

commit sha d94d875a649646491a95de97fd77589cbcd7109f

remove AvatarItem-more class

commit sha 52369251c12dad00852d7cb63d44aa150a345d62

more cleanup

push time in 16 days

PR merged primer/components

Major Release Tracking (20.0.0)

Tracking PR for the next major release (currently: 20.0.0)

💅 Enhancements

Updated hidden counters #848 @nuthinking

✨ New Components!

[x] Pagehead component from @haigdouzdjian #851

🚨 Breaking Changes 🚨

Default Avatar is now a circle instead of a square #773 @emplums @albingroen
AvatarStack now expects you to use Avatar components #773 as children @emplums @colinkeany
Removes scheme prop from Flash and small prop from StateLabel deprecation workarounds as scheduled in the 19.0.0 release #847
Upgrades to octicons dependency to version 10.0.0 - The new octicons version has significant API changes see the release notes for the icons package for more details.

+983 -1154

80 commit in primer/components/tree/major primer/components/tree/master

2 comments

61 changed files

emplums

pr closed time in 16 days

push eventprimer/components

commit sha d900585b58a7619aefe58ecf31c8622e5947174a

add missing CircleBadge.Icon props

push time in 16 days

push eventprimer/components

commit sha 38a5fdaedf8d30d4d0c74a8a4f6ad1ee047a7f42

fix StyledOcticon type

Major Release Tracking (20.0.0)

push time in 16 days

Pull request review commentprimer/components

 declare module '@primer/components' {    export interface CircleOcticonProps extends CommonProps, FlexProps {     size?: number-    icon: React.ReactNode+    icon: ReactComponentLike   }    export const CircleOcticon: React.FunctionComponent<CircleOcticonProps>    export interface StyledOcticonProps extends CommonProps {-    size?: number-    icon: React.ReactNode+    size?: number | 'small' | 'medium' | 'large'+    icon: ReactComponentLike+    verticalAlign: 'middle' | 'text-bottom' | 'top' | 'text-top'

it is not! good catch :)

emplums

comment created time in 16 days

push eventprimer/components

commit sha 2c87461d650988b66acf9b0e646c04b9aa995c5f

fix type

push time in 16 days

push eventprimer/components

Haig Douzdjian

commit sha e7fef9434458c3550f4291778a7a0b79ffb1d338

Implement Pagehead Component

Haig Douzdjian

commit sha 25c5874e426a53fe68a9ebba52893fa049dec276

Fixed PR comments

commit sha de86ccf938d30d11837515d8b855cf7f8f3bd626

Merge pull request #851 from haigdouzdjian/Pagehead Implement Pagehead Component

Implement Pagehead Component

push time in 16 days

PR merged primer/components

Implement Pagehead Component

Added Pagehead component using Primer.style/css as reference.

Closes #671

Screenshots

Screen Shot 2020-07-16 at 2 06 30 PM

Merge checklist

[x] Added or updated TypeScript definitions (index.d.ts) if necessary
[x] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

+94 -0

2 commit in haigdouzdjian/components/tree/Pagehead primer/components/tree/major

1 comment

7 changed files

haigdouzdjian

pr closed time in 16 days

issue openedemplums/testtest

A new issue!

created time in 16 days

created repositoryemplums/testtest

created time in 16 days

Pull request review commentprimer/components

+import React from 'react'+import PropTypes from 'prop-types'+import styled from 'styled-components'+import {COMMON, get} from './constants'+import theme from './theme'+import sx from './sx'++const StyledPagehead = styled.div`+  position: relative;+  padding-top: ${get('space.4')};+  padding-bottom: ${get('space.4')};+  margin-bottom: ${get('space.4')};+  border-bottom: 1px solid ${get('colors.border.gray')};+  ${COMMON};+  ${sx};+`++const Pagehead = ({...props}) => {

Since we don't need to do anything special here, we can remove lines 18-20 and rename the component in line 8 Pagehead! 🎉

haigdouzdjian

comment created time in 19 days

issue closedprimer/components

Remove Shadowed Docs Components

We need to upgrade Doctocat to the latest version of Primer React Components - right now it's on version ^16! Let's do this once version 20.0.0 ships 🎉

Once that is done, we can remove all the shadowed components here: https://github.com/primer/components/pull/761

closed time in 21 days

emplums

push eventprimer/components

commit sha feb789cd5fbee4655d2122ac1c77f97bb280c2b6

remove shadowed components

commit sha 45cc4ee08382d8bbffa43df73f2720cc6094f930

Merge branch 'major' into upgrade-doctocat

commit sha d5bf8216fe3a58664f446e8d66a46375aed51426

Merge pull request #850 from primer/upgrade-doctocat Upgrade Doctocat & Remove Shadowed Components

branch : upgrade-doctocat

push time in 21 days

PR merged primer/components

Upgrade Doctocat & Remove Shadowed Components

This PR upgrades Doctocat to the rc version in https://github.com/primer/doctocat/pull/154 and removes all shadowed components introduced in #761 that can now be removed since we've upgraded Primer Components in Doctocat 🙌

Closes: #841

+182 -492

2 commit in primer/components/tree/upgrade-doctocat primer/components/tree/major

1 comment

9 changed files

emplums

pr closed time in 21 days

MemberEvent

PR opened primer/components

Upgrade Doctocat & Remove Shadowed Components

This PR upgrades Doctocat to the rc version in https://github.com/primer/doctocat/pull/154 and removes all shadowed components introduced in #761 that can now be removed since we've upgraded Primer Components in Doctocat 🙌

Closes: #841

+880 -1153

73 commit in primer/components/tree/upgrade-doctocat primer/components/tree/master

0 comment

55 changed files

pr created time in 23 days

create barnchprimer/components

created branch time in 23 days

PR opened primer/doctocat

Upgrade Primer Components

This PR switches back to using @primer/[email protected] and uses the rc version of the Primer Components v20.0.0 release. I've made all necessary refactors for versions 17.0.0, 18.0.0, 19.0.0 and 20.0.0 in this PR. As soon Primer React Components makes the v20.0.0 release, I will create a follow-up PR to move to that version, but that release relies on these refactors 😄

+279 -90

5 commit in primer/doctocat/tree/upgrade-comps primer/doctocat/tree/master

0 comment

17 changed files

pr created time in 23 days

push eventprimer/doctocat

commit sha 0eaacfc90b6c81c60e13434e752c695aa5788051

upgrade Primer Components

push time in 23 days

delete branch primer/components

delete branch : upgrade-octicons

delete time in 23 days

push eventprimer/components

commit sha edad62eba6a9a1a13a6979ca4205b8bb155d674f

upgrade to octicons v10

commit sha c0e81e06af1a7d2dd86b7be6d2e0cbacd57dae1d

wildcard import doesnt work

commit sha a1f5481c834d4cd55ea30e4f7e7bae8e023f1b97

TextInput tweaks

commit sha 7761dca4164fd5620c4dfff2711583586941fb97

fix circle badge

commit sha ce152b912e6f57c14aa79ccf69977ca18c62cf4c

refactor CircleBadge again

commit sha 566b36822e353610f6d6c342a94f70eec289f8e9

Update StyledOcticon.js

commit sha 48ae33828a57823f06e7e9e8a288a3c0a836114c

Update Dialog.md

commit sha b25a5aab7b365e0c6b02e196350ed05600ab30c3

Update StyledOcticon.js

commit sha 3a739db685fc578033f66a94b6ef3df0f67fa1c2

fix unknown dot icon

commit sha c95ad0cc259a24cc28f2734996b2ce71e882af16

fix tests & types

commit sha 8ef2e503af3792a667bc84f562fc33065629a83f

update CircleBadge snapshot

commit sha 743d1de32391e9b31884d2f8ba04f97476ce98eb

Merge branch 'major' into upgrade-octicons

commit sha 1660228b5d656b9a33d666b6f002f683765291ef

fix prop types

commit sha e62cc50468118db0f45580f06ff4d000b5a1b70d

Update src/StyledOcticon.js Co-authored-by: Michelle Tilley <[email protected]>

Michelle Tilley

commit sha db0b206787ebf9960f4d75253387aff89d1692ab

Workaround broken getComputedStyles for LabelGroup test

Michelle Tilley

commit sha 26ec95333c40c003b14845fb786c60cd7906a42f

Fix linter errors

commit sha 1117ffb82c43f5158663349f91a24265dd3b4cd4

Merge branch 'upgrade-octicons' of github.com:primer/components into upgrade-octicons

commit sha d9d63ba160e7bcc9b94c2fb6cdacc3672f43b95d

update types

commit sha 7e10ccfebd7a6fe4103cdb1e2952a07900d9b8f7

Update index.d.ts

commit sha cb1012189abb9c08079e43e7d16b7344ce5eb3c6

Update index.d.ts

push time in 23 days

PR merged primer/components

Upgrade octicons

🚨 Do not merge until installing canary doctocat version 🚨

Description

This PR upgrades @primer/octicons-react to version 10.0.0. Since the new version of octicons-react removes the Octicon export, a couple of components needed to be refactored:

CircleBadge
CircleOcticon
StyledOcticon
TextInput

Notes

Our original strategy was to use @primer/styled-octicons but after weighing the pros and cons a bit more, we've decided to stick with the original package + a StyledOcticon component. Please see the closed issue for more details on this decision. I'm also going to hold off on marking it as a peer dependency for now.

Note that CircleOcticon looks janky since the size of the icon isn't proportional to the circle. This bug existed before these changes and needs to be addressed separately.

🚨 Breaking Changes 🚨

Though not directly related to changes in this repo, the new octicons version has significant API changes see the release notes for the icons package for more details.

+265 -301

20 commit in primer/components/tree/upgrade-octicons primer/components/tree/major

5 comments

38 changed files

emplums

pr closed time in 23 days

create barnchprimer/doctocat

branch : upgrade-comps

created branch time in 23 days

push eventprimer/components

commit sha cb1012189abb9c08079e43e7d16b7344ce5eb3c6

Update index.d.ts

push time in 23 days

pull request commentprimer/components

Upgrade octicons

@BinaryMuse I made the changes you requested + tested that ReactComponentLike works well in a TS environment here: https://codesandbox.io/s/primer-components-ts-testing-47dbw?file=/src/index.tsx

emplums

comment created time in 23 days

push eventprimer/components

commit sha 7e10ccfebd7a6fe4103cdb1e2952a07900d9b8f7

Update index.d.ts

push time in 23 days

push eventprimer/components

commit sha 1660228b5d656b9a33d666b6f002f683765291ef

fix prop types

commit sha 1117ffb82c43f5158663349f91a24265dd3b4cd4

Merge branch 'upgrade-octicons' of github.com:primer/components into upgrade-octicons

commit sha d9d63ba160e7bcc9b94c2fb6cdacc3672f43b95d

update types

New Component: access old versions

push time in 23 days

issue openedprimer/doctocat

From @broccolini in another repo:

Can we link to previous versions of our docs sites? I'm not sure how long we are keeping old branches, but after a quick look we do have the last several versions on Primer CSS and Octicons. Could we make this easier to find publicly? Occasionally people want to access the old docs for a previous version since they are not ready to upgrade yet, so this can be very helpful, particularly with big updates like we've just shipped.

Example of release urls:

https://primer-css-git-release-1300.primer.now.sh/css/ https://primer-css-git-release-1400.primer.now.sh/css/ https://octicons-git-release-960.primer.now.sh/octicons/ cc @emplums @BinaryMuse @colebemis

created time in 23 days

push eventprimer/doctocat

Cole Bemis

commit sha 5593e6770404ae045702bc485daf3a99f487513d

Bump version

Jonathan Lancaster

commit sha 246bb2e0c5d77ca256d0f1c9d426115f3d8a3428

ClipboardCopy now copies updated live code

commit sha 122bad5af4edae50931fa9448db3084056ace3d6

update Primer Components to Primer React

commit sha 2fe6bc57a88b5bfadeeaaca47a3b21d7f38be315

Merge branch 'master' into release-0.20.0

commit sha f2833f96b4d34145f0b1651917a377f3ad06762a

Merge branch 'release-0.20.0' into react-naming

Ryan Cao

commit sha 873bd1db73f06a42ab6f2032e60e21a653272774

Update information from Now -> Vercel

commit sha e96ca932624a887d8a84d161ccdbdf9c489a4255

Merge pull request #147 from primer/react-naming Rename Primer Components to Primer React

commit sha 1e289d8295ca7563137f836a735358e9ea5395da

Merge pull request #148 from ryanccn/patch-1 Update information from Now -> Vercel

commit sha 7fb16679ae6a45555411c6261368bb7d68726bbc

Merge pull request #134 from primer/release-0.20.0 Release v0.22.0

push time in a month

PR merged primer/doctocat

Release v0.22.0

[x] The copy button now copies updated live code #133 (Thanks @lancasja 🙏)
[x] Rename Primer Components to Primer React

+11 -8

8 commit in primer/doctocat/tree/release-0.20.0 primer/doctocat/tree/master

1 comment

4 changed files

colebemis

pr closed time in a month

push eventprimer/doctocat

Ryan Cao

commit sha 873bd1db73f06a42ab6f2032e60e21a653272774

Update information from Now -> Vercel

commit sha 1e289d8295ca7563137f836a735358e9ea5395da

Merge pull request #148 from ryanccn/patch-1 Update information from Now -> Vercel

push time in a month

PR merged primer/doctocat

Update information from Now -> Vercel

ZEIT Now is now Vercel.

https://vercel.com/blog/zeit-is-now-vercel

+3 -3

1 commit in ryanccn/doctocat/tree/patch-1 primer/doctocat/tree/release-0.20.0

1 comment

1 changed file

ryanccn

pr closed time in a month

delete branch primer/doctocat

delete branch : react-naming

delete time in a month

push eventprimer/doctocat

commit sha 122bad5af4edae50931fa9448db3084056ace3d6

update Primer Components to Primer React

commit sha f2833f96b4d34145f0b1651917a377f3ad06762a

Merge branch 'release-0.20.0' into react-naming

commit sha e96ca932624a887d8a84d161ccdbdf9c489a4255

Merge pull request #147 from primer/react-naming Rename Primer Components to Primer React

push time in a month

PR merged primer/doctocat

Reviewers

Rename Primer Components to Primer React

This PR changes the Primer Components naming in the top nav to be Primer React :)

+1 -1

2 commit in primer/doctocat/tree/react-naming primer/doctocat/tree/release-0.20.0

1 comment

1 changed file

emplums

pr closed time in a month

push eventprimer/components

commit sha e62cc50468118db0f45580f06ff4d000b5a1b70d

Update src/StyledOcticon.js Co-authored-by: Michelle Tilley <[email protected]>

push time in a month

push eventemplums/emplums

commit sha 48e322c9c5ec1e072e164ea68accfabaef8a16b2

Update README.md

push time in a month

push eventemplums/emplums

commit sha f12a6939f586cde0ea9becedd92f87b6eb32d22d

Update README.md

push time in a month

push eventemplums/emplums

commit sha f3bb31646063498ab46ed92e58c1e30ea6f3be1b

Update README.md

push time in a month

push eventemplums/emplums

commit sha 15a85062c3b5fabe0bbc8398f44f7d808ad8afec

Update README.md

push time in a month

push eventemplums/emplums

commit sha 8871adbd08d21558f0c882055ee940a56abfb5a0

Update README.md

push time in a month

push eventemplums/emplums

commit sha 530e52c41008aa04385b408c087912a77e793dc2

Update README.md

push time in a month

push eventemplums/emplums

commit sha ebbd8d221a2afa0bbadb3f2e19b68ad15dcb0ce2

Update README.md

push time in a month

push eventemplums/emplums

commit sha a179cfcf035edcfce1f96dc54311afde5495d2e5

Update README.md

push time in a month

push eventemplums/emplums

commit sha 52643089b9a724723f0a549bea1995036f6493b6

Update README.md

push time in a month

create barnchemplums/emplums

branch : master

created branch time in a month

created repositoryemplums/emplums

created time in a month

pull request commentprimer/components

Upgrade octicons

@BinaryMuse any idea why the LabelGroup test is failing? I didn't touch it in this PR and confirmed that the sx prop does work on LabelGroup 🤔

I think LabelGroup doesn't need this style wrapper anymore and I thought maybe that had something to do with the sx prop not working, but refactoring didn't make the test pass either

emplums

comment created time in a month

push eventprimer/components

Christian Giordano

commit sha e8c6559991a33738d55619ce3611c7d76a6f99f9

Replaced Counter:empty style from visibility:hidden to display:none

commit sha 922e1ab56959994eb19b6327915fd556887b2f13

Merge pull request #848 from nuthinking/master Replaced Counter:empty style from visibility:hidden to display:none