profile
viewpoint
Christoph Dreis dreis2211 Software-Developer. Open-source enthusiast.

dreis2211/bomr 0

Command-line tool for creating and updating a Maven bom

dreis2211/find-sec-bugs 0

The FindBugs plugin for security audits of Java web applications and Android applications. (Also work with Scala projects)

dreis2211/flyway 0

Flyway by Boxfuse • Database Migrations Made Easy.

dreis2211/FrameworkBenchmarks 0

Source code for the framework benchmarking project

dreis2211/gamejam 0

InnoGames Game Jam event page, forked from flamejam - https://github.com/svenstaro/flamejam

dreis2211/gitlabhq 0

GitLab is version control for your server

dreis2211/grafsy 0

Graphite client/proxy which listens locally on server and buffers data

push eventdreis2211/spring-boot

Dmytro Nosan

commit sha 1a8c321a7bb63f1ddd341ea69e47357c9f3937ff

Support nested requests in MetricsClientHttpRequestInterceptor Prior to this commit, requests made by `HttpRequestInterceptor` instances configured on `RestTemplate` would not be recorded properly. This commit ensures that nested requests are recorded separately. Closes gh-20231

view details

Madhura Bhave

commit sha 2086ed1b8c322476d8cbd0ba47cc6f8577389c2b

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha c0c097117ade4f3a7c2507e58cecbe9ef8f87805

Polish See gh-20244

view details

Stephane Nicoll

commit sha f4a3d7ff3abe1b32cac0674f4e45aa4ec21937ce

Upgrade to Couchbase Client 2.7.12 Closes gh-20247

view details

Stephane Nicoll

commit sha 4b9070d9b5492d09ae9e25706715f5b0bfe30897

Upgrade to Appengine Sdk 1.9.78 Closes gh-20248

view details

Stephane Nicoll

commit sha cd99b838f791a7d9207c5a1a25dd077b0d99e883

Upgrade to Hazelcast 3.11.7 Closes gh-20249

view details

Stephane Nicoll

commit sha b5a20492bdab030aea3644f88e4b7f905cc1bf44

Upgrade to Netty Tcnative 2.0.29.Final Closes gh-20250

view details

Stephane Nicoll

commit sha b3b7d803747ea04b2bbffa98e1e2341e0ffded13

Upgrade to Dependency Management Plugin 1.0.9.RELEASE Closes gh-20251

view details

Stephane Nicoll

commit sha 2b033c532bb91dcd8eb0db29921d002988f45474

Upgrade to Httpclient 4.5.11 Closes gh-20252

view details

Stephane Nicoll

commit sha ac41bcbb66140017c313a5e1ab8a787efa53b7d2

Upgrade to Tomcat 9.0.31 Closes gh-20253

view details

Stephane Nicoll

commit sha 7b8d3c284de76fee6735d70ac0fd949225ed44e6

Upgrade to Jetty 9.4.26.v20200117 Closes gh-20254

view details

Stephane Nicoll

commit sha 1e5b548501e5b810a961836bd9a46b6dc54bc082

Upgrade to Infinispan 9.4.18.Final Closes gh-20255

view details

Stephane Nicoll

commit sha 32fdc42ce1f83f88c0706c79e9f11879b1e5b965

Upgrade to Postgresql 42.2.10 Closes gh-20256

view details

Stephane Nicoll

commit sha 3f538c2b4aba60604ee80bcdaf018a461483ccb3

Upgrade to Lombok 1.18.12 Closes gh-20257

view details

Stephane Nicoll

commit sha eecd8e1669fd37ac6d8721189bde1f9c502c62af

Upgrade to Spring Security 5.1.8.RELEASE Closes gh-20258

view details

Stephane Nicoll

commit sha 29d7714a2bb150f25ccdb6563c886fa3ed66b90c

Upgrade to Spring Session Bom Bean-SR9 Closes gh-20259

view details

Stephane Nicoll

commit sha fb97f075b916af7281641fd8734bac0b44ae9898

Upgrade to Maven Shade Plugin 3.2.2 Closes gh-20260

view details

Stephane Nicoll

commit sha aee4388b9f2ff51b7d88cf26c68afc3bc6363479

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 021575a335ca991b2357457622b686aa63c307c2

Upgrade to Couchbase Client 2.7.12 Closes gh-20263

view details

Stephane Nicoll

commit sha 0b1b05f1299cc20e04bb127d9406b90ca5d2b176

Upgrade to Jackson 2.10.2.20200130 Closes gh-20264

view details

push time in 3 hours

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha 5d793c9e06fad1dfeefb6004a9a84326141b6474

Typo

view details

push time in 3 hours

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha f924a200a5894dc7c5e953d279a11fee486ba841

Add notice about workaround

view details

push time in a day

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha 79da2c2c9f1fbc613eaf37b1e54cbd0ae62b6b56

Fix typo

view details

push time in 2 days

push eventdreis2211/spring-boot

Scott Frederick

commit sha 625b40aa90b9dbc4e353ab1e5f307d92bc40500c

Prefer arguments in POM over spring-boot.run.arguments This commit changes the order of precedence for the `arguments` property of the AbstractRunMojo so that values specified in the POM override values provided on the command line using `spring-boot.run.arguments`. This brings the `arguments` property in line with all other Mojo parameters. Fixes gh-20024

view details

Scott Frederick

commit sha 23e781033ca2ad33eb07c92ce1ef9f0bcc676762

Merge branch '2.2.x' Closes gh-20244

view details

Madhura Bhave

commit sha 95f8f83833c174eda24c37db2e65a4da95fc5d6f

Remove spring security dependencies from Rsocket starter Fixes gh-20243

view details

push time in 2 days

PR opened spring-projects/spring-boot

Explicitly set java home in CommandLineInvoker

Hi,

similar to #20193 I found that JarCommandIT.jarCreationWithGrabResolver() fails if the java version in the console is different to the one used in IDEA, which is used to run the test.

Setting it explicitly in the CommandLineInvoker or more specifically in the ProcessBuilder seems to fix that.

Cheers, Christoph

+1 -0

0 comment

1 changed file

pr created time in 3 days

create barnchdreis2211/spring-boot

branch : java-home-cli-integration-tests

created branch time in 3 days

push eventdreis2211/spring-boot

Stephane Nicoll

commit sha 67d2258e76dd6391b54b360823c66a1739d10c3c

Start building against Spring Framework 5.2.4 snapshots See gh-20199

view details

Stephane Nicoll

commit sha 34f33e8b0d196a8da966a437c3193fcacd260da2

Start building against Spring HATEOAS 1.0.4 snapshots See gh-20232

view details

Stephane Nicoll

commit sha 2095295c4c039f96d01b39c8d0da1edd9072960b

Start building against Spring Data Moore SR5 snapshots See gh-20201

view details

Stephane Nicoll

commit sha 942cd85d76e75c9c64ff78e1d180c399e0af3a9b

Start building against Spring Integration 5.2.4 snapshots See gh-20202

view details

Stephane Nicoll

commit sha effa2a29f2ac8a71943ff572e6294bf0acbea811

Start building against Spring AMQP 2.2.5 snapshots See gh-20106

view details

Stephane Nicoll

commit sha cc3eac898ab0883e80ea9d971454e534b7972a55

Start building against Spring Kafka 2.3.6 snapshots See gh-20203

view details

Stephane Nicoll

commit sha 9b60794935f67712dad3e8198605ded98c351509

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha a039f6328dd7ac4e6dd80ed10983abda2d096e8e

Start building against Spring Framework 5.2.4 snapshots See gh-20240

view details

Stephane Nicoll

commit sha e7c265bc3ddc32768180960eb08d14f38c744ba9

Start building against Spring Data Neumann M4 snapshots See gh-20241

view details

push time in 3 days

issue commentspring-projects/spring-boot

Investigate "Failed to create volume" CI issues

I jinxed it 😆 https://ci.spring.io/builds/107398

dreis2211

comment created time in 3 days

issue commentspring-projects/spring-boot

Investigate "Failed to create volume" CI issues

I don't want to jinx it, but it seems that on the current master this is happening less frequent now. Did anything change, @wilkinsona ? I suspected my PR #20157 , but there were failures afterwards.

dreis2211

comment created time in 3 days

push eventdreis2211/spring-boot

Madhura Bhave

commit sha aa09058d8c78e429219e12663c4768fea722ba3a

Remove implicit layers support from the layer tools Closes gh-20187

view details

Mustafa Ulu

commit sha 2760426db0dabed96d49719edd39fd8e15dc1ae0

Polish log4j2 configuration See gh-20225

view details

Stephane Nicoll

commit sha 49c5d23b47b17d9a989714523557a509f4f8d16c

Merge pull request #20225 from mustafau * pr/20225: Polish log4j2 configuration Closes gh-20225

view details

dreis2211

commit sha d55bc5f850e17be6433a11ca532e3bfac8906341

Test the Gradle Plugin against Gradle 6.2 See gh-20222

view details

Stephane Nicoll

commit sha 7b190ecb88e5c30bed71dd64af7459ab3fa03d42

Merge pull request #20222 from dreis2211 * pr/20222: Test the Gradle Plugin against Gradle 6.2 Closes gh-20222

view details

Stephane Nicoll

commit sha 0c76c0acb9b0a97c96ad1b93b6edf59b6cad3d0a

Merge branch '2.2.x'

view details

Johnny Lim

commit sha 8be8a8421dd01ece3c0c3f330352479de0c4a098

Polish See gh-20226

view details

Stephane Nicoll

commit sha d65e06081f3a21727265e98df519ab52b0e11381

Update copyright year of changed files See gh-20226

view details

Stephane Nicoll

commit sha fc3fb7fb449165903ce907d1846cfc653b3a2ef3

Merge pull request #20226 from izeye * pr/20226: Update copyright year of changed files Polish Closes gh-20226

view details

dreis2211

commit sha e34cf8955c9ce969f82941479df58f462e004f7c

Include LICENCE and NOTICE files in shipped jars See gh-20058

view details

Andy Wilkinson

commit sha 8128f3090af9c3701bbdc7d99ff62bf9dd95d268

Polish "Include LICENCE and NOTICE files in shipped jars" See gh-20058

view details

Andy Wilkinson

commit sha d73366570a8cd5f3710b7dc13e1ac33982c13650

Merge pull request #20058 from dreis2211 * gh-20058: Polish "Include LICENCE and NOTICE files in shipped jars" Include LICENCE and NOTICE files in shipped jars Closes gh-20058

view details

Scott Frederick

commit sha 8f84dbe3cf7166db38a07440a71735b4375654d8

Harmonize MongoDB client factories This commit brings MongoClientFactory and ReactiveMongoClientFactory into functional alignment and reduces duplication in the classes and their tests. There are no behavior changes to ReactiveMongoClientFactory. MongoClientFactory now throws an exception when a URI is configured along with a host, port, or credentials, where it previousy ignored host, port, and credentials silently. MongClientFactory now also supports MongoClientSettingsBuilderCustomizers. Fixes gh-20019

view details

Scott Frederick

commit sha 6017c1ccac5cd8385083e3b4cd3e9efb51f7ceef

Update MongoDB auto-configuration documentation.

view details

Andy Wilkinson

commit sha 5ae66d4c08ef173a88c4ab5ef0c6a90f99377a61

Start building against Spring Framework 5.1.14 snapshots See gh-20197

view details

Andy Wilkinson

commit sha 29bc5d848e1351f4f7e98cd55d6186650fb7ee35

Start building against Spring Data Lovelace-SR16 snapshots See gh-20198

view details

Andy Wilkinson

commit sha 319ac968f6c9d2e09c1b7b66ad061720008f9cb7

Merge branch '2.1.x' into 2.2.x

view details

Andy Wilkinson

commit sha 56475c19fb749a26502ef632a0ed8fce9f8df358

Merge branch '2.2.x'

view details

Madhura Bhave

commit sha 15cd590f7f6411945e3c2530f4e140641a5ef244

Allow users to opt out of including the layer tools in a layered jar For Maven, the layer configuration is now an additional configuration option instead of a layout type. Closes gh-19866

view details

Madhura Bhave

commit sha c5bce2b99d6c69bee4655f0803a5d3659e6383ae

Fix gradle plugin validation error

view details

push time in 3 days

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha 14ec6158dc75f69a987a3a7eb6a2ed528e9aa473

Link GROOVY-9407 in README

view details

push time in 3 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

I've applied the suggestion in the Groovy ticket above, which seems to work around the behaviour change. At least it's better than copying the old ImportCustomizer logic to SmartImportCustomizer.

dreis2211

comment created time in 4 days

push eventdreis2211/spring-boot

dreis2211

commit sha 4f8aadf60e6637ef8308747245871e9589f0019c

Apply different fix for ImportCustomizer issues

view details

push time in 4 days

push eventdreis2211/spring-boot

dreis2211

commit sha b8124aabd6e4dd0231ad35dbb8537be3fe8f5c58

Rename customJavaHome to buildJavaHome

view details

push time in 4 days

Pull request review commenthibernate/hibernate-orm

HHH-13870 - Extract task action in Gradle plugin to fix up-to-date check

 private void applyEnhancement(final Project project, final HibernateExtension hi  			final Task compileTask = project.getTasks().findByName( sourceSet.getCompileJavaTaskName() ); 			assert compileTask != null;-			compileTask.doLast(-					task -> EnhancementHelper.enhance( sourceSet, hibernateExtension.enhance, project )-			);+			compileTask.doLast(new EnhancerAction( sourceSet, hibernateExtension, project ));

Added a comment

dreis2211

comment created time in 4 days

push eventdreis2211/hibernate-orm

Christoph Dreis

commit sha 7ae59b47064024f4f22795233d679aecbdb12c70

HHH-13870 - Add explaining comment

view details

push time in 4 days

pull request commentspring-projects/spring-boot

Implement possibility to set custom java home for Gradle tasks

Sure...will do so in a couple of minutes.

dreis2211

comment created time in 4 days

PR opened hibernate/hibernate-orm

HHH-13870 - Extract task action in Gradle plugin to fix up-to-date check

See https://hibernate.atlassian.net/browse/HHH-13870

+23 -3

0 comment

1 changed file

pr created time in 4 days

create barnchdreis2211/hibernate-orm

branch : HHH-13870

created branch time in 4 days

push eventdreis2211/hibernate-orm

Yoann Rodière

commit sha 8655d683e68fc335c74affd71f48d627bdb846dd

HHH-13666 Remove some dead code in tests related to transactions

view details

Yoann Rodière

commit sha 250f56933925d8b1b41f1d41f4001762cbd785b2

HHH-13666 Clarify that existing BeforeCompletion/AfterCompletion tests are about JTA only

view details

Yoann Rodière

commit sha f9c149ab0db9215d2fc45837b67b227c0bb5b77b

HHH-13666 Throw a HibernateException with a more appropriate message upon beforeTransactionCompletion/afterTransactionCompletion failure

view details

Yoann Rodière

commit sha 5c8169ba7cd81b5ab9ac282bd5c596f25c7d7f9b

HHH-13666 Re-use the wrapped exception's message upon beforeTransactionCompletion/afterTransactionCompletion failure For convenience.

view details

Yoann Rodière

commit sha 6cdb0256d41e873b67a8a6ce40a6d1ee5a4b6599

HHH-13666 Test custom BeforeTransactionCompletionProcess/AfterTransactionCompletionProcess

view details

Gail Badner

commit sha eccb786ba454ef95cab593d54214cdb60382d1c4

HHH-13634 : Test cases

view details

Gail Badner

commit sha 42de569a37f54fc3eec39fed3cb03ad6e763ddc1

HHH-13634 : PersistenceContext can get cleared before load completes using StatelessSessionImpl

view details

Gail Badner

commit sha 93a07453f0cdf3e764832a22679c8642e3af6fb9

HHH-13634 : Fix test case queries to order results

view details

Andrea Boriero

commit sha 1c840f9dd17c75f1e01667fe26b71753f97c7168

HHH-12858 HHH-13432 fix Oracle failing tests

view details

Christoph Dreis

commit sha 3b1e7afb20ce934abe35150889f02b41be98ca0c

HHH-13675 : Optimize PersistentBag.groupByEqualityHash()

view details

Andrea Boriero

commit sha 8f68a3573e5c244e8ed3986d9d8afbbd2884861a

HHH-13673 Add test for issue

view details

Andrea Boriero

commit sha f39d96f9fa824af1d92541ef5547f9f28e84a3ac

HHH-13673 Cryptic error when providing import.sql file without a terminal char at the end of each line

view details

Yoann Rodière

commit sha cacef1f466ae3215dbd9e270d0f11da0ae230a74

HHH-13680 Upgrade to Byte-buddy 1.10.2

view details

Yoann Rodière

commit sha d83acfa50fd7d121ef28e4b7797e21e48c33897b

HHH-13681 Upgrade to Byteman 4.0.8

view details

Andrea Boriero

commit sha 43402ea51c319cd037c94d858711bf2082dc2e24

HHH-13672 Add test for issue

view details

Andrea Boriero

commit sha 96e7abf80b45c6b25c25b7761d618a2b44fbdbd7

HHH-13672 The temporary PersistenceContext of a StatelessSession is not cleared after a refresh operation

view details

Andrea Boriero

commit sha 5c8045b42212c4f29f54ca9af4da641342250ad5

5.4.7

view details

Andrea Boriero

commit sha 4d0ec22411a6f536f18967113ad0728345827fa0

5.4.7

view details

Sanne Grinovero

commit sha 97c300a6ad03d7fe5843c9e0ac63afe43f649333

HHH-13686 Upgrade to Agroal 1.6

view details

Yosef Yona

commit sha 2808a75d5cefcf7703eb9d3448f25ae998343d22

HHH-13651 NPE on flushing when ElementCollection field contains null element

view details

push time in 4 days

pull request commentspring-projects/spring-boot

Include licence and notice files in shipped jars

Thanks for the proper review, @wilkinsona

dreis2211

comment created time in 4 days

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha 113b1cb604f7ced219c791cea95e1b9a70dfd26b

Remove redundant code for example

view details

push time in 4 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

Here we go: https://issues.apache.org/jira/browse/GROOVY-9407

dreis2211

comment created time in 5 days

push eventdreis2211/spring-boot

Andy Wilkinson

commit sha d8c309a31080f2db548178558522fc11769dd60c

Update gradlew.bat with Gradle 6.2's changes See gh-20213

view details

push time in 5 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

I've finally managed to reproduce it in a minimal example. See https://github.com/dreis2211/groovy3-import-bug

I would open a new issue if that's okay for you, @wilkinsona & @paulk-asert ?

dreis2211

comment created time in 5 days

push eventdreis2211/groovy3-import-bug

Christoph Dreis

commit sha e89ca9c490a6d30efdb8af8370baf1a32b74ac89

Initial commit

view details

push time in 5 days

create barnchdreis2211/groovy3-import-bug

branch : master

created branch time in 5 days

created repositorydreis2211/groovy3-import-bug

created time in 5 days

issue openedgradle/gradle

Documentation to upgrade wrapper is misleading

Hi,

today I upgraded the Gradle wrapper on Spring-Boot to 6.2 (see https://github.com/spring-projects/spring-boot/pull/20213 ).

To my surprise running ./gradlew wrapper --gradle-version 6.2 as stated in the official docs isn't the complete solution. Running another ./gradlew wrapper was necessary to actually update the gradlew.bat.

I have found #884 that talks about the root cause of this, but in the meantime the documentation should be updated to reflect this surprising behaviour.

Cheers, Christoph

created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

At least I'm not crazy. I will report this. And sorry for the inconvenience again.

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

Nope, when I run this on a branch where the update wasn't done yet, the same thing happens. Only line ending changes

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

I will report this to Gradle, if you don't mind.

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

I always followed the official docs: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper . Seems like I should not do that again. Sorry guys

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

@wilkinsona Aren't you on a Mac as well? Really sorry for that, but it feels I had no chance here given that the update didn't make the necessary changes. 😞

Did you execute something else than ./gradlew wrapper --gradle-version=6.2?

dreis2211

comment created time in 5 days

PR opened spring-projects/spring-boot

Test the Gradle Plugin against Gradle 6.2

Hi,

this PR tests the Gradle plugin against Gradle 6.2 as discussed in #20213 .

Cheers, Christoph

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchdreis2211/spring-boot

branch : gradle-plugin-6.2-2.2.x

created branch time in 5 days

push eventdreis2211/spring-boot

Brian Clozel

commit sha e59d3fbb861560de372f8bd186e199f0c7d5e42a

Clear ProducesRequestCondition cache attribute As of spring-projects/spring-framework#22644, Spring Framework caches the "produces" condition when matching for endpoints in the `HandlerMapping` infrastructure. This has been improved in spring-projects/spring-framework#23091 to prevent side-effects in other implementations. Prior to this commit, the Spring Boot actuator infrastructure for `EndpointHandlerMapping` would not clear the cached attribute, presenting the same issue as Spring Framework's infrastructure. This means that a custom arrangement with custom `HandlerMapping` or `ContentTypeResolver` would not work properly and reuse the cached produced conditions for other, unintented, parts of the handler mapping process. This commit clears the cached data and ensures that other handler mapping implementations are free of that side-effect. Fixes gh-20150

view details

Stephane Nicoll

commit sha 16111f126e707fb5064bab6150df7a77f54850ee

Use query-less datasource validation by default This commit changes DataSourceHealthIndicator to validate the connection rather than issuing a query to the database. If a custom validation query is specified, it uses that as before. Closes gh-17582

view details

dreis2211

commit sha 866c441d70c841afa1fe7e3af44a5afd250fcae1

Upgrade to Gradle 6.2 See gh-20213

view details

Andy Wilkinson

commit sha bca1b926ff17be124e53b34c05ceaf94f5363bf4

Merge pull request #20213 from dreis2211 * gh-20213: Upgrade to Gradle 6.2 Closes gh-20213

view details

Stephane Nicoll

commit sha 2147976c178a4eab7ca02ba99cfb53d767e3d8f1

Do not fallback to embedded configuration if a datasource url is set This commit makes sure that a fallback embedded datasource is not created if no suitable connection pool is found and an url has been explicitly registered. This is consistent with EmbeddedDataSourceConfiguration as it is using EmbeddedDatabaseBuilder behind the scenes and the latter does not honour the configured URL anyway. Closes gh-19192

view details

Stephane Nicoll

commit sha 1d60184075a4333ed0f58da4b58bb9cf1ba49829

Merge branch '2.1.x' into 2.2.x Closes gh-20217

view details

Stephane Nicoll

commit sha 287d577aeac516de8b21630b76208d276b7b5fca

Merge branch '2.2.x' Closes gh-20218

view details

Stephane Nicoll

commit sha 4ec30e1145d7221338e420b5727693b5fe073716

Add support for SimpleDriverDataSource This commit makes sure that DataSourceBuilder can configure SimpleDriverDataSource by adding an alias for the driver's class name. Closes gh-20220 Co-authored-by: Dmytro Nosan <dimanosan@gmail.com>

view details

hbellahc

commit sha d890f1f6d8c763c527d3795923befa51254f1f19

Document missing reference to DataSourceHealthIndicator See gh-20216

view details

Stephane Nicoll

commit sha d3535ca15f77906555ac6610750d0d3f2fe72394

Merge pull request #20216 from hbellahc * pr/20216: Document missing reference to DataSourceHealthIndicator Closes gh-20216

view details

Stephane Nicoll

commit sha 363edfa00cc9427be545abc1b41f39df82c7b17b

Merge branch '2.2.x' Closes gh-20221

view details

push time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

Interesting....I only got this:

git diff gradlew.bat
warning: CRLF wird in gradlew.bat durch LF ersetzt.

So essentially the same warning as you but without any changes.

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

@vpavic It only showed line ending changes, so I felt this wasn't necessary. Do you see other changes?

dreis2211

comment created time in 5 days

pull request commentspring-projects/spring-boot

Upgrade to Gradle 6.2

@wilkinsona How do we deal with 2.2.x? Should I open a separate PR for addressing the Gradle Plugin compatibility?

dreis2211

comment created time in 5 days

Pull request review commentspring-projects/spring-boot

Include licence files in shipped jars

 private void applyJavaConventions(Project project) { 		}); 	} +	private void copyLegalFiles(Project project, CopySpec metaInf) {+		copyNoticeFile(project, metaInf);+		copyLicenseFile(project, metaInf);+	}++	private void copyNoticeFile(Project project, CopySpec metaInf) {+		try {+			InputStream notice = getClass().getClassLoader().getResourceAsStream("NOTICE.txt");+			String noticeContent = FileCopyUtils.copyToString(new InputStreamReader(notice, StandardCharsets.UTF_8))+					.replace("${version}", project.getVersion().toString())+					.replace("${currentYear}", Integer.toString(Year.now().getValue()));+			metaInf.from(project.getResources().getText().fromString(noticeContent),

After the latest changes I get the following:

 ./gradlew :spring-boot-project:spring-boot-properties-migrator:jar

BUILD SUCCESSFUL in 1s
9 actionable tasks: 9 up-to-date

Previously, I got the following:

 ./gradlew :spring-boot-project:spring-boot-properties-migrator:jar

BUILD SUCCESSFUL in 1s
9 actionable tasks: 2 executed, 7 up-to-date

Thanks for the good catch, @wilkinsona

dreis2211

comment created time in 5 days

push eventdreis2211/spring-boot

dreis2211

commit sha 1151f5e853a79c26147f48e84962e9bee23874ae

Prevent legal files from changing up-to-date status

view details

push time in 5 days

Pull request review commentspring-projects/spring-boot

Include licence files in shipped jars

 private void applyJavaConventions(Project project) { 		}); 	} +	private void copyLegalFiles(Project project, CopySpec metaInf) {+		copyNoticeFile(project, metaInf);+		copyLicenseFile(project, metaInf);+	}++	private void copyNoticeFile(Project project, CopySpec metaInf) {+		try {+			InputStream notice = getClass().getClassLoader().getResourceAsStream("NOTICE.txt");+			String noticeContent = FileCopyUtils.copyToString(new InputStreamReader(notice, StandardCharsets.UTF_8))+					.replace("${version}", project.getVersion().toString())+					.replace("${currentYear}", Integer.toString(Year.now().getValue()));+			metaInf.from(project.getResources().getText().fromString(noticeContent),

I tried that and that didn't work. Will take a look again.

dreis2211

comment created time in 5 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

I will investigate a bit further, @wilkinsona if you don't mind and report back if I could find something.

dreis2211

comment created time in 5 days

Pull request review commentspring-projects/spring-boot

Include licence files in shipped jars

 private void applyJavaConventions(Project project) { 		}); 	} +	private void copyLegalFiles(Project project, CopySpec metaInf) {+		copyNoticeFile(project, metaInf);+		copyLicenseFile(project, metaInf);+	}++	private void copyNoticeFile(Project project, CopySpec metaInf) {+		try {+			InputStream notice = getClass().getClassLoader().getResourceAsStream("NOTICE.txt");+			String noticeContent = FileCopyUtils.copyToString(new InputStreamReader(notice, StandardCharsets.UTF_8))+					.replace("${version}", project.getVersion().toString())+					.replace("${currentYear}", Integer.toString(Year.now().getValue()));+			metaInf.from(project.getResources().getText().fromString(noticeContent),

I will take a look how it was done there and report back

dreis2211

comment created time in 5 days

PR opened spring-projects/spring-boot

Upgrade to Gradle 6.2

Hi,

this PR updates the project to Gradle 6.2 and updates the Gradle Plugin accordingly to test against 6.1.1 in addition to the new default.

Cheers, Christoph

+3 -3

0 comment

2 changed files

pr created time in 5 days

create barnchdreis2211/spring-boot

branch : gradle-6.2

created branch time in 5 days

push eventdreis2211/spring-boot

dreis2211

commit sha 4f824bf9ad572af675f8cde21c6337de8467891d

Fix duplicate words See gh-20210

view details

Stephane Nicoll

commit sha c53d4f2bf1900697b5a6986ba63a418b7d7717e8

Merge pull request #20210 from dreis2211 * pr/20210: Fix duplicate words Closes gh-20210

view details

push time in 5 days

push eventdreis2211/spring-boot

dreis2211

commit sha 76d2bc27eb95b2b2e3de7db53758bc441b812ab5

Explicitly set java home in Maven Plugin integration tests See gh-20193

view details

Andy Wilkinson

commit sha dcbbe20d41c46e6373655d03a11bb868ce8621f3

Merge pull request #20193 from dreis2211 * gh-20193: Explicitly set java home in Maven Plugin integration tests Closes gh-20193

view details

push time in 5 days

PR opened spring-projects/spring-boot

Fix duplicate words

Hi,

this PR fixes a couple of duplicate/redundant words in comments.

Cheers, Christoph

+3 -3

0 comment

3 changed files

pr created time in 6 days

create barnchdreis2211/spring-boot

branch : fix-duplicate-words-in-comments

created branch time in 6 days

push eventdreis2211/spring-boot

dreis2211

commit sha a9dabe13bb4b1bb53256d9f9802c40dc1e4e5005

Remove redundant useJUnitPlatform declarations See gh-20206

view details

Stephane Nicoll

commit sha 6a0cef8015be10de958f7611558e369b414d238f

Merge pull request #20206 from dreis2211 * pr/20206: Remove redundant useJUnitPlatform declarations Closes gh-20206

view details

Mike Smithson

commit sha 020ae2c7baaed85920336fe67db3b9cccfbfe3d9

Revisit PluginXmlParserTests See gh-20190

view details

Stephane Nicoll

commit sha 3ba411e04d2aab74b0dfd39d7f855d8a2fe726a5

Polish "Revisit PluginXmlParserTests" See gh-20190

view details

Stephane Nicoll

commit sha 5cb24c2584dfb67269552ec5969a64b54d71ab3f

Merge pull request #20190 from mikesmithson * pr/20190: Polish "Revisit PluginXmlParserTests" Revisit PluginXmlParserTests Closes gh-20190

view details

Eddú Meléndez

commit sha 407e237f109dc5a34a724c7cf3f39300baaa4578

Add support for configuring Liquibase tag property See gh-19316

view details

Stephane Nicoll

commit sha 4bcf4245d1d6e7b655b516125d3c89821069bf0c

Polish "Add support for configuring Liquibase tag property" See gh-19316

view details

Stephane Nicoll

commit sha d4c7315369e7e9dce6eb1c77e5f23d1e670247c8

Merge pull request #19316 from eddumelendez * pr/19316: Polish "Add support for configuring Liquibase tag property" Add support for configuring Liquibase tag property Closes gh-19316

view details

push time in 6 days

pull request commentspring-projects/spring-boot

Implement possibility to set custom java home for Gradle tasks

That's unavoidable for JDK 14 with Gradle's current capabilities no matter which approach we take so maybe it's not so bad.

Exactly. It feels like we're discussing the bigger picture (which I enjoy) while this PR seems needed anyway for the time being and is only a tiny piece of the complete JDK 14 CI process...

dreis2211

comment created time in 6 days

PR opened spring-projects/spring-boot

Remove redundant useJUnitPlatform declarations

Hi,

this PR removes two usages of useJUnitPlatform that should be redundant as they're applied via the ConventionsPlugin already.

Cheers, Christoph

+0 -4

0 comment

2 changed files

pr created time in 7 days

create barnchdreis2211/spring-boot

branch : redundant-use-junit-platform

created branch time in 7 days

push eventdreis2211/spring-boot

Andy Wilkinson

commit sha bf8ed44453e18a40fe889d55ceb6d7936dedefca

Upgrade to Spring AMQP 2.2.4.RELEASE Closes gh-20106

view details

Andy Wilkinson

commit sha ff4de95b3eecbdba0567a19ff5e0cab83415a51c

Merge branch '2.2.x'

view details

zhangt2333

commit sha e2d87a89d0ab942df53e3029e1fe42411732a81f

Polish See gh-20192

view details

Stephane Nicoll

commit sha 03bee839917ce819b1c4056be4231dd7e815a233

Update copyright date See gh-20192

view details

Stephane Nicoll

commit sha 6fc25a309c1385d08e4ca035d0c3eb554494ef03

Merge pull request #20192 from zhangt2333 * pr/20192: Update copyright date Polish Closes gh-20192

view details

push time in 7 days

PR opened spring-projects/spring-boot

Explicitly set java home in Maven Plugin integration tests

Hi,

I'm regularly switching between JDKs at the moment and noticed that RunIntegrationTests fails if IDEA is setup with JDK 13+ while the actual Java home (e.g. inside the terminal) is set to something lower.

This PR sets the Java home explicitly on the InvocationRequest in MavenBuild, so the Java version for the maven invocation matches the one that actually runs the test.

Cheers, Christoph

+1 -0

0 comment

1 changed file

pr created time in 8 days

create barnchdreis2211/spring-boot

branch : java-home-maven-build-integration-tests

created branch time in 8 days

push eventdreis2211/spring-boot

Stephane Nicoll

commit sha 32c1dd45a927e7620e4c2b5b5a7cb27fe39dcd21

Revert "Merge pull request #19926 from xak2000" Closes gh-19926

view details

Stephane Nicoll

commit sha 2ede9e63b9473333be406f103aed15df3121b4b5

Merge branch '2.1.x' into 2.2.x Closes gh-20117

view details

Stephane Nicoll

commit sha e3383b614c0e8f045a1aee74dbffe3de5e74f82d

Merge branch '2.2.x'

view details

Dave Syer

commit sha dcaaf9785f29b7aafe8a1377a89d0f013ee70b04

Remove duplicate auto-configuration class See gh-20168

view details

Stephane Nicoll

commit sha fc410f05722357ab155997317a9ecdf274cd2edd

Merge pull request #20168 from dsyer * pr/20168: Remove duplicate auto-configuration class Closes gh-20168

view details

Stephane Nicoll

commit sha a6fdbdcd80c199d40d1455c6c42a8a1b828a9811

Merge branch '2.2.x' Closes gh-20178

view details

Andy Wilkinson

commit sha c8907d46b40348f47a60055ca4016a6cba95d90c

Fix up-to-date checking of build info properties Closes gh-20135

view details

cbono

commit sha 852734b1296a0df108ac1d571072759412853cbf

Add support for configuring Jetty's backing queue See gh-19494

view details

Andy Wilkinson

commit sha d61b035640d4929fc4331aaa66542afdef9b7e27

Merge branch '2.1.x' into 2.2.x Closes gh-20183

view details

Stephane Nicoll

commit sha b56c4f1a4d89542089b538fefe2d95c2a6372edf

Polish "Add support for configuring Jetty's backing queue" See gh-19494

view details

Stephane Nicoll

commit sha f8173eb76dbf38706346947e6d510a48e026f4f9

Merge pull request #19494 from bono007 * pr/19494: Polish "Add support for configuring Jetty's backing queue" Add support for configuring Jetty's backing queue Closes gh-19494

view details

Juzer Ali

commit sha 30f7f9c9c4db53073cd86418dfc46c71f17c87d2

Document sanitized keys and uri sanitization behavior See gh-20169

view details

Stephane Nicoll

commit sha 40d1727cc53f1498c5e902d4e7cc76033a8c9a14

Polish "Document sanitized keys and uri sanitization behavior" See gh-20169

view details

Stephane Nicoll

commit sha 7a114995b38e707ff2de6f1892de6b4747b9a5f2

Merge pull request #20169 from juzerali * pr/20169: Polish "Document sanitized keys and uri sanitization behavior" Document sanitized keys and uri sanitization behavior Closes gh-20169

view details

Stephane Nicoll

commit sha ddeac66ca28860d3a0d8a03e91c1b411ff578c9c

Merge branch '2.2.x' Closes gh-20186

view details

Andy Wilkinson

commit sha b9c2d775a96f1fde45b4a85c695e07b0fb0f7120

Merge branch '2.2.x' Closes gh-20185

view details

Andy Wilkinson

commit sha e065ee7be2b1497cdde634e91a0e30a56dcef996

Merge branch '2.1.x' into 2.2.x Closes gh-20183

view details

Andy Wilkinson

commit sha d1aa8c02f93ae9096b2f7c44e6b0ae06e48b1066

Merge branch '2.2.x'

view details

Madhura Bhave

commit sha 4ac12660c650d233f8a64e324b3d87b5dfd80fe5

Explicitly enable config properties scan in java release scripts This commit also upgrades the Spring Boot version used by the scripts to 2.2.4 which is why the explicit annotation is required. Closes gh-20174

view details

Madhura Bhave

commit sha 0ec1ed4642633902f3d4fcae6f129e928b2ac448

Merge branch '2.2.x' Closes gh-20188

view details

push time in 8 days

pull request commentspring-projects/spring-boot

Implement possibility to set custom java home for Gradle tasks

This applies to our JDK 11 and 13 builds too

I have trouble to actually see where the JDK 11+ builds do compile with JDK 8. Or do you mean that they do exactly the same as proposed here? And you simply wonder if that's the right approach?

Anyhow, I do see some value in compiling with the newer JDK versions as that will show deprecation warnings etc. E.g. compiling with JDK 11 shows warnings about using Class.newInstance() instead of Class.getDeclaredConstructor().newInstance().

For the javadocs, this overlaps with #17259 if you ask me. Again, I see some value in generating them with the respective versions as that will show eventual changes in behaviour better. Similar to what @snicoll mentioned there already.

In summary, being aware of changes on the JDK level - let it be on compiler, javadoc or test side - is imho beneficial. But I'm also fine with removing the javadoc & compile part if you really want me to.

dreis2211

comment created time in 9 days

pull request commentspring-projects/spring-boot

Implement possibility to set custom java home for Gradle tasks

Anything I can do to help? I'm a bit confused what you want me to do ;-)

dreis2211

comment created time in 9 days

PR opened spring-projects/spring-boot

Fix some tests that fail with JDK 14

Hi,

this PR fixes two tests that break when running with JDK 14 as discussed in #20147 .

There are obviously more build failures, but these were quick wins.

Cheers, Christoph

+8 -3

0 comment

2 changed files

pr created time in 9 days

create barnchdreis2211/spring-boot

branch : first-jdk14-test-fixes

created branch time in 9 days

PR opened spring-projects/spring-boot

Implement possibility to set custom java home for Gradle tasks

Hi,

as discussed in #20147 this PR should give us a first insight into what might be broken with JDK 14.

The new functionality can be used like this:

./gradlew -PcustomJavaHome=/Users/christoph.dreis/.sdkman/candidates/java/14-ea

I specifically implemented a check for emptiness of the new property in preparation for an eventual CI. By that we could simply set it for JDK 14 builds and leave it empty for the others. That should keep the build-project.sh relatively simple.

Let me know what you think. Cheers, Christoph

+24 -2

0 comment

1 changed file

pr created time in 9 days

create barnchdreis2211/spring-boot

branch : custom-java-home-gradle

created branch time in 9 days

issue commentspring-projects/spring-boot

Add Java 14 CI

I can offer to provide some stuff for JDK 14 in general in smaller chunks, if that's okay for you? I already have a couple of things ( see my jdk-14-wip branch ) but to make one big PR at which end we have a (green) CI for JDK 14 I'm missing the time, at the moment. I could offer the following 3 PRs (or at least independent commits) for now based on the WIP branch:

  • Implement possibility to specify custom java home (so you guys can play around with it too locally)
  • Fix JarFileTests for multi release jars on JDK 14
  • Fix NoSuchBeanDefinitionFailureAnalyzerTests on JDK 14 (see JDK-8164819 & related tickets for the background )

Let me know what you think. Cheers, Christoph

snicoll

comment created time in 9 days

create barnchdreis2211/spring-boot

branch : jdk-14-wip

created branch time in 9 days

push eventdreis2211/spring-boot

Stephane Nicoll

commit sha cd11b74db7cc7f121ac3eedba7c9c309fd382c7d

Remove usage of Infinispan BOM Closes gh-20154

view details

Stephane Nicoll

commit sha db1c9f4058f817a0cace4d0939f1401e42d58da4

Remove plugin management for infinispan-protocol-parser-generator Closes gh-20155

view details

dreis2211

commit sha e1f743a21b7def869936142495cfb84f882c2266

Upgrade CI to Docker 19.03.5 See gh-20157

view details

Stephane Nicoll

commit sha 41b054460bf1a3e4fcdf18eb9ad41919782bf015

Merge pull request #20157 from dreis2211 * pr/20157: Upgrade CI to Docker 19.03.5 Closes gh-20157

view details

dreis2211

commit sha 23bf948101a83e811e53b1c2a22acdb3421f06ea

Upgrade to Asciidoctor Gradle JVM 3.0.0 See gh-19953

view details

Andy Wilkinson

commit sha f2a1840c88e530fe2786ee258046aa2dc0f339bd

Merge pull request #19953 from dreis2211 * gh-19953: Upgrade to Asciidoctor Gradle JVM 3.0.0 Closes gh-19953

view details

Andy Wilkinson

commit sha 8577a39a964a05f37b68ade0fe2f7a132068c794

Upgrade to Spring Asciidoctor Extensions 0.4.1.RELEASE Closes gh-20158

view details

Andy Wilkinson

commit sha 903a4a48e8a426c7bb4c6abf5c6000c1bc2e6810

Fix configuration property references in the reference docs Previously, the configprop macro was being used in the source but the extension that implements the macro was not available to Asciidoctor. This led to the references not being checked at build time and the macro being left as-is in the rendered documentation. This commit updates the dependencies that are available to Asciidoctor to include the extension and the projects which define the configuration properties referenced in the documentation. Closes gh-20149

view details

Stephane Nicoll

commit sha 06c85e96c3c66fc711f246bbb255872d067f99b8

Merge branch '2.1.x' into 2.2.x Closes gh-20159

view details

Stephane Nicoll

commit sha 475169a80e2c4573f86551ede380a339f57da944

Merge branch '2.2.x' Closes gh-20160

view details

Andy Wilkinson

commit sha 68f59a0d4042c8ded24f77b87386f98b60742a67

Move dependency management for JNA into spring-boot-parent Previously, dependency management for JNA was provided by spring-boot-dependencies so it affected users' applications. It was original added for Elasticsearch but is no longer needed for that purpose. We use JNA in spring-boot-buildpack-platform which is used by our Gradle and Maven plugins and should not affect an application's use of JNA. This commit moves management of JNA from spring-boot-dependencies into spring-boot-parent. This means that users' applications will now be free to use whatever version of JNA meets their needs while still controlling the version used for image building via Gradle or Maven. Closes gh-20156

view details

Stephane Nicoll

commit sha 362297a010083b655903aec0c4d1976293c31da8

Fix formatting

view details

Stephane Nicoll

commit sha 738e8b39c7cb096a685ca051a557ffa4c1b185b0

Upgrade to spring javaformat 0.0.20

view details

Stephane Nicoll

commit sha b8ccfbafd00f23b3cbc1993dcbc042a49dbf8458

Upgrade to Spring Boot 2.2.4

view details

Stephane Nicoll

commit sha faaf9a7e0c5b33e190ae7ca18985c1d4f83a9525

Upgrade to SendGrid 4.4.4 Closes gh-20092

view details

Stephane Nicoll

commit sha ca4d5b13339c74958c475c918b5012ab2f4f877c

Upgrade to Flyway 6.2.3 Closes gh-20161

view details

Stephane Nicoll

commit sha 5f826cdbd2dddd08748ad3defd046addc5214b03

Upgrade to Hibernate 5.4.11.Final Closes gh-20162

view details

Stephane Nicoll

commit sha be58d1a3100c8f2300e3a2fc1581a339d8079273

Upgrade to Infinispan 10.1.2.Final Closes gh-20163

view details

Stephane Nicoll

commit sha 8212ee49b3608be29432c1fac31b19e1220e20a8

Upgrade to Lettuce 5.2.2.RELEASE Closes gh-20164

view details

Stephane Nicoll

commit sha 4d51a16b11ab4c6576c7ca0fc209614d45830cc9

Upgrade to Liquibase 3.8.6 Closes gh-20165

view details

push time in 9 days

PR opened spring-projects/spring-boot

Upgrade to Docker 19.03.5 in CI

Hi,

this PR upgrades to Docker 19.03.5 in the CI setup. It's almost impossible for me to test this locally in a proper way, so feel free to decline the PR.

Cheers, Christoph

+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchdreis2211/spring-boot

branch : docker-ci-19.03.5

created branch time in 10 days

push eventdreis2211/spring-boot

Andy Wilkinson

commit sha 5fed25bb43a337eac367f347ac893f054844fa5e

Upgrade to Spring HATEOAS 1.1.0.M2 Closes gh-20142

view details

Andy Wilkinson

commit sha 2f16898c5f9f30fe4d4a506ee00785a18f567a7c

Upgrade to Spring Data Neumann-M3 Closes gh-20103

view details

dreis2211

commit sha 92b4ba6367a26a852250a24de83452dd7fbcc4e7

Fix structuring your code link in multi-page HTML documentation Closes gh-19953

view details

Andy Wilkinson

commit sha 420af175709de8550d44b8cc7d7e2d05fd7ce056

Merge branch '2.2.x' Closes gh-20148

view details

Brian Clozel

commit sha 97af0b2f3a0a39c0eeebbbf0f7a514db1d35eac3

Add actuator specific ObjectMapper Prior to this commit, Actuator endpoints would use the application ObjectMapper instance for serializing payloads as JSON. This was problematic in several cases: * application-specific configuration would change the actuator endpoint output. * choosing a different JSON mapper implementation in the application would break completely some endpoints. Spring Boot Actuator already has a hard dependency on Jackson, and this commit uses that fact to configure a shared `ObjectMapper` instance that will be used by the Actuator infrastructure consistently, without polluting the application context. This `ObjectMapper` is used in Actuator for: * JMX endpoints * Spring MVC endpoints with an HTTP message converter * Spring WebFlux endpoints with an `Encoder` * Jersey endpoints with a `ContextResolver<ObjectMapper>` For all web endpoints, this configuration is limited to the actuator-specific media types such as `"application/vnd.spring-boot.actuator.v3+json"`. Fixes gh-12951

view details

Scott Frederick

commit sha 191dce3f5e7c6aef43f8b9c122758e2aef34cb9b

Set Spring Boot version in ephemeral builder This commit adds a `createdBy` structure to the metadata of the ephemeral builder container image that identifies Spring Boot as the creator of the image, along with the Spring Boot version. See gh-20126

view details

Scott Frederick

commit sha e294d26458a198f29f8562771c60081b49ddfceb

Set ephemeral builder container creation to a fixed date This commit fixes the `Created` date and time of the ephemeral builder container image at the Windows epoch plus one second (1980-01-01T00:00:01Z). This date matches the created date of the builder image and influences the created date of the resulting image. Using a fixed date for images ensures that the digest is consistent for all images with the same version. Fixes gh-20126

view details

Andy Wilkinson

commit sha f22aeda0cefbc714254b85142c61f9331912a1ee

Upgrade to Spring Kafka 2.4.2.RELEASE Closes gh-20107

view details

Andy Wilkinson

commit sha 9860f9705c84a50a6921da593448b0623c503426

Upgrade to Spring AMQP 2.2.4.RELEASE Closes gh-20105

view details

Andy Wilkinson

commit sha 7970bf243736569bb268d29ff23d747a1c177fa3

Upgrade to Spring Integration 5.3.0.M2 Closes gh-20104

view details

Russell Scheerer

commit sha d61029a37aaba0a66c23631bb587311a74da1284

Fix Spring Boot version reference in spring-boot-starter-parent See gh-20143

view details

Stephane Nicoll

commit sha 90f7a3fd327901a6d7e4f01e2b5c2bcac979ca6a

Merge pull request #20143 from scheerer * pr/20143: Fix Spring Boot version reference in spring-boot-starter-parent Closes gh-20143

view details

push time in 10 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

I wonder if there's value in communicating the ImportCustomizer issues to the Groovy team. I tried isolating an example, but wasn't successful. What do you think?

dreis2211

comment created time in 10 days

pull request commentspring-projects/spring-boot

Upgrade to Asciidoctor Gradle JVM 3.0.0

Pushed an updated version

dreis2211

comment created time in 11 days

push eventdreis2211/spring-boot

dreis2211

commit sha d63ec9bebefc3f1cabaa0f5473cdd0ed2ecba489

Escape < and > properly in PDF documentation

view details

push time in 11 days

pull request commentspring-projects/spring-boot

Upgrade to Asciidoctor Gradle JVM 3.0.0

Interesting....I wonder why this didn't fail for me locally?

dreis2211

comment created time in 11 days

issue commentspring-projects/spring-boot

Add Java 14 CI

This time you beat me to it :D

snicoll

comment created time in 11 days

pull request commentspring-projects/spring-boot

Include licence files in shipped jars

Okay it was an hour, but it should be done now. Let me know if this is what you had in mind.

BTW: I have a bit of trouble to run the tests in buildSrc from IDEA which makes it quite a bit harder to debug them. Is there any trick to it?

dreis2211

comment created time in 11 days

push eventdreis2211/spring-boot

dreis2211

commit sha 6e199fda1dfbe897c60e892299315be49b9c7996

Include NOTICE and LICENSE file from buildSrc resources

view details

push time in 11 days

pull request commentspring-projects/spring-boot

Include licence files in shipped jars

Sure, @wilkinsona . Give me a minute or two.

dreis2211

comment created time in 11 days

pull request commentspring-projects/spring-boot

Exclude jcl-over-slf4j also on Reactive Cassandra starter

The failures after merging are due to #19931 and #17259

dreis2211

comment created time in 11 days

push eventdreis2211/spring-boot

dreis2211

commit sha 450ef36c7237ca4d3218c10dfbc25b08f0c443fa

Exclude jcl-over-slf4j also on Reactive Cassandra starter See gh-20141

view details

Stephane Nicoll

commit sha 1b4a3dfa77371fffd8849b3d5a6c33cf29840892

Merge pull request #20141 from dreis2211 * pr/20141: Exclude jcl-over-slf4j also on Reactive Cassandra starter Closes gh-20141

view details

push time in 11 days

PR opened spring-projects/spring-boot

Exclude jcl-over-slf4j also on Reactive Cassandra starter

Hi,

the missing exclude for jcl-over-slf4j is currently failing the build.

Cheers, Christoph

+3 -1

0 comment

1 changed file

pr created time in 11 days

create barnchdreis2211/spring-boot

branch : fix-missing-exclude

created branch time in 11 days

push eventdreis2211/spring-boot

Hans Schulz

commit sha 6828a15d31ac7d1ca1bfd560cfa05c393b3b7128

Handle JSON keys containing a dot from CF environment as a single path segment See gh-18915

view details

Madhura Bhave

commit sha 544dca7f1b8a2adf7921f7c56b86f7abb8f37964

Polish contribution Along with surrounding map keys with dot from VCAP_SERVICES with `[ ]`, this commit also does that for non-alphanumeric and `-` characters so that they are not stripped off later. See gh-18915

view details

Madhura Bhave

commit sha 3917968d2acb67fce6b82eab770f0c74b9f11b6b

Merge pull request #18915 from schulzh * pr/18915: Polish contribution Handle JSON keys containing a dot from CF environment as a single path segment Closes gh-18915

view details

Madhura Bhave

commit sha d1c76995394521760eddada276958a3eb7da69bd

Merge branch '2.1.x' into 2.2.x Closes gh-20129

view details

Madhura Bhave

commit sha c5ffe198afe53b18efa23f78d02c8238a5f39aec

Merge branch '2.2.x' Closes gh-20130

view details

Madhura Bhave

commit sha 747eab020de4e879cbd27e4bd1a2159693380537

Update copyright of changed files

view details

Madhura Bhave

commit sha 3bdd91a1190e378738c2ce32e4034bc251c3e588

Merge branch '2.1.x' into 2.2.x

view details

Madhura Bhave

commit sha a5a2d52ee3942f8a4acc8d2509d50f1566f8307e

Merge branch '2.2.x'

view details

cbono

commit sha e3516059622a09ea2ff439daffaeb87c649d9667

Verify ssl key alias on server startup See gh-19202

view details

Madhura Bhave

commit sha ac91f14f05ccf7d2198f6e313f03a5c73cc1c296

Polish "Verify ssl key alias on server startup" See gh-19202

view details

Madhura Bhave

commit sha 8bce2704454dfa07fce785ba6e51714c3942b236

Merge pull request #19202 from bono007 * pr/19202: Polish "Verify ssl key alias on server startup" Verify ssl key alias on server startup Closes gh-19202

view details

Madhura Bhave

commit sha 98a657fedbd1f16e14cce727bb354f8cdcc18d4d

Merge branch '2.1.x' into 2.2.x Closes gh-20132

view details

Madhura Bhave

commit sha 8d9b1d29886985b476f9614f8e524867cdb25d76

Merge branch '2.2.x' Closes gh-20133

view details

Madhura Bhave

commit sha 97ac6c9de740a09f4b9e4dfe0770599d78552723

Polish

view details

Madhura Bhave

commit sha 4eb71fc424b14f78bc9b8ba678ef613ba8d3e760

Merge branch '2.1.x' into 2.2.x

view details

Madhura Bhave

commit sha fe325c06c210fe525b7e1bfdb5c8bebb708b634b

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha d19920ae39a2d2b42ca17bdedc339db1d05b3a8c

Upgrade to Cassandra Driver 4.4.0 Closes gh-20064

view details

push time in 11 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

The groovy-3.0.0 branch should now be green (at least it is locally).

dreis2211

comment created time in 12 days

push eventdreis2211/spring-boot

Madhura Bhave

commit sha ec42dcd1739317d94359f6a25038ec0cf369fe3d

Fix typo

view details

Madhura Bhave

commit sha d485708f6814df433aae6b72a97a0fbaa1a60513

Fix 404 when composite contributor is added to a group Fixes gh-19974

view details

Madhura Bhave

commit sha 19b7dc8e4f7381f7b7f532454c809cd99b0c6bc6

Merge branch '2.2.x' Closes gh-20114

view details

Stephane Nicoll

commit sha 85eb279b30f9f6d99f5eaf83bdcd3b4bec22efdc

Reintroduce "Add Gradle Wrapper Validation GitHub Action" Closes gh-19762

view details

Jorge Cordoba

commit sha 547fc30eadef7fc7d505932ad066c06aafdfa032

Fix condition source in OnBeanCondition See gh-19948

view details

Stephane Nicoll

commit sha 66809c6c1e2c36e12981419c2f26aa493a45e658

Polish "Fix condition source in OnBeanCondition" See gh-19948

view details

Stephane Nicoll

commit sha b4d118e0411375a1ef9caca5d3813dffda70edd3

Merge pull request #19948 from jcordoba95 * pr/19948: Polish "Fix condition source in OnBeanCondition" Fix condition source in OnBeanCondition Closes gh-19948

view details

Stephane Nicoll

commit sha 32bd845a7d2502ecede74080f776439c12632030

Merge branch '2.2.x' Closes gh-20116

view details

Ruslan Stelmachenko

commit sha 5f7e1ac4f2c4268da79a000bac88f8cfc40304e4

Remove unnecessary leading slash in changelog locations See gh-19926

view details

Stephane Nicoll

commit sha ec14e82312cc0681f965f9c9438e7e0024e868ea

Polish "Remove unnecessary leading slash in changelog locations" See gh-19926

view details

Stephane Nicoll

commit sha 4c0c0aeb42bf0d86b49d32f7ffaf301aa1fc8572

Merge pull request #19926 from xak2000 * pr/19926: Polish "Remove unnecessary leading slash in changelog locations" Remove unnecessary leading slash in changelog locations Closes gh-19926

view details

Stephane Nicoll

commit sha a425cc1b466cca6dc61daa0d2119f254e3291ba1

Merge branch '2.1.x' into 2.2.x Closes gh-20117

view details

Stephane Nicoll

commit sha 466c1ba251e7b6f24378f1df9fc7eda3bf79989c

Merge branch '2.2.x' Closes gh-20118

view details

Stephane Nicoll

commit sha 25e87620d3527fbda30bfe89447e52883c2b6244

Fix broken smoke test See gh-19926

view details

Stephane Nicoll

commit sha 1e435372125d33f65a52b5885cd345a024ffb870

Fix broken smoke test See gh-19926

view details

Stephane Nicoll

commit sha 1306c9b77eab8b3330fdaeb0e92a9a69a4fb17e0

Merge branch '2.2.x'

view details

Stephane Nicoll

commit sha 2a90c3dea4ff47ecc2bdeab01e1118fa988d75a2

Fix broken smoke test See gh-19926

view details

Stephane Nicoll

commit sha 5f584101c62023dafab0e9590b5d84f7fc3b5a53

Merge branch '2.1.x' into 2.2.x

view details

Stephane Nicoll

commit sha 765b2178d17d6abe1dd67c6e786ec80297ee8b75

Document spring-boot.run.arguments behaviour with multiple arguments Closes gh-19998

view details

Stephane Nicoll

commit sha 322914218845f49f615627deb71a6a6f7978bc8e

Merge branch '2.2.x' Closes gh-20121

view details

push time in 12 days

push eventdreis2211/spring-boot

dreis2211

commit sha f906af6aa3ee728f8568cddec732b91ab4763249

Fix SampleIntegrationTests

view details

push time in 12 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

I think I nailed it down to the changes made in https://issues.apache.org/jira/browse/GROOVY-8399 for the ImportCustomizer. It seems that they cause the import processing to be skipped on the Application class as it has already been done for the beans classnode. The naive approach of copying the old mechanism to Boot's SmartImportCustomizer fixes the failing bean test.

dreis2211

comment created time in 12 days

push eventdreis2211/spring-boot

dreis2211

commit sha 87835e290ce466689ac61c5b0c1ef7a48e599385

Upgrade to Spock 2.0-M2

view details

push time in 12 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

spock-2.0-M2 has Groovy 3.x support, but I doubt there will be a final release in time.

dreis2211

comment created time in 12 days

issue commentspring-projects/spring-boot

Upgrade to Groovy 3.0.0

It might on Boot side though. I just couldn't find anything on Boot side, yet. And as the beans support is in the Framework I was thinking that it might needs investigation there. Spring-Framework is only using 3.x if a custom java home is set, so in the end it's not really included, just on the CI as far as I got it. See https://github.com/spring-projects/spring-framework/commit/d521d37f14f03688a17b6657df30ff533f2d5f9f

dreis2211

comment created time in 12 days

issue openedspring-projects/spring-boot

Upgrade to Groovy 3.0.0

Hi,

as Groovy 3.0.0 is finally released, I was wondering if Spring-Boot should support it. I initially hoped that the upgrade would be easy enough, but there are some things that seem to be not working when I upgrade it. I have a WIP branch where you can see the changes I made so far: https://github.com/spring-projects/spring-boot/compare/master...dreis2211:groovy-3.0.0

Specifically, the Spock framework worries me a bit, because we pull in org.spockframework:spock-core:1.3-groovy-2.5. Also the other tests that seem to fail seem to require further investigation and might needs work on Spring-Framework side (see the bean test that I disabled).

Given that Groovy 2.5.x doesn't really support JDK 14, I thought it might be a good point in time to discuss this as 2.3.0 is not out yet, but on the other hand it's already quite late in its development.

Anyhow, I wanted to start a discussion on this. ;-)

Cheers, Christoph

created time in 12 days

create barnchdreis2211/spring-boot

branch : groovy-3.0.0

created branch time in 12 days

issue commentgradle/gradle

Gradle 5.5.1 fails with the latest JDK 14 EA build

Groovy 3.0.0 is finally available

kevinrushforth

comment created time in 12 days

PR opened spring-projects/spring-boot

Remove redundant jar task configuration

Hi,

I just noticed that we have a jar configuration in spring-boot-gradle-plugin that seems redundant given that we apply the conventions plugin, which should add this. Am I missing something?

Cheers, Christoph

+0 -6

0 comment

1 changed file

pr created time in 13 days

create barnchdreis2211/spring-boot

branch : remove-redundant-jar-config

created branch time in 13 days

pull request commentspring-projects/spring-boot

Include licence files in shipped jars

I've added a test, @snicoll . Deciding what LICENSE.txt and/or if a notice.txt should be added, seems to outside of my hands at the moment, but I'm happy to add anything after you made a decision.

dreis2211

comment created time in 13 days

push eventdreis2211/spring-boot

dreis2211

commit sha 22c20347d123509bc86f2cca3faa4ff2e84829dc

Add test for adding license file to jar

view details

push time in 13 days

more