profile
viewpoint
Daniel, Dao Quang Minh dqminh @cloudflare London, UK

fork dqminh/gcc

fork in 7 days

startedSpiderLabs/ModSecurity

started time in 2 months

startedsozu-proxy/sozu

started time in 2 months

pull request commentgoogle/cadvisor

Add support for go module

@dashpole looks like the original go-bindata repository was foobar, i have switched the one we used here to https://github.com/kevinburke/go-bindata which seems to be in better shape.

The only other version bump we did here was related to some runc dependencies that go module seems to get wrong, i spotcheck a few other dependencies and they seem to stay the same.

dqminh

comment created time in 2 months

push eventdqminh/cadvisor

Daniel Dao

commit sha 8df190ec4a3a627ac154489674540cc34e84e4a3

bump dependencies of several runc packages Somehow the dependencies retrieved by `go mod init` was mismatched (maybe because runc itself does not support go module yet ?). This fixes the dependencies retrieved in go module, the packages bump itself seems sane. Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha 589192196f916c2a79926b66f74af4ab56fa6650

change go-bindata to kevinburke/go-bindata The original go-bindata is unmaintained and is on an old revision, so our usage of it is outdated. Changed to https://github.com/kevinburke/go-bindata which seems to be a more official and well maintained fork, and bump to latest version.

view details

Daniel Dao

commit sha e6559293b2b686764397b96c960d47acd250048a

add vendor changes from `go mod vendor` Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha 8cb3be6f3641b1cdcac4ed0366d93cfbca582ff1

remove Godeps finally Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

push time in 2 months

push eventdqminh/cadvisor

David Ashpole

commit sha 5879c34819a3ca426e935a940853d83b177de72a

update gofmt with go1.13

view details

David Ashpole

commit sha c9261a8d95a14bcf75bf425f9d31687aedbb12f5

Merge pull request #2339 from dashpole/go_fmt Update gofmt with go1.13

view details

zouyee

commit sha 976f231ab279934c2fb16342beb9e880da5bd5e7

support multi tmpfs in cadvisor Signed-off-by: Zou Nengren <zouyee1989@gmail.com>

view details

David Ashpole

commit sha fd4e2a03856e946db9c862943c0001f6fc3dcbe3

Merge pull request #2292 from zouyee/multitmpfs support multi tmpfs in cadvisor

view details

David Ashpole

commit sha dae76761cd2e143b2c59af9740233158ef11a94a

changelog for v0.35.0

view details

David Ashpole

commit sha 49033161cc529be82d2672805a196752a74eac9d

Merge pull request #2345 from dashpole/changelog_35 Changelog for v0.35.0

view details

Daniel Dao

commit sha d00ddd1193624860188be691f3ae80e47081a19d

add initial support for go module ``` go mod init github.com/google/cadvisor go mod tidy go get github.com/matttproud/golang_protobuf_extensions@c182affec369e30f25d3eb8cd8a478dee585ae7d go get github.com/containerd/typeurl@5eb25027c9fdd675e1db2bd25af02f5db75027ab ``` Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha a9d3f927509d8b917d06b06c48f73e2691e07073

add vendor changes from `go mod vendor` Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha 1cdfd80a68e3f5f2ada1e35880e739370a2b1807

remove Godeps finally Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha e070fbac69ccc17a2286b634b46562373dac5753

bump dependencies of several runc packages Somehow the dependencies retrieved by `go mod init` was mismatched (maybe because runc itself does not support go module yet ?). This fixes the dependencies retrieved in go module, the packages bump itself seems sane. Signed-off-by: Daniel Dao <dqminh89@gmail.com>

view details

Daniel Dao

commit sha e7cea11006ca50b6bf09da8def23d63e7b266f8f

change go-bindata to kevinburke/go-bindata The original go-bindata is unmaintained and is on an old revision, so our usage of it is outdated. Changed to https://github.com/kevinburke/go-bindata which seems to be a more official and well maintained fork.

view details

push time in 2 months

push eventdqminh/cadvisor

David Ashpole

commit sha 5879c34819a3ca426e935a940853d83b177de72a

update gofmt with go1.13

view details

David Ashpole

commit sha c9261a8d95a14bcf75bf425f9d31687aedbb12f5

Merge pull request #2339 from dashpole/go_fmt Update gofmt with go1.13

view details

zouyee

commit sha 976f231ab279934c2fb16342beb9e880da5bd5e7

support multi tmpfs in cadvisor Signed-off-by: Zou Nengren <zouyee1989@gmail.com>

view details

David Ashpole

commit sha fd4e2a03856e946db9c862943c0001f6fc3dcbe3

Merge pull request #2292 from zouyee/multitmpfs support multi tmpfs in cadvisor

view details

David Ashpole

commit sha dae76761cd2e143b2c59af9740233158ef11a94a

changelog for v0.35.0

view details

David Ashpole

commit sha 49033161cc529be82d2672805a196752a74eac9d

Merge pull request #2345 from dashpole/changelog_35 Changelog for v0.35.0

view details

push time in 2 months

PR opened google/cadvisor

Add support for go module

This adds initial support for go modules and remove Godeps.

+86562 -46281

0 comment

636 changed files

pr created time in 2 months

push eventdqminh/cadvisor

bingohuang

commit sha 22a3a8209512cbd2d39b838fc0212840dbd55f0c

Add Envs to specV2 from specV1

view details

Luc Perkins

commit sha 97fcafeb0bb8fef60e2d060408325a202bc300fc

Add table listing Prometheus metrics to Prometheus doc (#2001) Add prometheus docs metrics table

view details

Guoliang Wang

commit sha 910de81342634585243d0a23769587e5d6431057

Check the length before using container.Stats

view details

David Ashpole

commit sha 6147978e035be20bbb391b842ace0cf757418779

Merge pull request #2004 from wgliang/master Fix panic when querying prometheus endpoint

view details

Evan Klitzke

commit sha f31f580d9c91eb8fbb9088b1630907c487c26647

Lower log verbosity for statfs failures, fixes #1772

view details

Xander Grzywinski

commit sha a390d2ef0cc5757198b2f81424d0b657798711f3

statsd docs (Issue #2002) (#2005) * statsd documentation

view details

Valentyn Boginskey

commit sha b09b68c4a961ea33ee74cfa1f479ee335efb3a42

Fix cache reporting with cgroup hierarchy

view details

Sashank Appireddy

commit sha 2c96ceb4788bfc5354db66ee149b6cefd9f018e8

Ensure that labels for mesos tasks launched via MesosCommandExecutor are collected as well

view details

David Ashpole

commit sha 18afaa921b8dd8bc3bf5e6f95dd27a4fee7cf6bb

Merge pull request #2010 from sashankreddya/test_mesos_branch Ensure that labels for mesos tasks launched via MesosCommandExecutor are collected

view details

Gijs Kunze

commit sha 9e175e9ea917e17cc1078a9836f19ff14276613c

Adds mapped_file metric

view details

zhangjianweibj

commit sha cb8a80808920019972f92f2903645f1018f0ac24

networkUdpMetrics error if condition

view details

David Ashpole

commit sha 820ba9baf122a1b7e67663d214e016058dbafcf1

Merge pull request #2021 from zhangjianweibj/networkudpmetrics networkUdpMetrics error if condition

view details

David Ashpole

commit sha 015bce60a7cb3aeab5d1656db992b1bf0bb1028d

Merge pull request #2006 from eklitzke/statfs Lower log verbosity for statfs failures, fixes #1772

view details

David Ashpole

commit sha d8d7bf8b2dac4301f5df6218dde31bd237995f01

Merge pull request #2014 from grnhse/use-hierarchy-for-cache Fix cache reporting with cgroup hierarchy

view details

Becca Powell

commit sha eb02a5e941b0a2fc51244881bedbeef3aa3ac170

fix a few things in the readme (#2025) * small readme improvements

view details

David Ashpole

commit sha d1b3158fa506f52a72616ac94b6980b96d6aae2a

update documentation to make /var/run read-only, and add /dev/disk to the kustomize base

view details

David Ashpole

commit sha 03b0cc3b9d67526748a16579b00811d38bd662c2

Merge pull request #2029 from dashpole/update_security Update documentation to make /var/run read-only

view details

Manny Chang

commit sha e2330756825876df746ca72d93a750eb259e3ad7

Update Dockerfile and dependencies

view details

David Ashpole

commit sha 3e657b4b5e6981671b0be0814041a61b10d17177

Merge pull request #2033 from mannychang/master Update glibc version to 2.28-r0

view details

Gijs Kunze

commit sha 8a789bb1cda8e2b577c2b19a89e1d1dcb6acbf8b

Adds missing documentation for container_memory_mapped_files

view details

push time in 2 months

push eventdqminh/runc

Akihiro Suda

commit sha faf1e44ea9d001535f228ce570e56e18d3dece06

cgroup2: ebpf: increase RLIM_MEMLOCK to avoid BPF_PROG_LOAD error Fix #2167 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

view details

Qiang Huang

commit sha 2186cfa3cd52b8e00b1de76db7859cacdf7b1f94

Merge pull request #2168 from AkihiroSuda/ebpf-fix-rlimit cgroup2: ebpf: increase RLIM_MEMLOCK to avoid BPF_PROG_LOAD error

view details

push time in 2 months

PR closed google/cadvisor

Add support for go modules needs-ok-to-test

This adds:

  • support for go modules
  • remove Godeps
  • fix various nits when running tests and gofmt
+159282 -35410

1 comment

667 changed files

dqminh

pr closed time in 2 months

push eventdqminh/cadvisor

bingohuang

commit sha 22a3a8209512cbd2d39b838fc0212840dbd55f0c

Add Envs to specV2 from specV1

view details

Luc Perkins

commit sha 97fcafeb0bb8fef60e2d060408325a202bc300fc

Add table listing Prometheus metrics to Prometheus doc (#2001) Add prometheus docs metrics table

view details

Guoliang Wang

commit sha 910de81342634585243d0a23769587e5d6431057

Check the length before using container.Stats

view details

David Ashpole

commit sha 6147978e035be20bbb391b842ace0cf757418779

Merge pull request #2004 from wgliang/master Fix panic when querying prometheus endpoint

view details

Evan Klitzke

commit sha f31f580d9c91eb8fbb9088b1630907c487c26647

Lower log verbosity for statfs failures, fixes #1772

view details

Xander Grzywinski

commit sha a390d2ef0cc5757198b2f81424d0b657798711f3

statsd docs (Issue #2002) (#2005) * statsd documentation

view details

Valentyn Boginskey

commit sha b09b68c4a961ea33ee74cfa1f479ee335efb3a42

Fix cache reporting with cgroup hierarchy

view details

Sashank Appireddy

commit sha 2c96ceb4788bfc5354db66ee149b6cefd9f018e8

Ensure that labels for mesos tasks launched via MesosCommandExecutor are collected as well

view details

David Ashpole

commit sha 18afaa921b8dd8bc3bf5e6f95dd27a4fee7cf6bb

Merge pull request #2010 from sashankreddya/test_mesos_branch Ensure that labels for mesos tasks launched via MesosCommandExecutor are collected

view details

Gijs Kunze

commit sha 9e175e9ea917e17cc1078a9836f19ff14276613c

Adds mapped_file metric

view details

zhangjianweibj

commit sha cb8a80808920019972f92f2903645f1018f0ac24

networkUdpMetrics error if condition

view details

David Ashpole

commit sha 820ba9baf122a1b7e67663d214e016058dbafcf1

Merge pull request #2021 from zhangjianweibj/networkudpmetrics networkUdpMetrics error if condition

view details

David Ashpole

commit sha 015bce60a7cb3aeab5d1656db992b1bf0bb1028d

Merge pull request #2006 from eklitzke/statfs Lower log verbosity for statfs failures, fixes #1772

view details

David Ashpole

commit sha d8d7bf8b2dac4301f5df6218dde31bd237995f01

Merge pull request #2014 from grnhse/use-hierarchy-for-cache Fix cache reporting with cgroup hierarchy

view details

Becca Powell

commit sha eb02a5e941b0a2fc51244881bedbeef3aa3ac170

fix a few things in the readme (#2025) * small readme improvements

view details

David Ashpole

commit sha d1b3158fa506f52a72616ac94b6980b96d6aae2a

update documentation to make /var/run read-only, and add /dev/disk to the kustomize base

view details

David Ashpole

commit sha 03b0cc3b9d67526748a16579b00811d38bd662c2

Merge pull request #2029 from dashpole/update_security Update documentation to make /var/run read-only

view details

Manny Chang

commit sha e2330756825876df746ca72d93a750eb259e3ad7

Update Dockerfile and dependencies

view details

David Ashpole

commit sha 3e657b4b5e6981671b0be0814041a61b10d17177

Merge pull request #2033 from mannychang/master Update glibc version to 2.28-r0

view details

Gijs Kunze

commit sha 8a789bb1cda8e2b577c2b19a89e1d1dcb6acbf8b

Adds missing documentation for container_memory_mapped_files

view details

push time in 2 months

PR opened google/cadvisor

Add support for go modules

This adds:

  • support for go modules
  • remove Godeps
  • fix various nits when running tests and gofmt
+159282 -35410

0 comment

667 changed files

pr created time in 2 months

create barnchdqminh/cadvisor

branch : go-module

created branch time in 2 months

pull request commentcontainerd/cgroups

Set GO111MODULE=on and use `go mod vendor` to fix Go 1.11/1.12 builds

LGTM

@estesp its because we put the package inside GOPATH, and go mod doesnt work prior go 1.13 because the default GO111MODULE=auto will not active go mod inside a GOPATH.

Either one of these things would have make things work:

  1. stop manually cloning some dependencies, put this outside of GOPATH, and do go get
  2. forcing it to active module support with GO111MODULE=on go get. This is probably the same as GO111MODULE=on go mod vendor here.

I do prefer 1) for go modules project nowadays.

estesp

comment created time in 2 months

push eventdqminh/runc

Kevin Kelani

commit sha 056909bd3d966ea22ebb243b15fce5060d9850f0

Adds note about user ns for rootless containers Signed-off-by: Kevin Kelani <kkelani@gmail.com>

view details

Kenta Tada

commit sha 30817421efbc761c0adcb1d67b8ef84ae32171be

Modify check-config.sh in accordance with Moby Project updates This commit modifies check-config.sh to keep up with current kernel config. Signed-off-by: Kenta Tada <Kenta.Tada@sony.com>

view details

Daniel, Dao Quang Minh

commit sha 859f74576e7af6b3351f7b60f5327c7047655963

Merge pull request #1942 from KentaTada/fix-kernel-config-to-adjust-to-moby Modify check-config.sh in accordance with Moby Project updates

view details

JoeWrightss

commit sha 769d6c4a75b92991b0f5fa76586854f106346c88

Fix some typos Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>

view details

Aleksa Sarai

commit sha f5b99917df9fbe1d9a4114966fb088dd6860e85a

merge branch 'pr-1945' Fix some typos LGTMs: @crosbymichael @cyphar Closes #1945

view details

Tom Godkin

commit sha bdf3524b34ffe47b122e56806d7210e2890f1ae3

Retry adding pids to cgroups when EINVAL occurs The kernel will sometimes return EINVAL when writing a pid to a cgroup.procs file. It does so when the task being added still has the state TASK_NEW. See: https://elixir.bootlin.com/linux/v4.8/source/kernel/sched/core.c#L8286 Co-authored-by: Danail Branekov <danailster@gmail.com> Signed-off-by: Tom Godkin <tgodkin@pivotal.io> Signed-off-by: Danail Branekov <danailster@gmail.com>

view details

JoeWrightss

commit sha 0855bce448c0cc7aa57394f44229ee64504bee0a

Fix .Fatalf() error message Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>

view details

Michael Crosby

commit sha bbb17efcb4c0ab986407812a31ba333a7450064c

Merge pull request #1952 from JoeWrightss/patch-4 Fix .Fatalf() error message

view details

Adrian Reber

commit sha 360ba8a27d4c3688cbdad67501324c72bcab84dd

Update criurpc definition for latest features Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Adrian Reber

commit sha e157963054e1be28bcd6612f15df1ea561c62571

Enable CRIU configuration files CRIU 3.11 introduces configuration files: https://criu.org/Configuration_files https://lisas.de/~adrian/posts/2018-Nov-08-criu-configuration-files.html This enables the user to influence CRIU's behaviour without code changes if using new CRIU features or if the user wants to enable certain CRIU behaviour without always specifying certain options. With this it is possible to write 'tcp-established' to the configuration file: $ echo tcp-established > /etc/criu/runc.conf and from now on all checkpoints will preserve the state of established TCP connections. This removes the need to always use $ runc checkpoint --tcp-stablished If the goal is to always checkpoint with '--tcp-established' It also adds the possibility for unexpected CRIU behaviour if the user created a configuration file at some point in time and forgets about it. As a result of the discussion in https://github.com/opencontainers/runc/pull/1933 it is now also possible to define a CRIU configuration file for each container with the annotation 'org.criu.config'. If 'org.criu.config' does not exist, runc will tell CRIU to use '/etc/criu/runc.conf' if it exists. If 'org.criu.config' is set to an empty string (''), runc will tell CRIU to not use any runc specific configuration file at all. If 'org.criu.config' is set to a non-empty string, runc will use that value as an additional configuration file for CRIU. With the annotation the user can decide to use the default configuration file ('/etc/criu/runc.conf'), none or a container specific configuration file. Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Adrian Reber

commit sha 6f3e13cc48ead674ed94b1ac89e4607db6bc0f6e

Added test for container specific CRIU configuration files Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Adrian Reber

commit sha 403986c5dd078a9d528794aee0b38dc742ee072b

Add CRIU patch to fix checkpoint test For the newly integrated feature to use CRIU configuration files the test is broken without an additional CRIU patch. The test changes CRIU's log file. Changing the log file is unfortunately the only thing which is in broken in CRIU 3.11. But it is the easiest option for testing. With CRIU 3.12 this will be fixed. All other CRIU options can be changed with a CRIU configuration file. With this change the CRIU 3.11 feature can be merged into runc with a test and for the user it should just work, if they are not trying to change CRIU's log file. Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Xiaochen Shen

commit sha acb75d0e38071ccd65f30b1de1898e78ddea3f91

libcontainer: intelrdt: fix null intelrdt path issue in Destroy() This patch fixes a corner case when destroy a container: If we start a container without 'intelRdt' config set, and then we run “runc update --l3-cache-schema/--mem-bw-schema” to add 'intelRdt' config implicitly. Now if we enter "exit" from the container inside, we will pass through linuxContainer.Destroy() -> state.destroy() -> intelRdtManager.Destroy(). But in IntelRdtManager.Destroy(), IntelRdtManager.Path is still null string, it hasn’t been initialized yet. As a result, the created rdt group directory during "runc update" will not be removed as expected. Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>

view details

Giuseppe Scrivano

commit sha f01923376d04459dd6eac8584d5af8531c1d96de

systemd: fix setting kernel memory limit since commit df3fa115f97407713ec6ebe37a5ccf13b81dafd2 it is not possible to set a kernel memory limit when using the systemd cgroups backend as we use cgroup.Apply twice. Skip enabling kernel memory if there are already tasks in the cgroup. Without this patch, runc fails with: container_linux.go:344: starting container process caused "process_linux.go:311: applying cgroup configuration for process caused \"failed to set memory.kmem.limit_in_bytes, because either tasks have already joined this cgroup or it has children\"" Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha 28a697cce3e4f905dca700eda81d681a30eef9cd

rootfs: umount all procfs and sysfs with --no-pivot When creating a new user namespace, the kernel doesn't allow to mount a new procfs or sysfs file system if there is not already one instance fully visible in the current mount namespace. When using --no-pivot we were effectively inhibiting this protection from the kernel, as /proc and /sys from the host are still present in the container mount namespace. A container without full access to /proc could then create a new user namespace, and from there able to mount a fully visible /proc, bypassing the limitations in the container. A simple reproducer for this issue is: unshare -mrfp sh -c "mount -t proc none /proc && echo c > /proc/sysrq-trigger" Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Aleksa Sarai

commit sha 12f6a991201fdb8f82579582d5e00e28fba06d0a

merge branch 'pr-1962' rootfs: umount all procfs and sysfs with --no-pivot LGTMs: @mrunalp @cyphar Closes #1962

view details

Michael Crosby

commit sha 4e9d52da54de947afb8f76aef74f57ae2c1bf6ff

Merge pull request #1933 from adrianreber/master Add CRIU configuration file support

view details

Michael Crosby

commit sha c1e454b2a1bfb0f0ebd9e621a1433f98f9a8d4b0

Merge pull request #1960 from giuseppe/fix-kmem-systemd systemd: fix setting kernel memory limit

view details

Adrian Reber

commit sha 5f32bb94fdcdbc04bcd0ef4b656867800e0d9d23

Update runc-checkpoint man-page This just copies the latest output from 'runc checkpoint --help' to the man page. Signed-off-by: Adrian Reber <areber@redhat.com>

view details

Adrian Reber

commit sha dd50c7e3327b6c264087855f8225cb692046c5f4

Add 'org.criu.config' annotation documentation Signed-off-by: Adrian Reber <areber@redhat.com>

view details

push time in 2 months

push eventdqminh/.dotfiles

Daniel Dao

commit sha 39fe3bc1d839687c45df489643c2e43dbe4597d8

update

view details

push time in 2 months

pull request commentopencontainers/runc

Adds info about `userns` for rootless containers

LGTM

kkallday

comment created time in 3 months

pull request commentopencontainers/runc

Set unified mountpoint in find mnt func

LGTM

Approved with PullApprove

crosbymichael

comment created time in 3 months

pull request commentopencontainers/runc

io_v2.go: remove blkio v1 code

LGTM

AkihiroSuda

comment created time in 3 months

pull request commentjaegertracing/jaeger-client-cpp

Do not allocate 65k buffers for each span

@mdouaihy @yurishkuro apologized for long delay as i took a vacation :D

I sent another change at https://github.com/jaegertracing/jaeger-client-cpp/pull/185 which reuse the buffer for a sender to calculate the individual thrift sizes, hopefully that's correct.

dqminh

comment created time in 3 months

PR opened jaegertracing/jaeger-client-cpp

reuse TMemoryBuffer when calculating size of ThriftType

Replaces #180

Previous approach allocates several max size buffer everytime we want to calculate the size of the serialized thrift type. This changes to reuse only 1 buffer per sender. As sender is single-threaded this should be safe.

I manually modified the build script and example app to include sanitizer stats and producing span in a loop https://gist.github.com/dqminh/b64099d775d72e584a141a0d20c38a00. After compling you can run it with ASAN_OPTIONS=verbosity=1:atexit=1:print_stats=1 ./app ../examples/config.yml 10

Before:

AddressSanitizer exit stats:
Stats: 1M malloced (0M for red zones) by 1140 calls
Stats: 0M realloced by 0 calls
Stats: 1M freed by 1094 calls
Stats: 0M really freed by 0 calls
Stats: 5M (5M-0M) mmaped; 87 maps, 0 unmaps
  mallocs by size class: 2:80; 3:261; 4:95; 6:291; 7:39; 8:13; 11:1; 12:6; 13:64; 15:36; 16:42; 17:3; 18:59; 19:42; 20:9; 21:38; 22:20; 23:1; 25:5; 26:2; 29:1; 30:1; 31:1; 32:1; 33:4; 34:1; 37:1; 49:23;
Stats: malloc large: 0
Stats: StackDepot: 845 ids; 0M allocated
Stats: SizeClassAllocator64: 3M mapped (0M rss) in 3972 allocations; remains 2858
  02 (    32): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks    1920 avail:   2048 rss:      4K releases:      0 last released:      0K region: 0x602000000000
  03 (    48): mapped:     64K allocs:     384 frees:      39 inuse:    345 num_freed_chunks    1020 avail:   1365 rss:     16K releases:      0 last released:      0K region: 0x603000000000
  04 (    64): mapped:     64K allocs:     256 frees:      82 inuse:    174 num_freed_chunks     850 avail:   1024 rss:      8K releases:      0 last released:      0K region: 0x604000000000
  06 (    96): mapped:     64K allocs:     384 frees:      86 inuse:    298 num_freed_chunks     384 avail:    682 rss:     28K releases:      0 last released:      0K region: 0x606000000000
  07 (   112): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     457 avail:    585 rss:      8K releases:      0 last released:      0K region: 0x607000000000
  08 (   128): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     384 avail:    512 rss:      4K releases:      0 last released:      0K region: 0x608000000000
  11 (   176): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     244 avail:    372 rss:      4K releases:      0 last released:      0K region: 0x60b000000000
  12 (   192): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     213 avail:    341 rss:      4K releases:      0 last released:      0K region: 0x60c000000000
  13 (   208): mapped:     64K allocs:     256 frees:     118 inuse:    138 num_freed_chunks     177 avail:    315 rss:     20K releases:      0 last released:      0K region: 0x60d000000000
  15 (   240): mapped:     64K allocs:     256 frees:     106 inuse:    150 num_freed_chunks     123 avail:    273 rss:     12K releases:      0 last released:      0K region: 0x60f000000000
  16 (   256): mapped:     64K allocs:     256 frees:     118 inuse:    138 num_freed_chunks     118 avail:    256 rss:     12K releases:      0 last released:      0K region: 0x610000000000
  17 (   320): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks      76 avail:    204 rss:      4K releases:      0 last released:      0K region: 0x611000000000
  18 (   384): mapped:    128K allocs:     256 frees:      83 inuse:    173 num_freed_chunks     168 avail:    341 rss:     32K releases:      0 last released:      0K region: 0x612000000000
  19 (   448): mapped:    128K allocs:     256 frees:     127 inuse:    129 num_freed_chunks     163 avail:    292 rss:     28K releases:      0 last released:      0K region: 0x613000000000
  20 (   512): mapped:    128K allocs:     256 frees:     126 inuse:    130 num_freed_chunks     126 avail:    256 rss:      8K releases:      0 last released:      0K region: 0x614000000000
  21 (   640): mapped:    128K allocs:     204 frees:      81 inuse:    123 num_freed_chunks      81 avail:    204 rss:     32K releases:      0 last released:      0K region: 0x615000000000
  22 (   768): mapped:     64K allocs:      85 frees:       0 inuse:     85 num_freed_chunks       0 avail:     85 rss:     16K releases:      0 last released:      0K region: 0x616000000000
  23 (   896): mapped:     64K allocs:      73 frees:      72 inuse:      1 num_freed_chunks      72 avail:     73 rss:      4K releases:      0 last released:      0K region: 0x617000000000
  25 (  1280): mapped:     64K allocs:      51 frees:       0 inuse:     51 num_freed_chunks       0 avail:     51 rss:      8K releases:      0 last released:      0K region: 0x619000000000
  26 (  1536): mapped:    128K allocs:      84 frees:      41 inuse:     43 num_freed_chunks      42 avail:     85 rss:     12K releases:      0 last released:      0K region: 0x61a000000000
  29 (  2560): mapped:     64K allocs:      25 frees:       0 inuse:     25 num_freed_chunks       0 avail:     25 rss:      4K releases:      0 last released:      0K region: 0x61d000000000
  30 (  3072): mapped:     64K allocs:      21 frees:      20 inuse:      1 num_freed_chunks      20 avail:     21 rss:      4K releases:      0 last released:      0K region: 0x61e000000000
  31 (  3584): mapped:     64K allocs:      18 frees:       0 inuse:     18 num_freed_chunks       0 avail:     18 rss:      4K releases:      0 last released:      0K region: 0x61f000000000
  32 (  4096): mapped:     64K allocs:      16 frees:       0 inuse:     16 num_freed_chunks       0 avail:     16 rss:      4K releases:      0 last released:      0K region: 0x620000000000
  33 (  5120): mapped:     64K allocs:      12 frees:       0 inuse:     12 num_freed_chunks       0 avail:     12 rss:     20K releases:      0 last released:      0K region: 0x621000000000
  34 (  6144): mapped:     64K allocs:      10 frees:       9 inuse:      1 num_freed_chunks       9 avail:     10 rss:      8K releases:      0 last released:      0K region: 0x622000000000
  36 (  8192): mapped:    128K allocs:      16 frees:       6 inuse:     10 num_freed_chunks       6 avail:     16 rss:     16K releases:      0 last released:      0K region: 0x624000000000
  37 ( 10240): mapped:     64K allocs:       6 frees:       0 inuse:      6 num_freed_chunks       0 avail:      6 rss:      8K releases:      0 last released:      0K region: 0x625000000000
  49 ( 81920): mapped:   1856K allocs:      23 frees:       0 inuse:     23 num_freed_chunks       0 avail:     23 rss:    184K releases:      0 last released:      0K region: 0x631000000000
Stats: LargeMmapAllocator: allocated 0 times, remains 0 (0 K) max 0 M; by size logs:
Quarantine limits: global: 256Mb; thread local: 1024Kb
Global quarantine stats: batches: 2; bytes: 1432330 (user: 1415946); chunks: 332 (capacity: 2042); 16% chunks used; 1% memory overhead

After:

AddressSanitizer exit stats:
Stats: 0M malloced (0M for red zones) by 1079 calls
Stats: 0M realloced by 0 calls
Stats: 0M freed by 1033 calls
Stats: 0M really freed by 0 calls
Stats: 4M (4M-0M) mmaped; 68 maps, 0 unmaps
  mallocs by size class: 2:80; 3:241; 4:95; 6:271; 7:39; 8:13; 11:1; 12:6; 13:62; 14:1; 15:36; 16:42; 17:3; 18:59; 19:42; 20:9; 21:38; 22:20; 23:1; 25:6; 26:2; 29:1; 30:1; 31:1; 32:1; 33:4; 34:1; 37:1; 49:2;
Stats: malloc large: 0
Stats: StackDepot: 837 ids; 0M allocated
Stats: SizeClassAllocator64: 2M mapped (0M rss) in 4079 allocations; remains 2922
  02 (    32): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks    1920 avail:   2048 rss:      4K releases:      0 last released:      0K region: 0x602000000000
  03 (    48): mapped:     64K allocs:     384 frees:      60 inuse:    324 num_freed_chunks    1041 avail:   1365 rss:     16K releases:      0 last released:      0K region: 0x603000000000
  04 (    64): mapped:     64K allocs:     256 frees:      82 inuse:    174 num_freed_chunks     850 avail:   1024 rss:      8K releases:      0 last released:      0K region: 0x604000000000
  06 (    96): mapped:     64K allocs:     384 frees:     107 inuse:    277 num_freed_chunks     405 avail:    682 rss:     28K releases:      0 last released:      0K region: 0x606000000000
  07 (   112): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     457 avail:    585 rss:      8K releases:      0 last released:      0K region: 0x607000000000
  08 (   128): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     384 avail:    512 rss:      4K releases:      0 last released:      0K region: 0x608000000000
  11 (   176): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     244 avail:    372 rss:      4K releases:      0 last released:      0K region: 0x60b000000000
  12 (   192): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     213 avail:    341 rss:      4K releases:      0 last released:      0K region: 0x60c000000000
  13 (   208): mapped:     64K allocs:     256 frees:     118 inuse:    138 num_freed_chunks     177 avail:    315 rss:     20K releases:      0 last released:      0K region: 0x60d000000000
  14 (   224): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks     164 avail:    292 rss:      4K releases:      0 last released:      0K region: 0x60e000000000
  15 (   240): mapped:     64K allocs:     256 frees:     106 inuse:    150 num_freed_chunks     123 avail:    273 rss:     12K releases:      0 last released:      0K region: 0x60f000000000
  16 (   256): mapped:     64K allocs:     256 frees:     118 inuse:    138 num_freed_chunks     118 avail:    256 rss:     12K releases:      0 last released:      0K region: 0x610000000000
  17 (   320): mapped:     64K allocs:     128 frees:       0 inuse:    128 num_freed_chunks      76 avail:    204 rss:      4K releases:      0 last released:      0K region: 0x611000000000
  18 (   384): mapped:    128K allocs:     256 frees:      83 inuse:    173 num_freed_chunks     168 avail:    341 rss:     32K releases:      0 last released:      0K region: 0x612000000000
  19 (   448): mapped:    128K allocs:     256 frees:     127 inuse:    129 num_freed_chunks     163 avail:    292 rss:     28K releases:      0 last released:      0K region: 0x613000000000
  20 (   512): mapped:    128K allocs:     256 frees:     126 inuse:    130 num_freed_chunks     126 avail:    256 rss:      8K releases:      0 last released:      0K region: 0x614000000000
  21 (   640): mapped:    128K allocs:     204 frees:      81 inuse:    123 num_freed_chunks      81 avail:    204 rss:     32K releases:      0 last released:      0K region: 0x615000000000
  22 (   768): mapped:     64K allocs:      85 frees:       0 inuse:     85 num_freed_chunks       0 avail:     85 rss:     16K releases:      0 last released:      0K region: 0x616000000000
  23 (   896): mapped:     64K allocs:      73 frees:      72 inuse:      1 num_freed_chunks      72 avail:     73 rss:      4K releases:      0 last released:      0K region: 0x617000000000
  25 (  1280): mapped:     64K allocs:      51 frees:       0 inuse:     51 num_freed_chunks       0 avail:     51 rss:      8K releases:      0 last released:      0K region: 0x619000000000
  26 (  1536): mapped:    128K allocs:      84 frees:      41 inuse:     43 num_freed_chunks      42 avail:     85 rss:     12K releases:      0 last released:      0K region: 0x61a000000000
  29 (  2560): mapped:     64K allocs:      25 frees:       0 inuse:     25 num_freed_chunks       0 avail:     25 rss:      4K releases:      0 last released:      0K region: 0x61d000000000
  30 (  3072): mapped:     64K allocs:      21 frees:      20 inuse:      1 num_freed_chunks      20 avail:     21 rss:      4K releases:      0 last released:      0K region: 0x61e000000000
  31 (  3584): mapped:     64K allocs:      18 frees:       0 inuse:     18 num_freed_chunks       0 avail:     18 rss:      4K releases:      0 last released:      0K region: 0x61f000000000
  32 (  4096): mapped:     64K allocs:      16 frees:       0 inuse:     16 num_freed_chunks       0 avail:     16 rss:      4K releases:      0 last released:      0K region: 0x620000000000
  33 (  5120): mapped:     64K allocs:      12 frees:       0 inuse:     12 num_freed_chunks       0 avail:     12 rss:     20K releases:      0 last released:      0K region: 0x621000000000
  34 (  6144): mapped:     64K allocs:      10 frees:       9 inuse:      1 num_freed_chunks       9 avail:     10 rss:      8K releases:      0 last released:      0K region: 0x622000000000
  36 (  8192): mapped:    128K allocs:      16 frees:       7 inuse:      9 num_freed_chunks       7 avail:     16 rss:     12K releases:      0 last released:      0K region: 0x624000000000
  37 ( 10240): mapped:     64K allocs:       6 frees:       0 inuse:      6 num_freed_chunks       0 avail:      6 rss:      8K releases:      0 last released:      0K region: 0x625000000000
  49 ( 81920): mapped:    192K allocs:       2 frees:       0 inuse:      2 num_freed_chunks       0 avail:      2 rss:     16K releases:      0 last released:      0K region: 0x631000000000
Stats: LargeMmapAllocator: allocated 0 times, remains 0 (0 K) max 0 M; by size logs:
Quarantine limits: global: 256Mb; thread local: 1024Kb
Global quarantine stats: batches: 1; bytes: 57290 (user: 49098); chunks: 269 (capacity: 1021); 26% chunks used; 16% memory overhead

Note that after allocates less memory, and number of allocation in 81920 bucket is significantly less.

+19 -17

0 comment

2 changed files

pr created time in 3 months

push eventdqminh/jaeger-client-cpp

Daniel Dao

commit sha 1d79f21d17aac1e471c15d4dbd6013bdc55b9d9f

reuse TMemoryBuffer when calculating size of ThriftType Previous approach allocates several max size buffer everytime we want to calculate the size of the serialized thrift type. This changes to reuse only 1 buffer per sender. As sender is single-threaded this should be safe. Signed-off-by: Daniel Dao <dqminh@cloudflare.com>

view details

push time in 3 months

push eventdqminh/jaeger-client-cpp

Daniel Dao

commit sha 9ec9fdf60bdaf74865eb638ab2a6c1253a9c8204

reuse TMemoryBuffer when calculating size of ThriftType

view details

push time in 3 months

push eventdqminh/jaeger-client-cpp

push time in 3 months

push eventdqminh/jaeger-client-cpp

Daniel Dao

commit sha 7b1e8fe6a24d9b64e7c2ef06895ef9c8e072e57b

temporary drop hunter revision

view details

push time in 3 months

create barnchdqminh/jaeger-client-cpp

branch : reuse-buffer

created branch time in 3 months

push eventdqminh/jaeger-client-cpp

Yuri Shkuro

commit sha a472fba737dfbfa37f84621064543b05b1db1202

Clarify agent/sampler address overrides

view details

Mehrez DOUAIHY

commit sha fec4327ba45c186a708879204e1466284a323104

Upgrade to OpenTracing 1.5.0; Support build on Windows (#115) * Fix Build Under Windows ( #112) * Move to OpenTracing 1.5.0 that builds under Windows * Change link of OpenTracing to dynamic. With Static linking of OpenTracing, we end up with multi definition of OT Symbols. This is not acceptable especially for the OT Global Tracer * Fix OS specificities ** Networking API ** Windows headers * Fix some tests with random behavior that failed on Windows * Fix some MSVC specific compilation * Add appveyor build file. * Update Hunter version. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * Enable compilation against Windows 8.1 SDK The definition of `inet_ntop` for older Windows SDK versions, such as 8.1, does not declare the `pAddr` argument as `const`. Because of this we need to cast away the constness first. Despite the argument not being declared as const the function should not be touching it, hence this should be safe. Signed-off-by: Fredrik Appelros <fredrik.appelros@hypergene.se> * Fix nlohmann_json dependency The `package_deps` list is used to iterate over all dependencies in the package config file and run `find_package` on each of them. This should be using the package name (`nlohmann_json`) and not the target name (`nlohmann_json::nlohmann_json`). Signed-off-by: Fredrik Appelros <fredrik.appelros@hypergene.se> * Avoid redefinition of NOMINMAX Only define `NOMINMAX` if it has not already been defined to avoid redefinition warnings. Signed-off-by: Fredrik Appelros <fredrik.appelros@hypergene.se> * Add Appveyor badge and debug builds. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * Add TODO with the related issues for Tracer.testTracer test. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com>

view details

Mehrez DOUAIHY

commit sha 2b5e4fb4b63c6384c02b1c4e2406ef1e1c9fbc04

Throw exception on invalid sampling rate (fix #149) (#168) Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com>

view details

Mehrez DOUAIHY

commit sha 68be4e2d0416bc7b7262ff7111efa9cc1c5a2d08

Prepare release 0.5.0 (#169) Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com>

view details

Jorrit Salverda

commit sha b08310803dcddf3b3ad08de37e8b0d5e48b514c5

Update default samplingServerURL to include /sampling path (#158) * Update default samplingServerURL to include /sampling path Fixes issue https://github.com/jaegertracing/jaeger-client-cpp/issues/157 Signed-off-by: Jorrit Salverda <jorrit.salverda@gmail.com> * Improve test for default sampling server url By asserting against a static string the test will fail if the value changes, while otherwise it would not Signed-off-by: Jorrit Salverda <jsalverda@travix.com>

view details

BeDeBaMu

commit sha 11bbde1aa43e475258cd10a23983a67a914a0277

Remove Thrift headers from Jaeger public headers (#172) Adresses https://github.com/jaegertracing/jaeger-client-cpp/issues/121 so that thrift is a private dependency of jaeger. Signed-off-by: Benoit De Backer <bdebacker@murex.com>

view details

Mehrez DOUAIHY

commit sha 4ee8a66868fad5c70aaf50c46a8cdad9d71adb3f

Add an HTTP Sender (#165) (#171) * Add an HTTP Sender (#165) Support an HTTP Sender that allows to connect directly to a Collector. For instance, authentication is not supported. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * * Rename Http/UDP senders to Http/UDP Transporters * Rename ThriftTransporter to ThriftSender * Add Integration Test for http Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * Make HTTP capital to be inline with UDP. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com>

view details

Mehrez DOUAIHY

commit sha 5fc9c6507d2fd81ba72a0246a4d86ac654e88630

Support Tracer tags and configuration via environment variables (#181) * Support configuring client from environment variables (fix #178) Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * Apply Changes requested by @Yurishkhuro 1. When testing the config, start with a defined config instead of an empty one 2. Make sure fromEnv is harmful in case nothing is defined 3. Use literals to avoid fat-finger problem in the code 4. Avoid adding yet additional methods to the Tracer Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com> * Exclude sampler config. Signed-off-by: FR-MUREX-COM\mchaikhadouaihy <mehrez.douaihy@gmail.com>

view details

push time in 3 months

PR opened jaegertracing/jaeger-client-cpp

Do not allocate 65k buffers for each span

The current code allocates a few 65k buffer (i.e. maxPacketSize) when writing out thrift::Span which is wasteful, as single span rarely reaches this size. We noticed a significant memory increase when running under AddressSanitizer.

Instead, use the default 1024 bytes buffer and relies on buffer's growth to deal with large span.

Signed-off-by: Daniel Dao dqminh@cloudflare.com

+4 -4

0 comment

1 changed file

pr created time in 4 months

create barnchdqminh/jaeger-client-cpp

branch : reduce-span-buffer

created branch time in 4 months

pull request commentopencontainers/runc

*: verify operations on /proc/... are on procfs

LGTM

cyphar

comment created time in 4 months

Pull request review commentopencontainers/runc

*: verify operations on /proc/... are on procfs

 package utils  import (-	"io/ioutil"+	"fmt" 	"os" 	"strconv"  	"golang.org/x/sys/unix" ) +// IsProcHandle returns whether or not the given file handle is on procfs.+func IsProcHandle(fh *os.File) (bool, error) {+	var buf unix.Statfs_t+	err := unix.Fstatfs(int(fh.Fd()), &buf)+	return buf.Type == unix.PROC_SUPER_MAGIC, err

nit: IsProcHandle returns only bool is simpler, as caller has no way to handle error sanely so it should just abort with /proc is not what we expected

cyphar

comment created time in 4 months

pull request commentopencontainers/runc

*: verify operations on /proc/... are on procfs

LGTM

cyphar

comment created time in 4 months

startedcirosantilli/linux-kernel-module-cheat

started time in 4 months

more