profile
viewpoint
David Graham dgraham GitHub Denver, CO, USA Making github.com a little more wonderful every day.

dgraham/delegated-events 950

A small, fast delegated event library for JavaScript.

dgraham/Ka-Block 601

A Safari extension that blocks an artisanal selection of advertising domains.

dgraham/eslint-plugin-jquery 181

Disallow jQuery functions with native equivalents.

dgraham/json-stream 155

A streaming JSON parser that generates SAX-like events.

dgraham/identicon 36

A port of GitHub's identicon algorithm to Rust.

dgraham/mute-github-thread 24

Mute GitHub email notification threads with a macOS Mail shortcut.

dgraham/libds 10

Simple data structures in C.

dgraham/couchtweet 7

An example Rails app using CouchDB, CouchRest, and Twitter's data model.

dgraham/eslint-plugin-i18n-text 7

Disallow English text in string literals.

dgraham/couchproxy 6

A proxy server for Apache CouchDB clusters.

release github/stable-socket

v1.0.0

released time in 12 days

created taggithub/stable-socket

tagv1.0.0

A web socket that reconnects.

created time in 12 days

push eventgithub/stable-socket

David Graham

commit sha 475c2589a18b8d74a1ee907b37cb41092a5f6929

1.0.0

view details

push time in 12 days

starteddprint/dprint

started time in 18 days

startedSchniz/fnm

started time in 18 days

startedevanw/esbuild

started time in 18 days

startedRDambrosio016/RSLint

started time in 18 days

startedswc-project/swc

started time in 18 days

push eventdgraham/dotvim

David Graham

commit sha 61e61db79cd667d1e251177d5ee73f3641d61841

Add golang run and test shortcuts

view details

push time in 18 days

push eventdgraham/dotvim

David Graham

commit sha 361c50ade1a94cbd8082b7c40260619f614d10f5

Update plugins

view details

push time in 22 days

issue closedgithub/fetch

"Already read" error while posting

If I use the following code, I am getting an error "Already read" when accessing .json() . If we post using the pollyfill can we can we not read the json that is returned back?

var param = {name: 'Bob'};
fetch('/api', {
  method: 'POST', // or 'PUT'
  headers: {
    'Content-Type': 'application/json'
  },
  body: JSON.stringify(param)
})
  .then(function(response) {
    if (response.ok) {
      return response.json();
    } else {
      var error = new Error(response.statusText);
      error.response = response;
      throw error;
    }
  })
  .then(function(json) {
    console.log('parsed json', json);
    document.getElementById('divresponse').innerText = JSON.stringify(json);
  })
  .catch(function(ex) {
    console.log('parsing failed', ex);
  });

Below is the IE version. image

closed time in a month

surajts

issue commentgithub/fetch

"Already read" error while posting

The response body may be consumed only a single time. Calling the response.json(), response.text(), etc methods can only be done once and only one of them may be called on the response object.

I don't see anything in your code example that consumes the response body multiple times. However, attaching the response object to the exception allows multiple catch blocks to consume the response body, which may be causing this error. You can clone the response with response.clone() to consume the body again.

surajts

comment created time in a month

push eventgithub/tab-container-element

David Graham

commit sha 9bd2d39a312ab76d0dc819d30e11250e4ad1e55a

2020

view details

push time in a month

push eventgithub/tab-container-element

David Graham

commit sha 5bc8c134309d9d6b7cc42f14d7081ea76e6bc68f

Update development dependencies

view details

David Graham

commit sha aa7cf94fb257039f20488d1670cad8dfaa470b26

Build with GitHub Actions

view details

push time in a month

startedgithub/template-parts

started time in a month

delete branch github/session-resume

delete branch : test-failure

delete time in a month

create barnchgithub/session-resume

branch : test-failure

created branch time in a month

push eventgithub/session-resume

David Graham

commit sha 97fb6ddde440e65645d67cad6b2b133a97f48f60

Update development dependencies Closes #14 Closes #15

view details

David Graham

commit sha 14feffcadd2549580cad5f7cfb5714065c61bf27

Build with GitHub Actions

view details

push time in a month

PR closed github/session-resume

Bump http-proxy from 1.18.0 to 1.18.1 dependencies

Bumps http-proxy from 1.18.0 to 1.18.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md">http-proxy's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...v1.18.1">v1.18.1</a> - 2020-05-17</h2> <h3>Merged</h3> <ul> <li>Skip sending the proxyReq event when the expect header is present <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1447"><code>#1447</code></a></li> <li>Remove node6 support, add node12 to build <a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/pull/1397"><code>#1397</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/http-party/node-http-proxy/commit/9b96cd725127a024dabebec6c7ea8c807272223d"><code>9b96cd7</code></a> 1.18.1</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/335aeeba2f0c286dc89c402eeb76af47834c89a3"><code>335aeeb</code></a> Skip sending the proxyReq event when the expect header is present (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1447">#1447</a>)</li> <li><a href="https://github.com/http-party/node-http-proxy/commit/dba39668ba4c9ad461316e834b2d64b77e1ca88e"><code>dba3966</code></a> Remove node6 support, add node12 to build (<a href="https://github-redirect.dependabot.com/http-party/node-http-proxy/issues/1397">#1397</a>)</li> <li>See full diff in <a href="https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

PR closed github/session-resume

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

startedapple/swift-argument-parser

started time in a month

startedJetBrains/JetBrainsMono

started time in 2 months

startedmyobie/myobie

started time in 2 months

push eventgithub/paste-markdown

David Graham

commit sha dfe191b6e587aaa87da18c0f772679bd8465b7e5

Remove stale branch name

view details

push time in 2 months

push eventgithub/paste-markdown

David Graham

commit sha b7faae466103ec4dd6d2a9a93f4b9e2a71fce827

Update development dependencies

view details

push time in 2 months

delete branch dgraham/stache

delete branch : actions

delete time in 2 months

push eventdgraham/stache

David Graham

commit sha 1bf75c36f2e3469e380046ab596270216b6edabe

Build with GitHub Actions

view details

push time in 2 months

push eventdgraham/stache

David Graham

commit sha 6a82d0c941c5f4700f7f762a323f969505d5498f

Checkout mustache spec submodule

view details

push time in 2 months

create barnchdgraham/stache

branch : actions

created branch time in 2 months

push eventdgraham/stache

David Graham

commit sha e280ea7c6e084fcb10b19988ff8f86d00207709a

Fix deprecation warnings

view details

push time in 2 months

push eventdgraham/query-selectors

David Graham

commit sha 80a55537cb19afdc70e9fe4f0f309f9d86c21a47

Update development dependencies

view details

David Graham

commit sha cc6d6b0be5cfaec1a82505b3b2d05b9194012138

Build with GitHub Actions

view details

push time in 2 months

PR closed dgraham/option-type

Bump lodash from 4.17.10 to 4.17.20 dependencies

Bumps lodash from 4.17.10 to 4.17.20. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/ded9bc66583ed0b4e3b7dc906206d40757b4a90a"><code>ded9bc6</code></a> Bump to v4.17.20.</li> <li><a href="https://github.com/lodash/lodash/commit/63150ef7645ac07961b63a86490f419f356429aa"><code>63150ef</code></a> Documentation fixes.</li> <li><a href="https://github.com/lodash/lodash/commit/00f0f62a979d2f5fa0287c06eae70cf9a62d8794"><code>00f0f62</code></a> test.js: Remove trailing comma.</li> <li><a href="https://github.com/lodash/lodash/commit/846e434c7a5b5692c55ebf5715ed677b70a32389"><code>846e434</code></a> Temporarily use a custom fork of <code>lodash-cli</code>.</li> <li><a href="https://github.com/lodash/lodash/commit/5d046f39cbd27f573914768e3b36eeefcc4f1229"><code>5d046f3</code></a> Re-enable Travis tests on <code>4.17</code> branch.</li> <li><a href="https://github.com/lodash/lodash/commit/aa816b36d402a1ad9385142ce7188f17dae514fd"><code>aa816b3</code></a> Remove <code>/npm-package</code>.</li> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.10...4.17.20">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~bnjmnt4n">bnjmnt4n</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+49 -20

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PR closed dgraham/option-type

Bump eslint-utils from 1.3.1 to 1.4.3 dependencies

Bumps eslint-utils from 1.3.1 to 1.4.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mysticatea/eslint-utils/releases">eslint-utils's releases</a>.</em></p> <blockquote> <h2>v1.4.3</h2> <h2>🐛 Bug fixes</h2> <ul> <li>8f9e481ecc1204c7a1331b697f97903f90c75154 fixed false positive of <code>ReferenceTracker</code>.</li> </ul> <h2>v1.4.2</h2> <h2>🐛 Bug fixes</h2> <ul> <li>e4cb01498df6096b66edb0c78965ee6f47d3ac77 fixed a regression of the previous release.</li> </ul> <h2>v1.4.1</h2> <h2>🐛 Bug fixes</h2> <ul> <li>c119e832952c8c653bd4f21e39eb9f7ce48e5947 fixed <code>getStaticValue()</code> function to handle <code>null</code> literal correctly even if runtimes don't support BigInt natively.</li> <li>587cca2f82c245f5fc4a8b9fb2cf6b35c0d02552 fixed <code>getStringIfConstant()</code> function to handle regular expression literals and BigInt literals even if runtimes don't support those.</li> <li>08158db1c98fd71cf0f32ddefbc147e2620e724c fixed GHSA-3gx7-xhv7-5mx3.</li> </ul> <h2>v1.4.0</h2> <h2>✨ Enhancements</h2> <ul> <li>66456c5356310fc4309b4fe2756995f27b907747 (and ebf5a8378d3f0a20a74adb158a7112cb616bce44, aac472e815551688d23cc8fd88f9044dbf276804) added <code>isParenthesized()</code> function that checks if a given node is parenthesized or not.</li> <li>4f8407dd6cd52274ba115b3a8558153ec6d799a7 (and cb518c70ee037722f802d808bbbe93da83f07fb3) added <code>hasSideEffect()</code> function that checks if a given node may have side-effects or not.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mysticatea/eslint-utils/commit/23f4ddc58eda5e6aec3d6a43c6266acbe19345cd"><code>23f4ddc</code></a> 🔖 1.4.3</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/8f9e481ecc1204c7a1331b697f97903f90c75154"><code>8f9e481</code></a> 🐛 fix reference tracker false positive</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/663327835abfb1f62fc6fc5d69028457e11b5f80"><code>6633278</code></a> ⚒ fix test scripts</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/7c8e67c22f7222685a6a9154ba5eec2ac4896a3e"><code>7c8e67c</code></a> ⚒ fix build scripts</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/41ff95e728db2c52122ae3dad42997dccd223388"><code>41ff95e</code></a> ⚒ update dependencies</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/49420121ff4d2b4758d4016848055c1631389faa"><code>4942012</code></a> ⚒ fix build scripts</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/f1c8d02b3fd190a97e39603929c0aabe36c9904f"><code>f1c8d02</code></a> ⚒ update build scripts</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/a88598a74f0d71376447c4ecb6b56b27272f3992"><code>a88598a</code></a> Create FUNDING.yml</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/4e1bc077c2a6bb00538d66b69a63c24de3463bed"><code>4e1bc07</code></a> 1.4.2</li> <li><a href="https://github.com/mysticatea/eslint-utils/commit/e4cb01498df6096b66edb0c78965ee6f47d3ac77"><code>e4cb014</code></a> 🐛 add null test</li> <li>Additional commits viewable in <a href="https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+61 -21

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PR closed dgraham/option-type

Bump acorn from 5.7.2 to 5.7.4 dependencies

Bumps acorn from 5.7.2 to 5.7.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/6370e90067552022710190319cbbbd8c43001957"><code>6370e90</code></a> Mark version 5.7.4</li> <li><a href="https://github.com/acornjs/acorn/commit/fbc15b1344f6dfb992f67b4bbf1357436247c8a0"><code>fbc15b1</code></a> More rigorously check surrogate pairs in regexp validator</li> <li><a href="https://github.com/acornjs/acorn/commit/910e62bbda199ce7acc5de10d374afa0f6fcf7d6"><code>910e62b</code></a> Mark version 5.7.3</li> <li><a href="https://github.com/acornjs/acorn/commit/3442a80d2cdfa672ae2b6ccd6c2bd5c167914db4"><code>3442a80</code></a> Make generate-identifier-regex capable of rewriting src/identifier.js</li> <li><a href="https://github.com/acornjs/acorn/commit/22b22f36330d41a20225f26aab314d3e9d5452bd"><code>22b22f3</code></a> Raise specific errors for unterminated template literals</li> <li><a href="https://github.com/acornjs/acorn/commit/1461c7c5778933514126216fb3ec22d8dfc57feb"><code>1461c7c</code></a> Fix a lint error</li> <li><a href="https://github.com/acornjs/acorn/commit/0c12f63f171d8a6c8b354de54a7ff4a8d5fa486e"><code>0c12f63</code></a> Fix tokenizing of regexps after .of</li> <li><a href="https://github.com/acornjs/acorn/commit/832c3081da0df0a586cfc3ea96040f64252088b7"><code>832c308</code></a> Fix 404 url</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/5.7.2...5.7.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+49 -20

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventdgraham/option-type

David Graham

commit sha b86e1db4e21ba729e41edf7f31a9072f5c14cc6a

Update development dependencies Closes #1, #2, #3, #4

view details

push time in 2 months

PR closed dgraham/option-type

Bump js-yaml from 3.12.0 to 3.14.0 dependencies

Bumps js-yaml from 3.12.0 to 3.14.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md">js-yaml's changelog</a>.</em></p> <blockquote> <h2>[3.14.0] - 2020-05-22</h2> <h3>Changed</h3> <ul> <li>Support <code>safe/loadAll(input, options)</code> variant of call.</li> <li>CI: drop outdated nodejs versions.</li> <li>Dev deps bump.</li> </ul> <h3>Fixed</h3> <ul> <li>Quote <code>=</code> in plain scalars <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/519">#519</a>.</li> <li>Check the node type for <code>!<?></code> tag in case user manually specifies it.</li> <li>Verify that there are no null-bytes in input.</li> <li>Fix wrong quote position when writing condensed flow, <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/526">#526</a>.</li> </ul> <h2>[3.13.1] - 2019-04-05</h2> <h3>Security</h3> <ul> <li>Fix possible code execution in (already unsafe) <code>.load()</code>, <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/480">#480</a>.</li> </ul> <h2>[3.13.0] - 2019-03-20</h2> <h3>Security</h3> <ul> <li>Security fix: <code>safeLoad()</code> can hang when arrays with nested refs used as key. Now throws exception for nested arrays. <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/475">#475</a>.</li> </ul> <h2>[3.12.2] - 2019-02-26</h2> <h3>Fixed</h3> <ul> <li>Fix <code>noArrayIndent</code> option for root level, <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/468">#468</a>.</li> </ul> <h2>[3.12.1] - 2019-01-05</h2> <h3>Added</h3> <ul> <li>Added <code>noArrayIndent</code> option, <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/432">#432</a>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/nodeca/js-yaml/commit/34e5072f43fd36b08aaaad433da73c10d47c41e5"><code>34e5072</code></a> 3.14.0 released</li> <li><a href="https://github.com/nodeca/js-yaml/commit/7b25c83a6dc77097c2bf14bf714e168f60ee199b"><code>7b25c83</code></a> Browser files rebuild</li> <li><a href="https://github.com/nodeca/js-yaml/commit/6f7347396867b8dcfc042722c2aae810dfe4caae"><code>6f73473</code></a> Dev deps bump</li> <li><a href="https://github.com/nodeca/js-yaml/commit/0c293491d903cddcd41b41c165bc45eeb9a8d720"><code>0c29349</code></a> Travis-CI: drop old nodejs versions</li> <li><a href="https://github.com/nodeca/js-yaml/commit/10be97ebbd588e68907e6c67e0b3843a4caab475"><code>10be97e</code></a> fix(loader): Add support for <code>safe/loadAll(input, options)</code></li> <li><a href="https://github.com/nodeca/js-yaml/commit/d6983dd4291849b2854e8d26e1beb302edfd4c76"><code>d6983dd</code></a> Fix issue <a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/526">#526</a>: wrong quote position writing condensed flow (<a href="https://github-redirect.dependabot.com/nodeca/js-yaml/issues/527">#527</a>)</li> <li><a href="https://github.com/nodeca/js-yaml/commit/93fbf7d4ddecea60709c8379397247af28f11e10"><code>93fbf7d</code></a> fix issue 526 (wrong quote position writing condensed flow)</li> <li><a href="https://github.com/nodeca/js-yaml/commit/e569cc70ec9b41760d0d37b805a1d9b3ada519ca"><code>e569cc7</code></a> readme: update titelift info</li> <li><a href="https://github.com/nodeca/js-yaml/commit/8fb29059223b5f700dec4ea09b3d5550cd3a8e32"><code>8fb2905</code></a> changelog format update</li> <li><a href="https://github.com/nodeca/js-yaml/commit/33c2236d702fee430cac27ab41d75069b6647765"><code>33c2236</code></a> Verify that there are no null-bytes in input</li> <li>Additional commits viewable in <a href="https://github.com/nodeca/js-yaml/compare/3.12.0...3.14.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+49 -20

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventdgraham/option-type

David Graham

commit sha 47379370ee1ca00c663a438f61788ae322cac817

Build with GitHub Actions

view details

push time in 2 months

push eventdgraham/json-stream

David Graham

commit sha 63a963e6563652a09a5dc5d11f27a9fc84aea65a

Run bundle install

view details

push time in 2 months

delete branch dgraham/yajl-ffi

delete branch : actions

delete time in 2 months

push eventdgraham/yajl-ffi

David Graham

commit sha fcba0bbfdbe54fa4d65b9d1b7af79ba79ecef2cd

Build with GitHub Actions

view details

push time in 2 months

push eventdgraham/yajl-ffi

David Graham

commit sha f8fd246b2390d38f130afb03e0bbe74209a96a7f

Configure bundler

view details

push time in 2 months

create barnchdgraham/yajl-ffi

branch : actions

created branch time in 2 months

delete branch dgraham/json-stream

delete branch : actions

delete time in 2 months

push eventdgraham/json-stream

David Graham

commit sha 7552ffc01296989a8f872b72c829252a0a7e1cc9

Build with GitHub Actions

view details

push time in 2 months

push eventdgraham/json-stream

David Graham

commit sha b1e4fdedfdd23c1c5754cd9f6073d3f45434e4ba

Remove failure

view details

push time in 2 months

push eventdgraham/json-stream

David Graham

commit sha 88c99bb9e5e384000188cef166866b56e47dbcfd

Test failure

view details

push time in 2 months

push eventdgraham/json-stream

David Graham

commit sha b9aef8403d018e45d67dbf462c67bd2e5601a671

Do not generate gem docs

view details

push time in 2 months

push eventdgraham/json-stream

David Graham

commit sha dcd038144c1262ad3c56549c45c142bf31258cd5

Install bundler

view details

push time in 2 months

create barnchdgraham/json-stream

branch : actions

created branch time in 2 months

push eventdgraham/json-stream

David Graham

commit sha 4982a7c3e22ffa77f493ee3d790860d4a0586e8c

Use bundler 2.1

view details

David Graham

commit sha 5727de436cb2fae7459d66d07c2c490e27f60d45

Fix minitest deprecation warnings

view details

push time in 2 months

push eventdgraham/yajl-ffi

David Graham

commit sha 6beb32ef2958c8aec240319ebeac64156d6cfc00

Use bundler 2.1

view details

David Graham

commit sha f03276738102bc197112c5b80d71a3ca6ba0e7db

Fix minitest deprecation warnings

view details

push time in 2 months

push eventdgraham/identicon

David Graham

commit sha 09e27414865d84c4010f7be8a68caef0fcb80627

Build with GitHub Actions

view details

push time in 2 months

delete branch dgraham/calc

delete branch : actions

delete time in 2 months

push eventdgraham/calc

David Graham

commit sha 74093901117236868abc0acc6aadad9f499ccbc6

Build with GitHub Actions

view details

push time in 2 months

delete branch dgraham/scores

delete branch : actions

delete time in 2 months

create barnchdgraham/calc

branch : actions

created branch time in 2 months

push eventdgraham/scores

David Graham

commit sha 4e2a009a00227fd7d1a9fdf1c6dd1fb3642b7032

Build with GitHub Actions

view details

push time in 2 months

create barnchdgraham/scores

branch : actions

created branch time in 2 months

startedstefanjudis/web-vitals-element

started time in 2 months

push eventdgraham/mute-github-thread

David Graham

commit sha c35eb3c28b97a09397c101b7f1c24c50c8a3849c

Use flatMap

view details

push time in 2 months

push eventdgraham/mute-github-thread

David Graham

commit sha 605f3d1a86eb163b8b5b43c77c5efc73325fc134

Use macOS Big Sur screenshot

view details

push time in 2 months

starteddandavison/delta

started time in 2 months

startedjosh/josh

started time in 2 months

push eventgithub/query-selector

David Graham

commit sha 1fefff7d54568d3c70378222dfab732c0c3299eb

Build with actions

view details

push time in 2 months

push eventgithub/stable-socket

David Graham

commit sha 287dd89e67d856b8311f1e67658714ee488fe310

Update development dependencies

view details

push time in 2 months

delete branch github/mini-throttle

delete branch : cache-event-current-target

delete time in 3 months

PR closed github/mini-throttle

Make sure `currentTarget` is set on events

This doesn't feel as "clean" as the rest of the codebase but I ran into an issue where event.currentTarget is null when the callback is called after debouncing.

I believe that browsers lose the reference to currentTarget after the initial event handler scope. A note on the mdn article for Event.currentTarget states:

The value of event.currentTarget is only available while the event is being handled. If you console.log() the event object, storing it in a variable, and then look for the currentTarget key in the console, its value will be null. Instead, you can either directly console.log(event.currentTarget) to be able to view it in the console or use the debugger statement, which will pause the execution of your code thus showing you the value of event.currentTarget.

@muan pointed out we do something similar in delegated-events to rectify the issue.

Interested in hearing thoughts on this approach.

+712 -1

1 comment

5 changed files

koddsson

pr closed time in 3 months

delete branch github/auto-complete-element

delete branch : face

delete time in 3 months

delete branch github/remote-form

delete branch : update-deps

delete time in 3 months

push eventgithub/remote-form

David Graham

commit sha 6b51c0cceca4e602e8efc92f278be580639edce2

Remove stale branch name from build config

view details

push time in 3 months

push eventgithub/remote-form

David Graham

commit sha d9a1bc9f28e542dde6150450b94445815ab7d173

Update development dependencies Closes #23

view details

push time in 3 months

PR closed github/remote-form

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

delete branch github/g-emoji-element

delete branch : drop-emoji-support-on-linux

delete time in 3 months

PR closed github/g-emoji-element

feat: drop emoji support on linux. Fixes #2

Most Linux distributions come with support for Emoji by installing Noto. Adding fallback images can make things worse for linux users.

Fixes #2

For example here is Pop!_OS 20.04 (essentially Ubuntu) running Firefox, with native emoji support:

image

🦖😁

+2 -3

1 comment

1 changed file

keithamus

pr closed time in 3 months

pull request commentgithub/g-emoji-element

feat: drop emoji support on linux. Fixes #2

We need to know how many users this would affect before this can merge so closing for now.

keithamus

comment created time in 3 months

pull request commentgithub/g-emoji-element

use original emoji as alt text, alias as title

Closing as stale.

Crissov

comment created time in 3 months

Pull request review commentgithub/mini-throttle

Make sure `currentTarget` is set on events

 export function throttle<T extends unknown[]>(   let cancelled = false   function fn(this: unknown, ...args: T) {     if (cancelled) return++    // Cache the `currentTarget` if we are throttling a event handler.+    if (args[0] instanceof Event) {

I agree that this is a layering violation and outside the scope of mini-throttle. The caller to throttle or debounce can bind a function to the element: throttle(doSomething.bind(null, el)).

I think that this code makes sense in delegated-events since that's dealing with events

This is in place not for convenience but because it's the contract for event dispatch. The currentTarget value must be null after dispatch completes.

koddsson

comment created time in 3 months

delete branch github/markdown-toolbar-element

delete branch : fix-hotkey-selector

delete time in 3 months

release github/markdown-toolbar-element

v1.3.2

released time in 3 months

created taggithub/markdown-toolbar-element

tagv1.3.2

Markdown formatting buttons for text inputs.

created time in 3 months

push eventgithub/markdown-toolbar-element

David Graham

commit sha 7bbdf32ab7f7343e6ba10d6f30320aaf0d8c7709

1.3.2

view details

push time in 3 months

push eventgithub/markdown-toolbar-element

David Graham

commit sha a20936d2ab332c0872c16bd87382ab38dff09320

Fix invalid selector in hotkey query Using string concatentation with user controlled input to build a selector query results in syntax errors. > SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector. Instead, query potential hotkey buttons and test their attribute against the event's key value.

view details

David Graham

commit sha 4849a95faf5018a0164dba9c4f25782732b458a5

Merge pull request #34 from github/fix-hotkey-selector Fix invalid selector in hotkey query

view details

push time in 3 months

PR merged github/markdown-toolbar-element

Fix invalid selector in hotkey query

Using string concatentation with user controlled input to build a selector query results in syntax errors.

SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector.

Instead, query potential hotkey buttons and test their attribute against the event's key value.

+10 -1

0 comment

1 changed file

dgraham

pr closed time in 3 months

PR opened github/markdown-toolbar-element

Fix invalid selector in hotkey query

Using string concatentation with user controlled input to build a selector query results in syntax errors.

SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector.

Instead, query potential hotkey buttons and test their attribute against the event's key value.

+10 -1

0 comment

1 changed file

pr created time in 3 months

create barnchgithub/markdown-toolbar-element

branch : fix-hotkey-selector

created branch time in 3 months

push eventgithub/markdown-toolbar-element

David Graham

commit sha a561e302b7c5e2430e594eacdcd9242c539ad294

Update development dependencies

view details

push time in 3 months

push eventdgraham/dotvim

David Graham

commit sha 369cac5a2716899befdf52548c20dfde2eeb9036

Update plugins

view details

push time in 3 months

issue commentgithub/fetch

iOS 11 and 10 have outdated native fetch implementation

How would you recommend most companies/projects go about patching this for iOS 11+10?

We need to deal with the iOS 10 implementation of fetch on its own terms without patching over pieces of it. The approach we used was a module similar to this, mildly outdated, example. We called into the module function rather than using window.fetch directly.

When we stopped supporting browser versions with the previous credentials default of omit, we replaced calls to the module function with window.fetch.

devinrhode2

comment created time in 3 months

issue closedgithub/fetch

Backport of #24147

Backport of #24147

See that PR for details.

Notes: none.

Originally posted by @trop in https://github.com/electron/electron/pull/24176

closed time in 3 months

abent999

push eventgithub/file-attachment-element

David Graham

commit sha 207ed2ca0489fbcc553cd0324e596dfd3c5c563b

Update development dependencies

view details

push time in 3 months

push eventgithub/file-attachment-element

David Graham

commit sha ded09b90d1f611586dff04b31716d3a5328667cf

Build with Actions

view details

push time in 3 months

more