profile
viewpoint
David Graham dgraham GitHub Denver, CO, USA Making github.com a little more wonderful every day.

dgraham/delegated-events 948

A small, fast delegated event library for JavaScript.

dgraham/Ka-Block 584

A Safari extension that blocks an artisanal selection of advertising domains.

dgraham/eslint-plugin-jquery 182

Disallow jQuery functions with native equivalents.

dgraham/json-stream 153

A streaming JSON parser that generates SAX-like events.

dgraham/identicon 37

A port of GitHub's identicon algorithm to Rust.

dgraham/mute-github-thread 25

Mute GitHub email notification threads with a macOS Mail shortcut.

dgraham/libds 10

Simple data structures in C.

dgraham/couchtweet 7

An example Rails app using CouchDB, CouchRest, and Twitter's data model.

dgraham/eslint-plugin-i18n-text 7

Disallow English text in string literals.

dgraham/couchproxy 6

A proxy server for Apache CouchDB clusters.

delete branch github/mini-throttle

delete branch : cache-event-current-target

delete time in a day

PR closed github/mini-throttle

Make sure `currentTarget` is set on events

This doesn't feel as "clean" as the rest of the codebase but I ran into an issue where event.currentTarget is null when the callback is called after debouncing.

I believe that browsers lose the reference to currentTarget after the initial event handler scope. A note on the mdn article for Event.currentTarget states:

The value of event.currentTarget is only available while the event is being handled. If you console.log() the event object, storing it in a variable, and then look for the currentTarget key in the console, its value will be null. Instead, you can either directly console.log(event.currentTarget) to be able to view it in the console or use the debugger statement, which will pause the execution of your code thus showing you the value of event.currentTarget.

@muan pointed out we do something similar in delegated-events to rectify the issue.

Interested in hearing thoughts on this approach.

+712 -1

1 comment

5 changed files

koddsson

pr closed time in a day

delete branch github/auto-complete-element

delete branch : face

delete time in a day

delete branch github/remote-form

delete branch : update-deps

delete time in a day

push eventgithub/remote-form

David Graham

commit sha 6b51c0cceca4e602e8efc92f278be580639edce2

Remove stale branch name from build config

view details

push time in a day

push eventgithub/remote-form

David Graham

commit sha d9a1bc9f28e542dde6150450b94445815ab7d173

Update development dependencies Closes #23

view details

push time in a day

PR closed github/remote-form

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a day

delete branch github/g-emoji-element

delete branch : drop-emoji-support-on-linux

delete time in a day

PR closed github/g-emoji-element

feat: drop emoji support on linux. Fixes #2

Most Linux distributions come with support for Emoji by installing Noto. Adding fallback images can make things worse for linux users.

Fixes #2

For example here is Pop!_OS 20.04 (essentially Ubuntu) running Firefox, with native emoji support:

image

🦖😁

+2 -3

1 comment

1 changed file

keithamus

pr closed time in a day

pull request commentgithub/g-emoji-element

feat: drop emoji support on linux. Fixes #2

We need to know how many users this would affect before this can merge so closing for now.

keithamus

comment created time in a day

pull request commentgithub/g-emoji-element

use original emoji as alt text, alias as title

Closing as stale.

Crissov

comment created time in a day

Pull request review commentgithub/mini-throttle

Make sure `currentTarget` is set on events

 export function throttle<T extends unknown[]>(   let cancelled = false   function fn(this: unknown, ...args: T) {     if (cancelled) return++    // Cache the `currentTarget` if we are throttling a event handler.+    if (args[0] instanceof Event) {

I agree that this is a layering violation and outside the scope of mini-throttle. The caller to throttle or debounce can bind a function to the element: throttle(doSomething.bind(null, el)).

I think that this code makes sense in delegated-events since that's dealing with events

This is in place not for convenience but because it's the contract for event dispatch. The currentTarget value must be null after dispatch completes.

koddsson

comment created time in 2 days

delete branch github/markdown-toolbar-element

delete branch : fix-hotkey-selector

delete time in 2 days

release github/markdown-toolbar-element

v1.3.2

released time in 2 days

created taggithub/markdown-toolbar-element

tagv1.3.2

Markdown formatting buttons for text inputs.

created time in 2 days

push eventgithub/markdown-toolbar-element

David Graham

commit sha 7bbdf32ab7f7343e6ba10d6f30320aaf0d8c7709

1.3.2

view details

push time in 2 days

push eventgithub/markdown-toolbar-element

David Graham

commit sha a20936d2ab332c0872c16bd87382ab38dff09320

Fix invalid selector in hotkey query Using string concatentation with user controlled input to build a selector query results in syntax errors. > SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector. Instead, query potential hotkey buttons and test their attribute against the event's key value.

view details

David Graham

commit sha 4849a95faf5018a0164dba9c4f25782732b458a5

Merge pull request #34 from github/fix-hotkey-selector Fix invalid selector in hotkey query

view details

push time in 2 days

PR merged github/markdown-toolbar-element

Fix invalid selector in hotkey query

Using string concatentation with user controlled input to build a selector query results in syntax errors.

SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector.

Instead, query potential hotkey buttons and test their attribute against the event's key value.

+10 -1

0 comment

1 changed file

dgraham

pr closed time in 2 days

PR opened github/markdown-toolbar-element

Fix invalid selector in hotkey query

Using string concatentation with user controlled input to build a selector query results in syntax errors.

SyntaxError: Failed to execute 'querySelector' on 'Element': '[hotkey="""]' is not a valid selector.

Instead, query potential hotkey buttons and test their attribute against the event's key value.

+10 -1

0 comment

1 changed file

pr created time in 2 days

create barnchgithub/markdown-toolbar-element

branch : fix-hotkey-selector

created branch time in 2 days

push eventgithub/markdown-toolbar-element

David Graham

commit sha a561e302b7c5e2430e594eacdcd9242c539ad294

Update development dependencies

view details

push time in 2 days

push eventdgraham/dotvim

David Graham

commit sha 369cac5a2716899befdf52548c20dfde2eeb9036

Update plugins

view details

push time in 2 days

issue commentgithub/fetch

iOS 11 and 10 have outdated native fetch implementation

How would you recommend most companies/projects go about patching this for iOS 11+10?

We need to deal with the iOS 10 implementation of fetch on its own terms without patching over pieces of it. The approach we used was a module similar to this, mildly outdated, example. We called into the module function rather than using window.fetch directly.

When we stopped supporting browser versions with the previous credentials default of omit, we replaced calls to the module function with window.fetch.

devinrhode2

comment created time in 7 days

issue closedgithub/fetch

Backport of #24147

Backport of #24147

See that PR for details.

Notes: none.

Originally posted by @trop in https://github.com/electron/electron/pull/24176

closed time in 10 days

abent999

push eventgithub/file-attachment-element

David Graham

commit sha 207ed2ca0489fbcc553cd0324e596dfd3c5c563b

Update development dependencies

view details

push time in 10 days

push eventgithub/file-attachment-element

David Graham

commit sha ded09b90d1f611586dff04b31716d3a5328667cf

Build with Actions

view details

push time in 10 days

push eventgithub/stable-socket

Dominic

commit sha b9eb1b496ecc22b652ba80ac4c0d3a9a9ca6f3c9

Update README.md

view details

David Graham

commit sha edd9b42ca3aed7a992f05e862fc2624e97ec8542

Merge pull request #2 from doms/patch-1 Fix small typo in README

view details

push time in 11 days

PR merged github/stable-socket

Fix small typo in README

👋

Was reading the wonderful docs and noticed that an equal sign was missing for the url variable declaration.

cc @dgraham

+1 -1

0 comment

1 changed file

doms

pr closed time in 11 days

push eventdgraham/stache-bind

David Graham

commit sha 59ffbd78a77b5d2a8f286b92ac0deb3ea842f8af

Convert to TypeScript

view details

push time in 13 days

push eventdgraham/stache-bind

David Graham

commit sha ca2814a1555fc50fc8c216ce19b8bba1abf23915

Update development dependencies

view details

David Graham

commit sha dc9689b5c72e7fa1a2f3000d9493f89c6aae1b9f

Build and test with actions

view details

push time in 13 days

startedgithub/stable-socket

started time in 15 days

delete branch github/multimap

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 16 days

PR closed github/multimap

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 16 days

push eventdgraham/scores

David Graham

commit sha 4ae0fc64842ae8daeeb8b6c647bbb1123c5e1c34

Update dependencies

view details

push time in 16 days

push eventgithub/multimap

David Graham

commit sha 2a5d71a528f6ea6dc91a9703572ef9da0a7d99c4

Update development dependencies

view details

push time in 17 days

push eventgithub/eslint-plugin-github

David Graham

commit sha 8d98ff20c6dc416d169f8926664515b45e3a52ba

Fix typo

view details

push time in 21 days

push eventdgraham/eslint-plugin-i18n-text

David Graham

commit sha e1cbb441dedd87cf722d3c3f41556fa3e4b4bf2f

Update development dependencies Closes #5

view details

David Graham

commit sha 8fa419831c87b2415fb5242b8803ec0997185a4a

Replace Travis CI with actions

view details

push time in 21 days

PR closed dgraham/eslint-plugin-i18n-text

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventdgraham/eslint-plugin-jquery

David Graham

commit sha 8d5f2a331b61bf8eecc017de1c8bf3bdf2e532bf

Update development dependencies Closes #40

view details

David Graham

commit sha 555b4b7da5c9b1fac91ec36316a510f169045878

Replace Travis CI with actions

view details

push time in 21 days

PR closed dgraham/eslint-plugin-jquery

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventdgraham/eslint-plugin-delegated-events

David Graham

commit sha e1339e6f4d5ab0322185650ba570dc98eb7e5e20

Update development dependencies Closes #3

view details

David Graham

commit sha 66cd7d93650c6468aa3ddb96eba9edca2b915ddf

Replace Travis CI with actions

view details

push time in 21 days

PR closed dgraham/eslint-plugin-delegated-events

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventdgraham/delegated-events

David Graham

commit sha 5bdca98b252995cfff2a01256d452984681effd9

Remove Travis CI build

view details

push time in 21 days

push eventdgraham/delegated-events

David Graham

commit sha 2c31fbb0ade735b676751d30867988b1019b7178

Configure actions build

view details

push time in 21 days

push eventdgraham/delegated-events

David Graham

commit sha 5a5a57416e5d140f13e7ab8197ddf61659d97a16

Update development dependencies Closes #33

view details

push time in 21 days

PR closed dgraham/delegated-events

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

Pull request review commentgithub/eslint-plugin-github

Add event listener lints

 module.exports = {     'github/no-blur': 'error',     'github/no-dataset': 'error',     'github/no-innerText': 'error',-    'github/unescaped-html-literal': 'error'+    'github/unescaped-html-literal': 'error',+    'github/no-useless-passive': 'error',+    'github/no-non-passive-high-frequency-events': 'error',+    'github/prefer-observers-over-events': 'error'

We can tighten this up to something like prefer-observers. Lint rules typically name the alternatives in the error message rather than the rule name.

keithamus

comment created time in 22 days

Pull request review commentgithub/eslint-plugin-github

Add event listener lints

 module.exports = {     'github/no-blur': 'error',     'github/no-dataset': 'error',     'github/no-innerText': 'error',-    'github/unescaped-html-literal': 'error'+    'github/unescaped-html-literal': 'error',+    'github/no-useless-passive': 'error',+    'github/no-non-passive-high-frequency-events': 'error',

Can we replace the double negative with a positive assertion: require-passive-events?

keithamus

comment created time in 22 days

startedjasonlong/isometric-contributions

started time in a month

issue closedgithub/fetch

TypeError: Fetch event is destroyed. Safari bug tracked by Sentry after updating to latest whatwg-fetch@3.1.0

IOS 13.5.1 Mobile Safari 13.1.1

error on attempt to load css file from same origin

Never seen error like that before today.

Screenshot 2020-06-30 19 58 43

I've posted by accident to https://github.com/whatwg/fetch/issues/1048

closed time in a month

JustFly1984

issue closedgithub/fetch

IE11 fails with Syntax error on line 78

Using https://cdnjs.cloudflare.com/ajax/libs/fetch/3.1.0/fetch.js

IE fails to load the fetch polyfill with

SCRIPT1002: Syntax error
fetch.js (78,1)

Line 78:

export function Headers(headers) {

closed time in a month

ericnewton76

issue commentgithub/fetch

IE11 fails with Syntax error on line 78

Loading the module file from a third-party server isn’t a supported distribution format. The module needs to be compiled into a bundle using Rollup or Webpack in the host app.

ericnewton76

comment created time in a month

push eventdgraham/dotvim

David Graham

commit sha 6a73267f61b84b8a4d006b80a774ce8f69d9f614

Update plugins

view details

push time in a month

startedGoogleChrome/web-vitals

started time in a month

issue closedgithub/fetch

iOS 11 and 10 have outdated native fetch implementation

Summary: iOS 11 and 10 have a native window.fetch implementation, but they do not have credentials: 'same-origin' as the new default

This is not necessarily a browser bug. This is the original ticket in webkit's bugzilla tracker, "Make fetch() use "same-origin" credentials by default" https://bugs.webkit.org/show_bug.cgi?id=176023

It's fixed in iOS 12, and I'm assuming Apple isn't going to be updating iOS 11 and 10.

Basically, to account for iOS 11 and 10, developers need to ensure they pass credentials: 'same-origin' to all fetch calls which require cookies/auth (api's that return unique data from user's account, assuming they are logged in).

In leu of explaining everything in full depth, I think the best way to fix this would be with extremely specific UA detection, basically only checking for iOS 11 and 10, and if a UA appears to be iOS 11/10, running some code like this:

window.outdatedNativeFetch = window.fetch;
window.fetch = (url, opts) => window.outdatedNativeFetch(url, {...opts, credentials: 'same-origin'})

Of course, we could also just force the polyfill, if we fear there's more issues with iOS 11+10

closed time in a month

devinrhode2

issue commentgithub/fetch

iOS 11 and 10 have outdated native fetch implementation

The polyfill doesn't patch browser bugs or old spec versions in native implementations. It's active only in browsers without a fetch implementation. The credentials option must be set in fetch requests until the site stops supporting browser versions with the older default of omit.

devinrhode2

comment created time in a month

startedmuan/ab-rust

started time in a month

created repositorydgraham/test-import-2

created time in a month

issue closeddgraham/Ka-Block

Update for MacOS and iOS apps?

Hi @dgraham, I love this extension. Any chance we can get a new release for Mac and iOS with all the latest commits? Thanks! Abhaya

closed time in a month

abhayap

issue commentdgraham/Ka-Block

Update for MacOS and iOS apps?

I fixed a couple issues that caused the macOS app to be rejected and version 3.3 is in the App Store now.

abhayap

comment created time in a month

push eventdgraham/Ka-Block

David Graham

commit sha d4686b9f7c19a55ea3d033109547f6184d2cf9ff

Define color asset for dark mode

view details

push time in a month

push eventdgraham/Ka-Block

David Graham

commit sha 053b1e2cba74466039f4a7f92327de5668f56c07

Quit when window closes

view details

push time in a month

release github/multimap

v1.0.0

released time in a month

created taggithub/multimap

tagv1.0.0

A map in which more than one value may be stored under each key.

created time in a month

push eventgithub/multimap

David Graham

commit sha 72b14049b8d697a91c1af1bd78407b2604368bfc

1.0.0

view details

push time in a month

push eventgithub/multimap

David Graham

commit sha ff2962f1baf277374697c616baca71a48a87a383

Update description

view details

David Graham

commit sha 4dd663f3b3aa440b85137833b6557a431515d475

Document return values

view details

David Graham

commit sha 25445efeba9e69626054023e553ce96cd7550b2b

Document constructors

view details

push time in a month

push eventgithub/multimap

David Graham

commit sha bd4617b39c08ee6b6448485f4a90b55575fdf763

Initialize map from an Iterable<[K, V]>

view details

David Graham

commit sha d36191cc07a67f3e42da083306a54ba15d4bc556

Update development dependencies

view details

push time in a month

push eventgithub/multimap

David Graham

commit sha 59f7a51b0bde9406158ab515618ae88930e92f26

Document methods

view details

push time in a month

issue closedgithub/fetch

Implement `Body.body` ReadableStream interface

The definition of the Body object is missing the Bode.body property, that provides a ReadableStream object. In node-fetch it's implemented using Node.js streams, that although is not API compatible, it's a similar concept and differences can somewhat easily overriden. Probably this would require to implement a ReadableStream polyfill first...

closed time in 2 months

piranna

issue commentgithub/fetch

Implement `Body.body` ReadableStream interface

#746

piranna

comment created time in 2 months

push eventdgraham/dotvim

David Graham

commit sha 34403efe88c54596500c7136930d7724acc4f773

Add node shortcut

view details

David Graham

commit sha 567badc101a3f1eadc7b787c34091db835c6278f

Update plugins

view details

push time in 2 months

startedgithub/multimap

started time in 2 months

Pull request review commentgithub/hotkey

TypeScript conversion

 export class RadixTrie {     return currentNode   } -  // eslint-disable-next-line flowtype/no-weak-types-  delete(node: RadixTrie | Leaf<any>) {+  delete(node: RadixTrie | Leaf<unknown>) {
  delete(node: RadixTrie | Leaf<unknown>): boolean {
muan

comment created time in 2 months

Pull request review commentgithub/hotkey

TypeScript conversion

+{+  "compilerOptions": {+    "module": "esnext",
    "module": "es2020",
muan

comment created time in 2 months

Pull request review commentgithub/hotkey

TypeScript conversion

+name: Node CI++on: push+jobs:+  build:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v2+    - name: Use Node.js 12.x+      uses: actions/setup-node@v1+      with:+        node-version: 12.x+    - name: npm install, build, and test+      run: |+        npm install+        npm run build --if-present
        npm run build
muan

comment created time in 2 months

Pull request review commentgithub/details-menu-element

TypeScript conversion

 $ npm install @github/details-menu-element  ## Usage +### Script++Import as ES modules:
Import as a module:
muan

comment created time in 2 months

Pull request review commentgithub/details-menu-element

TypeScript conversion

+name: Node CI++on: push+jobs:+  build:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v2+    - name: Use Node.js 12.x+      uses: actions/setup-node@v1+      with:+        node-version: 12.x+    - name: npm install, build, and test+      run: |+        npm install+        npm run build --if-present
        npm run build
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

 export default class IncludeFragmentElement extends HTMLElement {   get src() {     const src = this.getAttribute('src')     if (src) {-      const link = this.ownerDocument.createElement('a')+      const link = this.ownerDocument!.createElement('a')       link.href = src       return link.href     } else {       return ''     }   } -  set src(val) {+  set src(val: string) {     this.setAttribute('src', val)   }    get accept() {
  get accept(): string {
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

+{+  "compilerOptions": {+    "module": "esnext",
    "module": "es2020",
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

 export default class IncludeFragmentElement extends HTMLElement {   get src() {     const src = this.getAttribute('src')     if (src) {-      const link = this.ownerDocument.createElement('a')+      const link = this.ownerDocument!.createElement('a')       link.href = src       return link.href     } else {       return ''     }   } -  set src(val) {+  set src(val: string) {     this.setAttribute('src', val)   }    get accept() {-    return this.getAttribute('accept')+    return this.getAttribute('accept') || ''   } -  set accept(val) {+  set accept(val: string) {     this.setAttribute('accept', val)   }    get data() {
  get data(): Promise<string> {
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

 function getData(el) {   } } -function isWildcard(accept) {+function isWildcard(accept: string | null) {   return accept && !!accept.split(',').find(x => x.match(/^\s*\*\/\*/)) }  export default class IncludeFragmentElement extends HTMLElement {+  _attached: boolean+   constructor() {     super()+    this._attached = false   }    static get observedAttributes() {
  static get observedAttributes(): string[] {
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

 export default class IncludeFragmentElement extends HTMLElement {   get src() {     const src = this.getAttribute('src')     if (src) {-      const link = this.ownerDocument.createElement('a')+      const link = this.ownerDocument!.createElement('a')       link.href = src       return link.href     } else {       return ''     }   } -  set src(val) {+  set src(val: string) {     this.setAttribute('src', val)   }    get accept() {-    return this.getAttribute('accept')+    return this.getAttribute('accept') || ''   } -  set accept(val) {+  set accept(val: string) {     this.setAttribute('accept', val)   }    get data() {     return getData(this)   } -  attributeChangedCallback(attribute) {+  attributeChangedCallback(attribute: string) {
  attributeChangedCallback(attribute: string): void {
muan

comment created time in 2 months

Pull request review commentgithub/include-fragment-element

TypeScript conversion

 export default class IncludeFragmentElement extends HTMLElement {   get src() {
  get src(): string {
muan

comment created time in 2 months

Pull request review commentgithub/g-emoji-element

TypeScript conversion

 class GEmojiElement extends HTMLElement {    connectedCallback() {
  connectedCallback(): void {
muan

comment created time in 2 months

Pull request review commentgithub/g-emoji-element

TypeScript conversion

   "name": "@github/g-emoji-element",   "version": "1.1.3",   "description": "Backports native emoji characters to browsers that don't support them by replacing the characters with fallback images.",-  "main": "dist/index.umd.js",-  "module": "dist/index.esm.js",-  "types": "index.d.ts",+  "main": "dist/index.js",+  "type": "module",+  "module": "dist/index.js",+  "types": "dist/index.d.ts",   "license": "MIT",   "repository": "github/g-emoji-element",+  "prettier": "@github/prettier-config",   "files": [-    "dist",-    "index.d.ts"+    "dist"   ],   "scripts": {     "clean": "rm -rf dist",-    "lint": "github-lint",+    "lint": "eslint . --ext .js,.ts && tsc --noEmit",     "prebuild": "npm run clean && npm run lint && mkdir dist",-    "build": "rollup -c && cp index.js.flow dist/index.esm.js.flow && cp index.js.flow dist/index.umd.js.flow",+    "build": "tsc && rollup -c",     "pretest": "npm run build",-    "generate-emoji": "script/generate-emoji-modifiers > modifiers.js && prettier --write modifiers.js",-    "test": "karma start test/karma.config.js",+    "generate-emoji": "script/generate-emoji-modifiers.cjs > src/modifiers.ts && prettier --write src/modifiers.ts",+    "test": "karma start test/karma.config.cjs",     "prepublishOnly": "npm run build",     "postpublish": "npm publish --ignore-scripts --@github:registry='https://npm.pkg.github.com'"   },   "devDependencies": {-    "@babel/cli": "^7.4.4",-    "@babel/core": "^7.4.5",-    "babel-preset-github": "^3.2.0",+    "@github/prettier-config": "0.0.4",     "chai": "^4.2.0",-    "eslint": "^6.6.0",-    "eslint-plugin-github": "^2.0.0",-    "flow-bin": "^0.101.1",-    "karma": "^4.1.0",+    "eslint": "^6.8.0",+    "eslint-plugin-github": "^4.0.0",+    "karma": "^5.0.9",     "karma-chai": "^0.1.0",     "karma-chrome-launcher": "^2.2.0",-    "karma-mocha": "^1.3.0",+    "karma-mocha": "^2.0.1",     "karma-mocha-reporter": "^2.2.5",-    "mocha": "^6.1.4",-    "rollup": "^1.26.3",-    "rollup-plugin-babel": "^4.3.3",+    "mocha": "^6.2.3",+    "rollup": "^1.32.1",

Can we use the latest 2.x version?

muan

comment created time in 2 months

Pull request review commentgithub/g-emoji-element

TypeScript conversion

+name: Node CI++on: push+jobs:+  build:+    runs-on: macos-latest+    steps:+    - uses: actions/checkout@v2+    - name: Use Node.js 12.x+      uses: actions/setup-node@v1+      with:+        node-version: 12.x+    - name: npm install, build, and test+      run: |+        npm install+        npm run build --if-present
        npm run build
muan

comment created time in 2 months

Pull request review commentgithub/g-emoji-element

TypeScript conversion

+name: Node CI++on: push+jobs:+  build:+    runs-on: macos-latest

Let's standardize on ubuntu-latest for builds.

    runs-on: ubuntu-latest
muan

comment created time in 2 months

issue closedgithub/fetch

build

closed time in 2 months

ShawtyDaGee

push eventgithub/file-attachment-element

David Graham

commit sha da2bf91879a84d7078d5958f868b6bc96374453e

Update development dependencies

view details

David Graham

commit sha ece0d59927b3c1da8ce98c7294ba713b56e5e2a2

Remove unused prettier config

view details

David Graham

commit sha 0751b9b71bae32df8ad3310dda296db5323bb72f

Annotate return types to fix tsc warnings

view details

push time in 3 months

Pull request review commentgithub/markdown-toolbar-element

Convert to TypeScript and simplify toolchain

 function orderedList(textarea: HTMLTextAreaElement): SelectionRange {       textarea.selectionEnd = endOfLine     }   } else {-    lines = (function() {+    lines = (function () {

It could be a good time to make this a named function. This looks like a CoffeeScript remnant.

muan

comment created time in 3 months

Pull request review commentgithub/markdown-toolbar-element

Convert to TypeScript and simplify toolchain

 const buttonSelectors = [ ] function getButtons(toolbar: Element): HTMLElement[] {   const els = []-  for (const button of toolbar.querySelectorAll(buttonSelectors.join(', '))) {+  for (const button of toolbar.querySelectorAll<HTMLElement>(buttonSelectors.join(', '))) {     // Skip buttons that are hidden, either via `hidden` attribute or CSS:     if (button.hidden || (button.offsetWidth <= 0 && button.offsetHeight <= 0)) continue     if (button.closest('markdown-toolbar') === toolbar) els.push(button)   }   return els } -function keydown(fn: KeyboardEventHandler): KeyboardEventHandler {-  return function(event: KeyboardEvent) {+function keydown(fn: (arg0: KeyboardEvent) => void): (arg0: KeyboardEvent) => void {
function keydown(fn: (event: KeyboardEvent) => void): (event: KeyboardEvent) => void {
muan

comment created time in 3 months

Pull request review commentgithub/markdown-toolbar-element

Convert to TypeScript and simplify toolchain

+{+  "compilerOptions": {+    "module": "esnext",

We should avoid moving pointers and use a fixed version to output.

    "module": "es2020",
muan

comment created time in 3 months

Pull request review commentgithub/markdown-toolbar-element

Convert to TypeScript and simplify toolchain

   "version": "1.2.0",   "description": "Markdown formatting buttons for text inputs.",   "repository": "github/markdown-toolbar-element",-  "main": "dist/index.umd.js",-  "module": "dist/index.esm.js",

Does Rollup do the right thing with a main + type key combination or do we still need the module key?

muan

comment created time in 3 months

pull request commentgithub/eslint-plugin-github

Turn off `@typescript-eslint/no-empty-function'` rule.

The function can contain a comment explaining why it's empty, right? What is an example empty function that we want to allow?

koddsson

comment created time in 3 months

issue closedgithub/time-elements

relative-time and time-ago elements display date after relative string

Hi,

When the page loads temporarily I can see the absolute time next to relative. This happens for both relative-time and time-ago elements.

Screen Shot 2020-05-14 at 6 08 42 PM

Are you maybe familiar with this issue?

One second after the page is loaded the element displays as it should - only the relative time.

Thank you :)

closed time in 3 months

bmarkons

issue commentgithub/time-elements

relative-time and time-ago elements display date after relative string

The elements overwrite textContent rather than append to it, so you might start debugging at those assignments to see what content is inserted.

bmarkons

comment created time in 3 months

issue commentgithub/remote-form

Did removing `selector-set` have a adverse effect on performance.

// Naive loop
// O(n x m) -> at a tree depth of 20 and selector list of 100
// this is 2,000 matches calls.
for (const el of elements) {
  for (const sel of selectors) {
    if (el.matches(sel)) {
      // do something
    }
  }
}

// SelectorSet
for (const el of elements) {
  // set calls matches only against selectors that have a chance of
  // matching, dropping 2,000 calls to just a handful.
  if (set.matches(el)) {
      // do something
    }
  }
}

Prior art

git clone https://github.com/dgraham/delegated-events.git
cd delegated-events
npm install
npm run bench
koddsson

comment created time in 3 months

pull request commentdgraham/delegated-events

Allow firing events on Document in TypeScript

This needs to match the EventTarget definition in Flow.

koddsson

comment created time in 3 months

more