profile
viewpoint
Kristján Oddsson koddsson GitHub London, UK https://koddsson.com I mostly argue about monorepos. In my spare time I write the JavaScript you're running.

github/hotkey 2153

Trigger an action on an element with a keyboard shortcut.

dgraham/delegated-events 948

A small, fast delegated event library for JavaScript.

github/tab-container-element 169

An accessible tab container element with keyboard support.

github/auto-check-element 65

An input element that validates its value with a server endpoint.

github/session-resume 40

Annotate fields to be persisted on navigation away from the current page

github/remote-form 24

Submit forms via AJAX with ease

keithamus/mini-observable 16

A mini implementation of TC39 observables, plus some utils!

github/refined-github 9

Browser extension that simplifies the GitHub interface and adds useful features

github/babel-plugin-ensure-name-for-custom-elements 7

This plugin makes sure that your custom elements always have a name property, even after minifying.

github/browser-detection 7

A utility for detecting browsers in Braintree libs.

Pull request review commentgithub/mini-throttle

Make sure `currentTarget` is set on events

 export function throttle<T extends unknown[]>(   let cancelled = false   function fn(this: unknown, ...args: T) {     if (cancelled) return++    // Cache the `currentTarget` if we are throttling a event handler.+    if (args[0] instanceof Event) {

I agree.

I've gone back and forth if I should open this PR over the past couple of days because this didn't feel right. In the end, I wanted to get some second eyes on the problem in case this looked fine to anyone or if there was an alternative I wasn't seeing.

On one hand, I think that this code makes sense in delegated-events since that's dealing with events but on the other, I feel like this will come as a surprise to consumers of the library when they try to debounce event handlers.

Maybe the solution here is to add a section to the README and write our own event handle debouncer for github/github.

koddsson

comment created time in 2 days

push eventgithub/mini-throttle

Kristján Oddsson

commit sha f203dff0d94f023cc30b8d8b6475fd9a90076cc6

Create CODEOWNERS

view details

push time in 2 days

push eventgithub/mini-throttle

Kristján Oddsson

commit sha 1ad31c28dc82cf85d5eef37cc88233e4ae57bf69

Cache `event.currentTarget` when throttling

view details

push time in 2 days

pull request commentgithub/mini-throttle

Add test to show that `currentTarget` is unset

I pushed the first commit to show that the test fails but there seems to be a small incident preventing me from pushing the second commit 😬

koddsson

comment created time in 2 days

Pull request review commentgithub/mini-throttle

Add test to show that `currentTarget` is unset

     "eslint-plugin-compat": "^3.5.1",     "eslint-plugin-escompat": "^1.1.0",     "eslint-plugin-github": "^3.4.1",+    "jsdom": "16.3.0",+    "jsdom-global": "3.0.2",

I added jsdom as a quick way to write a test for this but I would probably want to replace it with karma in order to be more in line with our other repositories.

koddsson

comment created time in 2 days

PR opened github/mini-throttle

Add test to show that `currentTarget` is unset

This doesn't feel as "clean" as the rest of the codebase but I ran into an issue where event.currentTarget is null when the callback is called after debouncing.

I believe that browsers lose the reference to currentTarget after the initial event handler scope. A note on the mdn article for Event.currentTarget states:

The value of event.currentTarget is only available while the event is being handled. If you console.log() the event object, storing it in a variable, and then look for the currentTarget key in the console, its value will be null. Instead, you can either directly console.log(event.currentTarget) to be able to view it in the console or use the debugger statement, which will pause the execution of your code thus showing you the value of event.currentTarget.

@muan pointed out we do something similar in delegated-events to rectify the issue.

Interested in hearing thoughts on this approach.

+696 -1

0 comment

3 changed files

pr created time in 2 days

create barnchgithub/mini-throttle

branch : cache-event-current-target

created branch time in 2 days

startedmuan/emojilib

started time in 6 days

push eventgithub/gemoji

Billie Thompson

commit sha 7f6550fe73e4db73428102f76bde4236f81c8cdd

Remove underscore from Pinata Relates-to: github/gemoji#180

view details

Kristján Oddsson

commit sha 3675a8781fa19a625a5787ddfa70db73ec94e6e8

Merge pull request #182 from PurpleBooth/only-pinjata Remove underscore from Pinata

view details

push time in 7 days

PR merged github/gemoji

Remove underscore from Pinata

Relates-to: github/gemoji#180

+1 -1

0 comment

1 changed file

PurpleBooth

pr closed time in 7 days

push eventkoddsson/koddsson.com

Kristján Oddsson

commit sha 0e69401d5367a146267ffab86a9f54a95e51350c

update deps

view details

Kristján Oddsson

commit sha ff3fca1359845908981b3dbe4f9d1521d1ade81f

update design a bit

view details

push time in 13 days

startedgithub/stable-socket

started time in 14 days

issue closeddgraham/delegated-events

Generic constraint instead of any on the fire function

On the fire function the last parameter is any, if that was changed to a generic you could optionally use an interface to help with type checking and the behavior should remain the same as any. Maybe there's side effects I'm not realizing, but if there aren't any is there any objection to changing the definition to something like this?

export function fire<T>(target: Document | Element, name: string, detail?: T): boolean;

Example usage:

interface ISomeEvent {
  val1: int;
  val2: string;
}

// adds type checking to the event details
fire<ISomeEvent>(target, "do:something", {
  val1: 0,
  val2: "",
});

// remains the same as `any`
fire(target, "do:something", {
  val1: 0,
  val2: "",
});

closed time in 21 days

xt0rted

push eventgithub/combobox-nav

dependabot[bot]

commit sha f4ad9bbfb15769cb18e0258c530abeecca4c9ade

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha c2c41ab428e2dcc0d0588525544a3869150acdc2

Merge pull request #28 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

PR merged github/combobox-nav

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventgithub/markdown-toolbar-element

dependabot[bot]

commit sha 3dec774b7ea71c2588e750e4adf7029756b5ce83

build(deps): bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha 167382ff0a60de058e20be49d7af2f2b685f1abf

Merge pull request #33 from github/dependabot/npm_and_yarn/lodash-4.17.19 build(deps): bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

PR merged github/markdown-toolbar-element

build(deps): bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

PR merged github/details-menu-element

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventgithub/details-menu-element

dependabot[bot]

commit sha e2e6387c1e51838fc841f5f4a5a194472d57724b

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha 73048a145256e7fabf9e0a1799125de427942ab8

Merge pull request #49 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

delete branch github/details-menu-element

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 21 days

push eventgithub/auto-complete-element

dependabot[bot]

commit sha b423b8bdbe1b25af8492ac5c777386a63ca39e81

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha 5299d49392d9d84682d47228bfe04d449edf6b8c

Merge pull request #44 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

delete branch github/auto-complete-element

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 21 days

PR merged github/auto-complete-element

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventgithub/details-dialog-element

dependabot[bot]

commit sha b4bfbaea154f594c7292a1e300622be0193ea7ba

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha d395bc80785595971ea2c2ba13ec3d0163161880

Merge pull request #60 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

delete branch github/details-dialog-element

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 21 days

PR merged github/details-dialog-element

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventgithub/clipboard-copy-element

dependabot[bot]

commit sha 1a0e7f92f760da227fc5a55a9baaa3a1952ac4da

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha c4328b565203d077354394005c1b680dbf06c9fd

Merge pull request #32 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

delete branch github/clipboard-copy-element

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 21 days

PR merged github/clipboard-copy-element

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventgithub/include-fragment-element

dependabot[bot]

commit sha 84e45bb57cecc874ebaff353e0d01cb581fa7bb2

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Kristján Oddsson

commit sha f1b0ad297d68790619d0645f3a778688e9e9440c

Merge pull request #60 from github/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 21 days

delete branch github/include-fragment-element

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 21 days

PR merged github/include-fragment-element

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

Pull request review commentgithub/hotkey

Use Array.splice instead of Array.slice & Array.concat

 export class Leaf<T> {   delete(value: T): boolean {     const index = this.children.indexOf(value)     if (index === -1) return false-    this.children = this.children.slice(0, index).concat(this.children.slice(index + 1))+    this.children.splice(index, 1)

Why this change? I'd personally not want to change this to mutate this.children. If we wanted to simplify this single line I'd like for it to be something like:

    this.children = [...this.children.slice(0, index), ...this.children.slice(index + 1))]
yuler

comment created time in 21 days

push eventkoddsson/micropub-media-endpoint

Kristján Oddsson

commit sha bcbf4cb1bd5c050125a3fc9310bd9b01190ec0ca

Serve images from the server as well.

view details

Kristján Oddsson

commit sha 2878f7860901748f586f65c624cd2c0e2c007599

npm audit fix

view details

Kristján Oddsson

commit sha b773fd3fc3c9ec95ddf2145f46086091f9e12682

Merge pull request #7 from koddsson/serve-images-from-server Serve images from server

view details

push time in 2 months

push eventkoddsson/micropub-media-endpoint

Kristján Oddsson

commit sha f177a31abae3dd0a7f6b40041009cfce5778be27

Create node.js.yml

view details

push time in 2 months

push eventkoddsson/micropub-media-endpoint

Kristján Oddsson

commit sha 2878f7860901748f586f65c624cd2c0e2c007599

npm audit fix

view details

push time in 2 months

create barnchkoddsson/micropub-media-endpoint

branch : serve-images-from-server

created branch time in 2 months

issue closedgithub/eslint-plugin-github

bin/eslint-unused-modules does not check .ts files

https://github.com/github/eslint-plugin-github/blob/master/bin/eslint-unused-modules.js

All the exports in our new TS files are currently unchecked. 😬

closed time in 2 months

muan

PR closed github/eslint-plugin-github

Add script that outputs exported functions that aren't imported

Replaces the script we removed after a migration to TypeScript. Modified from https://gist.github.com/dsherret/0bae87310ce24866ae22425af80a9864.

Fixes https://github.com/github/eslint-plugin-github/issues/89

+257 -17

2 comments

3 changed files

koddsson

pr closed time in 2 months

startedtrentmwillis/i-stand

started time in 2 months

push eventkoddsson/koddsson.com

Kristján Oddsson

commit sha d18712c851b6efd86927c27ff538d34dfd95cacf

repect $PORT variable

view details

Kristján Oddsson

commit sha d1460627bbddab4d1afef3319105b1c435c53fbb

create tables if they dont exist

view details

Kristján Oddsson

commit sha fa6f40e931cacab2bab79b1fdd909bc95e40f2f1

clean up css a bit

view details

push time in 2 months

startedskullface/protest.wtf

started time in 2 months

issue commentnadeesha/ts-prune

Doesn't handle dynamic imports

Unfortunately, the version in the gist uses APIs that yield poor performance.

If you are looking for user input then I'd take poor performance over not being able to use the app at all since I'm using dynamic imports.

The gist runs for ~16s going over ~73500 files on my local machine. I'm planning to only run it in CI so I don't mind the time it takes. I realize that might be the use case for everyone though.

turadg

comment created time in 2 months

release github/time-elements

v3.1.1

released time in 2 months

created taggithub/time-elements

tagv3.1.1

Web component extensions to the standard <time> element.

created time in 2 months

push eventgithub/time-elements

Kristján Oddsson

commit sha f4517563b726ad9002cda838181381d101587fcd

3.1.1

view details

push time in 2 months

delete branch github/time-elements

delete branch : fix-bad-mock

delete time in 2 months

push eventgithub/time-elements

Kristján Oddsson

commit sha 0e262bb8e0f9d4d0ed90818511d8b59b46761b1b

Actually mock date in time-ago tests Co-authored-by: Mu-An Chiou <me@muanchiou.com>

view details

Kristján Oddsson

commit sha dde1d80cc3d98a35f0e9e058a225dd87c54694dc

Fix one off error in broken test Co-authored-by: Mu-An Chiou <me@muanchiou.com>

view details

Kristján Oddsson

commit sha 487a0bedaff8f6dd136dbbf1d39385aa028abedd

Merge pull request #139 from github/fix-bad-mock Fix bad mock

view details

push time in 2 months

PR merged github/time-elements

Fix bad mock

In #133 I made changes that were backed up by tests. Those tests relied on a mock of Date which did not work. The tests only ran green because I made the oversight of using current dates as the freeze date. Now that some time has passed, the tests are failing on master and this was discovered by @muan in #138.

This change changes the mock to actually freeze the time and fixes a off by one error in the tests.

+20 -6

0 comment

1 changed file

koddsson

pr closed time in 2 months

PR opened github/time-elements

Fix bad mock

In #133 I made changes that were backed up by tests. Those tests relied on a mock of Date which did not work. The tests only ran green because I made the oversight of using current dates as the freeze date. Now that some time has passed, the tests are failing on master and this was discovered by @muan in #138.

This change changes the mock to actually freeze the time and fixes a off by one error in the tests.

+20 -6

0 comment

1 changed file

pr created time in 2 months

create barnchgithub/time-elements

branch : fix-bad-mock

created branch time in 2 months

delete branch koddsson/planner

delete branch : fix-terms-and-conditions-checkbox-margin

delete time in 2 months

PR opened codebar/planner

Don't wrap the input in a label element.

Before

image

After

image

+2 -1

0 comment

1 changed file

pr created time in 2 months

create barnchkoddsson/planner

branch : fix-terms-and-conditions-checkbox-margin

created branch time in 2 months

pull request commentdequelabs/axe-core

types: add `element` to NodeResults

Sorry about that. We've been working on a 4.0 release and just needed to get a bug fix out for color-contrast a bit earlier. This will be in the 4.0 release.

Ah no worries! I was just curious as when the change would land. Thanks for the explanation.

koddsson

comment created time in 2 months

fork koddsson/servest

🌾A progressive http server for Deno🌾

https://servestjs.org

fork in 2 months

pull request commentdequelabs/axe-core

types: add `element` to NodeResults

Hey @straker 👋🏻

I just noticed that v3.5.4 has been released but it doesn't include this change. At which point do commits in the develop branch end up in a release?

koddsson

comment created time in 2 months

push eventkoddsson/planner

Kristján Oddsson

commit sha e381c4445f1b30d6fbf1164c8ecb1655580a865f

Set the correct `id` and `for` attributes

view details

Kristján Oddsson

commit sha efdf2dacf71ced3102e165ac7e0425bd414409a7

Simplify donation checkbox i18n label Keys named `html` are marked as HTML safe[1]. This change pushes the HTML rendering into the i18n translation files and merges the two i18n values into one. [1]: https://guides.rubyonrails.org/v4.2/i18n.html#using-safe-html-translations

view details

Kristján Oddsson

commit sha 4dc5f7dc2f23a3fa509d06743f1d347ed0e260c2

`none` is not a valid `background-color` value

view details

Kristján Oddsson

commit sha 2009fbdc19f7ff66ba629e9c55645c085f641fdc

Wrap breadcrumb link in a span

view details

Kriszta Matyi

commit sha 52174552839eb50f6695cd1ba467a8726d11752b

Merge pull request #1342 from koddsson/small-job-new-page-fixes Some small fixes for the new job page

view details

Kristján Oddsson

commit sha b94c2b6c3e34628407f453678ce1f7a334656bb9

Merge branch 'master' into fix-relative-rsvp-date-text

view details

push time in 2 months

delete branch koddsson/planner

delete branch : small-job-new-page-fixes

delete time in 2 months

release github/eslint-plugin-github

v4.0.1

released time in 2 months

created taggithub/eslint-plugin-github

tagv4.0.1

An opinionated collection of ESLint shared configs and rules used by GitHub.

created time in 2 months

push eventgithub/eslint-plugin-github

Kristján Oddsson

commit sha d186731ea6c130b72e45105d3a73e327c1d79f45

4.0.1

view details

push time in 2 months

delete branch github/eslint-plugin-github

delete branch : dont-extend-configs-in-configs

delete time in 2 months

push eventgithub/eslint-plugin-github

Kristján Oddsson

commit sha 1fb5c57dcf4e7c38cf025ffef3329641a3f1a32d

don't extends configs in the browser and internal configs

view details

Kristján Oddsson

commit sha 9b8660b766865343a8d31b3e564765be89d6c8cf

Merge pull request #108 from github/dont-extend-configs-in-configs Don't extends configs in the browser and internal configs

view details

push time in 2 months

PR merged github/eslint-plugin-github

Don't extends configs in the browser and internal configs

It's not apparent to consumers of this plugin that when they extend the browser or internal configs they are extending the recommended config as well.

By not extending them in those configs we make the consumers denote each config they want to extend and give them the freedom to compose those configs together however they want.

This is a breaking change for consumers that have been relying on getting the recommended rules through the other configs.

+2 -4

1 comment

2 changed files

koddsson

pr closed time in 2 months

pull request commentgithub/eslint-plugin-github

Don't extends configs in the browser and internal configs

For posterity: Me and & @muan talked in slack and decided to release this as a bug fix to v4 rather than releaseing v5.

koddsson

comment created time in 2 months

PR opened codebar/planner

Some small fixes for the new job page

Some small fixes to issues I've noticed on the /jobs/new page.

e381c44

Fixes an issue where you'd click the label of one checkbox and the wrong checkbox would be toggled.

Screen Recording 2020-05-26 at 19 57 48

efdf2da

Keys named html are marked as HTML safe. This change pushes the HTML rendering into the i18n translation files and merges the two i18n values into one.

4dc5f7d

Remove CSS rule that doesn't do anything because it's invalid.

2009fbd

Before

image

After

image

+22 -25

0 comment

11 changed files

pr created time in 2 months

create barnchkoddsson/planner

branch : small-job-new-page-fixes

created branch time in 2 months

PR opened github/eslint-plugin-github

Don't extends configs in the browser and internal configs

It's not apparent to consumers of this plugin that when they extend the browser or internal configs they are extending the recommended config as well.

By not extending them in those configs we make the consumers denote each config they want to extend and give them the freedom to compose those configs together however they want.

This is a breaking change for consumers that have been relying on getting the recommended rules through the other configs.

+2 -4

0 comment

2 changed files

pr created time in 2 months

create barnchgithub/eslint-plugin-github

branch : dont-extend-configs-in-configs

created branch time in 2 months

push eventkoddsson/planner

Kristján Oddsson

commit sha fbb3d16a7f70f490079cc809bdd5b9328cc0916f

Create margin utility classes

view details

Kristján Oddsson

commit sha 0abd1299c49a8ef18f50d2c2ea58142aaa8a86eb

replace mb0 with margin-bottom-0

view details

Kristján Oddsson

commit sha 96c6e4580f9e49ac2216ca7fd27f4468ab23d245

Replace mb1 with margin-bottom-4 100px is roughly equal to 4em in the current font size so I think we can make this change without disrupting the look of the site.

view details

Kristján Oddsson

commit sha 9f184f3406df5c66b95ab4b8cb612bdb2d4d000d

Replace mt1 with margin-top-2 50px is equal to 2em in the current font size so I think we can make this change without disrupting the look of the site.

view details

Kristján Oddsson

commit sha 3cd67920dce6d486281ae8fc6df98bd63d5e2cc5

Revert back to previous utility class naming scheme

view details

Kristján Oddsson

commit sha e3c04689a84243a2d248a0c8fc1fa2dcf9fb1c7a

Add a normal margin utility class

view details

Despo Pentara

commit sha be5a44e8905dfd4c3c695859da0d5aaace5866b7

Merge pull request #1338 from koddsson/margin-utilities Margin utilities

view details

Richard

commit sha 1bef1dc26ba577d8e5ae12ed868b0f1ee6459868

Event remove unused method

view details

Richard

commit sha f464da54a2f9262d35bd147fd02fdb976882077f

Event remove unused attr_accessors publish_day and publish_time

view details

Richard

commit sha 6c75d9f50bb7b217c336b2f927d8ef6c4a3ad53c

(Refactor) Event model code arranged into blocks

view details

Richard

commit sha 84e9d35452184e0844d9368c8d5382db19c068f9

(Refactor) Prefer predicate over comparison to 0 - Rubocop error Rubocop --only=Style/NumericPredicate

view details

Richard

commit sha 770e36a46661600b3506b68042c3b7cc5b2b2960

(Fix) Event errors change student_space to student_spaces - Event form uses spaces and not spaces

view details

Richard

commit sha a864a54e7108e1f1c9ecf5894a891706a2264723

Event test validations

view details

Richard

commit sha 39757194d3ca04cf10ff8c4a4b2cd5822358417e

(Refactor) Event activerecord errors with i18n

view details

Richard

commit sha 4018c498e15538a889ebf32233be4a9fe84d3e6d

(Refactor) Simplify conditional with De Morgan's law unless coach_spaces.present? && student_spaces.present? if !(coach_spaces.present? && student_spaces.present?) if !coach_spaces.present? || !student_spaces.present? if coach_spaces.blank? || student_spaces.blank? Note: present? is !blank?

view details

Richard

commit sha a154dc596f6e95b844dff653281015aca9edff3a

Event remove legacy validation testing

view details

Despo Pentara

commit sha e71057698126a040b07224682a9a98c9788a6ed3

Merge pull request #1337 from notapatch/pr-event-test Review Event class

view details

Kristján Oddsson

commit sha ac8b3441bc46e76425fc25beae384564abffc6ee

Merge branch 'master' into fix-relative-rsvp-date-text

view details

push time in 2 months

push eventkoddsson/planner

Kristján Oddsson

commit sha def7273639ffc36a98fbe4d98451d0a5bc03056a

use margin utility class

view details

push time in 2 months

Pull request review commentcodebar/planner

Fix relative RSVP date text

         %h3           %small #{humanize_date(@workshop.date_and_time, @workshop.ends_at, with_time: true)}         - if @workshop.rsvp_opens_at-          RSVPs will open at-          = @workshop.rsvp_opens_at.strftime('%H:%M on %d/%m/%Y.')-          %br-          %br+          %div{style: "margin-bottom: 2em"}
          %div.mb2
koddsson

comment created time in 2 months

delete branch koddsson/ts-prune

delete branch : update-deps

delete time in 2 months

delete branch koddsson/planner

delete branch : margin-utilities

delete time in 2 months

PR opened codebar/planner

Margin utilities

I was gonna use a margin utility in #1335 but found the margins utilities already declared to be in a bit of disarray. This is my attempt to create margin utilities that are consistent and intuitive to use. They follow the same naming scheme as was already in place and start from 0 and go up to 5em.

Not sure if this is helpful but here's a diagram explaining the system:

.m[tbrl]*[0-5]
^^ ^^^^  ^^^^^
|| |     |
|| |     + size from 0 to 5em.
|| + denote a direction, top, bottom, right or left. omit for all directions.
|+ m for margin.
+ class selector.
+27 -16

0 comment

7 changed files

pr created time in 2 months

create barnchkoddsson/planner

branch : margin-utilities

created branch time in 2 months

pull request commentcodebar/planner

Fix relative RSVP date text

invitable is an attribute of the workshop model.

Oooh I was looking in the model and controller. I'll make sure to look in the schema next time.

koddsson

comment created time in 2 months

Pull request review commentcodebar/planner

Fix relative RSVP date text

         %h3           %small #{humanize_date(@workshop.date_and_time, @workshop.ends_at, with_time: true)}         - if @workshop.rsvp_opens_at-          RSVPs will open at-          = @workshop.rsvp_opens_at.strftime('%H:%M on %d/%m/%Y.')-          %br-          %br+          %div{style: "margin-bottom: 2em"}

Sure! I wasn't sure what to do since I thought foundation would have utility classes but I couldn't find them. Should CSS always be one-offs or do we want utility classes such as margin-bottom-2?

koddsson

comment created time in 2 months

PR opened codebar/planner

Fix relative RSVP date text

Half of #1278. Just makes sure that we say RSVPs opened at [date] when the date was in the past and RSVPs will open at [date] when the date is in the future.

I had trouble with the rest of the issue. Finding where invitable? is defined is not apparent to me but I might just not understand how this codebase is structured. I've also never seen HAML before and I got to admit that I think I prefer plain old HTML or ERB instead of it 😅

+6 -4

0 comment

1 changed file

pr created time in 2 months

create barnchkoddsson/planner

branch : fix-relative-rsvp-date-text

created branch time in 2 months

push eventkoddsson/planner

Kristján Oddsson

commit sha 15610f192d163a633cc08f6ef8ea0ce66109d509

convert coffeescript file to plain old javascript

view details

Kristján Oddsson

commit sha 689b069a652c0c93a216f36a44ee0adde27f3b92

remove coffee-rails

view details

Despo Pentara

commit sha d66bf16a6b4aee38b2fe361171c511caff795037

Merge pull request #1329 from koddsson/remove-coffee-script Remove coffee script

view details

Despo Pentara

commit sha b3c21c208ed782313b3e4e0ea18abd3f5007b7c4

Resolves production build error caused by removing coffee script ``` Uglifier::Error: Unexpected token: punc ()). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true). -- 42000 _gs('GSN-171446-A'); 42001 // Expand/collapse toggling for coach/student group subscriptions. 42002 // Used in the new user signup flow, to stop too many options being 42003 // presented. 42004 42005 /* global $ */ 42006 42007 => $(() => 42009 $(".subscriptions .toggle").click(function (e) { 42010 const $section = $(e.target).closest(".subscriptions"); 42011 const $container = $(".group-container", $section); 42012 const $icon = $(".toggle i", $section); 42013 $container.slideToggle(400, () => $container.toggleClass("collapsed")); 42014 $icon.toggleClass("fa-chevron-right fa-chevron-down"); 42015 }) 42016 ); == /tmp/build_8504ef483f907aa8cd48398d2 ```

view details

Despo Pentara

commit sha ca24d0c03cfe32ae20ae759e3b90afc3e9f54e6f

Merge pull request #1330 from despo/resolve-build-error Resolves production build error caused by removing coffee script

view details

Kristján Oddsson

commit sha c936da0dbfc33793b31e85d8408351d74495b435

Merge branch 'master' into fix-error-page-image

view details

push time in 2 months

pull request commentcodebar/planner

Include the error image on instead of hotlinking

Here's how it looks fixed

image

koddsson

comment created time in 2 months

PR opened codebar/planner

Include the error image on instead of hotlinking

Right now we are serving up the image from GitHub instead just serving it from our own of server.

This change includes the codebar-girl.gif image in the project and links to it on the error and not found pages.broken

You can see the image being broken in production by going to a non-existing url such as https://codebar.io/foobar.

image

+2 -2

0 comment

3 changed files

pr created time in 2 months

create barnchkoddsson/planner

branch : fix-error-page-image

created branch time in 2 months

pull request commentcodebar/planner

Remove coffee script

@despo Do we have the staging commands in a script somewhere? I could add a test script that would make sure something like this doesn't happen again?

koddsson

comment created time in 2 months

delete branch koddsson/planner

delete branch : remove-coffee-script

delete time in 2 months

pull request commentcodebar/planner

Remove coffee script

Doh! My bad. Glad you got it sorted.

koddsson

comment created time in 2 months

PR opened codebar/planner

Remove coffee script

As far as I can tell there was only one file written in coffeescript so I converted it to javascript and removed a whole dependency we were keeping around just for that one file 😊

+15 -14

0 comment

4 changed files

pr created time in 2 months

create barnchkoddsson/planner

branch : remove-coffee-script

created branch time in 2 months

Pull request review commentgithub/task-lists-element

TypeScript conversion

   "version": "1.0.7",   "description": "Drag and drop task list items.",   "repository": "github/task-lists-element",-  "main": "dist/index.umd.js",-  "module": "dist/index.esm.js",-  "types": "index.d.ts",+  "main": "dist/index.js",+  "module": "dist/index.js",+  "type": "module",+  "types": "dist/index.d.ts",   "scripts": {     "clean": "rm -rf dist",     "lint": "github-lint",-    "prebuild": "npm run clean && npm run lint",-    "build": "rollup -c && cp src/task-lists-element.js.flow dist/index.esm.js.flow && cp src/task-lists-element.js.flow dist/index.umd.js.flow",+    "prebuild": "npm run clean && npm run lint && tsc",

Should this have --noEmit?

    "prebuild": "npm run clean && npm run lint && tsc --noEmit",
muan

comment created time in 3 months

Pull request review commentgithub/task-lists-element

TypeScript conversion

-export default class TaskListsElement extends HTMLElement {-  disabled: boolean-  sortable: boolean-}--declare global {-  interface Window {-    TaskListsElement: typeof TaskListsElement-  }-  interface HTMLElementTagNameMap {-    'task-lists': TaskListsElement

Yup. Context is here.

muan

comment created time in 3 months

Pull request review commentgithub/clipboard-copy-element

TypeScript conversion

   ],   "license": "MIT",   "files": [-    "dist",-    "index.d.ts"+    "dist"   ],+  "prettier": "@github/prettier-config",   "devDependencies": {-    "@babel/core": "^7.6.2",-    "babel-preset-github": "^3.2.1",+    "@github/prettier-config": "0.0.4",     "chai": "^4.2.0",-    "eslint": "^6.5.1",-    "eslint-plugin-github": "^3.1.3",-    "flow-bin": "^0.111.1",-    "karma": "^4.3.0",+    "eslint": "^6.8.0",+    "eslint-plugin-github": "^3.4.1",

I think updating to 4.0.0 here would be good.

muan

comment created time in 3 months

Pull request review commentgithub/clipboard-copy-element

TypeScript conversion

   "version": "1.1.2",   "description": "Copy element text content or input values to the clipboard.",   "repository": "github/clipboard-copy-element",-  "main": "dist/index.umd.js",-  "module": "dist/index.esm.js",-  "types": "index.d.ts",+  "main": "dist/index.js",+  "type": "module",+  "module": "dist/index.js",+  "types": "dist/index.d.ts",   "scripts": {     "clean": "rm -rf dist",     "lint": "github-lint",-    "prebuild": "npm run clean && npm run lint",-    "build": "rollup -c && cp src/clipboard-copy-element.js.flow dist/index.esm.js.flow && cp src/clipboard-copy-element.js.flow dist/index.umd.js.flow",+    "prebuild": "npm run clean && npm run lint && tsc",

Do we need --noEmit here?

    "prebuild": "npm run clean && npm run lint && tsc --noEmit",
muan

comment created time in 3 months

Pull request review commentgithub/auto-check-element

TypeScript conversion

 export default class AutoCheckElement extends HTMLElement {     }   } -  static get observedAttributes(): Array<string> {+  static get observedAttributes(): string[] {     return ['required']   } -  get input(): ?HTMLInputElement {-    const input = this.querySelector('input')-    return input instanceof HTMLInputElement ? input : null+  get input(): HTMLInputElement | null {+    return this.querySelector('input')   }    get src(): string {     const src = this.getAttribute('src')     if (!src) return '' -    const link = this.ownerDocument.createElement('a')+    const link = this.ownerDocument!.createElement('a')

I just cut version 4.0.0 of eslint-plugin-github. If you update to that version, the ESLint violation here should go away.

muan

comment created time in 3 months

Pull request review commentgithub/auto-check-element

TypeScript conversion

-name: Node.js CI--on: [push]+name: Node CI +on: push jobs:   build:--    runs-on: ubuntu-latest-+    runs-on: ${{ matrix.os }}     strategy:+      fail-fast: false       matrix:-        node-version: ['*']-+        os: [ubuntu-latest, windows-latest, macos-latest]     steps:-    - uses: actions/checkout@v2

Why this change?

muan

comment created time in 3 months

Pull request review commentgithub/auto-check-element

TypeScript conversion

   "extends": [     "plugin:github/es6",     "plugin:github/browser",-    "plugin:github/flow"+    "plugin:github/typescript"   ],   "rules": {     "github/no-then": "off",     "no-invalid-this": "off"-  }+  },

Somewhat unrelated to this PR but I think we can remove this block.

muan

comment created time in 3 months

Pull request review commentgithub/auto-check-element

TypeScript conversion

   "description": "An input element that validates its value with a server endpoint.",   "repository": "github/auto-check-element",   "files": [-    "dist",-    "index.d.ts"+    "dist"   ],-  "main": "dist/index.umd.js",-  "module": "dist/index.esm.js",-  "types": "index.d.ts",+  "main": "dist/index.js",+  "module": "dist/index.js",+  "type": "module",+  "types": "dist/index.d.ts",   "scripts": {     "clean": "rm -rf dist/",     "lint": "github-lint",-    "prebuild": "npm run clean && npm run lint",-    "build": "rollup -c && cp src/index.js.flow dist/index.esm.js.flow && cp src/index.js.flow dist/index.umd.js.flow",+    "prebuild": "npm run clean && npm run lint && tsc",

Should we add --noEmit since we're using rollup to compile the builds already?

    "prebuild": "npm run clean && npm run lint && tsc --noEmit",
muan

comment created time in 3 months

more