profile
viewpoint
Gus Caplan devsnek @nodejs @tc39 @WebAssembly The Open Web https://gc.gy maker of overly complex interpreted languages | they/them

devsnek/discord-rich-presence 60

Discord RPC but only the rich presence part

devsnek/earl 7

Pure JavaScript ETF encoder/decoder

devsnek/ecma-operator-overloading 6

proposal for ecmascript operator overloading

devsnek/discord_bouncer 4

A fast and simple way to communicate with the Discord API

devsnek/benchmark 2

benchmark like a pro, wherever you go

devsnek/boop-teh-snek 2

award winning game

issue closedsindresorhus/refined-github

duplicate issue

https://github.com/sindresorhus/refined-github/pull/2831

closed time in 7 hours

devsnek

issue openedsindresorhus/refined-github

all repos show as private

My view:

From incognito mode:

created time in 7 hours

push eventdevsnek/node

Gus Caplan

commit sha 96caf979c10ec7cdf0bf3642a5d69f93c1f91c55

util: fix inspecting document.all Fixes: https://github.com/nodejs/node/issues/31889

view details

push time in 8 hours

issue commentnodejs/node

Disable __proto__

to this point, TC39 is working on getting rid of annex b and putting all the things contained within (more or less) in the main body of the spec.

mcollina

comment created time in 10 hours

startedarai-a/ecma262-compare

started time in 18 hours

startedPLSysSec/rlbox_sandboxing_api

started time in a day

push eventdevsnek/matrix-ircd

Gus Caplan

commit sha ce292f1160e0acfab70f5fd3a2f41acec0d7f30c

2

view details

push time in a day

pull request commentnodejs/node

util: fix inspecting document.all

@BridgeAR odd.. IsUndetectableObject works though, and it uses IsObject:

devsnek

comment created time in a day

issue commentnodejs/node

Disable __proto__

There are two parts to __proto__:

  • Object.prototype.__proto__
  • Object literals with __proto__

The second one is what affects JSON.parse, and can't be disabled without modifying the engine. However, it is also extremely popular for creating object literals with a null prototype, so I doubt we could disable it. I don't think the Object.prototype.__proto__ has anywhere near as much usage, but I would guess it is still a lot more than we could deal with.

mcollina

comment created time in a day

issue commenttc39/ecma262

Meta: auto-link the PR preview

prs to the html spec are automatically edited by a bot, and it works pretty nicely imo.

bakkot

comment created time in 2 days

Pull request review commenttc39/ecma262

Meta: add HTML page for pull request redirects

+<!doctype html>+<head><meta charset="utf-8">+<title>Redirecting...</title>+</head>+<body>+<h1>Redirecting...</h1>+<p>+  If you have JavaScript enabled, and you got here from a pull request to the tc39/ecma262 repository on GitHub, this page will attempt to redirect you to the appropriate snapshot rendering of the specification as of that pull request.+</p>+<p>+  If it doesn't work, you can get there yourself by clicking the "Show all checks" at the bottom of the pull request, then clicking the "details" link next to the "netlify/ecma262-snapshots/deploy-preview" check, as in <a href="https://cdn.netlify.com/f0b93f3003d5669924b6e73540bbfe07bc3d8d95/34c5d/img/blog/deploy-preview-workflow.gif">this animation</a>.+</p>+<script>+var match = /^https:\/\/github\.com\/tc39\/ecma262\/pull\/(\d+)/.exec(document.referrer);

What if we made a little script that edits the proper link into the pr description?

bakkot

comment created time in 2 days

push eventdevsnek/matrix-ircd

Gus Caplan

commit sha afe8958eb278eca6521711936d9e198402456bca

broken

view details

push time in 2 days

create barnchdevsnek/matrix-ircd

branch : master

created branch time in 2 days

created repositorydevsnek/matrix-ircd

created time in 2 days

push eventdevsnek/node

Gus Caplan

commit sha 71ca809c28c1d68d99684fb075f416254d11f0e7

util: fix inspecting document.all Fixes: https://github.com/nodejs/node/issues/31889

view details

push time in 2 days

pull request commentnodejs/node

util: fix inspecting document.all

@BridgeAR something is causing internalGetConstructorName to be called with a non-object, I wasn't really able to track it down...

devsnek

comment created time in 2 days

PR opened nodejs/node

util: fix inspecting document.all
Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+40 -3

0 comment

7 changed files

pr created time in 2 days

push eventdevsnek/node

Gus Caplan

commit sha d4c8e3c08cf9bf201ab9b1bc5d5c6858fd93dea5

util: fix inspecting document.all Fixes: https://github.com/nodejs/node/issues/31889

view details

push time in 2 days

create barnchdevsnek/node

branch : fix-htmldda

created branch time in 2 days

issue commentnodejs/node

Wrong hint message when parsing expression such as {a:1}['a'] === 1 in node

@tniessen if the code isn't valid with parens, parens are not used. the logic should more or less be: try { parse(wrap(input)); input = wrap(input); } catch {}

Killea

comment created time in 3 days

push eventdevsnek/esvu

Gus Caplan

commit sha 70835421d5199d240c423d53b601bfe9ff1315b5

enable strict arg parsing

view details

push time in 4 days

issue commentrust-lang/unsafe-code-guidelines

What about: Targets where NULL is a valid pointer

Hopefully not repeating anything, but in WASM, there are no restrictions/special behaviour around address 0. Additionally, WASM uses a Harvard architecture, so there will be a function address (or more accurately, index) 0. I believe this is handled in llvm by emitting a dummy function at the 0th index function, but it is still worth mentioning.

RalfJung

comment created time in 4 days

push eventdevsnek/node

Harshitha KP

commit sha 2d3717ad847665de333c85e5239ad4e6a4c0eb95

worker: emit runtime error on loop creation failure Instead of hard asserting throw a runtime error, that is more consumable. Fixes: https://github.com/nodejs/node/issues/31614 PR-URL: https://github.com/nodejs/node/pull/31621 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 1c4e984ed970612f129db2ba6f684311418ed3a2

test: remove common.PORT from test-net-write-callbacks.js Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rich Trott

commit sha cdac18519fd14df9ece958cf8e29b846f512656e

test: remove flaky designation for test-net-connect-options-port Closes: https://github.com/nodejs/node/issues/23207 PR-URL: https://github.com/nodejs/node/pull/31841 Fixes: https://github.com/nodejs/node/issues/23207 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 82afd85a31ab7c8f931f0bb0b23e76570aceb46d

tools: update lint-md task to lint for possessives of Node.js Add a markdown lint rule to prohibit "Node.js'" and "Node.js's". Instead, of "Node.js' module system", use "the Node.js module system". Refs: https://github.com/nodejs/node/pull/31748#issuecomment-585087745 PR-URL: https://github.com/nodejs/node/pull/31862 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ae41049a760d55b5dcc20e137a7454e7c70415c4

doc: add note about ssh key to releases PR-URL: https://github.com/nodejs/node/pull/31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cf0096104752607c7374a7f7297139e60b03c59d

tools: sync gyp code base with node-gyp repo PR-URL: https://github.com/nodejs/node/pull/30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 2f97e973ff540d2ae7de77482c631c06cc99c313

meta: move julianduque to emeritus julianduque confirmed in email that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/31863 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gus Caplan

commit sha 7c92ce88e2d6f13bd6d4b8622430ea66663bc05b

deps: V8: cherry-pick 596cf1e Original commit message: [top-level-await] fix handling termination exceptions Properly handle termination exceptions in TLA modules. Bug: v8:9978 Change-Id: Ica70a55d1f54ec89d175d7c846e9a405eaffe0a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1920750 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65135} Refs: https://github.com/v8/v8/commit/596cf1ee3e82ce66f6428fb475bb4decd7b9391b

view details

Gus Caplan

commit sha 0402973cf80a03ffbeccd38bb0f9471488935108

deps: V8: cherry-pick 854f28c Original commit message: [top-level-await] Stop throwing exceptions with TLA. Bug: v8:9970 Change-Id: I0e542fc63211e78800eab82257ccab9583305433 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946534 Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65351} Refs: https://github.com/v8/v8/commit/854f28ce1fd4a555ec21f050f12f4b67486fbf0d

view details

Gus Caplan

commit sha e4be87545add8b76e737239695449515ce049725

src: add support for TLA

view details

push time in 5 days

push eventdevsnek/esm_loader

Gus Caplan

commit sha e7495fea8b9db221d0847ae4db18dbcfd87dfabd

fix circular imports

view details

push time in 5 days

issue commentnodejs/node

Proxy's setter doesn't return on assign.

@mnini you can talk in #tc39 on freenode or on https://es.discourse.group/

mnini

comment created time in 5 days

issue commentnodejs/node

Proxy's setter doesn't return on assign.

the set proxy trap should return true or false indicating if the property was successfully set. the string you're returning is truthy.

mnini

comment created time in 5 days

push eventdevsnek/test262

Ross Kirsling

commit sha 723205bd54080bf7b84007420d59a7d513ed1819

Fix invalid YAML from #2470 and #2474.

view details

Daniel Ehrenberg

commit sha c6dd620ad3ebcd154d69535885048332cc7cbf0e

Rename FinalizationGroup to FinalizationRegistry Corresponds to https://github.com/tc39/proposal-weakrefs/pull/183 (Note, this is untested)

view details

Toru Nagashima

commit sha d2dab3510f4c03c1e8953931dfb475e3dbce2c59

Add test case for BigInt in LiteralPropertyName

view details

Toru Nagashima

commit sha 7b1a828459abc4200167d0e170049d2dbd3fbab4

add tests from #2486

view details

Toru Nagashima

commit sha eab9d3bd30160b498a0e1ba1090e624e1294a705

update tests to follow review

view details

Caio Lima

commit sha 5d5904d69a67adad5aa25336c39798c47097984e

Adding test cases to verify that 'numberingSystem' and 'calendar' options are being mapped to lower case

view details

Alexey Shvayka

commit sha b478d5fa299b95b18b4e4579b970232917844cd1

Make Array.from with iterable test more precise

view details

Alexey Shvayka

commit sha 8d4fbb4ab91057733ab0ec5937b07c0553e94d7d

Add Array.from with non-iterable test

view details

Alexey Shvayka

commit sha 61aa9951f2a7a3b1907548e4eff6cc5b32273ea2

Add Array.from non-writable property tests

view details

Alexey Shvayka

commit sha ac1c1b23c6aeccb8628646d47ae49733f91904bd

Add Array.of non-writable property test

view details

Alexey Shvayka

commit sha 1f7a0be6f5c24c10b45ed4274d9ee125ca4d5f27

Add Array#map non-configurable property test

view details

Alexey Shvayka

commit sha 10ead920246ae7a589870a525e1f15cefd1082d1

Add Array#map non-extensible test

view details

Alexey Shvayka

commit sha d842aa21af45b780384586f8a4a82e37df50b5c7

Add Array#filter non-configurable property test

view details

Alexey Shvayka

commit sha 06357bed6a0a86416a982e8fe23648f325550724

Add Array#filter non-extensible test

view details

Alexey Shvayka

commit sha b6590765f99b1cee94ba3e9f7b14ce0b1c07056b

Add Array#slice non-configurable property test

view details

Alexey Shvayka

commit sha 7c8dac120feed93d10c2996f6b04eb0809e3753c

Add Array#slice non-extensible test

view details

Alexey Shvayka

commit sha 4566372b88da52c9fed7f89bf14fd3111430e3dc

Add Array#splice non-configurable property test

view details

Alexey Shvayka

commit sha 8310766461baaf38ccd8d0b7d26fd42c77ecc90a

Add Array#splice non-extensible test

view details

Alexey Shvayka

commit sha 5faee49d36b18ee108381ff31bbe1234bd98c69f

Add Array#concat non-writable property tests

view details

Alexey Shvayka

commit sha 3fa940e7cdf94905cc8bb49b77ff35955a70d673

Add Array#concat non-configurable property tests

view details

push time in 6 days

issue commentnode-fetch/node-fetch

Discussion: http/2 support

Feel free to use this code from here too https://github.com/node-fetch/node-fetch/pull

guybedford

comment created time in 6 days

issue commentnodejs/node

`util.inspect` shouldn’t format objects with the `[[IsHTMLDDA]]` internal slot as undefined

I suppose this would matter when using electron, since you could actually do util.inspect(document.all). I can add an upstream Object::IsUndetectable and we could check it here.

ExE-Boss

comment created time in 6 days

Pull request review commentnodejs/node

vm: introduce vm.Context

 The `vm` module enables compiling and running code within V8 Virtual Machine contexts. **The `vm` module is not a security mechanism. Do not use it to run untrusted code**. -JavaScript code can be compiled and run immediately or-compiled, saved, and run later.+JavaScript code can be compiled and run immediately or compiled, saved, and run+later. -A common use case is to run the code in a different V8 Context. This means-invoked code has a different global object than the invoking code.--One can provide the context by [_contextifying_][contextified] an-object. The invoked code treats any property in the context like a-global variable. Any changes to global variables caused by the invoked-code are reflected in the context object.+A common use case is to run code within a different environment. Each context+uses a different V8 Context, meaning that it has a different global object than+the rest of the code. One can provide a context by using the [`vm.Context`][]+constructor.  ```js const vm = require('vm');  const x = 1; -const context = { x: 2 };-vm.createContext(context); // Contextify the object.+const context = new vm.Context();+context.global.x = 2;  const code = 'x += 40; var y = 17;';-// `x` and `y` are global variables in the context.-// Initially, x has the value 2 because that is the value of context.x.-vm.runInContext(code, context);+// `x` and `y` are global variables in the context environment.+// Initially, x has the value 2 because that is the value of context.global.x.+const script = new vm.Script(code);+script.runInContext(context); -console.log(context.x); // 42-console.log(context.y); // 17+console.log(context.global.x); // 42+console.log(context.global.y); // 17  console.log(x); // 1; y is not defined. ``` +## Class: `vm.Context`+<!-- YAML+added: REPLACEME+-->++> Stability: 1 - Experimental++### Constructor: `new vm.Context([options])`+<!-- YAML+added: REPLACEME+-->++* `options` {Object}+  * `name` {string} Human-readable name of the newly created context.+    **Default:** `'VM Context i'`, where `i` is an ascending numerical index of+    the created context.+  * `origin` {string} [Origin][origin] corresponding to the newly created+    context for display purposes. The origin should be formatted like a URL,+    but with only the scheme, host, and port (if necessary), like the value of+    the [`url.origin`][] property of a [`URL`][] object. Most notably, this+    string should omit the trailing slash, as that denotes a path.+    **Default:** `''`.+  * `codeGeneration` {Object}+    * `strings` {boolean} If set to false any calls to `eval` or function+      constructors (`Function`, `GeneratorFunction`, etc) will throw an+      `EvalError`. **Default:** `true`.+    * `wasm` {boolean} If set to false any attempt to compile a WebAssembly+      module will throw a `WebAssembly.CompileError`. **Default:** `true`.++Create a new VM Context. This context will have a unique global object and+variable environment.++### `context.global`+<!-- YAML+added: REPLACEME+-->++* {Object}++The global object of this context.

It's the global proxy I think? I can change the name I suppose.

I think we could even omit this API as one could easily evaluate this inside the context to get the value.

This is something that I explicitly want to not be needed.

devsnek

comment created time in 6 days

Pull request review commentnodejs/node

vm: introduce vm.Context

 The `vm` module enables compiling and running code within V8 Virtual Machine contexts. **The `vm` module is not a security mechanism. Do not use it to run untrusted code**. -JavaScript code can be compiled and run immediately or-compiled, saved, and run later.+JavaScript code can be compiled and run immediately or compiled, saved, and run+later. -A common use case is to run the code in a different V8 Context. This means-invoked code has a different global object than the invoking code.--One can provide the context by [_contextifying_][contextified] an-object. The invoked code treats any property in the context like a-global variable. Any changes to global variables caused by the invoked-code are reflected in the context object.

Originally this doc deprecated the old context apis and the new one wasn't experimental. I changed that because @joyeecheung blocked on it, but I really don't want to suggest that people continue using the current api.

devsnek

comment created time in 6 days

pull request commentnodejs/node

vm: introduce vm.Context

@TimothyGu

Can we possibly add the code-running functions as methods of the Context class? It feels more natural to type context.runCode(…) than the C-style vm.runCodeInContext(context, …)

I'm thinking the pattern would be:

const context = new vm.Context();

const script = new vm.Script(...);
script.runInContext(context);

I was considering adding a shortcut like you describe, but I didn't want to trick people into thinking

some loop {
  context.run(string);
}

was a good pattern

devsnek

comment created time in 6 days

push eventdevsnek/test262

Gus Caplan

commit sha 0f36d26daebdd2e10a82e26ee429592fe46887fe

add graaljs test runner

view details

push time in 6 days

push eventdevsnek/test262

Gus Caplan

commit sha 126c27e848e47abbe4fd6c629791e0d99b212e97

add graaljs test runner

view details

push time in 6 days

PR opened tc39/test262

switch to esvu to streamline engine installs

removes engine specific bin paths and gets rid of needing to build engine262 from scratch

+12 -25

0 comment

2 changed files

pr created time in 6 days

push eventdevsnek/test262

Gus Caplan

commit sha d51bb6ab548a7d060bedaca1998ec79c12f85724

switch to esvu to streamline engine installs

view details

push time in 6 days

push eventdevsnek/test262

Caio Lima

commit sha 04b1d2254bbd787593a5a65f9db7f7ac656de105

Added tests with invalid values for calendar and numberingSystem (#2480)

view details

Tomas Echeverri Valencia

commit sha 6d4d69f19fcb3c885fe64b344e4cc01ce667e6d9

Add missing `?` in unit test (#2477) The question mark is required as it is part of the "optional chaining operator" `?.` that's being tested here

view details

Alexey Shvayka

commit sha 963917618fc8a9cd99da1b89a7430d110cf13e21

Test that JSON.stringify calls replacer on deleted properties

view details

Natalie Silvanovich

commit sha c2e157240d9efbbcbf036d67127a9826932bcb31

Test that Typed Array internal slots are not inherited by TypedArray.prototype.buffer

view details

Natalie Silvanovich

commit sha a12677ec4c109a4df70b74c3bd52f059312ac964

Adding security tests for TypedArray.prototype.fill based on CVE-2016-4734

view details

Alexey Shvayka

commit sha 95fd012c668e5b88076a6a34e97c94ed80773855

Add isConstructor to Promise.prototype.finally test

view details

Alexey Shvayka

commit sha 1e13f2b1e7f666aad2fb3f8dd2002c8d0a256316

Add Catch Finally Functions test

view details

Alexey Shvayka

commit sha 8ce27898b919755ad46c1c82a2dca59c2ab3c0bd

Add Then Finally Functions test

view details

Alexey Shvayka

commit sha b3ec56fb8c0a201fe30ef5b7bf8edb38da692ee1

Add CreateResolvingFunctions tests

view details

Alexey Shvayka

commit sha c5b1c97362411274278c3a449f66b9cf731a2be3

Fix isConstructor checks

view details

Alexey Shvayka

commit sha 57d5ffa471831c9f6cebc13fe75f6c85e9e8acde

Fix $DONE usage

view details

Tooru Fujisawa

commit sha e75639979329ef7c8efcac0fa21fa66b01efa9bd

Add test for NumericLiteralSeparator after decimal point followed by DecimalDigit

view details

Alexey Shvayka

commit sha 946a2a3fecc80a10dd50193097d5c1d6f1d27a53

Merge "length" tests

view details

Alexey Shvayka

commit sha 72c4433687b31f2acfcd14c8e6afae6dc8472a02

Add `replaceValue` evaluation order test

view details

Caio Lima

commit sha 1337f11e21efc523c9f4728122873d185b8527ed

Adding tests to cover 'fractionalSecondDigits' on DateTimeFormat.prototype.formatRangeToParts.

view details

Caio Lima

commit sha 2e6a371f71e705f6260ad631e6f6b8b9bc72ac0f

Adding missing 'zip' function

view details

Caio Lima

commit sha 6ecaf1f065236d319c98d263b76ac025f4afda47

Adjusting separator character

view details

Ms2ger

commit sha 1f7f5ef23c0fd790b6faa1a535c9b8d05a28c58b

Change the unit in the NumberFormat unit tests. This ensures https://github.com/tc39/proposal-unified-intl-numberformat/pull/93 is covered.

view details

Natalie Silvanovich

commit sha 7ad85e90a990535befa57e96c2a4d8b8946fb1ad

Security test for TypedArray.prototype.sort based on CVE-2016-7288

view details

test262-automation

commit sha 2be08668956481f19b1e3fddbc6f975505fdd9b0

[v8-test262-automation] Updated curation log with latest revision sha's from export and changed files. sourceRevisionAtLastExport: ddf72e4b targetRevisionAtLastExport: 8d9f7690f8

view details

push time in 6 days

push eventengine262/engine262

GHA

commit sha 0d1bf78c4795b17e3d5911cc6324578a56876265

autobuild

view details

push time in 6 days

push eventdevsnek/esvu

Gus Caplan

commit sha a3c21cf02f8abdf5dbdf0307b0369eed1390ba97

version 1.0.0

view details

push time in 6 days

push eventengine262/engine262

Gus Caplan

commit sha 587a1fa64b42201eccc48280a07b36bbb4f40b7e

update test262

view details

push time in 6 days

push eventengine262/engine262

Gus Caplan

commit sha c13b620fd10dad4eed5efabf7fb380e29f25ebb2

update test262

view details

push time in 6 days

delete branch devsnek/test262

delete branch : fix-super-order-tests

delete time in 6 days

pull request commentnodejs/node

module: prevent builtins from resolving from disk

@guybedford they'll have to rename to process-browser, like they should've done from the start.

devsnek

comment created time in 6 days

pull request commentnodejs/node

module: prevent builtins from resolving from disk

???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????

devsnek

comment created time in 6 days

pull request commentnodejs/node

module: prevent builtins from resolving from disk

@guybedford that's why its semver major right?

devsnek

comment created time in 6 days

pull request commentnodejs/node

module: prevent builtins from resolving from disk

So it looks like webpack/browserify are testing something by creating a file in process/browser.js? And then there's this thing: https://github.com/webpack/node-libs-browser/blob/master/index.js, which tries to resolve with a trailing slash. Should we try to support that?

devsnek

comment created time in 6 days

pull request commentnodejs/node

src: combine internal file read utils

is there some specific problem you have with braces? It seems they're prevalent in our source, and we don't have a lint against them, so I'm not sure why I wouldn't be able to use them.

devsnek

comment created time in 6 days

issue closednodejs/node

Proposal: Implament dynamic import from urls via fetch include relativ path support

<!-- Thank you for suggesting an idea to make Node.js better.

Please fill in as much of the template below as you're able. -->

Is your feature request related to a problem? Please describe. I want to host my own files on my own server and import them via https including relative path support without resolving the dependency tree myself. at present I have coded a userland ESM loader using the data: URL string argument syntax with dynamic import() the dataUrl syntax already supports Node Resolve Algorithm but NOT Relative paths as the dataUrl has no knowledge where it comes from

so I would need to fetch the URL to get the string representation to replace relative URLs with the right location and then load that and loop over all dependencies that are relative.

Describe the solution you'd like Implement nativ support for relative module resolution when using import. and even better Implement the whole feature import('https://myscript') and I would love when file:// is also supported in the same fashion maybe I need to split that over many proposals what do you think?

deno at present is using parcel a JSBundler for that to fetch resources and evaluate complete dependency tree upfront execution and evaluation.

so I propose to add that ability to the loader itself it should remember on call via a URL the origin location and handle relative module resolution like it would do it local

Describe alternatives you've considered as described at the problem section I have experimented with my userland loader https://github.com/direktspeed/esm-loader and adding module resolution via rollup, for example, would solve the problem but that can be maybe better implemented inside node itself

closed time in 7 days

frank-dspeed

issue commentnodejs/node

Proposal: Implament https://www.w3.org/DOM/

this seems better left to browsers. also, w3 dom was replaced with the whatwg html spec.

frank-dspeed

comment created time in 7 days

push eventengine262/engine262

GHA

commit sha 1deb7060bcfd210b169c17e0461a1efaa51ffbae

autobuild

view details

push time in 7 days

push eventengine262/engine262

Gus Caplan

commit sha 67bef1a3b2474a580e88199484fb860aa503fcb6

implement weakmap and weakset

view details

Gus Caplan

commit sha 8473db60c4202a16ddaed8dc8aeb2908e1cf0d30

remove codecov

view details

Gus Caplan

commit sha ad63dc7c94007e6148d0400426ceded1ae06b3fd

experimental branch

view details

Gus Caplan

commit sha 6207366360848a904c35e958257c98b1ec943f79

repl experiment 2.0

view details

push time in 7 days

push eventengine262/engine262

Gus Caplan

commit sha 8473db60c4202a16ddaed8dc8aeb2908e1cf0d30

remove codecov

view details

push time in 7 days

issue commentnodejs/node

Clear the internal require `statCache` on an unsuccessful module load?

I think in a really general sense, these caches shouldn't be updated for failure cases (obviously easier to say than implement, but I think that's what we should aim for)

benjamingr

comment created time in 7 days

push eventengine262/engine262

GHA

commit sha e55456afe2b34ac32f7a5841c9cfe477f215225b

autobuild

view details

push time in 7 days

issue commentnodejs/modules

import.meta.main

@tschaub that would appear to have some bugs involving process.argv[1] not being present (repl) and returning true when i assume you would want it to return false (argv[1] is a, a.x is loaded, you call that from a.y and it returns true).

MylesBorins

comment created time in 7 days

pull request commentnodejs/node

src: combine internal file read utils

@bnoordhuis i don't think we really have a style one way or the other (if we wanted to, we should add a lint). The problem i have with braceless is that if braces eventually need to be added for multiple statements it shows an extra two lines of change in the diff.

devsnek

comment created time in 7 days

push eventengine262/engine262

Gus Caplan

commit sha 67bef1a3b2474a580e88199484fb860aa503fcb6

implement weakmap and weakset

view details

push time in 7 days

issue commentnodejs/modules

import.meta.main

@bmeck right, i mean the semantics of handling that main.

MylesBorins

comment created time in 7 days

issue commentnodejs/modules

import.meta.main

@bmeck probably something to discuss on the esm proposal instead? We'd want all the different js environments that support wasi to do it uniformly.

MylesBorins

comment created time in 7 days

issue commentnodejs/modules

import.meta.main

module === require.main is a fine pattern for commonjs, but esm is not commonjs. I don't think we need to feel forced to find a solution. It should be expected that migrating to a new system involves making changes that are more than a single line of code.

MylesBorins

comment created time in 7 days

pull request commentnodejs/node

doc: add esm alternative for require.main

You could also add the suggestion of splitting the bin and library into separate files.

tschaub

comment created time in 7 days

issue openedtc39/test262

%FinalizationGroupCleanupIteratorPrototype%.next missing coverage

After a full test262 run I'm seeing this result: https://coveralls.io/builds/28806730/source?filename=src/intrinsics/FinalizationGroupCleanupIteratorPrototype.mjs. engine262 does support weakrefs and finalization (https://engine262.js.org/#gist=02d22b8813a762e53b839f7f2d2ba84d) so I don't think it's a problem there. I realize there are tests in test262 which do call next(), so I'm concerned there might be issues with those tests.

created time in 7 days

pull request commentnodejs/node

src: combine internal file read utils

@bnoordhuis i'd rather not do braceless if it isn't too much of a problem.

devsnek

comment created time in 7 days

push eventdevsnek/node

Gus Caplan

commit sha 4d164080754d5504da1747cf40091ff91e40294e

src: combine internal file read utils

view details

push time in 7 days

issue commentnodejs/modules

Invalidate cache when using import

These all sound like use cases for V8's LiveEdit debug api. You can call into it using https://nodejs.org/api/inspector.html.

jonathantneal

comment created time in 7 days

issue commentnodejs/node

Async generator: catched error on last yield is wrongly rethrown

@nlepage Would you mind opening a bug here: https://bugs.chromium.org/p/v8/issues/list

nlepage

comment created time in 7 days

push eventdevsnek/node

Matheus Marchini

commit sha cf5624c4d8f16397c6d12aaf13bcc3ecfe10b8fe

test: add promises metadata to postmortem test type_JSPromise__JS_PROMISE_TYPE and type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to identify Promises in memory and core dumps: https://github.com/nodejs/llnode/pull/272. Add these to our postmortem test so we're aware of any changes to this metadata. PR-URL: https://github.com/nodejs/node/pull/31357 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha e43ee3712fd21710d6da07c4b7892fd1aa84d5e9

doc: explain `hex` encoding in Buffer API fixes: https://github.com/nodejs/node/issues/29786 refs: https://github.com/nodejs/node/pull/29792 refs: https://github.com/nodejs/node/issues/24491 PR-URL: https://github.com/nodejs/node/pull/31352 Fixes: https://github.com/nodejs/node/issues/29786 Refs: https://github.com/nodejs/node/pull/29792 Refs: https://github.com/nodejs/node/issues/24491 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 12ff6164985979505c97a07de224ccfa0aea6119

deps,test: update to uvwasi 0.0.4 This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 87ffc6e4a422d54194d8825da95694382b8bbcd0

deps: port uvwasi@676ba9a to gyp This commit ports https://github.com/cjihrig/uvwasi/commit/676ba9a from CMake to gyp. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha d43e94548253e49769126c62c59fc40e2993583f

deps: uvwasi: cherry-pick 941bedf Original commit message: https://github.com/cjihrig/uvwasi/commit/20fd9e2 was accidentally reverted in https://github.com/cjihrig/uvwasi/pull/73. This commit relands it. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 3199996de3cfd08b01a674dbe6c2b5522a183dbb

doc: correct added version for --abort-on-uncaught-exception PR-URL: https://github.com/nodejs/node/pull/31360 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

himself65

commit sha e588ed7391fb2a92b3936e0011d6fbe0df903fc2

doc: fix a broken link in fs.md PR-URL: https://github.com/nodejs/node/pull/31373 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 7b78ff04283e735d421d7dce4433969c5a71e2e8

stream: support passing generator functions into pipeline() PR-URL: https://github.com/nodejs/node/pull/31223 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ben Noordhuis

commit sha cc0748f509140b7b42d157348300a5581db98a37

test: export public symbols in addons tests Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: https://github.com/nodejs/node/pull/28647 Refs: https://github.com/nodejs/node-gyp/pull/1828 PR-URL: https://github.com/nodejs/node/pull/28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha 7864c53629b11d69746a4fc1f041900eeb358d31

fs: unset FileHandle fd after close - Do not set the fd as a property on the native object. - Use the already-existent `GetFD()` method to pass the fd from C++ to JS. - Cache the fd in JS to avoid repeated accesses to the C++ getter. - Set the fd to `-1` after close, thus reliably making subsequent calls using the `FileHandle` return `EBADF`. Fixes: https://github.com/nodejs/node/issues/31361 PR-URL: https://github.com/nodejs/node/pull/31389 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Matheus Marchini

commit sha b3189266347fa05395860f9f6e8949e447977284

test: update postmortem test with v12 constants Ref: https://github.com/nodejs/llnode/pull/330 PR-URL: https://github.com/nodejs/node/pull/31391 Refs: https://github.com/nodejs/llnode/pull/330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gabriel Schulhof

commit sha 85592e281802f82c8e4b211a8e280b481fd65388

src: reduce large pages code duplication Declaring and initializing a `struct text_region` is common to all three implementations of the large pages mapping code. Let's make it unconditional. PR-URL: https://github.com/nodejs/node/pull/31385 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

cjihrig

commit sha 57bd715d527aba8dae56b975056961b0e429e91e

doc: fix several child_process doc typos PR-URL: https://github.com/nodejs/node/pull/31393 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha 7d5a86cc05f3b8782b37c7ed438b3e994f6bd713

fs: do not emit 'close' twice if emitClose enabled fs streams have some backwards compat behavior that does not behave well if emitClose: true is passed in options. This fixes this edge case until the backwards compat is removed. PR-URL: https://github.com/nodejs/node/pull/31383 Fixes: https://github.com/nodejs/node/issues/31366 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 4f11fb6410728f5b026ea4b9b29775622dc4f849

test: add wasi test for symlink() and readlink() This test provides missing coverage for __wasi_path_symlink() and __wasi_path_readlink(). PR-URL: https://github.com/nodejs/node/pull/31403 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha 343ddffc1c025e444f28dbb0ccfefc23815479d3

doc: document process.std*.fd Fixes: https://github.com/nodejs/node/issues/28386 Refs: https://github.com/nodejs/node/pull/31292 Refs: https://github.com/nodejs/help/issues/2136 PR-URL: https://github.com/nodejs/node/pull/31395 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Guy Bedford

commit sha c2c3274631fe50b7e7e8949f453e01a38f5a3695

module: fix check exports issue in cjs module loading Refs: https://github.com/nodejs/node/pull/31001#issuecomment-576353389 PR-URL: https://github.com/nodejs/node/pull/31427 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha dcba12895ad58275ba5b027c2c5110461dfebf66

test,module: add test for exports cjs loader check Refs: https://github.com/nodejs/node/pull/31001#issuecomment-576353389 PR-URL: https://github.com/nodejs/node/pull/31427 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha f0d2df41f8716670435b284e987b2fcc23221947

fs: change streams to always emit close by default Previously due to compat reasons 'close' was only emitted if no 'error'. This removes the compat behavior in order to properly follow expected streams behavior. PR-URL: https://github.com/nodejs/node/pull/31408 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha c9e386c00fd5b1269426975d4b0f4533f66ce089

crypto: add key type 'dh' The new key type 'dh' corresponds to EVP_PKEY_DH. PR-URL: https://github.com/nodejs/node/pull/31178 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

push time in 8 days

delete branch nodejs/node

delete branch : v12.16.1-proposal

delete time in 8 days

delete branch nodejs/node

delete branch : v13.9.0-proposal

delete time in 8 days

delete branch nodejs/node

delete branch : v8.17.0-proposal

delete time in 8 days

delete branch nodejs/node

delete branch : v12.14.0-proposal

delete time in 8 days

delete branch nodejs/node

delete branch : v10.18.0-proposal

delete time in 8 days

push eventdevsnek/node

Gus Caplan

commit sha 8eae86a969e1c6930ea1a41ee77bb4e72179750a

module: add --unsafe-builtin-resolution option

view details

push time in 8 days

pull request commenttc39/ecma262

Normative: Prevent DFS invariants from being broken

Test: https://github.com/tc39/test262/pull/2506

devsnek

comment created time in 8 days

push eventdevsnek/test262

Gus Caplan

commit sha d3bc3a65df5682a7f9cc2d20a50c304b09ddd4a7

add dfs tests for https://github.com/tc39/ecma262/pull/1669

view details

push time in 8 days

PR opened tc39/test262

add dfs tests for https://github.com/tc39/ecma262/pull/1669
+32 -0

0 comment

3 changed files

pr created time in 8 days

create barnchdevsnek/test262

branch : ugh

created branch time in 8 days

delete branch devsnek/jsvu

delete branch : engine262

delete time in 8 days

PR closed GoogleChromeLabs/jsvu

Add support for engine262 cla: yes

Refs #75

+167 -2

0 comment

9 changed files

devsnek

pr closed time in 8 days

delete branch nodejs/node

delete branch : fixup-collaborator-list

delete time in 8 days

delete branch nodejs/node

delete branch : auto-version

delete time in 8 days

pull request commentnodejs/node

fs: add fs/promises alias module

@ljharb master is already v14.0.0-pre

devsnek

comment created time in 8 days

push eventdevsnek/node

Gus Caplan

commit sha 393cc5b7e89da6aaedaa221f8866a4dae7ed9080

module: add --unsafe-builtin-resolution option

view details

push time in 8 days

push eventdevsnek/node

Tobias Nießen

commit sha a17131400360562f06fc4d1c217ee60f7c5928aa

n-api: rename 'promise' parameter to 'value' This change makes it clear that the value doesn't need to be a Promise, and makes the signature consistent with other napi_is_* functions. PR-URL: https://github.com/nodejs/node/pull/31544 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gus Caplan

commit sha 43fb6ffef7a14b47d1b0ba8134102795f5017a59

build: enable loading internal modules from disk PR-URL: https://github.com/nodejs/node/pull/31321 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

bcoe

commit sha 13fe56bbbbc290cbc16804994ce0ec1d25729775

fs: return first folder made by mkdir recursive mkdir('/foo/bar', { recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: https://github.com/nodejs/node/pull/31530 Refs: https://github.com/nodejs/node/issues/31481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha 25c3f7c61a167c152c10afda68a2d39161179e77

test: remove --experimental-worker flag comment worker is stable in the master branch. The flag is no longer required. PR-URL: https://github.com/nodejs/node/pull/31563 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Lumish

commit sha 470511ae781f152ac53a192c7bb0f395c972d200

doc: add protocol option in http2.connect() This option is used here: https://github.com/nodejs/node/blob/70c32a6d190e2b5d7b9ff9d5b6a459d14e8b7d59/lib/internal/http2/core.js#L3010 PR-URL: https://github.com/nodejs/node/pull/31560 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Perrotte

commit sha 54c1a09202e68517d826104bad3e8e787d358197

deps: upgrade npm to 6.13.7 PR-URL: https://github.com/nodejs/node/pull/31558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha be6596352b2a1b8648dc266b5be81b6a1be180d6

doc: clarify require() OS independence PR-URL: https://github.com/nodejs/node/pull/31571 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 023ecbccc8b1e492234e769894fde2967d4a5677

src: remove preview for heap dump utilities At least `createHeapSnapshotStream()` and `triggerHeapSnapshot()` do have side effects, and more importantly, they should not be run transparently. Without this, typing e.g. `v8.getHeapSnapshot()` into the REPL will result in a crash or infinite loop while the REPL evaluates the expression for a preview. PR-URL: https://github.com/nodejs/node/pull/31570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ConorDavenport

commit sha d10927b687858224558dbe0f10f5c57b4139ad96

build: ignore all the "Debug","Release" folders Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: https://github.com/nodejs/node/pull/27210 PR-URL: https://github.com/nodejs/node/pull/31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Dylan Coakley

commit sha cb210110e9c7e4b8d7c64af4a45d4b1e7d429a0e

test: verify threadId in reports PR-URL: https://github.com/nodejs/node/pull/31556 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha ab9e89439e8f8699efe6c7786d5a3ba9be2a16a6

benchmark: add MessagePort benchmark Add a raw `MessagePort` benchmark that does not ping back and forth between different threads, unlike the `echo.js` benchmark, as there are some performance differences between single-threaded and multi- threaded operation, and a single-threaded Environment can be somewhat easier to work with when profiling. PR-URL: https://github.com/nodejs/node/pull/31568 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 22724894c99845755dfdafc2a87236fc311343f1

doc: list largepage values in --help This commit adds the supported --use-largepages values to the --help menu. PR-URL: https://github.com/nodejs/node/pull/31537 Fixes: https://github.com/nodejs/node/issues/31533 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rusty Conover

commit sha 0fe810168bef2a53e5ff6b2f7832e372f850e5f3

doc: clarify socket.setNoDelay() explanation Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: https://github.com/nodejs/node/pull/31541 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Steffen

commit sha d80c40047bedbf829bc1854a720b40e63bdb76fc

doc: fix numbering PR-URL: https://github.com/nodejs/node/pull/31575 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ben Noordhuis

commit sha 938abd9535663d45a8ec88d5fa6acc0af8e8fd13

src: use __executable_start for linux hugepages `__executable_start` is provided by GNU's and LLVM's default linker scripts, obviating the need to plug in a custom linker script. The problem with our bespoke linker script is that it works with ld.bfd but not ld.gold and cannot easily be ported because the latter linker doesn't understand the `INSERT BEFORE` directive. The /proc/self/maps scanner is updated to account for the fact that there are a number of sections between `&__executable_start` and the start of the .text section. Fortunately, those sections are all mapped into the same memory segment so we only need to look at the next line to find the start of our text segment. Fixes: https://github.com/nodejs/node/issues/31520 PR-URL: https://github.com/nodejs/node/pull/31547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 06deb94714ddb5e18a803c517e9272a8fe657995

test: fix flaky test-memory-usage abe6a2e3d1c268f introduced a test that verifies that ArrayBuffer allocations are tracked. However, V8 supports concurrent freeing of such allocations on background threads, meaning that the results may be subject to race conditions sometimes. Disabling concurrent freeing makes the test pass consistently. Refs: https://github.com/nodejs/node/pull/31550 PR-URL: https://github.com/nodejs/node/pull/31602 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 9528f953360c34a75b3a89839e71884908c2fe6e

test: mark additional tests as flaky on Windows Basically, any of the tests that failed in the runs for https://github.com/nodejs/node/pull/31602 which was not already marked as flaky. PR-URL: https://github.com/nodejs/node/pull/31606 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Ben Noordhuis

commit sha dbe881b64ce74f437ace5c6a884dfac5df597df2

test: show child stderr output in largepages test The test starts child processes. A recent change is suspected of causing flaky crashes on one of the alpine buildbots but we can't know for sure because the test hides the child's stderr. Refs: https://github.com/nodejs/node/pull/31547#issuecomment-581076515 PR-URL: https://github.com/nodejs/node/pull/31612 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Denys Otrishko

commit sha aec9ad8f6c8a75518d81279ec5e7188348e508de

src: fix console debug output on Windows The FWrite function on Windows assumed that MultiByteToWideChar automatically null-terminates the resulting string, but it will only do so if the size of the source was passed as -1 or null character was explicitly counted in the size. The FWrite uses std::string and its `.size()` method which doesn't count the null character even though the `.data()` method adds it to the resulting string. https://docs.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar#remarks > MultiByteToWideChar does not null-terminate an output string if the input string length is explicitly specified without a terminating null character. To null-terminate an output string for this function, the application should pass in -1 or explicitly count the terminating null character for the input string. PR-URL: https://github.com/nodejs/node/pull/31580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ConorDavenport

commit sha 99c8c6d80ff97ac7d53e01722142ac37756aabf1

src: remove duplicate field env in CryptoJob class Removed field env from cryptojob class, replaced with function env() inherited from ThreadPoolWork PR-URL: https://github.com/nodejs/node/pull/31554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 8 days

pull request commentnodejs/node

fs: add fs/promises alias module

landed in b8e41774d428

devsnek

comment created time in 8 days

delete branch devsnek/node

delete branch : restore-fs-slash-promises

delete time in 8 days

PR merged nodejs/node

Reviewers
fs: add fs/promises alias module fs semver-major

This restores fs/promises in node core. It can't be overridden by a file on disk in a version of node that has it. It will fail to load on a version of node that doesn't have it because the fs module on npm is locked. It is not a new core module, it is a child of the fs module, so the concern about namespacing shouldn't apply.

Fixes #21014

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
+16 -1

23 comments

5 changed files

devsnek

pr closed time in 8 days

issue closednodejs/node

Can’t import fs Promises API with ECMAScript Modules

  • Version: v10.2.1
  • Platform: Windows 10 64-bit
  • Subsystem: fs

Per the docs, “The API is accessible via require('fs').promises.”

When using ECMAScript Modules it can’t be accessed like that. One may expect to be able to load it with import {promises as fs} from 'fs', but this gives an error.

import {promises as fs} from 'fs'
        ^^^^^^^^
SyntaxError: The requested module 'fs' does not provide an export named 'promises'
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:89:21)

So right now accessing the fs Promises API directly when using ECMAScript Modules requires two lines, like so:

import {default as fsWithCallbacks} from 'fs'
const fs = fsWithCallbacks.promises

closed time in 8 days

dieulot

push eventnodejs/node

Gus Caplan

commit sha b8e41774d4287d128a40f7ecfecf170fe16fe9ed

fs: add fs/promises alias module PR-URL: https://github.com/nodejs/node/pull/31553 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

view details

push time in 8 days

push eventdevsnek/node

Richard Lau

commit sha d4c81be4a0035b2d96cd62ae3a846d4435d941e6

doc: update job reference in COLLABORATOR_GUIDE.md https://ci.nodejs.org/job/node-test-commit-custom-suites/ is disabled in Jenkins with a note to instead use https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/. Update the guide to remove the layer of indirection. PR-URL: https://github.com/nodejs/node/pull/31557 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

aaccttrr

commit sha 9225939528590f652e6ee1ccf73e709b029d4ca5

worker: remove redundant closing of child port PR-URL: https://github.com/nodejs/node/pull/31555 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha abe6a2e3d1c268f5bebbf05864f2588c6f4858b5

process: report ArrayBuffer memory in `memoryUsage()` Report memory allocations performed by the `ArrayBuffer::Allocator`. PR-URL: https://github.com/nodejs/node/pull/31550 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha dd4c62eabe1f5cf982137d9d826aac162a611d26

doc: clarify that `v8.serialize()` is not deterministic Fixes: https://github.com/nodejs/help/issues/2448 PR-URL: https://github.com/nodejs/node/pull/31548 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Tobias Nießen

commit sha a17131400360562f06fc4d1c217ee60f7c5928aa

n-api: rename 'promise' parameter to 'value' This change makes it clear that the value doesn't need to be a Promise, and makes the signature consistent with other napi_is_* functions. PR-URL: https://github.com/nodejs/node/pull/31544 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gus Caplan

commit sha 43fb6ffef7a14b47d1b0ba8134102795f5017a59

build: enable loading internal modules from disk PR-URL: https://github.com/nodejs/node/pull/31321 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

bcoe

commit sha 13fe56bbbbc290cbc16804994ce0ec1d25729775

fs: return first folder made by mkdir recursive mkdir('/foo/bar', { recursive: true }) and mkdirSync will now return the path of the first folder created. This matches more closely mkdirp's behavior, and is useful for setting folder permissions. PR-URL: https://github.com/nodejs/node/pull/31530 Refs: https://github.com/nodejs/node/issues/31481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha 25c3f7c61a167c152c10afda68a2d39161179e77

test: remove --experimental-worker flag comment worker is stable in the master branch. The flag is no longer required. PR-URL: https://github.com/nodejs/node/pull/31563 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Lumish

commit sha 470511ae781f152ac53a192c7bb0f395c972d200

doc: add protocol option in http2.connect() This option is used here: https://github.com/nodejs/node/blob/70c32a6d190e2b5d7b9ff9d5b6a459d14e8b7d59/lib/internal/http2/core.js#L3010 PR-URL: https://github.com/nodejs/node/pull/31560 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Michael Perrotte

commit sha 54c1a09202e68517d826104bad3e8e787d358197

deps: upgrade npm to 6.13.7 PR-URL: https://github.com/nodejs/node/pull/31558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha be6596352b2a1b8648dc266b5be81b6a1be180d6

doc: clarify require() OS independence PR-URL: https://github.com/nodejs/node/pull/31571 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 023ecbccc8b1e492234e769894fde2967d4a5677

src: remove preview for heap dump utilities At least `createHeapSnapshotStream()` and `triggerHeapSnapshot()` do have side effects, and more importantly, they should not be run transparently. Without this, typing e.g. `v8.getHeapSnapshot()` into the REPL will result in a crash or infinite loop while the REPL evaluates the expression for a preview. PR-URL: https://github.com/nodejs/node/pull/31570 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ConorDavenport

commit sha d10927b687858224558dbe0f10f5c57b4139ad96

build: ignore all the "Debug","Release" folders Since there're still many "Debug" and "Release" folders in "deps" and "tools", to make it more strict and totally ignore the generated obj files, ignore all the files/folders under them. Refs: https://github.com/nodejs/node/pull/27210 PR-URL: https://github.com/nodejs/node/pull/31565 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Dylan Coakley

commit sha cb210110e9c7e4b8d7c64af4a45d4b1e7d429a0e

test: verify threadId in reports PR-URL: https://github.com/nodejs/node/pull/31556 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha ab9e89439e8f8699efe6c7786d5a3ba9be2a16a6

benchmark: add MessagePort benchmark Add a raw `MessagePort` benchmark that does not ping back and forth between different threads, unlike the `echo.js` benchmark, as there are some performance differences between single-threaded and multi- threaded operation, and a single-threaded Environment can be somewhat easier to work with when profiling. PR-URL: https://github.com/nodejs/node/pull/31568 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 22724894c99845755dfdafc2a87236fc311343f1

doc: list largepage values in --help This commit adds the supported --use-largepages values to the --help menu. PR-URL: https://github.com/nodejs/node/pull/31537 Fixes: https://github.com/nodejs/node/issues/31533 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rusty Conover

commit sha 0fe810168bef2a53e5ff6b2f7832e372f850e5f3

doc: clarify socket.setNoDelay() explanation Change the description of socket.setNoDelay() to make it clear that sockets have Nagle's algorithm enabled by default. Better document the tradeoff of having the algorithm enabled. Explain the behavior of the function based on the passed arguments. PR-URL: https://github.com/nodejs/node/pull/31541 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Steffen

commit sha d80c40047bedbf829bc1854a720b40e63bdb76fc

doc: fix numbering PR-URL: https://github.com/nodejs/node/pull/31575 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ben Noordhuis

commit sha 938abd9535663d45a8ec88d5fa6acc0af8e8fd13

src: use __executable_start for linux hugepages `__executable_start` is provided by GNU's and LLVM's default linker scripts, obviating the need to plug in a custom linker script. The problem with our bespoke linker script is that it works with ld.bfd but not ld.gold and cannot easily be ported because the latter linker doesn't understand the `INSERT BEFORE` directive. The /proc/self/maps scanner is updated to account for the fact that there are a number of sections between `&__executable_start` and the start of the .text section. Fortunately, those sections are all mapped into the same memory segment so we only need to look at the next line to find the start of our text segment. Fixes: https://github.com/nodejs/node/issues/31520 PR-URL: https://github.com/nodejs/node/pull/31547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 06deb94714ddb5e18a803c517e9272a8fe657995

test: fix flaky test-memory-usage abe6a2e3d1c268f introduced a test that verifies that ArrayBuffer allocations are tracked. However, V8 supports concurrent freeing of such allocations on background threads, meaning that the results may be subject to race conditions sometimes. Disabling concurrent freeing makes the test pass consistently. Refs: https://github.com/nodejs/node/pull/31550 PR-URL: https://github.com/nodejs/node/pull/31602 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 8 days

issue commenttc39/ecma262

Question about level of formalism of spec

@lazdmx There is no descriptor to call it on. The information about the property exists in an implementation defined structure. OrdinaryGetOwnProperty gets the property, then builds a descriptor (Let D be a newly created Property Descriptor with no fields.) from that abstract information.

lazdmx

comment created time in 8 days

issue commenttc39/ecma262

Question about level of formalism of spec

In this case, O.[[GetOwnProperty]] == OrdinaryGetOwnProperty. OrdinaryGetOwnProperty is the actual implementation of [[GetOwnProperty]] for ordinary objects. The spec doesn't define data structure used for ordinary objects, so it has to stay kind of abstract.

lazdmx

comment created time in 8 days

push eventengine262/engine262

Gus Caplan

commit sha fe5c49d858df245fe760a37e8780cc3810a26d2a

implement weakrefs again

view details

Gus Caplan

commit sha 3554637b70429c866f1dc960114916fbf59e4780

experimental branch

view details

Gus Caplan

commit sha 7a5c11546ffbc4f250f6cc5e9db07b069d03e241

repl experiment 2.0

view details

push time in 8 days

pull request commentnodejs/node

process: add .stillSynchronous

I still don't understand the motivation for this feature.

ChALkeR

comment created time in 8 days

issue commenttc39/proposal-weakrefs

Finalization group iterator vs Array

Iterator that copies the elements is a good idea, I'd be okay with that as well.

littledan

comment created time in 8 days

push eventdevsnek/node

Gus Caplan

commit sha 6f017b73345c27196884340a9d55030af6a06adf

src: combine internal file read utils

view details

push time in 8 days

push eventengine262/engine262

GHA

commit sha b33366e8d6c0ffda795f14c7fe95c74638402a17

autobuild

view details

push time in 8 days

push eventengine262/engine262

Gus Caplan

commit sha fe5c49d858df245fe760a37e8780cc3810a26d2a

implement weakrefs again

view details

push time in 8 days

Pull request review commenttc39/test262

fix super evaluation order tests

 var reachable = 0; class C extends null {

this test exists to test extending null, the other one is for the generic "not a constructor" case.

devsnek

comment created time in 8 days

more