profile
viewpoint

cjihrig/uvwasi 67

WASI syscall API built atop libuv

danbev/learning-cpp 3

Personal project for learning c++11

danbev/learning-knative 1

Notes and examples for learning knative

danbev/centos7-s2i-nodejs 0

OpenShift S2I builder images for Node.js

push eventdanbev/learning-cpp

Daniel Bevenius

commit sha 5b82233c758e30bf9f2865751eb5027b6941a3fb

doc: add preprocessor notes

view details

push time in 5 hours

push eventdanbev/vim-settings

Daniel Bevenius

commit sha d8461c3c7d9ed2d814cc3caf6e62eb4386e3725c

doc: add redo section

view details

push time in 10 hours

PR closed nodejs/node

src: ignore maybe-uninitialized warning string_search C++ buffer

Currently, the following compilation warning is generated with GCC version 8.2.1:

In file included from ../src/node_buffer.cc:29:
../src/string_search.h:
In function ‘size_t node::stringsearch::SearchString(
    node::stringsearch::Vector<const Char>,
    node::stringsearch::Vector<const Char>,
    size_t) [with Char = short unsigned int]’:
../src/string_search.h:113:30: warning:
‘search’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
     return (this->*strategy_)(subject, index);
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

../src/string_search.h:
In function ‘size_t node::stringsearch::SearchString(
    node::stringsearch::Vector<const Char>,
    node::stringsearch::Vector<const Char>,
    size_t) [with Char = unsigned char]’:
../src/string_search.h:113:30:
warning: ‘search’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
     return (this->*strategy_)(subject, index);
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

The issue here seems to be with the strategy_ field which is a pointer to a member function, and it is set in the constructor of StringSearch. It is always set and I've not been able to work around this warning so this commit suggests adding a pragma for GCC to ignore the warning.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

2 comments

1 changed file

danbev

pr closed time in a day

pull request commentnodejs/node

src: ignore maybe-uninitialized warning string_search

Closing in favor of #31809

danbev

comment created time in a day

push eventdanbev/learning-c

Daniel Bevenius

commit sha b83800892724282ebf55ad0d819b7e88718fdb7d

doc: add static lib section

view details

push time in 2 days

push eventdanbev/vim-settings

Daniel Bevenius

commit sha e486c508084b2ad574c6dd51a4ad816e5fe3f71e

doc: add ',' note to search forward command

view details

push time in 2 days

push eventdanbev/vim-settings

Daniel Bevenius

commit sha ee5e0d90aeda6238578368b2e2d3f4e7a277fd7b

doc: add f command repeat note

view details

push time in 2 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha e14a5fda39aec5d16f486b37a46325a4d8f0a4c1

src: add multiple inputs example

view details

push time in 3 days

push eventdanbev/demo

Daniel Bevenius

commit sha 7cea20430081dd3a203ecd66b133d60a70cb6117

squash: fix rustfmt issue

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha e723b467b0edfa2c61b57c33346ace7e3320ee68

build: use published faas-wasm-runtime

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 7bce40baf849504e938cec322e6b813937daa2f6

build: update Carge.lock

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 6329f04fc01159d4a5d2bc4b172cc10a460501ba

build: update Cargo.lock

view details

push time in 4 days

push eventdanbev/demo

axel simon

commit sha 9bd982420434d632168025731df2bbdabb8e1430

make each header also a link

view details

Daniel Bevenius

commit sha b01f3dd77737022657dc6d45f02f32a3b139343c

wasmtime-basic: print i32 value instead of vec This commit is just a suggestion to change the output from the current vector to just the i32 value. For example, currently the following is displayed: Finished. Results: Output: [ I32( 12, ), ] Done. With the changes in this commit this output would be: Finished. Results: Output: 12: i32 Done.

view details

Connor Kuehl

commit sha 3211e7067c11cde67663573252d13e444f75e8b5

Point readers to the SEV demo video They will also find instructions on how to build and run the demo on the linked wiki page.

view details

Daniel Bevenius

commit sha f4cf9fa53d46d00a8274f05f4b0ed6b7580209b8

wasmtime-basic: update to wasmtime 0.11.0 This commit updates the wasmtime-basic demo to use wasmtime 0.11.0.

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 9593254b61d47b34cb083ea905f07438f55ea505

build: update faas-wasm-runtime name

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 3a340152f4efcab4f3d54fc4cd6fe6620d7fa5d2

build: remove unneeded deps

view details

push time in 4 days

PR opened enarx/demo

wasmtime-basic: update to wasmtime 0.11.0

This commit updates the wasmtime-basic demo to use wasmtime 0.11.0.

+484 -147

0 comment

3 changed files

pr created time in 4 days

create barnchdanbev/demo

branch : wasmtime-0.11.0-update

created branch time in 4 days

push eventdanbev/learning-rust

Daniel Bevenius

commit sha 79d218c0c54824da585dd7cb729fafa426b71065

doc: add building rustc from source notes

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 424755e4c1fcffc800859ba6237c912559f88e52

build: add keywords and readme to Cargo.toml

view details

push time in 4 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 11d0a7809cafedbfd06093d048fb8a4bdce011bb

src: update to use wasmtime 0.11.0

view details

push time in 5 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha f8a360daf9b3c3e98b4fd085e485e515697decb6

src: update to wasmtime 0.11.0 This commit updates the code base to use wasmtime 0.11.0 api. Currently this is a suboptimal solution but it works and I'll refactor it shortly.

view details

Daniel Bevenius

commit sha 817840e3c26dbf597ef9bc5946f830b390995d19

src: create module only once

view details

Daniel Bevenius

commit sha db19eb47721abbe2006f780a16283870db92f5f4

src: move the module creation to outside of WasmExecutor Currently, the module is compiled for each request which is not good.

view details

push time in 5 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha dd9a4fab840b355faac2b89cf1b40b80c0e2c6f4

build,doc: cleanup before publishing

view details

push time in 5 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha 55f3d0f69ddf28a24c6689d2d5ea004ac95dd58b

doc: add BINDGEN_EXTRA_CLANG_ARGS note

view details

push time in 5 days

issue openednodejs/build

Add Universal Base Image (UBI) build to CI system

Description

This issue purposes adding a build for Universal Base Image (UBI) 8.1, which is based on RHEL, to the CI system.

Motivation

The motivation for doing this is that UBI 8.1 contains a system OpenSSL version that has FIPS support and this build would be configured to dynamically link to that OpenSSL version. This would allow us to exercise the FIPS code path which is currently not done. This is not something that happens often but there has been one occasion where code was committed to master which failed to compiler when fips was enabled: https://github.com/nodejs/node/commit/17d87d522c674362a4769d20c05cb0f1daf10e7f

Docker build instructions

$ docker pull registry.access.redhat.com/ubi8:8.1
$ docker run --ipc=host -ti registry.access.redhat.com/ubi8:8.1 /bin/bash
$ yum install -y git gcc-c++ which make python3 openssl-devel procps-ng
$ git clone https://github.com/nodejs/node.git
$ cd node
$ update-crypto-policies --set LEGACY
$ export OPENSSL_ENABLE_MD5_VERIFY=true
$ ./configure --openssl-system-ca-path=/etc/pki/tls/certs/ca-bundle.crt --shared-openssl --openssl-is-fips
$ make -j8 test

Currently there is one test failure which is covered by https://github.com/nodejs/node/pull/31715

created time in 5 days

pull request commentnodejs/node

test: add secp224k1 check in crypto-dh-stateless

LGTM, but wouldn't it be easier to switch to a different curve that's available on all systems?

I did not think about changing the curve as I thought that was something that was being tested specifically. I don't think we can know which curves will be available on all systems and they might change over time. Even ones that exist now might be removed later. I'm not saying either way is better and I'm happy as long as the test does not fail for us.

Kind of related to this is that I'm going to open an issue in the build working group suggesting we add UBI 8.1 (Universal Base Image which is based on RHEL) build to the CI system which would dynamically link to the system OpenSSL. This would allow us to test FIPS which is not done at the moment but also find issues like this one early. I'll link this issue to it.

danbev

comment created time in 5 days

push eventdanbev/learning-quantum-computing

Daniel Bevenius

commit sha 1b163233429e4b44e6b5b378a72a9da6c7bd53d4

doc: fix typos

view details

push time in 6 days

push eventdanbev/learning-quantum-computing

Daniel Bevenius

commit sha 2ffa16b1f788ea7cb6e937c0677ba31f65fb6c06

doc: clarify phi and theta limits

view details

push time in 6 days

push eventdanbev/learning-quantum-computing

Daniel Bevenius

commit sha 3751cb9ea5b9c5fd4e11d6d832f298eb5b33e1f0

doc: fix various code snippet errors

view details

push time in 6 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha adfd4b27b8cd2d8fa68a1a72a62106fe0301fd26

src: add a very basic inline assembly example

view details

push time in 6 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 944cc99a5153dd6aa3642e6bced2844b73201347

doc: add minikube installation note

view details

push time in 6 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha a9139054221c29df2119206ea56de3e2d87ca2e7

doc: add __wasm_call_ctors notes

view details

push time in 6 days

push eventdanbev/learning-quantum-computing

Daniel Bevenius

commit sha 0dc8939cb59c7550f4c5cbe4161a87615c96f8f7

doc minor cleanup/clarification of braket notes

view details

push time in 6 days

push eventdanbev/vim-settings

Daniel Bevenius

commit sha 58f4717c289246f112dbcc0bffbe2be1ee44b31a

doc: add path configuration example

view details

push time in 7 days

push eventdanbev/learning-linux-kernel

Daniel Bevenius

commit sha 93011ed11ccc4d3c5cc5548de9d9917ff437d415

doc: fix c run time (crt) section

view details

push time in 7 days

pull request commentdanbev/learning-libcrypto

doc: fix link

@wataash Thanks, and sorry about the delay on merging this.

wataash

comment created time in 7 days

push eventdanbev/learning-libcrypto

Wataru Ashihara

commit sha 6edf55ffe68b9151e0942bc756d61a5772891f8e

doc: fix link

view details

push time in 7 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha 2a0c82c29bc5afcd352d5086cee1510a557e345a

doc: misc notes about building wasi-libc

view details

push time in 7 days

push eventdanbev/node

Daniel Bevenius

commit sha 9adaeb9cb5d676b5cf66bc6448b6ae25971cf96d

Revert "test: add shared_openssl check crypto-dh-stateless" This reverts commit e53501a80d2c6a9ef39115b42f2d6a55b0313597.

view details

Daniel Bevenius

commit sha 9fa3759e948aaf87d6cc62b415d1c1e84367f1fe

test: add secp224k1 check in crypto-dh-stateless This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl. The use case for this was building on RHEL 8.1 which only has the following curves: $ openssl ecparam -list_curves secp224r1 : NIST/SECG curve over a 224 bit prime field secp256k1 : SECG curve over a 256 bit prime field secp384r1 : NIST/SECG curve over a 384 bit prime field secp521r1 : NIST/SECG curve over a 521 bit prime field prime256v1: X9.62/SECG curve over a 256 bit prime field

view details

push time in 7 days

Pull request review commentnodejs/node

test: add shared_openssl check crypto-dh-stateless

 for (const [params1, params2] of [ test(crypto.generateKeyPairSync('ec', { namedCurve: 'secp256k1' }),      crypto.generateKeyPairSync('ec', { namedCurve: 'secp256k1' })); -assert.throws(() => {-  test(crypto.generateKeyPairSync('ec', { namedCurve: 'secp256k1' }),-       crypto.generateKeyPairSync('ec', { namedCurve: 'secp224k1' }));-}, {-  name: 'Error',-  code: 'ERR_OSSL_EVP_DIFFERENT_PARAMETERS'-});+if (!process.config.variables.node_shared_openssl) {+  assert.throws(() => {+    test(crypto.generateKeyPairSync('ec', { namedCurve: 'secp256k1' }),+         crypto.generateKeyPairSync('ec', { namedCurve: 'secp224k1' }));+  }, {+    name: 'Error',+    code: 'ERR_OSSL_EVP_DIFFERENT_PARAMETERS'+  });+}

Being linked against a shared copy of openssl doesn't have to mean the curve is unsupported.

My reasoning was that we know that the statically linked OpenSSL has this curve, but I'm happy to go with feature-detection like you suggested. Thanks.

danbev

comment created time in 7 days

PR opened nodejs/node

test: add shared_openssl check crypto-dh-stateless

This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl.

The use case for this was building on RHEL 8.1 which only has the following curves:

$ openssl ecparam -list_curves
secp224r1 : NIST/SECG curve over a 224 bit prime field
secp256k1 : SECG curve over a 256 bit prime field
secp384r1 : NIST/SECG curve over a 384 bit prime field
secp521r1 : NIST/SECG curve over a 521 bit prime field
prime256v1: X9.62/SECG curve over a 256 bit prime field
Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+9 -7

0 comment

1 changed file

pr created time in 8 days

push eventdanbev/node

Daniel Bevenius

commit sha e53501a80d2c6a9ef39115b42f2d6a55b0313597

test: add shared_openssl check crypto-dh-stateless This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl. The use case for this was building on RHEL 8.1 which only has the following curves: $ openssl ecparam -list_curves secp224r1 : NIST/SECG curve over a 224 bit prime field secp256k1 : SECG curve over a 256 bit prime field secp384r1 : NIST/SECG curve over a 384 bit prime field secp521r1 : NIST/SECG curve over a 521 bit prime field prime256v1: X9.62/SECG curve over a 256 bit prime field

view details

push time in 8 days

create barnchdanbev/node

branch : shared_openssl_check-test-crypto-dh-stateless

created branch time in 8 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha 9a61fc5616870751e6997d0f7c781efe5b336180

doc: add compiler-rt note

view details

push time in 10 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha 375ffd1867ab643325d53f2b23d03ed45882b717

doc: add compiler-rt section

view details

push time in 11 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha 2decb7750272a222f0eb1d7434d2603947c20bd4

doc: add instructions for building compiler-rt

view details

push time in 11 days

PR opened CraneStation/wasi-libc

Correct minor typo in c_headers.rs

The header api.h was update using the following command:

$ cd tools/wasi-headers
$ cargo run -- WASI/phases/snapshot/witx/typenames.witx \
  WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx \
  --output ../../libc-bottom-half/headers/public/wasi/api.h
+2 -2

0 comment

2 changed files

pr created time in 11 days

push eventdanbev/wasi-libc

Daniel Bevenius

commit sha f14e7a58f20fd1ca6d0c73bbf12f7c0e6eb25adc

Correct minor typo in c_headers.rs The header api.h was update using the following command: $ cd tools/wasi-headers $ cargo run -- WASI/phases/snapshot/witx/typenames.witx \ WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx \ --output ../../libc-bottom-half/headers/public/wasi/api.h

view details

push time in 11 days

create barnchdanbev/wasi-libc

branch : c_headers_typo

created branch time in 11 days

fork danbev/wasi-libc

WASI libc implementation for WebAssembly

https://wasi.dev

fork in 11 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha a0ea2053d30229f3e705d7b6c8c6bf80feb6d518

src,doc: add notes and example of compiling c to wasm

view details

push time in 11 days

push eventdanbev/learning-wasi

Daniel Bevenius

commit sha ad61603a438aae4b3614f62f62e596e3aac6148b

doc: add sysroot and musl notes

view details

push time in 12 days

Pull request review commentnodejs/node

test: add WASI test for file resizing

+#include <sys/stat.h>+#include <assert.h>+#include <fcntl.h>+#include <unistd.h>+#include <stdio.h>

Nit: I don't think this include is being used?

cjihrig

comment created time in 12 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha 7dc08f4c16945c1be92ee84f83365f492ed68762

doc: add rsp alignment note

view details

push time in 12 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha 6517dfbd20ed15c32d6011b376707b7db7296799

doc: add call frame information notes

view details

push time in 12 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 690ac75f91bf3e07f714b0dc6bc57fce30039904

src: add package.json and cloudevents-sdk dep

view details

push time in 13 days

PR opened openshift-cloud-functions/faas-js-runtime

src: add constants for cloudevent headers

This commit adds constants for the HTTP headers that are used for cloud events.

+31 -19

0 comment

3 changed files

pr created time in 13 days

create barnchdanbev/faas-js-runtime

branch : ce-specversion-const

created branch time in 13 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 0a2648895b567bc5dfbff8e6f48126c2fe593c9a

src: clean up use statements

view details

push time in 13 days

push eventdanbev/learning-linux-kernel

Daniel Bevenius

commit sha bbb68f75b6ffb4eb7e7ee1071f29406e47a72e9d

src: clarify __libc_start_main

view details

push time in 13 days

push eventdanbev/learning-linux-kernel

Daniel Bevenius

commit sha 1d499041418229597434f604f2b717bae5df8cfa

doc: minor clean up

view details

push time in 13 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha cbf2ec519455600b00e0122d27d6d86af180a90c

src: remove explicit type for args

view details

push time in 13 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha c6f9ef79d038f04a95085d7cc29f9138e186e53b

src: add WasmResponse type

view details

push time in 13 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 21eff61cbb23f0c1e557c6df47a46f43a161fdfa

src: update to use WasmResponse type

view details

push time in 13 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 85337ef526944f01b4600a45383d2b1f2985be28

src: minor simplification of create_response This function should be made indepedent of wasmtime_jit at some point and functionality to set headers and return code.

view details

push time in 14 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 78474a2a3f9955b17b1455d2e366c206b6215dae

src: remove commented out derive Debug

view details

push time in 14 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 0951e7493f0c1636eb8ab4cc7fd3f401635c5a2d

src: add context argument to extract/response functions

view details

push time in 14 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha a27829eefe0de14ca2fa662832b6cfafcb05c38c

src: add function_name and module path to context

view details

push time in 14 days

PR closed nodejs/node

src: remove unused `Worker::child_port_` member C++ author ready worker

This fixes a compiler warning introduced in 9225939528590f652e6.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+5 -16

4 comments

2 changed files

addaleax

pr closed time in 14 days

pull request commentnodejs/node

src: remove unused `Worker::child_port_` member

Landed in 60de60a0ce21378c80353489759dc70f05156cc7.

addaleax

comment created time in 14 days

push eventnodejs/node

Anna Henningsen

commit sha 60de60a0ce21378c80353489759dc70f05156cc7

src: remove unused `Worker::child_port_` member This fixes a compiler warning introduced in 9225939528590f652e6. PR-URL: https://github.com/nodejs/node/pull/31599 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 14 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha 586208ce233c8dc7142b4fb59f67f50a3cca1d39

doc: add note about environment and prog name

view details

push time in 14 days

push eventdanbev/node

Daniel Bevenius

commit sha 1b3454d428c2001d6915fe1a08303dd0ef8c3e30

Revert "src: ignore maybe-uninitialized warning string_search" This reverts commit b520c74dfd3cd164549dd89ec020dbdc662d9589.

view details

Daniel Bevenius

commit sha b1269abf1a05287347fe09212edc08ee8a8f6be5

src: ignore maybe-uninitialized warning string_search Currently, the following compilation warning is generated with GCC version 8.2.1: In file included from ../src/node_buffer.cc:29: ../src/string_search.h: In function ‘size_t node::stringsearch::SearchString( node::stringsearch::Vector<const Char>, node::stringsearch::Vector<const Char>, size_t) [with Char = short unsigned int]’: ../src/string_search.h:113:30: warning: ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized] return (this->*strategy_)(subject, index); ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ ../src/string_search.h: In function ‘size_t node::stringsearch::SearchString( node::stringsearch::Vector<const Char>, node::stringsearch::Vector<const Char>, size_t) [with Char = unsigned char]’: ../src/string_search.h:113:30: warning: ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized] return (this->*strategy_)(subject, index); ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ I'm not sure why this works but delegating to the default constructor of the base class StringSearchBase makes this warning go away.

view details

push time in 15 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha fc825dfdf0523b7127aa040151e3e54df29239f9

src: use closures instead of create functions

view details

push time in 15 days

push eventdanbev/faas-wasi-runtime-example

Daniel Bevenius

commit sha 8f9010108b4e15fb92ffdc865e36e094e1559eed

src: add Dockerfile for building a container image

view details

Daniel Bevenius

commit sha 3826482c1b0d864b987fc5f8aa94c4113f8c02dd

doc: add docker build instructions

view details

push time in 15 days

create barnchdanbev/faas-wasi-runtime-example

branch : master

created branch time in 15 days

created repositorydanbev/faas-wasi-runtime-example

Function as a service WASI runtime example

created time in 15 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 916687f122279a58428b8a5cd504f6c76b6d6967

src: remove module directory

view details

push time in 15 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 2bdbb7b2969edfbf83b8c4480a854353cedc88a9

src: remove main.rs This commit removes main.rs. This will be placed in an example instead to show that the goal of this project is to be a library and an end user would include as a dependency.

view details

Daniel Bevenius

commit sha 8cf28d45dd054116e0b7661b54f1c6a111f97427

src: add rustfmt changes

view details

push time in 15 days

Pull request review commentnodejs/node

src: ignore maybe-uninitialized warning string_search

 class StringSearch : private StringSearchBase {   }    size_t Search(Vector subject, size_t index) {+#if (__GNUC__ >= 8) && !defined(__clang__)+#pragma GCC diagnostic push+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"+#endif     return (this->*strategy_)(subject, index);+#if (__GNUC__ >= 8) && !defined(__clang__)+#pragma GCC diagnostic pop+#endif

@lundibundi Thanks, I'll try to take a closer look at this again this week.

danbev

comment created time in 15 days

pull request commentnodejs/node

src: remove unused `Worker::child_port_` member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4127/

addaleax

comment created time in 15 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha 8f1804a46f6d6534cb2d32e6304b25f9104ccbb7

doc: add gdb section

view details

Daniel Bevenius

commit sha ad61d8ca67d0daee27705d00dfd54c45a6aa0672

doc: replace load with r (run) for make note

view details

push time in 16 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha acb0710b949137eeed1608e90b897375ed456d98

src: add simple jnz example

view details

push time in 16 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha 82b416a8458795b74166a410811dda1383bbd087

doc: add initial stackover flow notes

view details

push time in 17 days

push eventdanbev/learning-assembly

Daniel Bevenius

commit sha d8bdbed0c1fe325791d62269d08fb13b63412ee8

doc: more plt notes

view details

push time in 18 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 5508ec5b959cc14cd6222268ca66c6361a2d3a34

doc: change title

view details

push time in 18 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha bbdd35afaa5a100e8bd9339fcd5e1214afc43d0c

src,doc: add js- prefix to faas-js-example yamls

view details

push time in 18 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha f6c7aad7b76a4558f525932865daccc93958aebf

doc: add an overview of components involved

view details

push time in 18 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 4fc26f2d9ebf490ce825738b21e909adc8e4f9cb

doc: add note about image size

view details

push time in 19 days

delete branch danbev/node

delete branch : das-gc

delete time in 19 days

PR closed nodejs/node

src: fix minor typo in base_object.h C++ author ready
Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+1 -1

2 comments

1 changed file

danbev

pr closed time in 19 days

pull request commentnodejs/node

src: fix minor typo in base_object.h

Landed in d227d22bd9653f201e182efb76f2a5fe6a93f955.

danbev

comment created time in 19 days

push eventnodejs/node

Daniel Bevenius

commit sha d227d22bd9653f201e182efb76f2a5fe6a93f955

src: fix minor typo in base_object.h PR-URL: https://github.com/nodejs/node/pull/31535 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 19 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha e669c31def6475d59d89b7c2b772640607edd2af

build: add wasm/wasi base image This commit adds a base image for the build so that we don't have to fetch and compile all dependencies when we compile the users code.

view details

Daniel Bevenius

commit sha 1f17985c050a3b921c6bef5679ca67b591108cc0

src: add POST method support

view details

push time in 19 days

push eventdanbev/faas-wasi-runtime-image

Daniel Bevenius

commit sha 293f6cd8d3f56a77a919e79d4b13508717ffef06

src: remove commented out code

view details

push time in 19 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 52c1ec74767fd0cfa3e06c270a0551f5a80057d4

src: initial knative example This commit is a work in progress and the goal is to be able to show how the Node.js runtime is intended to be used by end users.

view details

push time in 19 days

pull request commentnodejs/node

src: fix minor typo in base_object.h

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4125/

danbev

comment created time in 19 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha a2619d0c845ef6ac004c39ae9672c70dedf3e271

src: initial knative example This commit is a work in progress and the goal is to be able to show how the Node.js runtime is intended to be used by end users.

view details

push time in 19 days

push eventdanbev/faas-js-runtime-image

Daniel Bevenius

commit sha 01eea75fbf071fa7e559f8d9fe19882429c913cf

doc: use branch for faas-wasi-runtime-image

view details

push time in 19 days

create barnchdanbev/faas-wasi-runtime-image

branch : faas-wasm-example

created branch time in 19 days

more