profile
viewpoint
Christian Oliff coliff 01000001 01001100 01001011 00001101 00001010 00001101 00001010 London, UK ✈️ Osaka, JP https://christianoliff.com @trimble-oss @h5bp @htmlhint @gohugoio

coliff/bootstrap-ie7 577

Bootstrap 3 CSS for IE7

coliff/bootstrap-ie8 280

Bootstrap 4 for IE8 and IE9

caniuse-email/caniuse.email 141

HTML and CSS Compatibility tables for emails

coliff/bootstrap-ie11 74

Internet Explorer 11 compatibility solution for Bootstrap 5

coliff/awesome-website-testing-tools 26

Resource of web-based testing and validation tools

coliff/bootstrap-show-password-toggle 20

A show password as text toggle for Bootstrap forms

coliff/bootstrap-print-css 16

Print Stylesheet for Bootstrap 5

coliff/bootstrap-rfs 13

Easy-to-add CSS for adding Responsive Font Sizes (RFS) to Bootstrap 4

coliff/Brackets-CSSCodeHints 5

Extends Bracket's CSS code hints with more attributes; clip-path, image-rendering, tab-size, touch-action and more

coliff/bootstrap-checkout 1

Bootstrap Checkout Example with UX improvements

issue commentfiduswriter/Simple-DataTables

How to add custom CSS classes to pagination

Answering my own question, I added this code for now, but keen to know if there is a better way:

document.addEventListener("DOMContentLoaded", function () {
  const ul = document.querySelector(".dataTable-pagination-list");
  ul.className = "pagination";

  var pageItem = document.querySelectorAll(".dataTable-pagination > ul > li");
  for (var i = 0; i < pageItem.length; i++) {
    pageItem[i].classList.add("page-item");
  }

  var pageLink = document.querySelectorAll(".dataTable-pagination > ul > li > a");
  for (var i = 0; i < pageLink.length; i++) {
    pageLink[i].classList.add("page-link");
  }
});
coliff

comment created time in 14 hours

issue openedfiduswriter/Simple-DataTables

How to add custom css classes to pagination

I'd like to use Simple-DataTables with Bootstrap 5 CSS without rewriting any CSS classes. Is it possible to add CSS class names to the existing classes at run-time?

https://getbootstrap.com/docs/5.1/components/pagination/

For Bootstrap's pagination that'd mean adding the class pagination to dataTable-pagination-list and then page-item to each li and page-link to each a.

created time in 16 hours

issue commentfiduswriter/Simple-DataTables

Unable to initialize DataTable due to multiple JS errors

The error states 'Failed to resolve module specifier "simple-datatables". Relative references must start with either "/", "./", or "../".' so you need to use:

import { DataTable } from "./simple-datatables";
ToastedGuy2

comment created time in 16 hours

PR opened fiduswriter/Simple-DataTables

no need to specify types in example on README

These are not needed

+2 -2

0 comment

1 changed file

pr created time in 17 hours

push eventcoliff/Simple-DataTables

Christian Oliff

commit sha 9ac82f69d429bf64d59d5cc420e87214211e53dd

no need to specify types in example on README These are not needed

view details

push time in 17 hours

fork coliff/Simple-DataTables

DataTables but in Vanilla ES2018 JS

fork in 17 hours

startedfiduswriter/Simple-DataTables

started time in 17 hours

PullRequestReviewEvent

delete branch gohugoio/hugoDocs

delete branch : disqus-example-name

delete time in 20 hours

PR opened gohugoio/hugoDocs

Reviewers
fix disqus example name

changes discuss to disqus and use dashes to separate words to make it easier to read.

+1 -1

0 comment

1 changed file

pr created time in 20 hours

create barnchgohugoio/hugoDocs

branch : disqus-example-name

created branch time in 20 hours

PullRequestReviewEvent

PR opened paulirish/lite-youtube-embed

Add Prettier script and config

This changes spacing from 4 to 2. The actual code is near identical other than line lengths being a bit shorter in JS (could be modified in the prettier config if you want?). For the CSS a leading zero was adding to filter .1s (line 58) and one instance of double-quotes was changed to single quotes (line 31). A .gitignore file was added (needed to ignore node_modules).

+202 -155

0 comment

7 changed files

pr created time in a day

create barnchcoliff/lite-youtube-embed

branch : dev/coliff/prettier-config

created branch time in a day

PullRequestReviewEvent

push eventcoliff/lite-youtube-embed

Christian Oliff

commit sha c19a938c3f82993fcd4ed91b80df612bfeae1887

remove version="1.1" from SVG (not needed) (#99) saves a few bytes

view details

Christian Oliff

commit sha fd051685402111168e5995251de71e54cdd385f7

Update Lighthouse CI and Node (#98)

view details

Lee Hanbury

commit sha cff0e53f8c3bbc64fbb3f602b0f77cb70343c1de

Fix duplicate iframes being created (#97) Co-authored-by: Paul Irish <commits@paul.irish>

view details

Paul Irish

commit sha 1b051e4839d762084edb1ac0c7dc1f809f8686f6

lockfile bump

view details

Paul Irish

commit sha 80ed06e68d1057614a608c13e038900dd83013ff

update play button svg to match current YT inline svg. should not have any visual difference

view details

Karl Horky

commit sha 6842b8686f2ec68d667fe2e544067f9dc0c9acde

Add kylemocode/react-lite-yt-embed (#71)

view details

Ibrahim Cesar

commit sha d2353dc04a05e76ad30314782fa6a1085785942b

add React component port (#83)

view details

Paul Irish

commit sha 7730f941f173121fbf8a12099d53cb768377cb25

iframeEl reference

view details

Paul Irish

commit sha 754490bda43bbabdd7bf3e33ff5eb2a22209b3c3

fixup links to other facade projects

view details

Paul Irish

commit sha 9346290a7f732b89279d1ea6c064b54fbf46e742

remove poster image preload (#106)

view details

Christian Oliff

commit sha 79f21eafa44c52eea39ee0d47e186cbd380fa72b

Add `.editorconfig` (#107)

view details

push time in a day

PR opened paulirish/lite-youtube-embed

Add dependabot.yml

help keep dependencies up-to-date - updates npm and GitHub Actions. I set update interval to monthly so you're not bothered every week, but feel free to adjust of course.

+11 -0

0 comment

1 changed file

pr created time in a day

push eventcoliff/lite-youtube-embed

Christian Oliff

commit sha 799ca845c50e6718895aa3708970a13608328c15

Add dependabot.yml help keep dependencies up-to-date - updates npm and github actions.

view details

push time in a day

issue commentpaulirish/lite-youtube-embed

Add eslint and stylelint configs / script

Great. I’m a fan of Prettier too, I’ll open a PR later today.

coliff

comment created time in a day

delete branch coliff/lite-youtube-embed

delete branch : patch-1

delete time in a day

issue openedpaulirish/lite-youtube-embed

Add eslint and stylelint configs / script

I think it'd be good to add a .stylelintrc and a eslintrc.json to the projects root and add lint-js and lint-css tasks to package.json. We can use the recommended/standard configs for both. what do you think? I'd be happy to add a PR for this...

created time in 2 days

push eventcoliff/freshdesk-messaging-facade

Christian Oliff

commit sha 9450dcb24ea7fbe5f8fa0e6c9e879ce773fbc21d

Create codeql-analysis.yml

view details

push time in 2 days

pull request commentpaulirish/lite-youtube-embed

remove preload mention in comment since it's not used

maybe this can be re-opened and merged now. :-)

coliff

comment created time in 2 days

PR opened paulirish/lite-youtube-embed

Add `.editorconfig`

Add an .editorconfig to help ensure consistent code-formatting for contributors.

+13 -0

0 comment

1 changed file

pr created time in 2 days

push eventcoliff/lite-youtube-embed

Christian Oliff

commit sha a57290e93b504f5a49566beccb709750f735bcbb

Create .editorconfig Add an `.editorconfig` to help ensure consistent code-formatting for contributors.

view details

push time in 2 days

push eventcoliff/freshdesk-messaging-facade

Christian Oliff

commit sha 3c3d26adff3c7771c9c680a2808f182e7823729b

update dev deps

view details

Christian Oliff

commit sha 2dfa343327cc80baa89c37824e4f05ed6dfbcd04

Merge pull request #10 from coliff/dev/coliff/dev-deps-update update dev deps

view details

push time in 2 days

delete branch coliff/freshdesk-messaging-facade

delete branch : dev/coliff/dev-deps-update

delete time in 2 days

create barnchcoliff/freshdesk-messaging-facade

branch : dev/coliff/dev-deps-update

created branch time in 2 days

more