caub ( Cyril Auburtin )

commit sha bb4b8288632c8f722fdbb93b447e50e4f2985758

Add singleQuoteReplacement option

commit sha 6146cac7edaead00ff446241320489a77c8ee582

8.3.0

Some way to exclude files ?

push time in 3 days

issue commentcaub/pg-tsquery

"it's" changing to "its"

Hi, oh good point, I think recently we had to do this https://github.com/caub/pg-tsquery/blob/master/index.js#L220 where we replace single quotes by an empty string

We could make the replacement configurable m.groups.word.replace(/'/g, this.singleQuoteReplacer || '') or something

If you have a bit more time that I, maybe make a PR with quicks tests

soheilpro

comment created time in 17 days

issue commentexpressjs/serve-static

Hey, you can use index: false if want to ignore index.html file

technically setting index: false still serves the index.html file, it just avoid serving it for a request on the basedir

index: true:
GET / → 200
GET /index.html → 200

index: false:
GET / → 404
GET /index.html → 200

LeoIannacone

comment created time in a month

startedgliese1337/fast-myers-diff

started time in 2 months

startedreact-bootstrap/react-bootstrap

started time in 2 months

issue closedgliese1337/fast-myers-diff

Explain in README the output of calcPatch

For example:

> [...d.calcPatch('foo!!', 'fo1o')]
[ [ 2, 2, '1', 3 ], [ 3, 5, '', 4 ] ]

I guess [2, 2, '1', 3] is between 2nd and 2nd char of initial value (remove nothing), insert '1', (what is 3?)

then [ 3, 5, '', 4 ] is between 3rd and 5th, insert '' (so remove '!!'), there again what is 4?

Thanks for your project

closed time in 2 months

caub

issue commentReactTraining/react-router

[v6] Link with absolute path doesn't respect basename

I don't know yet if I like this change, bascially if I've a route with a link to another route

with react-router@5 you'd just:

<BrowserRouter basename="/app">
  <Switch>
    <Route path="/foo" exact render={() => <>foo! <Link to="/bar"></Link></>}>
    <Route path="/bar" exact render={()=>'bar!'} />
</BrowserRouter>

and the link to "/bar" would translate to "/app/bar" as expected

now with react-router@6 do you need to do?

<BrowserRouter>
  <Route path="/foo" element={<>foo! <Link to="../bar"></Link></>}>
  <Route path="/bar" element={'bar!'} />
</BrowserRouter>

where you need to play with relative path all the way

morhekil

comment created time in 2 months

pull request commentbrigand/jellobot

[v6] Link with absolute path doesn't respect basename

beautiful @brigand :+1:

caub

comment created time in 2 months

issue commentReactTraining/react-router

Confirmed, I was going to file an issue then noticed this one

https://codesandbox.io/s/peaceful-euclid-6t4nl?file=/src/App.js

What's the best workaround?

morhekil

comment created time in 2 months

pull request commentbrigand/jellobot

ok good point, string splitting has this capacity anyway

[..."👨🏿‍🦳"]
// (4) ["👨", "🏿", "‍", "🦳"]

caub

comment created time in 2 months

pull request commentbrigand/jellobot

Sure, but first we need to figure why the CI fails, I don't have docker installed locally anymore so I can't test easily for now

By the way, I'm not sure to understand the added value of .at https://replit.com/@caub/Stringprototypeat#index.js I thought it would return a whole unicode char, unlike charAt

caub

comment created time in 2 months

push eventcaub/jellobot

push time in 2 months

push eventcaub/jellobot

commit sha 8e054c5d184bf5bf12ef01d29d2cd880abd9d5e2

debug CI tests

push time in 2 months

push eventcaub/jellobot

commit sha f1004f8be94ac96ff38c0fe17a69199ad9b1297c

test with only array.prototype.at

push time in 2 months

push eventcaub/jellobot

commit sha 5babc7cf14667b42696100e9d040a28b6fbc85ea

fix missing -r

push time in 2 months

push eventcaub/jellobot

commit sha 4262c637a0a6c6b85118391b0024606217e3c945

restrict .at to babel mode

push time in 2 months

pull request commentbrigand/jellobot

yes, will do, but I don't understand why the CI fails though

caub

comment created time in 2 months

push eventcaub/jellobot

Cyril Auburtin

commit sha d74bba559b89de6284f769dc7095ecc36af4e283

Update src/plugins/js-eval/jsEvalPlugin.js Co-authored-by: Jordan Harband <[email protected]>

push time in 2 months

push eventcaub/jellobot

commit sha e89f7a5aeb79def2f972d73b22e2adc752a8dc2f

update node to require string/array.prototype.at shims at load time

push time in 2 months

push eventcaub/jellobot

commit sha 35c056ce10ea5f2e09e722a02e99256a9b71534f

update node to require string/array.prototype.at shims at load time

push time in 2 months

pull request commentbrigand/jellobot

it's not sufficient indeed, I'll add node -r string.prototype.at -r array.prototype.at maybe

caub

comment created time in 2 months

push eventcaub/jellobot

Cyril Auburtin

commit sha cb22e03edbd6dddf2eb596af1fd8b5c1598f103f

Update src/plugins/js-eval/Dockerfile Co-authored-by: Jordan Harband <[email protected]>