profile
viewpoint
Jordan Eldredge captbaritone @facebook Alameda, CA https://jordaneldredge.com JavaScript dork.

1j01/98 279

💿 Web-based Windows 98 desktop recreation █████▓█▓▓▒▓▒▒░▒░░░🗕︎🗗︎🗙︎

captbaritone/codeception-mailcatcher-module 98

Test emails in your Codeception acceptance tests

captbaritone/better-indent-support-for-php-with-html 50

This script allows you to indent HTML sections in PHP files

captbaritone/awesome-atwoods-law 14

A curated list of applications reimplemented in JavaScript

afahim/eslint-plugin-underscore-lodash-compatibility 8

Make sure your code can use underscore and lodash interchangeably.

aaronabramov/haste_map 5

jest-haste-map fork written in rust

captbaritone/clusterfach-py 3

A recommendation engine

captbaritone/album-cover-generator 2

Randomly generated album covers

captbaritone/acorn 1

A small, fast, JavaScript-based JavaScript parser

issue commentcaptbaritone/webamp

Listening/Handling button clicks

The code you included does a point-in-time check to see what the current status is. It would not help you trigger a side effect like generating a popup.

Could you explain what the popup does? What would it say, why are you adding it?

Perhaps onTrackDidChange would work for you, but I don't understand exactly what you are trying to achieve.

aawajjoshi

comment created time in 9 hours

issue commentcaptbaritone/webamp

Listening/Handling button clicks

Do you want to show the pop up when the user clicks the button, or anytime a song starts playing?

aawajjoshi

comment created time in a day

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha e37231ad712f795a0002a220f723ebce8089c583

Clean up op constants

view details

push time in a day

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha 9e6dd5c8132ab5bb8a698a1f1edfe99006dcfde1

Only emit the minimul number of function types

view details

push time in 2 days

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha 6327231c439444fba10d2c45a8e3f66944287db8

Use arguments for immediates

view details

push time in 2 days

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha c9d751359648df3873a58a91cb53b3322b9c68dc

Cleanup

view details

Jordan Eldredge

commit sha 21df5e6dc0e6ea7f09910abf9a08baf09d446692

v0.0.7

view details

Jordan Eldredge

commit sha 257472c02c589236a73cd60f1ee60428914ff9cb

Make const immediates arguments

view details

Jordan Eldredge

commit sha fcd2db451d08467559de5a8bcd19e659041b6aea

Make local_tee immediate an argument

view details

Jordan Eldredge

commit sha 1dc063dd0e6c75ca14332a43bfb4841f9be07cbc

Make local set/get use argument for immediate

view details

Jordan Eldredge

commit sha f33c84b3f1f194f25f1e0210e8a975eecbb0f41a

Make br_if take an argument

view details

Jordan Eldredge

commit sha b7b29dd3cc18a1288cd5964739a091239e9ac3fb

Make more immediates arguments

view details

push time in 2 days

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha 072a162af968b2587aae43ff1dd9225853882026

Handle out of range indexes for mutating buffer assignemnt (+=, -=, etc)

view details

Jordan Eldredge

commit sha 1ccd748eb67e1e9021c1af2c122abf34d67932a1

Refactor cleanup of ASSIGNMENT_EXPRESSION

view details

Jordan Eldredge

commit sha 765073cafce3ef45f347903d6ddb0b9a3c870984

Improve handling of out of range indexes

view details

push time in 2 days

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha be12dfed5bb84327cd03b88a20696910c7ca5463

buff +=

view details

push time in 2 days

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha 608b9ae12643f54f9d52a2e3e43d6e469cbaa4f1

Support local variables of other types

view details

Jordan Eldredge

commit sha e2a8c25c7eff69e63ba8f2189bbaeec76fd7dcd1

Add epsilon checks to buffer indexes

view details

Jordan Eldredge

commit sha 3a98313cc2c9f7fb7834f95a387f017438b0182e

Add more ops

view details

Jordan Eldredge

commit sha 859d1e0dcd9626c2a4106190dd72c187d9516205

Start adding bounds checking for buffer indexes

view details

Jordan Eldredge

commit sha 700dedc2520439afc570ba8dcdd539e6ff906c51

Handle out of range indexes in = buffer assignement

view details

push time in 2 days

create barnchcaptbaritone/adios

branch : fix-audio

created branch time in 3 days

issue commentcaptbaritone/webamp

initialTrack doesn't play (initially).

Are you sure the path to your media file is correct? Is it hosted somewhere that I could play with it?

aawajjoshi

comment created time in 3 days

startedshmishtopher/wasm-LEB128

started time in 5 days

startedwasm-tool/wasi

started time in 5 days

push eventcaptbaritone/wasi

Jordan Eldredge

commit sha fa32063c52470d0b8acd0d2d92d9a8b87148dbbe

Clarify what WASI is I wasn't familiar so I had to Google it. This will save the next person from having to Google.

view details

push time in 5 days

fork captbaritone/wasi

Import WebAssembly modules that expose the WebAssembly System Interface (WASI).

fork in 5 days

startedfeross/buffer

started time in 5 days

starteddotnet/aspnetcore

started time in 6 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha bd797873f4a56e14fc3fb925a51a815b00040fbe

Move files to better locations and remove possibley out of date readme content

view details

push time in 8 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 0d3990fffa0fa848de062782504feaa0d9cf5a04

Try to fix CI Fix up tests WIP

view details

push time in 8 days

PR closed captbaritone/webamp

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /experiments/skinArchiveTools dependencies

Bumps https-proxy-agent from 2.2.1 to 2.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p> <blockquote> <h2>2.2.4</h2> <h3>Patches</h3> <ul> <li>Add <code>.editorconfig</code> file: a0d4a20458498fc31e5721471bd2b655e992d44b</li> <li>Add <code>.eslintrc.js</code> file: eecea74a1db1c943eaa4f667a561fd47c33da897</li> <li>Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy errors: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/83">#83</a></li> <li>Remove unused <code>stream</code> module: 9fdcd47bd813e9979ee57920c69e2ee2e0683cd4</li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/lpinca">@lpinca</a> for helping!</p> <h2>2.2.3</h2> <h3>Patches</h3> <ul> <li>Update README with actual <code>secureProxy</code> behavior: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/65">#65</a></li> <li>Update <code>proxy</code> to v1.0.0: d0e3c18079119057b05582cb72d4fda21dfc2546</li> <li>Remove unreachable code: 46aad0988b471f042856436cf3192b0e09e36fe6</li> <li>Test on Node.js 10 and 12: 3535951e482ea52af4888938f59649ed92e81b2b</li> <li>Fix compatibility with Node.js >= 10.0.0: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/73">#73</a></li> <li>Use an <code>EventEmitter</code> to replay failed proxy connect HTTP requests: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/77">#77</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/stoically">@stoically</a>, <a href="https://github.com/lpinca">@lpinca</a>, and <a href="https://github.com/zkochan">@zkochan</a> for helping!</p> <h2>2.2.2</h2> <h3>Patches</h3> <ul> <li>Remove <code>package-lock.json</code>: c881009b9873707f5c4a0e9c277dde588e1139c7</li> <li>Ignore test directory, History.md and .travis.yml when creating npm package. Fixes <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/42">#42</a>: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/45">#45</a></li> <li>Update <code>agent-base</code> to v4.2: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/50">#50</a></li> <li>Add TypeScript type definitions: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/66">#66</a></li> <li>Feat(typescript): Allow input to be options or string: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/68">#68</a></li> <li>Update <code>agent-base</code> to v4.3: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/69">#69</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/marco-c">@marco-c</a>, <a href="https://github.com/tareqhs">@tareqhs</a>, <a href="https://github.com/ianhowe76">@ianhowe76</a>, and <a href="https://github.com/BYK">@BYK</a> for helping!</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4c4cce8cb60fd3ac6171e4428f972698eb49f45a"><code>4c4cce8</code></a> 2.2.4</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/9fdcd47bd813e9979ee57920c69e2ee2e0683cd4"><code>9fdcd47</code></a> Remove unused <code>stream</code> module</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/34ea8841922fb6447563b0521f972ac3a6062303"><code>34ea884</code></a> Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy erro...</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4296770b6a0e631e3f8e7bd6cfd41ac8e91a3ec4"><code>4296770</code></a> Prettier</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/eecea74a1db1c943eaa4f667a561fd47c33da897"><code>eecea74</code></a> Add <code>.eslintrc.js</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/a0d4a20458498fc31e5721471bd2b655e992d44b"><code>a0d4a20</code></a> Add <code>.editorconfig</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/0d8e8bfe8b12e6ffe79a39eb93068cdf64c17e78"><code>0d8e8bf</code></a> 2.2.3</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/850b8359b7d0467d721705106b58f4c7cfb937dd"><code>850b835</code></a> Revert "Use Mocha 5 for Node 4 support"</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/f5f56fa48ea4d2a61c385938e7753f5c1fe049d6"><code>f5f56fa</code></a> Remove Node 4 from Travis</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/bb837b984bd868ad69080812eb8eab01181b21d7"><code>bb837b9</code></a> Revert "Remove Node 4 from Travis"</li> <li>Additional commits viewable in <a href="https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+16 -10

3 comments

1 changed file

dependabot[bot]

pr closed time in 8 days

PR closed captbaritone/webamp

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /packages/webamp/experiments/skinArchiveTools dependencies

Bumps https-proxy-agent from 2.2.1 to 2.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p> <blockquote> <h2>2.2.4</h2> <h3>Patches</h3> <ul> <li>Add <code>.editorconfig</code> file: a0d4a20458498fc31e5721471bd2b655e992d44b</li> <li>Add <code>.eslintrc.js</code> file: eecea74a1db1c943eaa4f667a561fd47c33da897</li> <li>Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy errors: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/83">#83</a></li> <li>Remove unused <code>stream</code> module: 9fdcd47bd813e9979ee57920c69e2ee2e0683cd4</li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/lpinca">@lpinca</a> for helping!</p> <h2>2.2.3</h2> <h3>Patches</h3> <ul> <li>Update README with actual <code>secureProxy</code> behavior: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/65">#65</a></li> <li>Update <code>proxy</code> to v1.0.0: d0e3c18079119057b05582cb72d4fda21dfc2546</li> <li>Remove unreachable code: 46aad0988b471f042856436cf3192b0e09e36fe6</li> <li>Test on Node.js 10 and 12: 3535951e482ea52af4888938f59649ed92e81b2b</li> <li>Fix compatibility with Node.js >= 10.0.0: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/73">#73</a></li> <li>Use an <code>EventEmitter</code> to replay failed proxy connect HTTP requests: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/77">#77</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/stoically">@stoically</a>, <a href="https://github.com/lpinca">@lpinca</a>, and <a href="https://github.com/zkochan">@zkochan</a> for helping!</p> <h2>2.2.2</h2> <h3>Patches</h3> <ul> <li>Remove <code>package-lock.json</code>: c881009b9873707f5c4a0e9c277dde588e1139c7</li> <li>Ignore test directory, History.md and .travis.yml when creating npm package. Fixes <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/42">#42</a>: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/45">#45</a></li> <li>Update <code>agent-base</code> to v4.2: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/50">#50</a></li> <li>Add TypeScript type definitions: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/66">#66</a></li> <li>Feat(typescript): Allow input to be options or string: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/68">#68</a></li> <li>Update <code>agent-base</code> to v4.3: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/69">#69</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/marco-c">@marco-c</a>, <a href="https://github.com/tareqhs">@tareqhs</a>, <a href="https://github.com/ianhowe76">@ianhowe76</a>, and <a href="https://github.com/BYK">@BYK</a> for helping!</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4c4cce8cb60fd3ac6171e4428f972698eb49f45a"><code>4c4cce8</code></a> 2.2.4</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/9fdcd47bd813e9979ee57920c69e2ee2e0683cd4"><code>9fdcd47</code></a> Remove unused <code>stream</code> module</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/34ea8841922fb6447563b0521f972ac3a6062303"><code>34ea884</code></a> Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy erro...</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4296770b6a0e631e3f8e7bd6cfd41ac8e91a3ec4"><code>4296770</code></a> Prettier</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/eecea74a1db1c943eaa4f667a561fd47c33da897"><code>eecea74</code></a> Add <code>.eslintrc.js</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/a0d4a20458498fc31e5721471bd2b655e992d44b"><code>a0d4a20</code></a> Add <code>.editorconfig</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/0d8e8bfe8b12e6ffe79a39eb93068cdf64c17e78"><code>0d8e8bf</code></a> 2.2.3</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/850b8359b7d0467d721705106b58f4c7cfb937dd"><code>850b835</code></a> Revert "Use Mocha 5 for Node 4 support"</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/f5f56fa48ea4d2a61c385938e7753f5c1fe049d6"><code>f5f56fa</code></a> Remove Node 4 from Travis</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/bb837b984bd868ad69080812eb8eab01181b21d7"><code>bb837b9</code></a> Revert "Remove Node 4 from Travis"</li> <li>Additional commits viewable in <a href="https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+16 -10

2 comments

1 changed file

dependabot[bot]

pr closed time in 8 days

PR closed captbaritone/webamp

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /packages/webamp/experiments/skin-database dependencies

Bumps https-proxy-agent from 2.2.1 to 2.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p> <blockquote> <h2>2.2.4</h2> <h3>Patches</h3> <ul> <li>Add <code>.editorconfig</code> file: a0d4a20458498fc31e5721471bd2b655e992d44b</li> <li>Add <code>.eslintrc.js</code> file: eecea74a1db1c943eaa4f667a561fd47c33da897</li> <li>Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy errors: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/83">#83</a></li> <li>Remove unused <code>stream</code> module: 9fdcd47bd813e9979ee57920c69e2ee2e0683cd4</li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/lpinca">@lpinca</a> for helping!</p> <h2>2.2.3</h2> <h3>Patches</h3> <ul> <li>Update README with actual <code>secureProxy</code> behavior: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/65">#65</a></li> <li>Update <code>proxy</code> to v1.0.0: d0e3c18079119057b05582cb72d4fda21dfc2546</li> <li>Remove unreachable code: 46aad0988b471f042856436cf3192b0e09e36fe6</li> <li>Test on Node.js 10 and 12: 3535951e482ea52af4888938f59649ed92e81b2b</li> <li>Fix compatibility with Node.js >= 10.0.0: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/73">#73</a></li> <li>Use an <code>EventEmitter</code> to replay failed proxy connect HTTP requests: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/77">#77</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/stoically">@stoically</a>, <a href="https://github.com/lpinca">@lpinca</a>, and <a href="https://github.com/zkochan">@zkochan</a> for helping!</p> <h2>2.2.2</h2> <h3>Patches</h3> <ul> <li>Remove <code>package-lock.json</code>: c881009b9873707f5c4a0e9c277dde588e1139c7</li> <li>Ignore test directory, History.md and .travis.yml when creating npm package. Fixes <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/42">#42</a>: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/45">#45</a></li> <li>Update <code>agent-base</code> to v4.2: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/50">#50</a></li> <li>Add TypeScript type definitions: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/66">#66</a></li> <li>Feat(typescript): Allow input to be options or string: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/68">#68</a></li> <li>Update <code>agent-base</code> to v4.3: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/69">#69</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/marco-c">@marco-c</a>, <a href="https://github.com/tareqhs">@tareqhs</a>, <a href="https://github.com/ianhowe76">@ianhowe76</a>, and <a href="https://github.com/BYK">@BYK</a> for helping!</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4c4cce8cb60fd3ac6171e4428f972698eb49f45a"><code>4c4cce8</code></a> 2.2.4</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/9fdcd47bd813e9979ee57920c69e2ee2e0683cd4"><code>9fdcd47</code></a> Remove unused <code>stream</code> module</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/34ea8841922fb6447563b0521f972ac3a6062303"><code>34ea884</code></a> Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy erro...</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4296770b6a0e631e3f8e7bd6cfd41ac8e91a3ec4"><code>4296770</code></a> Prettier</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/eecea74a1db1c943eaa4f667a561fd47c33da897"><code>eecea74</code></a> Add <code>.eslintrc.js</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/a0d4a20458498fc31e5721471bd2b655e992d44b"><code>a0d4a20</code></a> Add <code>.editorconfig</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/0d8e8bfe8b12e6ffe79a39eb93068cdf64c17e78"><code>0d8e8bf</code></a> 2.2.3</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/850b8359b7d0467d721705106b58f4c7cfb937dd"><code>850b835</code></a> Revert "Use Mocha 5 for Node 4 support"</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/f5f56fa48ea4d2a61c385938e7753f5c1fe049d6"><code>f5f56fa</code></a> Remove Node 4 from Travis</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/bb837b984bd868ad69080812eb8eab01181b21d7"><code>bb837b9</code></a> Revert "Remove Node 4 from Travis"</li> <li>Additional commits viewable in <a href="https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+9 -5

2 comments

1 changed file

dependabot[bot]

pr closed time in 8 days

PR closed captbaritone/webamp

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /packages/skinArchiveTools dependencies

Bumps https-proxy-agent from 2.2.1 to 2.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p> <blockquote> <h2>2.2.4</h2> <h3>Patches</h3> <ul> <li>Add <code>.editorconfig</code> file: a0d4a20458498fc31e5721471bd2b655e992d44b</li> <li>Add <code>.eslintrc.js</code> file: eecea74a1db1c943eaa4f667a561fd47c33da897</li> <li>Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy errors: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/83">#83</a></li> <li>Remove unused <code>stream</code> module: 9fdcd47bd813e9979ee57920c69e2ee2e0683cd4</li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/lpinca">@lpinca</a> for helping!</p> <h2>2.2.3</h2> <h3>Patches</h3> <ul> <li>Update README with actual <code>secureProxy</code> behavior: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/65">#65</a></li> <li>Update <code>proxy</code> to v1.0.0: d0e3c18079119057b05582cb72d4fda21dfc2546</li> <li>Remove unreachable code: 46aad0988b471f042856436cf3192b0e09e36fe6</li> <li>Test on Node.js 10 and 12: 3535951e482ea52af4888938f59649ed92e81b2b</li> <li>Fix compatibility with Node.js >= 10.0.0: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/73">#73</a></li> <li>Use an <code>EventEmitter</code> to replay failed proxy connect HTTP requests: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/77">#77</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/stoically">@stoically</a>, <a href="https://github.com/lpinca">@lpinca</a>, and <a href="https://github.com/zkochan">@zkochan</a> for helping!</p> <h2>2.2.2</h2> <h3>Patches</h3> <ul> <li>Remove <code>package-lock.json</code>: c881009b9873707f5c4a0e9c277dde588e1139c7</li> <li>Ignore test directory, History.md and .travis.yml when creating npm package. Fixes <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/42">#42</a>: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/45">#45</a></li> <li>Update <code>agent-base</code> to v4.2: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/50">#50</a></li> <li>Add TypeScript type definitions: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/66">#66</a></li> <li>Feat(typescript): Allow input to be options or string: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/68">#68</a></li> <li>Update <code>agent-base</code> to v4.3: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/69">#69</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/marco-c">@marco-c</a>, <a href="https://github.com/tareqhs">@tareqhs</a>, <a href="https://github.com/ianhowe76">@ianhowe76</a>, and <a href="https://github.com/BYK">@BYK</a> for helping!</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4c4cce8cb60fd3ac6171e4428f972698eb49f45a"><code>4c4cce8</code></a> 2.2.4</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/9fdcd47bd813e9979ee57920c69e2ee2e0683cd4"><code>9fdcd47</code></a> Remove unused <code>stream</code> module</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/34ea8841922fb6447563b0521f972ac3a6062303"><code>34ea884</code></a> Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy erro...</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4296770b6a0e631e3f8e7bd6cfd41ac8e91a3ec4"><code>4296770</code></a> Prettier</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/eecea74a1db1c943eaa4f667a561fd47c33da897"><code>eecea74</code></a> Add <code>.eslintrc.js</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/a0d4a20458498fc31e5721471bd2b655e992d44b"><code>a0d4a20</code></a> Add <code>.editorconfig</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/0d8e8bfe8b12e6ffe79a39eb93068cdf64c17e78"><code>0d8e8bf</code></a> 2.2.3</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/850b8359b7d0467d721705106b58f4c7cfb937dd"><code>850b835</code></a> Revert "Use Mocha 5 for Node 4 support"</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/f5f56fa48ea4d2a61c385938e7753f5c1fe049d6"><code>f5f56fa</code></a> Remove Node 4 from Travis</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/bb837b984bd868ad69080812eb8eab01181b21d7"><code>bb837b9</code></a> Revert "Remove Node 4 from Travis"</li> <li>Additional commits viewable in <a href="https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+16 -10

0 comment

1 changed file

dependabot[bot]

pr closed time in 8 days

PR closed captbaritone/webamp

Bump https-proxy-agent from 2.2.1 to 2.2.4 in /packages/skin-database dependencies

Bumps https-proxy-agent from 2.2.1 to 2.2.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p> <blockquote> <h2>2.2.4</h2> <h3>Patches</h3> <ul> <li>Add <code>.editorconfig</code> file: a0d4a20458498fc31e5721471bd2b655e992d44b</li> <li>Add <code>.eslintrc.js</code> file: eecea74a1db1c943eaa4f667a561fd47c33da897</li> <li>Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy errors: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/83">#83</a></li> <li>Remove unused <code>stream</code> module: 9fdcd47bd813e9979ee57920c69e2ee2e0683cd4</li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/lpinca">@lpinca</a> for helping!</p> <h2>2.2.3</h2> <h3>Patches</h3> <ul> <li>Update README with actual <code>secureProxy</code> behavior: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/65">#65</a></li> <li>Update <code>proxy</code> to v1.0.0: d0e3c18079119057b05582cb72d4fda21dfc2546</li> <li>Remove unreachable code: 46aad0988b471f042856436cf3192b0e09e36fe6</li> <li>Test on Node.js 10 and 12: 3535951e482ea52af4888938f59649ed92e81b2b</li> <li>Fix compatibility with Node.js >= 10.0.0: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/73">#73</a></li> <li>Use an <code>EventEmitter</code> to replay failed proxy connect HTTP requests: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/77">#77</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/stoically">@stoically</a>, <a href="https://github.com/lpinca">@lpinca</a>, and <a href="https://github.com/zkochan">@zkochan</a> for helping!</p> <h2>2.2.2</h2> <h3>Patches</h3> <ul> <li>Remove <code>package-lock.json</code>: c881009b9873707f5c4a0e9c277dde588e1139c7</li> <li>Ignore test directory, History.md and .travis.yml when creating npm package. Fixes <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/42">#42</a>: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/45">#45</a></li> <li>Update <code>agent-base</code> to v4.2: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/50">#50</a></li> <li>Add TypeScript type definitions: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/66">#66</a></li> <li>Feat(typescript): Allow input to be options or string: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/68">#68</a></li> <li>Update <code>agent-base</code> to v4.3: <a href="https://github-redirect.dependabot.com/TooTallNate/node-https-proxy-agent/issues/69">#69</a></li> </ul> <h3>Credits</h3> <p>Huge thanks to <a href="https://github.com/marco-c">@marco-c</a>, <a href="https://github.com/tareqhs">@tareqhs</a>, <a href="https://github.com/ianhowe76">@ianhowe76</a>, and <a href="https://github.com/BYK">@BYK</a> for helping!</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4c4cce8cb60fd3ac6171e4428f972698eb49f45a"><code>4c4cce8</code></a> 2.2.4</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/9fdcd47bd813e9979ee57920c69e2ee2e0683cd4"><code>9fdcd47</code></a> Remove unused <code>stream</code> module</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/34ea8841922fb6447563b0521f972ac3a6062303"><code>34ea884</code></a> Use a <code>net.Socket</code> instead of a plain <code>EventEmitter</code> for replaying proxy erro...</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/4296770b6a0e631e3f8e7bd6cfd41ac8e91a3ec4"><code>4296770</code></a> Prettier</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/eecea74a1db1c943eaa4f667a561fd47c33da897"><code>eecea74</code></a> Add <code>.eslintrc.js</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/a0d4a20458498fc31e5721471bd2b655e992d44b"><code>a0d4a20</code></a> Add <code>.editorconfig</code> file</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/0d8e8bfe8b12e6ffe79a39eb93068cdf64c17e78"><code>0d8e8bf</code></a> 2.2.3</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/850b8359b7d0467d721705106b58f4c7cfb937dd"><code>850b835</code></a> Revert "Use Mocha 5 for Node 4 support"</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/f5f56fa48ea4d2a61c385938e7753f5c1fe049d6"><code>f5f56fa</code></a> Remove Node 4 from Travis</li> <li><a href="https://github.com/TooTallNate/node-https-proxy-agent/commit/bb837b984bd868ad69080812eb8eab01181b21d7"><code>bb837b9</code></a> Revert "Remove Node 4 from Travis"</li> <li>Additional commits viewable in <a href="https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.1...2.2.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+9 -5

0 comment

1 changed file

dependabot[bot]

pr closed time in 8 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 05715391cb181a076548aa2505f8c2ec75864a53

Fix up tests

view details

push time in 8 days

push eventcaptbaritone/webamp

Martín Acosta

commit sha 2101c74114f5f3b8352cf39363c8b5a3f18f34a2

Add extend handlers for openUrl, load/save list (#991) * Added missing handlers * Merge new yarn workspace version * Minor changes * Minor changes * Replace PlaylistTrack by Track * Minor changes * Fixed yarn.lock * Added getUserTracks selector * Added usage doc

view details

Jordan Eldredge

commit sha a3fa11aa614491d7c8572aaab4ccb6ea1e3a226d

v1.4.1-beta03

view details

Jordan Eldredge

commit sha ad01362fc3cfeb7e4fe4fb4fe13c49ab4623e227

Document that the playlist events are not yet released

view details

Jordan Eldredge

commit sha 48b813ee64fa1bfafb8d8c995a8e6fe349cbf03f

Update yarn.lock

view details

Jordan Eldredge

commit sha cce5cb3ee58219b8602fd6f3d3982084b04733da

Move CSS inlining to Babel and generate babel output

view details

Jordan Eldredge

commit sha 9818943b8ffc51adf7f5f6f030fd7b911ae59b22

Improve honesty of dependencies

view details

Jordan Eldredge

commit sha 1d606135dab304f53100ba18eaf00615525b67f2

Use derived .d.ts files

view details

Jordan Eldredge

commit sha 266a670001874f09e0549c51a5672ed3968ddb15

Redux dev tools are actually a dependency

view details

Jordan Eldredge

commit sha 8850061f2b3325016a0bf60c2213f8b4de8f182b

Move 'Modern' experiment into its own pacakge

view details

Jordan Eldredge

commit sha 3437dd0280f244b93f4268a9bba260143c0ba25a

Start moving demo site to own repo

view details

Jordan Eldredge

commit sha 2591227c0e23fadde028d89b6d214b2907fd15c4

Setup CI for newly split packages

view details

Jordan Eldredge

commit sha 69c9d2c5c74694f1b4441ce0de28d54ec1bafc25

Update Netlify to work in split packages

view details

Jordan Eldredge

commit sha c5588c5da5663b5325226470643057b043ebd9d8

Reduce bundle size by not importing all of Webamp

view details

Jordan Eldredge

commit sha 886d23feb95912c7a252d8070bcc70aa1682d5a1

Try to fix CI

view details

push time in 8 days

pull request commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

I just published a beta version 1.4.1-beta03 and tried it out here. Seems to work well!

Would you take it for a spin in your project and report back to confirm that it worked? I'll be publishing a new release in a little bit and hopefully you can move there soon.

tinchoz49

comment created time in 8 days

push eventcaptbaritone/webamp

Martín Acosta

commit sha 2101c74114f5f3b8352cf39363c8b5a3f18f34a2

Add extend handlers for openUrl, load/save list (#991) * Added missing handlers * Merge new yarn workspace version * Minor changes * Minor changes * Replace PlaylistTrack by Track * Minor changes * Fixed yarn.lock * Added getUserTracks selector * Added usage doc

view details

push time in 8 days

PR merged captbaritone/webamp

Add extend handlers for openUrl, load/save list

This PR adds support for openUrl, load/save list handlers:

  • [ ] Update USAGE.MD
new Webamp({
  handleAddUrlEvent() {
    // return Tracks[] to load
  },
  handleLoadListEvent() {
    // return Tracks[] to load
  },
  handleSaveListEvent(tracks: PlaylistTrack[]) {
    // async operation to save the tracks
  },
})
+101 -15

6 comments

10 changed files

tinchoz49

pr closed time in 8 days

pull request commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

Fantastic! I’ll merge this now and try to push an alpha release to NPM later today for you to use/test.

Thanks for all your work on this. Great idea.

tinchoz49

comment created time in 8 days

pull request commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

Looks great to me! Are you up to adding it to the usage.md docs?

tinchoz49

comment created time in 9 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        dispatch(removeAllTracks());++        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, 0));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function saveFilesToList(): Thunk {+  return (dispatch, getState, { handleSaveListEvent }) => {+    if (handleSaveListEvent) {+      const state = getState();+      const trackIds = getTrackOrder(state);+      const tracks = getTracks(state);+      handleSaveListEvent(+        trackIds.map((id) => {+          const track = tracks[id];++          return {+            url: track.url,+            metaData: {+              artist: track.artist || "",

Touché 😛

tinchoz49

comment created time in 9 days

startedadelsz/pgtyped

started time in 9 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 3bda9b29fb2f3e3309256d45a418870d79024a64

Try to fix CI

view details

push time in 9 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 816b0e6fe6549be485441045d51101305d88c5bf

Reduce bundle size by not importing all of Webamp

view details

push time in 10 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha a0ff9c9974f865f3ee907d371610447b49830c81

Update Netlify to work in split packages

view details

push time in 10 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 52c094da9341fa6189890edf0254d077f965174c

Setup CI for newly split packages

view details

Jordan Eldredge

commit sha c3586f06297b994ac46b953afe72f08f6856cae3

Update Netlify to work in split packages

view details

push time in 10 days

PR opened captbaritone/webamp

Massive PR to reorganize the repo

The repository has been in a messy state for ages. Now that we have yarn workspaces we can start to give a clearer separation between some things which are semantically separate. This should make the boundaries clearer to those new to the code base. This:

  1. Splits the modern experiment that we did out into its own package.
  2. Splits the demo site (found on https://webamp.org) into it's own package which consumes the actual Webamp export

Now that the demo site is actually consuming the version of Webamp exposed to NPM we have to be more honest about how we use private APIs. We also need a real way to consume Webamp not as a bundle.

There is way too much going on in this PR, but I suspect it's going to take us a while to clean up all the loose ends, so this is just a start. I plan to merge this when it's basically working (more or less) and then continue to clean up on master.

+3585 -587

0 comment

360 changed files

pr created time in 10 days

create barnchcaptbaritone/webamp

branch : babel-only

created branch time in 10 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        dispatch(removeAllTracks());++        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, 0));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function saveFilesToList(): Thunk {+  return (dispatch, getState, { handleSaveListEvent }) => {+    if (handleSaveListEvent) {+      const state = getState();+      const trackIds = getTrackOrder(state);+      const tracks = getTracks(state);+      handleSaveListEvent(+        trackIds.map((id) => {+          const track = tracks[id];++          return {+            url: track.url,+            metaData: {+              artist: track.artist || "",

I'm generally not a fan of || "". If the field is nullable, pass null, if it's not nullable then it's required and passing it an empty value is going to cause unexpected behavior. Could we just null out the entire metaData object if any of the required fields are missing?

tinchoz49

comment created time in 10 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 attr-accept@^2.0.0:   resolved "https://registry.yarnpkg.com/attr-accept/-/attr-accept-2.1.0.tgz#a231a854385d36ff7a99647bb77b33c8a5175aee"   integrity sha512-sLzVM3zCCmmDtDNhI0i96k6PUztkotSOXqE4kDGQt/6iDi5M+H0srjeF+QC6jN581l4X/Zq3Zu/tgcErEssavg== +aws-sdk@^2.663.0:+  version "2.678.0"+  resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.678.0.tgz#b16230f4894d40ead50f9e23805c874f4ca62549"+  integrity sha512-i8t7+1/C6maQzUYUFRQXPAsUPT0YdpNsf/oHZKmmZrsOX+epnn2jmAGIBTZgUakY8jRrZxCJka+QokUIadUVQg==+  dependencies:+    buffer "4.9.1"+    events "1.1.1"+    ieee754 "1.1.13"+    jmespath "0.15.0"+    querystring "0.2.0"+    sax "1.2.1"+    url "0.10.3"+    uuid "3.3.2"+    xml2js "0.4.19"+

I think these changes to yarn.lock are incorrect. I'm guessing you don't need any of them.

tinchoz49

comment created time in 10 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        dispatch(removeAllTracks());++        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, 0));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function saveFilesToList(): Thunk {+  return (dispatch, getState, { handleSaveListEvent }) => {+    if (handleSaveListEvent) {+      const state = getState();+      const trackIds = getTrackOrder(state);+      const tracks = getTracks(state);+      handleSaveListEvent(+        trackIds.map((id) => {+          const track = tracks[id];++          return {+            url: track.url,+            metaData: {+              artist: track.artist || "",+              title: track.title || "",+              album: track.album,+              albumArtUrl: track.albumArtUrl || "",+            },+          };

For bonus points we could move the generation of this array of tracks into a selector in the selectors file. (Not required)

tinchoz49

comment created time in 10 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 async function main() {         return null;       }     },+    handleLoadListEvent() {+      // in a real example the user will open a playlist file (maybe m3u?)+      return [+        {+          url:+            "https://raw.githubusercontent.com/captbaritone/webamp-music/4b556fbf/Diablo_Swing_Orchestra_-_01_-_Heroines.mp3",+        },+      ];+    },+    handleSaveListEvent(tracks) {+      console.log(tracks);+    },

I think we can remove both of these as well.

tinchoz49

comment created time in 13 days

startedcsstree/csstree

started time in 11 days

pull request commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

@remigallego would this API be useful for Winampify.io? If so, would this approach work?

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 async function main() {         return null;       }     },+    handleAddUrlEvent() {+      const url = window.prompt("Paste your URL");

Sadly due to CORs this won't work for most URLs. Thanks for including this in the PR so that we can see how it would be used, but lets remove them before we actually merge.

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export interface Extras {   handleTrackDropEvent?: (     e: React.DragEvent<HTMLDivElement>   ) => Track[] | null | Promise<Track[] | null>;+  handleAddUrlEvent?: () => Track[] | null | Promise<Track[] | null>;+  handleLoadListEvent?: () => Track[] | null | Promise<Track[] | null>;+  handleSaveListEvent?: (tracks: PlaylistTrack[]) => Promise<undefined>;

Does asking the user to return a promise here add any value? Currently we don't do anything with the promise.

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        await dispatch(removeAllTracks());++        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, 0));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function saveFilesToList(): Thunk {+  return async (dispatch, getState, { handleSaveListEvent }) => {+    if (handleSaveListEvent) {+      const state = getState();+      const trackIds = getVisibleTrackIds(state);+      const tracks = getTracks(state);+      await handleSaveListEvent(trackIds.map((id) => tracks[id]));

Do we need to await here?

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 import { useActionCreator } from "../../hooks"; /* eslint-disable no-alert */ export default function ListMenu() {   const removeAllTracks = useActionCreator(Actions.removeAllTracks);+  const addFilesFromList = useActionCreator(Actions.addFilesFromList);+  const saveFilesToList = useActionCreator(Actions.saveFilesToList);   return (     <PlaylistMenu id="playlist-list-menu">       <div className="new-list" onClick={removeAllTracks} />-      <div-        className="save-list"-        onClick={() => alert("Not supported in Webamp")}-      />-      <div-        className="load-list"-        onClick={() => alert("Not supported in Webamp")}-      />+      <div className="save-list" onClick={() => saveFilesToList()} />+      <div className="load-list" onClick={() => addFilesFromList()} />

I don't think we need these arrow functions:

      <div className="save-list" onClick={saveFilesToList} />
      <div className="load-list" onClick={addFilesFromList} />
tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export interface Extras {   handleTrackDropEvent?: (     e: React.DragEvent<HTMLDivElement>   ) => Track[] | null | Promise<Track[] | null>;+  handleAddUrlEvent?: () => Track[] | null | Promise<Track[] | null>;+  handleLoadListEvent?: () => Track[] | null | Promise<Track[] | null>;+  handleSaveListEvent?: (tracks: PlaylistTrack[]) => Promise<undefined>;

I think the type PlaylistTrack is an internal type that is not really exposed in the public API. Could we convert these to Track before returning them to the user without losing anything valuable?

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        await dispatch(removeAllTracks());

Why are we awaiting here?

tinchoz49

comment created time in 14 days

Pull request review commentcaptbaritone/webamp

Add extend handlers for openUrl, load/save list

 export function addDirAtIndex(nextIndex: number): Thunk {     );   }; }++export function addFilesFromUrl(atIndex = 0): Thunk {+  return async (dispatch, getState, { handleAddUrlEvent }) => {+    if (handleAddUrlEvent) {+      const tracks = await handleAddUrlEvent();++      if (tracks != null) {+        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, atIndex));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function addFilesFromList(): Thunk {+  return async (dispatch, getState, { handleLoadListEvent }) => {+    if (handleLoadListEvent) {+      const tracks = await handleLoadListEvent();++      if (tracks != null) {+        await dispatch(removeAllTracks());++        dispatch(loadMediaFiles(tracks, LOAD_STYLE.NONE, 0));+        return;+      }+    } else {+      alert("Not supported in Webamp");+    }+  };+}++export function saveFilesToList(): Thunk {+  return async (dispatch, getState, { handleSaveListEvent }) => {+    if (handleSaveListEvent) {+      const state = getState();+      const trackIds = getVisibleTrackIds(state);

This returns the ids of the tracks that are visible in the window. If the window is shorter this list is shorter. I think you want getTrackOrder.

tinchoz49

comment created time in 14 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 3ae10aee6d585d1d045fd8060b65a3b13b1838b2

Move IA tests to package

view details

Jordan Eldredge

commit sha a1f4e201952cdb292ac8d126e599c69db2f67761

Move tweetBot to its own package

view details

Jordan Eldredge

commit sha 681ac7e4f4cb404f8ddfea0edf27de761a54f9f7

Move skin stuff to their own packages

view details

Jordan Eldredge

commit sha c5603619efdcc9fd8821d2d0f8593931e0e8224e

Add readmes

view details

push time in 14 days

issue openedcaptbaritone/webamp

Add README.md for each package

Now that we have some of the experiments split out into their own "packages" we should give each one a readme.

created time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 975d7126627bd441f1a7deee7ec0a0bcd3e494f8

Start adopting Yarn workspaces (#985) * Start adopting Yarn workspaces My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate. Fix lint command * Use workspaces in CI * Fix deploy for monorepo

view details

push time in 15 days

PR merged captbaritone/webamp

Start adopting Yarn workspaces

My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate.

Note: I suspect there will be a list of things to figure out here for the various Github/Netlify integrations.

TODO

  • [x] Figure out how we will update documentation to point to the right files.
    • I ended up using find . -name \*.md ! -path "*/node_modules/*" ! -name press.md -exec yarn exec markdown-link-check {} \;
+3775 -4226

0 comment

634 changed files

captbaritone

pr closed time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha d1d0ec5a9226b46da00b784368b5873e870a4a1b

Fix deploy for monorepo

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 4bebcdd4e60d6acf8cd0ed8d6cc8087ba5710bed

Use workspaces in CI

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 50b25433fcb7e49b5e0d61ae24cc3b59b653052f

Ensure Store type includes observable interface

view details

Jordan Eldredge

commit sha 507416ff4ae522af75252b9d9b2faa7e44b00f4b

Start adopting Yarn workspaces My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate. Fix lint command

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 50b25433fcb7e49b5e0d61ae24cc3b59b653052f

Ensure Store type includes observable interface

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 35f9898dd35b61c75b0a12efe4a09656b8886195

Start adopting Yarn workspaces My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate. Fix lint command

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 536a1b77602d575f6a54ec4d2e792324412f606c

Use archived link for Spotiamp

view details

Jordan Eldredge

commit sha 808cfe9d55050be7119c5110d229f701efb9b9f1

Fix readme links

view details

Jordan Eldredge

commit sha 0984f098561cc9076521c96bacd45f2026f5aef0

Start adopting Yarn workspaces My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate.

view details

Jordan Eldredge

commit sha b2b1fb7bd21666cd1e2da1bc294bf9540a161f79

Fix lint command

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 808cfe9d55050be7119c5110d229f701efb9b9f1

Fix readme links

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 536a1b77602d575f6a54ec4d2e792324412f606c

Use archived link for Spotiamp

view details

Jordan Eldredge

commit sha 4c9031c0b8be0c472db41744a0ccd6733e77cc10

Fix readme links

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 4130b4eafb64102aa4fe0e870024b2bfef663211

Resolve lint errors

view details

Jordan Eldredge

commit sha 39da735f17258180629b228e336889bd7009ac32

Use --rulesdir

view details

Jordan Eldredge

commit sha 1c043ed598f9188b01c33fddc4ef41c1e6bd999e

Remove useless test

view details

Jordan Eldredge

commit sha a19633f0dc1702ed614d628e43aea5f23a91f0a8

Update image snapshots

view details

Jordan Eldredge

commit sha 617cf088f8d9b191b977e20719fd1b2092c3c524

Start adopting Yarn workspaces My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate.

view details

Jordan Eldredge

commit sha 869a4a2b3e2b5ef9f9e004e396487b07f59be8c0

Fix lint command

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha a19633f0dc1702ed614d628e43aea5f23a91f0a8

Update image snapshots

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 39da735f17258180629b228e336889bd7009ac32

Use --rulesdir

view details

Jordan Eldredge

commit sha 1c043ed598f9188b01c33fddc4ef41c1e6bd999e

Remove useless test

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 4130b4eafb64102aa4fe0e870024b2bfef663211

Resolve lint errors

view details

push time in 15 days

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha e4929dbf14b06f6494b4edce548162087bb62774

Fix lint command

view details

push time in 15 days

PR opened captbaritone/webamp

Start adopting Yarn workspaces

My plan is to move the existing package into a workspace and then split out the things that really ought to be their own packages. For example, the demo site and the experiments really ought to be separate.

Note: I suspect there will be a list of things to figure out here for the various Github/Netlify integrations.

TODO

  • [ ] Figure out how we will update documentation to point to the right files.
+3769 -4220

0 comment

636 changed files

pr created time in 15 days

create barnchcaptbaritone/webamp

branch : monorepo

created branch time in 15 days

pull request commentcaptbaritone/webamp

Use count from forceUpdate to determine if components areEqual

Oops. I somehow overlooked this, and now its git history is all a mess (Probably from the force push I did to remove the large assets I accidentally committed).

jberg

comment created time in 15 days

issue commentcaptbaritone/webamp

Render in specific container

Hey @hacklover thanks for reaching out.

The behavior of Webamp is that it can be dragged anywhere on the screen by the user. If I recall correctly, there were a number of cases where styling of the parent DOM nodes would cause subtle non-obvious edge cases in how the window dragging/resizing logic would work. Rather than trying to have Webamp handle any possible parent DOM setup, or pushing the responsibility of solving those issues onto those using Webamp, we decided to just inject Webamp at the top level.

Webamp's zIndex can be configured using a configuration option but maybe you need something more nuanced than that?

Your note about needing to prevent the windows from being dragged makes me think that you are using it in a way that's a bit unique. Could you give some details about how you're trying to use it? Maybe I'll have some ideas of how you can make it work.

hacklover

comment created time in 15 days

issue commentcaptbaritone/webamp

Extend add url and load/save list by the user

I think the closest parallel would be the handleTrackDropEvent option. Here's how that works:

  1. It's passed into the Webamp as an option and passed to the Redux store (here) as part of the extras. This makes the value available inside of the Redux Thunks.
  2. Then you'll need to create an action creator(s) like this one which responds to the user's action by calling the new function if provided, and falling back to calling alert() if it's not.
  3. Finally, inside the component, you'll need to dispatch the action you created. You can do this using useActionCreator, which already has an example in the file.

If you have any questions, feel free to ask here, or jump into our Discord (mentioned in the Readme).

Thanks again for the suggestion and your willingness to help.

tinchoz49

comment created time in 15 days

issue commentcaptbaritone/webamp

Extend add url and load/save list by the user

I like this idea. Would you be interested in working on a pull request to add it? If so, I can write up some code pointers showing where the changes would need to happen.

tinchoz49

comment created time in 15 days

startedxtuc/webassemblyjs

started time in 16 days

startedmunificent/game-programming-patterns

started time in 16 days

startedappcypher/awesome-wasm-langs

started time in 16 days

PR opened appcypher/awesome-wasm-langs

Add eel-wasm

This is a pet project I've been working on for a while. It still has a few bugs that I'm working out, but it's functional.

I'm not sure if amateur compilers like this are appropriate for this list or not. If not, feel free not to merge this pull request.

Thanks for the great list!

+7 -0

0 comment

1 changed file

pr created time in 16 days

push eventcaptbaritone/awesome-wasm-langs

Jordan Eldredge

commit sha 74204e84f389aec98484268d963fb57583f74c8c

Add eel-wasm This is a pet project I've been working on for a while. It still has a few bugs that I'm working out, but it's functional. I'm not sure if amateur compilers like this are appropriate for this list or not. If not, feel free not to merge this pull request. Thanks for the great list!

view details

push time in 16 days

fork captbaritone/awesome-wasm-langs

😎 A curated list of languages that compile directly to or have their VMs in WebAssembly

fork in 16 days

startedWebAssembly/design

started time in 16 days

startedrmp135/sql-ts

started time in 23 days

issue openedcaptbaritone/webamp

Incorrect handling of region.txt

Real Winamp

unknown (1)

Webamp

46b8c4e5662b37c03a5d5c8ff9f119ae

Webamp Link Download Skin

created time in 24 days

issue openedcaptbaritone/eel-wasm

Test fractional buffer indexes

created time in a month

push eventcaptbaritone/eel-wasm

Jordan Eldredge

commit sha 568448c2c0299f33704f4ca67e8412f2bba50693

Handle case where no arguments are passed to a buffer assignment

view details

Jordan Eldredge

commit sha deffae99cf006f2eba2091b35e59ff24514560eb

Add a note

view details

Jordan Eldredge

commit sha 7702bedcbf1761ca259b67541b89c8746b825481

Sketch out a JS emitter

view details

push time in a month

issue openedcaptbaritone/eel-wasm

while/loop return values

Check if while or loop return a value and add tests.

created time in a month

PR closed captbaritone/webamp

Bug, vulnerability and code smell fixes suggested by SonarCloud.

The repository was run through a SonarCloud tool, that identified several issues that were fixed in this rull request.

SonarCloud project link.

+71 -54

2 comments

22 changed files

AnastasiaVorton

pr closed time in a month

pull request commentcaptbaritone/webamp

Bug, vulnerability and code smell fixes suggested by SonarCloud.

I'm going to close this for now, but feel free to open these commits as individual pull requests with explanations for what problem smell/vulnerability they solve.

AnastasiaVorton

comment created time in a month

pull request commentcaptbaritone/webamp

Bug, vulnerability and code smell fixes suggested by SonarCloud.

@AnastasiaVorton Thanks for the PR, but there are a lot of unrelated things going on here. I'll read through it and see if there is anything that seems important enough to take, but in the future these types of changes would make more sense as individual PRs so that they can be merged more granularly.

AnastasiaVorton

comment created time in a month

PullRequestEvent

pull request commentcaptbaritone/webamp

Bug, vulnerability and code smell fixes suggested by SonarCloud.

@AnastasiaVorton I'm assuming this PR was generated

AnastasiaVorton

comment created time in a month

PR closed captbaritone/webamp

Bug, vulnerability and code smell fixes suggested by SoralCloud.

The reposityru was run through a SonarCloud tool, that identified several issues that were fixed in this rull request.

SonarCloud project link.

+71 -54

0 comment

22 changed files

AnastasiaVorton

pr closed time in a month

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 74e58befbee489c6b95fae7d5baf3d9d18f32c97

Don't typecheck the skin DB as part of Webamp

view details

Jordan Eldredge

commit sha ef8a0b083e650932d105f55c7f27a8b3698a2969

Update snapshots

view details

push time in a month

issue commentcaptbaritone/webamp

Handle region.txt edge case

Workaround here: https://github.com/captbaritone/webamp/commit/0bd8b09ecff9f00873fc13dcd2a5662bf3efff61

captbaritone

comment created time in a month

push eventcaptbaritone/webamp

Jordan Eldredge

commit sha 0bd8b09ecff9f00873fc13dcd2a5662bf3efff61

Ignore polygons with fewer than three sides

view details

push time in a month

issue openedcaptbaritone/webamp

Handle region.txt edge case

This skin does not seem to render correctly: https://webamp.org/?skinUrl=https://s3.amazonaws.com/webamp-uploaded-skins/skins/66202428b1abb8be535d66df9158d976.wsz

The top window is cut off because we render a clip path with a polygon with only one point. This is because it has a bogus region.txt.

[Normal]
numpoints=1, 0
pointlist=176,71

There are a few things wrong here:

  1. What does a zero point polygon mean?
  2. What does a one point polygon mean?

And yet Winamp renders it correctly.

Basically, at some point we should be throwing away this region.txt, but when? To test we should check the following:

Can you define a 1 or 0 point polygon as part of an otherwise valid region.txt

In the mean time, I think we'll just ignore polygons with fewer than three sides.

created time in a month

more