profile
viewpoint
David Calavera calavera Sunnyvale, CA

push eventcalavera/slack

David Calavera

commit sha a3f0a90c41a3b789cd60688e9bdadadecb8240e6

Parse slash command from url.Values This allows implementations to not rely on http Requests. This is useful for environments like AWS Lambda where you don't get an http.Request object.

view details

push time in 5 days

fork calavera/slack

Slack API in Go

fork in 5 days

issue commentdropbox/goebpf

Perf events was supported?

Hi @belyalov, is there a branch that people can see with the initial implementation?

I was wondering the same thing this morning. I'll be more than happy to help if it's blocked or you don't have much time to focus on it right now.

annp1987

comment created time in 5 days

push eventnetlify/actions

Brian Douglas

commit sha 5bd95bb059a209d2ac0e5db685462031ccceb6bc

show example in the docs

view details

Brian Douglas

commit sha ea13c3fa5184ce735f6738643b4ac43f383016c0

Update README.md

view details

David Calavera

commit sha a34a07203368d0c554b7d9425cba71b99b40d3f8

Merge pull request #17 from bdougie/patch-1 show example in the docs

view details

push time in 8 days

PR merged netlify/actions

show example in the docs

What is this?

I know this was an Action ship during the v1 launch. I am actually using this for a project and considering using this in some example content the GitHub Actions feature.

+15 -0

0 comment

1 changed file

bdougie

pr closed time in 8 days

pull request commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

@zwoop maybe this should be in the "What's new" section in the release? if it's not already.

calavera

comment created time in 8 days

delete branch netlify/trafficserver

delete branch : graduate_server_push_api

delete time in 8 days

delete branch netlify/trafficserver

delete branch : reverse_debug_specific_check

delete time in 9 days

startedtikv/tikv

started time in 10 days

issue openedapache/trafficserver

Very poor performance when diags.debug is enabled

We've ran some benchmarks and the difference between having diags.debug enabled or not is abysmal. You can easily reproduce, the numbers in the screenshot below are from running h2load on my local machine:

h2load --h1 -t 40 -D 60 -n 10000 -c 40 http://localhost

Screenshot from 2019-11-06 15-30-07

Being able to see debug logs is critical in trace issues in development, we use them extensively, and this drop in performance is a big issue for us:

created time in 10 days

create barnchnetlify/trafficserver

branch : rw_lock

created branch time in 10 days

PR opened apache/trafficserver

Reverse debug specific check.

debug_flag && diags->on() is almost an atomic operation, while is_debug_tag_set requires Diags to run a regular expression.

When debug_flag is set to 1, we always want to print the debug log, regardless of whether the tag is set or not, which makes the is_debug_tag_set check useless, and expensive.

This change flips the conditional to check if debug_flag is 1 first, skipping the tag check if it is.

+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchnetlify/trafficserver

branch : reverse_debug_specific_check

created branch time in 10 days

push eventnetlify/trafficserver

Phil Sorber

commit sha 5083cf97b9ab6a910c288e745e0569d4c3d02f19

Issue #4294: Handle return value of SSL_write() properly.

view details

bneradt

commit sha 452d60ea7878b202e45b297083641ed3968fc3fb

Adding an autest for traffic_dump.

view details

bneradt

commit sha 85c0cd449d8ebe5e4c14b2263c4bac076607f35d

Fixing include synopsis rendering for API docs. I noticed the include synopsis renders incorrectly for multiple includes. The method we're using for them is incorrect, even for a single include, but demonstrates itself as incorrect when there are multiple. The problem can currently be seen here: https://docs.trafficserver.apache.org/en/latest/developer-guide/api/functions/TSAPI.en.html I'm applying the solution which was already implemented here: https://raw.githubusercontent.com/apache/trafficserver/fa10c20b8ed43072fd7e214c62b195b525f24d8e/doc/developer-guide/internal-libraries/buffer-writer.en.rst

view details

Leif Hedstrom

commit sha bbcffa075ede77058dbb713d8c9bc42e2f0f9e81

Removes the records.config.shadow alternative config file In addition, cleans up the usage and definitions of "records.config".

view details

Sudheer Vinukonda

commit sha d22de244f665237ec68346691ef8bb455bcde356

Add Metrics to track SSL Handshake attempts Remove debug logs

view details

Randall Meyer

commit sha 51961cb54d448c94127028171c297ba3a40793db

Remove never implemented HttpTransact::service_transaction_in_proxy_only_mode HttpTransact::service_transaction_in_proxy_only_mode was part of the original import with a TODO to implement. This was never done. Also remove proxy.process.http.throttled_proxy_only as it was only incremented in a code path never executed.

view details

Leif Hedstrom

commit sha 4f8cb034fb01e8f6048331d2009afd9cb2550d2b

Updated to clang-format v9.0.0

view details

Bryan Call

commit sha b9505198cac1dd1a1a78dc4e39e6befefc127991

Cleaned up the changelog command for making our release notes

view details

Susan Hinrichs

commit sha bad68b5280d46935d2ef88079a8259ac43878e2a

Remove remnants of http/1.1 pipeline logic.

view details

David Calavera

commit sha 3fdcf70c828cb05b402c554c6ad5405248dfa9eb

Move TSHttpTxnServerPush to the stable API interface. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 35a1b323f3e5be3cd8bfaa0930d269a100c17999

Promote server_push_preload plugin. Move this plugin out of experimental at the same time that the API is promoted. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 7fbf421edf0395ea6c0f93ca9d16be3eb7633fb4

Change API to return a TSReturnCode code. Return a TS_ERROR when we cannot push the url to the promise table. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 11 days

issue commentapache/trafficserver

Plugin memory leak with TSMutexCreate

I just checked, and neither the 8.0.x branch nor the 7.1.x branch have this change:

https://github.com/apache/trafficserver/commit/d846436ab22ea8c0283bd7656d2305974e79f8d1#diff-51c2386548dfd5af5047991b7b69edb0

I don't know if the solution is to revert that change, or the problem is more systemic than that.

traeak

comment created time in 11 days

pull request commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

@sudheerv rebased :raised_hands:

calavera

comment created time in 12 days

push eventnetlify/trafficserver

Fei Deng

commit sha 8dc7cce1b8f5c0e303fe87c58de65cc5256ea555

a general autoconf cleanup

view details

Fei Deng

commit sha 752f5e68e7ebdbd8f505ba253a85bb7e33e7fef8

add some documentation to the action class to avoid confusion

view details

Valentin Gutierrez

commit sha 757256129811441f29eea288b1d7e19bc54fab9c

Cache SSL EC explicitly

view details

Masaori Koshiba

commit sha 0ee48a0ccb064226215385bd359d3d6907d97595

Cleanup: do not re-define _proxy_ssn variable in local

view details

Aaron Canary

commit sha 3a44862d203571443672f089c7f294ba81f18e6b

ProxySession cleanup: moving inline functions to .h moving non-virtual, one-liner functions to the .h with "inline" keyword.

view details

Masakazu Kitajo

commit sha cbc46ac4570ac034189d83de4e28c4b495545737

clang-analyzer: Add a null check

view details

Masakazu Kitajo

commit sha 482e30accbe2e755c73fd1f8dd7e4b2c40705171

Destroy MIMEFieldBlockImpl that doesn't have fields in use Because MIMEFieldBlocks are destroyed only when MIMEHdr is destroyed, the block chain never be short. With this change, a block will be destroyed when all fields in a block are deleted, and the block will be removed from a block chain.

view details

bneradt

commit sha c498f05fef01c00846e4817047f166f66aae27a6

Fix our doc build system to handle non-source dir configure locations.

view details

Vijay Mamidi

commit sha 9ca5abc19a89ca518049921dd9cd827268cb22a0

Mark host as partial when subdmains are more than default table depth

view details

Fei Deng

commit sha cd1485435bd5c5e52110149881d8bb07a8dad988

do not reload configs periodically

view details

Leif Hedstrom

commit sha a591c953a10a89e3b7bd0df21060e5acf6d0e1f3

These are the current settings we're running on docs

view details

Alan M. Carroll

commit sha 03aee4ce6faa2ce142b83216186151010fd13a23

Fix dynamic update for conntrack (HttpConnectionCount) configuration variables.

view details

Susan Hinrichs

commit sha 54b8caf6f5b1ddb7b6100d13af6377853bfac489

Fix TSHttpTxnReenable to schedule back to original SM thread

view details

Masakazu Kitajo

commit sha a80d779480e51c61e82d36f8e152d8d3ffa2367c

Add QUIC draft-23 support Squashed commit of the following: commit 8aab554452ee9f9f770b2406b0df0d033eaae8e0 Merge: fa823387f 32b5dae81 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Oct 8 15:14:18 2019 -0700 Merge branch 'master' into quic-latest * master: Add filename to error message in header_rewrite Turn on certificate verification, in permissive mode for now Concurrent SRV request failures Fix use-after-free problem related to logging headers ssl_multicert.config -> params->configFilePath Adds build targets on CI for 9.0.x weak mutex macros Fix a build issue on enabling FIPS Change the ready checks for ats to use the actual ats port and not the server port. Add ready check on server port for the server Address possibe use after free issue in HttpVCTable::remove_entry YAML config: output erroneous keyword and line number in YAML file it appears on in diags.log. Convert old sni configuration file in lua to yaml First cut at a layout for Release Notes Clear api set bit to avoid crash in following redirect. commit fa823387f81aefe42cabf5a449977dc861b90587 Author: scw00 <scw00@apache.org> Date: Fri Sep 27 14:04:31 2019 +0800 QUIC: Fix test_QUICKeyGenerator commit e62f4af7a3ee6978986cbd490875286ce1fa2730 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 16:35:07 2019 +0900 Fix a compile warning commit 887732b49527b4266b4b7956db3f627355b3bd14 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 13:01:15 2019 +0900 Update initial salt commit c2b9be3a83919b0c863e2d5880956aaf2096e3a7 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 10:16:20 2019 +0900 Update QUIC transport error codes commit 9d843ebf6e9399ff4dabd62952d7dc6a98f65f93 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:58:26 2019 +0900 Rename DISABLE_MIGRATION to DISABLE_ACTIVE_MIGRATION commit d1951e98e86702f0769947c7541f64aed2045962 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:54:22 2019 +0900 Update the length of unpredictable bits field in Stateless Reset Packet commit 617dd31a7bd904d839abc4fde50eb3f5280ce1e9 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:51:47 2019 +0900 Update draft version numbers to 23 commit 2e78599cc634a85f9552f22132bfbdd084319391 Merge: 212fdd319 70de21d9c Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 10:24:45 2019 +0900 Merge branch 'master' into quic-latest * master: (23 commits) Rearrange config reload notifications Removed hardcoded sni.yaml configuration filename in logs Clarify docs on the change from redirect_enabled. Make code buildable with BoringSSL Fix debug output for global_user_agent_header. Add documentation for TSHttpTxnRedoCacheLookup Add example plugin to show how to use TSRedoCacheLookup. TSHttpTxnRedoCacheLookup. Fix reference to SMDebug. adding TSHttpTxnRedoCacheLookup Add AUTest using h2spec Track scheduled events to (read|write)_vio.cont from Http2Stream Cleanup AuTest for HTTP/2 Fix AuTest for HTTP/2 using httpbin Add base64 encoding/decoding to encryption/decryption, and general code cleanup. Update documentation for connect_attempts_timeout. Track SSL session cache evictions performed due to full bucket Perform a SSL quiet shutdown when close-notify is not sent Remove hard coded filename in error message Substitution string has changed ... commit 212fdd3198a846eca22e7bbe73a0765c3e4782ee Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 10:20:28 2019 +0900 Fix unit tests commit 6f470fa831d4401bc85703ad233218e535df9d90 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Sep 26 17:36:39 2019 +0900 Fix build issues on macOS (or clang) commit a786041f3e27d34d009636a781cf3bd6972f0882 Author: scw00 <scw00@apache.org> Date: Thu Sep 19 08:29:25 2019 +0800 QUIC: Remove useless default constructor in QUICStreamManager commit edc4b672b98e38dd95f6d9a80e271e999cd3297a Author: scw00 <scw00@apache.org> Date: Tue Sep 17 14:03:14 2019 +0800 QUIC: Rename QUICCongestionController.cc to QUICNewRenoCongestionController.cc commit 45c3f138633466f2bc31dd45bbd617b00e14938b Author: scw00 <scw00@apache.org> Date: Wed Sep 11 14:09:34 2019 +0800 QUIC: Remove unnecessary allocator commit 256a74c54f93cf86cd7fc8d866f195b23df2f2f0 Author: scw00 <scw00@apache.org> Date: Wed Sep 11 11:30:04 2019 +0800 QUIC: Add Token Creator commit 5980fa47083aca5df6d4f04e388ddab5344cdd2b Author: scw00 <scw00@apache.org> Date: Mon Sep 9 15:24:23 2019 +0800 QUIC: add more infomation to QUICPacketProtectionKeyInfo commit 814f39e8269d8c19064b698825c2b9441c9eacb5 Author: scw00 <scw00@apache.org> Date: Mon Sep 9 12:32:20 2019 +0800 QUIC: Hidden more pp_key_info detail in QUICContext commit fecacfbd973b7c5e3b10c21e94fdfff4300768e5 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 14:33:52 2019 +0900 Stabilize unit tests commit e8565bbee89663a1c89b4052c0fc32ea80bccfb6 Author: scw00 <scw00@apache.org> Date: Wed Aug 7 10:55:54 2019 +0800 QUIC: Adds QUICContext to wrap some common params commit 5b04932d62ff66602923c7e63250660fd0992e84 Merge: 5c7b68a0d 92d4ef142 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 6 11:16:38 2019 +0900 Merge branch 'master' into quic-latest * master: Check F_GETPIPE_SZ is defined to fix macOS build Update Server IP in Transaction when attaching a session from the pool Add unit tests for MIOBuffer:write() Allow disabling HTTP/2 priority frames limit Add implementation for TextView::rtrim(char const*) Doc: Guide to remap plugin API. Add helper functions to apply api timeouts consistently. address review comments pipe buffer size for log.pipe should be configurable Provide stats for the recently introduced HTTP/2 rate limits commit 5c7b68a0d337fefaf1d4cdde31574c0ab9144034 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Sep 4 14:40:30 2019 +0900 Send PreferredAddress only if necessary commit 2b5e2ce18e6367f142f2acad345489716486660a Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 17:04:27 2019 +0900 Fix memory leaks detected by ASAN commit 13bdd9d05f5348c0aaa37f7669f1fa425c434503 Merge: e7430fabb c65f0a1fb Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 14:12:38 2019 +0900 Merge branch 'master' into quic-latest * master: (30 commits) Cleanup: Remove unused AllocType and unused functions Ran clang-format ProxySsn renaming member vars cachekey: added --key-type (for parent selection) Bumped the version of master to 10.0.0 ProxySsn Refactor move code to cc 1) add autest for log filter; 2) support filter for duplicated param name in query parm of URL code clean from review comments move code to utility function to reduce the interface size fix typo issue fix the bug if filter word included in param value fix the bug if filter word included in param value correct the size of DNS buffers cachekey: added --canonical-prefix parameter static linking asan, tsan, lsan Fixed const issue with magick plugin CI: added support for disabling curl in the build Adds the v9.0.x Docs link to main docs page Updates the CI build scripts, adds QUIC support Expose client SSL stats via API & Lua ... commit e7430fabb29f91bf6d146834d7eb5ba867b130a0 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 14:07:01 2019 +0900 Fix QUICPinger and tests for it commit f040d5fa7bcb170d054d5f0773a7aba38312bd3b Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 12:33:26 2019 +0900 Print a raw value of unknown transport parameter commit 13f9f63aef7e8b76d5aa11048d29112ccfaae533 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Aug 27 14:25:00 2019 +0900 Use active_connection_id_limit advertised commit 0e4622e62613fd8b7b9a8d65e2613131a7d1d9c6 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 22 16:38:38 2019 +0900 Assert sending a frame that is allowed on the encryption level commit 72b1f79c0af422a1e383d7becf370a580bcfd159 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 22 16:23:53 2019 +0900 Send PING only on Short packets commit e7a6cd6292ba54b6804b79298188e7042a73577a Merge: 3c8e6d12f 5886fb212 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Aug 21 11:42:41 2019 +0900 Merge branch 'master' into quic-latest * master: Fix inactivity timeout on QUIC Cleanup: Remove unused empty files Cleanup: unifdef WRITE_AND_TRANSFER Explain how SRV origin selection works Doc: fix build errors. HTTP/2 fix with realloc Fix clang-tidy's mistakes Ran make clang-tidy Updated clang-tidy configuration, scripts, and Makefiles Make proxy.config.http.per_server.min_keep_alive_connections overridable Make TS_NULL_MLOC a valid C compile-time constant. Doc: Remove python 2 vestiges from conf.py, traffic-server.py. Conflicts: iocore/net/QUICNetVConnection.cc commit 3c8e6d12f9335dc7b55ca45dafb21fc4c3c3c0b8 Merge: 7a9d7fd63 aa319a461 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Aug 19 09:29:44 2019 +0900 Merge branch 'master' into quic-latest * master: (48 commits) Fix H2 internal counters Reactivate active timeout enforcement Avoid AWS auth v4 path/query param double encoding Fix QUIC build Cleanup: Signal READ_READY event only if the buffer is readable Cleanup: Remove unused function & old comments Make client_context_dump test resilient to dump order changes Record HttpSM Id on new transaction make check race condition fix Doc: Improve handling of build when documentation is not enabled. fix. Limit resources used by regex_remap to prevent crashes on resource exhaustion. compress plugin: document undocumented options Allocate DependencyTree only if HTTP/2 stream priority is enabled HTTP/2 rate limiting Fixes various issues found in docs Remove double call of the SNI action on TLS accept. Refactor the alpn/npn handling into common ALPNSupport class Update for QUIC integration. Fixed the InkAPI to provide the TSVConnProtocolEnable/Disable functions. Update documentation and updated the example plugin. ... commit 7a9d7fd633dfdcd8a931dbbf35b76fa590707581 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Aug 16 11:56:12 2019 +0900 fix typo commit 5b5efeccb23e88b25e7b644a4a828208679f6416 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Aug 5 11:08:49 2019 +0900 Print sending Retry packets commit d222be218ef38f3f26e8a68b64f691b984f10799 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Aug 2 09:32:09 2019 +0900 Min/Max length of PreferredAddress commit fb350263dc0b8cc73d557c8ed1220afccfb9b244 Merge: 4938b7f85 e068b7685 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 16:57:48 2019 +0900 Merge branch 'master' into quic-latest * master: Add support for updating Container fields as well Preserve the raw log fields when wiping using case insensitive contains Add soft limit for HTTP Request URI and Header field length. Add a default body_factory template when rejecting a request that's too long Doc: Minor typo in CONTRIBUTING.md Add QUIC draft-20 support Initialize EventIO fixed datatype in example plugin Cleanup debug logs around SSLWriteBuffer Remove unnecesary function name on debug logs in SSLNetVConnection TS API - Adds the TSHttpTxnNextHopNameGet() function. Conflicts: .gitignore iocore/net/P_QUICNetVConnection.h iocore/net/QUICNetVConnection.cc iocore/net/QUICPacketHandler.cc iocore/net/quic/Makefile.am iocore/net/quic/Mock.h iocore/net/quic/QUICAckFrameCreator.cc iocore/net/quic/QUICAckFrameCreator.h iocore/net/quic/QUICAltConnectionManager.cc iocore/net/quic/QUICAltConnectionManager.h iocore/net/quic/QUICBidirectionalStream.cc iocore/net/quic/QUICBidirectionalStream.h iocore/net/quic/QUICConfig.h iocore/net/quic/QUICCongestionController.cc iocore/net/quic/QUICCryptoStream.cc iocore/net/quic/QUICCryptoStream.h iocore/net/quic/QUICDebugNames.cc iocore/net/quic/QUICFlowController.cc iocore/net/quic/QUICFlowController.h iocore/net/quic/QUICFrame.cc iocore/net/quic/QUICFrame.h iocore/net/quic/QUICFrameDispatcher.cc iocore/net/quic/QUICFrameDispatcher.h iocore/net/quic/QUICFrameGenerator.cc iocore/net/quic/QUICFrameGenerator.h iocore/net/quic/QUICHandshake.cc iocore/net/quic/QUICHandshake.h iocore/net/quic/QUICKeyGenerator.cc iocore/net/quic/QUICLossDetector.cc iocore/net/quic/QUICLossDetector.h iocore/net/quic/QUICPacket.cc iocore/net/quic/QUICPacket.h iocore/net/quic/QUICPacketFactory.cc iocore/net/quic/QUICPacketFactory.h iocore/net/quic/QUICPacketHeaderProtector.cc iocore/net/quic/QUICPacketReceiveQueue.cc iocore/net/quic/QUICPacketReceiveQueue.h iocore/net/quic/QUICPathValidator.cc iocore/net/quic/QUICPathValidator.h iocore/net/quic/QUICPinger.cc iocore/net/quic/QUICPinger.h iocore/net/quic/QUICStreamManager.cc iocore/net/quic/QUICStreamManager.h iocore/net/quic/QUICTransportParameters.h iocore/net/quic/QUICTypes.cc iocore/net/quic/QUICTypes.h iocore/net/quic/QUICUnidirectionalStream.cc iocore/net/quic/QUICUnidirectionalStream.h iocore/net/quic/test/test_QUICAckFrameCreator.cc iocore/net/quic/test/test_QUICFlowController.cc iocore/net/quic/test/test_QUICFrame.cc iocore/net/quic/test/test_QUICFrameDispatcher.cc iocore/net/quic/test/test_QUICInvariants.cc iocore/net/quic/test/test_QUICKeyGenerator.cc iocore/net/quic/test/test_QUICLossDetector.cc iocore/net/quic/test/test_QUICPacket.cc iocore/net/quic/test/test_QUICPacketFactory.cc iocore/net/quic/test/test_QUICPacketHeaderProtector.cc iocore/net/quic/test/test_QUICStream.cc iocore/net/quic/test/test_QUICStreamManager.cc iocore/net/quic/test/test_QUICType.cc mgmt/RecordsConfig.cc src/traffic_quic/quic_client.cc src/tscore/ink_inet.cc commit 4938b7f854cb06411d6fd061bdbde28a53074103 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 14:21:50 2019 +0900 Make QUICFrame:to_io_buffer_block pure virtual commit baaf97c51637116fcdd1ba3bf475788115c8662c Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 14:04:13 2019 +0900 Convert QUICAckFrame::store to to_io_buffer_block commit ad565245ed077205a6955a77d3250e2a39f5775b Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:21:42 2019 +0900 Convert QUICUnknownFrame::store to to_io_buffer_block commit 9cb75727328f8f02d9938a056ec5f5ac6091374c Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:15:30 2019 +0900 Convert QUICRetireConnectionIdFrame::store to to_io_buffer_block commit cc452b953d0cfb00be3abee374a99251d3139889 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:06:40 2019 +0900 Convert QUICNewTokenFrame::store to to_io_buffer_block commit 748d66cfad7e7181bd7b1aa50ebb9bed51f00b81 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 11:50:25 2019 +0900 Convert QUICCryptoFrame::store to to_io_buffer_block commit 2b38e5f88289a4e7d590d767c2b7c9a1942a184a Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:27:51 2019 +0900 Convert QUICPathResponseFrame::store to to_io_buffer_block commit e0f2c609212a617ae59ce0346dc9327a83421cc6 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:18:23 2019 +0900 Convert QUICPathChallengeFrame::store to to_io_buffer_block commit edd2963e2e0b12f6e14364bd5cdd4473e1804600 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:10:00 2019 +0900 Convert QUICNewConnectionIdFrame::store to to_io_buffer_block commit 93b79fb2e6386ce840130b08f46c8e58e56ffd2d Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:52:38 2019 +0900 Convert QUICStreamIdBlockedFrame::store to to_io_buffer_block commit d3b5ea831572403b037bba8585fa592acb585d14 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:44:58 2019 +0900 Convert QUICStreamDataBlockedFrame::store to to_io_buffer_block commit a1390e86c95fffc8e62f7c4ea471e77bddd6554b Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:40:27 2019 +0900 Convert QUICDataBlockediFrame::store to to_io_buffer_block commit f419cd9752aa1312454fe819a08e0516f90a3ba2 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:32:35 2019 +0900 Convert QUICPaddingFrame::store to to_io_buffer_block commit 6f5da6078bcb76cd1f0aabfc7c38defe7886e5d2 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:23:10 2019 +0900 Convert QUICMaxStreamsFrame::store to to_io_buffer_block commit 08501a8886e35241ca08ed9cd558e6dce5a18735 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:18:21 2019 +0900 Convert QUICMaxStreamDataFrame::store to to_io_buffer_block commit ac4a732c6f3f574f0558895b708bd557b50b95ce Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:13:36 2019 +0900 Convert QUICMaxDataFrame::store to to_io_buffer_block commit d996d4bcab89786783b9b4065c3ccf5ebc1008f0 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:05:08 2019 +0900 Convert QUICPingFrame::store to to_io_buffer_block commit 578772f84d2fcf425ee06b661a5a7b2a655cf6a1 Merge: eb2a9d31c 78995bf4e Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 23 15:03:38 2019 +0900 Merge branch 'master' into quic-latest * master: (46 commits) Add dest addr information to UDPPacket class Update UDPNet for QUIC Add HKDF wrapper Use un-deprecated records for SSL server verification Removes proxy.config.http.cache.allow_empty_doc Deprecate the mysql_remap plugin. See #5395 Removes the stale_while_revalidate plugin. See #5395 Removes the memcached_remap plugin. See #5395 Removes the hipes plugin. See #5395 Removes the header_normalize plugin. See #5395 Removes the buffer_upload plugin. See #5395 Removes the balancer plugin. See #5395 Fixes spelling in lib/records Fixes memory leak in traffic_crashlog Promotes certifier to stable, see #5394 Promotes remap_purge to stable, see #5394 Promotes prefetch to stable, see #5394 Promotes multiplexer to stable, see #5394 Promotes cache_range_requests to stable, see #5394 fix If-Match and If-Unmodified-Since priority problem,about rfc https://tools.ietf.org/html/rfc7232#section-3.3 ... Conflicts: build/crypto.m4 configure.ac include/tscore/HKDF.h iocore/net/P_UDPNet.h iocore/net/P_UnixNet.h iocore/net/UnixUDPNet.cc src/tscore/HKDF_boringssl.cc src/tscore/HKDF_openssl.cc commit eb2a9d31c6c5eca02596181085509aa155126e16 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 12:25:23 2019 +0900 Fix frame parsers for CON_CLOSE, STOP_SENDING and RST_STREAM Error codes were read as 16 bit integers commit 0dc9a3e542734909cd3466b555ecf56461fbd7e7 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 09:43:54 2019 +0900 Fix CONNECTION_CLOSE frame parser commit a62388d1b538e0d2617465928124a4b7573119ef Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 07:36:02 2019 +0900 Set default value for initial_max_stream_data_uni to 4096 http-22 says it should be 1024 or greater. commit 0e46a6bccc582f02d65d4e11c228e423e35508b6 Author: Masaori Koshiba <masaori@apache.org> Date: Mon Jul 22 02:07:32 2019 +0900 Fix storing QUICConnectionId::ZERO commit 5db9a3b1cba535e6dac6664139c953b136e8adcb Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 19 23:39:13 2019 +0900 Update max cid length commit 6e6351e721d784121f40f0f381124d624f7e5a39 Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 15:00:10 2019 +0900 Fix buffer length for VN packet commit bcf842a12a0a9ec67ca1d7e5e95f5c9be6a806ab Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 14:45:59 2019 +0900 Fix stateless retry on server side Prior this change, getting the token filed offset of INITIAL packet was wrong when stateless retry is enabled. commit ab8508b28a48c0653bd9187ce4511cb96d76ec34 Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 11:30:35 2019 +0900 Fix QUICFrame & unit tests for NEW_CONNECTION_ID commit 62f7174c6ec2428218f9b457f9b37a816a622e6a Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 16:26:25 2019 +0900 Add getter for retire_prior_to field commit 3fff0dec8aa7abc8ef34a3a9da50ac3336de06ab Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 16:14:27 2019 +0900 Add Retire Prior To field to sending NCID frames commit 2944fe85c21816ae5bcbeba8199f26c035049f8b Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 15:57:30 2019 +0900 Add tests for static functions of QUICPacketLongHeader commit 1ce476c91cd50e66c916daa1446f7d2480f19604 Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 12:28:55 2019 +0900 Fix getting packet length on dequeue from QUICPacketReceiveQueue commit 142e11e2cd4b6bfc4fb91db9b8fbcbd72123950c Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 11:21:33 2019 +0900 Update to support new RETRY packet format commit 16d7129f14d259d290bbb2b06aa69ecb107ea906 Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 11:00:27 2019 +0900 Fix sampling offset for packet header protection & unit tests commit 6f8682715cb604f838711b9ec6af5ed99db95f16 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 08:56:53 2019 +0900 Fix tests for QUICFrameDispatcher commit c647ed4dac3ca538252857e8674aa3b7ec47dd05 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:20:48 2019 +0900 Fix unit tests for QUICPacketFactory commit f140407023a3377d9c4ce420d4e33f66da735a8e Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:17:47 2019 +0900 Update storing long header packet & unit tests commit 7cc4b20ad7c82f9eaa2bda787897a0a1bb4b0560 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:16:29 2019 +0900 Fix loading long header packet commit c47874c3653191fb90543fbed5d6b734d69fba86 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 14:54:38 2019 +0900 Fix unit tests for QUICInvariants commit 87afcb077642df9c4902c15a7fc42f58b9a5f060 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 16 21:38:00 2019 +0900 Update Long Header CID parser commit 86a4317b4fd2ef19456cf5d231d78c50d99db09d Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 9 17:10:20 2019 +0900 Use variable-length integer for error code fields on QUIC frames commit e105d33d7569739174abffddb89c491e3e729cb0 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 17:10:55 2019 +0900 Make ErrorCode 62 bit unsigned integer commit 13d003757239833d8eff2e94aa387dc2dddb1dff Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 16:40:39 2019 +0900 Update initial_salt commit f0602a6e187e456b85e34b97d4aff6d2be9789ed Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 16:16:42 2019 +0900 Add active_connection_id_limit Transport Parameter commit 923916d7f0bbea19367fdfc7b2ddf430c5a54233 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 4 17:22:48 2019 +0900 Update draft version numbers to 22 commit e95f03599f42743e8774908c9a8d0879f5c59890 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 11 12:40:22 2019 +0900 Fix a heap-use-after-free in path validation commit c444068c28fe1693e056596faf3039ad0adde8e3 Merge: eb4092333 8510a1c24 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 10 11:51:27 2019 +0900 Merge branch 'master' into quic-latest * master: Log H2 errors with the codes Separate out common header compression logic to hdrs directory TSIOBufferReaderCopy: copy data from a reader to a fixed buffer. Remove unused header file ink_inout.h Remove unused LibBulkIO Reverse internal order of HPACK Dynamic Table Entries More Autest cleanup Conflicts: proxy/hdrs/Makefile.am proxy/http2/HPACK.cc commit eb4092333da5734acd9cf6b933a97f6b160c0b14 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 9 09:25:35 2019 +0900 Fix QUICPath::operator== commit 10805ba0dfe346dfbe93dad24656110e6d5fb250 Author: scw00 <scw00@apache.org> Date: Mon Jul 8 10:08:29 2019 +0800 QUIC: remove useless params in padder commit b0f248334200ec10be9d87d8593d7f46b4c88104 Author: scw00 <scw00@apache.org> Date: Mon Jul 8 09:25:28 2019 +0800 QUIC: Add inline generators into QUICFrameGenerator commit b76299f09e128e17d7103ee5ca5c72f3f4f67b22 Author: scw00 <scw00@apache.org> Date: Sun Jul 7 13:20:11 2019 +0800 QUIC: Add QUICPinger test commit fdff5b96f24e0d681884a1553ae1203161e9efaa Author: scw00 <scw00@apache.org> Date: Sun Jul 7 12:21:08 2019 +0800 QUIC: Fix test commit 816305894503400861fc4e830f464c6a3a3b1b41 Author: scw00 <scw00@apache.org> Date: Sun Jul 7 12:07:34 2019 +0800 QUIC: Using weight for QUICFrameGenerators commit 1eeb804564afb7db5164c8db90e6b5bcedd86b3e Author: scw00 <scw00@apache.org> Date: Thu Jul 4 08:58:15 2019 +0800 QUIC: Split QUICFrameGenerator into two queue

view details

Walter Karas

commit sha fd5901331a33d52af51ee97eefc73a614f4a56a3

Minor cleanup of proxy/logging/Log.h .

view details

Susan Hinrichs

commit sha 52944ce144d1de64ae31509f0e94745957af8bdd

Update TSVConnSslConnectionGet name to match others in the TSVConnSsl* family

view details

Zizhong Zhang

commit sha 08089103e05109b978fa5b545b0d35d2a6294b17

make proxy.config.http.request_buffer_enabled configurable and bug fix This PR fixes issue #6021, #6022, #6023

view details

Brian Olsen

commit sha b271b85aa64784e507c55697aabd0a2118480c9a

url_sig: fix memory leak with urlParse and pristine flag

view details

Susan Hinrichs

commit sha 26a51a0fb22095e0befc461c53691d3d0dd2d948

Revert "Optimize: If failed on migrateToCurrentThread, put the server session back to global server session pool" This reverts commit c776c6677b0c005dd511945ae023a14f8f6b0bc3. Conflicts: iocore/net/UnixNetVConnection.cc

view details

Gancho Tenev

commit sha db8cd14acede7460a5996864c52e1b206695e405

cachekey: allow multiple values for `--key-type` Allow multiple target types to be specified for `--key-type` so the operator can apply the same modifications to both cache key and parent selection url at the same time without chaining cachekey plugin instances. Instead of: @plugin=cachekey.so \ @pparam=--key-type=parent_selection_url \ @pparam=--remove-all-params=true @plugin=cachekey.so \ @pparam=--key-type=cache_key \ @pparam=--remove-all-params=true to write: @plugin=cachekey.so \ @pparam=--key-type=parent_selection_url,cache_key \ @pparam=--remove-all-params=true

view details

push time in 12 days

delete branch calavera/rutie

delete branch : send_sync

delete time in 12 days

delete branch calavera/docker

delete branch : gender_unbiased_names

delete time in 16 days

PR opened danielpclark/rutie

Implement Send+Sync for rb data types.

Rutie fails to compile on Rust's beta channel because these data types don't implement Send and Sync.

Signed-off-by: David Calavera david.calavera@gmail.com

+12 -5

0 comment

1 changed file

pr created time in 16 days

create barnchcalavera/rutie

branch : send_sync

created branch time in 16 days

delete branch calavera/rutie

delete branch : send_sync

delete time in 16 days

create barnchcalavera/rutie

branch : send_sync

created branch time in 16 days

delete branch calavera/rutie

delete branch : send_sync

delete time in 16 days

create barnchcalavera/rutie

branch : send_sync

created branch time in 16 days

issue closeddanielpclark/rutie

Invalid build when using Cargo workspaces.

I bumped into an interesting issue with Cargo workspaces.

I have a repository with two Rust libraries, one of them is the "core" library where I have a bunch of shared code. The other library is a ruby gem built with Rutie.

When I put both libraries in the workspace, the generated dynamic library includes a reference to libstd, which cannot be resolved in my system because I don't have anything set in LD_LIBRARY_PATH. That dynamic library won't work when it's loaded by the Ruby bindings.

ldd ../target/release/libtraffic_mesh_ruby.so 
        linux-vdso.so.1 (0x00007ffde239e000)
        libstd-4a76ff35a356aedf.so => not found
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0967c25000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0967a06000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f09677ee000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f09673fd000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f096705f000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f09685eb000)

If I put the "core" inside the workspace, but I exclude the Rutie library, the dynamic library generated doesn't include the reference to libstd and it works (as far as I can tell, I still have to add tests to the ruby part).

ldd target/release/libtraffic_mesh_ruby.so 
        linux-vdso.so.1 (0x00007ffdf47fe000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fbd0485a000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fbd04652000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbd04433000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fbd0421b000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbd03e2a000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fbd052ff000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fbd03a8c000)

So the workaround to solve this problem is to have the Rutie library in the Cargo workspace like this:

[workspace]
members = ["core"]
exclude = ["ruby-lib"]

I'm not familiar with the build toolchain, but I'd expect to be a better solution to this problem.

closed time in 16 days

calavera

issue commentdanielpclark/rutie

Invalid build when using Cargo workspaces.

It looks like the real issue is this: https://github.com/rust-lang/rust/issues/46369. I tested my project using cdynlib and it creates the object correctly with both projects in the workspace.

calavera

comment created time in 16 days

push eventcalavera/rutie

Dan Larkin

commit sha 3b557dcf353b5de254014b16d265fe3932bf3eff

add "no-link" cargo feature

view details

Dan Larkin

commit sha 6db74585735ca82894d6163357ee4defdc2cdc61

Merge branch 'no-link-cargo-feature'

view details

push time in 16 days

issue commentapache/trafficserver

Plugin memory leak with TSMutexCreate

We use stats_over_http a lot. It'd be a stopper for us to migrate to 9.0. I'm not familiar with the code enough to even start thinking on how to fix this issue :pensive:

traeak

comment created time in 16 days

pull request commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

Are we sure that the return code (TS_SUCCESS and TS_ERROR) based on whether it added an url to the table satisfy user needs?

After looking all the few possible error paths, I believe that failing silently is worse than returning errors. At least, it gives the user the possibility to do something about it instead of hiding possible issues from them.

calavera

comment created time in 17 days

Pull request review commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

 is not disabled by the client. You can call this API without checking whether Server Push is available on the transaction and it does nothing if Server Push is not available. --Notes-=====--This API may be changed in the future version since it is experimental.+This API returns an error if the URL cannot be added to the push table.

That's fair. I've changed that line to be more descriptive without referring to internal terms.

calavera

comment created time in 17 days

push eventnetlify/trafficserver

David Calavera

commit sha f1dbc39f18ab917ffd9017d360871fa083ee92ae

Change API to return a TSReturnCode code. Return a TS_ERROR when we cannot push the url to the promise table. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 17 days

push eventnetlify/trafficserver

David Calavera

commit sha 4953ba8d4e5c70865b61a5580175fbbf1e94013e

Change API to return a TSReturnCode code. Return a TS_ERROR when we cannot push the url to the promise table. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 18 days

push eventnetlify/trafficserver

David Calavera

commit sha de3dd9d1f8659ad26d3008d2738bd43bd59f9331

Change API to return a TSReturnCode code. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 18 days

pull request commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

@bryancall @sudheerv @maskit I made a small change here to return a TSReturnCode code. I can squash all commits into one of you all are ok with these changes.

calavera

comment created time in 18 days

push eventnetlify/trafficserver

David Calavera

commit sha 55bfec1a0717abe9ed8b64ce0bc15658fc7aa11b

Change API to return a TSReturnCode code. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 18 days

fork calavera/rust-openssl

OpenSSL bindings for Rust

fork in 22 days

startedtshlabs/cadence

started time in a month

issue commentdanielpclark/rutie

Invalid build when using Cargo workspaces.

I think it's unexpected that putting both projects in a workspace the shared object is not valid anymore. This workaround also creates two target directories, which is not ideal.

calavera

comment created time in a month

pull request commentapache/trafficserver

TLSv1.3 0-RTT support

this feels like it should be a directive in sni.yaml

@zwoop we don't use sni.yaml for anything. Do you mean that it should be an optionally configurable there?

duke8253

comment created time in a month

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 6e3503ff38c56cbe2596e1e92ef3d8b95e3d3c0c

remove linqia Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in a month

push eventcalavera/vegandollhouse.com

David Calavera

commit sha bd4cdb202a51681aca2fe532e66bffeef17b45b9

fix image src Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in a month

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 6b08d5a4c208ad9d5cf4ed61a2cb00131e02c6f9

Show pinterest save buttons in recipes. Add pin-media to the pin shortcode. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 3950639a6935f0b8f76843802744a822af733f21

migrate images to pin Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in a month

issue commentapache/trafficserver

SSL_read_early_data for 0-rtt TLSv1.3?

I think this could be a good future improvement:

Furthermore, Cloudflare can uniquely identify connection resumption attempts, so we relay this information to the origin by adding an extra header to 0-RTT requests. This header uniquely identifies the request, so if one gets repeated, the origin will know it's a replay attack.

Here’s what the header looks like:

Cf-0rtt-Unique: 37033bcb6b42d2bcf08af3b8dbae305a

The hexadecimal value is derived from a piece of data called a PSK binder, which is unique per 0-RTT request.

Generally speaking, 0-RTT is safe for most web sites and applications. If your web application does strange things and you’re concerned about its replay safety, consider not using 0-RTT until you can be certain that there are no negative effects.

From Cloudflare's blog post: https://blog.cloudflare.com/introducing-0-rtt/

shinrich

comment created time in a month

issue commentapache/trafficserver

SSL_read_early_data for 0-rtt TLSv1.3?

I found this piece of information in Cloudflare's blog post interesting for future improvements:

shinrich

comment created time in a month

Pull request review commentapache/trafficserver

TLSv1.3 0-RTT support

 HttpTransactHeaders::is_method_idempotent(int method)           method == HTTP_WKSIDX_HEAD || method == HTTP_WKSIDX_PUT || method == HTTP_WKSIDX_OPTIONS || method == HTTP_WKSIDX_TRACE); } +bool+HttpTransactHeaders::is_method_early_data_safe(int method)+{+  return (method == HTTP_WKSIDX_GET || method == HTTP_WKSIDX_HEAD);

from a customer point of view, it's better to follow the standard. We get questions every now and then about why our H/2 implementation is not fully compatible with the standard.

duke8253

comment created time in a month

PR opened apache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

We learned in the Fall Summit 2019 that this API is being used in production quite heavily in certain fruit company.

It would make sense to move this API and the plugin that's in experimental to the stable API section in ts.h.

In this change, I also modified the server_push_preload plugin to be able to load it as a RemapPlugin, since it was only a global plugin until now.

+77 -28

0 comment

9 changed files

pr created time in a month

create barnchnetlify/trafficserver

branch : graduate_server_push_api

created branch time in a month

delete branch calavera/ats-summit-demo

delete branch : demo

delete time in a month

push eventcalavera/ats-summit-demo

David Calavera

commit sha 050c09712d5d2e1108dcba001c009c92280e33e2

spanish Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 6d8532cf8a3610f3b12aee3aad4a5320bed0257f

Merge pull request #1 from calavera/demo spanish

view details

push time in a month

PR merged calavera/ats-summit-demo

spanish
+1 -0

0 comment

1 changed file

calavera

pr closed time in a month

PR opened calavera/ats-summit-demo

spanish
+1 -0

0 comment

1 changed file

pr created time in a month

create barnchcalavera/ats-summit-demo

branch : demo

created branch time in a month

create barnchcalavera/ats-summit-demo

branch : master

created branch time in a month

created repositorycalavera/ats-summit-demo

created time in a month

push eventnetlify/trafficserver

Leif Hedstrom

commit sha b1ceba7cc9f64a5f77abba21786911e8f712d6fe

First cut at a layout for Release Notes (cherry picked from commit 8a558cb9dd6775a04f4d23782228f596aeb80cee) Conflicts: doc/developer-guide/api/functions/TSHttpTxnRedoCacheLookup.en.rst

view details

Leif Hedstrom

commit sha fc9f1260b38ca7c1c50ad330fdfeda79d0ad9d98

Change the version to v9.x for this doc set

view details

Susan Hinrichs

commit sha 5083a8a9f5cdd166e7c7776e18c8dd0a998fbc12

Update documentation for connect_attempts_timeout. (cherry picked from commit 13b623775247fc76f93081ec0813075b9ff91e7c)

view details

Masaori Koshiba

commit sha 264ec459cf34ee872f9430e096c097e56d6aa678

Cleanup: VIO - No logical changes - Remove unnecessary include headers - Fix format - Make const functions (cherry picked from commit dc0fb99bab960026ba842210ec16fab4f4701e65)

view details

Masaori Koshiba

commit sha ab8996cade8df54e1450f2dd6285327aac3e7a66

Cleanup AuTest for HTTP/2 (cherry picked from commit 76cadf55ece2253c0ddf01a172c57c346f8cd89a)

view details

Masakazu Kitajo

commit sha 4cf8ff44df137b9e3ebf3b373be9051553907fdf

Make code buildable with BoringSSL Checked with the latest code f7b830d8df9f5578c748aa0283d44c59ea7eeb25 (cherry picked from commit 6c0eb634b5082532b52272a8d3d7e7905f74d00c)

view details

Masaori Koshiba

commit sha 95a2ce7a36e5cd965d9e0e7b20adde31ee8da654

Fix AuTest for HTTP/2 using httpbin (cherry picked from commit 2e15c6541e973ad6e45e1daf92549f7b5c47eccb)

view details

Valentin Gutierrez

commit sha ddba8b5895ec47bf217931e98f4930ccfb8dcbbb

Track SSL session cache evictions performed due to full bucket (cherry picked from commit a62e5f98763bd29bf68318cb55a2ddc1ec189a1b)

view details

Masaori Koshiba

commit sha 1013eb3b1486447a93588fd876ae80fc6deadea8

Track scheduled events to (read|write)_vio.cont from Http2Stream (cherry picked from commit 9bd2fd6f0264bfe2176895531f8348fea20f84fa)

view details

Valentin Gutierrez

commit sha 42f158f4ef6c8f1f328a4e00d4beae3cdace320a

Perform a SSL quiet shutdown when close-notify is not sent (cherry picked from commit acf2fb7519bb0ed3820d3f798178903341d0678f)

view details

Bryan Call

commit sha fcd64520dda8cbf80d3523036e87bdb786949512

Remove hard coded filename in error message (cherry picked from commit b564fc4fc648365f47b3d711bbd9349cb5dc2998)

view details

Alan M. Carroll

commit sha e5459ff2971fe838e119fd81d6f35bc4b2aacfc5

Fix debug output for global_user_agent_header. (cherry picked from commit 71fc9d3c016910f0361997e96d944ffa07734ab0)

view details

Susan Hinrichs

commit sha 4629fd73c2a450005aef60d1b1a6ce3785acdfb0

Clear api set bit to avoid crash in following redirect. (cherry picked from commit b0820c3bfa852596a49092c13cb373651c95964c)

view details

Susan Hinrichs

commit sha a4c04885455477ae7220c0446ad35cb540cee420

Clarify docs on the change from redirect_enabled. (cherry picked from commit eebdabba5c02133fd3ff69cafca3e4790c890cd6)

view details

Bryan Call

commit sha 106d06abf5be083554a68cfdb4220197e2c33abf

Removed hardcoded sni.yaml configuration filename in logs (cherry picked from commit c4ce6357ef42a72a51cbea948c0ae515c2f2750d)

view details

David Calavera

commit sha c9cafed86e98f532b53273d16d85b208735242a5

Add documentation for TSHttpTxnRedoCacheLookup Signed-off-by: David Calavera <david.calavera@gmail.com> (cherry picked from commit 4a19b32446427b98be43fb357ca7ccffbb9d7a86)

view details

Valentin Gutierrez

commit sha 9769e17f2c7f6c69df49e74a9e5bff468d6d4eec

Expose client SSL stats via API & Lua (cherry picked from commit cd92e255380b319e3c3473f14a2209c5487cdbce)

view details

Masaori Koshiba

commit sha 9bd3fad61ed2e7f096f63cefd952aee410cd5e18

Ran clang-format (cherry picked from commit aa58b6eb812319c7cde8be9e8d21ff939f9175f8)

view details

Valentin Gutierrez

commit sha 56659933c36ac3e76fc80f8bcd43166be00330f6

Provide stats for the recently introduced HTTP/2 rate limits Provide stats for the limits introduced by 9c09dbc11 (cherry picked from commit 5ec81125bd70d31f545cf959b65c4e929d26a192)

view details

Valentin Gutierrez

commit sha f9e69ef10b94290a3ce1ed015fc505c68698d14f

Allow disabling HTTP/2 priority frames limit (cherry picked from commit f2ebbcee400c3c91aa789382d7f7243797ed733c)

view details

push time in a month

issue commentapache/trafficserver

ATS 9 crash in OSDNSLookup

@bryancall I think this can be closed now:

https://github.com/apache/trafficserver/pull/5959#issuecomment-535117781

bryancall

comment created time in a month

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 3b3aa61c6aca884fb7c633b34203c0fa3d5ebd1f

sort categories Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha fdc423ff5be463a01197846911efd463c486d7e6

accept subkeys in shortcodes Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha d4a3ae61671a1cfda0a0757d24ed45d6b8c45d92

Add pin shortcode and descriptions. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

delete branch calavera/vegandollhouse.com

delete branch : html_recipe

delete time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 8cc0433e762930181a2b84100fb58c13467d3c3f

Move all recipe markup to the html. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 4e3726fd3d933af448092d01b5de367ef78daef4

use schema.org official name Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha fd380b467508485852e0151ef4add64147288e12

fix person type Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha c829779a74d463b273498b81dea77d13f2615121

Add article meta. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 08aca51afd9071faf4ddb0052e89afd869624a79

add meta attributes Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 71c14d1f2bb19e23f9291bf1beb2b380f09638a2

fix author Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 9efc34ae3be9dddc8c5e41cc2c33bb885ef96030

Merge pull request #9 from calavera/html_recipe Change makrup.

view details

push time in 2 months

PR opened calavera/vegandollhouse.com

Change makrup.
+16 -14

0 comment

3 changed files

pr created time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 71c14d1f2bb19e23f9291bf1beb2b380f09638a2

fix author Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 08aca51afd9071faf4ddb0052e89afd869624a79

add meta attributes Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha c829779a74d463b273498b81dea77d13f2615121

Add article meta. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha fd380b467508485852e0151ef4add64147288e12

fix person type Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 4e3726fd3d933af448092d01b5de367ef78daef4

use schema.org official name Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

create barnchcalavera/vegandollhouse.com

branch : html_recipe

created branch time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 0df99d5eca5c1fb92b31a55f12b6935afc07b254

start affiliates data file Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 626f2da34af0a9a92fdf465e9abb7247490cef57

fix mixed content links Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha f2fab4ee6b01fae2e932ac5d2e69ae9f2e56e365

add u-photo tag Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha ccec2b74ce878f646daec45bddc839d122c8e90c

fix affiliate links Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 40d8fb9cee8e38751606190950a1597047952b08

add recipe markup Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

created tagnetlify/netlify-toml-rs

tagv0.2.7

created time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha ddc41c019e9f36031ca4822d51c8cf61e2a3cc7e

Allow params and parameters as query aliases Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 6981ad5262f76b2cd83de9637d29d07795bc1757

Release version 0.2.7 Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

created tagnetlify/netlify-toml-rs

tagv0.2.6

created time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha 983ac4034980a80017f7b547c18f5d3cf0be3140

Release version 0.2.6 Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha 86f20c99a89be254a7f63a068364a2efdf7b32a5

Make destination optional. Not all rules need it. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 4352af5c914420fcf48005807c21c484ea464742

Merge pull request #3 from netlify/optional_destination Make destination optional.

view details

push time in 2 months

PR merged netlify/netlify-toml-rs

Make destination optional.

Not all rules need it.

+17 -8

0 comment

2 changed files

calavera

pr closed time in 2 months

delete branch netlify/netlify-toml-rs

delete branch : optional_destination

delete time in 2 months

PR opened netlify/netlify-toml-rs

Make destination optional.

Not all rules need it.

+17 -8

0 comment

2 changed files

pr created time in 2 months

create barnchnetlify/netlify-toml-rs

branch : optional_destination

created branch time in 2 months

issue openeddanielpclark/rutie

Invalid build when using Cargo workspaces.

I bumped into an interesting issue with Cargo workspaces.

I have a repository with two Rust libraries, one of them is the "core" library where I have a bunch of shared code. The other library is a ruby gem built with Rutie.

When I put both libraries in the workspace, the generated dynamic library includes a reference to libstd, which cannot be resolved in my system because I don't have anything set in LD_LIBRARY_PATH. That dynamic library won't work when it's loaded by the Ruby bindings.

ldd ../target/release/libtraffic_mesh_ruby.so 
        linux-vdso.so.1 (0x00007ffde239e000)
        libstd-4a76ff35a356aedf.so => not found
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0967c25000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0967a06000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f09677ee000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f09673fd000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f096705f000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f09685eb000)

If I put the "core" inside the workspace, but I exclude the Rutie library, the dynamic library generated doesn't include the reference to libstd and it works (as far as I can tell, I still have to add tests to the ruby part).

ldd target/release/libtraffic_mesh_ruby.so 
        linux-vdso.so.1 (0x00007ffdf47fe000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fbd0485a000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fbd04652000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbd04433000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fbd0421b000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbd03e2a000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fbd052ff000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fbd03a8c000)

So the workaround to solve this problem is to have the Rutie library in the Cargo workspace like this:

[workspace]
members = ["core"]
exclude = ["ruby-lib"]

I'm not familiar with the build toolchain, but I'd expect to be a better solution to this problem.

created time in 2 months

create barnchcalavera/rutie

branch : backports

created branch time in 2 months

fork calavera/rutie

“The Tie Between Ruby and Rust.”

fork in 2 months

delete branch netlify/trafficserver

delete branch : redo-cache-lookup

delete time in 2 months

pull request commentdanielpclark/rutie

Add faster versions of `equals`, `is_eql` and `is_equal`

This is a very good point. Hopefully it will get into master soon :pray:

asppsa

comment created time in 2 months

Pull request review commentdanielpclark/rutie

Add faster versions of `equals`, `is_eql` and `is_equal`

 fn macos_static_ruby_dep() { #[cfg(not(target_os = "windows"))] fn windows_static_ruby_dep() {} +fn rustc_cfg_ruby_version() {+    let program_version = rbconfig("RUBY_PROGRAM_VERSION");+    let v: Vec<u32> = program_version.split('.').map(|s| s.parse::<u32>().unwrap()).collect();

This is great. I just want to leave a comment, because RUBY_PROGRAM_VERSION works for preview releases too, so this code won't break in cases where you're using a pre-release or an RC:

➜  ~ chruby 2.7.0-preview1
➜  ~ irb
irb(main):001:0> RbConfig::CONFIG["RUBY_PROGRAM_VERSION"]
=> "2.7.0"
irb(main):002:0> 
asppsa

comment created time in 2 months

pull request commentdanielpclark/rutie

add "no-link" cargo feature

I'd love to see this merged. Even if it's not published in a new release, having it in master means that you could use it by depending on this github repository.

danlarkin

comment created time in 2 months

pull request commentapache/trafficserver

adding TSHttpTxnRedoCacheLookup

Thanks @SolidWallOfCode :raised_hands: :bug: :smile:

danm-netlify

comment created time in 2 months

delete branch netlify/netlify-toml-rs

delete branch : unique_conditions

delete time in 2 months

created tagnetlify/netlify-toml-rs

tagv0.2.5

created time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha e1c41e89c02fe499380ad87e69281e5f70223238

Release version 0.2.5 Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha bdc68e318735a348de05917224427d3900216124

Make redirect conditions unique. Use a HashSet instead of a vector. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 963318bfccc64a2f0e96e04c11097d519c67a4a7

Fix linter warnings Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha e632109d1f1a9b3a1d2c0630b226c9b0788f393f

Merge pull request #2 from netlify/unique_conditions Make redirect conditions unique.

view details

push time in 2 months

PR merged netlify/netlify-toml-rs

Make redirect conditions unique.

Use a HashSet instead of a vector.

+63 -34

0 comment

2 changed files

calavera

pr closed time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha 963318bfccc64a2f0e96e04c11097d519c67a4a7

Fix linter warnings Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventnetlify/netlify-toml-rs

David Calavera

commit sha 68d57ad99af82bd3e597008887f37d74602ab992

Add CI workflow

view details

push time in 2 months

PR opened netlify/netlify-toml-rs

Make redirect conditions unique.

Use a HashSet instead of a vector.

+61 -32

0 comment

2 changed files

pr created time in 2 months

more