profile
viewpoint
David Calavera calavera Sunnyvale, CA

calavera/active-proxy 135

Dynamic reverse proxy

bpftools/linux-observability-with-bpf 80

Code snippets from the O'Reilly book

bpftools/bpf-workshop 24

Let's share some eBPF love!

calavera/atompub-server 10

add atomPub server capabilities to you rails application

calavera/boring-github 7

Chrome extension to remove reactions from issues and pull requests

calavera/Ape 5

The Atom Protocol Exerciser

calavera/acts_as_unvlogable 4

An easy way to include external video services in a rails app.

calavera/Akuma 3

Unofficial fork of http://akuma.dev.java.net

calavera/ape-extensions-bundle 3

A bunch of textmate snippets in order to create ape extensions

calavera/bitescript 1

The BiteScript API and language

create barnchcalavera/slack

branch : modal_views

created branch time in 12 minutes

issue commentapache/trafficserver

Pauses of almost a second after alternate selection

Still early to confirm for sure, but it looks like 9.0.x doesn't have this problem. In the graph below, we stopped seeing this behavior at 14:15 when we deployed 9.0.x to one of our production nodes:

Screenshot from 2020-01-23 15-43-07

Something worth mentioning that I think I didn't say before is that all the transactions with the issue were marked as CACHE_MISS, even thought we know for sure that the object was in the cache, but I guess that's because of the OPEN_READ_FAILED event.

calavera

comment created time in 5 hours

issue openedapache/trafficserver

Pauses of almost a second after alternate selection

We're noticing that there are some unusual pauses after alternate selection happens. These pauses are around 1 second per alternate in the selection vector. We're still trying to find the cause of problem, but I thought I'd open an issue to see if someone else has seen this behavior before.

We're running 7.1.x, and we're about to try 9.0.x to see if the behavior is also there. You can see in the timestamps below how the continuation seems to stop after the alternate selection for almost a minute, and then HttpCacheSM sends an OPEN_READ_FAILED event:

[Jan 23 04:44:19.104] Server {0x7f074deb2700} DEBUG: <HttpTransactCache.cc:265 (SelectFromAlternates)> (http_seq) [SelectFromAlternates] Chosen alternate # 1
[alts] and the winner is alternate number 1
[Jan 23 04:44:20.043] Server {0x7f074deb2700} DEBUG: <HttpCacheSM.cc:118 (state_cache_open_read)> (http_cache) [40] [&HttpCacheSM::state_cache_open_read, CACHE_EVENT_OPEN_READ_FAILED]

We're seen the problem in isolated environments with only healthchecks sending request to TrafficServer and us sending two or three requests with curl. It happens with and without compression.

We also have the three settings below in our records configuration, which might be part of the problem:

# retries cache 5 times adding up to a total of 500ms delay into non cached requests.
CONFIG proxy.config.http.cache.max_open_read_retries INT 5
CONFIG proxy.config.http.cache.open_read_retry_time INT 100
# enables cache read while another request to the same url is writing to the same entry.
CONFIG proxy.config.cache.enable_read_while_writer INT 1

Does anyone have any idea about what might be happening?

created time in 11 hours

push eventnetlify/trafficserver

Bryan Call

commit sha 81f0c9d22da659f7a97a544bbc4186b915fcb982

Fixed build issues on macOS after 0-RTT merge (cherry picked from commit 3418938eddaf0005b8c8af882819041a59dbbbb7)

view details

bneradt

commit sha 604eb115d9f662dabf6438535334f370085e79dc

Fix some long lines and reduntant plugin_config SO additions. (cherry picked from commit 15b0051fa2230bb60922943f4207b4a811f65430)

view details

Walt Karas

commit sha fd2ce7488b37d24642224994815e9e14bbea7e91

Fix problems with "Probe" option for X-Debug MIME header field. (#6197) Fix problems with "Probe" option for X-Debug MIME header field. - Adds exercise of "Probe" to the existing x_remap Au test. - Remove memory leaks and risk of double deletion in xdebug plugin. (cherry picked from commit 473e0549cbb7bda763340b842d447d9db0d49879)

view details

Brian Olsen

commit sha a4a4cdd4cca085674c716e19fa73ed8703b83e02

remap_stats: restore handling of remap/hostname to remove memory leak (cherry picked from commit e622ae26bf1bb4a3dd815c066bd547d97e2e9185)

view details

push time in 12 hours

issue commentapache/trafficserver

ATS 9 using a continuation which is deleted

This crash hasn't triggered on our test builds for the past couple weeks. Perhaps it has been fixed? Or perhaps I haven't been as diligent in keeping our canary going.

Has anyone seen this error lately? @shinrich, @bryancall ?

bryancall

comment created time in a day

push eventcalavera/deno

David Calavera

commit sha aacf9b13e0f508721d5bd9177b87ef4cdcc2aeb6

Call unsafe function Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 days

push eventcalavera/deno

David Calavera

commit sha 7a982aa4bc9def82ee7d42ae766b879b33e93388

Add `call` function to invoke specific JS functions. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 days

create barnchcalavera/deno

branch : call_function

created branch time in 2 days

fork calavera/deno

A secure JavaScript and TypeScript runtime

https://deno.land/

fork in 2 days

push eventapache/trafficserver

push time in 6 days

issue closedapache/trafficserver

brotli not enabled on Ubuntu 18.04 LTS even when libbrotli-dev is installed

Here is a Dockerfile to reproduce the problem. (See https://github.com/hnakamur/trafficserver/tree/docker_brotli_not_enabled for the whole source tree).

FROM ubuntu:18.04

RUN ln -fs /usr/share/zoneinfo/Etc/UTC /etc/localtime \
 && sed -i 's/^# deb-src/deb-src/' /etc/apt/sources.list \
 && apt-get update \
 && DEBIAN_FRONTEND=noninteractive apt-get build-dep -y trafficserver \
 && useradd -r -m -s /bin/bash build

USER build
RUN mkdir -p ~/dev/trafficserver
COPY --chown=build:build . /home/build/dev/trafficserver/

RUN cd ~/dev/trafficserver \
 && autoreconf -if \
 && ./configure

CMD ["/bin/grep", "HAVE_BROTLI_ENCODE_H", "/home/build/dev/trafficserver/include/ink_autoconf.h"]

Build an image with the above Dockerfile.

docker build -t ats-build-brotli-not-enabled .

And verify HAVE_BROTLI_ENCODE_H is not defined.

$ docker run --rm ats-build-brotli-not-enabled 
/* #undef HAVE_BROTLI_ENCODE_H */

Make sure libbrotli-dev in installed.

$ docker run --rm ats-build-brotli-not-enabled dpkg -l '*brotli*'
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name             Version          Architecture Description
+++-================-================-============-===================================================================
ii  libbrotli-dev    1.0.3-1ubuntu1.2 amd64        library implementing brotli encoder and decoder (development files)
ii  libbrotli1:amd64 1.0.3-1ubuntu1.2 amd64        library implementing brotli encoder and decoder (shared libraries)

As a workaround, add --with-brotli=/usr/include to ./configure in the above Dockerfile. (See https://github.com/hnakamur/trafficserver/tree/docker_brotli_enabled_with_workaround for the whole source tree).

Build an image with the modified Dockerfile.

docker build -t ats-build-brotli .

And verify HAVE_BROTLI_ENCODE_H is defined.

$ docker run --rm ats-build-brotli
#define HAVE_BROTLI_ENCODE_H 1

closed time in 6 days

hnakamur

issue commentapache/trafficserver

brotli not enabled on Ubuntu 18.04 LTS even when libbrotli-dev is installed

This issue was fixed by https://github.com/apache/trafficserver/pull/5721. Closing this issue.

hnakamur

comment created time in 6 days

issue closedapache/trafficserver

Shouldn't we autodetect brotli?

It seems you have to explicitly ask for Brotli, but shouldn't we just do what we normally do, and auto detect (png-config etc.) for the Brotli include files ?

This might be related to #4741 as well.

closed time in 6 days

zwoop

issue commentapache/trafficserver

Shouldn't we autodetect brotli?

Closing this issue since it's already fixed.

zwoop

comment created time in 6 days

push eventapache/trafficserver

Walter Karas

commit sha 15a6890366ff9a791afec71580b0c03f6baccf5e

Make compress plugin normalization of Accept-Encoding header compatible with normalization in core TS. Specifically, remove parameters on values, but if there is a valid q parameter which is equal to 0.0, remove the associated value from the value list.

view details

push time in 7 days

PR merged apache/trafficserver

Reviewers
Make compress plugin normalization of Accept-Encoding header compatible with normalization in core TS. Plugins

Specifically, remove parameters on values, but if there is a valid q parameter which is equal to 0.0, remove the associated value from the value list.

+191 -228

1 comment

4 changed files

ywkaras

pr closed time in 7 days

push eventnetlify/trafficserver

Miles Libbey

commit sha 6c63873adc01872c42ac125a9e155f49b35d0c4b

Add links to RWW sections (cherry picked from commit 64bc0169bb02fa31978e077e7424127c5850e0fa)

view details

Miles Libbey

commit sha 96b37fc0655abe7bfed735916804594f13ebff89

Fix rst errors for collapsed forwarding plugin - The table of configs was printing the rst reference tags - the link to the thundering herd section wasn't a link - the hard coded anchor link is better as a reference that stays with the docs. (cherry picked from commit 8872c1d48ffd696c98e701e5c9dc71b9c8d180f2)

view details

Masaori Koshiba

commit sha 42713b4584cf22194f743c8e80c944d1ea9fa717

Reduce process duration of test_Http2FrequencyCounter (cherry picked from commit 0ad851937e66351b2dbee640678b3f0b9e157da8)

view details

Tucker

commit sha f2f4558a152008783583115af4d3d5bd9e11bc18

Doc bugs * reject is not a valid filter keyword. change to "action" * aggregate operator should be AVG, not AVERAGE (cherry picked from commit f2716faad07c04f72bce357866cd42e15fc1add0)

view details

Walter Karas

commit sha 0ccf62984e5183bd8b183ea2f09292d93874dc72

Clear all pointers in API Hooks clear function. (cherry picked from commit 4bdabd533d44f8959b88ae534018685567c01765)

view details

Fei Deng

commit sha 9ebbd60bdf05404761742acfb90bbdcbd4c33cde

TLSv1.3 0-RTT support (#5450) * TLSv1.3 0-RTT support TLSv1.3 0-RTT test TLSv1.3 0-RTT anti-replay TLSv1.3 0-RTT h2 (cherry picked from commit 8236813ef44e3187febe12b7996cb2cc9754f3e7)

view details

Oknet Xu

commit sha 98f41e932944a695a5ec6a20ffb8205872f86304

Don't sleep if ProtectedQueue.localQueue is not empty. (#6234) (cherry picked from commit aa5b2eafda2667621f443b455829ce3b5c3be0b0)

view details

Walter Karas

commit sha 0fade4485a139abff4346b40c40db30bdb314ef6

Copy the Client SNI Server Name out of the openssl SSL object and ensure it is null-terminated. (cherry picked from commit 770f9d4f5a6825465f2ae5a681c5f3896479f635)

view details

Alan M. Carroll

commit sha 269a30882a79dd1db954bf3fd489bdbc07495f0d

Fix dynamic update for conntrack (HttpConnectionCount) configuration variables. (cherry picked from commit 03aee4ce6faa2ce142b83216186151010fd13a23)

view details

Alan M. Carroll

commit sha 6ef37a31bb8c5c6e99d1f1ccf57d1c1133db298d

Promote 'Enable_Config_Var' from HttpConnectionCount to HttpConfig. This is so other configuration can use it. (cherry picked from commit 9550c6512840dcff80ea0ab2c57574390bf8c849)

view details

Dylan Souza

commit sha f85548b9d6d0699b18e5cbeb23cdda1078f04f1b

Add Example URI Signer Python Script Provide an example script to be used in conjunction with the uri signing plugin. This script is meant to serve as an example of how to get started with uri signing and could be useful in testing various configs. (cherry picked from commit 3632eb748de4556dd87a66925ef2ace9a2b2c3fa)

view details

Brian Olsen

commit sha 35f789a9682a88f0846cfd78f828518b314a79bb

Add simple autest and subsequent fixes (cherry picked from commit ea3aa04b88bbfea1412d8f2105c73c4eace763ee)

view details

Randall Meyer

commit sha 4117431fb3bfea9ea45e1d0e54014ca8a9754a9f

Fixes clang-format issues These files were committed from a PR before the new clang-format rules. (cherry picked from commit 4d06ce6ca57edc065fdbea9e8f0133f5c8fcef7d)

view details

Susan Hinrichs

commit sha a7d1650c01626da217c2da96a2a90637d38992ba

Add tests to exercise H2 and chunked encoding (cherry picked from commit d34a32c2aa584964fce5150c34f3ea2c2e418a32)

view details

Leif Hedstrom

commit sha fdb2fa9ae6c5557953e065fc6790086bf56dfa20

Updated ChangeLog

view details

Walter Karas

commit sha 06acc9d03e57dab377ee9626e20fac0489489408

Add new log field to output server name sent by client in TLS handshake. (cherry picked from commit c3590f1160f67c15944c5fcb2e8888ec6f684fce)

view details

Leif Hedstrom

commit sha a3dfab98cd1ee4a95cd33076751bcaff20085ccf

Fixes clang-format on this cherry-pick

view details

push time in 7 days

push eventapache/trafficserver

Susan Hinrichs

commit sha d34a32c2aa584964fce5150c34f3ea2c2e418a32

Add tests to exercise H2 and chunked encoding

view details

David Calavera

commit sha cf3d098fbe1bb4d7157f03fc400d3b39fc8f0eff

Merge pull request #6268 from shinrich/add_h2_chunked_encoding_test Add tests to exercise H2 and chunked encoding

view details

push time in 8 days

PR merged apache/trafficserver

Add tests to exercise H2 and chunked encoding Tests

Created these tests to track an issue we were seeing with H2 and chunked encoding. Already addressed on master, but seems like a good test to catch possible future regressions.

+220 -1

1 comment

8 changed files

shinrich

pr closed time in 8 days

startedcortexlabs/cortex

started time in 9 days

push eventnetlify/trafficserver

Vijay Mamidi

commit sha 43097fb638db6a92a5674c5d2182febb1e9137e3

Mark host as partial when subdmains are more than default table depth (cherry picked from commit 9ca5abc19a89ca518049921dd9cd827268cb22a0)

view details

Fei Deng

commit sha 75dafb0d9ae6d6043f911cc57ffd37433494d306

do not reload configs periodically (cherry picked from commit cd1485435bd5c5e52110149881d8bb07a8dad988)

view details

Susan Hinrichs

commit sha 6fa482bf0d9504dd5168af7107aca9c66a894729

Revert "Optimize: If failed on migrateToCurrentThread, put the server session back to global server session pool" This reverts commit c776c6677b0c005dd511945ae023a14f8f6b0bc3. Conflicts: iocore/net/UnixNetVConnection.cc (cherry picked from commit 26a51a0fb22095e0befc461c53691d3d0dd2d948)

view details

Gancho Tenev

commit sha e2302526a698e6be0c0aa5a70346c7e3b6971b6f

cachekey: allow multiple values for `--key-type` Allow multiple target types to be specified for `--key-type` so the operator can apply the same modifications to both cache key and parent selection url at the same time without chaining cachekey plugin instances. Instead of: @plugin=cachekey.so \ @pparam=--key-type=parent_selection_url \ @pparam=--remove-all-params=true @plugin=cachekey.so \ @pparam=--key-type=cache_key \ @pparam=--remove-all-params=true to write: @plugin=cachekey.so \ @pparam=--key-type=parent_selection_url,cache_key \ @pparam=--remove-all-params=true (cherry picked from commit db8cd14acede7460a5996864c52e1b206695e405)

view details

Masaori Koshiba

commit sha 4c9bdef9f311c1c2da65019928429f8f05897a7c

Cleanup: unifdef TRACK_BUFFER_USER (cherry picked from commit 64595af3d0fb7882993016d67e43e7c5ca3af914)

view details

Alan M. Carroll

commit sha 28e1d6d47b4aab5635677a56e6926829345ae15c

Doc: Guide to remap plugin API. (cherry picked from commit 5cb4b316ad93fd4c78f44effc4c1dfbe4949543c)

view details

Gancho Tenev

commit sha a8bcd1c58cdf70e1fb810738a3ea76850e79baa0

Rearrange config reload notifications Renamed `TSRemapConfigReload` to `TSRemapPreConfigReload` to notify all already loaded plugins that a configuration (re)load is about to start. Added new `TSRemapPostConfigReload(TSReturnCode)` to notify the plugins that the configuration (re)load is done and provide status of its success or failure. (cherry picked from commit 70de21d9c72997564ee9ae549cac5407e0f48a98)

view details

Gancho Tenev

commit sha 970a9a2fceb9a12d39c757909b234fbf9a87ce90

"Plugin (un)used" post reload notification Most of the plugins is assumed to use per-plugin-instance data-structures when reloading their configs and only a few of them that wish to optimize performance or deal with the complexities of using per-plugin DSO "global" data-structures would use plugin configuration reload notifications like `TSRemapPreConfigReload` and `TSRemapPostConfigReload`. Instead of trying to foresee the needs or the expectations of each use-case, a more "open-ended" and straight-forward design was chosen for the configuration reload notifications. The notifications are broadcasted to all loaded plugins at the moments before and after the reload attempt, regardless of whether a plugin is part of the new configuration or not. During the `TSRemapPostConfigReload` we already decided to notify the plugin if the plugin reload was successful or not so the plugins can recover adequately in case of configuration reload failure. This change adds a signal to show if the particular plugin was part of the new configuration. This will be beneficial for use-cases that expect plugin reload notification not to be called in case they are not part of the new configuration so they can ignore the notification. This change also attempts to clarify related documentation and code comments as well. (cherry picked from commit 78c7c0c0bf2afa87a90da5fa948a55d8ba747dbd)

view details

Masakazu Kitajo

commit sha e878cd1325cc284589ca330e7a4ceb4fee322a06

Add QUIC draft-23 support Squashed commit of the following: commit 8aab554452ee9f9f770b2406b0df0d033eaae8e0 Merge: fa823387f 32b5dae81 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Oct 8 15:14:18 2019 -0700 Merge branch 'master' into quic-latest * master: Add filename to error message in header_rewrite Turn on certificate verification, in permissive mode for now Concurrent SRV request failures Fix use-after-free problem related to logging headers ssl_multicert.config -> params->configFilePath Adds build targets on CI for 9.0.x weak mutex macros Fix a build issue on enabling FIPS Change the ready checks for ats to use the actual ats port and not the server port. Add ready check on server port for the server Address possibe use after free issue in HttpVCTable::remove_entry YAML config: output erroneous keyword and line number in YAML file it appears on in diags.log. Convert old sni configuration file in lua to yaml First cut at a layout for Release Notes Clear api set bit to avoid crash in following redirect. commit fa823387f81aefe42cabf5a449977dc861b90587 Author: scw00 <scw00@apache.org> Date: Fri Sep 27 14:04:31 2019 +0800 QUIC: Fix test_QUICKeyGenerator commit e62f4af7a3ee6978986cbd490875286ce1fa2730 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 16:35:07 2019 +0900 Fix a compile warning commit 887732b49527b4266b4b7956db3f627355b3bd14 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 13:01:15 2019 +0900 Update initial salt commit c2b9be3a83919b0c863e2d5880956aaf2096e3a7 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 10:16:20 2019 +0900 Update QUIC transport error codes commit 9d843ebf6e9399ff4dabd62952d7dc6a98f65f93 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:58:26 2019 +0900 Rename DISABLE_MIGRATION to DISABLE_ACTIVE_MIGRATION commit d1951e98e86702f0769947c7541f64aed2045962 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:54:22 2019 +0900 Update the length of unpredictable bits field in Stateless Reset Packet commit 617dd31a7bd904d839abc4fde50eb3f5280ce1e9 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 09:51:47 2019 +0900 Update draft version numbers to 23 commit 2e78599cc634a85f9552f22132bfbdd084319391 Merge: 212fdd319 70de21d9c Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 10:24:45 2019 +0900 Merge branch 'master' into quic-latest * master: (23 commits) Rearrange config reload notifications Removed hardcoded sni.yaml configuration filename in logs Clarify docs on the change from redirect_enabled. Make code buildable with BoringSSL Fix debug output for global_user_agent_header. Add documentation for TSHttpTxnRedoCacheLookup Add example plugin to show how to use TSRedoCacheLookup. TSHttpTxnRedoCacheLookup. Fix reference to SMDebug. adding TSHttpTxnRedoCacheLookup Add AUTest using h2spec Track scheduled events to (read|write)_vio.cont from Http2Stream Cleanup AuTest for HTTP/2 Fix AuTest for HTTP/2 using httpbin Add base64 encoding/decoding to encryption/decryption, and general code cleanup. Update documentation for connect_attempts_timeout. Track SSL session cache evictions performed due to full bucket Perform a SSL quiet shutdown when close-notify is not sent Remove hard coded filename in error message Substitution string has changed ... commit 212fdd3198a846eca22e7bbe73a0765c3e4782ee Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 27 10:20:28 2019 +0900 Fix unit tests commit 6f470fa831d4401bc85703ad233218e535df9d90 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Sep 26 17:36:39 2019 +0900 Fix build issues on macOS (or clang) commit a786041f3e27d34d009636a781cf3bd6972f0882 Author: scw00 <scw00@apache.org> Date: Thu Sep 19 08:29:25 2019 +0800 QUIC: Remove useless default constructor in QUICStreamManager commit edc4b672b98e38dd95f6d9a80e271e999cd3297a Author: scw00 <scw00@apache.org> Date: Tue Sep 17 14:03:14 2019 +0800 QUIC: Rename QUICCongestionController.cc to QUICNewRenoCongestionController.cc commit 45c3f138633466f2bc31dd45bbd617b00e14938b Author: scw00 <scw00@apache.org> Date: Wed Sep 11 14:09:34 2019 +0800 QUIC: Remove unnecessary allocator commit 256a74c54f93cf86cd7fc8d866f195b23df2f2f0 Author: scw00 <scw00@apache.org> Date: Wed Sep 11 11:30:04 2019 +0800 QUIC: Add Token Creator commit 5980fa47083aca5df6d4f04e388ddab5344cdd2b Author: scw00 <scw00@apache.org> Date: Mon Sep 9 15:24:23 2019 +0800 QUIC: add more infomation to QUICPacketProtectionKeyInfo commit 814f39e8269d8c19064b698825c2b9441c9eacb5 Author: scw00 <scw00@apache.org> Date: Mon Sep 9 12:32:20 2019 +0800 QUIC: Hidden more pp_key_info detail in QUICContext commit fecacfbd973b7c5e3b10c21e94fdfff4300768e5 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 10 14:33:52 2019 +0900 Stabilize unit tests commit e8565bbee89663a1c89b4052c0fc32ea80bccfb6 Author: scw00 <scw00@apache.org> Date: Wed Aug 7 10:55:54 2019 +0800 QUIC: Adds QUICContext to wrap some common params commit 5b04932d62ff66602923c7e63250660fd0992e84 Merge: 5c7b68a0d 92d4ef142 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Sep 6 11:16:38 2019 +0900 Merge branch 'master' into quic-latest * master: Check F_GETPIPE_SZ is defined to fix macOS build Update Server IP in Transaction when attaching a session from the pool Add unit tests for MIOBuffer:write() Allow disabling HTTP/2 priority frames limit Add implementation for TextView::rtrim(char const*) Doc: Guide to remap plugin API. Add helper functions to apply api timeouts consistently. address review comments pipe buffer size for log.pipe should be configurable Provide stats for the recently introduced HTTP/2 rate limits commit 5c7b68a0d337fefaf1d4cdde31574c0ab9144034 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Sep 4 14:40:30 2019 +0900 Send PreferredAddress only if necessary commit 2b5e2ce18e6367f142f2acad345489716486660a Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 17:04:27 2019 +0900 Fix memory leaks detected by ASAN commit 13bdd9d05f5348c0aaa37f7669f1fa425c434503 Merge: e7430fabb c65f0a1fb Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 14:12:38 2019 +0900 Merge branch 'master' into quic-latest * master: (30 commits) Cleanup: Remove unused AllocType and unused functions Ran clang-format ProxySsn renaming member vars cachekey: added --key-type (for parent selection) Bumped the version of master to 10.0.0 ProxySsn Refactor move code to cc 1) add autest for log filter; 2) support filter for duplicated param name in query parm of URL code clean from review comments move code to utility function to reduce the interface size fix typo issue fix the bug if filter word included in param value fix the bug if filter word included in param value correct the size of DNS buffers cachekey: added --canonical-prefix parameter static linking asan, tsan, lsan Fixed const issue with magick plugin CI: added support for disabling curl in the build Adds the v9.0.x Docs link to main docs page Updates the CI build scripts, adds QUIC support Expose client SSL stats via API & Lua ... commit e7430fabb29f91bf6d146834d7eb5ba867b130a0 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 14:07:01 2019 +0900 Fix QUICPinger and tests for it commit f040d5fa7bcb170d054d5f0773a7aba38312bd3b Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Sep 3 12:33:26 2019 +0900 Print a raw value of unknown transport parameter commit 13f9f63aef7e8b76d5aa11048d29112ccfaae533 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Aug 27 14:25:00 2019 +0900 Use active_connection_id_limit advertised commit 0e4622e62613fd8b7b9a8d65e2613131a7d1d9c6 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 22 16:38:38 2019 +0900 Assert sending a frame that is allowed on the encryption level commit 72b1f79c0af422a1e383d7becf370a580bcfd159 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 22 16:23:53 2019 +0900 Send PING only on Short packets commit e7a6cd6292ba54b6804b79298188e7042a73577a Merge: 3c8e6d12f 5886fb212 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Aug 21 11:42:41 2019 +0900 Merge branch 'master' into quic-latest * master: Fix inactivity timeout on QUIC Cleanup: Remove unused empty files Cleanup: unifdef WRITE_AND_TRANSFER Explain how SRV origin selection works Doc: fix build errors. HTTP/2 fix with realloc Fix clang-tidy's mistakes Ran make clang-tidy Updated clang-tidy configuration, scripts, and Makefiles Make proxy.config.http.per_server.min_keep_alive_connections overridable Make TS_NULL_MLOC a valid C compile-time constant. Doc: Remove python 2 vestiges from conf.py, traffic-server.py. Conflicts: iocore/net/QUICNetVConnection.cc commit 3c8e6d12f9335dc7b55ca45dafb21fc4c3c3c0b8 Merge: 7a9d7fd63 aa319a461 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Aug 19 09:29:44 2019 +0900 Merge branch 'master' into quic-latest * master: (48 commits) Fix H2 internal counters Reactivate active timeout enforcement Avoid AWS auth v4 path/query param double encoding Fix QUIC build Cleanup: Signal READ_READY event only if the buffer is readable Cleanup: Remove unused function & old comments Make client_context_dump test resilient to dump order changes Record HttpSM Id on new transaction make check race condition fix Doc: Improve handling of build when documentation is not enabled. fix. Limit resources used by regex_remap to prevent crashes on resource exhaustion. compress plugin: document undocumented options Allocate DependencyTree only if HTTP/2 stream priority is enabled HTTP/2 rate limiting Fixes various issues found in docs Remove double call of the SNI action on TLS accept. Refactor the alpn/npn handling into common ALPNSupport class Update for QUIC integration. Fixed the InkAPI to provide the TSVConnProtocolEnable/Disable functions. Update documentation and updated the example plugin. ... commit 7a9d7fd633dfdcd8a931dbbf35b76fa590707581 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Aug 16 11:56:12 2019 +0900 fix typo commit 5b5efeccb23e88b25e7b644a4a828208679f6416 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Aug 5 11:08:49 2019 +0900 Print sending Retry packets commit d222be218ef38f3f26e8a68b64f691b984f10799 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Aug 2 09:32:09 2019 +0900 Min/Max length of PreferredAddress commit fb350263dc0b8cc73d557c8ed1220afccfb9b244 Merge: 4938b7f85 e068b7685 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 16:57:48 2019 +0900 Merge branch 'master' into quic-latest * master: Add support for updating Container fields as well Preserve the raw log fields when wiping using case insensitive contains Add soft limit for HTTP Request URI and Header field length. Add a default body_factory template when rejecting a request that's too long Doc: Minor typo in CONTRIBUTING.md Add QUIC draft-20 support Initialize EventIO fixed datatype in example plugin Cleanup debug logs around SSLWriteBuffer Remove unnecesary function name on debug logs in SSLNetVConnection TS API - Adds the TSHttpTxnNextHopNameGet() function. Conflicts: .gitignore iocore/net/P_QUICNetVConnection.h iocore/net/QUICNetVConnection.cc iocore/net/QUICPacketHandler.cc iocore/net/quic/Makefile.am iocore/net/quic/Mock.h iocore/net/quic/QUICAckFrameCreator.cc iocore/net/quic/QUICAckFrameCreator.h iocore/net/quic/QUICAltConnectionManager.cc iocore/net/quic/QUICAltConnectionManager.h iocore/net/quic/QUICBidirectionalStream.cc iocore/net/quic/QUICBidirectionalStream.h iocore/net/quic/QUICConfig.h iocore/net/quic/QUICCongestionController.cc iocore/net/quic/QUICCryptoStream.cc iocore/net/quic/QUICCryptoStream.h iocore/net/quic/QUICDebugNames.cc iocore/net/quic/QUICFlowController.cc iocore/net/quic/QUICFlowController.h iocore/net/quic/QUICFrame.cc iocore/net/quic/QUICFrame.h iocore/net/quic/QUICFrameDispatcher.cc iocore/net/quic/QUICFrameDispatcher.h iocore/net/quic/QUICFrameGenerator.cc iocore/net/quic/QUICFrameGenerator.h iocore/net/quic/QUICHandshake.cc iocore/net/quic/QUICHandshake.h iocore/net/quic/QUICKeyGenerator.cc iocore/net/quic/QUICLossDetector.cc iocore/net/quic/QUICLossDetector.h iocore/net/quic/QUICPacket.cc iocore/net/quic/QUICPacket.h iocore/net/quic/QUICPacketFactory.cc iocore/net/quic/QUICPacketFactory.h iocore/net/quic/QUICPacketHeaderProtector.cc iocore/net/quic/QUICPacketReceiveQueue.cc iocore/net/quic/QUICPacketReceiveQueue.h iocore/net/quic/QUICPathValidator.cc iocore/net/quic/QUICPathValidator.h iocore/net/quic/QUICPinger.cc iocore/net/quic/QUICPinger.h iocore/net/quic/QUICStreamManager.cc iocore/net/quic/QUICStreamManager.h iocore/net/quic/QUICTransportParameters.h iocore/net/quic/QUICTypes.cc iocore/net/quic/QUICTypes.h iocore/net/quic/QUICUnidirectionalStream.cc iocore/net/quic/QUICUnidirectionalStream.h iocore/net/quic/test/test_QUICAckFrameCreator.cc iocore/net/quic/test/test_QUICFlowController.cc iocore/net/quic/test/test_QUICFrame.cc iocore/net/quic/test/test_QUICFrameDispatcher.cc iocore/net/quic/test/test_QUICInvariants.cc iocore/net/quic/test/test_QUICKeyGenerator.cc iocore/net/quic/test/test_QUICLossDetector.cc iocore/net/quic/test/test_QUICPacket.cc iocore/net/quic/test/test_QUICPacketFactory.cc iocore/net/quic/test/test_QUICPacketHeaderProtector.cc iocore/net/quic/test/test_QUICStream.cc iocore/net/quic/test/test_QUICStreamManager.cc iocore/net/quic/test/test_QUICType.cc mgmt/RecordsConfig.cc src/traffic_quic/quic_client.cc src/tscore/ink_inet.cc commit 4938b7f854cb06411d6fd061bdbde28a53074103 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 14:21:50 2019 +0900 Make QUICFrame:to_io_buffer_block pure virtual commit baaf97c51637116fcdd1ba3bf475788115c8662c Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 14:04:13 2019 +0900 Convert QUICAckFrame::store to to_io_buffer_block commit ad565245ed077205a6955a77d3250e2a39f5775b Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:21:42 2019 +0900 Convert QUICUnknownFrame::store to to_io_buffer_block commit 9cb75727328f8f02d9938a056ec5f5ac6091374c Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:15:30 2019 +0900 Convert QUICRetireConnectionIdFrame::store to to_io_buffer_block commit cc452b953d0cfb00be3abee374a99251d3139889 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 12:06:40 2019 +0900 Convert QUICNewTokenFrame::store to to_io_buffer_block commit 748d66cfad7e7181bd7b1aa50ebb9bed51f00b81 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Aug 1 11:50:25 2019 +0900 Convert QUICCryptoFrame::store to to_io_buffer_block commit 2b38e5f88289a4e7d590d767c2b7c9a1942a184a Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:27:51 2019 +0900 Convert QUICPathResponseFrame::store to to_io_buffer_block commit e0f2c609212a617ae59ce0346dc9327a83421cc6 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:18:23 2019 +0900 Convert QUICPathChallengeFrame::store to to_io_buffer_block commit edd2963e2e0b12f6e14364bd5cdd4473e1804600 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 17:10:00 2019 +0900 Convert QUICNewConnectionIdFrame::store to to_io_buffer_block commit 93b79fb2e6386ce840130b08f46c8e58e56ffd2d Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:52:38 2019 +0900 Convert QUICStreamIdBlockedFrame::store to to_io_buffer_block commit d3b5ea831572403b037bba8585fa592acb585d14 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:44:58 2019 +0900 Convert QUICStreamDataBlockedFrame::store to to_io_buffer_block commit a1390e86c95fffc8e62f7c4ea471e77bddd6554b Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:40:27 2019 +0900 Convert QUICDataBlockediFrame::store to to_io_buffer_block commit f419cd9752aa1312454fe819a08e0516f90a3ba2 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:32:35 2019 +0900 Convert QUICPaddingFrame::store to to_io_buffer_block commit 6f5da6078bcb76cd1f0aabfc7c38defe7886e5d2 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:23:10 2019 +0900 Convert QUICMaxStreamsFrame::store to to_io_buffer_block commit 08501a8886e35241ca08ed9cd558e6dce5a18735 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:18:21 2019 +0900 Convert QUICMaxStreamDataFrame::store to to_io_buffer_block commit ac4a732c6f3f574f0558895b708bd557b50b95ce Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:13:36 2019 +0900 Convert QUICMaxDataFrame::store to to_io_buffer_block commit d996d4bcab89786783b9b4065c3ccf5ebc1008f0 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 31 16:05:08 2019 +0900 Convert QUICPingFrame::store to to_io_buffer_block commit 578772f84d2fcf425ee06b661a5a7b2a655cf6a1 Merge: eb2a9d31c 78995bf4e Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 23 15:03:38 2019 +0900 Merge branch 'master' into quic-latest * master: (46 commits) Add dest addr information to UDPPacket class Update UDPNet for QUIC Add HKDF wrapper Use un-deprecated records for SSL server verification Removes proxy.config.http.cache.allow_empty_doc Deprecate the mysql_remap plugin. See #5395 Removes the stale_while_revalidate plugin. See #5395 Removes the memcached_remap plugin. See #5395 Removes the hipes plugin. See #5395 Removes the header_normalize plugin. See #5395 Removes the buffer_upload plugin. See #5395 Removes the balancer plugin. See #5395 Fixes spelling in lib/records Fixes memory leak in traffic_crashlog Promotes certifier to stable, see #5394 Promotes remap_purge to stable, see #5394 Promotes prefetch to stable, see #5394 Promotes multiplexer to stable, see #5394 Promotes cache_range_requests to stable, see #5394 fix If-Match and If-Unmodified-Since priority problem,about rfc https://tools.ietf.org/html/rfc7232#section-3.3 ... Conflicts: build/crypto.m4 configure.ac include/tscore/HKDF.h iocore/net/P_UDPNet.h iocore/net/P_UnixNet.h iocore/net/UnixUDPNet.cc src/tscore/HKDF_boringssl.cc src/tscore/HKDF_openssl.cc commit eb2a9d31c6c5eca02596181085509aa155126e16 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 12:25:23 2019 +0900 Fix frame parsers for CON_CLOSE, STOP_SENDING and RST_STREAM Error codes were read as 16 bit integers commit 0dc9a3e542734909cd3466b555ecf56461fbd7e7 Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 09:43:54 2019 +0900 Fix CONNECTION_CLOSE frame parser commit a62388d1b538e0d2617465928124a4b7573119ef Author: Masakazu Kitajo <maskit@apache.org> Date: Mon Jul 22 07:36:02 2019 +0900 Set default value for initial_max_stream_data_uni to 4096 http-22 says it should be 1024 or greater. commit 0e46a6bccc582f02d65d4e11c228e423e35508b6 Author: Masaori Koshiba <masaori@apache.org> Date: Mon Jul 22 02:07:32 2019 +0900 Fix storing QUICConnectionId::ZERO commit 5db9a3b1cba535e6dac6664139c953b136e8adcb Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 19 23:39:13 2019 +0900 Update max cid length commit 6e6351e721d784121f40f0f381124d624f7e5a39 Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 15:00:10 2019 +0900 Fix buffer length for VN packet commit bcf842a12a0a9ec67ca1d7e5e95f5c9be6a806ab Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 14:45:59 2019 +0900 Fix stateless retry on server side Prior this change, getting the token filed offset of INITIAL packet was wrong when stateless retry is enabled. commit ab8508b28a48c0653bd9187ce4511cb96d76ec34 Author: Masaori Koshiba <masaori@apache.org> Date: Fri Jul 19 11:30:35 2019 +0900 Fix QUICFrame & unit tests for NEW_CONNECTION_ID commit 62f7174c6ec2428218f9b457f9b37a816a622e6a Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 16:26:25 2019 +0900 Add getter for retire_prior_to field commit 3fff0dec8aa7abc8ef34a3a9da50ac3336de06ab Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 16:14:27 2019 +0900 Add Retire Prior To field to sending NCID frames commit 2944fe85c21816ae5bcbeba8199f26c035049f8b Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 15:57:30 2019 +0900 Add tests for static functions of QUICPacketLongHeader commit 1ce476c91cd50e66c916daa1446f7d2480f19604 Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 12:28:55 2019 +0900 Fix getting packet length on dequeue from QUICPacketReceiveQueue commit 142e11e2cd4b6bfc4fb91db9b8fbcbd72123950c Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 11:21:33 2019 +0900 Update to support new RETRY packet format commit 16d7129f14d259d290bbb2b06aa69ecb107ea906 Author: Masaori Koshiba <masaori@apache.org> Date: Thu Jul 18 11:00:27 2019 +0900 Fix sampling offset for packet header protection & unit tests commit 6f8682715cb604f838711b9ec6af5ed99db95f16 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 18 08:56:53 2019 +0900 Fix tests for QUICFrameDispatcher commit c647ed4dac3ca538252857e8674aa3b7ec47dd05 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:20:48 2019 +0900 Fix unit tests for QUICPacketFactory commit f140407023a3377d9c4ce420d4e33f66da735a8e Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:17:47 2019 +0900 Update storing long header packet & unit tests commit 7cc4b20ad7c82f9eaa2bda787897a0a1bb4b0560 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 16:16:29 2019 +0900 Fix loading long header packet commit c47874c3653191fb90543fbed5d6b734d69fba86 Author: Masaori Koshiba <masaori@apache.org> Date: Wed Jul 17 14:54:38 2019 +0900 Fix unit tests for QUICInvariants commit 87afcb077642df9c4902c15a7fc42f58b9a5f060 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 16 21:38:00 2019 +0900 Update Long Header CID parser commit 86a4317b4fd2ef19456cf5d231d78c50d99db09d Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 9 17:10:20 2019 +0900 Use variable-length integer for error code fields on QUIC frames commit e105d33d7569739174abffddb89c491e3e729cb0 Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 17:10:55 2019 +0900 Make ErrorCode 62 bit unsigned integer commit 13d003757239833d8eff2e94aa387dc2dddb1dff Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 16:40:39 2019 +0900 Update initial_salt commit f0602a6e187e456b85e34b97d4aff6d2be9789ed Author: Masakazu Kitajo <maskit@apache.org> Date: Fri Jul 5 16:16:42 2019 +0900 Add active_connection_id_limit Transport Parameter commit 923916d7f0bbea19367fdfc7b2ddf430c5a54233 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 4 17:22:48 2019 +0900 Update draft version numbers to 22 commit e95f03599f42743e8774908c9a8d0879f5c59890 Author: Masakazu Kitajo <maskit@apache.org> Date: Thu Jul 11 12:40:22 2019 +0900 Fix a heap-use-after-free in path validation commit c444068c28fe1693e056596faf3039ad0adde8e3 Merge: eb4092333 8510a1c24 Author: Masakazu Kitajo <maskit@apache.org> Date: Wed Jul 10 11:51:27 2019 +0900 Merge branch 'master' into quic-latest * master: Log H2 errors with the codes Separate out common header compression logic to hdrs directory TSIOBufferReaderCopy: copy data from a reader to a fixed buffer. Remove unused header file ink_inout.h Remove unused LibBulkIO Reverse internal order of HPACK Dynamic Table Entries More Autest cleanup Conflicts: proxy/hdrs/Makefile.am proxy/http2/HPACK.cc commit eb4092333da5734acd9cf6b933a97f6b160c0b14 Author: Masakazu Kitajo <maskit@apache.org> Date: Tue Jul 9 09:25:35 2019 +0900 Fix QUICPath::operator== commit 10805ba0dfe346dfbe93dad24656110e6d5fb250 Author: scw00 <scw00@apache.org> Date: Mon Jul 8 10:08:29 2019 +0800 QUIC: remove useless params in padder commit b0f248334200ec10be9d87d8593d7f46b4c88104 Author: scw00 <scw00@apache.org> Date: Mon Jul 8 09:25:28 2019 +0800 QUIC: Add inline generators into QUICFrameGenerator commit b76299f09e128e17d7103ee5ca5c72f3f4f67b22 Author: scw00 <scw00@apache.org> Date: Sun Jul 7 13:20:11 2019 +0800 QUIC: Add QUICPinger test commit fdff5b96f24e0d681884a1553ae1203161e9efaa Author: scw00 <scw00@apache.org> Date: Sun Jul 7 12:21:08 2019 +0800 QUIC: Fix test commit 816305894503400861fc4e830f464c6a3a3b1b41 Author: scw00 <scw00@apache.org> Date: Sun Jul 7 12:07:34 2019 +0800 QUIC: Using weight for QUICFrameGenerators commit 1eeb804564afb7db5164c8db90e6b5bcedd86b3e Author: scw00 <scw00@apache.org> Date: Thu Jul 4 08:58:15 2019 +0800 QUIC: Split QUICFrameGenerator into two queue (cherry picked from commit a80d779480e51c61e82d36f8e152d8d3ffa2367c)

view details

Bryan Call

commit sha e589e8e15df1033c5fca4c4e038cb773ca8a0285

Add filename to error message in header_rewrite (cherry picked from commit 32b5dae814310f8b6386638b6024bde4aecedb1b)

view details

Fei Deng

commit sha e0d70d66dd97713c8183ad8f2d6f035f3fac3d31

do not schedule stuff during shutdown (cherry picked from commit d970c3787d20ad6c7a0d04bb9ac23988f6fd2962)

view details

Masakazu Kitajo

commit sha 08ed0619e28f1b2aa396a7adf18792f56aad8409

Destroy MIMEFieldBlockImpl that doesn't have fields in use Because MIMEFieldBlocks are destroyed only when MIMEHdr is destroyed, the block chain never be short. With this change, a block will be destroyed when all fields in a block are deleted, and the block will be removed from a block chain. (cherry picked from commit 482e30accbe2e755c73fd1f8dd7e4b2c40705171)

view details

Masakazu Kitajo

commit sha 1f5b382a99d1bf092b92a2a68b3506c57eaedf32

Fix a build issue on enabling FIPS (cherry picked from commit 526efb0a22a2018ee79ac4851f5e392a47acbd37)

view details

Evan Zelkowitz

commit sha 3a2740df9993c3d564d6b7759123a8845f8e9458

Change the ready checks for ats to use the actual ats port and not the server port. Add ready check on server port for the server (cherry picked from commit 29b1dc90e276813dd1b62cde881bb8f806065eaa)

view details

xinli1

commit sha 582c8cbada501df7f27a718e4ba616574655c6c8

log filter enhancement fix the bug if filter word included in param value (cherry picked from commit d3ed0276545774d989d050fe57fdf7dd3877b49c) fix the bug if filter word included in param value (cherry picked from commit 601d090b07f64a90cbf11bf55d6c1fad83f34f2d) fix typo issue (cherry picked from commit 16ddd19307dc8a04a05bf5cbe8afedd00c538019) move code to utility function to reduce the interface size (cherry picked from commit 89bed7bcbc5b57652f9392b1905908d993483674) code clean from review comments (cherry picked from commit ca24696ab407f532cb090a0abd40c1a5edb99d40) 1) add autest for log filter; 2) support filter for duplicated param name in query parm of URL (cherry picked from commit 87db2452595ccbc2498a5eecc31dc9d2a67be62c)

view details

Eric Schwartz

commit sha c5b3203dc79363550db15e800b5189fc47784610

pipe buffer size for log.pipe should be configurable Conflicts: proxy/logging/YamlLogConfig.cc (cherry picked from commit 45592cff2f8e424f87c80059a62befdbfdd06633)

view details

Eric Schwartz

commit sha 91fb9b7447bd723b9a70d3c22f4624f547803fe5

address review comments (cherry picked from commit 8e4776c24e58e9bf41a6040a3aad71fd64e3a1ef)

view details

Valentin Gutierrez

commit sha e2bce63311122e3e317f175ab7cd87c99e9fa86c

Cache SSL EC explicitly (cherry picked from commit 757256129811441f29eea288b1d7e19bc54fab9c)

view details

Sudheer Vinukonda

commit sha 9c242f120fbd84157efc4d68336bdc6a9f67a324

Fix use-after-free problem related to logging headers mime_header_value_set() has a coalesce logic to coalesce dead allocations in the header heap and in the process can free up previously allocated strings that Logging references (cquuc etc). When logging tries to access those fields subsequently it results in a use-after-free (caught using ASAN build). In the wipe field logging use case, there isn't a need to recreate new header heaps, just need to replace the fields with wiped values. So, added a new utility function to simply overwrite the fields. The fix has been retested with ASAN and looks good on prod host. (cherry picked from commit 702c6ac75cc416b988a1f8407baebeb1986e6bb3)

view details

Bryan Call

commit sha f336266ace49737c43e7c86f5a3fa7a63db67ba6

Removed hardcoded logging.yaml filename in logs (cherry picked from commit 173173fc14bbcd8b43b60727c1a2a59565b844b1)

view details

push time in 15 days

push eventnetlify/trafficserver

push time in 15 days

push eventnetlify/trafficserver

bneradt

commit sha f6dadd5de44a994c0b0920ef171eaaa92d94e3b8

Removing traffic_cop reference in Admin Guide introduction. The introduction to our Administrator's Guide referenced three processes but only described two: traffic_manager and traffic_server. The third process was probably traffic_cop. But we currently now only run with traffic_server and traffic_manager. This adjusts the number of referenced processes from three to two and removes the image which is not as helpful anymore with only two processes that collaborate.

view details

bneradt

commit sha 8fcb137d361ee063e720b183be4c767b7ecda53e

Adding verify plugin TS maintenance commands This adds the verify_global_plugin and verify_remap_plugin maintenance commands.

view details

Susan Hinrichs

commit sha 0cbe04cfbd903e266ab7ae8f194bc75459a35008

Fix sni.yaml fqdn to match complete name string

view details

Brian Neradt

commit sha 2af0dce59513edaefe4885bc5c77e48666246d08

Some tweaks to reloading-plugins.en.rst (#6251)

view details

John Rushford

commit sha 0da369c80e2a846e5e8fdbdc3b27c57f6af2e3dd

Add some stats collections to cache_promote.

view details

Masaori Koshiba

commit sha c55001bec19d4db63f58b484186b942fbec5ae2a

Avoid unnecesarry copy on POST request over HTTP/2

view details

Brian Olsen

commit sha e622ae26bf1bb4a3dd815c066bd547d97e2e9185

remap_stats: restore handling of remap/hostname to remove memory leak

view details

bneradt

commit sha fa6e5731762ed41c6f31aa89b18579362302d326

auto delete rolled log file fixes This fixes auto delete registration for: - core log files that were not getting deleted (such as error.log and manager.log) as well as... - plugin log files. To make log deletion registration more automatic, I placed it in LogObject initialization so that it doesn't have to happen in as many disparate places. By doing this, plugin log auto delete comes for free. This is why nothing in the core plugin implementation needed to be changed to register their log files, for instance. Not all log objects are managed by LogObject, however, so we still have some manual calls to registration in LogConfig for core log files (such as traffic.out and diags.log, for example). Before this change, LogConfig manipulated deleting_info to create and maintain candidates. To encapsulate this logic, I created RolledLogDeleter and changed LogConfig to interact with an instance of that. This simplified the LogConfig logic while also enabling unit testability of the main log deletion feature. This also: - Adds a rolling_max_count autest. - Fixes a shutdown leak concerning LogDeletingInfo. - Fixes a paramater mismatch between TextLogObject and LogObject.

view details

Evan Zelkowitz

commit sha 3bfb95f69ef1939622ff5992b3ef2e24ed3023e2

Initial revision of .lgtm.yml config file (#6258) This allows for doing security code analysis via lgtm.com. This is just the first known good config I have tried that could successfully run a build. There are many options if we wish to exclude certain files/dir or other pre/post build options: https://help.semmle.com/lgtm-enterprise/user/help/lgtm.yml-configuration-file.html

view details

Masaori Koshiba

commit sha 9987d720ef75010612972695c8ac1ca4eefa555f

Fix TS_USE_DIAGS usage for --disable-diags option

view details

Alan M. Carroll

commit sha 5dafd97c9f106bf56cda450a57346168e44e077f

TCL: cleanup in HostLookup.cc, make sure keys are stable. (#6263)

view details

Randall Meyer

commit sha 9d51c2f9e68451a2450497d8c3b3fbf8ce0cbc04

Fixes various crashers loading/reloading parent.config Fixes issue #5976

view details

John Rushford

commit sha c4a30b2290d1f07b28e528db5cd125e1a1f1ceba

LGTM: fix a comparison that is always false. Fixes a comparison error in NextHopSelectionStrategy::markNextHopUp() that prevents a host restoral message from being logged.

view details

John Rushford

commit sha 34a9e2784c7df0af7a6e66ba3b642833563e92d9

LGTM: fixes a shadowed variable in ParentSelection::PreprocessParents().

view details

Masaori Koshiba

commit sha 2d13010119b923d674f9bab555f1c49e00f1d29a

Change HTTP/2 error rate log to warning

view details

Masaori Koshiba

commit sha 721efc3b8b5f1d1ac2b11ac2c6019ea62eb91e20

LGTM: Fix wrong type of arguments to formatting function

view details

Masaori Koshiba

commit sha a139fd194eb2906a28781e5e7e1940a076ed60ce

LGTM: Add header guards

view details

Evan Zelkowitz

commit sha 27225d85b3bb83f4ca07978daeeb8f6906eb77e6

Remove -j from lgtm build (#6274) The lgtm build seems to be hanging some times for an hour or two, which can then lead to the build timing out when it keeps going. Removing the -j option thinking this might be causing resource contention with the builds. Have done a successful test build using this config

view details

Walter Karas

commit sha e2642f9969fbc82c5c3b7a52c2cd92cbc14564d2

For per-transaction config override, crossing the const-correctness event horizon. And falling into the black hole.

view details

Walter Karas

commit sha 770f9d4f5a6825465f2ae5a681c5f3896479f635

Copy the Client SNI Server Name out of the openssl SSL object and ensure it is null-terminated.

view details

push time in 15 days

pull request commentapache/trafficserver

Cleanup RamCacheCLFUS

fair question. I just went through the rest of the code base and it looks like this change is consistent with many other classes as it is. So let's merge it, no need to change anything. :+1:

scw00

comment created time in 16 days

pull request commentapache/trafficserver

TLSv1.3 0-RTT support

This as been onDocs for two months already, anything else to do here before merging, @zwoop ?

duke8253

comment created time in 16 days

issue commentapache/trafficserver

☂ v9.0.0 Release Stoppers

@zwoop was this issue removed? the link goes to the 404 page for me:

Assertion in HttpSM (regression) #4921

zwoop

comment created time in 17 days

startedjamesmunns/bbqueue

started time in 18 days

push eventcalavera/vegandollhouse.com

David Calavera

commit sha b84b30efd5d8f688a9aac003fc8bd234db2394b4

Fix unterminated template

view details

push time in a month

push eventcalavera/vegandollhouse.com

David Calavera

commit sha 80ff28d20af599257c0f0521a8dff984faef4fba

Show pinterest button in pages that have a pin description.

view details

push time in a month

create barnchnetlify/trafficserver_rs

branch : master

created branch time in a month

created repositorynetlify/trafficserver_rs

created time in a month

pull request commentnetlify/netlify-commons

Build static godoc

we should merge this and write a blog post @mraerino :wink:

mraerino

comment created time in a month

created tagnetlify/netlify-commons

tagv0.24.0

created time in a month

delete branch netlify/netlify-commons

delete branch : chi_mount

delete time in a month

push eventnetlify/netlify-commons

David Calavera

commit sha f2162509eb9563a281fa2521813487ee3f467031

Expose Mount from the chi Router. So you can mount other custom handlers. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha 94019701cadcf091554718356a647da290f936d7

Merge pull request #102 from netlify/chi_mount Expose Mount from the chi Router.

view details

push time in a month

PR merged netlify/netlify-commons

Expose Mount from the chi Router.

So you can mount other custom handlers.

+12 -3

2 comments

1 changed file

calavera

pr closed time in a month

pull request commentnetlify/netlify-commons

Expose Mount from the chi Router.

It's also nicer to actually have access to the real router, and not a trimmed version.

calavera

comment created time in a month

pull request commentnetlify/netlify-commons

Expose Mount from the chi Router.

we've often done

I don't want to enforce the HTTPError that our custom handler enforces, because of reasons :wink:

calavera

comment created time in a month

push eventnetlify/netlify-commons

David Calavera

commit sha f2162509eb9563a281fa2521813487ee3f467031

Expose Mount from the chi Router. So you can mount other custom handlers. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in a month

PR opened netlify/netlify-commons

Expose Mount from the chi Router.

So you can mount other custom handlers.

+12 -3

0 comment

1 changed file

pr created time in a month

create barnchnetlify/netlify-commons

branch : chi_mount

created branch time in a month

delete branch netlify/open-api

delete branch : chore/remove-obsolete

delete time in a month

push eventnetlify/open-api

Marcus Weiner

commit sha 6dc16c4d8d78932c01b45eb615b0d319ad1b8310

Remove obsolete okbody structs

view details

David Calavera

commit sha 46bb032811074be45b6fa82153a1f39ef870da64

Merge pull request #206 from netlify/chore/remove-obsolete Remove obsolete okbody structs

view details

push time in a month

PR merged netlify/open-api

Reviewers
Remove obsolete okbody structs

This is the result of running make generate. Those structs are not referenced anywhere in the client code and I don't think anybody needs them as part of the public lib.

+0 -987

1 comment

21 changed files

mraerino

pr closed time in a month

PR opened mholt/archiver

Replace Zip and Flate packages.

Use the optimized versions from github.com/klauspost/compress. In smoke tests, compressing 7K files took 3 seconds, rather than 12 seconds with the official packages.

+3 -2

0 comment

1 changed file

pr created time in a month

create barnchcalavera/archiver

branch : compress_zip

created branch time in a month

fork calavera/archiver

Easily create & extract archives, and compress & decompress files of various formats

https://godoc.org/github.com/mholt/archiver

fork in a month

startedcloudflare/lazyhtml

started time in a month

create barnchcalavera/vegd

branch : master

created branch time in 2 months

created repositorycalavera/vegd

created time in 2 months

create barnchnetlify/trafficserver

branch : apache_7_1_7_patch_3

created branch time in 2 months

create barnchnetlify/trafficserver

branch : apache_7_1_7_patch_2

created branch time in 2 months

create barnchnetlify/trafficserver

branch : patch_7_1_7

created branch time in 2 months

delete branch netlify/trafficserver

delete branch : request_smuggling

delete time in 2 months

create barnchnetlify/trafficserver

branch : request_smuggling

created branch time in 2 months

MemberEvent

delete branch netlify/trafficserver

delete branch : apache_7_1_x_smuggle_fix

delete time in 2 months

PR closed netlify/trafficserver

Request smuggling fix.

Patch to fix request smuggling on top of ATS 7.1.8.

+48083 -10444

0 comment

1205 changed files

calavera

pr closed time in 2 months

PR opened netlify/trafficserver

Request smuggling fix.

Patch to fix request smuggling on top of ATS 7.1.8.

+48083 -10444

0 comment

1205 changed files

pr created time in 2 months

create barnchnetlify/trafficserver

branch : apache_7_1_x_smuggle_fix

created branch time in 2 months

create barnchnetlify/trafficserver

branch : apache_7_1_x

created branch time in 2 months

created tagnetlify/trafficserver

tag7.1.8

Mirror of Apache Traffic Server

created time in 2 months

push eventcalavera/functest

David Calavera

commit sha 0fd85b3a511bad6c97c69a234b324cfd089cb2aa

fix process Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/functest

David Calavera

commit sha 5ad983fb6c285c3f466d588643892247cb7f79ad

fix process Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/functest

David Calavera

commit sha f53e002f20af48559a974755c769318efcef3976

print version Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

create barnchcalavera/functest

branch : master

created branch time in 2 months

created repositorycalavera/functest

created time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha e14955eed06d3fea85131d09dc1464903163c54d

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha 8218fe6336b74e484852ab53c6a7c75a8d132157

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

created tagcalavera/gobpf

tagv0.1.0

Go bindings for creating BPF programs.

created time in 2 months

created tagcalavera/gobpf

tag0.1.0

Go bindings for creating BPF programs.

created time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha 019e6b2412c65f48627543b7bf0c8d4c3a39a32d

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha f5bcd0c6bbb379c86c15c5c649e8632d7241ce68

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha e4263cea33b2c21ee6f78ccedf2c3a4602851d96

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

push eventcalavera/gobpf

David Calavera

commit sha 26b0a7faa7b95aa27cf9df61d766adc70457c470

Improve function attachment Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

push time in 2 months

create barnchcalavera/gobpf

branch : elf_attach_functions

created branch time in 2 months

created tagnetlify/netlify-commons

tagv0.23.0

created time in 2 months

delete branch netlify/netlify-commons

delete branch : update_goenv

delete time in 2 months

push eventnetlify/netlify-commons

David Calavera

commit sha 192ab80eb1c48d945b537b5b998bffa3f0b76229

Update envconfig to 1.4.0. Fix issue with capital letters in variables. Signed-off-by: David Calavera <david.calavera@gmail.com>

view details

David Calavera

commit sha f0ef76851e76bdb7a9821a1415273916c5652a91

Merge pull request #101 from netlify/update_goenv Update envconfig to 1.4.0.

view details

push time in 2 months

PR merged netlify/netlify-commons

Update envconfig to 1.4.0.

Fix issue with capital letters in variables.

+5 -12

0 comment

2 changed files

calavera

pr closed time in 2 months

PR opened netlify/netlify-commons

Update envconfig to 1.4.0.

Fix issue with capital letters in variables.

+5 -12

0 comment

2 changed files

pr created time in 2 months

create barnchnetlify/netlify-commons

branch : update_goenv

created branch time in 2 months

pull request commentapache/trafficserver

remap_stats: restore handling of remap/hostname to remove memory leak

Should this go into 9, @traeak @zwoop?

traeak

comment created time in 2 months

issue closednetlify/netlify-setup-heuristics

ensure warning about "this looks like a Jekyll site" is properly targeted

Apparently the github-pages gem includes jekyll under the hood, so we should warn more appropriately about that when it is present rather than jekyll.

(ref https://app.intercom.io/a/apps/q245f50x/inbox/a/search/conversations/6486406473 )

closed time in 2 months

fool

Pull request review commentapache/trafficserver

Fixes various crashers loading/reloading parent.config

 CharIndex::iterator::advance() -> self_type &       break;     } else if (state.block->array[state.index].block != nullptr) {       // There is a lower level block to iterate over, store our current state and descend-      q[cur_level++] = state;-      state.block    = state.block->array[state.index].block.get();-      state.index    = 0;+      if (static_cast<int>(q.size()) <= cur_level) {+        q.push_back(state);+      } else {+        q[cur_level] = state;

the old code incremented cur_level after the lookup, but the new one doesn't, is that on purpose?

randall

comment created time in 2 months

issue commentapache/trafficserver

Plugin memory leak with TSMutexCreate

At worst, I can put up a PR that backs out the mutex cleanup portion of the PR.

:+1: Thanks @shinrich :raised_hands:

traeak

comment created time in 2 months

issue commentapache/trafficserver

Plugin memory leak with TSMutexCreate

If that's the ideal solution, I guess it should be replaced in all plugins in this repository, and make sure that it's very explicitly documented in the docs and the release notes. This is a big breaking change.

traeak

comment created time in 2 months

issue commentapache/trafficserver

Plugin memory leak with TSMutexCreate

It might not be as easy as it sounds, there have been other patches built upon that one. However, I agree that it requires a more global fix since this potentially affect many plugins in production.

Maybe @shinrich or @duke8253 have some ideas to fix this problem since they worked in #4926 and #5879.

traeak

comment created time in 2 months

push eventcalavera/slack

David Calavera

commit sha a3f0a90c41a3b789cd60688e9bdadadecb8240e6

Parse slash command from url.Values This allows implementations to not rely on http Requests. This is useful for environments like AWS Lambda where you don't get an http.Request object.

view details

push time in 2 months

fork calavera/slack

Slack API in Go

fork in 2 months

issue commentdropbox/goebpf

Perf events was supported?

Hi @belyalov, is there a branch that people can see with the initial implementation?

I was wondering the same thing this morning. I'll be more than happy to help if it's blocked or you don't have much time to focus on it right now.

annp1987

comment created time in 2 months

push eventnetlify/actions

Brian Douglas

commit sha 5bd95bb059a209d2ac0e5db685462031ccceb6bc

show example in the docs

view details

Brian Douglas

commit sha ea13c3fa5184ce735f6738643b4ac43f383016c0

Update README.md

view details

David Calavera

commit sha a34a07203368d0c554b7d9425cba71b99b40d3f8

Merge pull request #17 from bdougie/patch-1 show example in the docs

view details

push time in 2 months

PR merged netlify/actions

show example in the docs

What is this?

I know this was an Action ship during the v1 launch. I am actually using this for a project and considering using this in some example content the GitHub Actions feature.

+15 -0

0 comment

1 changed file

bdougie

pr closed time in 2 months

pull request commentapache/trafficserver

Graduate TSHttpTxnServerPush to the stable API interface

@zwoop maybe this should be in the "What's new" section in the release? if it's not already.

calavera

comment created time in 3 months

delete branch netlify/trafficserver

delete branch : graduate_server_push_api

delete time in 3 months

delete branch netlify/trafficserver

delete branch : reverse_debug_specific_check

delete time in 3 months

startedtikv/tikv

started time in 3 months

issue openedapache/trafficserver

Very poor performance when diags.debug is enabled

We've ran some benchmarks and the difference between having diags.debug enabled or not is abysmal. You can easily reproduce, the numbers in the screenshot below are from running h2load on my local machine:

h2load --h1 -t 40 -D 60 -n 10000 -c 40 http://localhost

Screenshot from 2019-11-06 15-30-07

Being able to see debug logs is critical in trace issues in development, we use them extensively, and this drop in performance is a big issue for us:

created time in 3 months

create barnchnetlify/trafficserver

branch : rw_lock

created branch time in 3 months

more