ashfurrow ( Ash Furrow )

commit sha 9accfdff28fc7b2cdab78fd1a74b9bb5324002b9

Site updated to c6b898d

fix(city guide): fix cta images not showing up

push time in a day

PullRequestReviewEvent

PR opened artsy/echo

Reviewers

Adds schema validation

This came up in KS on Tuesday and I wanted to give it a shot. Turns out: not too hard! This is the first time I've used JSON schemas, so feedback is encouraged. I looked into validating the date format but things got tricky – these are the important bits, anyway.

+76 -0

2 commit in artsy/echo/tree/schema-validate artsy/echo/tree/master

0 comment

5 changed files

pr created time in a day

create barnchartsy/echo

branch : schema-validate

created branch time in a day

Pull request review commentartsy/eigen

 target 'Artsy' do    pod 'Emission', path: './emission' -  pod 'React', path: 'node_modules/react-native'-  if ENV['CIRCLE_BUILD_NUM']-    pod 'React-Core', path: 'node_modules/react-native'-  else-    pod 'React-Core', path: 'node_modules/react-native', subspecs: ['DevSupport']

Okay, so it seems we can move this to when we invoke use_react_native!?

use_react_native! production:  ENV['CIRCLE_BUILD_NUM']

pvinis

comment created time in a day

PullRequestReviewEvent

Pull request review commentartsy/eigen

fix(city guide): fix cta images not showing up

 target 'Artsy' do    pod 'Emission', path: './emission' -  pod 'React', path: 'node_modules/react-native'-  if ENV['CIRCLE_BUILD_NUM']-    pod 'React-Core', path: 'node_modules/react-native'-  else-    pod 'React-Core', path: 'node_modules/react-native', subspecs: ['DevSupport']

We should make sure that the beta builds don't ship with this enabled 😅

pvinis

comment created time in a day

PullRequestReviewEvent

push eventartsy/eigen

Brian Beckerle

commit sha 5c0d98aea14bb501d0d40b1b4b887bb3df3e6b37

Update patch to select correct window in when input window is present (#4048)

fix: select correct window in react-image-crop-picker when input window is present

push time in a day

delete branch artsy/eigen

delete branch : brian/fix-blank-screen-on-submit

delete time in a day

PR merged artsy/eigen

fix: select correct window in react-image-crop-picker when input window is present Jira Synced

The type of this PR is: Bugfix

This PR resolves CX-711

Description

We do some swizzling in the AppDelegate that causes [[UIApplication sharedApplication] delegate] window] to return nil. react-native-image-crop-picker uses this method to find the viewController to present the picker onto so we had a patch that grabbed the last window in the hierarchy to workaround this issue. In the My Collection flow this was returning the wrong window, specifically a UIInputWindow that manages presentation of the keyboard. This PR updates our existing patch for react-native-image-crop-picker to look for our custom window subclass instead which should return the correct window, and falls back to the last window if it can't find the subclass.

Before

before-image-crop

After

after-image-crop

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

+27 -6

2 commit in artsy/eigen/tree/brian/fix-blank-screen-on-submit artsy/eigen/tree/master

1 comment

3 changed files

brainbicycle

pr closed time in a day

Pull request review commentartsy/eigen

 diff --git a/node_modules/react-native-image-crop-picker/ios/.DS_Store b/node_modules/react-native-image-crop-picker/ios/.DS_Store new file mode 100644-index 0000000..5172429-Binary files /dev/null and b/node_modules/react-native-image-crop-picker/ios/.DS_Store differ+index 0000000..e69de29 diff --git a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m-index 25ead1a..3b431c8 100644+index 25ead1a..ea872d1 100644 --- a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m +++ b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m-@@ -124,7 +124,7 @@ - (void) setConfiguration:(NSDictionary *)options+@@ -123,8 +123,19 @@ - (void) setConfiguration:(NSDictionary *)options+     }  }  - - (UIViewController*) getRootVC {+-- (UIViewController*) getRootVC { -    UIViewController *root = [[[[UIApplication sharedApplication] delegate] window] rootViewController];-+    UIViewController *root = [[[[UIApplication sharedApplication] windows] lastObject] rootViewController];++- (UIViewController *) getRootVC {++    UIWindow *presentingWindow;++    for (UIWindow *window in [[UIApplication sharedApplication] windows]) {++        if ([window isKindOfClass:NSClassFromString(@"ARWindow")]) {++            presentingWindow = window;++        }++    }++    if (!presentingWindow) {++        NSAssert(false, @"Unable to find ARWindow did it get renamed?");

Great work, this 👍

brainbicycle

comment created time in a day

PullRequestReviewEvent

Pull request review commentartsy/eigen

fix: select correct window in react-image-crop-picker when input window is present

 diff --git a/node_modules/react-native-image-crop-picker/ios/.DS_Store b/node_modules/react-native-image-crop-picker/ios/.DS_Store new file mode 100644-index 0000000..5172429-Binary files /dev/null and b/node_modules/react-native-image-crop-picker/ios/.DS_Store differ+index 0000000..e69de29 diff --git a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m-index 25ead1a..3b431c8 100644+index 25ead1a..ea872d1 100644 --- a/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m +++ b/node_modules/react-native-image-crop-picker/ios/src/ImageCropPicker.m-@@ -124,7 +124,7 @@ - (void) setConfiguration:(NSDictionary *)options+@@ -123,8 +123,19 @@ - (void) setConfiguration:(NSDictionary *)options+     }  }  - - (UIViewController*) getRootVC {+-- (UIViewController*) getRootVC { -    UIViewController *root = [[[[UIApplication sharedApplication] delegate] window] rootViewController];-+    UIViewController *root = [[[[UIApplication sharedApplication] windows] lastObject] rootViewController];++- (UIViewController *) getRootVC {++    UIWindow *presentingWindow;++    for (UIWindow *window in [[UIApplication sharedApplication] windows]) {++        if ([window isKindOfClass:NSClassFromString(@"ARWindow")]) {++            presentingWindow = window;++        }++    }++    if (!presentingWindow) {++        NSAssert(false, @"Unable to find ARWindow did it get renamed?");++        presentingWindow = [[[UIApplication sharedApplication] windows] lastObject];++    }++++    UIViewController *root = [presentingWindow rootViewController];

Yeah, it was to fix this same bug actually! But that change didn't cover the case that Brian outlined, this patch is much more specific 👍

brainbicycle

comment created time in a day

PullRequestReviewEvent

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha a256398b095a401115285c8db42914c66e88afa9

Site updated to c6b898d

push time in 2 days

push eventartsy/eigen

commit sha 437c4ddf642b26ef4522f0af6fd6004b535cf6ed

fix(home): auctions rail capitalization (#4042) * fix capitalization * changelog

Handle new files that have a single line

push time in 2 days

delete branch artsy/eigen

delete branch : capitalization-in-home-auctions-rail

delete time in 2 days

PR merged artsy/eigen

Reviewers

fix(home): auctions rail capitalization Jira Synced

The type of this PR is: Bugfix

This PR resolves CX-731

Description

Fixes capitalization in home rail, by reusing the logic we have for the auctions screen.

Screenshot 2020-10-21 at 13 59 16

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

+20 -11

2 commit in artsy/eigen/tree/capitalization-in-home-auctions-rail artsy/eigen/tree/master

0 comment

4 changed files

pvinis

pr closed time in 2 days

PullRequestReviewEvent

pull request commentashfurrow/danger-rubocop

Okay! That's been released as 0.9.1.

joeltaylor

comment created time in 2 days

created tagashfurrow/danger-rubocop

tag0.9.1

Danger plugin for Rubocop

created time in 2 days

push eventashfurrow/danger-rubocop

commit sha 71c075299409b40789e8d5c674058fcd06c0940b

Version bump.

push time in 2 days

push eventashfurrow/danger-rubocop

Joel Taylor

commit sha ed077e27513214194ace507b43448f7e4d70758c

Handle new files that have a single line

commit sha 48a6a4dbd0d91c01157dbe3b381fb9c30919232f

Merge pull request #42 from joeltaylor/master Handle new files that have a single line

push time in 2 days

PR merged ashfurrow/danger-rubocop

Handle new files that have a single line

Problem

danger-rubocop fails to check new files that only have a single line and instead results in NoMethodError: undefined method 'captures' for nil:NilClass

This is due the the git diff not matching the original regex.

Solution

Account for diff hunk identifiers that have the format @@ -\d,\d +\d @@

+21 -1

1 commit in joeltaylor/danger-rubocop/tree/master ashfurrow/danger-rubocop/tree/master

0 comment

2 changed files

joeltaylor

pr closed time in 2 days

PullRequestReviewEvent

delete branch artsy/peril-settings

delete branch : enable-rfc-327-commit-formatting-check-for-volt-prs-take-ii

delete time in 2 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha 9ce2658e6249d1993a18d654e24c2bda374453ac

Site updated to c6b898d

chore: Add default export to rfc_327

push time in 3 days

pull request commentartsy/peril-settings

Yes! That’s correct.

dblandin

comment created time in 3 days

issue commentashfurrow/Nimble-Snapshots

One snapshot to test them all

Hi there, and thanks for the question. This is the exact right place.

So let's see if I understand – the question is how developers can run their unit tests across many different device simulators and get a reliable answer? It's a tricky problem because, just like iOS versions, the emulated hardware can create snapshot differences. At Artsy, we rely on using the same device simulator for unit testing (same iOS version and same device).

We try to do our best with this testing utility, which tries to mimic what an actual device would be. The code is Objective-C and we haven't used it for new tests in a while (we've moved to React Native).

https://github.com/artsy/eigen/blob/156ff472a15ee63493a60344e30f4bee3a532f3e/Artsy_Tests/Supporting_Files/ARTestContext.m

Here is an example use:

https://github.com/artsy/eigen/blob/156ff472a15ee63493a60344e30f4bee3a532f3e/Artsy_Tests/View_Controller_Tests/Components/ARSerifNavigationViewControllerSpec.m#L26-L59

I hope that helps! I would highly recommend your dev team all use the same simulator and test device for local unit tests, though. It's the best way to get reliable results.

MrRipcord

comment created time in 3 days

pull request commentashfurrow/Nimble-Snapshots

fix conflict with nimble bridging header

Okay! Released as version 9.0.0. Thanks again!

robinbonin

comment created time in 3 days

commit sha c9a1e1645d48b75ed4196fa3c07b42597fe76611

Version bump.

push time in 3 days

issue openedashfurrow/Nimble-Snapshots

Fix CI

Our CI has been red since #203 upgraded to Xcode 12. I haven't had time to look into this yet.


❌  /Users/distiller/Nimble-Snapshots/Nimble_Snapshots/PrettySyntax.swift:48:3: argument labels '(file:, line:, _:)' do not match any available overloads

  expect(file: file, line: line, snapshottable).to(recordSnapshot())
^



❌  /Users/distiller/Nimble-Snapshots/Nimble_Snapshots/PrettySyntax.swift:53:3: argument labels '(file:, line:, _:)' do not match any available overloads

  expect(file: file, line: line, snapshottable).to(recordSnapshot(named: name))
  ^

I'd appreciate any help here.

created time in 3 days

created tagashfurrow/Nimble-Snapshots

tag9.0.0

Nimble matchers for FBSnapshotTestCase.

created time in 3 days

Robin Bonin

commit sha 30673d894fb3ff12e15c7b93f6b6d22ecfeaa649

fix conflict with nimble bridge

Robin Bonin

commit sha 114db1082594733f3c8502608ce84e0acdaadaaf

fix lint

commit sha addec3318269400b93fb5a591da5fe22f272a40b

Merge pull request #210 from robinbonin/fix/bridge-conflict fix conflict with nimble bridging header

fix conflict with nimble bridging header

push time in 3 days

PR merged ashfurrow/Nimble-Snapshots

fix conflict with nimble bridging header

Hi!

We're getting this compiler error, where there is a conflict in naming for the shared instance of CurrentTestCaseTracker.

Not sure if I can get around it in some other way, but this solves it for us.

/.../Build/Products/Debug-iphonesimulator/Nimble/Nimble.framework/Headers/Nimble-Swift.h:230:103: 'CurrentTestCaseTracker' has different definitions in different modules; first difference is definition in module 'Nimble.Swift' found property name 'sharedInstance'

/.../Build/Products/Debug-iphonesimulator/Nimble-Snapshots/Nimble_Snapshots.framework/Headers/Nimble_Snapshots-Swift.h:216:103: But in 'Nimble_Snapshots.Swift' found property name 'shared'

+3 -2

2 commit in robinbonin/Nimble-Snapshots/tree/fix/bridge-conflict ashfurrow/Nimble-Snapshots/tree/master

2 comments

2 changed files

robinbonin

pr closed time in 3 days

pull request commentashfurrow/Nimble-Snapshots

Okay, I'll get this merged, add a changelog entry, and release it as a major version.

robinbonin

comment created time in 3 days

Pull request review commentartsy/Aerodramus

chore: replace Echo with S3

 #import "AeroRouter.h"  @interface AeroRouter()-@property (nonatomic, readonly, copy) NSString *APIKey; @property (nonatomic, readonly, copy) NSURL *baseURL; @end  @implementation AeroRouter -- (instancetype)initWithAPIKey:(NSString *)APIkey baseURL:(NSURL *)baseURL+- (instancetype)initWithBaseURL:(NSURL *)baseURL {     self = [super init];     if (!self) { return nil; } -    _APIKey = APIkey;     _baseURL = baseURL;      return self; }  - (NSURL *)urlForPath:(NSString *)path {-    return [NSURL URLWithString:path relativeToURL:self.baseURL];+    return [self.baseURL URLByAppendingPathComponent:path]; } -- (NSURLRequest *)headLastUpdateRequestForAccountID:(NSInteger)account+- (NSURLRequest *)headLastUpdateRequest {-    NSURL *url = [self urlForPath:[NSString stringWithFormat:@"/accounts/%@", @(account)]];+    NSURL *url = [self urlForPath:[NSString stringWithFormat:@"Echo.json"]];

I think we'll need some way to specify using Echo.staging.json here instead? Maybe we can add another parameter to initWithBaseURL: like initWithBaseURL:fileName: – happy to pair on this.

ashfurrow

comment created time in 3 days

PullRequestReviewEvent

delete branch artsy/echo

delete branch : s3

delete time in 3 days

push eventartsy/echo

commit sha 8c58c966f6e29d3390c8d3891f0cfb5d07d9d782

clean up

commit sha 0ef8bce7961a3fdb3730840005912531c454a9d9

add example file

commit sha 635764f59f9eb64371d3627d4d0027a118d3b750

some docs

commit sha 3cf070cc350d42fbabf4c70495ecdac75487cc61

scripts and echo.json

commit sha f2fa31a7a1651283133bf08d1b2357a7ee231fb9

lint and tools

commit sha 63c5359b93d9daa2b0daf342e839df7b3e3d4c19

ci

commit sha 505cfccaa6d585c48d41af847305f818680717ba

Merge pull request #39 from artsy/s3 Move echo to S3 🎉

push time in 3 days

PR merged artsy/echo

Move echo to S3 🎉

Follow up:

[ ] make a production branch from master.
[x] fixup https://releases.artsy.net/admin/projects/56 to have master instead of s3 and production instead of s3-production for all stages and deploy strategies.
[x] Do we need a way to force deploy, even if there are no json changes? 🤔 No. Even if we do, it's easy enough to add a dummy flag.

+373 -1708

6 commit in artsy/echo/tree/s3 artsy/echo/tree/master

1 comment

78 changed files

pvinis

pr closed time in 3 days

Pull request review commentartsy/echo

Move echo to S3 🎉

 # echo -**NOTE TO ARTSY STAFF**: The `master` branch is currently not deployable. The last deployed branch is `ash-deploy`, so any urgent fixes should be made from there. See [PLATFORM-1300](https://artsyproduct.atlassian.net/browse/PLATFORM-1300) for more information.+**NOTE TO ARTSY STAFF**: The last deployed branch in heroku is `ash-deploy`, so any urgent fixes should be made from there. See [PLATFORM-1300](https://artsyproduct.atlassian.net/browse/PLATFORM-1300) for more information. -[echo](http://github.com/artsy/echo) is a Grape + Rack ([Gris](http://github.com/artsy/gris)) hypermedia API service that provides remote configuration for Artsy mobile clients.--[![Build Status](https://semaphoreci.com/api/v1/projects/0b1b6ac6-4ee1-47b4-a65e-90bc37b414c2/469563/badge.svg)](https://semaphoreci.com/artsy-it/echo)+[echo](http://github.com/artsy/echo) is an API service that provides remote configuration for Artsy mobile clients. It works using a json file and some scripts to upload it to s3.  Meta ---  * __State:__ production-* __Production:__ [https://echo-api-production.herokuapp.com/](https://echo-api-production.herokuapp.com/) | [Web Interface](https://echo-web-production.herokuapp.com) | [Heroku](https://dashboard.heroku.com/apps/echo-api-production/resources)+* __Staging:__ [https://echo.artsy.net/Echo.staging.json](https://echo.artsy.net/Echo.staging.json)+* __Production:__ [https://echo.artsy.net/Echo.json](https://echo.artsy.net/Echo.json) * __Github:__ [https://github.com/artsy/echo/](https://github.com/artsy/echo/)-* __CI:__ [Semaphore](https://semaphoreci.com/artsy-it/echo/); merged PRs to artsy/echo#master are automatically deployed to staging; production is manually deployed from Semaphore-* __Point People:__ [@ashfurrow](https://github.com/ashfurrow)+* __Point People:__ [@ashfurrow](https://github.com/ashfurrow), [@pvinis](https://github.com/pvinis)

🌟

pvinis

comment created time in 3 days

PullRequestReviewEvent

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha 8040e2da240c4685252ee570e741d3cdc7b19cf6

Site updated to c6b898d

Add support for RxSwift 6

push time in 4 days

pull request commentRxSwiftCommunity/Action

Okay! That's been released as version 4.2.0. Thank you again for the contribution!

sharplet

comment created time in 4 days

push eventRxSwiftCommunity/Action

commit sha 77a1aba64490424b485b54ffbd0bdecc3abaa046

Version bump.

push time in 4 days

created tagRxSwiftCommunity/Action

tag4.2.0

Abstracts actions to be performed in RxSwift.

created time in 4 days

push eventRxSwiftCommunity/Action

commit sha ccce814a45046820e0df9797be86fb63d04a2c33

Add support for RxSwift 6 RxSwift 6 doesn't introduce any source-breaking changes that affect Action, so it's safe to extend our version compatibility to include both RxSwift 5 and 6.

commit sha f26e79ad0356e7bc25d61a12f4bf43e9f09d7466

Use Xcode 11.7 on CI

commit sha 7688e52376933435dd5b8153f4aecb2fc2cd9c78

Don't override SDK when selecting simulator destination

commit sha 8fd0019fd0f470ca3c1a6002393155e0ba4ea082

Update to Nimble 9.0

commit sha be8782ff40c2e009eb9c080eef6db30d521c7da8

Merge pull request #223 from sharplet/rxswift-6 Add support for RxSwift 6

Add support for RxSwift 6

push time in 4 days

PR merged RxSwiftCommunity/Action

Add support for RxSwift 6

RxSwift 6 (as of 6.0.0-rc.1) doesn't introduce any source-breaking changes that affect Action, so it's safe to extend our version compatibility to include both RxSwift 5 and 6.

+27 -27

4 commit in sharplet/Action/tree/rxswift-6 RxSwiftCommunity/Action/tree/master

4 comments

8 changed files

sharplet

pr closed time in 4 days

PullRequestReviewEvent

pull request commentRxSwiftCommunity/Action

Maybe we need an Xcode update?

https://github.com/RxSwiftCommunity/Action/blob/53c42b38f060932748795f3baaed75b096fbad7b/circle.yml#L12

sharplet

comment created time in 4 days

pull request commentRxSwiftCommunity/Action

Add support for RxSwift 6

Oh, wait, CI failing. Looks like Carthage can't build – can you confirm if this is working locally?

sharplet

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentartsy/peril-settings

feat: Warn when semantic formatting not detected in PR title

+import { danger, warn, fail } from "danger"++const semanticFormat = /^(fix|feat|build|chore|ci|docs|style|refactor|perf|test)(?:\(.+\))?!?:.+$/++export default async () => {+  const pr = danger.github.pr++  if (!semanticFormat.test(pr.title)) {+    warn(

When we talked last about this, I think we talked about using the markdown helper instead of warn or fail so that it would be a softer kind of feedback?

dblandin

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentartsy/peril-settings

feat: Warn when semantic formatting not detected in PR title

       "pull_request": "dangerfile.ts"     },     "artsy/peril-settings": {-      "pull_request": "dangerfile.ts"+      "pull_request": ["dangerfile.ts", "org/checkForSemanticFormatting.ts"]

We can use this to test the functionality of the rule, but I think we should use a slightly higher-traffic repo for testing how it "feels" to have the rule rolled out.

dblandin

comment created time in 4 days

push eventartsy/eigen

commit sha fe40051f5d439a5835fb8657d85aa2ed1cc7db1e

chore: remove any type from MyAccount

commit sha 9d44442671b48d785e638b1e2d8c9b960e036bd5

fix: center text items withing the sale artwrorks items (#4006)

commit sha 1a0303addfe8fd0e06f0746e249a1db2a5b79ba8

Prepares for 6.6.7 development (#4032)

push time in 4 days

push eventartsy/eigen

commit sha dada257a6c08e186759e06da9dbd2aa2c08b9172

Prepares for 6.6.7 development.

push time in 4 days

PR opened artsy/eigen

Prepares for 6.6.7 development Squash On Green

The type of this PR is: release

Description

Updates plist and changelog for new release.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

+10 -3

1 commit in artsy/eigen/tree/6.6.7-prep artsy/eigen/tree/master

0 comment

3 changed files

pr created time in 4 days

create barnchartsy/eigen

branch : 6.6.7-prep

created branch time in 4 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha a7dc80a5c42c24e2111b75226af1f6b8be355aaf

Site updated to c6b898d

push time in 5 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha 6947841eed1530a8d0888ca6a77b87fd78342112

Site updated to c6b898d

push time in 6 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha eb41633b1293dfcd768636201b9c32bf67040220

Site updated to c6b898d

push time in 7 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha 78f159f8006a25ac4782b8f9d50370a8a3779287

Site updated to c6b898d

[RFC] Drop setup scripts and replace with docs

push time in 8 days

issue commentartsy/README

I'm a big fan of setup scripts, even if Eigen doesn't take full advantage of them 🙈 When I've needed to work in other projects, like Pulse or Gravity, having a script helps me get productive quickly. Even if they fail, I know where they fail and can get that step done manually, and then re-run.

I would be in favour of adopting Jon's approach to scripts, to be more developer-friendly, but I wouldn't want to throw away the value of setup scripts because of one problem installing one dependency.

izakp

comment created time in 8 days

delete branch artsy/metaphysics

delete branch : chore/add-comment-about-sale-artworks-connection-aggregation

delete time in 8 days

push eventartsy/metaphysics

commit sha 84462120af4ee97f4cc7958e44e0db7616d3edca

chore: add sale artworks connection aggregation comment

commit sha af0fdd223fb55ec9342d19a42a0ace8c54d5dbee

Merge pull request #2777 from artsy/chore/add-comment-about-sale-artworks-connection-aggregation chore: add sale artworks connection aggregation comment

push time in 8 days

PR merged artsy/metaphysics

chore: add sale artworks connection aggregation comment

Description:

add a usage comment on how to use aggregations at the saleArtworksConnection interface.

+8 -0

1 commit in artsy/metaphysics/tree/chore/add-comment-about-sale-artworks-connection-aggregation artsy/metaphysics/tree/master

0 comment

2 changed files

MounirDhahri

pr closed time in 8 days

PullRequestReviewEvent

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha ca6acbdbf1bfe0d849bf2fd450714d6607fbd2fe

Site updated to c6b898d

Bypassing Swift upgrade warning for CocoaPods

push time in 9 days

issue commentashfurrow/TIL

Hi @briancordanyoung! I’m glad this was helpful. Podfile hooks are documented here: https://guides.cocoapods.org/syntax/podfile.html#post_install and you can find the docs for the Installer class here: https://rubydoc.info/gems/cocoapods/Pod/Installer/

ashfurrow

comment created time in 9 days

Samantha John

commit sha 92698654e9785dd90b4693b76324039b095a2d0d

Remove version from Nimble dependency

Bobby McBride

commit sha a4cff382cb78880b7381ba118d9f84726ad14a5f

Rearranging emoji syntax arguments to fix xcode 12 complaints

Bobby McBride

commit sha 9113a42de42fce2327d2bbb24e60cf987641542c

Corrected parameters to follow old pattern

commit sha 1836312c28d7bc3ee093dbe2de62c8e6d4788c69

Merge pull request #209 from MrRipcord/master Rearranging emoji syntax arguments to fix xcode 12 complaints

commit sha 2a7c1f26ccfc5d315327a47607ae5aa9a929f3c7

Merge pull request #207 from samjohn/master Make Nimble-Snapshots work with Nimble 9.0 and newer

commit sha af1033ddfecf1db4a1cff81504b0bf0ee8c0a719

Verison bump.

commit sha a52ab772e57f9e855c0543ad464a3f1c58d26d50

Merge branch 'master' into upgrade-xcode-circleci

Make Nimble-Snapshots work with Nimble 9.0 and newer

push time in 10 days

pull request commentashfurrow/Nimble-Snapshots

Okay! This is released as version 8.3.0.

samjohn

comment created time in 10 days

commit sha af1033ddfecf1db4a1cff81504b0bf0ee8c0a719

Verison bump.

push time in 10 days

created tagashfurrow/Nimble-Snapshots

tag8.3.0

Nimble matchers for FBSnapshotTestCase.

created time in 10 days

Samantha John

commit sha 92698654e9785dd90b4693b76324039b095a2d0d

Remove version from Nimble dependency

commit sha 2a7c1f26ccfc5d315327a47607ae5aa9a929f3c7

Merge pull request #207 from samjohn/master Make Nimble-Snapshots work with Nimble 9.0 and newer

Make Nimble-Snapshots work with Nimble 9.0 and newer

push time in 10 days

PR merged ashfurrow/Nimble-Snapshots

Make Nimble-Snapshots work with Nimble 9.0 and newer

This fixes https://github.com/ashfurrow/Nimble-Snapshots/issues/202 so that this gem can work with Xcode 12.

+1 -1

1 commit in samjohn/Nimble-Snapshots/tree/master ashfurrow/Nimble-Snapshots/tree/master

9 comments

1 changed file

samjohn

pr closed time in 10 days

issue closedashfurrow/Nimble-Snapshots

Support Nimble 9.0

Due to an issue with our tests with Nimble 8.4 on Xcode 12, we had to update to Nimble v9 RC. Is it possible to update Nimble-Snapshots to a version that has Nimble v9 as a dependency (when it is officially released)?

closed time in 10 days

joridor

pull request commentashfurrow/Nimble-Snapshots

@MrRipcord I don't see any reason to block this for now. We can possibly do the major API change in a follow-up. Thanks for bumping this, I didn't realize the feedback wasn't blocking this specific PR 👍

samjohn

comment created time in 10 days

push eventRxSwiftCommunity/rxswiftcommunity.github.io

commit sha d2fc0cfab40ff5df93135f96beeedda935e7473f

Site updated to c6b898d

Make Nimble-Snapshots work with Nimble 9.0 and newer

push time in 10 days

pull request commentashfurrow/Nimble-Snapshots

Hmm, I'm a little unclear here on the problem. The warning was coming from SwiftLint? What was the warning? I'd rather not change the API if we can help it, but I'm open to it if there's a good reason 👍

samjohn

comment created time in 10 days

push eventartsy/eigen

commit sha 211f29b3b916cf0d54ff830acbcf2b8e18c9f8dc

fix: authentication middleware

commit sha 6e6b9561799340dac52da44888256326108f044b

chore: update changelog Co-authored-by: Ash Furrow <[email protected]> Co-authored-by: Pavlos Vinieratos <[email protected]> Co-authored-by: Brian Beckerle <[email protected]> Co-authored-by: David Sheldrick <[email protected]> Co-authored-by: Sarah Weir <[email protected]> Co-authored-by: Devon Blandin <[email protected]>

commit sha 3ef185d9687a9445f917b0b62680d3bca44383de

chore: add checkAuthenticationMiddleware comment

commit sha 69c3e84feefe1df033d08a4d38e05fe0a3f9344a

chore: fix build failure

commit sha c3df7e03305cbf170cfdb5522400fe99f273847d

Merge branch 'master' into fix/check-authentication-middleware

commit sha a2c9e2c9056551453ad7bc2f3af0dcf44ead3950

Merge pull request #4002 from artsy/fix/check-authentication-middleware fix: reorder check authentication middleware

push time in 10 days

delete branch artsy/eigen

delete branch : fix/check-authentication-middleware

delete time in 10 days

PR merged artsy/eigen

fix: reorder check authentication middleware Jira Synced

The type of this PR is: Bugfix

This PR resolves CX-690

Description

Fix issue with the user not getting logged out when their session is invalid

PS: Placing the checkAuthenticationMiddleware after principalFieldErrorMiddleware fixed the issue 🎉

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

+45 -4

5 commit in artsy/eigen/tree/fix/check-authentication-middleware artsy/eigen/tree/master

0 comment

4 changed files

MounirDhahri

pr closed time in 10 days

PullRequestReviewEvent

push eventartsy/eigen

commit sha 06bf7e2048ed500d5786983c3d8fc00535783dfa

fix: support multiple artist names

commit sha cf6b3600618dc48f059c2e4b0130846967876990

fix: fix incorrect type for flex value

commit sha 62074d771c4981589515744bf4c2817bab007aff

feat: improve animation for collapsible artwork details This does 2 things: - Wrapping Text inside of a Flex as LayoutAnimation doesn't work for Text [1]. - Setting background color for sibling component so the collapsed content is properly masked. [1] https://github.com/facebook/react-native/issues/6502

commit sha 4d50f4dd3d80422200be8625a5e18780eeeabf4e

refactor: extract a ArtworkDetailsRow component

commit sha 7a25d5e69c1410084772751f9d163c9b3658b36b

feat: use artwork details row for more metadata

commit sha 41712b18b85af2a0162e08ba5414089e19c38537

doc: update CHANGELOG

Christina

commit sha fa9255636381231bd5c120adc224cf63996169d0

Merge pull request #3963 from artsy/inquiry-modal-tweaks feat: full artwork details in inquiry modal; improve UI (PURCHASE-2154)

Ashley Jelks

commit sha b050eb1117a3e89f6f13f3392d7f31d9d50aff33

feat: add context provider to pass state between inquiry modals

Ashley Jelks

commit sha 6a641420ac0da38db387a6275886cbc036fb120e

feat: enable toggle on shipping inquiry

Ashley Jelks

commit sha ea7b68b67f713290329a6bb920f61f2908c95986

Merge pull request #3994 from artsy/inquiry-state PURCHASE Add Artwork context provider for passing/persisting modal state

commit sha 7a874717806d405c5c77d4bae095322aa2a2f537

Updates release notes for 6.6.5.

artsyit

commit sha 26c5e728efe97cf54fc041bb8ee0aba489d79717

Update metaphysics schema

artsy-peril[bot]

commit sha 53149f901f7a0b89229c0560b2932a1dce51ea60

Update metaphysics schema (#4008) Update metaphysics schema

Anandaroop Roy

commit sha 46eb7ebe76b29878dd9e568cdc9a1383a39f4b20

fix: change Fairs2 artwork grid batch size from 20 to 30 (#4004) * fix: change default artwork batch size from 20 to 30 * docs: remove stale inline comment * docs: changelog

Will Doenlen

commit sha c27f019f2a5605749a5384d49186c1560d47e4b9

feat: Adds view showing artworks by all artists user follows in a fair (#4007) * Rename Fair2FollowedArtists -> Fair2FollowedArtistsRail * Add Fair2AllFollowedArtists skeleton and route * WIP: Artwork data added but does not render * Fair2AllFollowedArtists view rendering correctly * Fair2AlLFollowedArtists page correctly rendering * Add skeleton loader * Add some tests for Fair2AllFollowedArtists * Fix payload type for SetInitialFilterState and add test for setInitialFilterState actioN' * Revert View All button styling to correct style * Fix TS lint errors * Do not show View All button unless there are more than 3 artworks to show * Update changelog * Fix type * Update test title and fix broken tests * Fix broken test * Regenerating fragments * Fix another broken test * Fix another broken test

commit sha 962b9efcf8cd0eafacf852746790b24ec1d71223

Prepare for 6.6.6 release (#4009)

Sarah Weir

commit sha 60eab7360ff65994a9988f144f524368fbc625d1

feat: Adds ability to filter by artists within a fair (#4005)

commit sha 3616a810ff397fbdd8bde7c82da00eb5f54fbe40

chore: fix environment variable names for Sentry (#3999) * doc: remove distribution mention from bundle install command The distribution group was already removed from d45fdadb6d30eec27bb14dfe3e3c0c41da4244b6. * chore: fix environment variable names for Sentry * doc: update and fix CHANGELOG

commit sha c3df7e03305cbf170cfdb5522400fe99f273847d

Merge branch 'master' into fix/check-authentication-middleware

[WIP]Best practices on exporting/importing relay containers

push time in 10 days

PullRequestReviewEvent

issue commentartsy/README

I'm a 👍 to standardizing – the conventions that Matt outlines are generally how I work as well, except I don't rename during imports. Maybe it's the Objective-C programmer in me, but I'll take a more precise, explicit name over a more concise, ambiguous name any day.

As I've taught more and more engineers how Relay works in Eigen, the inconsistencies really add up to make it more difficult than it has to be. I'm also 👍 to avoiding default exports, which we've been avoiding on Eigen for some time.

jo-rs

comment created time in 10 days

push eventashfurrow/blog

commit sha eb5bb60f0b0d4447af712b99c1c98d2432fe14ac

Moving Home to New Brunswick