profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pvinis/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Pavlos Vinieratos pvinis My house, an office, who knows. pavlos.dev Just coding.. and coding.. and using two-dot ellipsis..

ncuillery/rn-diff 1081

Easier React Native upgrades by clearly expose changes from a version to another. :rocket:

gameplaycolor/gameplaycolor 176

JavaScript Game Boy Color emulator for iOS

pvinis/awesome-split-keyboards 79

A collection of ergonomic split keyboards โŒจ

Aposymbiont/split-keyboards 41

A collection of ergonomic split keyboards โŒจ

PacktPublishing/React-Native-Tips-Tricks-and-Techniques 15

React Native: Tips, Tricks, and Techniques [Video], published by Packt

inseven/bookmarks 3

Pinboard client for iOS and macOS

inseven/incontext 3

An extensible multimedia static site generator

jbmorley/patternjs 3

JavaScript pattern rendering library

pvinis/alexa-pepper-radio 2

alexa skill that can play pepper radio (https://pepper966.gr)

pull request commentartsy/cohesion

Deprecate Helpers

I didn't think of the @deprecated comment. that would be cool, but maybe too much work? ๐Ÿค”

pvinis

comment created time in a day

PR opened artsy/eigen

refactor(palette): removing more v2 things

The type of this PR is: Enhancement

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- ๐Ÿ’ก This checklist is experimental. CX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have tested my changes on iOS and Android.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [x] I have added a changelog entry below or my changes do not require one.

<details><summary>Changelog updates</summary>

Changelog updates

<!-- ๐Ÿ“ Please fill out at least one of these sections. --> <!-- โ“˜ 'User-facing' changes will be published as release notes. --> <!-- โŒซ Feel free to remove sections that don't apply. --> <!-- โ€ข Write a markdown list or just a single paragraph, but stick to plain text. --> <!-- ๐Ÿ“– eg. Enable lotsByFollowedArtists - john or Fix phone input misalignment - mary. --> <!-- ๐Ÿคทโ€โ™‚๏ธ Replace this entire block with the hashtag #nochangelog to avoid updating the changelog. --> #nochangelog

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

<!-- end_changelog_updates -->

</details>

+1089 -1324

0 comment

53 changed files

pr created time in a day

create barnchartsy/eigen

branch : v2cleanup-misc

created branch time in a day

push eventartsy/eigen

Pavlos Vinieratos

commit sha c3ed3be88db494e8f84e7fa48d28fc34cb2f25e9

refactor(palette): removing text v2 (#5518)

view details

push time in a day

delete branch artsy/eigen

delete branch : v2cleanup-text

delete time in a day

PR merged artsy/eigen

refactor(palette): removing text v2

The type of this PR is: Enhancement

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

<!-- Implementation description -->

Removing v2 text, and mapping all v2 text variants to the v3 values.

PR Checklist (tick all before merging)

<!-- ๐Ÿ’ก This checklist is experimental. CX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [ ] I have tested my changes on iOS and Android.
  • [ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [ ] I have documented any follow-up work that this PR will require, or it does not require any.
  • [ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [ ] I have added a changelog entry below or my changes do not require one.

<details><summary>Changelog updates</summary>

Changelog updates

<!-- ๐Ÿ“ Please fill out at least one of these sections. --> <!-- โ“˜ 'User-facing' changes will be published as release notes. --> <!-- โŒซ Feel free to remove sections that don't apply. --> <!-- โ€ข Write a markdown list or just a single paragraph, but stick to plain text. --> <!-- ๐Ÿ“– eg. Enable lotsByFollowedArtists - john or Fix phone input misalignment - mary. --> <!-- ๐Ÿคทโ€โ™‚๏ธ Replace this entire block with the hashtag #nochangelog to avoid updating the changelog. -->

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • removing a bunch of palette v2 code - pavlos

<!-- end_changelog_updates -->

</details>

+458 -729

1 comment

162 changed files

pvinis

pr closed time in a day

push eventartsy/eigen

Pavlos Vinieratos

commit sha fab6becb9829210c5b71952d782e2ea4cf8289ab

fix

view details

push time in a day

push eventartsy/eigen

Pavlos Vinieratos

commit sha 680fdfaa1394c373f22e9351cf50e7f143c771d8

cleanup(palette v3): button v2 ๐Ÿ‘‹ (#5512)

view details

Hanna Trapachka

commit sha 62cc71fa35ac4945b901a8314160d237da6815cf

feat(FX-3331): make recent searches title case (#5516)

view details

Pavlos Vinieratos

commit sha dbf2c4f6cfd32693c842ae4caeea028464f47351

text v2 bye

view details

push time in a day

PR opened artsy/eigen

refactor(palette): removing text v2

The type of this PR is: Enhancement

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- ๐Ÿ’ก This checklist is experimental. CX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [ ] I have tested my changes on iOS and Android.
  • [ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [ ] I have documented any follow-up work that this PR will require, or it does not require any.
  • [ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [ ] I have added a changelog entry below or my changes do not require one.

<details><summary>Changelog updates</summary>

Changelog updates

<!-- ๐Ÿ“ Please fill out at least one of these sections. --> <!-- โ“˜ 'User-facing' changes will be published as release notes. --> <!-- โŒซ Feel free to remove sections that don't apply. --> <!-- โ€ข Write a markdown list or just a single paragraph, but stick to plain text. --> <!-- ๐Ÿ“– eg. Enable lotsByFollowedArtists - john or Fix phone input misalignment - mary. --> <!-- ๐Ÿคทโ€โ™‚๏ธ Replace this entire block with the hashtag #nochangelog to avoid updating the changelog. -->

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • removing a bunch of palette v2 code - pavlos

<!-- end_changelog_updates -->

</details>

+559 -1333

0 comment

201 changed files

pr created time in a day

PR opened artsy/eigen

fix(test): unfocus random focused test

The type of this PR is: Bugfix

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- ๐Ÿ’ก This checklist is experimental. CX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have tested my changes on iOS and Android.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [x] I have added a changelog entry below or my changes do not require one.

<details><summary>Changelog updates</summary>

Changelog updates

<!-- ๐Ÿ“ Please fill out at least one of these sections. --> <!-- โ“˜ 'User-facing' changes will be published as release notes. --> <!-- โŒซ Feel free to remove sections that don't apply. --> <!-- โ€ข Write a markdown list or just a single paragraph, but stick to plain text. --> <!-- ๐Ÿ“– eg. Enable lotsByFollowedArtists - john or Fix phone input misalignment - mary. --> <!-- ๐Ÿคทโ€โ™‚๏ธ Replace this entire block with the hashtag #nochangelog to avoid updating the changelog. --> #nochangelog

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

<!-- end_changelog_updates -->

</details>

+1 -1

0 comment

1 changed file

pr created time in a day

create barnchartsy/eigen

branch : pvinis-patch-4

created branch time in a day

create barnchartsy/eigen

branch : v2cleanup-text

created branch time in a day

push eventartsy/eigen

Pavlos Vinieratos

commit sha 680fdfaa1394c373f22e9351cf50e7f143c771d8

cleanup(palette v3): button v2 ๐Ÿ‘‹ (#5512)

view details

push time in a day

delete branch artsy/eigen

delete branch : v2cleanup-button

delete time in a day

PR merged artsy/eigen

cleanup(palette v3): button v2 ๐Ÿ‘‹

The type of this PR is: Enhancement

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- ๐Ÿ’ก This checklist is experimental. CX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have tested my changes on iOS and Android.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [x] I have added a changelog entry below or my changes do not require one.

<details><summary>Changelog updates</summary>

Changelog updates

<!-- ๐Ÿ“ Please fill out at least one of these sections. --> <!-- โ“˜ 'User-facing' changes will be published as release notes. --> <!-- โŒซ Feel free to remove sections that don't apply. --> <!-- โ€ข Write a markdown list or just a single paragraph, but stick to plain text. --> <!-- ๐Ÿ“– eg. Enable lotsByFollowedArtists - john or Fix phone input misalignment - mary. --> <!-- ๐Ÿคทโ€โ™‚๏ธ Replace this entire block with the hashtag #nochangelog to avoid updating the changelog. --> #nochangelog

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

<!-- end_changelog_updates -->

</details>

+100 -603

2 comments

62 changed files

pvinis

pr closed time in a day

PullRequestReviewEvent

Pull request review commentartsy/eigen

feature: integrate v3 input

+import { COUNTRY_SELECT_OPTIONS } from "lib/Components/CountrySelect"++// finds a country's long name by the passed country code+const findCountryNameByCountryCode = (countryCode: string): string => {+  const countryLongName = COUNTRY_SELECT_OPTIONS.find((opt) => opt.value === countryCode)?.label++  if (countryLongName && typeof countryLongName === "string") {+    return countryLongName+  }++  return ""

i dont know where this is used, but would return undefined or return null make more sense, to signify failure?

AlicanAkyuz

comment created time in a day

Pull request review commentartsy/eigen

feature: integrate v3 input

 import { CloseIcon, Flex, Separator, Spacer, Text, Touchable, useColor } from "p import React, { useEffect, useMemo, useRef, useState } from "react" import { FlatList, TextInput, TouchableOpacity } from "react-native" import { FancyModal } from "../../../lib/Components/FancyModal/FancyModal"-import { INPUT_HEIGHT } from "../../../lib/Components/Input/Input" import { SearchInput } from "../../../lib/Components/SearchInput"-+import { INPUT_HEIGHT } from "../Input" export interface SelectOption<ValueType> {
import { INPUT_HEIGHT } from "../Input"

export interface SelectOption<ValueType> {

just some breathing room

AlicanAkyuz

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventartsy/eigen

Pavlos Vinieratos

commit sha d291405d33aeab343f0f504d64bf1233f223c4cf

cleanup(palette v3): remove palette flag (#5511) * remove palette flag * refresh * default here too * yep

view details

Pavlos Vinieratos

commit sha 99fbd68beced0630b4bcf8ca5d9aaa122cbcac15

button v2 byebye

view details

push time in a day

push eventartsy/eigen

Pavlos Vinieratos

commit sha c7a941e6adf56b4849544a52323d9de41570f859

yep

view details

push time in a day

Pull request review commentartsy/eigen

cleanup(palette v3): remove palette flag

 export const StickyTabPageTabBar: React.FC<{ onTabPress?(tab: { label: string; i     }   }, [activeTabIndex.current])

yea.. I didn't want to change any code with this PR besides removing some v2 stuff. I noticed this, and I did not want to get into "simplifying" in this PR. Maybe after everything v2 is gone. Or maybe whoever worked on it can help. If I start simplifying, the PR will never end ๐Ÿ˜“.

pvinis

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentartsy/eigen

cleanup(palette v3): remove palette flag

 export const Fair: React.FC<FairProps> = ({ fair }) => {                   }                   case "fairTabsAndFilter": {                     const tabToShow = tabs ? tabs[activeTab] : null-                    const TabVersionToUse = allowV3 ? NavigationalTabs : V2Tabs+                    const TabVersionToUse = NavigationalTabs

true. fixing it.

pvinis

comment created time in a day

Pull request review commentartsy/eigen

cleanup(palette v3): remove palette flag

 const isV2Props = (props: ButtonProps): props is ButtonV2Props => { }  export const Button: React.FC<ButtonProps> = (props) => {-  const allowV3 = usePaletteFlagStore((state) => state.allowV3)--  if (allowV3) {-    if (isV2Props(props)) {-      return (-        <ThemeV3>-          <ButtonV3 {...transformV3Props(props)} />-        </ThemeV3>-      )-    } else {-      return (-        <ThemeV3>-          <ButtonV3 {...props} />-        </ThemeV3>-      )-    }-  }-   if (isV2Props(props)) {-    return <ButtonV2 {...props} />+    return (+      <ThemeV3>+        <ButtonV3 {...transformV3Props(props)} />+      </ThemeV3>+    )+  } else {+    return (+      <ThemeV3>+        <ButtonV3 {...props} />+      </ThemeV3>+    )

same :)

pvinis

comment created time in a day

PullRequestReviewEvent

Pull request review commentartsy/eigen

cleanup(palette v3): remove palette flag

 export type SelectComponentI<ValueType = any> = React.FC<SelectProps<ValueType>> // export type SelectComponentI = React.FC<React.ComponentPropsWithRef<typeof SelectV2>>

yep, I noticed that too. I guess yea. Again, will be removed in another PR

pvinis

comment created time in a day

PullRequestReviewEvent