profile
viewpoint
Andrew Duthie aduth @GSA, and personal projects Cincinnati, OH, USA https://andrewduthie.com/ Developer and purveyor of open source with an enduring passion for bleeding-edge front-end web.

aduth/dones 62

Simple team task management and tracking

aduth/correctingInterval 60

An auto-correcting alternative to setInterval

aduth/Doom_CooldownPulse 8

A World of Warcraft addon that animates ability icons when they are available to be used after cooldown

aduth/g-debugger 6

Visual debugging tools for block development

aduth/Ghat 4

Relay GitHub events to your favorite chat client

aduth/crawl-domain 3

Crawl to discover all paths under a given URL domain

aduth/equivalent-key-map 3

A Map variant which allows for equivalent (deeply equal) object and array keys

aduth/express-mongoose-starter 3

A very bare-bones starter app, using only Express and Mongoose.

aduth/github-explorer 3

Embeddable GitHub file explorer

push eventaduth/StreamLens

Andrew Duthie

commit sha 63137150d288876e22e04438587f9d426d231dbe

Remove unused import

view details

push time in a day

push eventaduth/StreamLens

Andrew Duthie

commit sha e518d5d286d10f8245ab8080291c5de10f2764ac

Bump dependencies

view details

Andrew Duthie

commit sha 0dae52cc8c1b77e916ade25b1f6a6366d2185859

Refactor provider settings as tab panel Setting up for provider-specific configuration

view details

push time in a day

push event18F/identity-idp

Andrew Duthie

commit sha 03f2d7ef71edd4455f1dee4d607d638ae7e76a08

Adjust margins for button, fallback links

view details

push time in 2 days

Pull request review comment18F/identity-idp

LG-4792: Update webauthn MFA screen layout

 en:       intro: Add a security key that meets the FIDO standard as your authentication         method. You can add as many security keys as you want. To get started,         first give your security key a nickname.-      login_text: When you are ready to authenticate, press the button+      login_text: 'When you are ready to authenticate, press the button:'

We have two different texts for security key vs. platform authenticators. Why is that? 🤔

When you are ready, press the button:

When you are ready to authenticate, press the button:

aduth

comment created time in 2 days

PullRequestReviewEvent

PR opened 18F/identity-idp

LG-4792: Update webauthn MFA screen layout

Why: In anticipation of upcoming font change to Public Sans, this pull request updates typography and layout of the webauthn MFA screen based on Figma guidance included in the associated ticket.

Draft while I confirm revisions to shared partials like "Fallback Links" and "Cancel" on other screens.

State Before After
Initial Screen Shot 2022-01-21 at 4 08 59 PM image
Authenticating Screen Shot 2022-01-21 at 4 09 05 PM image

(Note: For clarity, the "After" screenshots artificially include revisions that would be applied as part of #5840)

+27 -27

0 comment

6 changed files

pr created time in 2 days

create barnch18F/identity-idp

branch : aduth-webauthn-layout

created branch time in 2 days

pull request comment18F/identity-style-guide

LG-4791: Add Process List component styles

I narrowed the connector slightly (8px to 5px) for the default (non-"big") process list based on this discussion in Slack (cc @anniehirshman-gsa), which can be seen in the live preview.

Are there any other revisions we'd like to make here?

aduth

comment created time in 2 days

pull request comment18F/identity-idp

LG-4793: Convert "Remember this browser" checkboxes to design system

One last question: are the checkboxes on or off by default, or is it a mix across pages? I would expect off by default/on load, but curious if that needs standardizing while we are here.

It will default to checked, but it will also remember the user's preference. So if they unchecked "Remember this browser", it would be unchecked the next time they're prompted for their MFA.

aduth

comment created time in 2 days

push event18F/identity-style-guide

Andrew Duthie

commit sha 92a61936bad8becfa9efa46869c12800246389bf

Improve SASS assets compilation (#282) * Recover from SASS build failure * Remove unused postcss-csso dependency * Skip CSS minification in development * Bump dependencies related to SASS build * Remove parcel/css We tried 😄 (It almost works, but doesn't properly handle vendor prefixes in all cases, such as with CSS "mask" property)

view details

push time in 2 days

delete branch 18F/identity-style-guide

delete branch : aduth-recover-error

delete time in 2 days

PR merged 18F/identity-style-guide

Improve SASS assets compilation

This pull request includes several miscellaneous improvements to the SASS compilation:

  • Continue watching for file changes if an error occurs during build
  • Skip CSS minification in development to improve build performance
  • Remove unused postcss-nano dependency
  • Upgrade other dependencies related to SASS compilation
+482 -1093

0 comment

3 changed files

aduth

pr closed time in 2 days

started18F/identity-style-guide

started time in 2 days

push event18F/identity-style-guide

Andrew Duthie

commit sha f1c58278bda1246009c6aad469fed777dcf9753c

Rebuild

view details

push time in 2 days

push event18F/identity-style-guide

Andrew Duthie

commit sha 787b34c12abd596d2b633519176f71ab5d4720b6

Remove parcel/css We tried 😄 (It almost works, but doesn't properly handle vendor prefixes in all cases, such as with CSS "mask" property)

view details

push time in 2 days

PR opened 18F/identity-style-guide

Improve SASS assets compilation

This pull request includes several miscellaneous improvements to the SASS compilation:

  • Continue watching for file changes if an error occurs during build
  • Skip CSS minification in development to improve build performance
  • Remove unused postcss-nano dependency
  • Upgrade other dependencies related to SASS compilation
+761 -1093

0 comment

3 changed files

pr created time in 2 days

create barnch18F/identity-style-guide

branch : aduth-recover-error

created branch time in 2 days

push event18F/identity-style-guide

Andrew Duthie

commit sha d75c9d1cb078942dad1d61cbeda0ca40e95c5601

Process List: Adjust connected, default styling Narrower connector

view details

push time in 2 days

push event18F/identity-idp

Andrew Duthie

commit sha 15465801c8a2338a7b6da9ae0fbe692c816f2554

Appease Brakeman

view details

push time in 3 days

pull request comment18F/identity-idp

LG-4793: Convert "Remember this browser" checkboxes to design system

A little out of scope, but I wonder if we can take this opportunity to standardize the "Add Authenticator App" and "MFA w/ OTP" checkboxes, so they are all in the same position/spacing (between the last input and the Continue/Submit button), and are all bordered checkboxes?

Sure, I think that makes sense. I gave it a shot in 56512d6 and 251e26d. Do these screenshots look like what you'd expect?

Before After
Screen Shot 2022-01-21 at 9 58 07 AM Screen Shot 2022-01-21 at 10 09 52 AM
Screen Shot 2022-01-21 at 10 14 43 AM Screen Shot 2022-01-21 at 10 15 21 AM

LGTM! Curious, do these look the same or are they full-width on mobile? (Either is fine w me but consistency would be good)

They will appear the same on mobile. Here's an example with the updated OTP screen:

screenshot

aduth

comment created time in 3 days

push event18F/identity-idp

Zach Margolis

commit sha 33e3781d4306869c355048b19bc0bc97731c3677

Simplify account page personal key logic (#5817) * Simplify account page personal key logic * Split Users::PersonalKeysController into two: - /manage/personal_key stays with Users:: controller - /account/personal_key goes to a new Accounts:: controller

view details

Andrew Duthie

commit sha 558d4d6b3661ffc25cd80a362712ec6d70d73e4f

Correctly set RAILS_ENV for Make test target (#5821) **Why**: Since the Webpack configuration has special considerations for test environment (specifically, checking absence of i18n keys), ensure that the `yarn build` would be run with the correct environment.

view details

Andrew Duthie

commit sha a02cc75c785780b0ab6a1568cc631b4d80f943c7

Persist Webpack assets manifest between requests (#5805) * Persist Webpack assets manifest between requests **Why**: To avoid touching the filesystem for every request in production, since the manifest will never change during the lifetime of the application. * Add happy-path test case for load_manifest * Reset cached manifest before starting specs **Why**: May have lingering value from preceding tests * Disable asset manifest caching in non-production * Reset AssetSources.manifest to nil for load spec **Why**: Since it may be assigned via a preceding spec, and load_manifest is only called based on a combination of both cache_manifest and the presence of an existing manifest. * Bump CodeClimate * Remove production-specific handling for assets * Cache manifest in test environment * Always reset manifest in specs **Why**: Because we now cache in test env * Swaparoo cached vs. uncached in spec context Default is cached

view details

bleachbyte

commit sha b0032430d9c9b666fc81c3d3a047394cf2bf90a5

create rake task to look up UUID by email address

view details

bleachbyte

commit sha 1ee2c28c7a291d2ecc85d8b14f214579a6c7b1d4

Merge branch 'jp/email-to-uuid'

view details

Mitchell Henke

commit sha 9dfadf4397b98c6b0316671dde9337067008d61b

Fix a handful of 500s (#5823) * fix oidc logout 500 * fix oidc token 500 * fix TOTP 500 * fix phone_info 500 * Update spec/controllers/openid_connect/logout_controller_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Zach Margolis

commit sha 63504b9d418fdebe0da538ced772d4bc9cbfaf24

Skip Gzipping assets in development (#5824) **Why**: It sped up rake assets:compile for me locally - Follow-up to #5812

view details

Manish Shah

commit sha eceea0f4df59cf3bb934b561e1d141edf1276174

LG-5670-RoU-acceptance-more-explicit (#5826) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Manish Shah

commit sha 12cfbac80505fb6b6872db1f4652cacd811f1972

LG-5523-state-id-number-to-state-issued-id (#5831) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Manish Shah

commit sha 83672a5449a1c0eedf2b14325c98ad9dff2f12be

LG-5523-state-id-number-to-state-issued-id-spell-fix (#5833) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Andrew Duthie

commit sha e8dcc5680f1a16156056d4f5c30b055d325bb81d

Fix Acuant sequence-break error cookie sync issue (#5830) * Fix Acuant sequence-break error cookie sync issue **Why**: To fix a bug where if the Acuant camera fails to start due to iOS 15 "sequence-break" error, subsequent attempts to capture would result in the captured image not being set correctly. This fixes a regression introduced in #5778 where the cookie value tracked by AcuantCapture falls out of date after Acuant handles the error, since we never refresh the value after it is [set internally by Acuant's error handling](https://github.com/Acuant/JavascriptWebSDKV11/blob/9a5387576a33710188501ad6233f986b1b6bb1cb/SimpleHTMLApp/webSdk/dist/AcuantCamera.js#L616). Thus, the next time the user clicks "Take Photo", the [cookie value logic](https://github.com/18F/identity-idp/blob/eceea0f4df59cf3bb934b561e1d141edf1276174/app/javascript/packages/document-capture/components/acuant-capture.jsx#L400) is out-of-date, and Acuant capture is started instead of the default manual capture handling. To resolve this, we anticipate that Acuant would set the cookie in their error handling of sequence-break, and refresh the cookie value when we get a chance to handle the error in our own code. * Try to improve async handling of focus return * useCookie: Set next value as variable for subscriber set 1. Clearer that the value is actually being updated 2. Only parse cookie once for all subscribers, rather than per-subscriber

view details

Andrew Duthie

commit sha e1a05a7ef37054cc4b8320c3276caec422ba4d09

Prevent simultaneous active Acuant instances (#5834) * Prevent simulataneous active Acuant instances **Why**: Because the Acuant SDK (or at least our implementation of it) is treated as a singleton, unexpected behavior can occur when trying to start capturing a second image before the first is finished, as in the case of the new loading experience introduced in #5747. * Update specs for Acuant context * Rearrange capture spec to ensure image processing while clicking second

view details

Andrew Duthie

commit sha 7bdfb5b5013a394b120a4f6856a62fcdcbdbc97a

Improve "make run-https" asset workflow (#5835) * Improve "make run-https" asset workflow **Why**: - To prevent caching in development with the Rails public file server - To avoid writing webpack-dev-server URLs into the asset manifest when the app is requested across the network - To automatically recompile JavaScript while running "make run-https" * Keep webpack port consideration **Why**: So as not to break assets precompilation * Flip webpack watch and webpack serve by HTTPS env Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Nathan Berg

commit sha 6085ea61d3c402f28d52c66a470bc5b134617366

Update rules_of_use_updated_at (#5837) This is used to trigger users to accept the new rules of use. Relates to: https://github.com/18F/identity-site/pull/792

view details

Jessica Dembe

commit sha d7f1eaf8001c78ecc7c33a3d51838cca12cc2f0f

make text readable in personal key custom dialog (#5806) * add aria labelledby and ariadescribed by * add local assignment to views * change how data gets passed between personal key and modal * change other modals to be dynamically assigned * Update app/views/shared/_modal_layout.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * refactor label id and description, fix lint errors * Update app/views/reactivate_account/_modal.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/views/reactivate_account/_modal.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * add tab index -1 to modal Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Sammy

commit sha aaf2402fb8bc44b8e26255a84ce7c6486f75f43d

specified ruby version, enhanced troubleshooting guidance (#5819) * specified ruby version, enhanced troubleshooting guidance * moved thin and mailcatcher options to setup * circleci issue fix * Update README.md typos Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * linting Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Zach Margolis

commit sha 3398c7875578941fdbc494d5b12a4c9a831c50b2

Add new account management flow to reset personal key (LG-5664) (#5825) **Why**: Previously we only let users reset their personal keys if they *did not* have a profile (because a previous iteration of Login had personal keys as a backup 2FA method) * Remove unused #visible? method * Copy changes, translations Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

view details

Andrew Duthie

commit sha b44fa1f3152e0546b3a885fd5e893de5a484dd09

LG-4792: Remove instances of "Check your email" icon (#5827) **Why**: As part of the typographical clean-up work of LG-4792, we want to remove all usage of this "Check your email" icon, along with the icon and stylings themselves.

view details

Andrew Duthie

commit sha d37f1b0a90dec84e9b4df542f222f8bc30951a6c

LG-4792: Use consistent Accordion spacing (#5828) * Apply Accordion class with tag_options, bordered modifier * LG-4792: Use consistent Accordion spacing **Why**: As part of typographical refinement in LG-4792, accordions throughout the application should use a consistent vertical margin. * Update "Continue" button margin bottom to 2.5rem

view details

Andrew Duthie

commit sha 1909296bed176df5a875316be57ca2c476f8e712

Prune or fix unreachable specs (#5841) * Prune or fix unreachable specs **Why**: Because otherwise they don't serve any purpose, since they aren't run by the default RSpec pattern "*_spec.rb" * Fix specs (🤞)

view details

push time in 3 days

pull request comment18F/identity-idp

LG-4792: Use component for consistent headings

I found a handful more with fun variations like <h1 class="margin-bottom-2 margin-top-4 margin-y-0">. There's also some that I chose not to touch now, since they're not quite as trivial to update (such as the SP sign-in "SP is using Login.gov to...").

Part of this was also to try to make content combinations like Icon+Heading more consistent. I did this by adding margin-bottom-2 (1rem) to the icons, though I see in some cases we use margin-bottom-4. Happy to go with whichever if you have thoughts @anniehirshman-gsa .

aduth

comment created time in 3 days

push event18F/identity-idp

Sammy

commit sha aaf2402fb8bc44b8e26255a84ce7c6486f75f43d

specified ruby version, enhanced troubleshooting guidance (#5819) * specified ruby version, enhanced troubleshooting guidance * moved thin and mailcatcher options to setup * circleci issue fix * Update README.md typos Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * linting Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Zach Margolis

commit sha 3398c7875578941fdbc494d5b12a4c9a831c50b2

Add new account management flow to reset personal key (LG-5664) (#5825) **Why**: Previously we only let users reset their personal keys if they *did not* have a profile (because a previous iteration of Login had personal keys as a backup 2FA method) * Remove unused #visible? method * Copy changes, translations Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

view details

Andrew Duthie

commit sha b44fa1f3152e0546b3a885fd5e893de5a484dd09

LG-4792: Remove instances of "Check your email" icon (#5827) **Why**: As part of the typographical clean-up work of LG-4792, we want to remove all usage of this "Check your email" icon, along with the icon and stylings themselves.

view details

Andrew Duthie

commit sha d37f1b0a90dec84e9b4df542f222f8bc30951a6c

LG-4792: Use consistent Accordion spacing (#5828) * Apply Accordion class with tag_options, bordered modifier * LG-4792: Use consistent Accordion spacing **Why**: As part of typographical refinement in LG-4792, accordions throughout the application should use a consistent vertical margin. * Update "Continue" button margin bottom to 2.5rem

view details

Andrew Duthie

commit sha 1909296bed176df5a875316be57ca2c476f8e712

Prune or fix unreachable specs (#5841) * Prune or fix unreachable specs **Why**: Because otherwise they don't serve any purpose, since they aren't run by the default RSpec pattern "*_spec.rb" * Fix specs (🤞)

view details

Andrew Duthie

commit sha 9121f7606dffaab8408c3c705001171f6a3c1f78

LG-4792: Use component for consistent headings **Why**: To avoid visual inconsistencies, to simplify and streamline developer experience, to create a single source of truth for common heading styles, and to create alignment between Rails and React heading implementations.

view details

push time in 3 days

push event18F/identity-idp

Andrew Duthie

commit sha 57fcf601cd22d96c445cce1a8968de4a32105805

Remove useless simple_form default class (#5814) **Why**: Because the class would already be applied, and in some cases we aren't applying the option correction, since it must be passed as the html keyword of simple_form_for.

view details

dependabot[bot]

commit sha f7a94f0f7ee779d38b9e9551ba374f0f49d33093

Bump follow-redirects from 1.13.0 to 1.14.7 (#5818) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Andrew Duthie

commit sha fb4961ee44759419fddcf6683d0aad5b25407505

Remove redundant empty div wrappers (#5813) * Remove useless empty div wrappers **Why**: Since div carries no semantics, and these elements have no other attributes or classes, the only purpose would have been to create a [block formatting context](https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context), but this is not necessary for the changed files due their existing placement and/or surrounding content. * Bump CodeClimate

view details

Andrew Duthie

commit sha 0a3493210e667a411fd2a629710538cac3257fb0

LG-3437: Improve responsiveness of Acuant pending crop (#5747) * Split "AcuantCamera" from "AcuantCaptureCanvas" for managing Acuant lifecycle **Why**: As currently implemented, the AcuantCaptureCanvas component must remain mounted for the full duration of an Acuant capture, since it's currently responsible for managing callbacks. Since the canvas is a UI component rendered within the FullScreen dialog, this has limited our ability to show different UI states for when an image has been captured, but hasn't yet finished cropping. To be able to improve the responsiveness of the interaction, we can instead split this into two component: One which manages the Acuant lifecycle (AcuantCamera) and one which displays the UI associated with the canvas rendering (AcuantCaptureCanvas). * Extract SpinnerDots component * FileInput: Add support for pending value * AcuantCapture: Render FileInput as pending while cropping * FullScreen: Avoid calling onRequestClose during unmount "onRequestClose" should only be initiated by a user interaction * Reset hasStartedCropping between captures * Update specs for split AcuantCamera, AcuantCaptureCanvas * Format _file-input.scss with Prettier * Prefer pending state to existing value * Unassign hasEffectiveValue to fix TypeScript error See: https://github.com/18F/identity-idp/pull/5747#discussion_r778398872 * Add minor delay to spinner animation **Why**: Without this, spinner dots animate inconsistently in iOS Safari, sometimes only animating one of the three dots. * work in progress: announce image load * Use status message to announce pending file changes * Try: Extract StatusMessage component **Why**: To better support use-case where element should always be present in the page, but text may only be set in specific circumstances (improve interoperability with screen reader live announcements). * Try: Upgrade focus-trap to latest version **Why**: See if it helps stability of screen reader announcements with FullScreen component focus trap behaviors. * Use separate StatusMessage instance for error, success See: https://github.com/18F/identity-idp/pull/5747#discussion_r781342665

view details

Andrew Duthie

commit sha 399e0300fae873f96a952ca61a3cd251604cd1fe

Add support for native TypeScript (#5815) * Try: TypeScript **Why**: One of the other advantages / hopes with #5746 was a more direct path to incrementally adopting native TypeScript if we choose. * Move babel/preset-typescript to dependencies Required for production build * wip: ESLint, Mocha * Move TypeScript ESLint rules to shared configuration * Revert extends to main Simplify diff * Add test case for additional resolved Webpack extensions

view details

Zach Margolis

commit sha 33e3781d4306869c355048b19bc0bc97731c3677

Simplify account page personal key logic (#5817) * Simplify account page personal key logic * Split Users::PersonalKeysController into two: - /manage/personal_key stays with Users:: controller - /account/personal_key goes to a new Accounts:: controller

view details

Andrew Duthie

commit sha 558d4d6b3661ffc25cd80a362712ec6d70d73e4f

Correctly set RAILS_ENV for Make test target (#5821) **Why**: Since the Webpack configuration has special considerations for test environment (specifically, checking absence of i18n keys), ensure that the `yarn build` would be run with the correct environment.

view details

Andrew Duthie

commit sha a02cc75c785780b0ab6a1568cc631b4d80f943c7

Persist Webpack assets manifest between requests (#5805) * Persist Webpack assets manifest between requests **Why**: To avoid touching the filesystem for every request in production, since the manifest will never change during the lifetime of the application. * Add happy-path test case for load_manifest * Reset cached manifest before starting specs **Why**: May have lingering value from preceding tests * Disable asset manifest caching in non-production * Reset AssetSources.manifest to nil for load spec **Why**: Since it may be assigned via a preceding spec, and load_manifest is only called based on a combination of both cache_manifest and the presence of an existing manifest. * Bump CodeClimate * Remove production-specific handling for assets * Cache manifest in test environment * Always reset manifest in specs **Why**: Because we now cache in test env * Swaparoo cached vs. uncached in spec context Default is cached

view details

bleachbyte

commit sha b0032430d9c9b666fc81c3d3a047394cf2bf90a5

create rake task to look up UUID by email address

view details

bleachbyte

commit sha 1ee2c28c7a291d2ecc85d8b14f214579a6c7b1d4

Merge branch 'jp/email-to-uuid'

view details

Mitchell Henke

commit sha 9dfadf4397b98c6b0316671dde9337067008d61b

Fix a handful of 500s (#5823) * fix oidc logout 500 * fix oidc token 500 * fix TOTP 500 * fix phone_info 500 * Update spec/controllers/openid_connect/logout_controller_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Zach Margolis

commit sha 63504b9d418fdebe0da538ced772d4bc9cbfaf24

Skip Gzipping assets in development (#5824) **Why**: It sped up rake assets:compile for me locally - Follow-up to #5812

view details

Manish Shah

commit sha eceea0f4df59cf3bb934b561e1d141edf1276174

LG-5670-RoU-acceptance-more-explicit (#5826) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Manish Shah

commit sha 12cfbac80505fb6b6872db1f4652cacd811f1972

LG-5523-state-id-number-to-state-issued-id (#5831) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Manish Shah

commit sha 83672a5449a1c0eedf2b14325c98ad9dff2f12be

LG-5523-state-id-number-to-state-issued-id-spell-fix (#5833) Co-authored-by: Manish Shah <manishshah@Manishs-MBP.fios-router.home>

view details

Andrew Duthie

commit sha e8dcc5680f1a16156056d4f5c30b055d325bb81d

Fix Acuant sequence-break error cookie sync issue (#5830) * Fix Acuant sequence-break error cookie sync issue **Why**: To fix a bug where if the Acuant camera fails to start due to iOS 15 "sequence-break" error, subsequent attempts to capture would result in the captured image not being set correctly. This fixes a regression introduced in #5778 where the cookie value tracked by AcuantCapture falls out of date after Acuant handles the error, since we never refresh the value after it is [set internally by Acuant's error handling](https://github.com/Acuant/JavascriptWebSDKV11/blob/9a5387576a33710188501ad6233f986b1b6bb1cb/SimpleHTMLApp/webSdk/dist/AcuantCamera.js#L616). Thus, the next time the user clicks "Take Photo", the [cookie value logic](https://github.com/18F/identity-idp/blob/eceea0f4df59cf3bb934b561e1d141edf1276174/app/javascript/packages/document-capture/components/acuant-capture.jsx#L400) is out-of-date, and Acuant capture is started instead of the default manual capture handling. To resolve this, we anticipate that Acuant would set the cookie in their error handling of sequence-break, and refresh the cookie value when we get a chance to handle the error in our own code. * Try to improve async handling of focus return * useCookie: Set next value as variable for subscriber set 1. Clearer that the value is actually being updated 2. Only parse cookie once for all subscribers, rather than per-subscriber

view details

Andrew Duthie

commit sha e1a05a7ef37054cc4b8320c3276caec422ba4d09

Prevent simultaneous active Acuant instances (#5834) * Prevent simulataneous active Acuant instances **Why**: Because the Acuant SDK (or at least our implementation of it) is treated as a singleton, unexpected behavior can occur when trying to start capturing a second image before the first is finished, as in the case of the new loading experience introduced in #5747. * Update specs for Acuant context * Rearrange capture spec to ensure image processing while clicking second

view details

Andrew Duthie

commit sha 7bdfb5b5013a394b120a4f6856a62fcdcbdbc97a

Improve "make run-https" asset workflow (#5835) * Improve "make run-https" asset workflow **Why**: - To prevent caching in development with the Rails public file server - To avoid writing webpack-dev-server URLs into the asset manifest when the app is requested across the network - To automatically recompile JavaScript while running "make run-https" * Keep webpack port consideration **Why**: So as not to break assets precompilation * Flip webpack watch and webpack serve by HTTPS env Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Nathan Berg

commit sha 6085ea61d3c402f28d52c66a470bc5b134617366

Update rules_of_use_updated_at (#5837) This is used to trigger users to accept the new rules of use. Relates to: https://github.com/18F/identity-site/pull/792

view details

Jessica Dembe

commit sha d7f1eaf8001c78ecc7c33a3d51838cca12cc2f0f

make text readable in personal key custom dialog (#5806) * add aria labelledby and ariadescribed by * add local assignment to views * change how data gets passed between personal key and modal * change other modals to be dynamically assigned * Update app/views/shared/_modal_layout.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * refactor label id and description, fix lint errors * Update app/views/reactivate_account/_modal.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/views/reactivate_account/_modal.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * add tab index -1 to modal Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

push time in 3 days

Pull request review comment18F/identity-idp

Replace SecureHeaders CSP tooling with built in Rails tooling

     ],     style_src: ["'self'", IdentityConfig.store.asset_host.presence],     base_uri: ["'self'"],+    preserve_schemes: true,+    disable_nonce_backwards_compatibility: true,

another "what browsers do we support" conversation

Based on this, seems like it's a very limited slice of browsers which would be impacted? i.e. pre-2015 Chrome/Firefox, and Safari 9 and below (15 is current).

jmhooper

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request comment18F/identity-style-guide

LG-4791: Add Process List component styles

Not critical, but something to note: The vertical center for the item number appears slightly more upward when my browser (both Chrome and Safari) is at 100% (See screenshot).

Yeah, I did notice this. I had actually put some "nudge" styling in place originally, then decided to revert it in 20b09bf. I noticed that it differs depending on the resolution of the display, because the nudge caused an offset when I was looking at the preview on my phone. Since the default styling is actually centered, I think it's probably a sub-pixel rounding issue.

There might be some other adjustments we could try to make this a bit more consistent (e.g. font size, circle size, etc).

aduth

comment created time in 3 days

push event18F/identity-style-guide

Andrew Duthie

commit sha cc43feee7e8ff18158242b31050e46d7bc50d730

Upgrade USWDS to 2.13.1 (#280) **Why**: To use latest features, improvements, and bug fixes. Notably, this includes the `luminance` function improvements that had been temporarily patched as part of #278 and can now be removed. Release notes: https://github.com/uswds/uswds/releases/tag/v2.13.1

view details

push time in 3 days

delete branch 18F/identity-style-guide

delete branch : aduth-uswds-2-13-1

delete time in 3 days

more