profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mitchellhenke/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Mitchell Henke mitchellhenke GSA (work) + Personal Projects Milwaukee, WI

getsentry/sentry-elixir 500

The official Elixir SDK for Sentry (sentry.io)

jeregrine/jsonapi 405

JSON:API Serializer and Query Handler for Elixir

MarchonMilwaukee/MarchonMilwaukee.github.io 2

200 Nights of Freedom Website.

18F/identity-pki-elixir 0

Support PIV/CAC with identity-idp, now with more immutability!

codeformilwaukee/hack-night-planning 0

Hack Night Planning Repository

release 18F/identity-pki

2021-09-23T212751

released time in 16 hours

created tag18F/identity-pki

tag2021-09-23T212751

Support PIV/CAC with identity-idp

created time in 16 hours

push event18F/identity-pki

Mitchell Henke

commit sha ffa0307a3ed9416973bb6f9c0e96b99e72981dc5

Delete expiring certs (#247) * delete expiring certs * delete expiring certs

view details

Mitchell Henke

commit sha d2ac258c8aabf5c58d8276c65ce9e345d0735626

Merge pull request #250 from 18F/stages/rc-2021-09-22 Deploy RC 24 to Prod

view details

push time in 16 hours

delete branch 18F/identity-pki

delete branch : stages/rc-2021-09-22

delete time in 16 hours

PR merged 18F/identity-pki

Reviewers
Deploy RC 24 to Prod

Removes some expiring certs

+0 -244

0 comment

8 changed files

mitchellhenke

pr closed time in 16 hours

push event18F/identity-idp

Zach Margolis

commit sha e3d9e39d1f7994675ed0158c35508890427f799b

Revert changes to IDV personal key generation (#5433) * Revert "Allow idv/confirmations_controller #show and #download out of order (LG-4847) (#5230)" This reverts commit 57308972fd615821a84dd51943923a195ec0190f. * Add regression specs

view details

Andrew Duthie

commit sha 1610c63bb950c4ff61e40f8568a552292f01d665

LG-3880: Remove BassCSS "background-colors" module (#5427) **Why**: To improve page load speed by reducing CSS bundle size, to eliminate developer confusion by choice of styling, to improve developer experience by reducing SASS compilation times, to standardize on design system colors and semantics, and to resolve broken visual appearances for backgrounds.

view details

Andrew Duthie

commit sha 07771a6613aece94ebae9ce3910b328cbbf6f590

Remove unused BassCSS modules (#5437) * Remove unused BassCSS **Why**: Because it's unused, and it unnecessarily inflates the size of our stylesheets. * Add table-fixed as deprecated class * Include h00-responsive in deprecated patterns

view details

Andrew Duthie

commit sha e1383df8cff12dcd8523d8f1eda37af18a3a783f

Extract Cleave.js-dependant JavaScript from application pack (#5435) * Extract Cleave.js-dependant JavaScript from application pack **Why**: Reduce minified bundle size of hot-path application.js by ~25%, and further establish convention of partial/component-specific JavaScript packs. * Include formatted-fields with zipcode field * Remove unused field patterns from form validation * Extract SSN field to shared partial See: https://github.com/18F/identity-idp/pull/5435#discussion_r714136554 * Remove unnecessary curly braces

view details

Mitchell Henke

commit sha d1ba8390ba18649ee60b0bce4970683f8e8e7b79

check pii matches and that personal key digest matches in personal key spec (#5436) * check pii matches and that personal key digest matches in spec * Update spec/controllers/idv/confirmations_controller_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * narrow allowed behavior in test of personal key #show Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

view details

Jessica Dembe

commit sha 67f437787e0afb1976c8730a9eaccd98e4f6c664

LG-5141: Move zip code to its own line (#5438) * move zip code to its own line * Address PR comment

view details

Zach Margolis

commit sha 07fd8b925698f1d26f52e54a38345d483e8e1eeb

Update pinpoint supported countries (#5439) - Via make update_pinpoint_supported_countries * Remove now-redundant pinpoint overrides

view details

push time in 16 hours

PullRequestReviewEvent
PullRequestReviewEvent

delete branch 18F/identity-idp

delete branch : mitchellhenke/disallow-other-hosts-on-referer-redirect

delete time in 20 hours

PullRequestReviewEvent

release 18F/identity-idp

2021-09-23T160808

released time in 21 hours

created tag18F/identity-idp

tag2021-09-23T160808

Login.gov Core App: Identity Provider (IdP)

created time in 21 hours

push event18F/identity-idp

Mitchell Henke

commit sha c1e541a56b99cbdc2b246c5ce62b5fe29e3da5c9

drop exception notifier (#5413)

view details

Zach Margolis

commit sha 89d48dffa394d1ff6d97a8b1b76d124e5e36318c

Add separate feature flags for cron jobs, IDV jobs (LG-5059) (#5412) * Remove ruby_workers_enabled since we have more granular flags now

view details

Zach Margolis

commit sha 88ff08926ed5dfaa72f931d5a37fa1ecd654fa99

Daily Auths Report: only one query once per destination (#5416)

view details

Andrew Duthie

commit sha ce15f9c604233a9c43673492276b7b85460fa0d0

LG-3880: Remove BassCSS "colors" module (#5408) * LG-3880: Remove BassCSS "colors" module **Why**: To improve page load speed by reducing CSS bundle size, to eliminate developer confusion by choice of styling, to improve developer experience by reducing SASS compilation times, and to standardize on design system styles. Reference for removal: https://github.com/basscss/basscss-sass/blob/v3.0.0/_colors.scss * Exclude gray from deprecated It's used in mailers as an explicitly-defined style. In the future, we should update this to at least a similarly named/colored `text-base-dark` design system utility. https://github.com/18F/identity-idp/blob/main/app/assets/stylesheets/email.css.scss * Replace red with text-error

view details

Doug Price

commit sha 130c5c63e33b8d30d514ff3304e2c0f6d7c0696e

LG-5073: add location to "Get Help at SP" link on welcome page (#5415) * LG-5073: add location to "Get Help at SP" link on welcome page * change location to 'missing_items' Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

view details

Andrew Duthie

commit sha 45121ad7ecc9dedd34c64eb41c06c6351b1599b8

Replace "btn-border" with USWDS checkbox and radio (#5279) * Replace "btn-border" with USWDS checkbox **Why**: - Consistency and alignment toward design system - Semantic correctness in considering checkboxes and radio inputs as inputs, not as buttons - Eliminates now-unused custom styling and JavaScript - Avoids relying on JavaScript for stylistic effects - Simpler implementation in some cases * Use constant for Privacy URL Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Omit empty label Avoid offset layout * Simplify radio disabled logic * Replace border-none with border-0 Rebase error Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Jessica Dembe

commit sha 0040901c3fa76c6f184d4f40ccda977249d3ec1e

change font size of personal key to 24px (#5397)

view details

Andrew Duthie

commit sha b0552fb4c7c1d336e76627fa359399fe05a5a792

LG-5072: Add Start Over to additional steps in the IAL2 flow (#5394) * Repurpose Idv::SessionsController#destroy for IAL2 restart **Why**: Because not all "Start Over" occurs is expected to occur within the FlowStateMachine (e.g. GPO verification, soon others). * Add "Start Over" link to IAL2 steps * Allow have_logged_event with absent attributes **Why**: Because sometimes events are logged without any attributes, and it's tedious / redundant to have to explicitly pass an empty hash, especially when the original call under test doesn't actually have to pass an empty hash. * Add Idv::SessionsController spec * Mock missing view values for IdV phone start_over_or_cancel uses cancel shared partial, which relies on specific values to determine whether user is signing up * Mock missing view values for IdV OTP delivery method * Support logging location params for SessionsController#destroy * Log "clear and start over" via step, location params * Opt-in verify_account view for ERB linting * Remove unused analytics constant * Remove unnecessary ERBLint exclusion It passes as-is * Remove more unnecessary ERBLint exclusions All passing * Add trailing comma to _start_over_or_cancel ERBLint * Pass step to start over link **Why**: It's already there!

view details

Mitchell Henke

commit sha 86c4f38e3632cf8a859b909b45fe72c3383106c1

Remove logstash command from setup (#5418)

view details

Mitchell Henke

commit sha b5356b4b9fb09f829394899db10139d52685d28e

support local-only install in build script (#5419)

view details

Mitchell Henke

commit sha 530cf12c2549d78da75106f37f59a04be1e6f6a4

do not raise while running RISC job if server returns SSL error (#5421)

view details

Mitchell Henke

commit sha 629d79ac4e1dcefbce6293bfd3ecd85833b791be

do not raise when code is nil in otp verification (#5420)

view details

Mitchell Henke

commit sha ef744390838f80e39dc8fa24b3a91ee2dc263cbe

update telephony gem to better handle errors (#5423)

view details

Andrew Duthie

commit sha 33d2f4da6a23022d48e1fa7a9082abe66b19cb75

Fix capitalization for Pinpoint SMS config key (#5424) * Fix capitalization for Pinpoint SMS config key **Why**: So that the script runs without errors. * Update spec fixture markup

view details

Andrew Duthie

commit sha 907d8cb3bc7605e755152169fa61e08058dc18b1

Refactor verification badge to use design system (#5422) * Refactor verification badge to use design system **Why**: - So that we don't have duplicate styles for the same UI element - To establish precedent for referencing assets from within the design system, which could be useful for future refactoring - To standardize markup of rendered badges to align with design system and support further refactoring as a view component - To help toward eliminating references to non-design-system SASS variables (space-1, space-2, white, green, border-radius-xxl) * Tighten ERBLint exclusions Lint all the things * Alphabetize ERBLint exclusions Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Remove unnecessary (redundant) badge image margin Already applied by styles Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Mitchell Henke

commit sha b68d3144506082ce03d3dc886a4899c358f4adf6

update gems (#5426)

view details

Mitchell Henke

commit sha eb03bfae94f4450bc79782cc003ecc88c8040d6d

Merge pull request #5429 from 18F/stages/rc-2021-09-21 Release RC 158 to production

view details

push time in 21 hours

delete branch 18F/identity-idp

delete branch : stages/rc-2021-09-21

delete time in 21 hours

PR merged 18F/identity-idp

Reviewers
Release RC 158 to production status - promotion
+632 -752

0 comment

93 changed files

mitchellhenke

pr closed time in 21 hours

push event18F/identity-terraform

Mitchell Henke

commit sha 91c557eba8ff06d3d7d181f96927f87346297849

improve format of slack alarm messages

view details

Mitchell Henke

commit sha e3dffe8dbfc8d0b9682fa0fcd848063ccd64c1b3

shorten Terraform note in alarm descriptions

view details

Mitchell Henke

commit sha 194e221352a2c9228e4a77886442d954a8af2e8d

Update slack_lambda/main.tf Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

Mitchell Henke

commit sha ee7140bb9277354871bff9e2400d17b6e1171c65

use python f strings

view details

push time in 2 days

delete branch 18F/identity-terraform

delete branch : mitchellhenke/slack-alerts-improved

delete time in 2 days

PR merged 18F/identity-terraform

Reviewers
Improve Formatting of Cloudwatch Alarms in Slack

We can pull anything we want out of the JSON that gets printed now, but I excluded what feels like some of the more extraneous information. Definitely open to feedback on the message format. I did test the updated lambda in the sandbox and it works (Slack link)

image

This also includes shortening the (Managed by Terraform) note and moving it to the end of the description to make it easier to read and parse the messages.

Proposed Format (without the TF description changes):

Alarm has gone off!
mhenke-squid-denials
(Managed by Terraform) Alarm when the Squid access log shows any denied requests
Threshold Crossed: 1 out of the last 15 datapoints [2.0 (22/09/21 15:25:00)] was greater than or equal to the threshold (1.0) (minimum 1 datapoint for OK -> ALARM transition).
Time: 2021-09-22T15:26:17.412+0000
Region: US West (Oregon)

Existing Format

<code> {"AlarmName":"mhenke-squid-denials","AlarmDescription":"(Managed by Terraform) Alarm when the Squid access log shows any denied requests","AWSAccountId":"894947205914","NewStateValue":"ALARM","NewStateReason":"Threshold Crossed: 1 out of the last 15 datapoints [1.0 (20/09/21 17:08:00)] was greater than or equal to the threshold (1.0) (minimum 1 datapoint for OK -> ALARM transition).","StateChangeTime":"2021-09-20T17:09:17.506+0000","Region":"US West (Oregon)","AlarmArn":"arn:aws:cloudwatch:us-west-2:894947205914:alarm:mhenke-squid-denials","OldStateValue":"OK","Trigger":{"MetricName":"mhenke/DeniedRequests","Namespace":"LogMetrics/squid","StatisticType":"Statistic","Statistic":"SUM","Unit":null,"Dimensions":[],"Period":60,"EvaluationPeriods":15,"ComparisonOperator":"GreaterThanOrEqualToThreshold","Threshold":1.0,"TreatMissingData":"- TreatMissingData: breaching","EvaluateLowSampleCountPercentile":""}} </code>

+16 -6

0 comment

5 changed files

mitchellhenke

pr closed time in 2 days

Pull request review comment18F/identity-terraform

Improve Formatting of Cloudwatch Alarms in Slack

 locals {         eventmsg = event['Records'][0]['Sns']['Message']         try:           data = json.loads(eventmsg)-          if data['detailType'] == 'CodePipeline Pipeline Execution State Change':+          if 'detailType' in data and data['detailType'] == 'CodePipeline Pipeline Execution State Change':             msgtext = 'auto-terraform:  ' + data['detail']['pipeline'] + ' pipeline ' + data['detail']['state'] + ' with execution ID ' + data['detail']['execution-id']+          elif 'AlarmName' in data and 'AlarmDescription' in data:+```suggestion

Ah, yep. I was working on a fix and converted to Python f strings for better formatting in 7b7d78a

mitchellhenke

comment created time in 2 days

PullRequestReviewEvent

push event18F/identity-terraform

Mitchell Henke

commit sha 7b7d78a46bbd05903674a310e5d23afd7dbc2c0a

use python f strings

view details

push time in 2 days

push event18F/identity-terraform

Mitchell Henke

commit sha 59a3e3f47c828259aace03820d6e60df1b6919f8

Update slack_lambda/main.tf Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>

view details

push time in 2 days

push event18F/identity-idp

Mitchell Henke

commit sha d1ba8390ba18649ee60b0bce4970683f8e8e7b79

check pii matches and that personal key digest matches in personal key spec (#5436) * check pii matches and that personal key digest matches in spec * Update spec/controllers/idv/confirmations_controller_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * narrow allowed behavior in test of personal key #show Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

view details

push time in 2 days

delete branch 18F/identity-idp

delete branch : mitchellhenke/slightly-stricter-personal-key-test

delete time in 2 days

PR merged 18F/identity-idp

check pii matches and that personal key digest matches in personal key spec

follow up to some regression spec additions in #5433 that makes it slightly stricter

+9 -3

0 comment

1 changed file

mitchellhenke

pr closed time in 2 days

Pull request review comment18F/identity-terraform

Improve Formatting of Cloudwatch Alarms in Slack

 locals {         eventmsg = event['Records'][0]['Sns']['Message']         try:           data = json.loads(eventmsg)-          if data['detailType'] == 'CodePipeline Pipeline Execution State Change':+          if 'detailType' in data and data['detailType'] == 'CodePipeline Pipeline Execution State Change':             msgtext = 'auto-terraform:  ' + data['detail']['pipeline'] + ' pipeline ' + data['detail']['state'] + ' with execution ID ' + data['detail']['execution-id']+          elif 'AlarmName' in data and 'AlarmDescription' in data:+            msgtext = ('Alarm has gone off!\n' + data['AlarmName'] + '\n' + data['AlarmDescription'] + '\n' + data['NewStateReason'] + '\nTime: ' ++                      data['StateChangeTime'] + '\nRegion: ' + data['Region'])

Thanks!

mitchellhenke

comment created time in 2 days

PullRequestReviewEvent

Pull request review comment18F/identity-idp

check pii matches and that personal key digest matches in personal key spec

 def index       expect(@analytics).to have_logged_event(Analytics::IDV_DOWNLOAD_PERSONAL_KEY, success: true)     end -    it 'recovers pii with the code' do+    it 'recovers pii and verifies personal key digest with the code' do       get :show       get :download        code = response.body.chomp -      expect(user.profiles.first.recover_pii(normalize_personal_key(code))).to be

we are still using normalize_personal_key, but I added 0709cbb2f to have a similar check in that spec

mitchellhenke

comment created time in 2 days

PullRequestReviewEvent