Limeth ( Jakub Hlusička )

A guide for rewriting Shadertoy shaders

@P-ignatovich Please see the suggested changes I approved previously: https://github.com/gfx-rs/gfx/pull/3323/commits/2bfbd4d4efaa4bc127e8392f679cf51cfc2e2c43

Limeth

comment created time in 2 months

issue commentLimeth/obs-shaderfilter-plus

This plugin currently does not let you combine multiple sources, though I would definitely like to see this functionality added in the future. I assume it would not be facilitated using "Effect Filters", but rather a new source that combines other sources. The OBS documentation regarding this seems very scarce, however, so I have not made much progress on that front.

MarioMey

comment created time in 2 months

issue commentLimeth/obs-shaderfilter-plus

Help...?

Hello, thank you for the question! I think that it would be helpful to create a wiki page comparing shadertoy and OBS ShaderFilter Plus shaders and about how to adapt the shaders.

In your particular example, the uniforms would have to be renamed according to the README and

void main() {
    vec2 st = gl_FragCoord.xy/u_resolution.xy;

would be replaced with

float4 render(float2 st) {

vec4 render(vec2 st) {

depending whether you use DirectX or OpenGL, respectively.

MarioMey

comment created time in 2 months

pull request commentgfx-rs/gfx

The @monocodus bot seems to have been recommending odd style changes, such as incorrect indentation, so I did not apply their suggestions this time. I have tried creating a Multiview example derived from the quad example, but I got stuck when implementing the synchronization logic, as I do not feel confident in my understanding of it and how it is structured in gfx.

Limeth

comment created time in 3 months

push eventLimeth/gfx

commit sha ce44c9f230e05dac0754e687f9c97838c64aeea3

WIP: Begin work on a Multiview example

push time in 3 months

Pull request review commentgfx-rs/gfx

 impl queue::QueueFamily for QueueFamily {     } } +pub struct PhysicalDeviceMultiviewProperties {+    pub max_multiview_view_count: u32,+    pub max_multiview_instance_index: u32,+}++impl From<vk::PhysicalDeviceMultiviewProperties> for PhysicalDeviceMultiviewProperties {+    fn from(other: vk::PhysicalDeviceMultiviewProperties) -> Self {+        PhysicalDeviceMultiviewProperties {+            max_multiview_view_count: other.max_multiview_view_count,+            max_multiview_instance_index: other.max_multiview_instance_index,+        }+    }+}++pub struct PhysicalDeviceProperties {+    properties: vk::PhysicalDeviceProperties,+    multiview: Option<PhysicalDeviceMultiviewProperties>,+}++impl PhysicalDeviceProperties {+    pub fn load(instance: &Instance, device: &vk::PhysicalDevice, extensions: &[vk::ExtensionProperties]) -> Self {+        fn supports_extension(extensions: &[vk::ExtensionProperties], extension: &CStr) -> bool {+            extensions.iter()+                .any(|ep| unsafe { CStr::from_ptr(ep.extension_name.as_ptr()) } == extension)+        }++        if let Some(ref get_device_properties) = instance.raw.get_physical_device_properties {+            let mut properties2_builder = vk::PhysicalDeviceProperties2KHR::builder()+                .properties(vk::PhysicalDeviceProperties::builder().build());+            let mut multiview = None;++            // Add extension infos to the p_next chain+            if supports_extension(extensions, *KHR_MULTIVIEW) {

This check is performed only once during the initialization of PhysicalDevices, I have now replaced the same check within PhysicalDevice::features(): https://github.com/gfx-rs/gfx/pull/3323/files#diff-44198a1b71ecb41e695db8b6967cd689R1028

Limeth

comment created time in 3 months

push eventLimeth/gfx

commit sha cdca5ddb2e476ca3fd71cd2abca518e10032761a

Apply suggestions

push time in 3 months

startedheadcrab-rs/headcrab

started time in 3 months

startedboxdot/gurk-rs

started time in 3 months

startedrepnop/vanadinite

started time in 3 months

startedemilianavt/OpenSeeFace

started time in 3 months

Pull request review commentgfx-rs/gfx

 impl queue::QueueFamily for QueueFamily {     } } +pub struct PhysicalDeviceMultiviewProperties {+    pub max_multiview_view_count: u32,+    pub max_multiview_instance_index: u32,+}

Substitute to vk::PhysicalDeviceMultiviewProperties without any pointers that would prevent PhysicalDeviceProperties below from being Sync.

Limeth

comment created time in 3 months

push eventLimeth/gfx

commit sha 2bfbd4d4efaa4bc127e8392f679cf51cfc2e2c43

Apply suggestions from code review Co-authored-by: monocodus[bot] <49363530+monocodus[bot]@users.noreply.github.com>

push time in 3 months

PR opened gfx-rs/gfx

WIP: Feature multiview

Once finished, Fixes #3303. Hopefully the API usage is correct. An example demonstrating the Multiview feature would be desirable. Feedback is appreciated.

PR checklist:

[x] make succeeds (on *nix)
[ ] make reftests succeeds
[ ] tested examples with the following backends:
[ ] rustfmt run on changed code

+191 -47

2 commit in Limeth/gfx/tree/feature-multiview gfx-rs/gfx/tree/master

0 comment

15 changed files

pr created time in 3 months

push eventLimeth/gfx

commit sha 99e6df7c52cda40cea3148dccc0bea319ab2b2a9

Ensure all backends compile