profile
viewpoint
Vojtech Novak vonovak Prague, Czech Republic https://react-native-training.eu/ React Native, Java and Objective-C

react-native-community/google-signin 1917

Google Sign-in for your React Native applications

oblador/react-native-keychain 1836

:key: Keychain Access for React Native

react-native-community/datetimepicker 743

React Native date & time picker component for iOS, Android and Windows

Elyx0/react-native-document-picker 567

Document Picker for React Native using Document Providers

react-native-dialogs/react-native-dialogs 555

React Native wrappers for https://github.com/afollestad/material-dialogs

vonovak/appcenter-build-scripts-examples 0

A collection of build script examples to be used in the Build service of https://appcenter.ms

vonovak/circleci-cli 0

Use CircleCI from the command line

startedCovidShield/mobile

started time in 4 hours

issue commentreact-native-community/datetimepicker

Value is being updated while picking

It seems to me you're talking about 2 separate things

first:

The problem: value props is being updated, even if picker is open.

second:

onChange function should be called after each change (at the moment it is called on ok/cancel button press).

or do I misunderstand? Please expand on this, and be detailed in the differences between current and expected behavior, thank you.

alex-golubtsov

comment created time in 4 days

issue commentreact-native-community/datetimepicker

Value is being updated while picking

hello and thanks for reporting. What is your expected behavior?

alex-golubtsov

comment created time in 5 days

release vonovak/react-navigation-header-buttons

v5.0.0

released time in 5 days

push eventvonovak/react-navigation-header-buttons

Vojtech Novak

commit sha 522a1118a494d8f8c725c7852ce31bdb1aaf5244

chore: small readme adjustments

view details

push time in 5 days

push eventvonovak/react-navigation-header-buttons

Vojtech Novak

commit sha bb3dd7d90ea250355273a6ddd36e64b4d2382d64

5.0.0

view details

push time in 5 days

created tagvonovak/react-navigation-header-buttons

tagv5.0.0

Easily render header buttons for react-navigation.

created time in 5 days

PR merged vonovak/react-navigation-header-buttons

added support for destructive buttons on iOS

Added support for destructive buttons styling of ActionSheetIOS.

Heavily inspired by https://github.com/vonovak/react-navigation-header-buttons/pull/60, but allows to specify multiple destructive buttons.

+82 -37

0 comment

6 changed files

jbazant

pr closed time in 5 days

push eventvonovak/react-navigation-header-buttons

Jiří Bažant

commit sha aceff22e5909c57cf363b5f44451d5b004f37280

feat: added support for destructive actions in overflowMenuPressHandlerActionSheet * added support for destructive buttons on iOS * fix flow * fix lint errors * add ts typings * bump react-native version * revert version bump and corresponding changes * HiddenItem destructive prop passing updated * lint fixes Co-authored-by: Jiri Bazant <jiri.bazant@memsource.com>

view details

push time in 5 days

issue commentreact-native-community/datetimepicker

Compiling against the iOS 14 SDK changes the look of the native APIs, so this library looks extremely weird.

@NeliHarbuzava I'm expect to get this done in a week or two

SConaway

comment created time in 5 days

Pull request review commentvonovak/react-navigation-header-buttons

added support for destructive buttons on iOS

 export type Props = {|    * TestID used for testing purposes    */   testID?: string,+  /**+   * Whether the 'item' is destructive action. Destructive items are formatted differently on iOS.+   */+  destructive?: boolean

the screenshot comes from the overflowMenuPressHandlerActionSheet, but src/overflowMenu/vendor/MenuItem.js is used in overflowMenuPressHandlerDropdownMenu. Even if you look at https://github.com/vonovak/react-navigation-header-buttons/blob/364a327b1e56bb62c3c6c3d14d68eb4e69c234d9/src/overflowMenu/vendor/MenuItem.js you'll see destructive is not used in there

jbazant

comment created time in 5 days

release vonovak/react-navigation-backhandler

v2.0.1

released time in 5 days

created tagvonovak/react-navigation-backhandler

tagv2.0.1

Easily handle Android back button behavior with React-Navigation.

created time in 5 days

push eventvonovak/react-navigation-backhandler

Vojtech Novak

commit sha bbe6a1c0894f9198214f0c7e8a4e3543a0a4f6ad

2.0.1

view details

push time in 5 days

pull request commentvonovak/react-navigation-backhandler

Fix export

thanks!

mamousavi

comment created time in 5 days

push eventvonovak/react-navigation-backhandler

Mir Amir Mousavi

commit sha 62a45f549a140ff8aaf13a9e68b2e27f09eed2ce

Fix export (#21)

view details

push time in 5 days

release vonovak/react-navigation-header-buttons

v4.0.3

released time in 5 days

created tagvonovak/react-navigation-header-buttons

tagv4.0.3

Easily render header buttons for react-navigation.

created time in 5 days

push eventvonovak/react-navigation-header-buttons

Vojtech Novak

commit sha fb059a0b860e5ccf0e7e5fc7c7081e76247c6e2e

4.0.3

view details

push time in 5 days

PR merged vonovak/react-navigation-header-buttons

Do not render OverflowMenu without child elements

Version 3 of this library do not render overflow button when no hidden items were specified. This introduces same behaviour to v4.

+34 -0

0 comment

3 changed files

jbazant

pr closed time in 5 days

push eventvonovak/react-navigation-header-buttons

Jiří Bažant

commit sha cbb0d6dc67d10ff5d3941f1ead474cfbff511c24

fix: do not render OverflowMenu if there are no valid children (#85) * Do not render OverflowMenu without child elements * ignore falsy children * fix flow errors * fix lint error * updated ts typings * review * undo TS typings change * fix lint Co-authored-by: Jiri Bazant <jiri.bazant@memsource.com> Co-authored-by: Vojtech Novak <vonovak@gmail.com>

view details

push time in 5 days

push eventjbazant/react-navigation-header-buttons

Vojtech Novak

commit sha 59e7ce0d966bc1bf515b6b8f19a72a7df74fd43d

fix lint

view details

push time in 5 days

push eventjbazant/react-navigation-header-buttons

Vojtech Novak

commit sha 65d25808802386276fb1c3e0ed5d61c08573f62e

undo TS typings change

view details

push time in 5 days

push eventjbazant/react-navigation-header-buttons

Vojtech Novak

commit sha 33f90d438fe6ad2eac862c174baaf2b0ac8bb520

review

view details

push time in 5 days

Pull request review commentvonovak/react-navigation-header-buttons

added support for destructive buttons on iOS

 export type Props = {|    * TestID used for testing purposes    */   testID?: string,+  /**+   * Whether the 'item' is destructive action. Destructive items are formatted differently on iOS.+   */+  destructive?: boolean

is this here just to satisfy flow or not? I find the comment a little misleading, because ifaik the destructive prop does not influence MenuItem in any way, or does it?

jbazant

comment created time in 6 days

Pull request review commentvonovak/react-navigation-header-buttons

added support for destructive buttons on iOS

 const HiddenItemWrappedTwice = ()=> <HiddenItemWrapped />  `HiddenItem` accepts: -| prop and type              | description                                                 | note |-| -------------------------- | ----------------------------------------------------------- | ---- |-| title: string              | title for the button, required                              |      |-| style?: ViewStyleProp      | style to apply to the touchable element that wraps the text |      |-| titleStyle?: ViewStyleProp | style to apply to the text                                  |      |-| onPress: ?() => any        | function to call on press                                   |      |-| testID?: string            | testID to locate view in e2e tests                          |      |-| disabled?: boolean         |                                                             |      |+| prop and type              | description                                                        | note     |+| -------------------------- | ------------------------------------------------------------------ | -------- |+| title: string              | title for the button, required                                     |          |+| style?: ViewStyleProp      | style to apply to the touchable element that wraps the text        |          |+| titleStyle?: ViewStyleProp | style to apply to the text                                         |          |+| onPress: ?() => any        | function to call on press                                          |          |+| testID?: string            | testID to locate view in e2e tests                                 |          |+| disabled?: boolean         | disabled 'item' is greyed out and `onPress` is not called on touch |          |+| destructive?: boolean      | flag specifying whether this item is destructive                   | iOS only |

can you please add this to the TS typings file too? Thanks

jbazant

comment created time in 6 days

Pull request review commentvonovak/react-navigation-header-buttons

added support for destructive buttons on iOS

 export const overflowMenuPressHandlerActionSheet = ({ }: OnOverflowMenuPressParams) => {   checkParams(hiddenButtons);   let actionTitles = hiddenButtons.map((btn) => btn.title);+  let destructiveActions = hiddenButtons.reduce((acc, btn, index) => {
  const destructiveActions = hiddenButtons.reduce((acc, btn, index) => {
jbazant

comment created time in 6 days

Pull request review commentvonovak/react-navigation-header-buttons

Do not render OverflowMenu without child elements

 describe('overflowMenu', () => {       });     }   );++  it('should not render overflow button when no item is specified', () => {+    const onPress = jest.fn();++    const { queryByA11yLabel } = render(+      <OverflowMenu OverflowIcon={<Text>+</Text>} onPress={onPress} />

I think we also want to handle the case when we have

      <OverflowMenu OverflowIcon={<Text>+</Text>} onPress={onPress}>
        {false && <HiddenItem icon={<Text>O</Text>} title="search" onPress={...} />}
      </OverflowMenu>

and show nothing in that case

jbazant

comment created time in 6 days

issue commentnotifee/react-native-notifee

[question] APNs integration

@jyliang yes, from my experience, notifee overwrites the delegate you may have set previously, and so your delegate does not learn the events it should. I hope this will be addressed at some point soon.

vonovak

comment created time in 6 days

issue commentreact-native-community/datetimepicker

Time picker sometimes resets value to previous value after change

:tada: This issue has been resolved in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

bitttttten

comment created time in 7 days

pull request commentreact-native-community/datetimepicker

Update Readme intro with Windows info.

:tada: This PR is included in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rectified95

comment created time in 7 days

pull request commentreact-native-community/datetimepicker

fix time picker sometimes resets to previous value

:tada: This PR is included in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mnmaraes

comment created time in 7 days

pull request commentreact-native-community/datetimepicker

Fix circle ci status

:tada: This PR is included in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

luancurti

comment created time in 7 days

pull request commentreact-native-community/datetimepicker

Bump lodash from 4.17.15 to 4.17.19

:tada: This PR is included in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dependabot[bot]

comment created time in 7 days

pull request commentreact-native-community/datetimepicker

chore: add semantic-relase

:tada: This PR is included in version 2.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vonovak

comment created time in 7 days

release react-native-community/datetimepicker

v2.6.1

released time in 7 days

created tagreact-native-community/datetimepicker

tagv2.6.1

React Native date & time picker component for iOS, Android and Windows

created time in 7 days

push eventreact-native-community/datetimepicker

semantic-release-bot

commit sha 480a1b13e8e1c61b8b7c6f38961c7665d5f5ff16

chore(release): 2.6.1 [skip ci] ## [2.6.1](https://github.com/react-native-community/datetimepicker/compare/v2.6.0...v2.6.1) (2020-07-28) ### Bug Fixes * time picker sometimes resets to previous value ([#234](https://github.com/react-native-community/datetimepicker/issues/234)) ([fda536b](https://github.com/react-native-community/datetimepicker/commit/fda536b949649d0a36cb5b2cfc451e23b0a6ee88))

view details

push time in 7 days

push eventreact-native-community/datetimepicker

Murillo Nicacio de Maraes

commit sha fda536b949649d0a36cb5b2cfc451e23b0a6ee88

fix: time picker sometimes resets to previous value (#234) * DateTimePicker iOS fix * [CHANGELOG] DateTimePicker iOS fix * Update CHANGELOG.md Co-authored-by: Vojtech Novak <vonovak@gmail.com>

view details

push time in 7 days

PR merged react-native-community/datetimepicker

fix time picker sometimes resets to previous value

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect -->

Summary

Keeps values sent to JS side from resetting the native picker component on iOS. fixes #192

It's a simple diff check on the Class' setDate: method

<!-- Explain the motivation for making this change: here are some points to help you:

  • What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
  • What is the feature? (if applicable)
  • How did you implement the solution?
  • What areas of the library does it impact? -->

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

What's required for testing (prerequisites)?

See issue above

What are the steps to reproduce (after prerequisites)?

See issue above

Compatibility

OS Implemented
iOS
Android

Checklist

<!-- Check completed item, when applicable, via: [X] -->

  • [x] I have tested this on a device and a simulator
  • [ ] ~I added the documentation in README.md~
  • [x] I mentioned this change in CHANGELOG.md
  • [ ] ~I updated the typed files (TS and Flow)~
  • [ ] ~I added a sample use of the API in the example project (example/App.js)~

Let me know if any other info/changes are needed :)

+7 -0

0 comment

1 changed file

mnmaraes

pr closed time in 7 days

push eventmnmaraes/datetimepicker

Vojtech Novak

commit sha 3af1c5cbe6417151693d02f6d610d226e68c7e36

Update CHANGELOG.md

view details

push time in 7 days

Pull request review commentreact-native-community/datetimepicker

Feat/Android locale support

 DatePickerDialog getDialog(                   display           );         default:+          if (args != null && args.containsKey(RNConstants.ARG_LOCALE)) {+            // for header (NOTE: will change the app locale)+            Locale.setDefault(getLocale(args));

It's quite possible there is no other way to localize the pickers, but this seems like an action that can have far-reaching consequences.

on ios the prop just "overrides the system default with a specific locale." - that is a "safe way" of specifying locale.

Here, the call would have side effects beyond the datepicker, and I'm not sure we want to take that path. Seem to me that code like this should probably be called from userland upon app start. What do you think?

(also applies to activityContext.getResources().getConfiguration().setLocale(getLocale(args))).

Inbal-Tish

comment created time in 8 days

Pull request review commentreact-native-community/datetimepicker

Feat/Android locale support

+#Wed Jul 22 14:26:15 IDT 2020

why do you belive these gradle files should be included in the repo?

Inbal-Tish

comment created time in 8 days

PR opened react-native-community/datetimepicker

chore: add semantic-relase [wild try]

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect -->

Summary

motivation: we want automatically generated changelogs, and releases.

When this is done, the PRs merged by maintainers need to follow the conventions

+3075 -73

0 comment

4 changed files

pr created time in 13 days

delete branch react-native-community/datetimepicker

delete branch : fix/circle-ci-status

delete time in 13 days

delete branch react-native-community/datetimepicker

delete branch : @vonovak/release-automation

delete time in 13 days

issue closedElyx0/react-native-document-picker

Android Pick PDF not working when using Images types

In android v3.5.3 when i use DocumentPicker.types.images it overrides all types and show only images in picker.

 const file = await DocumentPicker.pick({
          type: [DocumentPicker.types.pdf, DocumentPicker.types.images],
          readContent: true,
          copyTo: 'cachesDirectory',
        });

Currently I want pdf and images both but it is only showing images.

closed time in 13 days

msaqlain

push eventElyx0/react-native-document-picker

Vojtech Novak

commit sha 3684d4fcc2bc0b47c32be39024e4796004c3e428

3.5.4

view details

push time in 13 days

created tagElyx0/react-native-document-picker

tagv3.5.4

Document Picker for React Native using Document Providers

created time in 13 days

pull request commentElyx0/react-native-document-picker

Get Mime types using readableArrayToStringArray

thanks!

msaqlain

comment created time in 13 days

push eventElyx0/react-native-document-picker

Muhammad Saqlain

commit sha 5d1df3cab94d7df2567f9d2d7b5b1eb6dcba7c40

Get Mime types using readableArrayToStringArray (#330) * Get Mime types using readableArrayToStringArray * Update DocumentPickerModule.java Co-authored-by: Vojtech Novak <vonovak@gmail.com>

view details

push time in 13 days

PR merged Elyx0/react-native-document-picker

Get Mime types using readableArrayToStringArray

This fix is related to bug https://github.com/Elyx0/react-native-document-picker/issues/329

+11 -1

0 comment

1 changed file

msaqlain

pr closed time in 13 days

push eventmsaqlain/react-native-document-picker

Vojtech Novak

commit sha 2bfd115a0ce5fcd15b74bceb0520fbffac314949

Update DocumentPickerModule.java

view details

push time in 13 days

issue commentreact-native-community/datetimepicker

Datepicker text on physical iPhone is White

hello @dmantelli does this help? https://github.com/react-native-community/datetimepicker/pull/204/files

dmantelli

comment created time in 13 days

push eventElyx0/react-native-document-picker

Marq Roldan

commit sha 242ffde18debbee02385f90ed01244502dcd47c7

Update README.md (#327) We should probably update this part as since this package is no longer using `Intent.ACTION_OPEN_DOCUMENT` or `Intent.ACTION_PICK` since 2017

view details

push time in 14 days

PR merged Elyx0/react-native-document-picker

Update README.md

We should probably update this part as since this package is no longer using Intent.ACTION_OPEN_DOCUMENT nor Intent.ACTION_PICK since 2017

https://github.com/Elyx0/react-native-document-picker/pull/77 063fe5d7c140c6b4a5263dd5aaf22395c8768fdf

+1 -1

0 comment

1 changed file

marqroldan

pr closed time in 14 days

issue closedElyx0/react-native-document-picker

iOS files missing or deleted after several minutes

Acessing the file and filepath are working as intended initially but after a period of several minutes accessing the file again will result in the file not being found or missing.

This is on iOS. Could it be that because the files are in a temporary path /tmp/ they're being cleaned?

What would be the recommended solution here? Copying or moving the file to another directory?

closed time in 15 days

IvanCaceres

issue commentElyx0/react-native-document-picker

iOS files missing or deleted after several minutes

On iOS, the solution is to use the copyTo option.

Closing because the original issue is resolved.

IvanCaceres

comment created time in 15 days

PR merged vonovak/react-native-add-calendar-event

Bump lodash from 4.17.15 to 4.17.19 in /example dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 15 days

push eventvonovak/react-native-add-calendar-event

dependabot[bot]

commit sha 35efeaf3761ac79d994565696cdfd997111b31ed

Bump lodash from 4.17.15 to 4.17.19 in /example (#107) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 15 days

push eventvonovak/react-native-add-calendar-event

dependabot[bot]

commit sha 4871113dd18cb9ea7eadfeafe6029dd0d4d0c5ea

Bump lodash from 4.17.15 to 4.17.19 (#106) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 15 days

PR merged vonovak/react-native-add-calendar-event

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 15 days

delete branch react-native-community/datetimepicker

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 15 days

push eventreact-native-community/datetimepicker

dependabot[bot]

commit sha 5df8a9e5fceaa7a5e2c64ff05394755b5520b859

Bump lodash from 4.17.15 to 4.17.19 (#226) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 15 days

PR merged react-native-community/datetimepicker

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -8

0 comment

1 changed file

dependabot[bot]

pr closed time in 15 days

issue commentreact-native-community/discussions-and-proposals

What packages belong in react-native-community?

Personally, I would prefer that the RN community org does not grow larger - in terms of number of repos that are in it, but rather smaller, if possible. From my (limited) experience, when a library is in the RNC it

(1) gives the module a "premium badge" just because of its presence in RNC - whereas in reality, any module can be great regardless of what GH org it is in.

(2) Users assume that if a module is in RNC, it is top quality - and that may or may not be true. Some modules are in great shape, others like datetimepicker have a lot of work that needs to be done - I say that as that module's maintainer.

(3) Kinda related to (2) - I feel like because a module is in RNC, folks might assume it has "a team of maintainers", and from my experience in datetimepicker, outside contributions do not happen as often as I'd expect.

TheSavior

comment created time in 16 days

push eventreact-native-community/datetimepicker

luancurti

commit sha a4a02e9a798a45ae2832d4ae5f636088f8270e32

fix circle ci status (#225)

view details

push time in 16 days

PR merged react-native-community/datetimepicker

Fix circle ci status

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect -->

Summary

Fix circle ci status in README

<!-- Explain the motivation for making this change: here are some points to help you:

  • What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
  • What is the feature? (if applicable)
  • How did you implement the solution?
  • What areas of the library does it impact? -->

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

<!-- Check completed item, when applicable, via: [X] -->

  • [ ] I have tested this on a device and a simulator
  • [X] I added the documentation in README.md
  • [ ] I mentioned this change in CHANGELOG.md
  • [ ] I updated the typed files (TS and Flow)
  • [ ] I added a sample use of the API in the example project (example/App.js)
+1 -1

0 comment

1 changed file

luancurti

pr closed time in 16 days

push eventreact-native-community/google-signin

dependabot[bot]

commit sha c8f5644f1d9730eb00575dfa95c642a70cd6bc3d

Bump lodash from 4.17.15 to 4.17.19 (#907) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 17 days

PR merged react-native-community/google-signin

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 17 days

issue commentoblador/react-native-keychain

getGenericPassword is too slow on android 10

please contribute

@sm2017 here's a quick answer to that: https://twitter.com/vonovak/status/1283895813903654912?s=20

hope this makes sense 🙂

sm2017

comment created time in 18 days

delete branch vonovak/react-navigation-props-mapper

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 18 days

push eventvonovak/react-navigation-props-mapper

dependabot[bot]

commit sha 64548bfa0f093195a1221f338d40421444fe2d4b

Bump lodash from 4.17.11 to 4.17.19 (#27) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 18 days

PR merged vonovak/react-navigation-props-mapper

Bump lodash from 4.17.11 to 4.17.19 dependencies

Bumps lodash from 4.17.11 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.11...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -9

0 comment

1 changed file

dependabot[bot]

pr closed time in 18 days

Pull request review commentElyx0/react-native-document-picker

[Android][Google Drive] Download file from google drive then cache in local storage

 The type or types of documents to allow selection of. May be an array of types a - If `type` is omitted it will be treated as `*/*` or `public.content`. - Multiple type strings are not supported on Android before KitKat (API level 19), Jellybean will fall back to `*/*` if you provide an array with more than one value. -##### [iOS only] `copyTo`:`"cachesDirectory" | "documentDirectory"`:+##### `copyTo`:`"cachesDirectory" | "documentDirectory"`:
##### [iOS and Android only] `copyTo`:`"cachesDirectory" | "documentDirectory"`:
r0b0t3d

comment created time in 20 days

Pull request review commentElyx0/react-native-document-picker

[Android][Google Drive] Download file from google drive then cache in local storage

 public void onShowActivityResult(int resultCode, Intent data, Promise promise) { 			}  			try {-				WritableArray results = Arguments.createArray();-+				List<Uri> uris = new ArrayList<>(); 				if (uri != null) {-					results.pushMap(getMetadata(uri));+					uris.add(uri); 				} else if (clipData != null && clipData.getItemCount() > 0) { 					final int length = clipData.getItemCount(); 					for (int i = 0; i < length; ++i) { 						ClipData.Item item = clipData.getItemAt(i);-						results.pushMap(getMetadata(item.getUri()));+						uris.add(item.getUri()); 					} 				} else {-					promise.reject(E_INVALID_DATA_RETURNED, "Invalid data returned by intent");+					sendError(E_INVALID_DATA_RETURNED, "Invalid data returned by intent"); 					return; 				} -				promise.resolve(results);+				new ProcessDataTask(getReactApplicationContext(), uris, copyTo, promise).execute(); 			} catch (Exception e) {-				promise.reject(E_UNEXPECTED_EXCEPTION, e.getLocalizedMessage(), e);+				sendError(E_UNEXPECTED_EXCEPTION, e.getLocalizedMessage(), e); 			} 		} else {-			promise.reject(E_UNKNOWN_ACTIVITY_RESULT, "Unknown activity result: " + resultCode);+			sendError(E_UNKNOWN_ACTIVITY_RESULT, "Unknown activity result: " + resultCode); 		} 	} -	private WritableMap getMetadata(Uri uri) {-		WritableMap map = Arguments.createMap();--		map.putString(FIELD_URI, uri.toString());-		// TODO vonovak - FIELD_FILE_COPY_URI is implemented on iOS only (copyTo) settings-		map.putString(FIELD_FILE_COPY_URI, uri.toString());+	private static class ProcessDataTask extends GuardedResultAsyncTask<ReadableArray> {+		private Context context;

android studio is complaining about "this field leaks a context object" - we probably should use a WeakReference here

r0b0t3d

comment created time in 20 days

Pull request review commentElyx0/react-native-document-picker

[Android][Google Drive] Download file from google drive then cache in local storage

 public void onShowActivityResult(int resultCode, Intent data, Promise promise) { 			}  			try {-				WritableArray results = Arguments.createArray();-+				List<Uri> uris = new ArrayList<>(); 				if (uri != null) {-					results.pushMap(getMetadata(uri));+					uris.add(uri); 				} else if (clipData != null && clipData.getItemCount() > 0) { 					final int length = clipData.getItemCount(); 					for (int i = 0; i < length; ++i) { 						ClipData.Item item = clipData.getItemAt(i);-						results.pushMap(getMetadata(item.getUri()));+						uris.add(item.getUri()); 					} 				} else {-					promise.reject(E_INVALID_DATA_RETURNED, "Invalid data returned by intent");+					sendError(E_INVALID_DATA_RETURNED, "Invalid data returned by intent"); 					return; 				} -				promise.resolve(results);+				new ProcessDataTask(getReactApplicationContext(), uris, copyTo, promise).execute(); 			} catch (Exception e) {-				promise.reject(E_UNEXPECTED_EXCEPTION, e.getLocalizedMessage(), e);+				sendError(E_UNEXPECTED_EXCEPTION, e.getLocalizedMessage(), e); 			} 		} else {-			promise.reject(E_UNKNOWN_ACTIVITY_RESULT, "Unknown activity result: " + resultCode);+			sendError(E_UNKNOWN_ACTIVITY_RESULT, "Unknown activity result: " + resultCode); 		} 	} -	private WritableMap getMetadata(Uri uri) {-		WritableMap map = Arguments.createMap();--		map.putString(FIELD_URI, uri.toString());-		// TODO vonovak - FIELD_FILE_COPY_URI is implemented on iOS only (copyTo) settings-		map.putString(FIELD_FILE_COPY_URI, uri.toString());+	private static class ProcessDataTask extends GuardedResultAsyncTask<ReadableArray> {+		private Context context;+		private final List<Uri> uris;+		private final String copyTo;+		private final Promise promise;++		protected ProcessDataTask(ReactContext reactContext, List<Uri> uris, String copyTo, Promise promise) {+			super(reactContext.getExceptionHandler());+			this.context = reactContext.getApplicationContext();+			this.uris = uris;+			this.copyTo = copyTo;+			this.promise = promise;+		} -		ContentResolver contentResolver = getReactApplicationContext().getContentResolver();+		@Override+		protected ReadableArray doInBackgroundGuarded() {+			WritableArray results = Arguments.createArray();+			for (Uri uri : uris) {+				results.pushMap(getMetadata(uri));+			}+			return results;+		} -		map.putString(FIELD_TYPE, contentResolver.getType(uri));+		@Override+		protected void onPostExecuteGuarded(ReadableArray readableArray) {+			promise.resolve(readableArray);+		} -		try (Cursor cursor = contentResolver.query(uri, null, null, null, null, null)) {-			if (cursor != null && cursor.moveToFirst()) {-				int displayNameIndex = cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME);-				if (!cursor.isNull(displayNameIndex)) {-					map.putString(FIELD_NAME, cursor.getString(displayNameIndex));+		private WritableMap getMetadata(Uri uri) {+			ContentResolver contentResolver = context.getContentResolver();+			WritableMap map = Arguments.createMap();+			map.putString(FIELD_URI, uri.toString());+			map.putString(FIELD_TYPE, contentResolver.getType(uri));+			String fileName = null;+			try (Cursor cursor = contentResolver.query(uri, null, null, null, null, null)) {+				if (cursor != null && cursor.moveToFirst()) {+					int displayNameIndex = cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME);+					if (!cursor.isNull(displayNameIndex)) {+						fileName = cursor.getString(displayNameIndex);+						map.putString(FIELD_NAME, fileName);+					}+					if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {+						int mimeIndex = cursor.getColumnIndex(DocumentsContract.Document.COLUMN_MIME_TYPE);+						if (!cursor.isNull(mimeIndex)) {+							map.putString(FIELD_TYPE, cursor.getString(mimeIndex));+						}+					}+					int sizeIndex = cursor.getColumnIndex(OpenableColumns.SIZE);+					if (!cursor.isNull(sizeIndex)) {+						map.putInt(FIELD_SIZE, cursor.getInt(sizeIndex));+					} 				}+			} -				if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {-					int mimeIndex = cursor.getColumnIndex(DocumentsContract.Document.COLUMN_MIME_TYPE);-					if (!cursor.isNull(mimeIndex)) {-						map.putString(FIELD_TYPE, cursor.getString(mimeIndex));-					}+			if (copyTo != null) {

would it be possible to extract this code block into an independent, nicely named function for better readability?

r0b0t3d

comment created time in 20 days

push eventreact-native-dialogs/react-native-dialogs

dependabot[bot]

commit sha 8653282ee0fb6f8d3516f4a9b5d04f359504f4d2

Bump lodash from 4.17.15 to 4.17.19 (#132) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 19 days

PR merged react-native-dialogs/react-native-dialogs

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 19 days

Pull request review commentfacebook/react-native

improve "not a registered callable module" error message

 class MessageQueue {     const moduleMethods = this.getCallableModule(module);     invariant(       !!moduleMethods,-      'Module %s is not a registered callable module (calling %s)',-      module,-      method,+      `Module ${module} is not a registered callable module (calling ${method}). This can happen when the application entry file path is incorrect.+      On Android, verify 'getJSMainModuleName()' in 'MainApplication.java' and 'project.ext.react.entryFile' in 'android/app/build.gradle'.+      On iOS, verify '- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge' in 'AppDelegate.m' and 'ENTRY_FILE' env. variable passed to 'react-native-xcode.sh' (if any) in 'Build Phases' -> 'Bundle React Native code and images'.

@fkgozali I updated the message, please let me know if this is ok or not. Thanks

vonovak

comment created time in 22 days

push eventvonovak/eslint-plugin-react-native-a11y

Vojtech Novak

commit sha acee778d097fb57776b52681dc4987d64e4fe1fb

allow accessibilityState to be undefined

view details

push time in 22 days

issue closedvonovak/react-navigation-header-buttons

ActionSheetIOS is missing in react-native-web >= 0.12.0

When using react-native-web package I get the error

Module not found: Can't resolve 'react-native-web/dist/exports/ActionSheetIOS'

which points to file react-navigation-header-buttons/src/overflowMenuPressHandlers.js. Since react-native-web package >= version 0.12.0 the export of ActionSheetIOS was removed. Could this be fixed?

closed time in 22 days

chrda81

issue commentvonovak/react-navigation-header-buttons

ActionSheetIOS is missing in react-native-web >= 0.12.0

hello, on web you can only use overflowMenuPressHandlerDropdownMenu (see https://github.com/vonovak/react-navigation-header-buttons#overflowmenu).

regarding removal of ActionSheetIOS from react-native web, nothing can be done about that, you need to provide your own implementation

you can pass your own custom handler, eg. @expo/react-native-action-sheet as seen in https://github.com/vonovak/react-navigation-header-buttons/blob/master/example/screens/UsageCustomOverflow.tsx

hope this helps!

chrda81

comment created time in 22 days

push eventvonovak/react-native

Valentin Shergin

commit sha b72d6768e0228792a30d1cd3874e99361a3c7f60

Fabric: Automatic removing outstanding Surface on Scheduler destruction; gated. Summary: This is an addition to an automatic emergency clean-up algorithm that we have in Scheduler. In addition to committing empty surfaces, we also remove those surfaces from the registry making calling stuff on them impossible. Removing surfaces waits for all commits in flight to be finished, so it theoretically can deadlock (so we gated that). If we won't face deadlocks in a coming couple of weeks, I would remove gating. Changelog: [Internal] Fabric-specific internal change. Reviewed By: mdvacca Differential Revision: D21610683 fbshipit-source-id: 71feeaa0ee4521a0180cdfba6e3a271e7f7d9401

view details

Tim Yung

commit sha 8ac467c51b94c82d81930b4802b2978c85539925

Pressable: Add Support for Inspector Overlay Summary: Adds support for the debug overlay (enabled via the Inspector) that the legacy touchable components supported. Changelog: [General][Added] - Added Inspector overlay support for Pressable Reviewed By: TheSavior Differential Revision: D21614412 fbshipit-source-id: b884e04f8dba1bfd35e61de25d33d6d47bc34b03

view details

duan

commit sha 7b61a968fd774a6ca2196a731b6cec4282ab25cc

set`NSAllowsArbitraryLoads` to false by default in template (#28885) Summary: Since we already have `localhost` as`Exception Domains` in NSAppTransportSecurity to allow connect to dev server, the template should set `NSAllowsArbitraryLoads` to false by default, as exaplained in [Apple's document](https://developer.apple.com/documentation/bundleresources/information_property_list/nsapptransportsecurity/nsallowsarbitraryloads) as a good practice. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [enhancement] - set `NSAllowsArbitraryLoads` to `false` by default in template Pull Request resolved: https://github.com/facebook/react-native/pull/28885 Differential Revision: D21624042 Pulled By: shergin fbshipit-source-id: 690afcd037c3f328d293ef4475380a28efd9fee6

view details

David Vacca

commit sha a2e46e43fb980d91542fa9c052183568056a0b79

Extends view flattening algorithm to support flattening of absolute positioned views Summary: This diff extends view flattening algorithm to support flattening of absolute positioned views. changeLog:[Internal] internal change in fabric Reviewed By: shergin Differential Revision: D21614519 fbshipit-source-id: e33a41677a332bb58d5e5dcedbffd614a8416a45

view details

Daniel Weaver

commit sha b4f4f2d33ee6e6161582c7a27ce4fec3c9bfbc41

Update Hermes attribution labels Summary: Internal target attribution update. Changelog: [Internal] Reviewed By: janettec Differential Revision: D21519089 fbshipit-source-id: 1aa1b57f5e1a1405db32f5cfb9973f27a13bcfdf

view details

Valentin Shergin

commit sha 656db7823c9359964a1c7dbbbb778ec804738e58

Fabric: Changes in LayoutableShadowNodeTest Summary: One small test was added. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D21480201 fbshipit-source-id: fd6c050143fcdf27d345ee62e74c4368266e6ce0

view details

Valentin Shergin

commit sha caab26e0c33ab7117abbd18aaee8ddc8bffa29cf

Fabric: Refinement of `LayoutableShadowNode::getRelativeLayoutMetrics` Summary: This diff simplifies the implementation of `LayoutableShadowNode::getRelativeLayoutMetrics`. It fixes a small bug but the most important change is the new interface. Now the function that does measurements accepts a node and a family instead of two nodes. It prevents misuse and misinterpretation of what the function does. The function needs two things to perform measurement: * an ancestor node that defines the tree is being measured and the base node of measurement; * a family of some descendant node being measured relative to the ancestor node. An API that accepts two nodes is misleading because it implies that the given descendant node will be measured (which is not true). Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D21480200 fbshipit-source-id: 9fddc361417fee47bbf66cc7ac2954eb088a3179

view details

Valentin Shergin

commit sha dafa97535208d1fe2d452059ead418f828466583

Fabric: Simplification of `UIManager::getRelativeLayoutMetrics` Summary: Using of the new API makes clear that we don't need to calculate the newest descendant node. Changelog: [Internal] Fabric-specific internal change. Reviewed By: mdvacca Differential Revision: D21480202 fbshipit-source-id: c54998573baffe4a05726e3402da027f052b049a

view details

David Vacca

commit sha a011eaf7e58f8ae043f1de030ce72f22554176b7

Basic implementation of ARTSurfaceView Summary: Basic implementation of ARTSurfaceView (shadow nodes, props and component descriptor) changelog: [Internal] Reviewed By: shergin Differential Revision: D21621484 fbshipit-source-id: 5577989e966a8a97a043454bf9ae1e5602abc3b1

view details

David Vacca

commit sha 12fee9af629f1c890bf8676569cceb1c9103890a

Create basic implementation of Shape Summary: Create basic implementation of Shape (shadow node, props and component descriptor) changelog: [Internal] Internal changes to support art in Fabric Reviewed By: shergin Differential Revision: D21621482 fbshipit-source-id: e5b9bb2812ee92bce625301b7521f0578eaca0ff

view details

David Vacca

commit sha 54adda64eca5be0fdadfa02e9789b11c4ad4692b

Basic implementation of ARTGroupProps Summary: Basic implementation of ARTGroupProps (shadow node, props and component descriptor) changelog: [Internal] Internal changes to support art in Fabric Reviewed By: shergin Differential Revision: D21621480 fbshipit-source-id: 367a479568b8c1a290f3e0f633cc4052a9c95b87

view details

David Vacca

commit sha 7929f674ccc222981907acd246efc184b5a26147

Basic implementation of ARTText Summary: Basic implementation of ARTText (shadow node, props and component descriptor) changelog: [Internal] Internal changes to support art in Fabric Reviewed By: shergin Differential Revision: D21621483 fbshipit-source-id: d0886dc149520af13faa1bb936dfcccab1798c37

view details

Paige Sun

commit sha 1f95c9b62e306fdaf0ef351b02fb79713941259c

iOS: Fix logging lifecycle when image is scrolled out and immediately back in Reviewed By: fkgozali Differential Revision: D21619910 fbshipit-source-id: b94073afaacad45e12d22d593184cea97612fa26

view details

David Vacca

commit sha 04b8c9c925f7443ec24a0b70643942fd315e2a26

Delete local data from Fabric android Summary: LocalData was fully replaced by State, this diff removes dead code thas was previously used to update local Data changelog: [Internal] Internal cleanup on Fabric Android code Reviewed By: shergin Differential Revision: D21621481 fbshipit-source-id: a3e38300a54a85adff9145cdeea1e89dad09103f

view details

Vojtech Novak

commit sha c8ed2dbbb287deed05a8782fb8665c1edf45bbac

get ripple drawables by id (#28600) Summary: While working on recent PRs regarding ripple radius in TouchableNativeFeedbaack and ripple support in Pressable I noticed `ReactDrawableHelper` uses a [discouraged](https://developer.android.com/reference/android/content/res/Resources#getIdentifier(java.lang.String,%20java.lang.String,%20java.lang.String)) way to obtain resources. The attribute names (strings) `'selectableItemBackground'` and `'selectableItemBackgroundBorderless'` are used here https://github.com/facebook/react-native/blob/4a48b021d63a474f1570e92616988384957d4273/Libraries/Components/Touchable/TouchableNativeFeedback.js#L105 And passed to `context.getResources().getIdentifier()` in `ReactDrawableHelper`. Since we know the attribute names beforehand I figured we can obtain the resources by id (fast) instead of by name (slow). I made it so that the slow code path is taken in case the attribute name does not match what is expected, as a fallback. Note that I did not do any measurement of the effect of this, I'm just offering this as a PR. You'll notice that this PR relies on the fact that the string in JS is the same as the string in Java (it is duplicated). While I could export the strings from Java and use them in JS, I wasn't sure where to export them. But note that even before, the JS code depended on the `'selectableItemBackground'` and `'selectableItemBackgroundBorderless'` strings to exist on the native side, in the android SDK, I just made the dependency explicit. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Changed] - get ripple drawables by id Pull Request resolved: https://github.com/facebook/react-native/pull/28600 Test Plan: tested manually in RNTester Differential Revision: D21241773 Pulled By: shergin fbshipit-source-id: 1b8314f99616095cb6ed557c62095cf3200f53b6

view details

Tim Yung

commit sha 4aaf62998247bcfd8ebf369d73290096fde08012

Pressable: Minimum Press Duration Summary: When a `Pressable` has a configured (or the default) `delayPressIn` and no (or the default) `delayPressOut`, tapping very quickly can lead to intantaneous invocation of `onPressIn` and `onPressOut`. The end result is that users may never experience any intended visual press feedback. This changes `Pressable` to accept (and be preconfigured with a default) **minimum press duration**. The minimum press duration ensures that even if the press is released before `delayPressIn` has elapsed, `onPressOut` will still wait the remaining time up to `minPressDuration` before firing. Note that setting a non-zero `delayPressOut` is insufficient because if a user holds down on a `Pressable` for longer than `delayPressIn`, we still want `onPressOut` to fire immediately when the press is released. Changelog: [General][Changed] - Added `minPressDuration` to `Pressable`. Reviewed By: TheSavior Differential Revision: D21614708 fbshipit-source-id: 502f3d8ad6a40e7762435b6df16809c8798dd92c

view details

lukewalczak

commit sha f0bf4b09863f0426dd5f6753fb75a174c6c74cbd

Add possibility to disable buttons in action sheet ios (#28792) Summary: I've noticed that currently there is no option to disable button within the `ActionSheetIOS`. It can be really useful and decided to extend the API to support that functionality. I added a new option called `disabledButtonsIndices` to `ActionSheetIOS` which is an array of button indices which should be disabled. `ActionSheetIOS` documentation - PR https://github.com/facebook/react-native-website/pull/1898 ## Changelog [iOS] [Added] - Add disableButtonsIndices option to ActionSheetIOS component Pull Request resolved: https://github.com/facebook/react-native/pull/28792 Test Plan: 1. Run the `RNTester` 2. Choose `ActionSheetIOS` 3. Check the fourth example `Show Action Sheet with disabled buttons` 4. `Option 1` and `Option 2` should be disabled screenshot | gif --- | --- <img width="493" alt="Screenshot 2020-04-30 at 15 16 22" src="https://user-images.githubusercontent.com/22746080/80739025-1ec52780-8b16-11ea-8b1c-30bb40ad8c99.png"> | ![action_sheet_disabled](https://user-images.githubusercontent.com/22746080/80739043-24227200-8b16-11ea-8bcb-af25eb57baac.gif) Differential Revision: D21396409 Pulled By: shergin fbshipit-source-id: b3c3e442965160e0c5e52854352f0540575c4d4c

view details

Mike Vitousek

commit sha 37e7b41419516d1d03cfd631d6bacef8fd2429a5

deploy Flow 0.125.1 to xplat Summary: Changelog: [Internal] allow-large-files Reviewed By: gkz Differential Revision: D21597387 fbshipit-source-id: dddec43885daa5a9c5c4dfe8e338ecedc9abcd1e

view details

Samuel Susla

commit sha f9e4e246ff0258c99a3c79b3600098b21b3486a4

Prevent SafeAreaView from reporting same size twice Summary: Changelog: [Internal] # Problem We call `_state->updateState` anytime safe area insets changes. Once that is called, `_state` still holds old value, so when we check whether there is big enough of a difference, we are actually checking it against old value of state until `updateState` is called from MountingManager. This causes `_state->updateState` to be called dozens of times (I measured 47, with this diff it fell to 22) when displaying a safe area view inside Modal. # Solution Create new ivar `_lastPaddingStateWasUpdatedWith` where we store last padding that was sent through `_state->updateState` and compare new inset with this value instead of last value stored in state. Reviewed By: shergin Differential Revision: D21596367 fbshipit-source-id: b9249b8ef444ea532ec8b86a15a32c733eb6f987

view details

Samuel Susla

commit sha 351a9f10476160eedc44e9d047f8841df12b86d5

Copy alreadyAppliedPadding when cloning SafeAreaViewShadowNode Summary: Changelog: [Internal] `SafeAreaViewShadowNode.alreadyAppliedPadding` was always {0, 0, 0, 0} because value of previous shadow node was never copied over to new shadow node during clone. Reviewed By: shergin Differential Revision: D21617361 fbshipit-source-id: 6d6c91b19ff60271bf7c48145d85faaee0321680

view details

push time in 24 days

push eventvonovak/react-native

Vojtech Novak

commit sha 590987f7941a4402651c9c344cf96e27133bba1b

change the error message

view details

push time in 24 days

delete branch Elyx0/react-native-document-picker

delete branch : @vonovak/sponsor

delete time in 24 days

startedMonitorControl/MonitorControl

started time in 25 days

pull request commentnotifee/react-native-notifee

fix(react-native): app project is evaluated first

@Salakar I confirm this works for me

russellwheatley

comment created time in a month

pull request commentfacebook/react-native

improve "not a registered callable module" error message

hello, @fkgozali I heard you might be the right person to review, would you mind taking a look at this? Thank you in advance! :)

vonovak

comment created time in a month

startedIjzerenHein/react-native-bundle-visualizer

started time in a month

issue commentvonovak/react-native-simple-toast

Is there any way to specify position of the toast ?

hello there's no such way currently, but a PR for this would be accepted

NeerajNegi

comment created time in a month

push eventreact-native-community/datetimepicker

Vojtech Novak

commit sha e3289e7b94732787fa1bea83a38ce771624a6727

update changelog

view details

Vojtech Novak

commit sha 488bedac6a41ccb8c6b34d2a07824de6fd77f47a

2.6.0

view details

push time in a month

created tagreact-native-community/datetimepicker

tagv2.6.0

React Native date & time picker component for iOS, Android and Windows

created time in a month

more