vikstrous ( Viktor Stanchev )

commit sha e2f10a2e6dde976bdb9e46ab5fc25b8e3ddf2807

Update golangci/golangci-lint Docker tag to v1.31.0

commit sha 18db9507cb13f93f677fc456f779fa83142af249

newlines fix

commit sha 4fdc33f24ebdf4b75510f9345c645c09cc568741

newlines fix

push time in 23 days

PR merged vikstrous/mvpkg

Update golangci/golangci-lint Docker tag to v1.31.0

This PR contains the following updates:

Package	Type	Update	Change
golangci/golangci-lint	docker	minor	`v1.29.0` -> `v1.31.0`

Renovate configuration

:date: Schedule: "on the first day of the month" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -1

3 commit in vikstrous/mvpkg/tree/renovate/docker-golangci-golangci-lint-1.x vikstrous/mvpkg/tree/master

1 comment

3 changed files

renovate[bot]

pr closed time in 23 days

push eventvikstrous/mvpkg

commit sha c7fb14ce0f2a24a5e080d3a9d0193255f8ef6da1

newlines fix

push time in 23 days

push eventvikstrous/mvpkg

commit sha 07fb98e71d255a301f33c274ab8f932dd5beb936

newlines fix

push time in 23 days

delete branch vikstrous/mvpkg

delete branch : renovate/golang.org-x-tools-digest

delete time in 23 days

push eventvikstrous/mvpkg

commit sha ec363bc5003fd1c11277994970e46cb7b77672ab

Update golang.org/x/tools commit hash to 39188db

push time in 23 days

PR merged vikstrous/mvpkg

Update golang.org/x/tools commit hash to 39188db

This PR contains the following updates:

Package	Type	Update	Change
golang.org/x/tools	require	digest	`b5fad4e` -> `39188db`

Renovate configuration

:date: Schedule: "on the first day of the month" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+6 -1

1 commit in vikstrous/mvpkg/tree/renovate/golang.org-x-tools-digest vikstrous/mvpkg/tree/master

1 comment

2 changed files

renovate[bot]

pr closed time in 23 days

delete branch vikstrous/mvpkg

delete branch : renovate/docker-circleci-golang-1.x

delete time in 23 days

push eventvikstrous/mvpkg

commit sha 17a5c504dfde80242fc4854d08759cb72fef7275

Update circleci/golang Docker tag to v1.15

push time in 23 days

PR merged vikstrous/mvpkg

Update circleci/golang Docker tag to v1.15

This PR contains the following updates:

Package	Type	Update	Change
circleci/golang	docker	minor	`1.14` -> `1.15`

Renovate configuration

:date: Schedule: "on the first day of the month" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

1 commit in vikstrous/mvpkg/tree/renovate/docker-circleci-golang-1.x vikstrous/mvpkg/tree/master

1 comment

1 changed file

renovate[bot]

pr closed time in 23 days

PullRequestReviewEvent

issue commentgo-swagger/go-swagger

I prefer the new behaviour. It makes sense to use an absolute path. The old behaviour seems to have been to guess the path based on the package name, which can be ambiguous.

vikstrous

comment created time in 2 months

issue commentgo-swagger/go-swagger

ok, we were using only the name of the package without a full path in the --principal parameter, which seems to have worked before for some mysterious reason (goimports?) and now it doesn't work any more. The --principal parameter needs a full package path

vikstrous

comment created time in 2 months

issue closedgo-swagger/go-swagger

Problem statement

After upgrading from 0.24.0 to 0.25.0, aliased principal types are now being replaced by the types that they are aliases of. This breaks the generated code because it leads to importing /internal/ packages.

This is the diff in our generated code that resulted from the upgrade:

import (
        "net/http"

-       "<redacted>/lib/auth"
        "github.com/go-openapi/runtime/middleware"
+
+       "<redacted>/service/<redacted>/internal/<redacted>/auth"
 )

Swagger specification

hopefully not relevant

Steps to reproduce

Upgrade from 0.24.0 to 0.25.0. Command run:

go run github.com/go-swagger/go-swagger/cmd/swagger generate server --target ./generated --name <redacted> --spec ./<redacted>.yaml --exclude-main -q --principal=auth.<redacted>

Environment

swagger version: 0.25.0 go version: go1.14.4 OS: linux/amd64

closed time in 2 months

vikstrous

issue commentgo-swagger/go-swagger

Sorry, looks like I completely misunderstood the problem. It seems like the issue is with the interpretation of the principal's path. There's no alias involved. I'll close this for now while I investigate this properly.

vikstrous

comment created time in 2 months

issue openedgo-swagger/go-swagger

Problem statement

After upgrading from 0.24.0 to 0.25.0, aliased principal types are now being replaced by the types that they are aliases of. This breaks the generated code because it leads to importing /internal/ packages.

This is the diff in our generated code that resulted from the upgrade:

import (
        "net/http"

-       "<redacted>/lib/auth"
        "github.com/go-openapi/runtime/middleware"
+
+       "<redacted>/service/<redacted>/internal/<redacted>/auth"
 )

Swagger specification

hopefully not relevant

Steps to reproduce

Upgrade from 0.24.0 to 0.25.0. Command run:

go run github.com/go-swagger/go-swagger/cmd/swagger generate server --target ./generated --name <redacted> --spec ./<redacted>.yaml --exclude-main -q --principal=auth.<redacted>

Environment

swagger version: 0.25.0 go version: go1.14.4 OS: linux/amd64

created time in 2 months

delete branch vikstrous/mvpkg

delete branch : renovate/golang.org-x-tools-digest

delete time in 2 months

push eventvikstrous/mvpkg

commit sha 8b3dc078bae2dc6c2331a2d01dc6b5d13209a38e

Update golang.org/x/tools commit hash to b5fad4e

push time in 2 months

PR merged vikstrous/mvpkg

Update golang.org/x/tools commit hash to b5fad4e

This PR contains the following updates:

Package	Type	Update	Change
golang.org/x/tools	require	digest	`6123e77` -> `b5fad4e`

Renovate configuration

:date: Schedule: "on the first day of the month" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+3 -1

1 commit in vikstrous/mvpkg/tree/renovate/golang.org-x-tools-digest vikstrous/mvpkg/tree/master

1 comment

2 changed files

renovate[bot]

pr closed time in 2 months

issue commentThreeDotsLabs/watermill

Sagas support

What are your thoughts on how sagas should work with watermill? It seems to me that it's pretty simple to implement a choreograpy based saga using the existing features of watermill. To implement an orchestration based saga, wouldn't you just not use watermill at all? Doesn't it make more sense to implement an orchestration based saga by just creating a service that stores its state in a database (or even filesystem) and logs its progress there without the need for events or pub/sub or anything fancy?

roblaszczak

comment created time in 2 months

startedThreeDotsLabs/watermill

started time in 2 months

push eventvikstrous/mvpkg

commit sha a3cb522b5f8da1d7115d94cdf16fc802468e5fb6

check in some editor configs and clean up go.mod

push time in 2 months

delete branch vikstrous/mvpkg

delete branch : better-tests

delete time in 2 months

push eventvikstrous/mvpkg

commit sha 13640e8069c5753d6a380b4936f45463aa477748

add new test pattern

push time in 2 months

PR merged vikstrous/mvpkg

add new test pattern

+84 -0

1 commit in vikstrous/mvpkg/tree/better-tests vikstrous/mvpkg/tree/master

1 comment

9 changed files

vikstrous

pr closed time in 2 months

push eventvikstrous/mvpkg

commit sha 103a82c903261e29bc86a90002203f98d3736aad

add new test pattern

push time in 2 months

PR opened vikstrous/mvpkg

add new test pattern

+84 -0

1 commit in vikstrous/mvpkg/tree/better-tests vikstrous/mvpkg/tree/master

0 comment

9 changed files

pr created time in 2 months

create barnchvikstrous/mvpkg

branch : better-tests

created branch time in 2 months

push eventvikstrous/mvpkg

commit sha 84e555fde8172cca7476b9e838181817d1d575fb

Update renovate.json

push time in 2 months

delete branch vikstrous/mvpkg

delete branch : renovate/golang.org-x-tools-digest

delete time in 2 months

push eventvikstrous/mvpkg

commit sha 3b376f539ce951432d4cd0777b1de2d574da73c3

Update golang.org/x/tools commit hash to 6123e77

push time in 2 months

PR merged vikstrous/mvpkg

Update golang.org/x/tools commit hash to 6123e77

This PR contains the following updates:

Package	Type	Update	Change
golang.org/x/tools	require	digest	`134513d` -> `6123e77`

Renovate configuration

:date: Schedule: "every weekend" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+3 -1

1 commit in vikstrous/mvpkg/tree/renovate/golang.org-x-tools-digest vikstrous/mvpkg/tree/master

1 comment

2 changed files

renovate[bot]

pr closed time in 2 months

delete branch vikstrous/mvpkg

delete branch : renovate/docker-golangci-golangci-lint-1.x

delete time in 2 months

push eventvikstrous/mvpkg

commit sha 02b2fff36344df60cac3b8b28f1162653ef7a60e

Update golangci/golangci-lint Docker tag to v1.29.0

commit sha 90948f612da5115b478c7fa78568b652dd10f662

fix lint

push time in 2 months

PR merged vikstrous/mvpkg

Update golangci/golangci-lint Docker tag to v1.29.0

This PR contains the following updates:

Package	Type	Update	Change
golangci/golangci-lint	docker	minor	`v1.27.0` -> `v1.29.0`

Renovate configuration

:date: Schedule: "every weekend" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+9 -6

2 commit in vikstrous/mvpkg/tree/renovate/docker-golangci-golangci-lint-1.x vikstrous/mvpkg/tree/master

0 comment

3 changed files

renovate[bot]

pr closed time in 2 months

push eventvikstrous/mvpkg

commit sha 2a9d188648085765bad14f2daeeb20aad4fd6839

fix lint

push time in 2 months

push eventvikstrous/mvpkg

commit sha bfa9dc85c8f43fa91b74f40ee43507debd1b9f44

Update golang.org/x/tools commit hash to 134513d

branch : 0.11.3-unreachable

push time in 3 months

PR merged vikstrous/mvpkg

Update golang.org/x/tools commit hash to 134513d

This PR contains the following updates:

Package	Type	Update	Change
golang.org/x/tools	require	digest	`a32c0cb` -> `134513d`

Renovate configuration

:date: Schedule: "every weekend" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+9 -1

1 commit in vikstrous/mvpkg/tree/renovate/golang.org-x-tools-digest vikstrous/mvpkg/tree/master

1 comment

2 changed files

renovate[bot]

pr closed time in 3 months

create barnchvikstrous/gqlgen

created branch time in 3 months

push eventvikstrous/gqlgen

commit sha 91b9ff4f1f45e8beb339162a9d4ecac61a55c1fe

remove unreachable types from generated code

push time in 3 months

push eventvikstrous/gqlgen

commit sha dd03f3cbd8f854de25348472304156acb1130078

remove unreachable types from generated code

push time in 3 months

PR opened 99designs/gqlgen

fix #1237 remove unreachable types from generated code

Describe your PR and link to any relevant issues.

I have:

[ ] Added tests covering the bug / feature (see testing)
[ ] Updated any relevant documentation (see docs)

+372 -1103

1 commit in vikstrous/gqlgen/tree/unreachable 99designs/gqlgen/tree/master

0 comment

13 changed files

pr created time in 3 months

push eventvikstrous/gqlgen

commit sha daaec457eeac670769dddcc4fdb79fc362778626

remove unreachable types from generated code

remove unreachable types/resolvers from generated code

push time in 3 months

create barnchvikstrous/unreachable-repro

branch : master

created branch time in 3 months

created repositoryvikstrous/unreachable-repro

Example of

created time in 3 months

issue opened99designs/gqlgen

What happened?

I have a number of graphql files that hold shared type definitions from multiple backends. Not every backend uses every type, but it's convenient to be able to deduplicate them in cases where they are shared.

Unfortunately, currently, this results in every backend being forced to generate resolvers for every type.

What did you expect?

I expected that unreachable types don't need to be implemented and don't affect the output of gqlgen.

Minimal graphql.schema and models to reproduce

https://github.com/vikstrous/unreachable-repro

versions

gqlgen version: master
go version: 1.14.4
dep or go modules: go modules

Other

Note that this is not just a slight annoyance. In order to split up our graphql schema and move towards federation, we need to be able to take chunks out of the main common schema one at a time. With multiple different services re-implementing the same graphql resolvers, we would have to duplicate our schema 5 times as the first step towards federation. It's very hard to do this at scale and having this feature in gqlgen would really simplify our transition.

created time in 3 months

push eventvikstrous/gqlgen

commit sha 49b1655b89907e35535240500b6beaa71d8e4712

fix internal

push time in 3 months

create barnchvikstrous/gqlgen

branch : unreachable

created branch time in 3 months

push eventvikstrous/mvpkg

commit sha b8cc0845a06bbc4e77a7f7e418833e81443d810f

Update golang.org/x/tools commit hash to a32c0cb