profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/unknwon/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Joe Chen unknwon @sourcegraph Hangzhou, China https://unknwon.io Wild kid in the junkyard.

unknwon/go-fundamental-programming 7887

《Go 编程基础》是一套针对 Google 出品的 Go 语言的视频语音教程,主要面向新手级别的学习者。

unknwon/go-study-index 4599

Go 语言学习资料索引

unknwon/go-web-foundation 2626

《Go Web 基础》是一套针对 Google 出品的 Go 语言的视频语音教程,主要面向完成《Go 编程基础》教程后希望进一步了解有关 Go Web 开发的学习者。

unknwon/go-rock-libraries-showcases 1575

《Go名库讲解》是一套针对 Google 出品的 Go 语言的第三方库进行评测讲解的集博客、示例与语音视频为一体的综合教程,适合完成学习完成《Go编程基础》教程的学习者。

studygolang/GCTT 1303

GCTT Go中文网翻译组。

unknwon/com 701

This is an open source project for commonly used functions for the Go programming language.

unknwon/gowalker 646

Go Walker is a server that generates Go projects API documentation on the fly.

unknwon/goconfig 576

Package goconfig is a fully functional and comments-support configuration file (.ini) parser.

unknwon/building-web-applications-in-go 573

Go 语言 Web 应用开发系列教程,从新手到双手残废

unknwon/bra 379

Bra (Brilliant Ridiculous Assistant) is a command line utility tool.

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsourcegraph/sourcegraph

FIX: Add primary email when user has no email

 func (r *schemaResolver) AddUserEmail(ctx context.Context, args *struct { 	if err != nil { 		return nil, err 	}+	+	emails, err := database.GlobalUserEmails.ListByUser(ctx, database.UserEmailsListOptions{+		UserID: userID,+	})+	 	if err := backend.UserEmails.Add(ctx, r.db, userID, args.Email); err != nil { 		return nil, err 	}+	+	// If user has no existing email, the added email will be set as the primary email+	if len(emails) == 0 {+		// email needs to exist and be verified to be set as the primary email+		if err := database.UserEmails(r.db).SetVerified(ctx, userID, args.Email, true); err != nil {

I believe when site admin create a user with email added

This assumption is not true at all time, with this change, users can now add arbitrary emails and these emails become verified without being actually verified.

I think this is not the right place to set primary email, and that should happen when user verified an email, and when that email happens to be the only email, we then set the email to be the primary email automatically.

abeatrix

comment created time in 2 days

PullRequestReviewEvent

push eventunknwon/unknwon.cn

Joe Chen

commit sha 3637227f110f7af372f58a6cacfb02f0ee76a67d

Update about.md

view details

push time in 2 days

push eventunknwon/unknwon.cn

Joe Chen

commit sha 784eddd060c2304387bfa1059108c4f044e8c2f9

Update about.md

view details

push time in 2 days

issue commentgo-ini/ini

Project referencing itself with gopkg.in/ini.v1 causes double entries in the go mod file.

You may pull down https://github.com/go-ini/ini/releases/tag/v1.63.2, which should no longer have "gopkg.in/ini.v1" in your dependency tree.

myusuf3

comment created time in 2 days

release go-ini/ini

v1.63.2

released time in 2 days

created taggo-ini/ini

tagv1.63.2

Package ini provides INI file read and write functionality in Go

created time in 2 days

push eventgo-ini/ini

Joe Chen

commit sha 14e9811b1643cf01ea36277e44dffef4f119fa31

test: rename package to be same as the main (#304)

view details

push time in 2 days

delete branch go-ini/ini

delete branch : jc/rename-test-package

delete time in 2 days

PR merged go-ini/ini

test: rename package to be same as the main

Fixes #292

+238 -262

1 comment

9 changed files

unknwon

pr closed time in 2 days

issue closedgo-ini/ini

Project referencing itself with gopkg.in/ini.v1 causes double entries in the go mod file.

Describe the bug We are seeing weird import paths for a dependencies that uses this project. Looks like go mod doesn't ignore test files when we are building the dependency graph.

We are seeing the following

go mod why gopkg.in/ini.v1
# gopkg.in/ini.v1
github.com/aws/aws-sdk-go/aws/session
github.com/go-ini/ini
github.com/go-ini/ini.test
gopkg.in/ini.v1

As you can see the dependency chain ends correct here.

go mod why github.com/go-ini/ini
# github.com/go-ini/ini
github.com/aws/aws-sdk-go/aws/session
github.com/go-ini/ini

To Reproduce Simply rely on go-ini/ini and run a go mod tidy and see two imports for the same project.

Expected behavior We should only see one import for the dependency.

closed time in 2 days

myusuf3

PR opened go-ini/ini

test: rename package to be same as the main

Fixes #292

+238 -262

0 comment

9 changed files

pr created time in 2 days

create barnchgo-ini/ini

branch : jc/rename-test-package

created branch time in 2 days

pull request commentgo-ini/ini

all: rewrite tests to use testify instead of goconvey

Here you go: https://github.com/go-ini/ini/releases/tag/v1.63.1

sagikazarmark

comment created time in 3 days

release go-ini/ini

v1.63.1

released time in 3 days

created taggo-ini/ini

tagv1.63.1

Package ini provides INI file read and write functionality in Go

created time in 3 days

push eventgo-ini/ini

Joe Chen

commit sha fd697c7bd637c12e4a968b717d151f9bf9675d78

ci: workaround to make lint work (#303)

view details

push time in 3 days

delete branch go-ini/ini

delete branch : jc/fix-golangci

delete time in 3 days

PR merged go-ini/ini

ci: workaround to make lint work
+1 -2

1 comment

2 changed files

unknwon

pr closed time in 3 days

issue closedgo-ini/ini

Add support for go modules

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Hi, am using Go 1.15.5 and I would like to add this library as a dependency for my project.

Describe the solution you'd like A clear and concise description of what you want to happen.

Adopt https://blog.golang.org/using-go-modules

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

I can do the work, just let me know the module name.

closed time in 3 days

domust

issue commentgo-ini/ini

Add support for go modules

This package can't have Go Modules because Go Modules do not allow two different import paths. This package has been widely referenced by both gopkg.in/ini.v1 and github.com/go-ini/ini.

Once there is a change to release v2, then we can have Go Modules.

domust

comment created time in 3 days

issue closedgo-ini/ini

can't parse “#”

Describe the bug when I use the go-ini package parse the ini config file , but it can't parse the character “#”

for example: It parse the password failed, the password contain the character "#"

image my password is test123456#@, but it parse it to test123456

closed time in 3 days

Boblis

push eventgo-ini/ini

ᴜɴᴋɴᴡᴏɴ

commit sha 7bfce6513ee233dc5560a75057aeea2cc8148731

Fix lint

view details

push time in 3 days

PR merged go-ini/ini

all: rewrite tests to use testify instead of goconvey

What problem should be fixed?

Fixes #295

Have you added test cases to catch the problem?

This PR is about refactoring tests, no additional tests are necessary.

Notes for reviewer

This is an attempt to refactor tests into using testify instead of goconvey.

During the refactor I followed the following rules:

  • Singular top level Convey was removed everywhere
  • Multiple Convey blocks were converted into subtests (t.Run)
  • Child Convey blocks were converted into subtests (t.Run)
  • require was used everywhere when the following assertions depended on the outcome (eg. no error or no nil return value)
  • assert was used everywhere else

I suggest turning off showing whitespaces in the diff because there are lots of indentation changes.

If you like the result, I can refactor the remaining tests as well.

+1531 -1474

10 comments

8 changed files

sagikazarmark

pr closed time in 3 days

push eventgo-ini/ini

Márk Sági-Kazár

commit sha bba62c3754bab836d75db85f1bd1bdff980fb9ad

all: rewrite tests to use testify instead of goconvey (#300)

view details

push time in 3 days

issue closedgo-ini/ini

github.com/smartystreets/goconvey v1.6.4 // indirect

please remove indirect test dependency from product code

closed time in 3 days

zqfan

pull request commentgo-ini/ini

all: rewrite tests to use testify instead of goconvey

OK, looks like that's a file somewhere on main, not related to this PR, merging!

sagikazarmark

comment created time in 3 days